/[MITgcm]/MITgcm/doc/tag-index
ViewVC logotype

Diff of /MITgcm/doc/tag-index

Parent Directory Parent Directory | Revision Log Revision Log | View Revision Graph Revision Graph | View Patch Patch

revision 1.1590 by jmc, Sat Feb 4 17:25:23 2012 UTC revision 1.1726 by jmc, Tue Aug 28 21:13:08 2012 UTC
# Line 4  $Name$ Line 4  $Name$
4      Notes on tags used in MITgcmUV      Notes on tags used in MITgcmUV
5      ==============================      ==============================
6    
7    o tools/genmake2:
8      - define variable MAKE within Makefile and use it in place of 'make';
9      - update AD_CONFIG.h (if needed) before building any of the executable
10        (forward, adjoint or tangent-lin); this involves a 2nd invocation of make;
11        and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h;
12      - always print usual warning comment 'this file is automatically generated'
13        from script convert_cpp_cmd2defines (+ remove this warning from genmake2).
14    o pkg/exf:
15        added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch.
16        ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F)
17        and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h).
18    o pkg/exf, autodiff, ctrl, ecco and seaice:
19        remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones.
20    o pkg/ctrl, ecco:
21        allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL.
22        Depending on useAtmWind, one is inactive, and the other is active (see
23        exf_getffields.F/exf_getsurfacefluxes.F).
24    o tools/genmake2:
25      - improve error msg when failing in 2nd test of check_for_broken_Ff
26      - fix option '-makefile' short-name (-mf according to genmake2 -help)
27      - source local config file "genmake_local" just after processing the genmake2
28        command arguments (previously done before processing arg).
29    o pkg/grdchk:
30      - add a call to TURNOFF_MODEL_IO for Tangent-Linear run (in this case, call
31        to this routine from cost_final has been dropped in g_cost_final)
32      - improve printed information (more explicit msg, no longer using "print *,"
33         fix fcpertminus printed value).
34    o model/src:
35      - move call to COST_INIT_VARIA out of packages_init_variables.F directly
36        into initialise_varia.F (just after calling PACKAGES_INIT_VARIABLES):
37        this prevents getting cost-funct reset in adinitialise_varia recomputations.
38    o pkg/dic:
39      - move initialisation of "freefe" array from from dic_biotic_forcing.F to
40        fe_chem.F: this prevents TAF from dropping this initialisation in TLM code.
41    o pkg/grdchk:
42      - grdchk_main.F : added CALL GLOBAL_SUM_INT( ierr , myThid )
43      - grdchk_getadxx.F etc. : omit I/O if ierr.EQ.0
44    o pkg/autodiff/ctrl/grdchk :
45      - attempt to sort out what works and what does not,
46        with regard to I/O, and to warn/stop accordingly.
47    o pkg/grdchk:
48      - attempt to fix grdchk in the case of useSingleCpuIO.
49      - "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )"
50       statements were moved from grdchk_main.F and into
51       grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F.
52      - a global sum is applied to record numbers icvrec/layer
53       out of grdchk_loc so that they be passed to I/O routines.
54    o pkg/smooth:
55      - fix recomputation that appeared with nlfs : use smooth_recip_hFacC,
56        smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case.
57    o verification/testreport:
58      - add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive);
59      - can also use compressed (gzip) reference output file;
60      - change format (in pkg/grdchk) of TLM output (+ add forward gradient)
61        to be easier to collect by testreport.
62      - update existing TLM output (half out-of-date by more than 3 yrs).
63      - report NETCDF & LAPACK settings (from genmake2) in output dir.
64      - report run-time in each individual summary (previously only for AD test);
65        for TLM test, add also TAF version.
66      - add daily TLM test on (old) aces cluster + weekly test on baudelaire.
67    
68    checkpoint63r (2012/08/15)
69    o tools/genmake2:
70      - fix Makefile for target ftlall (+ update files to clean after make ftlall)
71    o pkg/ecco/ecco_cost_final.F :
72      - fix fc print statements (to stdout and costfunction0000) so
73        that the printed value is always after the global sum.
74    o pkg/seaice/seaice_dynsolver.F :
75      - fix ice strength assymptote at SEAICE_area_max<1
76        (no change for the standard case of SEAICE_area_max=1)
77    o some cleaning:
78      - pkg source files: ensure that all *.F files from each pkg included the
79        corresponding ${PKG}_OPTIONS.h file (except stand-alone src file which
80        only includes CPP_EEOPTIONS.h); fix S/R CTRL_SMOOTH ; update AD experiment
81        code_ad/*.F src files; add new option-file in pkg/admtlm + corresponding
82        includes;
83      - model/src: add PACKAGES_CONFIG.h wherever ALLOW_AUTODIFF[_TAMC] is used.
84      - ALLOW_DIFFKR_CONTROL: add a stop in S/R CTRL_CHECK in case ALLOW_3D_DIFFKR
85        is undef; also define /DYNVARS_DIFFKR/ common block in DYNVARS.h when
86        ALLOW_DIFFKR_CONTROL is defined, to allow to compile and reach this stop.
87      - update option-file CPP_OPTIONS.h of all AD experiments:
88        * no longer include PACKAGES_CONFIG.h ;
89        * includes ECCO_CPPOPTIONS.h if PACKAGES_CONFIG.h has been included ;
90        * def/undef ALLOW_3D_DIFFKR independently of ALLOW_DIFFKR_CONTROL (before
91          including ECCO_CPPOPTIONS.h).
92    o pkg/cost, pkg/ctrl, pkg/ecco option-file:
93      - clean-up and split content of old pkg/ecco/ECCO_CPPOPTIONS.h file into
94        separated pkg option-file (done according to old doc from ECCO_CPPOPTIONS.h,
95        not necessary accurate).
96      - add a template for option-file ECCO_CPPOPTIONS.h, mostly empty, in
97        pkg/autodiff, i.e., the 1rst pkg to compile for adjoint built, with lines to
98        deliberately break compilation (a remainder that it needs to be customized)
99      - in pkg/ecco, includes ECCO_OPTIONS.h instead of COST_OPTIONS.h
100      - rename COST_CPPOPTIONS.h to COST_OPTIONS.h
101      - rename CTRL_CPPOPTIONS.h to CTRL_OPTIONS.h
102    o tools/genamke2:
103      - check for lapack.
104    o pkg/cost and pkg/ecco : attempt to sort out some of the limiting intricacies.
105      - pkg/cost.cost_final.F : allow for use of pkg/ecco and pkg/cost cost functions
106        jointly. The exclusive ifdefs were removed, to add costs terms (when defined)
107        from both packages.
108      - the fc global sum in pkg/ecco/ecco_cost_final.F was removed accordingly.
109      - for objf_atl we use either the pkg/ecco or the pkg/cost term depending on CPPs.
110      - pkg/ecco and model/src : add CPP brackets around pkg/cost and pkg/ctrl includes
111        of "CTRL_SIZE.h" "ctrl.h" "ctrl_dummy.h" "optim.h" / "cost.h" accordingly.
112    o pkg/cost : add comments to explain special and/or untested setups.
113    o pkg/exf:
114      - use EXF_OPTIONS.h to set pkg/exf options except if done in ECCO_CPPOPTIONS.h
115        (previously, ALLOW_AUTODIFF_TAMC was controling this switch).
116    o verification/*/code_ad:
117      mimimal cleaning of AD experiments ECCO_CPPOPTIONS.h option-file:
118      - reccord when this file is included (define ECCO_CPPOPTIONS_H)
119      - remove the most obvious obsolete features (e.g., #define ALLOW_COST not
120        allowed since Oct 2003 in any option-file except in PACKAGES_CONFIG.h)
121    o pkg/seaice :
122      - added possibility to change ice strength/PRESS0 relationship to
123        HEFF, according to the following run time parameters
124        SEAICEpresPow0 :: HEFF exponent for ice strength below SEAICEpresH0 (integer, >0)
125        SEAICEpresPow1 :: HEFF exponent for ice strength above SEAICEpresH0 (integer, >0)
126        SEAICEpresH0   :: HEFF threshold for ice strength            (m)
127    o pkg/ggl90 :
128      - added run time flag mxlSurfFlag to include the code that ensure
129        mixing between first and second level (previously included as a comment)
130    o verification/1D_ocean_ice_column/input_ad/data.autodiff :
131      - add test of newly added dumpAdByRec=T option where
132        we write all records to one file per variable.
133    o verification/global_ocean.cs32x15/code_ad/CPP_OPTIONS.h :
134      - switch to #define ALLOW_BALANCE_RELAX and ALLOW_BALANCE_FLUXES
135        to check that this code is ok with taf and compiles in adjoint.
136    o pkg/autodiff :
137      - added run time param dumpAdByRec : ad dump format switch.
138        If true then write all records to one file per variable.
139        Else write one file per record (remains the default).
140      - revise seaice_ad_dump.F and exf_adjoint_snapshots_ad.F accordingly.
141    o pkg/seaice:
142     - Added SEAICEuseTILT run time switch : if set to
143       false then omit the tilt term in seaice dynamics.
144     - Fix free drift calculation.
145    o pkg/shelfice:
146      When initializing SHELFICEDragQuadratic, set default to be
147      consistent with shiCdrag in case SHELFICEuseGammaFrict is used,
148      but retain option to set it independently
149      (inconsistenty spotted by Veronique Dansereau)
150    o eesupp/inc:
151      - in EEPARAMS.h, add real-type constant for some frequently used simple number
152         (0,1,2,1/2), with name explicitly referring to RS/RL type.
153    o model/src:
154      - move balancing of relaxation terms to new S/R balance_relax.F.
155    o pkg/autodiff:
156      re-write active I/O high-level (control) S/R:
157      - rename  S/R ACTIVE_READ/WRITE_RL to ACTIVE_READ/WRITE_3D_RL
158      - add 1 more argument (useCurrentDir) to replace the "_LOC" 2nd set of S/R.
159      - use standard pkg/mdsio I/O routines (MDS_READ/WRITE_SEC_XZ/YZ  and
160        MDS_READ/WRITE_FIELD); change loops to multi-threads.
161      - update and merge active_file_control_slice.flow into active_file_control.flow
162      - update the calls in lower level S/R (active_file.F, active_file_g.F and
163        active_file_ad.F) keeping the argument list and function unchanged.
164      - also update lower-level "_LOC" version (call same S/R with "useCurrentDir
165        =.TRUE.") and remove high-level (control) _loc version (not called anymore).
166      - new low-level active I/O routines, one for each type (RL/RS), for active var
167        of various (XY,XZ,YZ) shape and level number (arguments: arrShape, myNr);
168        fix ctrl_init_wet.F & ecco_cost_weights.F by calling the new S/R with the
169        right type.
170    o autodiff and RS=real*4:
171      - call the right type (_RS instead of _RL) of S/R in few output S/R (pkg/exf
172        ad-monitor and snapshots); disable arrType='RS' in mdsio_gl*.F ;
173      - change argument type of 3-D mask argument to _RS to match type in the call
174        (in seaice_cost*.F, ctrl_*_gen.F and *ctrl_bound.F); to be continued.
175    o pkg/thsice:
176      - re-anable balanceEmPmR when useSEAICE=T with useThSIce=T.
177      - option to correct ocean fresh-water flux for imbalance of Atmos+Land
178        fresh-water flux: uniform correction or proportional to local precip.
179    o pkg/ctrl:
180      - new header file CTRL_SIZE.h for parameters maxCtrlArr2D, maxCtrlArr3D
181      - redefine CPP option ALLOW_BOTTOMDRAG_CONTROL to
182                            ALLOW_BOTTOMDRAG_CONTROL_NONGENERIC
183      - verification/hs94.1x64x5/ tests ALLOW_GENARR{2D,3D}_CONTROL
184    
185    checkpoint63q (2012/07/30)
186    o pkg/autodiff:
187      note about monitor and snap-shot of ad-variables:
188      a) need to apply ADEXCH before monitor or output of ad-vars to include
189       overlap contributions (was done for adjDump but missing for monitor).
190      b) since ADEXCH implies adding overlap values to interior array, machine
191       truncation error is expected when adding an ADEXCH call in the middle of
192       the time-stepping (although mathematically identical).
193      modifs:
194      - fix some incorrect type (RL/RS, UV/scalar) in ADEXCH calls and ad-vars
195        declaration (adEddyPsiX,adEddyPsiY in adcommon.h).
196      - add new run-time params (dumpAdVarExch & mon_AdVarExch) to select how  to
197        apply ADEXCH before monitor or snap-shot of ad-variables:
198           =0 : no ADEXCH ; =1 : do ADEXCH ; =2 : apply ADEXCH on a local copy.
199      - implement new method (copy+adexch) for snap-shot and monitor of main model
200        ad-vars (initially not used by default -> output unchanged).
201      - change default (set to 2) to use new method and update few output_adm.txt
202        with accurate ad-monitor (global_ocean.90x40x15, tutorial_global_oce_biogeo
203        and both tutorial_tracer_adjsens tests).
204      - switch 2 global_ocean.cs32x15 AD-tests to AB-2 (seaice_dynmix & thsice)
205        and turn off momDissip_In_AB in the 2 other (needed for stable AB-3).
206    o pkg/ctrl:
207      enable the use of a variable number (maxCtrlArr2D, maxCtrlArr3D) of
208      generic control variables via
209      #define ALLOW_GENARR2D_CONTROL and/or #define ALLOW_GENARR3D_CONTROL
210      Only required customization should be S/R ctrl_map_ini_genarr.F
211      (routine in repository contains example)
212    o pkg/exf:
213      - fix and refine checking of surface-relaxation setting when using EXF
214    o verification (adjoint exp):
215      - reduce length of simulation by half for experiment global_ocean.cs32x15
216        (std, seaice & seaice_dynmix) and exp tutorial_dic_adjoffline; update output.
217    o pkg/mom_common (mom_u/v_bottomdrag), pkg/shelfice (shelfice_u/v_drag)
218      - replace if statements KE.ne.0 with KE.gt.0 to avoid sqrt of negative numbers
219        of KE that can occur with aggressive optimization
220      + put quadratic bottom drag calculation in separated loops (only done if
221        using bottomDragQuadratic)
222    o model/src: CG2D_NSA
223      - clean-up:  stop if cg2dNormaliseRHS=T and AUTODIFF
224         and replace GLOBAL_SUM calls with GLOBAL_SUM_TILE.
225      - in test-exp that uses CG2D_NSA (bottom_ctrl & tutorial_tracer_adjsens),
226         change cg2d residual target to be expressed in Wunits (=> do not normalise
227         RHS ; this fix global_max Pb with TAF); update output.
228    o verification/tutorial_tracer_adjsens:
229       improve parameter consistency (and get rid of warnings):
230       - use deltaTFreeSurf=deltaTtracer (better with NonLin FreeSurf);
231       - switch Temp Adv Scheme from 81 to 80 (no limiter since theta < 0 is physical)
232       - use staggerTimeStep (for stability) in som81; use default rotation period.
233    o pkg/exch2:
234      - with empty facet: fix compact-format (W2_mapIO=1) definition (was previously
235        reset to 0 = 1 long line in X)
236    o pkg/mdsio:
237      - fix reading of dimensions from meta file for large-size domain
238    o model/src:
239      - fix saltIsActiveTr setting for IdealGas eosType (eosType is 6 character long);
240      - to refine CS-grid check, add logical flag "hasWetCSCorners": true if using
241        Cubed-Sphere Exch with CS-corners inside the domain;
242        make new S/R INI_GLOBAL_DOMAIN from code in ini_linear_phisurf.F to calculate
243        globalArea and to set hasWetCSCorners.
244      - add warning if usingCurvilinearGrid and momAdvection in flux-form (missing
245        metric terms); stop if hasWetCSCorners=T and momAdvection in flux-form.
246      - re-activate the stop if useCDscheme and hasWetCSCorners=T (previously if
247        useCDscheme and useCubedSphereExchange).
248    o pkg/seaice/seaice_growth.F :
249      - compute the SEAICE_DISABLE_HEATCONSFIX term accordingly
250        for the (.NOT.useRealFreshWaterFlux).OR.(nonlinFreeSurf.EQ.0)
251        when the previous code was not correct.
252      - in all cases diagnoze the boundary condition mismatch to SIaaflux
253      - in the case of useRealFreshWaterFlux.AND.(nonlinFreeSurf.GT.0) add
254        that term to QNET (essentially to set the melt/freeze water to 0degC).
255        when SEAICEheatConsFix is true, so that the ocean+ice budget heat is closed.
256    o verification/global_ocean.cs32x15/input.seaice :
257      - add SEAICEheatConsFix in data.seaice, ensuring closed ocean+ice heat budget.
258      - add diagnostics (commented out) for budget test using my matlab codes (gcmfaces).
259      - update results (output.seaice.txt) accordingly.
260    o verification/lab_sea/input/data.seaice :
261      - remove SEAICEheatConsFix, which is now be tested
262        in global_ocean.cs32x15. The presently coded fix
263        is only consistent with real fresh water + nlfs.
264      - update results (output.txt) accordingly.
265    o pkg/salt_plume: added diagnotic for salt tendency (oceSPtnd).
266    o AD_CONFIG.h file:
267      - in genmake2: remove "#undef ALLOW_ECCO_OPTIMIZATION" from AD_CONFIG.h;
268      - remove #include "AD_CONFIG.h" from all included OPTIONS files and
269        add it explicitly in each fortran src file where it is needed.
270        motivation: header file AD_CONFIG.h is generated/modified after "make depend"
271        thus introducing potentially wrong dependency; therefore, better to include
272        it only where it's really needed, and after any other included OPTIONS file
273        (less tempting to bring conditional includes according to ALLOW_ADJOINT_RUN
274        or ALLOW_TANGENTLINEAR_RUN).
275    
276    checkpoint63p (2012/07/06)
277    o pkg/autodiff:
278      - rename S/R INI_AUTODIFF to AUTODIFF_INIT_VARIA ;
279      - create new header file "AUTODIFF_PARAMS.h" for pkg/autodiff parameters
280        which are now read from new parameter file "data.autodiff" (inAdExact
281        previously in "data", use{KPP/GMRedi/SEAICE}inAdMode previously in data.pkg)
282      - add file "data.autodiff" in all verification/*/input_ad/ directories.
283      - add run-time parameter to turn On/Off SEAICEuseFREEDRIFT in adjoint/forward
284        mode (used in global_ocean.cs32x15.seaice_dynmix test exp.)
285    o verification/tutorial_tracer_adjsens/
286      - add extra sub-verification which uses "SOM" advection scheme
287        (2nd Order-Moment Advection Scheme, Prather Limiter) with
288          #define GAD_ALLOW_TS_SOM_ADV in GAD_OPTIONS.h
289        and in data:
290          multiDimAdvection=.TRUE.,
291          tempAdvScheme=81,
292          saltAdvScheme=81,
293    o model/src:
294      - introduce ALLOW_BALANCE_RELAX which allow the removal
295       of the global mean of relaxation terms by setting
296       balanceThetaClimRelax and balanceSaltClimRelax
297      - disable balanceEmPmR and balanceQnet in the case when useSeaice.
298       This case is now treated appropriately in seaice_growth.F
299    o pkg/seaice:
300      - do balanceEmPmR and balanceQnet based on the net fluxes
301        (SItflux) that enter the ocean+ice system rather than QNET
302        and EMPMR. Works best in real fresh water.
303      - SIatmFW, SIatmQnet, and SItflux computations had to be moved
304        out of the diagnotics bloc, and stored in global arrays.
305    
306    checkpoint63o (2012/06/29)
307    o vertical mixing schemes:
308      - remove unused S/R CALC_BUOYANCY (left from branch-atmos merging)
309      - replace computation of density (in Function STATE1, opps_calc.F) by a call
310        to S/R FIND_RHO_SCALAR
311      - pass sigmaR to S/R PP81_CALC, MY82_CALC (but not yet used) and to GGL90_CALC
312        and use it for N^2 calculation in ggl90_calc.F (save 2 density computations);
313        affects output (vermix.ggl90) at truncation level.
314    o testreport:
315      - change adjustment of SIZE.h for mpi+mth testing: preserve enough tiles
316        (nSx,nSy) for the number of threads (from eedata.mth)
317    o model/src:
318      - remove 2nd set of calls at the top of initialise_varia.F (Adjoint part)
319        related to Non_Lin Free-Surf or Bottom-Control (but not longer necessary).
320    o verification/tutorial_tracer_adjsens/
321      - compile with ALLOW_CG2D_NSA
322      - run with nonlinFreeSurf=3
323      - update reference output_adm.txt
324    o tools/genmake2:
325      - add "-DHAVE_NETCDF" to the DEFINES list when NetCDF is available ;
326        refine usePROFILES switching off (only when NetCDF is not available).
327    o verification (atmospheric set-up):
328      - change eosType='IDEALGAS' to eosType='IDEALG' to match variable declaration
329    o pkg/profiles : refine profiles and files handling.
330    o model/src and pkg/ecco : introduce run-time switch usePROFILES.
331    o model/src/the_main_loop.F, forward_step.F and pkg/exf/EXF_OPTIONS.h :
332      - changes to use model/src/the_main_loop.F rather than the ecco version
333        in ecco type adjoint runs.
334    o model/src:
335      - move computation of recip of grid distance & area from INI_MASKS_ETC to INI_GRID
336      - move setting of h0Fac[C,W,S] from INI_LINEAR_PHISURF to INI_MASKS_ETC
337      - update_masks_etc.F: rename SMOOTH*_R4,R8 function to the corresponding type (RS,RL)
338    o model/src:
339      - fix S/R UPDATE_CG2D for ALLOW_DEPTH_CONTROL case (was empty before);
340        update output of test experiment bottom_ctrl_5x5.
341    o pkg/generic_advdiff:
342      - implement vertical bi-harmonic diffusion (for now, only for T & S and
343        only explicitly).
344    o verification/bottom_ctrl_5x5/
345      update reference output (results changed quite some time ago,
346      not sure when; but new reference results look ok in terms of grdchk)
347    o verification/1D_ocean_ice_column/
348      For verification purposes, the exact adjoint rather than an approx.
349      should be used (e.g., to comare against F.D. or TLM).
350      removed autodiff_inadmode*_ad.F routines in code_ad/
351      Update results/ accordingly.
352    o pkg/cal:
353      - change cal_getdate.F so that output date is function of input time only
354        (less ambiguous, not mixed up with input iteration number).
355      - fix calendarDumps for non-zero phase-lag (S/R CAL_TIME2DUMP).
356    o pkg/diagnostics:
357      - implement calendarDumps also for stats-diags
358      - implement calendarDumps also for snap-shot output (negative freq)
359      - for now, ignores calendarDumps if non-zero phase-lag.
360    
361    checkpoint63n (2012/06/04)
362    o model/src:
363      - recompute rSurfW & S to ensure consistent column thickness (needed for rStar)
364        between Sum_k(hFac*drF) and rSurf-rLow, for now only when using pkg/shelfice;
365      - use h0FacC, W & S to compute hFac_surfC, W & S in calc_surf_dr.F (more
366        similar to calc_r_star.F); update results of experiment internal_wave and
367        tutorial_global_oce_in_p (affected @ truncation level).
368    o pkg/shelfice:
369      - add parameterisation of advective-diffusive flux into the ice shelf
370        according to Holland and Jenkins (1999), eq.22-33, as suggested by Jan De Ryd
371      - simply eps3/3a computation
372    o eesupp:
373     - add new CPP option (DISCONNECTED_TILES) to disconnect tiles (no exchange
374       between tiles, just fill-in edges assuming locally periodic subdomain) and
375       add corresponding exchange subroutines (EXCH0);
376     - new CG-solver version (_EX0) for disconnected-tiles special case.
377    o model/src (CG-solvers):
378     - modify Single-Reduction version (CG2D_SR) in case cg2dMaxIters is reached
379       (similar final residual output and max-Iter number as with standard version);
380     - allows to store and use lowest-residual solution (standard & _SR versions);
381     - cleaning up (remove old, commented out code, LETS_MAKE_JAM ...).
382     - by default, also compile CG2D_SR version (define ALLOW_SRCG in CPP_OPTIONS.h)
383    o eesup/src:
384     - global_vec_sum.F cleaning: add a BARRIER ; update comments ; remove ndef
385       ALWAYS_USE_MPI (no longer needed after fixing usingMPI settings - March 2012)
386    o pkg/salt_plume added to lab_sea/input_ad.noseaicedyn
387    
388    checkpoint63m (2012/04/27)
389    o pkg/shelfice:
390     - account for partical cells in surface level below ice-shelf for hydrostatic
391       pressure calculion (set uniformFreeSurfLev to F); update isomip experiments.
392    o ad test experiments:
393     - update and rename to "ad_optfile.local" local AD-optfile specific to a
394       particular adjoint verification experiment (in verification/*/code_ad/)
395    o pkg/seaice & pkg/exf:
396     - Part two of ECCO-CLIVAR code merges.
397       Completes merge of seaice area relax. code.
398       Requires unified CPP option EXF_ALLOW_SEAICE_RELAX
399       to be set in EXF_OPTIONS.h since this pkg controls its I/O
400       (and avoids second CPP option in SEAICE_OPTIONS.h)
401     - change default value of costIceStart & costIceEnd to a valid date.
402     - add snowPrecip to HSNOW in seaice_growth
403    o pkg/ptracers:
404     - move ptracers summary and setup check into separated S/R ; add a check for
405       valid PTRACERS_Iter0 value (error+stop or just warning).
406    o pkg/cal (+ pkg/ecco):
407     - avoid calling a S/R with 2 times the same arg (FWD: unless both are only used
408       as input; and for AD, unless both are not differentiable (e.g., k index)).
409    o model/src:
410     - define internal flag "uniformFreeSurfLev" (=T when free-surface level-index
411       is everywhere k=1) to speed-up some calculations (by pass kSurf reference);
412       temporary set to usingZCoords value (to be changed to F when using shelfice).
413     - hydrostatic pressure: implement partial cell near the surface also for
414       Z-coordinates (for the case where uniformFreeSurfLev=F); replace test on
415       usingZCoords with test on uniformFreeSurfLev where needed (in NonHyd code).
416    o pkg/ctrl/ctrl_init.F:
417     - add a formal parameter to s/r ctrl_init_rec to print
418       xx_$(ctrl_valiable)_file for easier debugging
419     - move call of cal_* routines into the if-block where they are really
420       needed so that xx_$(ctrl_variable)_period can be 0 or -12 without having
421       to specify a startdate
422    o pkg/seaice:
423     - update comments in SEAICE_OPTIONS.h (+ similar update of lab_sea/code and
424       global_ocean.cs32x15/code versions).
425     - turn on seaice Multi-category (in data.seaice, SEAICE_multDim=7) for
426       verification experiment global_ocean.cs32x15.seaice and update results.
427    o pkg/exf:
428     - new S/R EXF_GETFIELD_START to return starting-time of a forcing field
429       (according to useExfYearlyFields).
430    o pkg/cal:
431     - move calendar setting & summary (previously in cal_readparams.F) into new
432       S/R CAL_INIT_FIXED to be called later in the initialisation process, once
433       length of the simulation is set (after SET_PARMS call); This is an attempt
434       to fix Pb when, e.g.: pkg/longstep, modifies the length of the run.
435     - For safety: keep a record of pkg/cal parameter settings status
436               to allow to STOP if one pkg/cal S/R is called too early.
437     - add a stop in all basic pkg/cal subroutines if called before setting is done.
438     - modify cal_getdate.F: stop when nothing was returned;
439       if called with myIter=-1, simply retrun modelBaseDate (1,2 = startDate_1,_2);
440       this allows to remove "cal.h" from seaice_read_parms.F & init_mnc_vars.F.
441    
442    checkpoint63l (2012/04/04)
443    o pkg/bbl:
444      - fix call to FIND_RHO_2D in bbl_calc_rho.F (case multi-tiles per proc);
445        update global_with_exf output.yearly.txt file.
446    o pkg/cal:
447      - start to clean-up cal_set.F ; fix for the case where baseTime is non-zero.
448      - remove 2 unsused and very short (1 line only) functions ;
449      - remove unsused subroutines from AD-Diff list.
450    o model/src:
451      - start to implement clean wait to stop in initialization S/R (config_check.F,
452         packages_check.F, ini_parms.F and pkg/obcs/obcs_check.F + pkg/mypackage)
453    o folowing PRINT_MESSAGE changes:
454      - remove reminder multiple print to the same file (STDOUT) when multi-threads.
455    o pkg/bbl:
456      - modification so it can work with z*
457      - replace deltaT with dTtracerLev(k) for asynchronous time stepping
458      - global_with_exf/input.yearly verification; changes output.yearly.txt
459    o eesupp/src:
460      - PRINT_MESSAGE: use OpenMP critical instruction (similar to PRINT_ERROR);
461        writing to unit 0 (if unit=errorMessageUnit) extended to the case myThid=1
462      - CHECK_THREADS: specific code if using OpenMP threading: improve checking of
463        # of threads across processors (e.g., different env OMP_NUM_THREADS setting)
464      - improve special preliminary call to EESET_PARMS (if eedata is read 2 times).
465      - when using MPI, always set usingMPI=T ; set default accordingly and stop
466        if not consistent.
467      - ALL_PROC_DIE: add a BARRIER after MPI_FINALIZE call ; skip this when thread
468        argument is zero (in case called within single-thread section).
469    o pkg/fizhi:
470        clean-up turbulence cold-start switch: decided in fizhi_init_vars.F, stored
471        in common bloc (fizhi_coms.h) and then passed as argument up to S/R TURBIO.
472    o pkg/exch2:
473      - add argument "updateCorners" to S/R exch2_get_uv_bounds (enable to
474        activate EXCH_IGNORE_CORNERS in vector EXCH S/R).
475      - switch 1rst EXCH call to IGNORE_CORNERS (instead of UPDATE_CORNERS)
476        but keep the 2nd with UPDATE_CORNERS: this prevents overwriting good data
477        with bad ones coming from a not-yet-updated halo.
478        This should fix the problem when sNx <> sNy and GCD(sNx,sNy) < 2*Olx.
479    o pkg/frazil:
480        move FrzForcT diag from frazil_diagnostics_state.F to frazil_calc_rhs.F
481        http://mitgcm.org/pipermail/mitgcm-devel/2012-March/005384.html
482    o model/src/config_check.F: add a check for OLx>sNx/OLy>sNy
483    o verification/lab_sea
484      * #undef SEAICE_EXCLUDE_FOR_EXACT_AD_TESTING
485      * #define ALLOW_SST_CONTROL & ALLOW_SST_CONTROL
486      * nTimeSteps 3 -> 4
487      * changed reference output accordingly
488    o pkg/ctrl:
489      * fix ctrl_get_gen for xx_sst, xx_sss
490    o pkg/fizhi:
491      - fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F
492        update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d)
493      - by default, use new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE);
494        fix few out-of-bounds indices in referencing vars (initialise igrd to 1);
495        clean-up fizhi_turb.F (remove unused & uninitialised qdiaglsm array).
496    o pkg/gmredi:
497      - add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp
498    o pkg/fizhi:
499      - fix few initialisation and multi-tile Pb: aqualev & gridalt now pass the
500        (old)aces open64 tuv test.
501    o pkg/icefront: fix bug and reorder loop in icefront_init_varia.F
502    o pkg/mom_vecinv:
503      - fix 1 loop range in mom_vecinv.F to be like all the other loops which
504        set/update gu,gv/Diss (fix Pb of uninitialised fVerUkp in admom_vecinv
505        with non-lin free-surf).
506    o model/src: move k-loop outside of i/j-loops when (re-)computing R_low
507      in ini/update_masks_etc.F in order to avoid -O3 optimization problems with
508      some compilers (gfortran 4.6.0 on MacOS)
509    o momentum:
510      - separate fVer?(:,:,kUp) & fVer?(:,:,kDown) in argument list of MOM_FLUXFORM
511        & MOM_VECINV subroutines (to help TAF). This fixes Pb of uninitialised
512        fVer?(kUp) in admom_fluxform with non-lin free-surf or bottom control.
513    
514    checkpoint63k (2012/03/17)
515    o model/src:
516       - selectAddFluid (ALLOW_ADDFLUID): add missing term in horizontal momentum
517         flux-form (mom_fluxform.F) and vertical momentum (calc_gw.F) equations.
518       - SOLVE_DIAGONAL: switch default to use adjoinable & vectorized version
519         (#undef SOLVE_DIAGONAL_LOWMEMORY); update output of exp. front_relax.bvp.
520    o model/src: solve_*diagonal.F
521       - replace division with multiplication by inverse (similar to original version)
522         update output of AD exp. global_ocean.90x40x15.
523       - fix pkg/gmredi/gmredi_calc_psi_bvp.F & pkg/ggl90/ggl90_calc.F
524         to enable the use of the vectorized & differentiable solve_tridiagonal.F
525       - test exp. global_ocean.90x40x15/input_ad: switch to advection scheme 20 for
526         vertical advection (to get solve_tridiagonal tested in AD mode).
527    o pkg/seaice: ECCO-CLIVAR merge:
528      1. seaice AREA relaxation
529         * CPP option: SEAICE_ALLOW_AREA_RELAXATION
530         * runtime flag: SEAICE_tauAreaObsRelax
531      2. modified global mean cost imbalance code: CPP option
532          ALLOW_SSH_GLOBMEAN_COST_CONTRIBUTION
533    o another iteration on solve_*diagonal.F
534       Make choices independent of AUTODIFF
535       Default will be the adjoinable vectorized version.
536       Alternative choices are:
537       * non-adjoinable original version with low memory footprint:
538         #define SOLVE_DIAGONAL_LOWMEMORY
539       * still adjoinable but does not vectorize (k as inner-most loop):
540         #define SOLVE_DIAGONAL_KINNER (keeping SOLVE_DIAGONAL_LOWMEMORY undef)
541    o testreport
542     - add option to use a home made wrapper around "make"
543     - remove MITGCM_IEEE env. variable (no longer active)
544    o pkg/shelfice
545     - improve computation of friction velocity for velocity dependent
546       exchange coefficients: include velocities into SHELFICEBoundaryLayer
547       block to average velocities vertically
548     - add TAF store directives for SHI_ALLOW_GAMMAFRICT
549    o Modify diagonal solvers, now three versions (upon request):
550      #ifndef SOLVE_DIAGONAL_AUTODIFF
551        1. default version (dating back a while ago)
552      #else /* def SOLVE_DIAGONAL_AUTODIFF */
553      # ifdef SOLVE_DIAGONAL_KINNER
554        2. adjoinable version with k-innermost loop (G. Forget)
555      # else
556        3. adjoinable vectorized version of 2.
557      # endif
558      #endif /* SOLVE_DIAGONAL_AUTODIFF */
559      All flags are currently set within routines, but could/should be moved to CPP-options.
560      Array bounds for 1. are as before, for 2.,3. cover the entire domain
561      (could be changed for 1. too).
562    o verification/lab_sea (fwd):
563      - update the 4 fwd lab_sea test experiment: no longer SEAICE_GROWTH_LEGACY,
564        use 7 categories (except hb87), new solve4temp params (except salt_plume),
565        constant salinity (=4) or variable salinity (salt_plume) done through
566        SItracer.
567    o pkg/seaice:
568      - rename parameters: SIsalFrac to SEAICE_saltFrac & SIsal0 to SEAICE_salt0;
569      - remove old parameters ( SEAICE_freeze, SEAICEturbFluxFormula, SEAICE_gamma_t,
570         SEAICE_gamma_t_frz, SEAICE_availHeatTaper & SEAICE_availHeatFracFrz)
571        from SEAICE_PARMS.h ; still need to fix seaice_cost_sst.F (broken when
572        SEAICE_freeze got retired) but already better than previously with
573        SEAICE_freeze=123456.7 deg.C;
574      - move setting of facOpenGrow/Melt from SEAICE_INIT_FIXED to SEAICE_READPARMS
575        (safer multi-threaded setting); always set SEAICEuseEVP;
576      - setting of ocean-ice turb. flux coeff: moved from SEAICE_CHECK to
577        SEAICE_READPARMS & SEAICE_INIT_FIXED (this fixes wrong summary report);
578        stop if multiple specifications for the same coeff; make sure default
579        SEAICE_mcPheePiston is compatible with drF(1) & deltaT.
580    o pkg/obcs:
581      - allow to switch to upwind 1rst order advection scheme for the advective
582        flux computation at the open-boundary; disabled for adjoint built.
583    o pkg/ptracers:
584      - rename PTRACERS_RESTART.h -> PTRACERS_START.h
585      - rename ptracers_fields_blocking_exchanges.F -> ptracers_fields_blocking_exch.F
586      - add parameter to decide when to start a tracer; use internal flag to
587        know which tracer to step-forward; switch this internal flag at the top
588        of forward_step.F (new S/R PTRACERS_SWITCH_ONOFF); for now, not enabled
589        for adjoint built.
590    o pkg/seaice:
591      - add SEAICE_SIZE.h anywhere in the code where SEAICE.h is included ;
592      - move MULTDIM declaration and setting from SEAICE.h to SEAICE_SIZE.h ;
593      - keep experiment offline_exf_seaice truly single category (set MULTDIM=1).
594    o pkg/ecco:
595      - fix writing of output file DiagnosCost_ClimSalt/Theta
596        and DiagnosCost_DriftSalt/Theta (if multi-tiles per proc).
597    o pkg/seaice:
598      - add missing initialisation of COR_ICE array in dynsolver.F
599      - merging SEAICE_MULTICATEGORY define and undef cases. Now the same code is
600        compiled either way, and is tested in all exps (multidim was only tested
601        in lab_sea ad before).
602      - cosmetic change to prepare for future addition of ITD. no change to results.
603        no defaults change.
604      - added run time param SEAICE_multDim (7 for SEAICE_MULTICATEGORY, 1 otherwise).
605      - by lack of adequate verification experiments, I further used custom versions
606        of global_ocean.cs32x15 to test multicat or not, with pickup or not. All
607        should be correct.
608      - avoid recomputations in ad.
609    o array initialisation in adjoint mode:
610      1) pkg/mom_common/mom_calc_ke.F:
611        add full array initialisation of KE inside mom_calc_ke.F (ALLOW_AUTODIFF_TAMC):
612        The S/R which calls MOM_CALC_KE initialises KE but in some recomputation
613        part this initialisation is gone, resulting in Floating Point Exception
614        (caught by open64 compiler with debug option).
615      2) model/src/convective_weights.F
616        set output convectCount over the full array range (instead of doing
617        an update): this fix a similar issue when called within recomputation (adjoint)
618        which could by-pass the initialisation (normally done in the caller S/R).
619    o pkg/seaice:
620      - final version of turbulent flux params, as agreed at MIT ice meet:
621           SEAICE_mcPheePiston (default is ~ 0.000875)
622           SEAICE_mcPheeTaper (default is 0.)
623           SEAICE_frazilFrac (defualt is 1.)
624           SEAICE_mcPheeStepFunc (default is false)
625      - changes results at trunction error level
626      - ifdef SEAICE_EXTERNAL_FLUXES, disallow SEAICE_waterAlbedo
627    o added pkg/frazil:
628      - see frazil_description.tex for details
629      - verification experiment is global_with_exf/input.yearly; changes output.yearly.txt
630    o pkg/shelfice/shelfice_thermodynamics.F
631      - fix exponents for velocity dependent exchange coefficients: change
632        from 2/3(=0) to 0.66666666666666667
633      - move computation of velocity dependent exchange coefficients into
634        separate loop, so that it applies to both thermodynamics
635      - move some divisions by constants out of loops
636    
637    checkpoint63j (2012/02/16)
638    o pkg/seaice:
639      - overhaul of seaice_summary.F after feb 2012 clean-up of seaice_growth.F etc.
640      - SItracer:  added run time params, and allow coupling to ocn salinity.
641    o pkg/seaice: remove (almost) all divisions by constants within loops
642      in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d
643      results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only
644      those, caused by 1/QI -> recip_QI) -> update output.seaice.txt,
645      output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt
646    o pkg/seaice :
647      - simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula
648        = 1 or 2, using newly added run time parameter SEAICE_availHeatTaper.
649      - fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148.
650      - add permanent SItflux diag that corresponds to TFLUX but includes
651        ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget.
652      - allow activation/testing of a fix for suspected missing term in
653        ocn-ice heat budget (to be confirmed). To test this, you want to
654        undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param
655        SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic.
656      - no change in results, fwd or ad.
657    o global_ocean.cs32x15/results: 3 changes following from the pkg/seaice commit below:
658      - switch to variable freezing point.
659           Results change : cg2d -> 1 digits; ad -> 3-6-6 digits.
660      - bug fix : the sublimation term that was missing is now activated.
661           Results change : cg2d -> 2 digits; ad -> 8-6-6 digits.
662      - bug fix : flooding sign term for SIsal0.NE.0.
663           Result change : cg2d -> 8 digits; ad -> 11-12-9 digits.
664    o pkg/seaice:
665      - unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT
666        is now the default, and the old default constant freezing point is recovered
667        with SEAICE_tempFrz0    = -1.96,
668             SEAICE_dTempFrz_dS = 0.,
669      - retire SEAICE_freeze (= the old way of specifycing the constant freezing point)
670      - remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there.
671      - bug fix (thanks to M. Losch) : the sublimation term that was missing is now
672        activated. To reproduce old results with this bug define SEAICE_DISABLE_SUBLIM.
673      - bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211)
674        was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail).
675      - bug fix (thanks to O. Jahn) : area loss for melting  got messed up in
676        seaice_growth r149 for legacy branch (no results change).
677      - introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code
678        from I. Fenty).
679      - results did not change except for global_ocean.cs32x15, mostly due to the
680        switch to variable freezing point (see above item for detail).
681    o pkg/thsice:
682      - fix and simplify interface to salt_plume pkg ; diagnose directly amount of
683        seawater freezing in thsice_calc_thickn (not used).
684    o pkg/seaice: turbulent flux term specification via run time params.
685      - replace CPP switches with run time switches to facilitate testing
686      - retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX,
687                       GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR
688      - added runtime parameter : SEAICEturbFluxFormula
689      - move Mcphee constants to SEAICE_PARAMS.h
690      - seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula;
691                 SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply);
692                 remove seaice_summary call (moved to seaice_init_fixed)
693      - seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on
694        SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms)
695      - seaice_summary.F : add missing report of read turbulent flux term set up
696                           and SITRACER.
697      - seaice_check.F : check range; inform and stop if retired CPPs are used
698                         (incl. SEAICE_AGE).
699      - seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without
700             CPP switch, same computation as before for the different options.
701      - change results at the truncation level.
702    o pkg/seaice:
703      - remove un-used parameters LAD & MAX_TICE ; add new run-time parameters:
704        useMaykutSatVapPoly (default=F), postSolvTempIter (default=2) and
705        SEAICE_wetAlbTemp (default=-1e-3). Remove option SEAICE_SOLVE4TEMP_LEGACY.
706      - update verification/*/input*/data.seaice:
707        to reproduce previous results with former #defined SEAICE_SOLVE4TEMP_LEGACY
708        code, set useMaykutSatVapPoly=T & postSolvTempIter=0 ;
709        and to reproduce previous results with former non-SOLVE4TEMP_LEGACY code,
710        set SEAICE_wetAlbTemp=0 & SEAICE_snowThick=0.
711    o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY):
712      - remove LEGACY code for solving for tsurf (A1,A2,A3) but maintain the same
713        algorithm (same choice: useMaykutPolySatVap=T, postSolvTempIter=0);
714        difference in results only due to machine truncation.
715      - remove MAX_TICE (tsurf is always =< TMELT anyway); keep MIN_TICE if using
716        MaykutPolySatVap; keep MIN_LWDOWN.
717      - adapt SEAICE_MODIFY_GROWTH_ADJ code (untested) to non-legacy formulation.
718      - update output of verification exp. lab_sea (4 fwd: 11 cg2d digits except hb87,
719        + 3 AD: 6 digits except evp) and offline_exf_seaice.seaice (12 digits).
720  o pkg/salt_plume:  o pkg/salt_plume:
721     - isolate saltPlumeFlux array exch into a specific S/R called from    - isolate saltPlumeFlux array exch into a specific S/R called from
722       do_oceanic_phys.F      do_oceanic_phys.F
723     - add interface to pkg/salt_plume (filling of saltPlumeFlux) in pkg/thsice.    - add interface to pkg/salt_plume (filling of saltPlumeFlux) in pkg/thsice.
724  o verification:  o verification:
725     - move untested set-up to MITgcm_contrib/verification_other.    - move untested set-up to MITgcm_contrib/verification_other.
726  o pkg/seaice:  o pkg/seaice:
727    - retire old way of SEAICE_AGE. Now replaced with ALLOW_SITRACER.    - retire old way of SEAICE_AGE. Now replaced with ALLOW_SITRACER.
728  o pkg/seaice:  o pkg/seaice:

Legend:
Removed from v.1.1590  
changed lines
  Added in v.1.1726

  ViewVC Help
Powered by ViewVC 1.1.22