| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o eesupp/src: |
| 8 |
|
- S/R MDSFINDUNIT avoids reserved unit numbers (scrUnit1, eeDataUnit ...) |
| 9 |
|
o pkg/seaice/seaice_preconditioner.F: fix preconditioner once again |
| 10 |
|
- remove wrong parts of the rhs and the lhs (were in there |
| 11 |
|
because I did not understand the concept of this preconditioner) |
| 12 |
|
- add an exchange between u- and v-sweep. This increases communication |
| 13 |
|
by a factor of two but improves the convergence of jfnk. Ideally, |
| 14 |
|
one would like the u- and v-sweep to be independent. So far within |
| 15 |
|
undocumented ifdefs |
| 16 |
|
- reorganize the extra computations for printing the residuals |
| 17 |
|
o tools/genmake2: |
| 18 |
|
- comment out the "mpif.h" include in NetCDF test programm (for MPI built) |
| 19 |
|
since it's not necessary (and was preventing to use MNC in some cases). |
| 20 |
|
|
| 21 |
|
checkpoint64a (2012/11/16) |
| 22 |
|
o pkg/autodiff: |
| 23 |
|
- improve pkg-internal logical parameter switch (inAd/inFwd mode) so that |
| 24 |
|
autodiff_readparms.F no longer depends on calling order (within |
| 25 |
|
packages_readparms.F) and no longer requires to include ${PKG}_PARMS.h): |
| 26 |
|
rename param turnFreeDriftInAdMode to SEAICEuseFREEDRIFTswitchInAd |
| 27 |
|
and change param SEAICEuseDYNAMICSinAdMode to SEAICEuseDYNAMICSswitchInAd. |
| 28 |
|
o pkg/obcs: |
| 29 |
|
- adding tidal velocity forcing capability to obcs |
| 30 |
|
for usage example, see verification/seaice_obcs/input.tides |
| 31 |
|
o pkg/seaice: |
| 32 |
|
- turn the LSR-relaxation parameters WFAU/V into runtime parameters |
| 33 |
|
SEAICE_LSRrelaxU/V |
| 34 |
|
- introduce runtime parameter SEAICEetaZmethod (=0 by default) |
| 35 |
|
o pkg/aim_v23: |
| 36 |
|
- implement heating from friction (bottom friction and stratospheric drag). |
| 37 |
|
o pkg/shap_filt: |
| 38 |
|
- fix diagnostic "SHAP_dKE" (was 2 time smaller); implement heating from |
| 39 |
|
dissipation but only for Shap_funct=2, active when addFrictionHeating=T. |
| 40 |
|
o model/src: |
| 41 |
|
- move AddMass common block from DYNVARS.h to FFIELDS.h; allow to read-in |
| 42 |
|
time-constant addMass field from file (addMassFile); |
| 43 |
|
- support for heating due to friction (and Kinetic Energy dissipation): |
| 44 |
|
add option, run-time switch and 3-D field array + support code ; each pkg |
| 45 |
|
or S/R can add heating contribution (if there is a sink of KE); the sum is |
| 46 |
|
accounted for as a Temperature tendency term (EXTERNAL_FORCING_T). |
| 47 |
|
o pkg/seaice: |
| 48 |
|
- complete merge of ITD code into seaice_growth.F |
| 49 |
|
from MITgcm_contrib/torge/itd/code/ |
| 50 |
|
no verification so far, but Torge Martin tested |
| 51 |
|
"1-D test case and Beaufort set up; |
| 52 |
|
deliver okay results after 1 model year." |
| 53 |
|
- complete merge of SEAICE_SIZE.h into all relevant routines |
| 54 |
|
- move computation of eta at Z-points into calc_viscosities |
| 55 |
|
+ introduce global field etaZ |
| 56 |
|
+ add different methods for computing etaZ, for now the old |
| 57 |
|
method (simple averages of eta to Z-points) is hardwired |
| 58 |
|
+ replace etaMeanZ by etaZ in seaice_lsr, seaice_calc_residual, |
| 59 |
|
seaice_preconditioner |
| 60 |
|
- simplify computations for SEAICE_ZETA_SMOOTHREG |
| 61 |
|
- seaice_preconditioner: |
| 62 |
|
+ replace one remaining press by pressLoc (mistake) |
| 63 |
|
+ adjust printing of residuals |
| 64 |
|
- improve I/O of diagnostics of JFNK in seaice_jfnk.F: |
| 65 |
|
+ add (SEAICE.h) and rename some counters (initiliased in |
| 66 |
|
seaice_init_fixed.F) |
| 67 |
|
+ add _BEGIN/END_MASTER (myThid) around print statements |
| 68 |
|
+ print total number of iterations and failures over SEAICE_monFreq |
| 69 |
|
interval to STDOUT |
| 70 |
|
- move control over output-messages by fgmres to seaice_jfnk to save |
| 71 |
|
some operations |
| 72 |
|
- move resetting initial guess for fgmres outside of seaice_fgmres_driver |
| 73 |
|
in order to make restarts with sol .ne. zero (fgmres with restarts) |
| 74 |
|
(seaice_jfnk.F, seaice_fgmres.F) |
| 75 |
|
- seaice_calc_l/rhs.F: replace maskW/S by maskInW/S; this fixes |
| 76 |
|
a serious convergence problem when open boundaries are involved |
| 77 |
|
o pkg/ggl90: fix computation of control volumes for the case of |
| 78 |
|
ALLOW_GGL90_HORIZDIFF (probably not used very often): move control volumes |
| 79 |
|
up half a grid cell from C-centered to W-centered (pointed out by C. Eden) |
| 80 |
|
o pkg/seaice: simplify seaice_evp by avoiding use of extra fields u/vIceC |
| 81 |
|
o pkg/autodiff |
| 82 |
|
- Add inAdMode switch for SEAICEuseDYNAMICS: |
| 83 |
|
SEAICEuseDYNAMICSinAdMode |
| 84 |
|
(extend logic in ADAUTODIFF_INADMODE_SET) |
| 85 |
|
o pkg/seaice |
| 86 |
|
- Step 1 of merging ice-thickness distribution (ITD) code from |
| 87 |
|
MITgcm_contrib/torge/itd/ (author: Torge Martin) |
| 88 |
|
The code implements concept laid out in Thorndike et al. (1975); |
| 89 |
|
code is enabled via CPP flag SEAICE_ITD |
| 90 |
|
nITD (in SEAICE_SIZE.h) defines number of ice thickness categories; |
| 91 |
|
code is not complete yet!! |
| 92 |
|
- SEAICE_SIZE.h now included in almost all seaice routines |
| 93 |
|
o verification (using seaice): |
| 94 |
|
- switch back seaice-dynamics (+ lower SOLV_MAX_ITERS) in ADM exp. |
| 95 |
|
global_ocean.cs32x15.seaice ; update results. |
| 96 |
|
- compile B-grid dynamics in FW test exp 1D_ocean_ice_column ; |
| 97 |
|
- compile C-grid dynamics with #define SEAICE_ALLOW_JFNK in FW test exp |
| 98 |
|
offline_exf_seaice (previously compiling B-grid). |
| 99 |
|
o pkg/exf: |
| 100 |
|
- fix some STOP conditions in exf_check.F (from Aug 28, modifs did not allow |
| 101 |
|
to specify neither just 1 comp of wind or wind-stress, nor no surface momentum |
| 102 |
|
forcing): just replace CPP option ALLOW_ATM_WIND with run-time param useAtmWind. |
| 103 |
|
o pkg/layers (adjust changes from Sept 19): |
| 104 |
|
- do snap-shot output and fill diagnostics from inside iLa loop (layers_calc.F) |
| 105 |
|
this allows to remove "layers_maxNum" dimension from all layers arrays. |
| 106 |
|
o pkg/layers (adjust changes from Sept 19): |
| 107 |
|
- remove ALLOW_LAYERS_OUTPUT ; fix snap-shot and time-ave output ; |
| 108 |
|
- snap-shot extended to all type of layers (not just the 1rst type); |
| 109 |
|
- remove layers variables when corresponding CPP option is undef. |
| 110 |
|
o pkg/layers: |
| 111 |
|
- rename pkg/layers variable and add new output (layer exist & un-weighted |
| 112 |
|
velocity in layer) |
| 113 |
|
o pkg/seaice: |
| 114 |
|
- simplify (?) ocean-drag coefficent computations by using |
| 115 |
|
the same routine in all three solvers (saves some code lines) |
| 116 |
|
- remove global fields DRAGA and DRAGS from C-grid code and |
| 117 |
|
declare them locally in lsr.F (the only place where they are |
| 118 |
|
still used) |
| 119 |
|
- update AD output of lab_sea.evp (very sensitive anyway). |
| 120 |
|
o pkg/seaice: add Jacobian-free Newton Krylov solver for ice dynamics |
| 121 |
|
(Lemieux et al. 2010, 2012). Turn on with the usual SEAICE_ALLOW_JFNK |
| 122 |
|
and SEAICEuseJFNK=.true. A few things to note: |
| 123 |
|
- involves a FGMRES, that is parallel but very inefficient, |
| 124 |
|
because of many scalar products (global sums) in the Gram-Schmidt |
| 125 |
|
orthogonalization method. Needs to be replaced. Original code |
| 126 |
|
from J.-F. Lemieux |
| 127 |
|
- preconditioner for FGMRES is a stripped down version of LSOR |
| 128 |
|
- SOLV_MAX_ITERS is now used for LSOR as a solver and as a |
| 129 |
|
preconditioner. For the preconditioner, the default is set to 10. |
| 130 |
|
- Jacobian times vector is computed with finite differences |
| 131 |
|
- marginally related to JFNK-solver: add a smooth regularization for |
| 132 |
|
zeta with tanh that will improve convergence (Lemieux and Tremblay, |
| 133 |
|
2009) for any implicit solver (not implemented for EVP because EVP |
| 134 |
|
does not need this regularization in the first place). Define |
| 135 |
|
SEAICE_ZETA_SMOOTHREG in SEAICE_OPTIONS.h to use. |
| 136 |
|
o eesupp/src: |
| 137 |
|
- check in genmake2 that intrinsic S/R flush is available. |
| 138 |
|
- add S/R to flush IO unit (if intrinsic S/R flush is available) |
| 139 |
|
- flush standard & error msg unit before MPI termination |
| 140 |
|
- if debugMode, flush IO unit after printing msg |
| 141 |
|
o pkg/ctrl: |
| 142 |
|
- ctrl_unpack.F, ALLOW_GENARR3D_CONTROL code: fix missing argument in call |
| 143 |
|
to ctrl_set_unpack_xyz. |
| 144 |
|
|
| 145 |
|
checkpoint64 (2012/10/09) |
| 146 |
|
o pkg/shelfice |
| 147 |
|
- in mom_fluxform.F, mom_vecinv.F: |
| 148 |
|
CALL SHELFICE_V_DRAG(bi,bj,k,vFld,KE,KappaRU,vF,myThid) |
| 149 |
|
Bug fix KappaRU -> KappaRV |
| 150 |
|
does not change verification/isomip but may change other setups |
| 151 |
|
(presumably constant KappaRU=KappaRV) |
| 152 |
|
- fix diagnostics SHIU/Vdrag (thanks to Tom Millgate) |
| 153 |
|
o pkg/obcs: |
| 154 |
|
- fixed some indexing bugs in obcs_seaice_sponge.F |
| 155 |
|
- added obcs relaxation subroutines for HSALT and HSNOW |
| 156 |
|
- changes verification/seaice_obcs/results/obcs_seaice_sponge.F |
| 157 |
|
o pkg/seaice: |
| 158 |
|
- add "multicategory" parameterization for snow in analogy to ice, |
| 159 |
|
default is off for now. |
| 160 |
|
o pkg/obcs: |
| 161 |
|
- added obcs_seaice_sponge.F for obcs relaxation of seaice variables; |
| 162 |
|
see verification/seaice_obcs/input.seaiceSponge for example application. |
| 163 |
|
- remove local commom bloc "OBCS_GLOBAL" in obcs_readparms.F and do all the OB |
| 164 |
|
index setting by master-thread. This fix multi-threads Pb in previous modifs. |
| 165 |
|
o pkg/layers : |
| 166 |
|
- add diagnostics to pkg/layers |
| 167 |
|
- move the meat of pkg/layers from layers_calc.F to layers_fluxcalc.F |
| 168 |
|
(from R.Tulloch). Layers_calc.F now calls layers_fluxcalc.F accordingly. |
| 169 |
|
o pkg/generic_advdiff/gad_implicit_r.F : |
| 170 |
|
- fix ADVr diagnostics in case of both implicit vertical advection and diffusion. |
| 171 |
|
o pkg/seaice/seaice_growth.F: |
| 172 |
|
- fix SItflux diagnostics in virtual salt flux + balanceEmpmr case. |
| 173 |
|
o pkg/obcs: |
| 174 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
| 175 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
| 176 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
| 177 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
| 178 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
| 179 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
| 180 |
|
o pkg/obcs: |
| 181 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
| 182 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
| 183 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
| 184 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
| 185 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
| 186 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
| 187 |
|
to replace hard-coded null index value of zero. |
| 188 |
|
o pkg/exch2: |
| 189 |
|
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
| 190 |
|
always check buffer-size (but outside the loop); move checking for valid |
| 191 |
|
index from W2_USE_E2_SAFEMODE to W2_E2_DEBUG_ON; in W2_E2_DEBUG_ON, |
| 192 |
|
print each tile and point connection only if |W2_printMsg|>= 2 and 3. |
| 193 |
|
o pkg/ctrl (pack & unpack): |
| 194 |
|
- in ctrl_pack.F & ctrl_unpack.F, use the same local file-name variable |
| 195 |
|
(locally defined) for different variables (+ remove the variable-specific |
| 196 |
|
file name in CTRL_GENARR.h). For now, only implemented for GENARR2/3D_CONTROL |
| 197 |
|
(to be extended to other local file names in ctrl.h). |
| 198 |
|
o pkg/flt: |
| 199 |
|
- add a FLT_Iter0 option (similar to PTRACERS_Iter0). |
| 200 |
|
o pkg/mdsio: |
| 201 |
|
- fix missing STOP in mdsio_readvec_loc.F (case ioUnit=0) when file is missing |
| 202 |
|
o tools/genmake2: |
| 203 |
|
- add similar dependences for target EXE_AD & EXE_FTL as we have for EXECUTABLE |
| 204 |
|
(added by Alistair in version 1.51 for building without make depend); |
| 205 |
|
- remove Header files list (H_SRC_FILES) from the dependence of targets |
| 206 |
|
ad_input_code.f & ftl_input_code.f (not clear why it was added in the first |
| 207 |
|
place in version 1.23): this save going through staf when unrelated header |
| 208 |
|
file has been modified. |
| 209 |
|
Note: for an intermediate target (e.g., ad_input_code.f or adtaf) without |
| 210 |
|
"make depend" step, still need to do "make links" before "make adtaf". |
| 211 |
|
o eesupp/src (+ few pkg src files) & genmake2: |
| 212 |
|
- finish to remove ALWAYS_USE_MPI in source code that TAF does not see; |
| 213 |
|
- no longer set ALWAYS_USE_MPI in Makefile (was done by genmake2). |
| 214 |
|
- improve genmake2 checking for ALLOW_${PKG} in CPP_OPTIONS.h files (distinguish |
| 215 |
|
upper/lower case ; account for space between "#" and undef/define) |
| 216 |
|
o pkg/flt (with exch2): |
| 217 |
|
- cleaning: fix so that it compiles; move remaining MPI calls out of flt_exch2.F; |
| 218 |
|
- simplify threads synchronisation; fix (many issues) multi-threaded with MPI. |
| 219 |
|
|
| 220 |
|
checkpoint63s (2012/09/05) |
| 221 |
|
o pkg/ecco: |
| 222 |
|
- remove #ifdef ALLOW_SMOOTH_CORREL3D brackets. |
| 223 |
|
- add more relevant #ifdef ALLOW_SMOOTH ones. |
| 224 |
|
- sort out useAtmWind, useSMOOTH, ctrlSmoothCorrel2D. |
| 225 |
|
o pkg/ctrl: |
| 226 |
|
- CTRL_OPTIONS.h : document CPPs related to smoothing; ALLOW_SMOOTH_CORREL2D/3D, |
| 227 |
|
ALLOW_CTRL_SMOOTH, ALLOW_SMOOTH_CTRL2D, ALLOW_SMOOTH_CTRL3D. |
| 228 |
|
- ctrl.h : document run time params doInitXX, doMainPack, doMainUnpack, doPackDiag, |
| 229 |
|
doSinglePrecTapelev (audodiff param!), ctrlSmoothCorrel2D (new) and |
| 230 |
|
ctrlSmoothCorrel3D (new). |
| 231 |
|
The added ctrlSmoothCorrel2D/3D replace the old ALLOW_SMOOTH_CORREL2D/3D CPP. |
| 232 |
|
- ctrl_readparms.F : initialise ctrlSmoothCorrel2D/3D and read from namelist. |
| 233 |
|
- ctrl_init.F ctrl_pack.F ctrl_unpack.F : switch off ustress/vstress |
| 234 |
|
controls when useAtmWind, and vice versa. |
| 235 |
|
- ctrl_map_ini_ecco.F : UVEL0, VVEL0, edtaux, edtauy cannot be smoothed as tracers. |
| 236 |
|
- ctrl_get_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL2D with |
| 237 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel2D, IF useSMOOTH. |
| 238 |
|
- ctrl_map_ini_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL3D with |
| 239 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel3D, IF useSMOOTH. |
| 240 |
|
- ctrl_set_pack_xy[z].F, ctrl_set_unpack_xy[z].F: |
| 241 |
|
replace ALLOW_SMOOTH_CORREL2D/3D brackets with ctrlSmoothCorrel2D/3D. |
| 242 |
|
o pkg/smooth: |
| 243 |
|
- remove un-necessary includes. |
| 244 |
|
- remove ALLOW_SMOOTH*D and ALLOW_SMOOTH_CORREL*D brakets. |
| 245 |
|
Those CPP options were never defined, and not necessary. |
| 246 |
|
o model/src: |
| 247 |
|
- fix CPP brackets in ini_mixing.F (GM_background_K belongs to gmredi). |
| 248 |
|
- standard treatment of useSMOOTH. |
| 249 |
|
o pkg/autodiff: |
| 250 |
|
- add LOGICAL useGGL90inAdMode, useGGL90inFwdMode, useSALT_PLUMEinAdMode, |
| 251 |
|
useSALT_PLUMEInFwdMode allowing to switch off ggl90 and salt_plume adjoint. |
| 252 |
|
o pkg/exch2: |
| 253 |
|
- add "if usingMPI" where it was missing (in exch2_rx?_cube*.template) |
| 254 |
|
+ start to remove ALWAYS_USE_MPI in source code that TAF does not see. |
| 255 |
|
- make new S/R W2_MAP_PROCS out of w2_eeboot.F to setup exch2 CommonFlag |
| 256 |
|
and tiles to process mapping. |
| 257 |
|
- re-arrange 3 header files (W2_EXCH2_PARAMS.h, _BUFFER.h & _TOPOLOGY.h) |
| 258 |
|
moving /EXCH2_FILLVAL_RX/ & /W2_EXCH2_COMMFLAG/ to W2_EXCH2_TOPOLOGY.h; |
| 259 |
|
rename "exch2_tProc" to "W2_tileProc" and move seting of e2FillValue_RX |
| 260 |
|
from w2_eeboot.F to w2_readparms.F. |
| 261 |
|
o eesupp/src: |
| 262 |
|
- set exchNeedsMemsync & exchUsesBarrier according to "usingMPI" (instead of |
| 263 |
|
ALWAYS_USE_MPI) + moved from ini_communication_patterns.F to eeset_parms.F; |
| 264 |
|
also move setting of exchCollectStatistics from exch_init.F to eeset_parms.F |
| 265 |
|
- in eedie.F and all_proc_die.F, always call MPI_FINALIZE when ALLOW_USE_MPI |
| 266 |
|
is defined (remove condition on usingMPI) to match cases where MPI_INIT |
| 267 |
|
has been called. |
| 268 |
|
- fix bug I put in previous modif of exch_sm_3d_rx.template (not much used); |
| 269 |
|
- change default (non-MPI) value of myPid (from 1 to 0) to match MPI settings |
| 270 |
|
(so that on 1 proc, get same myPid independently of usingMPI) |
| 271 |
|
- add a stop if multi-procs but usingMPI=F ; stop also if usingMPI=T and |
| 272 |
|
useCubedSphereExchange with EXCH-1 (safer). |
| 273 |
|
- add "if usingMPI" where it was missing (+ start to remove ALWAYS_USE_MPI). |
| 274 |
|
o pkg/ggl90: |
| 275 |
|
- fix bug in filling corner mask array "mskCor" (FILL_CS_CORNER_TR_RL call) |
| 276 |
|
used in ALLOW_GGL90_SMOOTH code. |
| 277 |
|
o pkg/flt: |
| 278 |
|
- fix typo in FLT_WITHOUT_Y_PERIODICITY (the effect was to ignore stopping |
| 279 |
|
floats at the Southern end of the domain). |
| 280 |
|
o eesupp/inc: |
| 281 |
|
- add a list of CPP-options which can be set by Makefile (DEF_IN_MAKEFILE.h); |
| 282 |
|
but not used (and not to be used) anywhere, just for documentation. |
| 283 |
|
o pkg/autodiff, exf, ptracers & seaice (AD & TL output): |
| 284 |
|
- comment out the very nasty "writeBinaryPrec = writeStatePrec" line, since: |
| 285 |
|
a) can damage previously written records in any other multi-record files. |
| 286 |
|
b) if needed, can easily do it cleanly, by calling S/R WRITE_REC_3D_RL/S. |
| 287 |
|
o tools/genmake2: |
| 288 |
|
- define variable MAKE within Makefile and use it in place of 'make'; |
| 289 |
|
- update AD_CONFIG.h (if needed) before building any of the executable |
| 290 |
|
(forward, adjoint or tangent-lin); this involves a 2nd invocation of make; |
| 291 |
|
and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h; |
| 292 |
|
- always print usual warning comment 'this file is automatically generated' |
| 293 |
|
from script convert_cpp_cmd2defines (+ remove this warning from genmake2). |
| 294 |
|
o pkg/cheapaml: |
| 295 |
|
- updated to correspond to the code used in accepted paper (Nico Wienders). |
| 296 |
|
o pkg/exf: |
| 297 |
|
added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch. |
| 298 |
|
ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F) |
| 299 |
|
and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h). |
| 300 |
|
o pkg/exf, autodiff, ctrl, ecco and seaice: |
| 301 |
|
remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones. |
| 302 |
|
o pkg/ctrl, ecco: |
| 303 |
|
allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL. |
| 304 |
|
Depending on useAtmWind, one is inactive, and the other is active (see |
| 305 |
|
exf_getffields.F/exf_getsurfacefluxes.F). |
| 306 |
|
o tools/genmake2: |
| 307 |
|
- improve error msg when failing in 2nd test of check_for_broken_Ff |
| 308 |
|
- fix option '-makefile' short-name (-mf according to genmake2 -help) |
| 309 |
|
- source local config file "genmake_local" just after processing the genmake2 |
| 310 |
|
command arguments (previously done before processing arg). |
| 311 |
|
o pkg/grdchk: |
| 312 |
|
- add a call to TURNOFF_MODEL_IO for Tangent-Linear run (in this case, call |
| 313 |
|
to this routine from cost_final has been dropped in g_cost_final) |
| 314 |
|
- improve printed information (more explicit msg, no longer using "print *," |
| 315 |
|
fix fcpertminus printed value). |
| 316 |
|
o model/src: |
| 317 |
|
- move call to COST_INIT_VARIA out of packages_init_variables.F directly |
| 318 |
|
into initialise_varia.F (just after calling PACKAGES_INIT_VARIABLES): |
| 319 |
|
this prevents getting cost-funct reset in adinitialise_varia recomputations. |
| 320 |
|
o pkg/dic: |
| 321 |
|
- move initialisation of "freefe" array from from dic_biotic_forcing.F to |
| 322 |
|
fe_chem.F: this prevents TAF from dropping this initialisation in TLM code. |
| 323 |
|
o pkg/grdchk: |
| 324 |
|
- grdchk_main.F : added CALL GLOBAL_SUM_INT( ierr , myThid ) |
| 325 |
|
- grdchk_getadxx.F etc. : omit I/O if ierr.EQ.0 |
| 326 |
|
o pkg/autodiff/ctrl/grdchk : |
| 327 |
|
- attempt to sort out what works and what does not, |
| 328 |
|
with regard to I/O, and to warn/stop accordingly. |
| 329 |
|
o pkg/grdchk: |
| 330 |
|
- attempt to fix grdchk in the case of useSingleCpuIO. |
| 331 |
|
- "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )" |
| 332 |
|
statements were moved from grdchk_main.F and into |
| 333 |
|
grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F. |
| 334 |
|
- a global sum is applied to record numbers icvrec/layer |
| 335 |
|
out of grdchk_loc so that they be passed to I/O routines. |
| 336 |
|
o pkg/smooth: |
| 337 |
|
- fix recomputation that appeared with nlfs : use smooth_recip_hFacC, |
| 338 |
|
smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case. |
| 339 |
|
o verification/testreport: |
| 340 |
|
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
| 341 |
|
- can also use compressed (gzip) reference output file; |
| 342 |
|
- change format (in pkg/grdchk) of TLM output (+ add forward gradient) |
| 343 |
|
to be easier to collect by testreport. |
| 344 |
|
- update existing TLM output (half out-of-date by more than 3 yrs). |
| 345 |
|
- report NETCDF & LAPACK settings (from genmake2) in output dir. |
| 346 |
|
- report run-time in each individual summary (previously only for AD test); |
| 347 |
|
for TLM test, add also TAF version. |
| 348 |
|
- add daily TLM test on (old) aces cluster + weekly test on baudelaire. |
| 349 |
|
|
| 350 |
|
checkpoint63r (2012/08/15) |
| 351 |
|
o tools/genmake2: |
| 352 |
|
- fix Makefile for target ftlall (+ update files to clean after make ftlall) |
| 353 |
|
o pkg/ecco/ecco_cost_final.F : |
| 354 |
|
- fix fc print statements (to stdout and costfunction0000) so |
| 355 |
|
that the printed value is always after the global sum. |
| 356 |
|
o pkg/seaice/seaice_dynsolver.F : |
| 357 |
|
- fix ice strength assymptote at SEAICE_area_max<1 |
| 358 |
|
(no change for the standard case of SEAICE_area_max=1) |
| 359 |
|
o some cleaning: |
| 360 |
|
- pkg source files: ensure that all *.F files from each pkg included the |
| 361 |
|
corresponding ${PKG}_OPTIONS.h file (except stand-alone src file which |
| 362 |
|
only includes CPP_EEOPTIONS.h); fix S/R CTRL_SMOOTH ; update AD experiment |
| 363 |
|
code_ad/*.F src files; add new option-file in pkg/admtlm + corresponding |
| 364 |
|
includes; |
| 365 |
|
- model/src: add PACKAGES_CONFIG.h wherever ALLOW_AUTODIFF[_TAMC] is used. |
| 366 |
|
- ALLOW_DIFFKR_CONTROL: add a stop in S/R CTRL_CHECK in case ALLOW_3D_DIFFKR |
| 367 |
|
is undef; also define /DYNVARS_DIFFKR/ common block in DYNVARS.h when |
| 368 |
|
ALLOW_DIFFKR_CONTROL is defined, to allow to compile and reach this stop. |
| 369 |
|
- update option-file CPP_OPTIONS.h of all AD experiments: |
| 370 |
|
* no longer include PACKAGES_CONFIG.h ; |
| 371 |
|
* includes ECCO_CPPOPTIONS.h if PACKAGES_CONFIG.h has been included ; |
| 372 |
|
* def/undef ALLOW_3D_DIFFKR independently of ALLOW_DIFFKR_CONTROL (before |
| 373 |
|
including ECCO_CPPOPTIONS.h). |
| 374 |
|
o pkg/cost, pkg/ctrl, pkg/ecco option-file: |
| 375 |
|
- clean-up and split content of old pkg/ecco/ECCO_CPPOPTIONS.h file into |
| 376 |
|
separated pkg option-file (done according to old doc from ECCO_CPPOPTIONS.h, |
| 377 |
|
not necessary accurate). |
| 378 |
|
- add a template for option-file ECCO_CPPOPTIONS.h, mostly empty, in |
| 379 |
|
pkg/autodiff, i.e., the 1rst pkg to compile for adjoint built, with lines to |
| 380 |
|
deliberately break compilation (a remainder that it needs to be customized) |
| 381 |
|
- in pkg/ecco, includes ECCO_OPTIONS.h instead of COST_OPTIONS.h |
| 382 |
|
- rename COST_CPPOPTIONS.h to COST_OPTIONS.h |
| 383 |
|
- rename CTRL_CPPOPTIONS.h to CTRL_OPTIONS.h |
| 384 |
|
o tools/genamke2: |
| 385 |
|
- check for lapack. |
| 386 |
|
o pkg/cost and pkg/ecco : attempt to sort out some of the limiting intricacies. |
| 387 |
|
- pkg/cost.cost_final.F : allow for use of pkg/ecco and pkg/cost cost functions |
| 388 |
|
jointly. The exclusive ifdefs were removed, to add costs terms (when defined) |
| 389 |
|
from both packages. |
| 390 |
|
- the fc global sum in pkg/ecco/ecco_cost_final.F was removed accordingly. |
| 391 |
|
- for objf_atl we use either the pkg/ecco or the pkg/cost term depending on CPPs. |
| 392 |
|
- pkg/ecco and model/src : add CPP brackets around pkg/cost and pkg/ctrl includes |
| 393 |
|
of "CTRL_SIZE.h" "ctrl.h" "ctrl_dummy.h" "optim.h" / "cost.h" accordingly. |
| 394 |
|
o pkg/cost : add comments to explain special and/or untested setups. |
| 395 |
|
o pkg/exf: |
| 396 |
|
- use EXF_OPTIONS.h to set pkg/exf options except if done in ECCO_CPPOPTIONS.h |
| 397 |
|
(previously, ALLOW_AUTODIFF_TAMC was controling this switch). |
| 398 |
|
o verification/*/code_ad: |
| 399 |
|
mimimal cleaning of AD experiments ECCO_CPPOPTIONS.h option-file: |
| 400 |
|
- reccord when this file is included (define ECCO_CPPOPTIONS_H) |
| 401 |
|
- remove the most obvious obsolete features (e.g., #define ALLOW_COST not |
| 402 |
|
allowed since Oct 2003 in any option-file except in PACKAGES_CONFIG.h) |
| 403 |
|
o pkg/seaice : |
| 404 |
|
- added possibility to change ice strength/PRESS0 relationship to |
| 405 |
|
HEFF, according to the following run time parameters |
| 406 |
|
SEAICEpresPow0 :: HEFF exponent for ice strength below SEAICEpresH0 (integer, >0) |
| 407 |
|
SEAICEpresPow1 :: HEFF exponent for ice strength above SEAICEpresH0 (integer, >0) |
| 408 |
|
SEAICEpresH0 :: HEFF threshold for ice strength (m) |
| 409 |
|
o pkg/ggl90 : |
| 410 |
|
- added run time flag mxlSurfFlag to include the code that ensure |
| 411 |
|
mixing between first and second level (previously included as a comment) |
| 412 |
|
o verification/1D_ocean_ice_column/input_ad/data.autodiff : |
| 413 |
|
- add test of newly added dumpAdByRec=T option where |
| 414 |
|
we write all records to one file per variable. |
| 415 |
|
o verification/global_ocean.cs32x15/code_ad/CPP_OPTIONS.h : |
| 416 |
|
- switch to #define ALLOW_BALANCE_RELAX and ALLOW_BALANCE_FLUXES |
| 417 |
|
to check that this code is ok with taf and compiles in adjoint. |
| 418 |
|
o pkg/autodiff : |
| 419 |
|
- added run time param dumpAdByRec : ad dump format switch. |
| 420 |
|
If true then write all records to one file per variable. |
| 421 |
|
Else write one file per record (remains the default). |
| 422 |
|
- revise seaice_ad_dump.F and exf_adjoint_snapshots_ad.F accordingly. |
| 423 |
|
o pkg/seaice: |
| 424 |
|
- Added SEAICEuseTILT run time switch : if set to |
| 425 |
|
false then omit the tilt term in seaice dynamics. |
| 426 |
|
- Fix free drift calculation. |
| 427 |
|
o pkg/shelfice: |
| 428 |
|
When initializing SHELFICEDragQuadratic, set default to be |
| 429 |
|
consistent with shiCdrag in case SHELFICEuseGammaFrict is used, |
| 430 |
|
but retain option to set it independently |
| 431 |
|
(inconsistenty spotted by Veronique Dansereau) |
| 432 |
|
o eesupp/inc: |
| 433 |
|
- in EEPARAMS.h, add real-type constant for some frequently used simple number |
| 434 |
|
(0,1,2,1/2), with name explicitly referring to RS/RL type. |
| 435 |
|
o model/src: |
| 436 |
|
- move balancing of relaxation terms to new S/R balance_relax.F. |
| 437 |
|
o pkg/autodiff: |
| 438 |
|
re-write active I/O high-level (control) S/R: |
| 439 |
|
- rename S/R ACTIVE_READ/WRITE_RL to ACTIVE_READ/WRITE_3D_RL |
| 440 |
|
- add 1 more argument (useCurrentDir) to replace the "_LOC" 2nd set of S/R. |
| 441 |
|
- use standard pkg/mdsio I/O routines (MDS_READ/WRITE_SEC_XZ/YZ and |
| 442 |
|
MDS_READ/WRITE_FIELD); change loops to multi-threads. |
| 443 |
|
- update and merge active_file_control_slice.flow into active_file_control.flow |
| 444 |
|
- update the calls in lower level S/R (active_file.F, active_file_g.F and |
| 445 |
|
active_file_ad.F) keeping the argument list and function unchanged. |
| 446 |
|
- also update lower-level "_LOC" version (call same S/R with "useCurrentDir |
| 447 |
|
=.TRUE.") and remove high-level (control) _loc version (not called anymore). |
| 448 |
|
- new low-level active I/O routines, one for each type (RL/RS), for active var |
| 449 |
|
of various (XY,XZ,YZ) shape and level number (arguments: arrShape, myNr); |
| 450 |
|
fix ctrl_init_wet.F & ecco_cost_weights.F by calling the new S/R with the |
| 451 |
|
right type. |
| 452 |
|
o autodiff and RS=real*4: |
| 453 |
|
- call the right type (_RS instead of _RL) of S/R in few output S/R (pkg/exf |
| 454 |
|
ad-monitor and snapshots); disable arrType='RS' in mdsio_gl*.F ; |
| 455 |
|
- change argument type of 3-D mask argument to _RS to match type in the call |
| 456 |
|
(in seaice_cost*.F, ctrl_*_gen.F and *ctrl_bound.F); to be continued. |
| 457 |
|
o pkg/thsice: |
| 458 |
|
- re-anable balanceEmPmR when useSEAICE=T with useThSIce=T. |
| 459 |
|
- option to correct ocean fresh-water flux for imbalance of Atmos+Land |
| 460 |
|
fresh-water flux: uniform correction or proportional to local precip. |
| 461 |
|
o pkg/ctrl: |
| 462 |
|
- new header file CTRL_SIZE.h for parameters maxCtrlArr2D, maxCtrlArr3D |
| 463 |
|
- redefine CPP option ALLOW_BOTTOMDRAG_CONTROL to |
| 464 |
|
ALLOW_BOTTOMDRAG_CONTROL_NONGENERIC |
| 465 |
|
- verification/hs94.1x64x5/ tests ALLOW_GENARR{2D,3D}_CONTROL |
| 466 |
|
|
| 467 |
|
checkpoint63q (2012/07/30) |
| 468 |
|
o pkg/autodiff: |
| 469 |
|
note about monitor and snap-shot of ad-variables: |
| 470 |
|
a) need to apply ADEXCH before monitor or output of ad-vars to include |
| 471 |
|
overlap contributions (was done for adjDump but missing for monitor). |
| 472 |
|
b) since ADEXCH implies adding overlap values to interior array, machine |
| 473 |
|
truncation error is expected when adding an ADEXCH call in the middle of |
| 474 |
|
the time-stepping (although mathematically identical). |
| 475 |
|
modifs: |
| 476 |
|
- fix some incorrect type (RL/RS, UV/scalar) in ADEXCH calls and ad-vars |
| 477 |
|
declaration (adEddyPsiX,adEddyPsiY in adcommon.h). |
| 478 |
|
- add new run-time params (dumpAdVarExch & mon_AdVarExch) to select how to |
| 479 |
|
apply ADEXCH before monitor or snap-shot of ad-variables: |
| 480 |
|
=0 : no ADEXCH ; =1 : do ADEXCH ; =2 : apply ADEXCH on a local copy. |
| 481 |
|
- implement new method (copy+adexch) for snap-shot and monitor of main model |
| 482 |
|
ad-vars (initially not used by default -> output unchanged). |
| 483 |
|
- change default (set to 2) to use new method and update few output_adm.txt |
| 484 |
|
with accurate ad-monitor (global_ocean.90x40x15, tutorial_global_oce_biogeo |
| 485 |
|
and both tutorial_tracer_adjsens tests). |
| 486 |
|
- switch 2 global_ocean.cs32x15 AD-tests to AB-2 (seaice_dynmix & thsice) |
| 487 |
|
and turn off momDissip_In_AB in the 2 other (needed for stable AB-3). |
| 488 |
|
o pkg/ctrl: |
| 489 |
|
enable the use of a variable number (maxCtrlArr2D, maxCtrlArr3D) of |
| 490 |
|
generic control variables via |
| 491 |
|
#define ALLOW_GENARR2D_CONTROL and/or #define ALLOW_GENARR3D_CONTROL |
| 492 |
|
Only required customization should be S/R ctrl_map_ini_genarr.F |
| 493 |
|
(routine in repository contains example) |
| 494 |
|
o pkg/exf: |
| 495 |
|
- fix and refine checking of surface-relaxation setting when using EXF |
| 496 |
|
o verification (adjoint exp): |
| 497 |
|
- reduce length of simulation by half for experiment global_ocean.cs32x15 |
| 498 |
|
(std, seaice & seaice_dynmix) and exp tutorial_dic_adjoffline; update output. |
| 499 |
|
o pkg/mom_common (mom_u/v_bottomdrag), pkg/shelfice (shelfice_u/v_drag) |
| 500 |
|
- replace if statements KE.ne.0 with KE.gt.0 to avoid sqrt of negative numbers |
| 501 |
|
of KE that can occur with aggressive optimization |
| 502 |
|
+ put quadratic bottom drag calculation in separated loops (only done if |
| 503 |
|
using bottomDragQuadratic) |
| 504 |
|
o model/src: CG2D_NSA |
| 505 |
|
- clean-up: stop if cg2dNormaliseRHS=T and AUTODIFF |
| 506 |
|
and replace GLOBAL_SUM calls with GLOBAL_SUM_TILE. |
| 507 |
|
- in test-exp that uses CG2D_NSA (bottom_ctrl & tutorial_tracer_adjsens), |
| 508 |
|
change cg2d residual target to be expressed in Wunits (=> do not normalise |
| 509 |
|
RHS ; this fix global_max Pb with TAF); update output. |
| 510 |
|
o verification/tutorial_tracer_adjsens: |
| 511 |
|
improve parameter consistency (and get rid of warnings): |
| 512 |
|
- use deltaTFreeSurf=deltaTtracer (better with NonLin FreeSurf); |
| 513 |
|
- switch Temp Adv Scheme from 81 to 80 (no limiter since theta < 0 is physical) |
| 514 |
|
- use staggerTimeStep (for stability) in som81; use default rotation period. |
| 515 |
|
o pkg/exch2: |
| 516 |
|
- with empty facet: fix compact-format (W2_mapIO=1) definition (was previously |
| 517 |
|
reset to 0 = 1 long line in X) |
| 518 |
|
o pkg/mdsio: |
| 519 |
|
- fix reading of dimensions from meta file for large-size domain |
| 520 |
|
o model/src: |
| 521 |
|
- fix saltIsActiveTr setting for IdealGas eosType (eosType is 6 character long); |
| 522 |
|
- to refine CS-grid check, add logical flag "hasWetCSCorners": true if using |
| 523 |
|
Cubed-Sphere Exch with CS-corners inside the domain; |
| 524 |
|
make new S/R INI_GLOBAL_DOMAIN from code in ini_linear_phisurf.F to calculate |
| 525 |
|
globalArea and to set hasWetCSCorners. |
| 526 |
|
- add warning if usingCurvilinearGrid and momAdvection in flux-form (missing |
| 527 |
|
metric terms); stop if hasWetCSCorners=T and momAdvection in flux-form. |
| 528 |
|
- re-activate the stop if useCDscheme and hasWetCSCorners=T (previously if |
| 529 |
|
useCDscheme and useCubedSphereExchange). |
| 530 |
|
o pkg/seaice/seaice_growth.F : |
| 531 |
|
- compute the SEAICE_DISABLE_HEATCONSFIX term accordingly |
| 532 |
|
for the (.NOT.useRealFreshWaterFlux).OR.(nonlinFreeSurf.EQ.0) |
| 533 |
|
when the previous code was not correct. |
| 534 |
|
- in all cases diagnoze the boundary condition mismatch to SIaaflux |
| 535 |
|
- in the case of useRealFreshWaterFlux.AND.(nonlinFreeSurf.GT.0) add |
| 536 |
|
that term to QNET (essentially to set the melt/freeze water to 0degC). |
| 537 |
|
when SEAICEheatConsFix is true, so that the ocean+ice budget heat is closed. |
| 538 |
|
o verification/global_ocean.cs32x15/input.seaice : |
| 539 |
|
- add SEAICEheatConsFix in data.seaice, ensuring closed ocean+ice heat budget. |
| 540 |
|
- add diagnostics (commented out) for budget test using my matlab codes (gcmfaces). |
| 541 |
|
- update results (output.seaice.txt) accordingly. |
| 542 |
|
o verification/lab_sea/input/data.seaice : |
| 543 |
|
- remove SEAICEheatConsFix, which is now be tested |
| 544 |
|
in global_ocean.cs32x15. The presently coded fix |
| 545 |
|
is only consistent with real fresh water + nlfs. |
| 546 |
|
- update results (output.txt) accordingly. |
| 547 |
|
o pkg/salt_plume: added diagnotic for salt tendency (oceSPtnd). |
| 548 |
|
o AD_CONFIG.h file: |
| 549 |
|
- in genmake2: remove "#undef ALLOW_ECCO_OPTIMIZATION" from AD_CONFIG.h; |
| 550 |
|
- remove #include "AD_CONFIG.h" from all included OPTIONS files and |
| 551 |
|
add it explicitly in each fortran src file where it is needed. |
| 552 |
|
motivation: header file AD_CONFIG.h is generated/modified after "make depend" |
| 553 |
|
thus introducing potentially wrong dependency; therefore, better to include |
| 554 |
|
it only where it's really needed, and after any other included OPTIONS file |
| 555 |
|
(less tempting to bring conditional includes according to ALLOW_ADJOINT_RUN |
| 556 |
|
or ALLOW_TANGENTLINEAR_RUN). |
| 557 |
|
|
| 558 |
|
checkpoint63p (2012/07/06) |
| 559 |
o pkg/autodiff: |
o pkg/autodiff: |
| 560 |
- rename S/R INI_AUTODIFF to AUTODIFF_INIT_VARIA ; |
- rename S/R INI_AUTODIFF to AUTODIFF_INIT_VARIA ; |
| 561 |
- create new header file "AUTODIFF_PARAMS.h" for pkg/autodiff parameters |
- create new header file "AUTODIFF_PARAMS.h" for pkg/autodiff parameters |
| 572 |
multiDimAdvection=.TRUE., |
multiDimAdvection=.TRUE., |
| 573 |
tempAdvScheme=81, |
tempAdvScheme=81, |
| 574 |
saltAdvScheme=81, |
saltAdvScheme=81, |
| 575 |
|
o model/src: |
| 576 |
|
- introduce ALLOW_BALANCE_RELAX which allow the removal |
| 577 |
|
of the global mean of relaxation terms by setting |
| 578 |
|
balanceThetaClimRelax and balanceSaltClimRelax |
| 579 |
|
- disable balanceEmPmR and balanceQnet in the case when useSeaice. |
| 580 |
|
This case is now treated appropriately in seaice_growth.F |
| 581 |
|
o pkg/seaice: |
| 582 |
|
- do balanceEmPmR and balanceQnet based on the net fluxes |
| 583 |
|
(SItflux) that enter the ocean+ice system rather than QNET |
| 584 |
|
and EMPMR. Works best in real fresh water. |
| 585 |
|
- SIatmFW, SIatmQnet, and SItflux computations had to be moved |
| 586 |
|
out of the diagnotics bloc, and stored in global arrays. |
| 587 |
|
|
| 588 |
checkpoint63o (2012/06/29) |
checkpoint63o (2012/06/29) |
| 589 |
o vertical mixing schemes: |
o vertical mixing schemes: |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch