| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/kpp: add "_d 0" to real constant (if missing); |
| 8 |
|
update output of exp: natl_box (10.digits); vermix (std, 7.digits) |
| 9 |
|
and lab_sea, 3.FW (only 6,4,6 digits match) & AD (8.digits). |
| 10 |
|
o prepare for "clever pickup" implementation: add new header file "RESTART.h" |
| 11 |
|
for internal parameters related to restart process (formerly from PARAMS.h) |
| 12 |
|
and add startAB parameter to argument list of S/R ADAMS_BASHFORTH2. |
| 13 |
|
o more standard interface to {PKG}_WRITE_PICKUP with pickup suffix passed |
| 14 |
|
as argument. (only atm2d & obcs write_pickup have not yet been updated) |
| 15 |
|
o pkg/monitor: |
| 16 |
|
- use GLOBAL_SUM_TILE instead of _GLOBAL_SUM |
| 17 |
|
- fix mon_stats_rs (statistics over the full domain, even where field is zero) |
| 18 |
|
- account for deep Atmosphere factor and density factor (anelastic) |
| 19 |
|
o added open boundary conditions capability for seaice HEFF and AREA |
| 20 |
|
o pkg/shelfice: add option for convservative form of Hellmer&Olbers (1989) |
| 21 |
|
thermodynamics |
| 22 |
|
- requires a little reorganization, which affects the testreport results |
| 23 |
|
of isomip.htd (only 7 digits of cg2d agree) => update/modify experiment, |
| 24 |
|
so that now the conservative form is tested |
| 25 |
|
- add a few comments |
| 26 |
|
o add missing cvs Header: or Name: in eesupp/*, pkg/* & verification/code* |
| 27 |
|
o add a little bit of code to gad_os7mp_adv_?.F to help vectorization |
| 28 |
|
o add new diagnostics to seaice: advective, diffusive fluxes (only for |
| 29 |
|
multidim-advection, for scheme 2 they are not filled) and transports, |
| 30 |
|
thermodynamic growth rates |
| 31 |
|
o change units of EmPmR (inside the code) from m/s to kg/m2/s (mass flux) but |
| 32 |
|
leave input file unchanged. Affects results @ truncation level (cg2d match) |
| 33 |
|
and update output of experiments: lab_sea(6), global_ocean.90x40x15(10), |
| 34 |
|
global_ocean.cs32x15(11x3,10), natl_box(11), tutorial_global_oce_latlon(11) |
| 35 |
|
+ adjoint results: global_ocean_ebm(11) and lab_sea (12). |
| 36 |
|
Next: will retire convertEmP2rUnit (simply using mass2rUnit instead). |
| 37 |
|
|
| 38 |
|
checkpoint59h |
| 39 |
|
o pkg/exf: |
| 40 |
|
- improve vectorization by moving if-statement out of loops in |
| 41 |
|
exf_mapfields, exf_radiation |
| 42 |
|
- exf_bulkformulae.F: introduce 2D fields and vectorize code |
| 43 |
|
o pkg/kpp: added the salt plume scheme (ALLOW_SALT_PLUME) to KPP package |
| 44 |
|
o testreport: |
| 45 |
|
- allow to test for Qnet & SeaIce monitor output; clean-up ALLOW_BULK_OFFLINE |
| 46 |
|
monitor & update offline_exf_seaice exp. output. |
| 47 |
|
- AD testing: pass/FAIL according to Grad. output accuracy (instead of Cost) |
| 48 |
|
o pkg/seaice: |
| 49 |
|
- bug fix in the evp solver: boundary conditions were affected be |
| 50 |
|
masking of zMax/zMin (changes results) |
| 51 |
|
- minor bug fix in boundary conditions in seaice_calc_strainrates |
| 52 |
|
(changes results for no_slip) |
| 53 |
|
- seaice_lsr.F: make interpolation of eta dependent on boundaries |
| 54 |
|
- replace hardcoded lower limit for zeta (zMin) by runtime parameter |
| 55 |
|
- add a test to lab_sea, that tests the Hibler and Bryan (1987) ocean |
| 56 |
|
stress formulation and no-slip boundary conditions |
| 57 |
|
o pkg/ptracers: Temporary fix for PTRACERS_useGMRedi & PTRACERS_useKPP |
| 58 |
|
in gad_calc_rhs.F ; add few safety stops in initialisation phase. |
| 59 |
|
o pkg/seaice: a first HSALT time stepping equation has been checked in |
| 60 |
|
o pkg/seaice: replaced maskW with seaiceMaskU and maskS with seaiceMaskV |
| 61 |
|
in seaice_lsr.F; this solves the pkg/seaice-pkg/obcs problem |
| 62 |
|
without requiring DO-IF statements |
| 63 |
|
o pkg/thsice: |
| 64 |
|
use continuous power-law function for partition of energy between lateral |
| 65 |
|
melting/freezing and thinning/thickening ; old code using step function |
| 66 |
|
still available with #undef THSICE_FRACEN_POWERLAW |
| 67 |
|
update output of exp: aim.5l_cs.thSI, global_ocean.cs32x15.icedyn & .thsice |
| 68 |
|
o testreport: change AD testing : check against results/output_adm.txt |
| 69 |
|
using same scripts as for forward test. |
| 70 |
|
|
| 71 |
|
checkpoint59g |
| 72 |
|
o adjoint testing: in preparation for changing testreport: |
| 73 |
|
- output format: cost and grad written on separated lines |
| 74 |
|
- ad output results in directory "results" (instead of "results_ad") |
| 75 |
|
o pkg/seaice: adding ice salinity HSALT as a prognostic variable |
| 76 |
|
o pkg/seaice: changes for using pkg/seaice with pkg/obcs |
| 77 |
|
o pkg/ecco: allow user defined cost function contributions |
| 78 |
|
o testreport: |
| 79 |
|
Allow to choose (per experiment) the list of tested output variables |
| 80 |
|
and the main variable (used to issue a pass/FAIL ) ; |
| 81 |
|
- for now, done by adding the specific list in file: [exp]/input/tr_checklist |
| 82 |
|
- default is unchanged: >cg2d< , (T,S,U,V,5 tracers)_[min,max,mean,StD] ; |
| 83 |
|
Also modify printing of summary: |
| 84 |
|
a) ">" NN "<" indicates the "main" variable (used for pass/FAIL) |
| 85 |
|
b) echo the list of tested variables in the individual summary.txt of |
| 86 |
|
each experiment. |
| 87 |
|
o new S/R GLOBAL_SUM_TILE to compute global sum independently of number of |
| 88 |
|
threads and number of processes (with #define GLOBAL_SUM_SEND_RECV) |
| 89 |
|
(but still depend on the tile decompostion of the domain). |
| 90 |
|
o pkg/seaice: change a discretization detail to make the B-grid code |
| 91 |
|
"more symmetric". This change is likely to remove all "ridges/leads" that |
| 92 |
|
where quasi-aligned with the grid in B-grid solutions. It may also be |
| 93 |
|
the solution to the stress coupling issues with the B-grid. |
| 94 |
|
o each tested exp: add a "run" directory with a standard ".cvsignore" file ; |
| 95 |
|
remove .cvsignore from input dir. (since testreport no longer run here). |
| 96 |
|
o pkg/thsice: |
| 97 |
|
- cleaning: move common block out of "THSICE_2DYN.h" (removed) to "THSICE_VARS.h" |
| 98 |
|
- fix reshaping of sea-ice just after advection: |
| 99 |
|
melt all the ice only if ice-volume is too small. |
| 100 |
|
- re-visit lateral/thinning repartition of melting (modifs from May 04, 2007): |
| 101 |
|
prevent lateral melting if sea-ice fraction is too close to iceMaskMin ; |
| 102 |
|
and update experiment global_ocean.cs32x15.icedyn (+start from pickup files). |
| 103 |
|
o external_forcing_surf : extend the use of salt_EvPrRn & temp_EvPrRn (fresh-water |
| 104 |
|
tracer content) to linFS or no RealFreshWaterFlux ; default remains unchanged. |
| 105 |
|
o define mass2rUnit & rUnit2mass as units conversion factor, used for surface |
| 106 |
|
forcing. mass2rUnit: from mass per unit area [kg/m2] to r-coordinate unit |
| 107 |
|
(z-coord: =1/rhoConst ; p-coord: =gravity) ; rUnit2mass is just the reverse; |
| 108 |
|
and remove horiVertRatio (& recip_horiVertRatio). Affects truncation error |
| 109 |
|
of exp. global_oce_in_p: 10 16 16 14 16 13 16 16 16 13 13 13 16 13 13 12 16 |
| 110 |
|
-> update output.txt |
| 111 |
|
o pkg/cd_code: add brackets in multiple terms sum (S/R CD_CODE_SCHEME): |
| 112 |
|
this affects truncation error: -> update output.txt of exp: |
| 113 |
|
global_ocean.90x40x15 (fw&adm), lab_sea (fw&adm) & lab_sea.lsr, |
| 114 |
|
ideal_2D_oce, isomip.htd, natl_box, tutorial_global_oce_latlon. |
| 115 |
|
|
| 116 |
|
checkpoint59f |
| 117 |
|
o pkg/autodiff: zero_adj resets an ajoint variable to zero (in adjoint mode) |
| 118 |
|
o pkg/ctrl: ctrl_bound forces parameter corrections to stay in |
| 119 |
|
a bounded range (in forward mode) |
| 120 |
|
o pkg/ecco, ctrl, autodiff and mom_common: |
| 121 |
|
internal parameter controls, completements of implementations |
| 122 |
|
o add few EXCH S/R (UV_BGRID, UV_DGRID, SM) for B & D-Grid velocity & 2nd Moment Sxy. |
| 123 |
|
o use UV_BGRID exch for dxV,dyU: for now, only with pkg/exch2 & forward ; |
| 124 |
|
(not seem any difference in testing results). |
| 125 |
|
o pkg/cd_code: use the right EXCH calls (for CS-grid); but problem remains |
| 126 |
|
at face corners. |
| 127 |
|
o pkg/generic_advdiff: |
| 128 |
|
- in GAD.h, define as parameters (iMinAdvR,iMaxAdvR,jMinAdvR,jMaxAdvR) |
| 129 |
|
loop range indices for computing vertical advection tendency |
| 130 |
|
and do the calculation in the interior only (no overlap) ; |
| 131 |
|
for now, only implemented for SOM advection (to save CPU time). |
| 132 |
|
- add argument "withSigns" to S/R FILL_CS_CORNER_TR_RL (needed for SOM_xy moment) |
| 133 |
o exch2 adjoint |
o exch2 adjoint |
| 134 |
First set of changes: |
First set of changes: |
| 135 |
- add exch2 hand-written adjoint templates |
- add exch2 hand-written adjoint templates |
| 139 |
- Comment all relevant #ifndef ALLOW_AUTODIFF_TAMC |
- Comment all relevant #ifndef ALLOW_AUTODIFF_TAMC |
| 140 |
that used to hide exch2 or cubed-sphere specific code |
that used to hide exch2 or cubed-sphere specific code |
| 141 |
(commented via 'cph-exch2') |
(commented via 'cph-exch2') |
| 142 |
|
o pkg/seaice |
| 143 |
|
- Close southern and western boundaries for UICE/VICE when useOBCS=.TRUE. |
| 144 |
|
o pkg/bulk_force: fix loading into Qsw of Short-Wave flux; and update |
| 145 |
|
output of global_ocean.cs32x15.thsice . |
| 146 |
|
|
| 147 |
checkpoint59e |
checkpoint59e |
| 148 |
o exch2: new S/R that only use the cube-tracer (center-position) exchange: |
o exch2: new S/R that only use the cube-tracer (center-position) exchange: |
| 342 |
ATMOSPHERIC_LOADING is #define). |
ATMOSPHERIC_LOADING is #define). |
| 343 |
o pkg/kpp: replaced _KPP_RL with _RL |
o pkg/kpp: replaced _KPP_RL with _RL |
| 344 |
o bug fixes for vertical diffusivity computations when both KPP and |
o bug fixes for vertical diffusivity computations when both KPP and |
| 345 |
3D diffusivity arrays are used. |
3D diffusivity arrays are used; pkg/kpp/kpp_calc_diff_s & _t.F |
| 346 |
|
are no longer updating the vertical diffusivity array |
| 347 |
|
(passed as argument) but are (re-) setting those arrays. |
| 348 |
o pkg/seaice: fix bug in evp solver, while doing that |
o pkg/seaice: fix bug in evp solver, while doing that |
| 349 |
- change (improve?) discretization of stress computations for both |
- change (improve?) discretization of stress computations for both |
| 350 |
cgrid-lsr and evp solver |
cgrid-lsr and evp solver |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch