| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/seaice: |
| 8 |
|
- seaice_growth.F: fix bug in conservation of freshwater connected to |
| 9 |
|
capping of heff, put contribution into d_HEFFbyNEG |
| 10 |
|
- replace irritating parameters SEAICE_latentWater/Ice and SEAICE_sensHeat |
| 11 |
|
by something more sensible (parameters that are what their name implies) |
| 12 |
|
- change some defaults, so that by default exf-parameters are used for |
| 13 |
|
things like rhoAir, cpAir,latent/sensible heat parameters, in order |
| 14 |
|
to reproduce the old results, many data.seaice now contain funny values |
| 15 |
|
for cpAir and latent heat of sublimation |
| 16 |
|
o packages_readparms.F: move exf_readparms up in line so that |
| 17 |
|
exf-parameters are visible for other packages (e.g. seaice) |
| 18 |
|
o debugMode & debugLevel=2: |
| 19 |
|
- differentiate between debugMode & debugLevel=2: |
| 20 |
|
debugMode: controls printing of debug messages (sequence of S/R calls). |
| 21 |
|
debugLevel: controls printing of algorithm intermediate results and stats. |
| 22 |
|
- remove "if debugLevel=2 => debugMode" but keep "debugMode => debugLevel=2"; |
| 23 |
|
=> allows to print debug-stats without all sequence of call messages. |
| 24 |
|
- switch control of debug print from debugLevel to debugMode in many S/R. |
| 25 |
|
o pkg/obcs (obcs-sponge): |
| 26 |
|
fix bug that was introduced on Oct 25 (in dynamics.F v1.151): put back the |
| 27 |
|
call to OBCS_PRESCRIBE_EXCHANGES (need to exch gU,gV when using obcs-sponge) |
| 28 |
|
o pkg/generic_advdiff: |
| 29 |
|
- record overlap minimum size for each advection scheme; |
| 30 |
|
- refine criteria on overlap minimum size; |
| 31 |
|
- check and stop (in gad_check) if overlap size is too small. |
| 32 |
|
o pkg/obcs: |
| 33 |
|
- with ptracers: remove multiple calls to obcs_apply_ptracer (only done |
| 34 |
|
once, in ptracers_implicit.F) |
| 35 |
|
- with seaice: remove test on empty file name in obcs_apply_seaice (always |
| 36 |
|
apply OB values when tile has OB) |
| 37 |
|
o model/src, coriolis setting: |
| 38 |
|
- integer parameter "selectCoriMap" (=0,1,2) replaces 3 logical |
| 39 |
|
useConstantF, useBetaPlaneF, useSphereF ; can now read coriolis from |
| 40 |
|
files (selectCoriMap=3) with any grid. |
| 41 |
|
- add parameter "fPrime" for constant second Coriolis coeff (default=0). |
| 42 |
|
o pkg/seaice/seaice_growth.F: |
| 43 |
|
a few cosmetic changes that reduce the number of lines of code |
| 44 |
|
o pkg/obcs: add boundary conditions following Stevens (1990) |
| 45 |
|
- the code follows old MOM/NAOSIM code |
| 46 |
|
- so far it is only implemented for the eastern and western boundaries |
| 47 |
|
and NOT for pTracers |
| 48 |
|
o pkg/rbcs: |
| 49 |
|
- replace rbcsInIter by rbcsForcingOffset, the time in seconds at the |
| 50 |
|
beginning of the first rbcs forcing period. |
| 51 |
|
- add option rbcsSingleTimeFiles that makes rbcs read forcing data like the |
| 52 |
|
offline package, i.e., one file per time, labeled by iteration number; |
| 53 |
|
deltaTrbcs sets the timestep with which the data was generated; |
| 54 |
|
rbcsIter0 is the forcing iteration corresponding to rbcsForcingOffset. |
| 55 |
|
- rbcsForcingCycle=0 makes forcing non-cyclic. |
| 56 |
|
- make arithmetic safe for negative times and odd forcing periods. |
| 57 |
|
|
| 58 |
|
checkpoint62n (2010/11/09) |
| 59 |
|
o pkg/seaice: |
| 60 |
|
fix masking in free-drift S/R ; update results of exp. lab_sea.fd |
| 61 |
|
o pkg/obcs: |
| 62 |
|
New S/R to copy tracer value from the OB location to narrow band region |
| 63 |
|
(width = same as overlap) beyond the OB: preserve OB value (needed for |
| 64 |
|
high-order scheme) which were overwritten by EXCH call if in overlap |
| 65 |
|
region. Applied to theta, salt, ptracer and advected seaice variables. |
| 66 |
|
With seaice: use maskInC in similar way as in gad_advection.F, |
| 67 |
|
in seaice_advection.F and advect.F. |
| 68 |
|
Update output of experiment seaice_obcs and change exp4 to test OBCS with |
| 69 |
|
4th order Adv.Scheme. for pasive salt and ptracer. |
| 70 |
|
o tools/genmake2: |
| 71 |
|
- when looking for an optfile (not specified), only search for Fortran compiler |
| 72 |
|
(remove sym-link test + setting of CPP + makedepend check + C-compiler check) |
| 73 |
|
- in get_fortran_c_namemangling: use "$CC $CFLAG" to compile C test programm |
| 74 |
|
(instead of "$MAKE genmake_test.o" since an existing Makefile can be wrong) |
| 75 |
|
- set default for CPP to "cpp -traditional -P" (was the case without specifying |
| 76 |
|
an optfile, but otherwise default was just "cpp". |
| 77 |
|
- comment out PLATFORM=$p_PLATFORM (no idea where p_PLATFORM comes from) |
| 78 |
|
- when "CC" is not set in the optfile, look for possible C compiler |
| 79 |
|
(instead of just setting CC=cc) |
| 80 |
|
- put back version v.169 modif (from 2008/02/15), was dropped in v.173 changes: |
| 81 |
|
=> add a ".F" to ".o" rule for source files with no "#include" (such as |
| 82 |
|
port_rand.F); otherwise, default ignores FOPTIM and just uses FFLAGS. |
| 83 |
|
- move gfortran before g77 in list of possible Fortran compiler (consistent |
| 84 |
|
with reference compiler switch from g77 to gfortran) |
| 85 |
|
o pkg/seaice: |
| 86 |
|
o remove SEAICE_OLD_AND_BAD_DISCRETIZATION-code, add a test to |
| 87 |
|
seaice_check that stops the model, when the CPP flag is used. |
| 88 |
|
o seaice_growth.F: make capping of ice volume conserving by returning the |
| 89 |
|
capped ice as freshwater to EmPmR. This does not change the verification |
| 90 |
|
experiments but will change runs where the capping is acutally active |
| 91 |
|
o change reference platform+compiler from faulks+g77 to baudelaire+gfortran |
| 92 |
|
(except the 2 fizhi test exp.); update output of exp.: bottom_ctrl_5x5, |
| 93 |
|
global_ocean.cs32x15 (icedyn, thsice, AD thsice), global_ocean_ebm (AD), |
| 94 |
|
lab_sea (fd, hb87, salt_plume), MLAdjust (3/5) and vermix (dd) |
| 95 |
|
o tools/genmake2: |
| 96 |
|
- merge genmake_warnings & genmake_errors into 1 log file: "genmake.log") |
| 97 |
|
- change DUMPSTATE default to false (can use "-ds" option to switch it to T) |
| 98 |
|
- clean previous genmake log files before anything else. |
| 99 |
|
- change Makefile to remove testreport log files (*.tr_log) and genmake log |
| 100 |
|
files only with "CLEAN" target (instead of "Clean"); |
| 101 |
|
o pkg/generic_advdiff: |
| 102 |
|
Change OBCS in multiDim advection (gad_advection.F): |
| 103 |
|
Use maskInC to prevent intermediate update of tracer-field in OB regions, |
| 104 |
|
thus keeping current-time-step OB values; and remove the call to OBCS_APPLY |
| 105 |
|
which were applying future time-step OB values. |
| 106 |
|
This way, all explicit calculations use current-time-step OB values |
| 107 |
|
(simpler and more consistent). |
| 108 |
|
Affects results when set-up uses time-varying OBC and multi-dim advection; |
| 109 |
|
update output of experiment seaice_obcs. |
| 110 |
|
o pkg/seaice: |
| 111 |
|
move OPTIONS (formerly locally defined) to SEAICE_OPTIONS.h: |
| 112 |
|
this includes SEAICE_GROWTH_LEGACY (+ SEAICE_DO_OPEN_WATER_GROWTH & |
| 113 |
|
SEAICE_OCN_MELT_ACT_ON_AREA ) and SEAICE_SOLVE4TEMP_LEGACY. |
| 114 |
|
Default (pkg/seaice/SEAICE_OPTIONS.h) is to define SEAICE_SOLVE4TEMP_LEGACY |
| 115 |
|
but leave SEAICE_GROWTH_LEGACY undef ; For now, keep verification exp |
| 116 |
|
unchanged (SEAICE_GROWTH_LEGACY defined in */code*/SEAICE_OPTIONS.h) |
| 117 |
|
o pkg aim (2010/10/26): |
| 118 |
|
- Introduce ALLOW_INSOLATION, moving toward a more general incoming solar radiation |
| 119 |
|
formulation with obliquity, eccentricity, ... as run-time parameters, |
| 120 |
|
- Introduce diagnostics for top-of-the-atmaophere incoming solar radiation and |
| 121 |
|
upward shortwave radition at the surface (all-sky and clear-sky). |
| 122 |
|
o pkg/obcs: |
| 123 |
|
- writing sections with globalFiles=T does not work: switch to tiled-files |
| 124 |
|
when writing sections for OBCS (change pkg/rw/write_rec.F accordingly). |
| 125 |
|
- fix index bug (OB_Ie -> OB_Iw_) in obcs_apply_uvice.F |
| 126 |
|
- apply OBCS_SEAICE_COMPUTE_UVICE to both uice and vice at all obcs |
| 127 |
|
|
| 128 |
|
checkpoint62m (2010/10/21) |
| 129 |
|
o pkg/seaice: vectorize seaice_solve4temp.F |
| 130 |
|
- move iterations loops outside of i/j-loops |
| 131 |
|
- requires 2D arrays for TB and effConduct |
| 132 |
|
- add 2D iceOrNot to replace HICE_ACTUAL.GT.0, as HICE_ACTUAL is |
| 133 |
|
modified in this routine |
| 134 |
|
- a little bit of clean up, adjusting indentation, etc. |
| 135 |
|
- replaced a few TEN**a by exp(a*log(10.)) in new code for better |
| 136 |
|
performance and '**TWO' by '**2' (because TWO is a float), |
| 137 |
|
replaced ONE, ZERO |
| 138 |
|
o eesupp/src: |
| 139 |
|
fix flow dir for exch1_z_RX_cube, exch1_uv_RX_cube & exch1_bg_RX_cube |
| 140 |
|
o pkg/seaice/seaice_growth.F |
| 141 |
|
Revision 1.89 of seaice_growth.F completes the overall october 2010 revision and |
| 142 |
|
merging process. The merged routine has two branches, and one activates the 'evolution' |
| 143 |
|
branch by setting SEAICE_GROWTH_LEGACY to undef (at the top of the routine for now). |
| 144 |
|
In summary, here is what the '10/10 revision' did consist of |
| 145 |
|
part 1: seaice_growth.F revisions 1.71 to 1.75 |
| 146 |
|
- Preliminary seaice_growth.F clean-up, keeping test results strictly unchanged. |
| 147 |
|
The emphasis here was on improving readability (e.g. by trying to use meaningful |
| 148 |
|
variable names) and modularity (e.g. by adding arrays to store heff etc. updates). |
| 149 |
|
part 1.5: |
| 150 |
|
- revising the lab_sea experiment to make it a more useful (i.e. stable |
| 151 |
|
and representative of an actual model run). This was done by generating a |
| 152 |
|
(winter) pickup to start from, switching back the main experiment dynamic |
| 153 |
|
solver from evp to lsr, having one of the experiments use the free drift solution. |
| 154 |
|
part 2: seaice_growth.F revisions 1.76 to 1.85 |
| 155 |
|
- Sorting out hard-coded constants that prevented heat and fresh water conservation. |
| 156 |
|
- Sorting out the various fields units and sign (set early on and reset at the end) |
| 157 |
|
to avoid numerous scalings/re-scalings. By v1.85 the basic unit for ice, heat and |
| 158 |
|
fresh water stock is 'effective ice meters', and >0 implies more ice/snow. |
| 159 |
|
- Using tendency terms arrays (d_HEFF* etc.) to alleviate remaining code locks, |
| 160 |
|
and simplifying logical expressions to further improve readibility. |
| 161 |
|
part 3: seaice_growth.F revisions 1.86 to 1.89 |
| 162 |
|
- Re-organize the blocks of code more logically. |
| 163 |
|
- Merging the '_if.F' pieces that add something new. |
| 164 |
o pkg/thsice: |
o pkg/thsice: |
| 165 |
re-arrange calculation in THSICE_SOLVE4TEMP: move outside of i,j loops |
- vectorize thsice_solve4temp and thsice_get_exf. |
| 166 |
|
Problem: thsice_solve4temp has an unvectorizable statement that |
| 167 |
|
might also be problematic for TAF |
| 168 |
|
- thsice_get_exf: add the ALLOW_BULK_LARGEYEAGER04 CPP-flag. This |
| 169 |
|
does not change the verifcation experiment, but will change all |
| 170 |
|
experiments that have this flag undefined (not tested in verification); |
| 171 |
|
a little reorganization to save a few 2D fields and recomputations |
| 172 |
|
- 1st step of revisiting thsice adjoint (major recomp. sorted out) |
| 173 |
|
- 2nd step: fix some store dirs |
| 174 |
|
o seems to work somewhat, i.e. using ifort but not g77 |
| 175 |
|
o likely cause are incomplete init. or recomputation |
| 176 |
|
o start verification/global_ocean.cs32x15/input_ad.thsice |
| 177 |
|
o pkg/obcs: add support for exch2 |
| 178 |
|
- the position of the boundary and prescribed values are specified using |
| 179 |
|
a global domain with exch2 facets stacked |
| 180 |
|
- in x for N,S boundaries (like W2_mapIO=-1) |
| 181 |
|
- in y for E,W boundaries (so E,W boundaries do not overlap) |
| 182 |
|
o pkg/mdsio: add support for writing global sections with exch2 |
| 183 |
|
file layout is as for obcs described above: |
| 184 |
|
- for x-z sections, facets are stacked in x (like W2_mapIO=-1) |
| 185 |
|
- for y-z sections, facets are stacked in y |
| 186 |
|
o pkg/thsice: |
| 187 |
|
- change a few routines for better vectorization: thsice_albedo.F, |
| 188 |
|
thsice_step_temp.F, and in thsice_calc_thickn.F. Results are |
| 189 |
|
not affected, but in particular the latter routine has changed |
| 190 |
|
dramatically (not necessarily easier to read now). |
| 191 |
|
- re-arrange calculation in THSICE_SOLVE4TEMP: move outside of i,j loops |
| 192 |
iteration loop and call to S/R THSICE_GET_BULKF & THSICE_GET_EXF. |
iteration loop and call to S/R THSICE_GET_BULKF & THSICE_GET_EXF. |
| 193 |
o verification/lab_sea: |
o verification/lab_sea: |
| 194 |
- overhaul of the forward model experiments. The main motivation |
- overhaul of the forward model experiments. The main motivation |
| 195 |
for this revision is that lab_sea has proven quite fragile (when |
for this revision is that lab_sea has proven quite fragile (when |
| 196 |
changing the sea-ice code, and switching platforms) to a point |
changing the sea-ice code, and switching platforms) to a point |
| 197 |
when failures were very hard to attribute to specific code problems. |
when failures were very hard to attribute to specific code problems. |
| 198 |
- the suspected reason for this fragility is noise amplification by evp so, |
- the suspected reason for this fragility is noise amplification by evp so, |
| 199 |
to start with, we decided to replace evp with lsr in the main experiment. |
to start with, we decided to replace evp with lsr in the main experiment. |
| 200 |
- the input.lsr experiment thus became obsolete and was removed. |
- the input.lsr experiment thus became obsolete and was removed. |
| 201 |
- it was replaced with the input.fd experiment that uses an |
- it was replaced with the input.fd experiment that uses an |
| 202 |
analytical "free drift" solution as the ice velocity field. |
analytical "free drift" solution as the ice velocity field. |
| 203 |
- Taken together, input (lsr), input.fd (free drift) and input.hb87 (evp) |
- Taken together, input (lsr), input.fd (free drift) and input.hb87 (evp) |
| 204 |
will hopefully allow us to discriminate problems due to dynamic solvers |
will hopefully allow us to discriminate problems due to dynamic solvers |
| 205 |
from problems due to the thermodynamic code. input.salt_plume (lsr) allows |
from problems due to the thermodynamic code. input.salt_plume (lsr) allows |
| 206 |
us to test additional options, along with the salt plume package. |
us to test additional options, along with the salt plume package. |
| 207 |
- Finally a pickup was generated (at the end of a one year run) to |
- Finally a pickup was generated (at the end of a one year run) to |
| 208 |
make the tests more representative of an actual model run. Previously |
make the tests more representative of an actual model run. Previously |
| 209 |
the tests starting point was a 1m thickness of ice everywhere. |
the tests starting point was a 1m thickness of ice everywhere. |
| 210 |
o pkg/seaice: |
o pkg/seaice: |
| 211 |
- introducing S\R seaice_freedrift.F that compute the |
- introducing S\R seaice_freedrift.F that compute the |
| 212 |
analytical solution to an approximate ice momentum |
analytical solution to an approximate ice momentum |
| 213 |
equation (i.e. the simple stress/coriolis balance). |
equation (i.e. the simple stress/coriolis balance). |
| 214 |
- define SEAICE_ALLOW_FREEDRIFT to trigger the computation |
- define SEAICE_ALLOW_FREEDRIFT to trigger the computation |
| 215 |
of the free drift velocity field, and enable its use. |
of the free drift velocity field, and enable its use. |
| 216 |
To actually use the free drift solution as the model ice |
To actually use the free drift solution as the model ice |
| 217 |
velocity field set SEAICEuseFREEDRIFT to .TRUE. in data.seaice. |
velocity field set SEAICEuseFREEDRIFT to .TRUE. in data.seaice. |
| 218 |
o move "useOASIS" from PARAMS.h to EEPARAMS.h and read it from "eedata" |
o move "useOASIS" from PARAMS.h to EEPARAMS.h and read it from "eedata" |
| 219 |
|
|
| 220 |
checkpoint62l (2010/10/04) |
checkpoint62l (2010/10/04) |
| 535 |
but keep the former optfile for few weeks for smooth transition |
but keep the former optfile for few weeks for smooth transition |
| 536 |
o pkg/ecco |
o pkg/ecco |
| 537 |
- allow user defined cost function contributions |
- allow user defined cost function contributions |
| 538 |
CPP: ALLOW_USERCOST_CONTRIBUTION |
CPP: ALLOW_USERCOST_CONTRIBUTION |
| 539 |
USAGE: compute contributions in cost_usercost_all.F |
USAGE: compute contributions in cost_usercost_all.F |
| 540 |
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
| 541 |
the two options are complementary. |
the two options are complementary. |
| 542 |
o pkg/smooth |
o pkg/smooth |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch