| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg aim (2010/10/26): |
| 8 |
|
- Introduce ALLOW_INSOLATION, moving toward a more general incoming solar radiation |
| 9 |
|
formulation with obliquity, eccentricity, ... as run-time parameters, |
| 10 |
|
- Introduce diagnostics for top-of-the-atmaophere incoming solar radiation and |
| 11 |
|
upward shortwave radition at the surface (all-sky and clear-sky). |
| 12 |
|
|
| 13 |
|
o pkg/obcs: |
| 14 |
|
- writing sections with globalFiles=T does not work: switch to tiled-files |
| 15 |
|
when writing sections for OBCS (change pkg/rw/write_rec.F accordingly). |
| 16 |
|
- fix index bug (OB_Ie -> OB_Iw_) in obcs_apply_uvice.F |
| 17 |
|
- apply OBCS_SEAICE_COMPUTE_UVICE to both uice and vice at all obcs |
| 18 |
|
|
| 19 |
|
checkpoint62m (2010/10/21) |
| 20 |
|
o pkg/seaice: vectorize seaice_solve4temp.F |
| 21 |
|
- move iterations loops outside of i/j-loops |
| 22 |
|
- requires 2D arrays for TB and effConduct |
| 23 |
|
- add 2D iceOrNot to replace HICE_ACTUAL.GT.0, as HICE_ACTUAL is |
| 24 |
|
modified in this routine |
| 25 |
|
- a little bit of clean up, adjusting indentation, etc. |
| 26 |
|
- replaced a few TEN**a by exp(a*log(10.)) in new code for better |
| 27 |
|
performance and '**TWO' by '**2' (because TWO is a float), |
| 28 |
|
replaced ONE, ZERO |
| 29 |
|
o eesupp/src: |
| 30 |
|
fix flow dir for exch1_z_RX_cube, exch1_uv_RX_cube & exch1_bg_RX_cube |
| 31 |
|
o pkg/seaice/seaice_growth.F |
| 32 |
|
Revision 1.89 of seaice_growth.F completes the overall october 2010 revision and |
| 33 |
|
merging process. The merged routine has two branches, and one activates the 'evolution' |
| 34 |
|
branch by setting SEAICE_GROWTH_LEGACY to undef (at the top of the routine for now). |
| 35 |
|
In summary, here is what the '10/10 revision' did consist of |
| 36 |
|
part 1: seaice_growth.F revisions 1.71 to 1.75 |
| 37 |
|
- Preliminary seaice_growth.F clean-up, keeping test results strictly unchanged. |
| 38 |
|
The emphasis here was on improving readability (e.g. by trying to use meaningful |
| 39 |
|
variable names) and modularity (e.g. by adding arrays to store heff etc. updates). |
| 40 |
|
part 1.5: |
| 41 |
|
- revising the lab_sea experiment to make it a more useful (i.e. stable |
| 42 |
|
and representative of an actual model run). This was done by generating a |
| 43 |
|
(winter) pickup to start from, switching back the main experiment dynamic |
| 44 |
|
solver from evp to lsr, having one of the experiments use the free drift solution. |
| 45 |
|
part 2: seaice_growth.F revisions 1.76 to 1.85 |
| 46 |
|
- Sorting out hard-coded constants that prevented heat and fresh water conservation. |
| 47 |
|
- Sorting out the various fields units and sign (set early on and reset at the end) |
| 48 |
|
to avoid numerous scalings/re-scalings. By v1.85 the basic unit for ice, heat and |
| 49 |
|
fresh water stock is 'effective ice meters', and >0 implies more ice/snow. |
| 50 |
|
- Using tendency terms arrays (d_HEFF* etc.) to alleviate remaining code locks, |
| 51 |
|
and simplifying logical expressions to further improve readibility. |
| 52 |
|
part 3: seaice_growth.F revisions 1.86 to 1.89 |
| 53 |
|
- Re-organize the blocks of code more logically. |
| 54 |
|
- Merging the '_if.F' pieces that add something new. |
| 55 |
|
o pkg/thsice: |
| 56 |
|
- vectorize thsice_solve4temp and thsice_get_exf. |
| 57 |
|
Problem: thsice_solve4temp has an unvectorizable statement that |
| 58 |
|
might also be problematic for TAF |
| 59 |
|
- thsice_get_exf: add the ALLOW_BULK_LARGEYEAGER04 CPP-flag. This |
| 60 |
|
does not change the verifcation experiment, but will change all |
| 61 |
|
experiments that have this flag undefined (not tested in verification); |
| 62 |
|
a little reorganization to save a few 2D fields and recomputations |
| 63 |
|
- 1st step of revisiting thsice adjoint (major recomp. sorted out) |
| 64 |
|
- 2nd step: fix some store dirs |
| 65 |
|
o seems to work somewhat, i.e. using ifort but not g77 |
| 66 |
|
o likely cause are incomplete init. or recomputation |
| 67 |
|
o start verification/global_ocean.cs32x15/input_ad.thsice |
| 68 |
|
o pkg/obcs: add support for exch2 |
| 69 |
|
- the position of the boundary and prescribed values are specified using |
| 70 |
|
a global domain with exch2 facets stacked |
| 71 |
|
- in x for N,S boundaries (like W2_mapIO=-1) |
| 72 |
|
- in y for E,W boundaries (so E,W boundaries do not overlap) |
| 73 |
|
o pkg/mdsio: add support for writing global sections with exch2 |
| 74 |
|
file layout is as for obcs described above: |
| 75 |
|
- for x-z sections, facets are stacked in x (like W2_mapIO=-1) |
| 76 |
|
- for y-z sections, facets are stacked in y |
| 77 |
|
o pkg/thsice: |
| 78 |
|
- change a few routines for better vectorization: thsice_albedo.F, |
| 79 |
|
thsice_step_temp.F, and in thsice_calc_thickn.F. Results are |
| 80 |
|
not affected, but in particular the latter routine has changed |
| 81 |
|
dramatically (not necessarily easier to read now). |
| 82 |
|
- re-arrange calculation in THSICE_SOLVE4TEMP: move outside of i,j loops |
| 83 |
|
iteration loop and call to S/R THSICE_GET_BULKF & THSICE_GET_EXF. |
| 84 |
|
o verification/lab_sea: |
| 85 |
|
- overhaul of the forward model experiments. The main motivation |
| 86 |
|
for this revision is that lab_sea has proven quite fragile (when |
| 87 |
|
changing the sea-ice code, and switching platforms) to a point |
| 88 |
|
when failures were very hard to attribute to specific code problems. |
| 89 |
|
- the suspected reason for this fragility is noise amplification by evp so, |
| 90 |
|
to start with, we decided to replace evp with lsr in the main experiment. |
| 91 |
|
- the input.lsr experiment thus became obsolete and was removed. |
| 92 |
|
- it was replaced with the input.fd experiment that uses an |
| 93 |
|
analytical "free drift" solution as the ice velocity field. |
| 94 |
|
- Taken together, input (lsr), input.fd (free drift) and input.hb87 (evp) |
| 95 |
|
will hopefully allow us to discriminate problems due to dynamic solvers |
| 96 |
|
from problems due to the thermodynamic code. input.salt_plume (lsr) allows |
| 97 |
|
us to test additional options, along with the salt plume package. |
| 98 |
|
- Finally a pickup was generated (at the end of a one year run) to |
| 99 |
|
make the tests more representative of an actual model run. Previously |
| 100 |
|
the tests starting point was a 1m thickness of ice everywhere. |
| 101 |
|
o pkg/seaice: |
| 102 |
|
- introducing S\R seaice_freedrift.F that compute the |
| 103 |
|
analytical solution to an approximate ice momentum |
| 104 |
|
equation (i.e. the simple stress/coriolis balance). |
| 105 |
|
- define SEAICE_ALLOW_FREEDRIFT to trigger the computation |
| 106 |
|
of the free drift velocity field, and enable its use. |
| 107 |
|
To actually use the free drift solution as the model ice |
| 108 |
|
velocity field set SEAICEuseFREEDRIFT to .TRUE. in data.seaice. |
| 109 |
|
o move "useOASIS" from PARAMS.h to EEPARAMS.h and read it from "eedata" |
| 110 |
|
|
| 111 |
|
checkpoint62l (2010/10/04) |
| 112 |
|
o pkg/seaice: |
| 113 |
|
-fix the USE_ORIGINAL_SBI version (for variable freezing point); |
| 114 |
|
-use "celsius2K" in SEAICE_VARIABLE_FREEZING_POINT and in new |
| 115 |
|
version (with USE_ORIGINAL_SBI undef); |
| 116 |
|
o add hooks for new packages OASIS, the package will follow |
| 117 |
|
(hooks exclude the seaice pkg for now) |
| 118 |
|
o pkg/autodiff: ALLOW_AUTODIFF_WHTAPEIO |
| 119 |
|
Option to use mdsio_read_whalos.F/mdsio_write_whalos.F, |
| 120 |
|
rather than mdsio_readvector.F/mdsio_writevector.F, within |
| 121 |
|
adread_adwrite.F to read/write adjoint-related tapes to disk. |
| 122 |
|
o eesupp and pkg/mdsio: ALLOW_WHIO |
| 123 |
|
Option to write/read 2D fields to files including tiles halos. |
| 124 |
|
The main purpose is for adjoint related "tape I/O". |
| 125 |
|
The secondary purpose is for debugging phases. |
| 126 |
|
A word on those rather specifically intended purposes. |
| 127 |
|
The code was meant to be stripped down to the bare minimum. |
| 128 |
|
Typically, there is a unique and basic mapping to the global |
| 129 |
|
buffer (tile by tile, then proc by proc, then level by level), and |
| 130 |
|
byteswaps and meta-files are omitted. Indeed the (*_WH*) code is not |
| 131 |
|
meant to generate user friendly outputs of various shapes and forms. |
| 132 |
|
Rather it is intended, for the knowledgeabale developers, |
| 133 |
|
to be largely independent of the many mdsio options, to allow |
| 134 |
|
outputs of tiles+halos in debugging phases and in adjoint runs, |
| 135 |
|
and to allow some flexibility in tuning (adoint) I/O depending on each |
| 136 |
|
file system behavior. With regard to tuning, most of the potential knobs |
| 137 |
|
(to leave files open, to allocate the I/O indep. of usesinglecpuio, |
| 138 |
|
to specify directories, to specify the typical size of I/O calls, etc.) |
| 139 |
|
are not yet included, and will be added if they prove useful. |
| 140 |
|
o pkg/seaice: |
| 141 |
|
fix uninitialised arrays in USE_ORIGINAL_SBI version of seaice_solve4temp.F |
| 142 |
|
o pkg/seaice: |
| 143 |
|
new S/R seaice_solve4temp.F: this is the merged version of Ian Fenty |
| 144 |
|
code (seaice_budget_ice_if.F) which enable to recover old standard |
| 145 |
|
code (seaice_budget_ice.F) when option USE_ORIGINAL_SBI is defined. |
| 146 |
|
temporary: add "#define USE_ORIGINAL_SBI" at the top of seaice_solve4temp.F. |
| 147 |
|
o model/src (rStar): |
| 148 |
|
use simple average (not area weighted) of rStarFac at U,V point when using |
| 149 |
|
vectorInvariant and selectKEscheme=1,3 (consistent with mom. vertical advection) |
| 150 |
|
update output of exp. fizhi-cs-32x32x40 and fizhi-cs-aqualev20. |
| 151 |
|
|
| 152 |
|
checkpoint62k (2010/09/17) |
| 153 |
|
o adjoint |
| 154 |
|
* changed verification/global_ocean.cs32x15 ; adjoint now tests |
| 155 |
|
Adams-Bashforth 3 + NLFS + RSTAR |
| 156 |
|
* some more modifs required for ECCO-GODAE v4 |
| 157 |
|
o pkg/seaice |
| 158 |
|
add SEAICE_AGE_VOL option to use volume instead of area for |
| 159 |
|
integrating SEAICE_AGE |
| 160 |
|
o model/src: |
| 161 |
|
first check-in of sigma & hybrid-sigma coordinate code ; also includes |
| 162 |
|
non-linear free-surface parts ; but pressure-gradient not yet coded. |
| 163 |
|
o pkg/ptracers: |
| 164 |
|
option for ptracer to convert Salt Relax into additional EmP. |
| 165 |
|
tested in exp. global_ocean.90x40x15.dwnslp (update output) |
| 166 |
|
|
| 167 |
|
checkpoint62j (2010/08/25) |
| 168 |
|
o pkg/ggl90: |
| 169 |
|
other minor changes: remove 3-D temp array gTKE (+ add argument myIter) |
| 170 |
|
o pkg/dic: car_flux.F, phos_flux.F |
| 171 |
|
- reduce number of exp-calls in order to improve performance |
| 172 |
|
- clean up a little (replace fields by their macros, etc., fix |
| 173 |
|
typo in CPP-flag) |
| 174 |
|
o pkg/ggl90: minor changes |
| 175 |
|
- GGL90diffKrS was removed --> always use GGL90diffKr |
| 176 |
|
- GGL90viscAr was removed --> replaced with GGL90viscArU, GGL90viscArV |
| 177 |
|
- hack of mxlMaxFlag=2 --> ensure mixing between first and second level |
| 178 |
|
(commented out for now) |
| 179 |
|
- change in max/min operations to ensure that smoothing is ok |
| 180 |
|
- smoothing of GGL90viscAr was moved to ggl90_calc.F (as done for GGL90diffKr) |
| 181 |
|
- always use diffKrNrT as background profile (i.e. never use diffKr field) |
| 182 |
|
o pkg/cfc: bug fix, AREA(i,j,1,bi,bj) -> AREA(i,j,bi,bj) |
| 183 |
|
o pkg/dic: |
| 184 |
|
- model/src/impldiff.F: if TARGET_NEC_SX, extend loop ranges for better |
| 185 |
|
vectorization |
| 186 |
|
- small bug fix in insol for the unlikely case of a cartesian grid |
| 187 |
|
- towards vectorizing the dic package: bio_export.F, car_flux.F, phos_flux.F |
| 188 |
|
+ now vectorize, which also removes adjoint recomputations; |
| 189 |
|
+ replace integer maksp1 by _RL maskp1 |
| 190 |
|
+ replace a**x by exp(x*log(a)) in phos_flux.F for speed |
| 191 |
|
|
| 192 |
|
checkpoint62i (2010/07/21) |
| 193 |
|
o pkg/flt: |
| 194 |
|
- with OBCS: stop floats which enter the OB region |
| 195 |
|
o model/src: |
| 196 |
|
- use tempVertAdvScheme & saltVertAdvScheme (instead of horizontal ones) |
| 197 |
|
for implicit vertical advection. |
| 198 |
|
o pkg/seaice: |
| 199 |
|
- account for melting in seaice age evolution. |
| 200 |
|
- remove double counting of seaice ridging effect on seaice age. |
| 201 |
|
|
| 202 |
|
checkpoint62h (2010/06/18) |
| 203 |
|
o pkg/exch2: |
| 204 |
|
- remove exch2_*xy_rx files: call was replaced with exch2_*3d_rx(myNz=1). |
| 205 |
|
o tools/genmake2 |
| 206 |
|
- remove "-pdefault" option: redundant with the use of "packages.conf"; |
| 207 |
|
- remove file pkg/pkg_default : set the default as a pkg group |
| 208 |
|
("default_pkg_list") defined in pkg/pkg_groups; |
| 209 |
|
- fix for case pkg/pkg_depend is missing (was hanging before); |
| 210 |
|
- add option "-pgroups" to specify a different pkg_groups than the default. |
| 211 |
|
o verification/adjustment.cs-32x32x1: |
| 212 |
|
add a "minimal" set-up test (code_min & input_min) which only compiles |
| 213 |
|
eesupp/src and the 2 pkgs (exch2 & debug) which don't need model/src & inc. |
| 214 |
|
o tools/genmake2 |
| 215 |
|
- extend pkg_depend rules to model & eesupp (e.g., if model depend on [pkg])) |
| 216 |
|
- fix details of checking for mnc & profile pkg when NetCDF is unavailable. |
| 217 |
|
o pkg/exf: merge exf_bulk_largeyeager04 into exf_bulkformulae because these |
| 218 |
|
files are nearly the same anyway. |
| 219 |
|
Step 1: make exf_bulkformulae look like exf_bulk_largeyeager04: |
| 220 |
|
- redefinition of tau(i,i) (by a factor of ustar) |
| 221 |
|
- 1./exf(Const/T) -> exf(-Const/T) (big change in the results) |
| 222 |
|
- replace rhonil by rhoConstFresh in computation of evap (bug fix) |
| 223 |
|
- replace u/vstress=tau*rd*ws*cw by tau*rd*u/vwind (changes results) |
| 224 |
|
- replace |
| 225 |
|
rd(i,j)= rdn(i,j)/(exf_one - rdn(i,j)/karman*psimh ) |
| 226 |
|
shn = sh(i,j,bi,bj)*rd(i,j)/rdn(i,j) |
| 227 |
|
by |
| 228 |
|
shn = sh(i,j,bi,bj)/(exf_one - rdn(i,j)/karman*psimh ) |
| 229 |
|
(changes results) |
| 230 |
|
-> exf_bulkformulae v1.22, |
| 231 |
|
update verification experiments lab_sea, offline_exf_seaice, seaice_obcs |
| 232 |
|
(lab_sea: output.hb87.txt 1.11, output.lsr.txt 1.25, output.salt_plume.txt 1.13, |
| 233 |
|
output.txt 1.63 |
| 234 |
|
offline_exf_seaice: output.seaicetd.txt 1.7 |
| 235 |
|
seaice_obcs: output.txt 1.10) |
| 236 |
|
Step 2: do the actual merge and remove exf_bulk_largeyeager04.F |
| 237 |
|
-> exf_bulkformulae v1.23, |
| 238 |
|
unfortunately requires updating lab_sea.salt_plume (6 matching digits), |
| 239 |
|
and global_ocean.cs32x15.icedyn (only 11 matching digits) |
| 240 |
|
Also update output_adm of exp. lab_sea (all 4) and offline_exf_seaice. |
| 241 |
|
o adjoint of exch-1: |
| 242 |
|
- pass high-level EXCH S/R through TAF (eesupp/src/exch_ad_diff.list) |
| 243 |
|
(note: was already like this when using EXCH-2) and remove flow dir |
| 244 |
|
and hand-written AD version of high-level EXCH S/R (pkg/autodiff); |
| 245 |
|
- provide flow-dir for low-level exch1 S/R (eesupp/src/exch1_ad.flow); |
| 246 |
|
- update pkg/exch2 diff list. |
| 247 |
|
|
| 248 |
|
checkpoint62g (2010/05/19) |
| 249 |
|
o eesupp/src (exch-1): |
| 250 |
|
- split exch_rx.F into Forward S/R (exch1_rx.F) and Adjoint S/R (exch1_rx_ad.F) |
| 251 |
|
and remove argument "simulationMode"; same thing for all exch_*rx_cube.F |
| 252 |
|
(renamed to exch1_*rx_cube.F). |
| 253 |
|
- change accordingly exch_*_rx.template and AD version in pkg/autodiff |
| 254 |
|
to call new exch1 S/R ; update Makefile and .cvsignore. |
| 255 |
|
- replace call to exch2_xy_rx S/R with exch2_*3d_rx(myNz=1) (will remove |
| 256 |
|
exch2_xy_rx later) |
| 257 |
|
Note: after updating your code, need to run "make clean" in eesupp/src |
| 258 |
|
o test experiment bottom_ctrl_5x5: |
| 259 |
|
new output_adm.txt with fewer grdchk & less monitor output. |
| 260 |
|
o model/src: |
| 261 |
|
remove the call to ini_cori in initialise_varia.F (just keep the usual one |
| 262 |
|
in initialise_fixed.F). More consistent with coriolis & horizontal grid |
| 263 |
|
beeing treated in the same way (ini_grid is not called a 2nd time). |
| 264 |
|
o pkg/exf: |
| 265 |
|
- rewrite exf_bulk_largeyeager04.F for better vectorization, changes |
| 266 |
|
global_ocean.cs32x15/input.icedyn (11 digits of agreement), updated |
| 267 |
|
- fix adjoint (used worked for ALLOW_ATM_WIND defined, works for this now) |
| 268 |
|
- cosmetic changes to exf_bulkformulae.F to make it look more like |
| 269 |
|
exf_bulk_largeyeager04.F |
| 270 |
|
o eesupp/src (exch-1): |
| 271 |
|
- Fix AD EXCH code for 2-D domain special cases (Nx=1 or Ny=1). |
| 272 |
|
- Separate buffer filling and MPI sending: allow EXCH-1 to work for local |
| 273 |
|
array (non-shared) when using MPI+MTH. Also reduces number of BARRIER |
| 274 |
|
(even without using MPI). |
| 275 |
|
- Message mode: move RecvAck setting (indicator of buffer being ready) |
| 276 |
|
from send_put to recv_get S/R (was useless before, but not sure if |
| 277 |
|
it's much more useful now); |
| 278 |
|
- Switch the order of sync: MPI-proc 1rst and then threads; |
| 279 |
|
- take out spin-waiting code (#undef EXCH_USE_SPINNING), use BARRIER instead. |
| 280 |
|
- fix AD code for communication mode ='get' (but not used). |
| 281 |
|
o model/src: |
| 282 |
|
initialise dPhiHydX,dPhiHydY inside calc_grad_phi_hyd.F (so that TAF does |
| 283 |
|
not drop it in S/R mddynamics, producing NaN in hs94.1x64x5 AD-test exp). |
| 284 |
|
o utils/matlab/rdmnc.m: adapt to be able to use the generic matlab netcdf API |
| 285 |
|
o pkg/ctrl: require a specific set of control variables and exf-flags for |
| 286 |
|
adjoint of seaice (stop in ctrl_check.F if conditions are not satisfied) |
| 287 |
|
o model/src: |
| 288 |
|
a) 1rst version of a new driver S/R to turn-off output freq and flags after the |
| 289 |
|
1rst forward sweep, to avoid over-writing output files during recomputations |
| 290 |
|
recomputations (& grdchk); called from cost_final.F (& ctrl_init_ctrlvar.F ?) |
| 291 |
|
b) 2nd version: |
| 292 |
|
- add specific pkg S/R for seaice & ptracers (called from S/R TURNOFF_MODEL_IO); |
| 293 |
|
- switch-off more output flags (exf_monFreq, chkPtFreq, dumpInitAndLast, |
| 294 |
|
writePickupAtEnd) + seaice & ptracers output; |
| 295 |
|
- do not switch off MNC flags (otherwise, won't get admonitor netcdf file) |
| 296 |
|
o model/src: |
| 297 |
|
- new S/R rotate_uv2en_rl (..._rs) that rotates vector fields. |
| 298 |
|
o pkg/exch2: |
| 299 |
|
- remove "simulationMode" from arg. list of S/R EXCH2_RX1,2_CUBE ; |
| 300 |
|
- add argument "signOption" to EXCH2_RX1_CUBE (will be needed for SM exch). |
| 301 |
|
o pkg/autodiff & exch2: |
| 302 |
|
process exch_uv_agrid_3d_rx.f & exch2_uv_agrid_3d_rx.f through TAF |
| 303 |
|
(for now, only if ALLOW_EXCH2 is defined). |
| 304 |
|
o pkg/autodiff: |
| 305 |
|
- include PACKAGES_CONFIG.h in exch*ad.flow & exch*ad.F |
| 306 |
|
(not supposed to be in CPP_OPTIONS.h) to get ALLOW_EXCH2 defined correctly. |
| 307 |
|
+ clean-up comments (_RS is not always real*4) |
| 308 |
|
- fix bug in ADEXCH_UV_3D_RX (without EXCH2, was calling the forward exch S/R) |
| 309 |
|
- add a stop in ADEXCH_UV_AGRID_3D_RX if trying to use it with EXCH2: |
| 310 |
|
was calling a forward exch2, which is wrong ; used in SEAICE & EXF pkgs. |
| 311 |
|
o testreport (AD-tests): |
| 312 |
|
no longer link files from dir "../input" (1rst link files from |
| 313 |
|
"../input_ad.[xx]" if secondary test "xx" and then from "../input_ad") |
| 314 |
|
|
| 315 |
|
checkpoint62f (2010/04/29) |
| 316 |
|
o model/src/the_main_loop.F: |
| 317 |
|
adjust store directives for seaice evp and multicategory according to |
| 318 |
|
pkg/ecco/the_main_loop.F |
| 319 |
|
o adjoint: |
| 320 |
|
global_sum_ad was incomplete (noted many times by many people ;) |
| 321 |
|
nice description by Jean U. as follows: |
| 322 |
|
* allreduce(var) in global_sum.F can be interpreted as |
| 323 |
|
reduce(sum) followed by broadcast of sum. |
| 324 |
|
* The adjoint of that is |
| 325 |
|
sum(adjoint) followed by broadcast(summed adjoint value) |
| 326 |
|
or in other words, allreduce(sum, adjoint vars) |
| 327 |
|
We were missing the sum(adjoint)! |
| 328 |
|
Benign, except(!) for "global" scalars appearing in tile loops (bi,bj) |
| 329 |
|
(noted by J.M. Campin, e.g., in cost_ssh_mean, variable offset). |
| 330 |
|
The fix should produce 16-digit accuracy between |
| 331 |
|
single-CPU multi-tile (e.g. nSx=2, nPx=1) and |
| 332 |
|
multi-CPU single-tile (e.g. nSx=1, nPx-2) |
| 333 |
|
We'll probably change this yet again shortly |
| 334 |
|
o eesupp/src: |
| 335 |
|
- fix global_sum_r4 (wrong from previous modif in Jun 2009; ever used ?) |
| 336 |
|
o pkg/icefront |
| 337 |
|
- ALLOW_SUBGLACIAL_RUNOFF option adds capability for time-evolving |
| 338 |
|
specification of addmass array based on a 2D field, which is added |
| 339 |
|
at bottommost wet level at each horizontal location. |
| 340 |
|
o model/src: |
| 341 |
|
horizontal grid initialisation (other than curvilinear): add code for Exch2 IO |
| 342 |
|
layout; (not always compatible with delX,delY setting; commented out for now). |
| 343 |
|
o pkg/exch2: |
| 344 |
|
change tile to processor setting (case nSy*nPy > 1): allows default model mapping |
| 345 |
|
(myX and myYGlobalLow) to be used for simple (1 facet, no blank tile) config. |
| 346 |
|
|
| 347 |
|
checkpoint62e (2010/04/15) |
| 348 |
|
o pkg/obcs: |
| 349 |
|
- fix wrong index in OBCS_SPONGE_V for Eastern-OB (reported by David Hebert). |
| 350 |
|
o pkg/dic: |
| 351 |
|
-fix bug in fe_chem.F for multi-tile (nSx*nSy > 1) set-up; |
| 352 |
|
(note: not presently tested in any forward verification exp.) |
| 353 |
|
update tutorial_global_oce_biogeo AD output file. |
| 354 |
|
o pkg/exf: |
| 355 |
|
- account for the variation of albedo as a function of zenith angle |
| 356 |
|
by defining ALLOW_ZENITHANGLE in EXF_OPTIONS.h |
| 357 |
|
o build_options: |
| 358 |
|
- rename "linux_ia64_ifort+mpi_ice_nas" to "linux_amd64_ifort+mpi_ice_nas" |
| 359 |
|
o pkg/dic: |
| 360 |
|
change DIC atmos-CO2 box (method 3, dic_int1=3) initialisation & restart: |
| 361 |
|
- use binary pickup file for restart; |
| 362 |
|
- initialise atmos-CO2 box from dic_pCO2 parameter; |
| 363 |
|
- fix multi-threaded. |
| 364 |
|
o pkg/rbcs: |
| 365 |
|
- clean-up RBCS code: add RBCS_OPTIONS.h file ; fix multi-threaded ; |
| 366 |
|
change (+ fix IO calls) type of array RBC_mask from _RL to _RS. |
| 367 |
|
- add RBCS to exp4 passive tracer 01 (rbcs was previously untested) |
| 368 |
|
and update output.txt |
| 369 |
|
o pkg/kpp: |
| 370 |
|
- add diagnostics for KPP non-local flux of Temp, Salinity and pTracers; |
| 371 |
|
- change diagnostic of KPP non-local term: output average of KPPghat*KPPdiffKzS |
| 372 |
|
(= ratio of KPP non-local (salt) flux relative to surface-flux) when |
| 373 |
|
using pkg/timeave & pkg/diagnostics (diag 'KPPghatK' replaces 'KPPghat '); |
| 374 |
|
- change pkg/offline to read-in average KPPghat*KPPdiffKzS from file |
| 375 |
|
KPP_ghatKFile (instead of the average of KPPghat from file KPP_ghatFile). |
| 376 |
|
o pkg/offline: |
| 377 |
|
fix bug in S/R OFFLINE_FIELDS_LOAD regarding surfaceForcing conversion factor |
| 378 |
|
(bug was added in version 1.10 on 2007-08-23). |
| 379 |
|
o pkg/offline: |
| 380 |
|
- no need to specify periodicExternalForcing, etc ... to use offline pack |
| 381 |
|
- offline input files no longer just single prec --> parameter offlineLoadPrec |
| 382 |
|
o verification/lab_sea: |
| 383 |
|
change AD test to multi-tile setup and update all 4 AD output. |
| 384 |
|
NOTE: while cost function values remain very similar, |
| 385 |
|
gradients are very different, although gradient checks are self-consistent |
| 386 |
|
Should try to get to the bottom of this (cost function summation order?) |
| 387 |
|
o pkg/dic: |
| 388 |
|
in carbon_chem.F, replace log10 (AUTODIFF) with explicit form to avoid |
| 389 |
|
a weakness of TAF that drops part of double precision in log10 derivative. |
| 390 |
|
<= changes removed since problem has been fixed in current TAF version 1.9.71 |
| 391 |
|
update AD output of exp. tutorial_dic_adjoffline & tutorial_global_oce_biogeo. |
| 392 |
|
o pkg/ecco: |
| 393 |
|
add missing "_d 0" in cost_readers.F, cost_readtopex.F & cost_readtopexmean.F |
| 394 |
|
update all 4 lab_sea AD output. |
| 395 |
|
|
| 396 |
|
checkpoint62d (2010/03/22) |
| 397 |
|
o build_options: |
| 398 |
|
remove '-r8' (and '-i4') from linux_*pgf and linux_*ifort optfiles. |
| 399 |
|
o remove unbalanced quote (single or double) in commented line of source code |
| 400 |
|
(may cause some warning with some preprocessor/makedepend versions). |
| 401 |
|
o pkg/seaice: |
| 402 |
|
fix seaice_model.F for adjoint (gael) and update AD results of experiments |
| 403 |
|
lab_sea (std + evp + noseaicedyn) and offline_exf_seaice. |
| 404 |
|
o testreport: |
| 405 |
|
add option '-runonly' (short: '-ro') to just do the run part (without make). |
| 406 |
|
o eesupp: remove JAM communication code (obsolete). |
| 407 |
|
o add option to genmake2 & testreport to switch "_RS" type to "real*4" |
| 408 |
|
(if allowed in CPP_EEOPTIONS.h); update default CPP_EEOPTIONS.h and return |
| 409 |
|
to default CPP_EEOPTIONS.h for exp. inverted_barometer & solid-body.cs-32x32x1 |
| 410 |
|
(update also the output). |
| 411 |
|
|
| 412 |
|
checkpoint62c (2010/03/02) |
| 413 |
|
o tools/build_options : |
| 414 |
|
move (some) old optfiles from build_options/ to build_options/unsupported/ |
| 415 |
|
o model/src and pkg/exf |
| 416 |
|
surface relaxation -- separating data and data.exf options |
| 417 |
|
The point is to ensure that we specify the surface relaxation |
| 418 |
|
either in data or in data.exf (but not half and half) and to |
| 419 |
|
avoid an accidental relaxation to 0 (which happened if a time |
| 420 |
|
scale was specified but the file name was left empty) |
| 421 |
|
o model/src model/inc and pkg/mom_common |
| 422 |
|
ALLOW_3D_VISCAH/ALLOW_3D_VISCA4 => 3D specification of Viscosity |
| 423 |
|
=> addition to the viscosity field as computed by others schemes |
| 424 |
|
o tools/build_options: |
| 425 |
|
- rename "_generic_mpi" -> "+mpi_generic" (like other "+mpi" optfile) |
| 426 |
|
but keep the former optfile for few weeks for smooth transition |
| 427 |
|
o pkg/ecco |
| 428 |
|
- allow user defined cost function contributions |
| 429 |
|
CPP: ALLOW_USERCOST_CONTRIBUTION |
| 430 |
|
USAGE: compute contributions in cost_usercost_all.F |
| 431 |
|
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
| 432 |
|
the two options are complementary. |
| 433 |
|
o pkg/smooth |
| 434 |
|
- migration from contrib to the main repository |
| 435 |
|
|
| 436 |
|
checkpoint62b (2010/01/26) |
| 437 |
|
o pkg/monitor: |
| 438 |
|
- change back mon_printstats_rl.F & mon_stats_rl.F and add a stop |
| 439 |
|
(in case someone forgot to update customized pieces of code) |
| 440 |
|
o nonHydrostatic: |
| 441 |
|
- add Non-hydrostatic free-surface form (selectNHfreeSurf=1)(not fully tested); |
| 442 |
|
- add a simple 2-D experiment (short_surf_wave) to test it. |
| 443 |
|
o pkg/icefront: |
| 444 |
|
adding the shell of, and the hooks to, a new package that |
| 445 |
|
will model melting and freezing of vertical glacier ice fronts |
| 446 |
|
o momentum: |
| 447 |
|
add diagnostics of momentum tendency from Hydrostatic pressure gradient |
| 448 |
|
(without surf.pressure term: would need a 2nd filling since implicit term). |
| 449 |
|
o add 3 "_d 0"s so that fizhi compiles with xlf on iblade, and replace |
| 450 |
|
two " &end" by " &" (in fizhi-cs-*) because S/R NML_SET_TERMINATOR |
| 451 |
|
cannot deal with the former |
| 452 |
|
o cleaning: |
| 453 |
|
- remove all (except OpenAD) old TLM output from results_ad dirs. |
| 454 |
|
- remove unused S/R (MDSWRITEMETA, DIAGNOSTICS_ADD2LIST, old DFILE IO S/R) |
| 455 |
|
- comment out maskH definition (replaced by maskInC) |
| 456 |
|
o pkg/monitor: |
| 457 |
|
- change mon_printstats_rl.F & mon_stats_rl.F (were similar to mon_writestats_rl |
| 458 |
|
& mon_calc_stats_rl) to be the RL equivalent of mon_printstats_rs & mon_stats_rs. |
| 459 |
|
|
| 460 |
|
checkpoint62a (2010/01/15) |
| 461 |
|
o model/src: |
| 462 |
|
- bottom pressure diagnostic: correct for r* (when nonlinFreeSurf >= 4) |
| 463 |
|
o pkg/diagnostics: |
| 464 |
|
- add optional level number diagnostics (i.e., level number to be define |
| 465 |
|
explictly with S/R DIAGNOSTICS_SETKLEV) with parser-code(10)="X". |
| 466 |
|
- strictly check for valid parser-code(10) ; |
| 467 |
|
- check if adding diag to the list from the right place. |
| 468 |
o pkg/longstep: |
o pkg/longstep: |
| 469 |
- change parameters and fix tracer conservation with rstar/nonlinear free surface |
- change parameters and fix tracer conservation with rstar/nonlinear free surface |
| 470 |
o diagnostics: |
o diagnostics: |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch