| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
o model/src/ini_curvilinear_grid.F: |
o pkg ctrl |
| 8 |
compute angleSin/CosC when they are not read from a file |
- make obcs as control parameter work also with useSingleCPUio |
| 9 |
|
- replace a few sny and snx by Ny and Nx to be consistent with |
| 10 |
|
ctrl_set_globfld_x/yz.F |
| 11 |
|
o pkg seaice |
| 12 |
|
- re-introduce global field frWtrAtm for the case of |
| 13 |
|
ALLOW_MEAN_SFLUX_COST_CONTRIBUTION defined (SEAICE.h, seaice_growth.F) |
| 14 |
|
- catch the case of an empty filename in seaice_cost_init_fixed.F |
| 15 |
|
o pkg ecco: |
| 16 |
|
- small bug fixes in the_main_loop |
| 17 |
|
. fix order of monitor arguments |
| 18 |
|
. change SEAICE_MULTILEVEL to SEAICE_MULTICATEGORY |
| 19 |
|
. move include DYNVARS.h up outside the ALLOW_AUTODIFF_TAMC block so |
| 20 |
|
that ALLOW_ECCO_FORWARD_RUN works with NONLIN_FRSURF |
| 21 |
|
- replace cos(yc*deg2rad) by _rA in cost_mean_heat/saltflux.F, fix the |
| 22 |
|
imbalance diagnostics for wmean_h/sflux = 0 |
| 23 |
|
- add actual values to f_obcsn/s/w/e in ecco_cost_final.F |
| 24 |
|
- catch the case of empty filenames in ecco_cost_init_fixed.F |
| 25 |
|
and ecco_readparms.F |
| 26 |
|
- fix the logic of wsalt=0.and.wsalt2=0 to wsalt=0.or.wsalt2=0 (and theta) |
| 27 |
|
to make this statement meaningfull in ecco_cost_weights.F |
| 28 |
|
o pkg zonal_filt: |
| 29 |
|
- change ZONAL_FILTER S/R interface (allows to filter 2-D fields) |
| 30 |
|
- when using rStar, filter uVel*hFacW instead of uVel |
| 31 |
|
(tested without topography: fix a Pb of growing instability with NLFS) |
| 32 |
|
o pkg/aim/thsice: |
| 33 |
|
-Add capacity to read a Q-Flux to be applied in slab-mixed layer thsice_slab_ocean.F |
| 34 |
|
(works as SST restoring) |
| 35 |
|
o pkg/thsice: |
| 36 |
|
-add specific parameter for salt restoring in slab mixed-layer |
| 37 |
|
(by default equal to the temperature restoring) |
| 38 |
|
|
| 39 |
|
checkpoint61v |
| 40 |
|
o pkg/kpp: |
| 41 |
|
-add double diffusive contributions as a hack, turned off by default |
| 42 |
|
for now, and the code can be excluded with a CPP-flag |
| 43 |
|
EXCLUDE_KPP_DOUBLEDIFF just as EXCLUDE_KPP_SHEAR_MIX |
| 44 |
|
-add a verification experiments to "vermix" to test this code |
| 45 |
|
o pkg/mom_common: |
| 46 |
|
Move computation of length scales to mom_init_fixed.F (avoid recomputation |
| 47 |
|
at each time-steps*levels). |
| 48 |
|
o pkg/layers: |
| 49 |
|
Created a new package for computing volume fluxes in temperature or |
| 50 |
|
[not yet implemented] density layers, e.g. for calculating residual |
| 51 |
|
overturning circulations. |
| 52 |
|
o pkg/diagnostics: |
| 53 |
|
implement a RS type version for the set of DIAGNOSTICS-FILL subroutines |
| 54 |
|
o fix few RS/RL type mismatch (check with ifort 11.1 "-warn all" option) |
| 55 |
|
o pkg/mdsio (& pkg/rw): rework high level S/R interface: |
| 56 |
|
To avoid mixing type (RS/RL) of input/output array argument, |
| 57 |
|
replace single mixed-type array with a pair from each type (RS/RL). |
| 58 |
|
o setting pickupSuff force to start from a pickup (even if nIter0=0): this |
| 59 |
|
is now implemented for all pkgs (previously only done for the main pickup) |
| 60 |
|
|
| 61 |
|
checkpoint61u |
| 62 |
|
o pkg/obcs: |
| 63 |
|
- change OB?eta from _RS to _RL and put them into a separate commen block |
| 64 |
|
- add code to read OB?eta from a file via obcs_prescribe_read: the code |
| 65 |
|
compiles and does not destroy any other experiments, the data is read |
| 66 |
|
properly, but the code is not tested in actual applications |
| 67 |
|
o ini_mnc_vars.F: if available (ALLOW_CAL), use startTime_1 and 2 to |
| 68 |
|
create a meaningful unit attribute for the time coordinate variable |
| 69 |
|
o pkg/ebm: add plenty of missing "_d 0" ; |
| 70 |
|
update results of experiment global_ocean_ebm (fwd + adjoint tests) |
| 71 |
|
Notes: several pieces of code only works for (very) specific set up |
| 72 |
|
(domain size, lat range, etc ...); should be documented & stop if one |
| 73 |
|
of those assumptions is not meet. |
| 74 |
|
o pkg/seaice: add missing "_d 0" in HSNOW initialisation |
| 75 |
|
update results of experiments: lab_sea (3 fwd tests + 2 adjoint tests) |
| 76 |
|
and offline_exf_seaice (seaicetd + adjoint). |
| 77 |
|
o add missing "_d 0" in ShortWave flux penetration (S/R SWFRAC): |
| 78 |
|
update results of experiments: lab_sea (4 fwd tests + 3 adjoint), |
| 79 |
|
seaice_obcs, global_ocean.cs32x15 (icedyn & thsice) and natl_box (x2). |
| 80 |
|
o few changes to pass when compiling with strick checking of arguments |
| 81 |
|
across S/R (allow to find few bugs in S/R calls). |
| 82 |
|
o pkg/seaice: |
| 83 |
|
- seaice_evp: move if-statement out of loop (TEM) at the cost of 11 new |
| 84 |
|
2d-fields, for slightly better performance |
| 85 |
|
|
| 86 |
|
checkpoint61t |
| 87 |
|
o pkg/seaice: |
| 88 |
|
- remove unused variables in seaice_evp |
| 89 |
|
- reduce number of SQRT in seaice_evp and seaice_calc_viscosities |
| 90 |
|
o eeset_parms.F, open_copy_data_file.F & ini_parms.F: |
| 91 |
|
named file replacing SCRATCH files (for TARGET_BGL & TARGET_CRAYXT): |
| 92 |
|
each processor opens a different file (a fix from Matt). |
| 93 |
|
o cg2d: |
| 94 |
|
use simple EXCH (overlap size = 1 and ignore corners), like in cg3d.F : |
| 95 |
|
this reduces number of EXCH calls by 2 when using exch2. |
| 96 |
|
For now, keep previous size array for gc2d_nsa.F to avoid Pb with store |
| 97 |
|
directives and missing simple EXCH (exch_s3d_rx) adjoint code. |
| 98 |
|
o pkg/thsice: |
| 99 |
|
add code for Near Infra-Red albedo (from Jeff) |
| 100 |
|
(turned on with run-time flag: thSIce_calc_albNIR, in data.ice). |
| 101 |
|
o ini_model_io: |
| 102 |
|
move (from packages_readparms.F & initialise_fixed.F) to ini_model_io.F |
| 103 |
|
MNC & MONITOR initialisation calls; move MNC calls from {pkg}_readparms.F |
| 104 |
|
to {pkg}_init_fixed.F for {pkg}= kpp, seaice & shelfice. |
| 105 |
|
|
| 106 |
|
checkpoint61s |
| 107 |
|
o pkg/exch2 (exch2_rxN_cube*): |
| 108 |
|
remove last BARRIER (no need to synchronise after getting data from shared |
| 109 |
|
buffer (get) as long as any change to buffer (put,recv) is between BARRIER) |
| 110 |
|
o change tiling of natl_box (from 2 to 4 tiles) to get it tested with MPI+MTH |
| 111 |
|
and generate new output (for the 2 tests) using default rotationPeriod. |
| 112 |
|
o pkg/exch2: |
| 113 |
|
- always call exch2_*_cube, not exch-1 anymore, if useCubedSphereExchange=F |
| 114 |
|
(was already the case with AUTODIFF_EXCH2 defined) |
| 115 |
|
- add bj in exch2 arrays and S/R. |
| 116 |
|
- can now use pkg/exch2 for regular (non CS) set-up; switch test experiment |
| 117 |
|
MLAdjust to exch2 (identical results except with MPI -> truncation diff); |
| 118 |
|
o add pkg/longstep for ptracer timestep a multiple of U/V/T/S timestep |
| 119 |
|
- adds deltaT argument to the subroutines TIMESTEP_TRACER DWNSLP_APPLY |
| 120 |
|
GAD_ADVECTION GAD_CALC_RHS GAD_IMPLICIT_R GAD_SOM_ADVECT |
| 121 |
|
- verification experiment natl_box.longstep |
| 122 |
|
o build_options: ifort+mpi_aces optfile (following Constantinos advise): |
| 123 |
|
allow different versions of ifort (8 or 9) and different versions |
| 124 |
|
of mpi (mpich or mpich2) to be used with the same optfile. |
| 125 |
|
requires to load a netcdf module and set MPI_INC_DIR (see comments inside |
| 126 |
|
optfile). Change testing scripts (example_scripts/ACESgrid) accordingly. |
| 127 |
o pkg/seaice: |
o pkg/seaice: |
| 128 |
|
fix previous modif (3-level field removed) for old-pickup reading |
| 129 |
|
|
| 130 |
|
checkpoint61r |
| 131 |
|
o pkg/seaice: |
| 132 |
|
- clean up the 3-time levels of UICE,VICE,HEFF,AREA in three steps: |
| 133 |
|
1. introduce fields for time step (N-1) |
| 134 |
|
2. do not use levels 2 and 3 anymore (but keep them) |
| 135 |
|
3. replace 3D versions of UICE,VICE,HEFF,AREA by 2D versions. This |
| 136 |
|
includes changes to pkg/thsice/thsice_get_velocity.F, |
| 137 |
|
model/src/external_forcing_surf.F, pkg/obcs/obcs_apply_seaice.F, and |
| 138 |
|
pkg/obcs/obcs_apply_uvice.F. |
| 139 |
|
- completely remove code for leap-frog time stepping for second order |
| 140 |
|
advection |
| 141 |
|
- adjusted adjoint accordingly; |
| 142 |
|
gradient checks have improved by an order of magnitude! |
| 143 |
|
|
| 144 |
|
checkpoint61q |
| 145 |
|
o pkg/seaice: fix bug in free slip boundary conditons for LSOR solver |
| 146 |
|
- the boundary conditions along open boundaries are unclear, because the |
| 147 |
|
associated masks are set to zero and are thus treated as closed when |
| 148 |
|
applying the slip-boundary conditions. |
| 149 |
|
- move initialisation of grid variables from seaice_init_varia to _fixed |
| 150 |
|
o adding doc/diags_changes.txt |
| 151 |
|
o model/src: |
| 152 |
|
do_the_model_io: rename few pkg S/R which are called from do_the_model_io, |
| 153 |
|
to avoid "_diags" naming if no relation to pkg/diagnostics. |
| 154 |
|
ini_theta,ini_salt: fix (at least compile the code) reading from NetCDF |
| 155 |
|
file and only call PLOT_FIELD_XYZ if debugMode=T. |
| 156 |
|
remove few PLOT_FIELD_XY calls outside initialisation. |
| 157 |
|
remove few unnecessary BARRIER. |
| 158 |
|
o pkg/salt_plume: add SaltPlumeSouthernOcean to allow disabling |
| 159 |
|
of salt_plume package in Southern Ocean |
| 160 |
|
o pkg/thsice: |
| 161 |
|
- fix hOceMxL in overlap (needed for sea-ice advection); |
| 162 |
|
update output of experiment global_ocean.cs32x15.icedyn. |
| 163 |
|
o pkg/seaice: |
| 164 |
|
- make the (placeholder-)tracer IceAge a little more meaningful |
| 165 |
|
by avoiding ridging of age due to convergent ice flow |
| 166 |
|
- add diagnostics for surface temperature, atmospheric and oceanic |
| 167 |
|
heat flux, and atmospheric and oceanic ice growth |
| 168 |
|
|
| 169 |
|
checkpoint61p |
| 170 |
|
o eesupp (global_max & global_sum): |
| 171 |
|
- add one more element to buffer (start at index 0) for GL_MAX/SUM output; |
| 172 |
|
- remove starting & endding barrier (no longer needed) |
| 173 |
|
o pkg/mdsio, writelocal: |
| 174 |
|
works also in multi-threaded when LOCBIN_IO_THREAD_SAFE is undefined |
| 175 |
|
(remove the STOP): uses shared buffer IO to store data from all threads |
| 176 |
|
and then let master-thread write nThreads tiles. |
| 177 |
|
o pkg/mdsio (read/write field): |
| 178 |
|
- tiled IO done in 1 piece (all levels at a time); |
| 179 |
|
- new header file "MDSIO_BUFF_3D.h" with 3-D buffers. |
| 180 |
|
- multi-threaded: allow to read/write local (non-shared) array |
| 181 |
|
(was already working with singleCpuIO ; now works also without); |
| 182 |
|
=> no longer needs barrier call after reading a file (added inside |
| 183 |
|
mds_read/write field). |
| 184 |
|
- move barrier calls outside gather/scatter_2d to mds_read/write_field |
| 185 |
|
o pkg/obcs/exf |
| 186 |
|
- exf_getffieldrec.F: add a few ". _d 0" and |
| 187 |
|
add code to catch the case fldperiod = 0. |
| 188 |
|
- obcs_precribe_read.F: change if statements so that they match |
| 189 |
|
the variable type (_RL) |
| 190 |
|
- add a separate exf_iprec_obcs to exf_set_obcs (by default equal to |
| 191 |
|
exf_iprec) as part of namelist EXF_NML_01 |
| 192 |
|
o pkg/mdsio: |
| 193 |
|
- read/write tiled (local) files: read/write 1-level tile chunk at a time |
| 194 |
|
(instead of segment of length sNx); expected to speed up tiled IO. |
| 195 |
|
o pkg/exch2: |
| 196 |
|
- take buffer copy from/to array out of S/R exch2_send/recv into new |
| 197 |
|
S/R exch2_put/get ; Exch of local variable now works with MPI+MTH |
| 198 |
|
(tested by removing commom block statement in SOLVE_FOR_PRESSURE.h). |
| 199 |
|
- ad version of send/recv no longer needed (but needs exch2_ad_put/ad_get) |
| 200 |
|
- simplify argument list of S/R exch2_get_uv_bounds and exch2_get_scal_bounds |
| 201 |
|
(which replaces exch2_get_recv_bounds & exch2_get_send_bounds) by |
| 202 |
|
including Topology header file (and common blocks). |
| 203 |
|
- implement EXCH_IGNORE_CORNERS in scalar exchange (rx1); |
| 204 |
|
remove 2nd exch call in exch2_s3d_rx (no longer needed). |
| 205 |
|
- document S/R arg. list (+ update some comments) |
| 206 |
|
o pkg/seaice: |
| 207 |
|
- added SEAICE_CLIM_AIR code, which permits modulation of surface air |
| 208 |
|
temperature and humidity over sea ice based on climatological values. |
| 209 |
|
- clean up computation of Hibler+Bryan (1987) stress coupling for the case |
| 210 |
|
of LSR (this change is expected to change the results slightly because now |
| 211 |
|
it uses slightly difference moduli from the second last LSR solution, but |
| 212 |
|
that is more consistent with the stress computations; this part of the code |
| 213 |
|
is not tested in the verification experiments) |
| 214 |
|
- fix diagnostics for flux of ice in case of B-grid |
| 215 |
|
- turn strain rates eij and press into global fields within global |
| 216 |
|
common block in SEAICE.h for more straighforward diagnostics |
| 217 |
|
- fix diagnostics for principal stress components, press, zeta, eta |
| 218 |
|
to give something meaning full |
| 219 |
|
o change tiling of global_ocean.cs32x15 (12 tiles, 32x16) and generate |
| 220 |
|
new output (all 4 tests) using default rotationPeriod. |
| 221 |
|
o pkg KPP: |
| 222 |
|
- add flag (LimitHblStable) to avoid limiting BL depth under stable conditions |
| 223 |
|
- fix vertical indices in RI_IWMIX (match between KPP grid from 0 to Nr+1 |
| 224 |
|
and normal grid from 1 to Nr) |
| 225 |
|
o Fix computations of L4rdt in mom_calc_visc.F |
| 226 |
|
o eesupp: |
| 227 |
|
new S/R ALL_PROC_DIE (like EEDIE, without irrelevant threads err msg): |
| 228 |
|
should be called before a "stop" if we know that all process are going |
| 229 |
|
to stop; if one Proc does call this S/R, will hang in MPI_FINALISE. |
| 230 |
|
|
| 231 |
|
checkpoint61o |
| 232 |
|
o pkg/exch2: change check_depths to issue just a warning (instead of error+stop) |
| 233 |
|
o model/src/ini_curvilinear_grid.F: |
| 234 |
|
compute angleSin/CosC when they are not read from a file |
| 235 |
|
o pkg/seaice: |
| 236 |
add pseudo time stepping for LSOR |
add pseudo time stepping for LSOR |
| 237 |
o pkg/exch2: |
o pkg/exch2: |
| 238 |
temporary fix for exch2_s3d_rx; update results of exp. hs94.cs-32x32x5.impIGW |
temporary fix for exch2_s3d_rx; update results of exp. hs94.cs-32x32x5.impIGW |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch