| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o adjoint testing: in preparation for changing testreport: |
| 8 |
|
- output format: cost and grad written on separated lines |
| 9 |
|
- ad output results in directory "results" (instead of "results_ad") |
| 10 |
|
o pkg/seaice: adding ice salinity HSALT as a prognostic variable |
| 11 |
|
o pkg/seaice: changes for using pkg/seaice with pkg/obcs |
| 12 |
|
o pkg/ecco: allow user defined cost function contributions |
| 13 |
|
o testreport: |
| 14 |
|
Allow to choose (per experiment) the list of tested output variables |
| 15 |
|
and the main variable (used to issue a pass/FAIL ) ; |
| 16 |
|
- for now, done by adding the specific list in file: [exp]/input/tr_checklist |
| 17 |
|
- default is unchanged: >cg2d< , (T,S,U,V,5 tracers)_[min,max,mean,StD] ; |
| 18 |
|
Also modify printing of summary: |
| 19 |
|
a) ">" NN "<" indicates the "main" variable (used for pass/FAIL) |
| 20 |
|
b) echo the list of tested variables in the individual summary.txt of |
| 21 |
|
each experiment. |
| 22 |
|
o new S/R GLOBAL_SUM_TILE to compute global sum independently of number of |
| 23 |
|
threads and number of processes (with #define GLOBAL_SUM_SEND_RECV) |
| 24 |
|
(but still depend on the tile decompostion of the domain). |
| 25 |
|
o pkg/seaice: change a discretization detail to make the B-grid code |
| 26 |
|
"more symmetric". This change is likely to remove all "ridges/leads" that |
| 27 |
|
where quasi-aligned with the grid in B-grid solutions. It may also be |
| 28 |
|
the solution to the stress coupling issues with the B-grid. |
| 29 |
|
o each tested exp: add a "run" directory with a standard ".cvsignore" file ; |
| 30 |
|
remove .cvsignore from input dir. (since testreport no longer run here). |
| 31 |
|
o pkg/thsice: |
| 32 |
|
- cleaning: move common block out of "THSICE_2DYN.h" (removed) to "THSICE_VARS.h" |
| 33 |
|
- fix reshaping of sea-ice just after advection: |
| 34 |
|
melt all the ice only if ice-volume is too small. |
| 35 |
|
- re-visit lateral/thinning repartition of melting (modifs from May 04, 2007): |
| 36 |
|
prevent lateral melting if sea-ice fraction is too close to iceMaskMin ; |
| 37 |
|
and update experiment global_ocean.cs32x15.icedyn (+start from pickup files). |
| 38 |
|
o external_forcing_surf : extend the use of salt_EvPrRn & temp_EvPrRn (fresh-water |
| 39 |
|
tracer content) to linFS or no RealFreshWaterFlux ; default remains unchanged. |
| 40 |
|
o define mass2rUnit & rUnit2mass as units conversion factor, used for surface |
| 41 |
|
forcing. mass2rUnit: from mass per unit area [kg/m2] to r-coordinate unit |
| 42 |
|
(z-coord: =1/rhoConst ; p-coord: =gravity) ; rUnit2mass is just the reverse; |
| 43 |
|
and remove horiVertRatio (& recip_horiVertRatio). Affects truncation error |
| 44 |
|
of exp. global_oce_in_p: 10 16 16 14 16 13 16 16 16 13 13 13 16 13 13 12 16 |
| 45 |
|
-> update output.txt |
| 46 |
|
o pkg/cd_code: add brackets in multiple terms sum (S/R CD_CODE_SCHEME): |
| 47 |
|
this affects truncation error: -> update output.txt of exp: |
| 48 |
|
global_ocean.90x40x15 (fw&adm), lab_sea (fw&adm) & lab_sea.lsr, |
| 49 |
|
ideal_2D_oce, isomip.htd, natl_box, tutorial_global_oce_latlon. |
| 50 |
|
|
| 51 |
|
checkpoint59f |
| 52 |
|
o pkg/autodiff: zero_adj resets an ajoint variable to zero (in adjoint mode) |
| 53 |
|
o pkg/ctrl: ctrl_bound forces parameter corrections to stay in |
| 54 |
|
a bounded range (in forward mode) |
| 55 |
|
o pkg/ecco, ctrl, autodiff and mom_common: |
| 56 |
|
internal parameter controls, completements of implementations |
| 57 |
|
o add few EXCH S/R (UV_BGRID, UV_DGRID, SM) for B & D-Grid velocity & 2nd Moment Sxy. |
| 58 |
|
o use UV_BGRID exch for dxV,dyU: for now, only with pkg/exch2 & forward ; |
| 59 |
|
(not seem any difference in testing results). |
| 60 |
|
o pkg/cd_code: use the right EXCH calls (for CS-grid); but problem remains |
| 61 |
|
at face corners. |
| 62 |
|
o pkg/generic_advdiff: |
| 63 |
|
- in GAD.h, define as parameters (iMinAdvR,iMaxAdvR,jMinAdvR,jMaxAdvR) |
| 64 |
|
loop range indices for computing vertical advection tendency |
| 65 |
|
and do the calculation in the interior only (no overlap) ; |
| 66 |
|
for now, only implemented for SOM advection (to save CPU time). |
| 67 |
|
- add argument "withSigns" to S/R FILL_CS_CORNER_TR_RL (needed for SOM_xy moment) |
| 68 |
|
o exch2 adjoint |
| 69 |
|
First set of changes: |
| 70 |
|
- add exch2 hand-written adjoint templates |
| 71 |
|
- exch2 hand-written no longer use TAF-flag 'nownew_arg' |
| 72 |
|
This will require cleanup in pkg/autodiff/*.F |
| 73 |
|
(changed routines currently kept separate in verif. code/) |
| 74 |
|
- Comment all relevant #ifndef ALLOW_AUTODIFF_TAMC |
| 75 |
|
that used to hide exch2 or cubed-sphere specific code |
| 76 |
|
(commented via 'cph-exch2') |
| 77 |
|
o pkg/seaice |
| 78 |
|
- Close southern and western boundaries for UICE/VICE when useOBCS=.TRUE. |
| 79 |
|
o pkg/bulk_force: fix loading into Qsw of Short-Wave flux; and update |
| 80 |
|
output of global_ocean.cs32x15.thsice . |
| 81 |
|
|
| 82 |
|
checkpoint59e |
| 83 |
|
o exch2: new S/R that only use the cube-tracer (center-position) exchange: |
| 84 |
|
for B-grid vector (not yet tested) and C-grid vector (<- only used |
| 85 |
|
when option W2_USE_R1_ONLY in W2_OPTIONS.h is defined). |
| 86 |
|
o starting implementation of Duffy et al. (GRL 1999) salt plume scheme |
| 87 |
|
(#ifdef ALLOW_SALT_PLUME) |
| 88 |
|
o gather_2d/scatter_2d: removed halo regions |
| 89 |
|
o gmredi: add option (GM_taper_scheme='fm07') for Ferrari & McWilliams 2007 |
| 90 |
|
scheme and the corresponding test case (under front_relax dir). For now, |
| 91 |
|
only available with Skew-flux form and not yet tested in realistic set-up. |
| 92 |
|
adjoint: store directives updated, but gradient checks deteriorated, |
| 93 |
|
so maybe GM/Redi adjoint is now broken. |
| 94 |
|
o seaice adjoint |
| 95 |
|
* add AREA, HEFF, HSNOW as control variable |
| 96 |
|
(should not change lab_sea results) |
| 97 |
|
* CTRL_OPTIONS.h needs new flag: CTRL_SET_OLD_MAXCVARS_40 |
| 98 |
|
o pkg/seaice: |
| 99 |
|
* added computation of saltFlux in seaice_growth; |
| 100 |
|
For time being, sea ice salinity is assumed constant |
| 101 |
|
contribution of snow flooding to freshening of sea ice is neglected. |
| 102 |
|
SEAICE_salinity is set in SEAICE_PARM01 of data.seaice and it |
| 103 |
|
defaults to 0.0 in order to maintain backward compatibility. |
| 104 |
|
Typical values for SEAICE_salinity are 4 to 10 g/kg. |
| 105 |
|
* replaced dRf(1) with dRf(kSurface)*hFacC(kSurface) in seaice_growth.F |
| 106 |
|
* added SEAICE_availHeatFrac, which specifies fraction of surface level |
| 107 |
|
heat content used to melt or grow ice |
| 108 |
|
* commented out cap of HICE: it helps keep ice thinner |
| 109 |
|
* reintroduced cap of HEFF via MAX_HEFF and SEAICE_CAP_HEFF option |
| 110 |
|
* applied OBCS T/S mask to HEFFM sea ice mask |
| 111 |
|
|
| 112 |
|
checkpoint59d |
| 113 |
|
o standard name: {PKG}_DIAGNOSTICS_STATE to fill diagnostics array |
| 114 |
|
for {PKG} state variables, and called from DO_STATEVARS_DIAGS. |
| 115 |
|
(keep {PKG}_DIAGNOSTICS_FILL for non-state variables diagnostics) |
| 116 |
|
o pkg/gmredi (gmredi_readparms.F): add some missing "_d 0" |
| 117 |
|
and change default value of parameter "GM_Small_Number"; |
| 118 |
|
update output of exp: lab_sea (x2), cfc_example, global_ocean.90x40x15, |
| 119 |
|
global_ocean.cs32x15 (x4), global_ocean_ebm, global_with_exf, |
| 120 |
|
tutorial_global_oce_biogeo, tutorial_global_oce_latlon |
| 121 |
|
o pkg/ecco: cost function when applying pkg/smooth to controls |
| 122 |
|
o pkg/ctrl: add forcingPrecond run time parameter |
| 123 |
|
o pkg/seaice: |
| 124 |
|
- replace ZMIN=4.e8 with ZMIN=0. in dynsolver.F as in C-grid code |
| 125 |
|
- fix bug in metric terms of u-equation in LSR solver (implicit part), |
| 126 |
|
changes verification/lab_sea |
| 127 |
|
- rearrange implicit part of u-equation in LSR solver to make it easier to |
| 128 |
|
read, understand, and debug. This causes changes at the truncation level. |
| 129 |
|
- fix (serious) bug in the boundary conditions (sign error in the implicit |
| 130 |
|
part) of the LSR solver. Changes all LSR results. |
| 131 |
|
- fixed problem with HSNOW initialization to avoid thick snow when AREA |
| 132 |
|
is initilized with small values - does not change lab_sea results. |
| 133 |
|
- added HsnowFile initialization capability |
| 134 |
|
o pkg/smooth: addition to model/src and pkg/ctrl so allow |
| 135 |
|
initialization of pkg/smooth and application to control vector |
| 136 |
|
o pkg/seaice: fix another bug in the LSR no-slip boundary conditons |
| 137 |
|
o dependencies: pkg/profiles requires pkg/cal |
| 138 |
|
o pkg/profiles: |
| 139 |
|
- added option ALLOW_PROFILES_GENERICGRID |
| 140 |
|
-> pkg/profiles can thus be used with any grid (e.g. cs32x15) assuming |
| 141 |
|
that interpolation information (grid points and coefficients) is provided |
| 142 |
|
within the netcdf input files. |
| 143 |
|
-> sample matlab scripts can be found in MITgcm_contrib/gael |
| 144 |
|
that allow you to prepare netcdf input files. |
| 145 |
|
- also modified: cleaner include statements, cleaner error print statements, |
| 146 |
|
cleaner stops when error, and more tests of the netcdf input files consistency. |
| 147 |
|
o additional test (in global_ocean.cs32x15) using seaice+thsice pkgs. |
| 148 |
|
o pkg/seaice: |
| 149 |
|
- move seaice-diagnostics from seaice_do_diags to do_statevars_diags; this |
| 150 |
|
requires a new routine: seaice_diagnostics_fill.F |
| 151 |
|
- make sure that seaice does not move if not forced (pressure replacement |
| 152 |
|
method, Hibler and Ip, 1995), changes results |
| 153 |
|
- and new damping criterion for EVP solver according to Hunke, JCP, 2001 |
| 154 |
|
- SEAICE_evpDampC = > 0. turns it on (615. is the recommended value). |
| 155 |
|
It is turned off by default (=-1.), because it changes the results. |
| 156 |
|
- make it possible to read AREA from a file, too. |
| 157 |
|
|
| 158 |
|
checkpoint59c |
| 159 |
|
o add S/R and diagnostics for oceanic mixed-layer depth |
| 160 |
|
o move GMRedi call after all vertical mixing schemes (including KPP) |
| 161 |
|
o pkg/thsice: |
| 162 |
|
- ensure iceMask > iceMaskMin : this problem appeared after May-04 modifs |
| 163 |
|
(melt only laterally if thin ice): update output of global_ocean.cs32x15.thsice |
| 164 |
|
o pkg/obcs: |
| 165 |
|
- bug fix for balance code |
| 166 |
|
o pkg/seaice: |
| 167 |
|
- allow values of SEAICE_elasticParm > 1 |
| 168 |
|
- add new parameter SEAICE_evpTauRelax as an alternative |
| 169 |
|
to SEAICE_elasticParm |
| 170 |
|
- make lsr boundary conditions free slip (by default), changes result |
| 171 |
|
- add code for no slip boundary conditions for lsr |
| 172 |
|
- set minimum of zeta to zero (and not 4e8) (changes results) |
| 173 |
|
- add a cap on AREA after advecting AREA if seaice_growth is not called |
| 174 |
|
o change calculation of Visbeck K: |
| 175 |
|
- no longer depend on tapering scheme; instead, compute slope (limited |
| 176 |
|
by GM_maxSlope). this is equivalent to what was comuted before with |
| 177 |
|
clipping or linear tappering. |
| 178 |
|
- fix vertical averaging (wrong by 1/2 level) |
| 179 |
|
- leave the old version (but will not be maintained) within |
| 180 |
|
#ifdef OLD_VISBECK_CALC / #endif |
| 181 |
|
- update output of exp. ideal_2D_oce |
| 182 |
|
o change error catch in calc_r_star to improve vectorization |
| 183 |
|
o exf runoff and seaice: remove ALLOW_SEAICE from exf pkg files and |
| 184 |
|
add #define ALLOW_RUNOFF in SEAICE_OPTIONS.h (when not using exf). |
| 185 |
|
o adjoint: |
| 186 |
|
Re-organized adjoint checkpointing according to Matt Mazloff |
| 187 |
|
(but with modifs/completions/cleanups) |
| 188 |
|
Storing is now bundled into large arrays to optimized I/O |
| 189 |
|
(and second step in cleanup of the_main_loop) |
| 190 |
|
|
| 191 |
|
checkpoint59b |
| 192 |
|
o coupler (pkg/atm_ocn_coupler, pkg/ocn_compon_interf, pkg/atm2d): |
| 193 |
|
- export/import (between ocean & coupler) fields needed for ocean DIC. |
| 194 |
|
o pkg/seaice: |
| 195 |
|
- get rid of three more exchanges seaice_calc_viscosities (required |
| 196 |
|
different loop boundaries in seaice_lsr and seaice_ocean_stress) |
| 197 |
|
- bug fix in seaice_ocean_stress (update of lab_sea required) |
| 198 |
|
- reduce loop boundaries to necessary minimum also in seaice_evp |
| 199 |
|
- go back to the old way of computing deltaC/Z as the adjoint likes that |
| 200 |
|
better |
| 201 |
|
o Refresh of tutorial_global_oce_latlon (includes changing salinity-like |
| 202 |
|
passive tracer to an Age Tracer) + update output.txt |
| 203 |
|
o pkg/exf: |
| 204 |
|
- implement A-grid / C-grid selection for wind-stress input files. |
| 205 |
|
- clean-up exf_wind.F (remove us, use wspeed instead ; add wStress) |
| 206 |
|
for now, in exf_bulk_largeyeager04.F only : |
| 207 |
|
- change implementation for case where windspeed + 2. components wind-stress |
| 208 |
|
are read-in. AND use rhoConstFresh to convert evap. |
| 209 |
|
o pkg/seaice: |
| 210 |
|
- use correct EXCH_UV for wind-forcing (on A-grid). |
| 211 |
|
- change SEAICE_OPTIONS.h to limit the number of option combinations (regarding |
| 212 |
|
SEAICE_EXTERNAL_FORCING & SEAICE_EXTERNAL_FLUXES); add corresponding stops. |
| 213 |
o pkg/exf: |
o pkg/exf: |
| 214 |
move exf header files from lower_case.h to UPPER_CASE.h ; |
- default EXF options are now set in EXF_OPTIONS.h (ifndef ALLOW_AUTODIFF_TAMC) |
| 215 |
add missing cvs Header & Name |
EXF_INTERPOLATION: |
| 216 |
|
- merge global_with_exf/code version of exf_interp_read.F |
| 217 |
|
to the main code ; |
| 218 |
|
- Add new option: EXF_INTERP_USE_DYNALLOC to use Dynamical Allocation when |
| 219 |
|
reading the file ; Important: This options needs to be defined to recover |
| 220 |
|
previous code. |
| 221 |
|
otherwise, use fixed size array to read in (size=exf_interp_bufferSize). |
| 222 |
|
- no longer loose real*8 precision along the way when using exf_iprec=64. |
| 223 |
|
o pkg/seaice: rearrangement of common blocks (really needs more cleaning up) |
| 224 |
|
- change discretisation of evp-solver in order to avoid another exchange |
| 225 |
|
(changes lab_sea) and clean up a little |
| 226 |
|
- replace SQRT(MAX(deltaC,SEAICE_EPS)) by MAX(SQRT(deltaC),SEAICE_EPS) |
| 227 |
|
help the adjoint (this also changes the results slightly) |
| 228 |
|
- add a few "_d 0" where they had been missing in seaice_evp.F |
| 229 |
|
- cleaning up: remove unused seaice_calc_rhs.F |
| 230 |
|
o pkg/exf: some cleaning-up: |
| 231 |
|
- change various "constants" into runtime parameters |
| 232 |
|
- cleaned-up Large&Yeager04 routine which should eventually |
| 233 |
|
replace exf_bulkformulae.F (changed names of S/R and CPP) |
| 234 |
|
and merged various ALLOW_ATM_WIND options |
| 235 |
|
only used with thsice pkg (in thsice_get_exf.F): |
| 236 |
|
- implement fixed turbulent transfert Coeff over ice (as in Large&Yeager04) |
| 237 |
|
which are used when useStabilityFct_overIce=TRUE (= the default) |
| 238 |
|
- change default values of ice & snow emissivity and scale downward LW |
| 239 |
|
by ice & snow emissivity. |
| 240 |
|
o pkg/thsice: |
| 241 |
|
fix few little problems, in thsice_calc_thickn.F: |
| 242 |
|
- growth vertically (and not laterally) if iceFrac == iceMaskMax |
| 243 |
|
- melt only laterally if hIce < hThinIce (as the comments say) |
| 244 |
|
and in thsice_extend.F: |
| 245 |
|
- allow to form ice even when iceFrac == iceMaskMax (by increasing thickness) |
| 246 |
|
- start to form ice as soon as the minimum ice-volume is reachable. |
| 247 |
|
update output of test-exp: aim.5l_cs(thSI), global_ocean.cs32x15(thsice), |
| 248 |
|
and cpl_aim+ocn |
| 249 |
|
o pkg/kpp |
| 250 |
|
- move computation of surface related input fields to KPP into a new |
| 251 |
|
subroutine kpp_forcing_surf.F |
| 252 |
|
- remove wrong (within bi,bj loops) EXCH calls. |
| 253 |
|
- little cleaning (add argument myThid in last position, cvs header ...) |
| 254 |
|
- for now, fix conservation problem by exchanging KPPviscAz (may not |
| 255 |
|
be the best fix) |
| 256 |
|
o pkg/seaice |
| 257 |
|
- check for inconsistent evp parameter/cpp-flag combination |
| 258 |
|
- remove leftover errIO flat for obsolete name list error handling |
| 259 |
|
o OpenAD |
| 260 |
|
- changed verification/OpenAD to full baroclinic setup (including GM/Redi) |
| 261 |
|
|
| 262 |
|
checkpoint59a |
| 263 |
|
o pkg/seaice: some parameter clarifications and a little bit of clean up |
| 264 |
|
o pkg/thsice: rename run-time parameters: |
| 265 |
|
himin -> hIceMin |
| 266 |
|
himin0 -> hThinIce |
| 267 |
|
hihig -> hThickIce |
| 268 |
|
i0 -> i0swFrac |
| 269 |
|
transCoef -> bMeltCoef |
| 270 |
|
frac_energy -> fracMelting |
| 271 |
|
add new parameters: hNewIceMax, fracFreezing, dhSnowLin |
| 272 |
|
with default values (for now) that do not change the results. |
| 273 |
|
remove old version of thsice vars advection in pkg/seaice. |
| 274 |
|
o in FFIELDS.h: |
| 275 |
|
- replace #ifndef ALLOW_EXF by #ifndef EXCLUDE_FFIELDS_LOAD |
| 276 |
|
- make pLoad & sIceLoad always available (but still only used if |
| 277 |
|
ATMOSPHERIC_LOADING is #define). |
| 278 |
|
o pkg/kpp: replaced _KPP_RL with _RL |
| 279 |
|
o bug fixes for vertical diffusivity computations when both KPP and |
| 280 |
|
3D diffusivity arrays are used. |
| 281 |
|
o pkg/seaice: fix bug in evp solver, while doing that |
| 282 |
|
- change (improve?) discretization of stress computations for both |
| 283 |
|
cgrid-lsr and evp solver |
| 284 |
|
- add a new routine to compute strain rates |
| 285 |
|
- the above changes lab_sea results |
| 286 |
|
- add no slip conditions for evp solver (off by default), lsr-version |
| 287 |
|
may follow |
| 288 |
|
- fix exchange for shear at Z-points (does not change lab_sea) |
| 289 |
|
- retire SEAICEuseEVP, instead turn on EVP by setting SEAICE_deltaTevp |
| 290 |
|
(to force the user to pick a time step since there is not "safe" way |
| 291 |
|
of choosing it) |
| 292 |
|
- add principal stress diagnostics |
| 293 |
|
- rearrange fields for evp a little to avoid having to call a: too many |
| 294 |
|
exchanges and b: exchanges for stress trensor components which we do |
| 295 |
|
not have. |
| 296 |
|
- modify Hibler+Bryan (1987) stress coupling so that it reuses information |
| 297 |
|
of evp, complete rewrite for lsr case (latter is does not yet work |
| 298 |
|
in all cases) |
| 299 |
|
o pkg/kpp: add code to have mixing in shelf ice caverns |
| 300 |
|
- add myThid to all kpp routines (long overdue) |
| 301 |
|
|
| 302 |
|
checkpoint59 |
| 303 |
|
o pkg/exf: |
| 304 |
|
- fix wind-stress location: defined on A-grid (if ALLOW_ATM_WIND & |
| 305 |
|
ALLOW_BULKFORMULAE or USE_EXF_INTERPOLATION), otherwise, defined on C-grid |
| 306 |
|
- move exf header files from lower_case.h to UPPER_CASE.h ; |
| 307 |
|
add missing cvs Header & Name |
| 308 |
|
- add adjoint routines and flow dirs for newly used exch_uv_agrid routines |
| 309 |
|
- add namelist param. selectStressGridPosition, exf_monFreq |
| 310 |
|
- retire many _CLIM routines, and remove data.exf_clim |
| 311 |
|
+ params moved to data.exf |
| 312 |
|
+ climsst, climsss now handled by exf_set_gen, i.e. |
| 313 |
|
climss?period=0 refers to constant field, |
| 314 |
|
climss?period=-12 to monthly forcing |
| 315 |
|
- split up namelists in data.exf |
| 316 |
o pkg/seaice: |
o pkg/seaice: |
| 317 |
- remove seaice_exch and seaice_exch_uv |
- remove seaice_exch and seaice_exch_uv |
| 318 |
- remove superfluous exchange of theta |
- remove superfluous exchange of theta |
| 321 |
+ new routine |
+ new routine |
| 322 |
+ two new field (taux, tauy for stress over ice) |
+ two new field (taux, tauy for stress over ice) |
| 323 |
+ removed one global field (DAIRN) for C-grid case only |
+ removed one global field (DAIRN) for C-grid case only |
| 324 |
|
o pkg/thsise |
| 325 |
|
- 2nd set of modifs for thsice adjoint in conjunction with exf |
| 326 |
|
o enable runtime flag useEXF (useCAL is set to .T. if useEXF=.T.) |
| 327 |
|
|
| 328 |
checkpoint58y_post |
checkpoint58y_post |
| 329 |
o Added capability for latitudinal dependence of Bryan and Lewis, 1979 |
o Added capability for latitudinal dependence of Bryan and Lewis, 1979 |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch