| 3 |
|
|
| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
o pkg/layers: |
| 7 |
|
Created a new package for computing volume fluxes in temperature or |
| 8 |
|
[not yet implemented] density layers, e.g. for calculating residual |
| 9 |
|
overturning circulations. |
| 10 |
|
o pkg/diagnostics: |
| 11 |
|
implement a RS type version for the set of DIAGNOSTICS-FILL subroutines |
| 12 |
|
o fix few RS/RL type mismatch (check with ifort 11.1 "-warn all" option) |
| 13 |
|
o pkg/mdsio (& pkg/rw): rework high level S/R interface: |
| 14 |
|
To avoid mixing type (RS/RL) of input/output array argument, |
| 15 |
|
replace single mixed-type array with a pair from each type (RS/RL). |
| 16 |
|
o setting pickupSuff force to start from a pickup (even if nIter0=0): this |
| 17 |
|
is now implemented for all pkgs (previously only done for the main pickup) |
| 18 |
|
|
| 19 |
|
checkpoint61u |
| 20 |
|
o pkg/obcs: |
| 21 |
|
- change OB?eta from _RS to _RL and put them into a separate commen block |
| 22 |
|
- add code to read OB?eta from a file via obcs_prescribe_read: the code |
| 23 |
|
compiles and does not destroy any other experiments, the data is read |
| 24 |
|
properly, but the code is not tested in actual applications |
| 25 |
|
o ini_mnc_vars.F: if available (ALLOW_CAL), use startTime_1 and 2 to |
| 26 |
|
create a meaningful unit attribute for the time coordinate variable |
| 27 |
|
o pkg/ebm: add plenty of missing "_d 0" ; |
| 28 |
|
update results of experiment global_ocean_ebm (fwd + adjoint tests) |
| 29 |
|
Notes: several pieces of code only works for (very) specific set up |
| 30 |
|
(domain size, lat range, etc ...); should be documented & stop if one |
| 31 |
|
of those assumptions is not meet. |
| 32 |
|
o pkg/seaice: add missing "_d 0" in HSNOW initialisation |
| 33 |
|
update results of experiments: lab_sea (3 fwd tests + 2 adjoint tests) |
| 34 |
|
and offline_exf_seaice (seaicetd + adjoint). |
| 35 |
|
o add missing "_d 0" in ShortWave flux penetration (S/R SWFRAC): |
| 36 |
|
update results of experiments: lab_sea (4 fwd tests + 3 adjoint), |
| 37 |
|
seaice_obcs, global_ocean.cs32x15 (icedyn & thsice) and natl_box (x2). |
| 38 |
|
o few changes to pass when compiling with strick checking of arguments |
| 39 |
|
across S/R (allow to find few bugs in S/R calls). |
| 40 |
|
o pkg/seaice: |
| 41 |
|
- seaice_evp: move if-statement out of loop (TEM) at the cost of 11 new |
| 42 |
|
2d-fields, for slightly better performance |
| 43 |
|
|
| 44 |
|
checkpoint61t |
| 45 |
|
o pkg/seaice: |
| 46 |
|
- remove unused variables in seaice_evp |
| 47 |
|
- reduce number of SQRT in seaice_evp and seaice_calc_viscosities |
| 48 |
|
o eeset_parms.F, open_copy_data_file.F & ini_parms.F: |
| 49 |
|
named file replacing SCRATCH files (for TARGET_BGL & TARGET_CRAYXT): |
| 50 |
|
each processor opens a different file (a fix from Matt). |
| 51 |
|
o cg2d: |
| 52 |
|
use simple EXCH (overlap size = 1 and ignore corners), like in cg3d.F : |
| 53 |
|
this reduces number of EXCH calls by 2 when using exch2. |
| 54 |
|
For now, keep previous size array for gc2d_nsa.F to avoid Pb with store |
| 55 |
|
directives and missing simple EXCH (exch_s3d_rx) adjoint code. |
| 56 |
|
o pkg/thsice: |
| 57 |
|
add code for Near Infra-Red albedo (from Jeff) |
| 58 |
|
(turned on with run-time flag: thSIce_calc_albNIR, in data.ice). |
| 59 |
|
o ini_model_io: |
| 60 |
|
move (from packages_readparms.F & initialise_fixed.F) to ini_model_io.F |
| 61 |
|
MNC & MONITOR initialisation calls; move MNC calls from {pkg}_readparms.F |
| 62 |
|
to {pkg}_init_fixed.F for {pkg}= kpp, seaice & shelfice. |
| 63 |
|
|
| 64 |
|
checkpoint61s |
| 65 |
|
o pkg/exch2 (exch2_rxN_cube*): |
| 66 |
|
remove last BARRIER (no need to synchronise after getting data from shared |
| 67 |
|
buffer (get) as long as any change to buffer (put,recv) is between BARRIER) |
| 68 |
|
o change tiling of natl_box (from 2 to 4 tiles) to get it tested with MPI+MTH |
| 69 |
|
and generate new output (for the 2 tests) using default rotationPeriod. |
| 70 |
|
o pkg/exch2: |
| 71 |
|
- always call exch2_*_cube, not exch-1 anymore, if useCubedSphereExchange=F |
| 72 |
|
(was already the case with AUTODIFF_EXCH2 defined) |
| 73 |
|
- add bj in exch2 arrays and S/R. |
| 74 |
|
- can now use pkg/exch2 for regular (non CS) set-up; switch test experiment |
| 75 |
|
MLAdjust to exch2 (identical results except with MPI -> truncation diff); |
| 76 |
|
o add pkg/longstep for ptracer timestep a multiple of U/V/T/S timestep |
| 77 |
|
- adds deltaT argument to the subroutines TIMESTEP_TRACER DWNSLP_APPLY |
| 78 |
|
GAD_ADVECTION GAD_CALC_RHS GAD_IMPLICIT_R GAD_SOM_ADVECT |
| 79 |
|
- verification experiment natl_box.longstep |
| 80 |
|
o build_options: ifort+mpi_aces optfile (following Constantinos advise): |
| 81 |
|
allow different versions of ifort (8 or 9) and different versions |
| 82 |
|
of mpi (mpich or mpich2) to be used with the same optfile. |
| 83 |
|
requires to load a netcdf module and set MPI_INC_DIR (see comments inside |
| 84 |
|
optfile). Change testing scripts (example_scripts/ACESgrid) accordingly. |
| 85 |
|
o pkg/seaice: |
| 86 |
|
fix previous modif (3-level field removed) for old-pickup reading |
| 87 |
|
|
| 88 |
|
checkpoint61r |
| 89 |
|
o pkg/seaice: |
| 90 |
|
- clean up the 3-time levels of UICE,VICE,HEFF,AREA in three steps: |
| 91 |
|
1. introduce fields for time step (N-1) |
| 92 |
|
2. do not use levels 2 and 3 anymore (but keep them) |
| 93 |
|
3. replace 3D versions of UICE,VICE,HEFF,AREA by 2D versions. This |
| 94 |
|
includes changes to pkg/thsice/thsice_get_velocity.F, |
| 95 |
|
model/src/external_forcing_surf.F, pkg/obcs/obcs_apply_seaice.F, and |
| 96 |
|
pkg/obcs/obcs_apply_uvice.F. |
| 97 |
|
- completely remove code for leap-frog time stepping for second order |
| 98 |
|
advection |
| 99 |
|
- adjusted adjoint accordingly; |
| 100 |
|
gradient checks have improved by an order of magnitude! |
| 101 |
|
|
| 102 |
|
checkpoint61q |
| 103 |
|
o pkg/seaice: fix bug in free slip boundary conditons for LSOR solver |
| 104 |
|
- the boundary conditions along open boundaries are unclear, because the |
| 105 |
|
associated masks are set to zero and are thus treated as closed when |
| 106 |
|
applying the slip-boundary conditions. |
| 107 |
|
- move initialisation of grid variables from seaice_init_varia to _fixed |
| 108 |
|
o adding doc/diags_changes.txt |
| 109 |
|
o model/src: |
| 110 |
|
do_the_model_io: rename few pkg S/R which are called from do_the_model_io, |
| 111 |
|
to avoid "_diags" naming if no relation to pkg/diagnostics. |
| 112 |
|
ini_theta,ini_salt: fix (at least compile the code) reading from NetCDF |
| 113 |
|
file and only call PLOT_FIELD_XYZ if debugMode=T. |
| 114 |
|
remove few PLOT_FIELD_XY calls outside initialisation. |
| 115 |
|
remove few unnecessary BARRIER. |
| 116 |
|
o pkg/salt_plume: add SaltPlumeSouthernOcean to allow disabling |
| 117 |
|
of salt_plume package in Southern Ocean |
| 118 |
|
o pkg/thsice: |
| 119 |
|
- fix hOceMxL in overlap (needed for sea-ice advection); |
| 120 |
|
update output of experiment global_ocean.cs32x15.icedyn. |
| 121 |
|
o pkg/seaice: |
| 122 |
|
- make the (placeholder-)tracer IceAge a little more meaningful |
| 123 |
|
by avoiding ridging of age due to convergent ice flow |
| 124 |
|
- add diagnostics for surface temperature, atmospheric and oceanic |
| 125 |
|
heat flux, and atmospheric and oceanic ice growth |
| 126 |
|
|
| 127 |
|
checkpoint61p |
| 128 |
|
o eesupp (global_max & global_sum): |
| 129 |
|
- add one more element to buffer (start at index 0) for GL_MAX/SUM output; |
| 130 |
|
- remove starting & endding barrier (no longer needed) |
| 131 |
|
o pkg/mdsio, writelocal: |
| 132 |
|
works also in multi-threaded when LOCBIN_IO_THREAD_SAFE is undefined |
| 133 |
|
(remove the STOP): uses shared buffer IO to store data from all threads |
| 134 |
|
and then let master-thread write nThreads tiles. |
| 135 |
|
o pkg/mdsio (read/write field): |
| 136 |
|
- tiled IO done in 1 piece (all levels at a time); |
| 137 |
|
- new header file "MDSIO_BUFF_3D.h" with 3-D buffers. |
| 138 |
|
- multi-threaded: allow to read/write local (non-shared) array |
| 139 |
|
(was already working with singleCpuIO ; now works also without); |
| 140 |
|
=> no longer needs barrier call after reading a file (added inside |
| 141 |
|
mds_read/write field). |
| 142 |
|
- move barrier calls outside gather/scatter_2d to mds_read/write_field |
| 143 |
|
o pkg/obcs/exf |
| 144 |
|
- exf_getffieldrec.F: add a few ". _d 0" and |
| 145 |
|
add code to catch the case fldperiod = 0. |
| 146 |
|
- obcs_precribe_read.F: change if statements so that they match |
| 147 |
|
the variable type (_RL) |
| 148 |
|
- add a separate exf_iprec_obcs to exf_set_obcs (by default equal to |
| 149 |
|
exf_iprec) as part of namelist EXF_NML_01 |
| 150 |
|
o pkg/mdsio: |
| 151 |
|
- read/write tiled (local) files: read/write 1-level tile chunk at a time |
| 152 |
|
(instead of segment of length sNx); expected to speed up tiled IO. |
| 153 |
|
o pkg/exch2: |
| 154 |
|
- take buffer copy from/to array out of S/R exch2_send/recv into new |
| 155 |
|
S/R exch2_put/get ; Exch of local variable now works with MPI+MTH |
| 156 |
|
(tested by removing commom block statement in SOLVE_FOR_PRESSURE.h). |
| 157 |
|
- ad version of send/recv no longer needed (but needs exch2_ad_put/ad_get) |
| 158 |
|
- simplify argument list of S/R exch2_get_uv_bounds and exch2_get_scal_bounds |
| 159 |
|
(which replaces exch2_get_recv_bounds & exch2_get_send_bounds) by |
| 160 |
|
including Topology header file (and common blocks). |
| 161 |
|
- implement EXCH_IGNORE_CORNERS in scalar exchange (rx1); |
| 162 |
|
remove 2nd exch call in exch2_s3d_rx (no longer needed). |
| 163 |
|
- document S/R arg. list (+ update some comments) |
| 164 |
|
o pkg/seaice: |
| 165 |
|
- added SEAICE_CLIM_AIR code, which permits modulation of surface air |
| 166 |
|
temperature and humidity over sea ice based on climatological values. |
| 167 |
|
- clean up computation of Hibler+Bryan (1987) stress coupling for the case |
| 168 |
|
of LSR (this change is expected to change the results slightly because now |
| 169 |
|
it uses slightly difference moduli from the second last LSR solution, but |
| 170 |
|
that is more consistent with the stress computations; this part of the code |
| 171 |
|
is not tested in the verification experiments) |
| 172 |
|
- fix diagnostics for flux of ice in case of B-grid |
| 173 |
|
- turn strain rates eij and press into global fields within global |
| 174 |
|
common block in SEAICE.h for more straighforward diagnostics |
| 175 |
|
- fix diagnostics for principal stress components, press, zeta, eta |
| 176 |
|
to give something meaning full |
| 177 |
|
o change tiling of global_ocean.cs32x15 (12 tiles, 32x16) and generate |
| 178 |
|
new output (all 4 tests) using default rotationPeriod. |
| 179 |
|
o pkg KPP: |
| 180 |
|
- add flag (LimitHblStable) to avoid limiting BL depth under stable conditions |
| 181 |
|
- fix vertical indices in RI_IWMIX (match between KPP grid from 0 to Nr+1 |
| 182 |
|
and normal grid from 1 to Nr) |
| 183 |
|
o Fix computations of L4rdt in mom_calc_visc.F |
| 184 |
|
o eesupp: |
| 185 |
|
new S/R ALL_PROC_DIE (like EEDIE, without irrelevant threads err msg): |
| 186 |
|
should be called before a "stop" if we know that all process are going |
| 187 |
|
to stop; if one Proc does call this S/R, will hang in MPI_FINALISE. |
| 188 |
|
|
| 189 |
|
checkpoint61o |
| 190 |
|
o pkg/exch2: change check_depths to issue just a warning (instead of error+stop) |
| 191 |
|
o model/src/ini_curvilinear_grid.F: |
| 192 |
|
compute angleSin/CosC when they are not read from a file |
| 193 |
|
o pkg/seaice: |
| 194 |
|
add pseudo time stepping for LSOR |
| 195 |
|
o pkg/exch2: |
| 196 |
|
temporary fix for exch2_s3d_rx; update results of exp. hs94.cs-32x32x5.impIGW |
| 197 |
|
o pkg/seaice: |
| 198 |
|
Adding separate sea ice albedo, drag coefficients, and HO in Southern |
| 199 |
|
Ocean from those in Arctic Ocean. See *_south in SEAICE_PARAMS.h |
| 200 |
|
o SingleCpuIO: |
| 201 |
|
fix bug put before chkp61n (May 11), when more than 2 MPI cpu are used. |
| 202 |
|
o pkg/seaice: |
| 203 |
|
put exchanged variable in (local) common block for MPI+Multi-Threads |
| 204 |
|
to work (necessary with exch1, and for now with exch2 too). |
| 205 |
|
o verification: to get more experiments tested with mpi, mth and mpi+mth, |
| 206 |
|
change tiling of: |
| 207 |
|
aim.5l_Equatorial_Channel, aim.5l_LatLon, dome, exp4, global_ocean.90x40x15, |
| 208 |
|
hs94.cs-32x32x5, MLAdjust, offline_exf_seaice & tutorial_plume_on_slope |
| 209 |
|
update output of exp: |
| 210 |
|
exp4, global_ocean.90x40x15(+.dwslp), MLAdjust(all 5), |
| 211 |
|
tutorial_plume_on_slope and hs94.cs-32x32x5 (use default rotationPeriod) |
| 212 |
|
+ ideal_2D_ocean: use default rotation period + test Global_Sum_SINGLECPU |
| 213 |
|
(note: output.txt generated on faulks using only 1 tile) |
| 214 |
|
o eesupp & mdsio (SingleCpuIO): |
| 215 |
|
- remove MISSING_TILE_IO (from MDSIO_OPTIONS.h), replaced by run-time |
| 216 |
|
parameter "W2_useE2ioLayOut" (read from file "data.exch2"). |
| 217 |
|
Note: was not effective for globalFile & useSingleCpuIO=F; now fixed. |
| 218 |
|
- move MDSIO_SCPU.h (pkg/mdsio) to EEBUFF_SCPU.h (eesupp/inc). |
| 219 |
|
- fix GLOBAL_SUM_SINGLECPU when using Exch2; re-use same buffers and same |
| 220 |
|
gather/scatter S/R as with SingleCpuIO (=> 1 less 2D global RL array). |
| 221 |
|
o pkg/exch2: |
| 222 |
|
- new code to set-up W2-Exch2 topology (replace matlab-topology-generator): |
| 223 |
|
read parameter file "data.exch2" if it exists; otherwise try default regular |
| 224 |
|
cube without blank-tile; new header file "W2_EXCH2_SIZE.h"; |
| 225 |
|
- update matlab-topology-generator (exch2_setup_cs6_print.m) to be compatible |
| 226 |
|
with new code (not to be used, just as a backup solution). |
| 227 |
|
- add examples (e.g., for lat-lon-cap_120) of parameter file "data.exch2" |
| 228 |
|
in utils/exch2/input. |
| 229 |
|
|
| 230 |
|
checkpoint61n |
| 231 |
|
o eesupp & mdsio (SingleCpuIO): |
| 232 |
|
- move mapping to global io-buffer inside gather_2d/scater_2d: this save |
| 233 |
|
memory (1 less 2D global RL array); skip 1 buffer copy; and only send/ |
| 234 |
|
receive real*4 array (instead of real*8) to read/write 32.bit files. |
| 235 |
|
(new template for gather_2d/scater_2d, new set of S/R MDS_PASS_R4,8toRL,S |
| 236 |
|
and remove new mapping S/R) |
| 237 |
|
o pkg/mdsio: in preparation for topology-generator within pkg/exch2: |
| 238 |
|
- Change declaration of SingleCpuIO buffer, reduced to only 1 dim.: |
| 239 |
|
xyBuffer_size, which is set to W2_ioBufferSize from W2_EXCH2_PARAMS.h |
| 240 |
|
when using exch2. Add S/R to map global io-buffer to global model array. |
| 241 |
|
- uses exch2_global_Nx,y instead of exch2_domain_nxt,nyt. |
| 242 |
|
|
| 243 |
|
checkpoint61m |
| 244 |
|
o write_utils : change WRITE_1D_R8 to WRITE_1D_RL |
| 245 |
|
and add 3 other S/R for other types (R4,R8,RS). |
| 246 |
|
Change calls to WRITE_0D/1D_R[4,8,S,L] to match the type of argument. |
| 247 |
|
o eesupp/inc/CPP_EEMACROS.h (EXCH & GLOBAL_SUM/MAX macros): |
| 248 |
|
- ensure suffix (_R4,_R8,_RS,_RL) correspondance between macro and S/R ; |
| 249 |
|
- reduce number of macro definitions (keep only those which are used); |
| 250 |
|
can always call directly the corrresponding S/R if needed. |
| 251 |
|
- everywhere in the code: change macros (EXCH & GLOBAL_SUM/MAX) suffix |
| 252 |
|
_R4/_R8 to _RS/_RL when applied to _RS/_RL variable. |
| 253 |
|
Fixed wrong type of arg in: |
| 254 |
|
atm2d/put_ocnvars.F cheapaml/cheapaml.F ocn_compon_interf/ocn_apply_import.F |
| 255 |
|
ctrl/ctrl_map_ini_ecco.F seaice/seaice_do_diags.F seaice/seaice_model.F |
| 256 |
|
To fix: global_sum of var in common block is wrong (multi-threaded) in: |
| 257 |
|
dic/dic_atmos.F ebm/ebm_area_t.F ebm/ebm_zonalmean.F sbo/sbo_calc.F |
| 258 |
|
To fix: aim_v23/aim_do_co2.F (BARRIER & GLOBAL_SUM within bi,bj loops) |
| 259 |
|
o adjustment.cs-32x32x1: test "blank tiles" when compiling with mpi; 2nd |
| 260 |
|
"nlfs" mpi test is going to stop when checking for unconnected tile egdes. |
| 261 |
|
o eesupp/src: new S/R to stop everyone when 1 (or more) Proc. find an error |
| 262 |
|
o pkg/exch2: new S/R EXCH2_CHECK_DEPTHS to check that unconnected tile |
| 263 |
|
edges are closed (zero depth); might happen with "blank tiles"; |
| 264 |
|
for now, disabled if using OBCS. |
| 265 |
|
o tools/gemake2: delete modifs from March 27-29 2009 (with option "-mpi": |
| 266 |
|
link *_mpi files from "MODS" dir) to return to a strait-forward behavior. |
| 267 |
|
o move read_write.F to write_utils.F ; new parameter (maxLengthPrt1D) |
| 268 |
|
to reduce length of 1.D array print in STDOUT. |
| 269 |
|
o adjustment.cs-32x32x1: changed to oceanic test with 1 continent |
| 270 |
|
+ use 48 tiles (16x8): this will allow to test "blank tiles". |
| 271 |
|
o start to test MPI + multi-threaded (change testreport to skip tests |
| 272 |
|
where number of tiles do not match). |
| 273 |
|
o genmake2: add option "-omp" to turn on Open-MP ; |
| 274 |
|
passed to testreport (if using -mth) ; merge few (*+mth) optfiles. |
| 275 |
|
o pkg/exch2 (+ utils/exch2): ignore blank tiles (instead of removing them) |
| 276 |
|
and keep the original tile numbering. Note: compatible with old |
| 277 |
|
W2_EXCH2_TOPOLOGY.h & w2_e2setup.F topology files. |
| 278 |
|
|
| 279 |
|
checkpoint61l |
| 280 |
|
o Overlaps had been forgotten in calculating ijk keys : fixed |
| 281 |
|
o fix cyrus makedepend for gcc 4.4 |
| 282 |
|
o experiment fizhi-cs-aqualev20: |
| 283 |
|
switching to new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE) |
| 284 |
|
and generate new output. Note: new output is much closer to the old |
| 285 |
|
one (v1.8) generated with pgf77 -O2 on Mar 14 2007 than it is from |
| 286 |
|
the previous one (v1.9) generated with pgf77 -O0 on Jun 13 2007. |
| 287 |
|
o pkg/fizhi: |
| 288 |
|
- change to avoid indices going deliberately over array-bounds |
| 289 |
|
- remove unnecessary MPI stuff |
| 290 |
|
- perpetual spring equinox with "#define FIZHI_USE_FIXED_DAY" |
| 291 |
|
- new version of S/R GETPWHERE available with #define TRY_NEW_GETPWHERE: |
| 292 |
|
does not go over array-bounds and therefore returns reliable output. |
| 293 |
|
- in fizhi_driver.F & fizhi_turb.F, fix "get_alarm" calls: |
| 294 |
|
this S/R has 4 output arguments, which are used inside "get_alarm"; |
| 295 |
|
when it is called with the same variable "ndum" in place of several |
| 296 |
|
output arguments, this produces weird side effect inside "get_alarm" |
| 297 |
|
(e.g., datein=dates(n) is overwritten by timein=times(n) since both |
| 298 |
|
datein & timein, resp. 2nd and 3rd arg., are pointed to the same "ndum" |
| 299 |
|
address) and produces error. |
| 300 |
|
o tools/gemake2: (March 27-29 2009) |
| 301 |
|
with option "-mpi": link *_mpi files from "MODS" dir (this is what |
| 302 |
|
testreport does). |
| 303 |
|
o lab_sea experiment: change from 2x1 tiles to 2x2 tiles and regenerate output |
| 304 |
|
o pkg/seaice: fix bug in new version of S/R SEAICE_LSR.F: |
| 305 |
|
update lab_sea.lsr & lab_sea.salt_plume results |
| 306 |
|
o pkg/seaice: |
| 307 |
|
Major overhaul of the LSOR solver: change discretization from original |
| 308 |
|
finite differences to finite volume. The old routine is still in the |
| 309 |
|
file seaice_lsr.F and can be turned on with the CPP-flag |
| 310 |
|
SEAICE_OLD_AND_BAD_DISCRETIZATION |
| 311 |
|
Along with this change, the discretization of the strain rates is changed. |
| 312 |
|
The same flag turns on the old discretization in seaice_calc_strainrates.F |
| 313 |
|
All verification experiments with seaice are affected (except for |
| 314 |
|
seaice_exf_offline); global_ocean.cs32x15/input.icedyn recovers the old |
| 315 |
|
results by setting the above flag. |
| 316 |
|
Further changes involve changes in defaults: |
| 317 |
|
- ALLOW_FLOODING is defined and turned on by default |
| 318 |
|
- SEAICEadvSnow = .true. is now the default |
| 319 |
|
- SEAICEadvSalt = .true. is now the default |
| 320 |
|
- SEAICEadvAge = .true. is now the default |
| 321 |
|
- SEAICE_clipVelocities = .false. is now the default |
| 322 |
|
(as per J. Zhang's recommendation) |
| 323 |
|
- B-grid, and thus not tested: SEAICE_TEST_ICE_STRESS_1/EXPLICIT_SSH_SLOPE |
| 324 |
|
is defined, SEAICE_TEST_ICE_STRESS_1 is renamed into SEAICE_BICE_STRESS |
| 325 |
|
- seaice_growth: replace computation of UG by a simple copy from wspeed |
| 326 |
|
|
| 327 |
|
checkpoint61k |
| 328 |
|
o pkg/seaice: a few bug fixes mostly concerning the metric terms: |
| 329 |
|
seaice_lsr: fixed a few metric terms, |
| 330 |
|
affects lab_sea.lsr, lab_sea.salt_plume, seaice_obcs |
| 331 |
|
add more debugging diagnostics |
| 332 |
|
seaice_evp: removed superfluous many metric terms of FV discretization |
| 333 |
|
of stress divergence |
| 334 |
|
affects lab_sea, lab_sea.hb87 |
| 335 |
|
seaice_ocean_stress: removed superfluous many metric terms of FV discretization |
| 336 |
|
of stress divergence for non-evp solver |
| 337 |
|
(this part is not tested anywhere) |
| 338 |
|
seaice_calc_strainrates: fixed a bug in no-slip boundary conditions, |
| 339 |
|
they were effectively only half slip |
| 340 |
|
affects lab_sea.hb87 |
| 341 |
|
updated all relevant verification experiments (except lab_sea//output_adm.txt |
| 342 |
|
which was left over, but fails at level 7 & 6) |
| 343 |
|
|
| 344 |
|
checkpoint61j |
| 345 |
|
o pkg/seaice: turn a few hard wired parameters into run time parameters |
| 346 |
|
o pkg/seaice/exf/monitor: turn netcdf coordinate variable T into model |
| 347 |
|
time in seconds as promised by the usints in seaice_monitor and exf_monitor |
| 348 |
|
o pkg/mnc: fix the coordinate variables for multi-tile curvi-linear grids |
| 349 |
|
that are not cubed-sphere grids |
| 350 |
|
o pkg/seaice: fix a bug for the rare case of SEAICE_VECTORIZE_LSR |
| 351 |
|
o pkg/ctrl: |
| 352 |
|
fix bug in ctrl_depth_ini.F (EXCH_XYZ was applied to 2-D field xx_r_low) |
| 353 |
|
o non-hydrostatic (calc_gw.F): |
| 354 |
|
fix viscA4 on CS-grid + fix diagnostics: Wm_Diss & Wm_Advec |
| 355 |
|
update output of exp. global_ocean.cs32x15.viscA4 |
| 356 |
|
o remove backward compatibility for thetaMin,phiMin |
| 357 |
|
(replaced by xgOrigin,ygOrigin on Jan 27, 2009) |
| 358 |
|
o pkg/exf: fix a serious bug in exf_set_uv.F: do a rotation of the |
| 359 |
|
interpolated wind field not only for curvilineargrid=.true., but also |
| 360 |
|
for a rotated grid (rotateGrid=.true.) |
| 361 |
|
o pkg/exf: add capability to bypass interpolation for runoff |
| 362 |
|
by setting yet another CPP-flag |
| 363 |
|
o eesupp/src, B-grid exchange: |
| 364 |
|
add simple (6 tiles, non MPI) CS exch + standard interface S/R. |
| 365 |
|
o autodiff |
| 366 |
|
new CPP option ALLOW_TAMC_SINGLEPREC_COMLEV |
| 367 |
|
allows to switch to single-prec common blocks; |
| 368 |
|
corresponding switch occurs in tamc.h, integer isbyte |
| 369 |
|
TAF store directivs "byte" and "kind" seem equivalent; |
| 370 |
|
Most tamc.h have been updated correspondingly. |
| 371 |
|
|
| 372 |
|
checkpoint61i |
| 373 |
|
o autodiff: |
| 374 |
|
fix autodiff_sore/_restore indices for obcs |
| 375 |
|
(spotted by I. Hoteit, M. Mazloff) |
| 376 |
|
o pkg/autodiff, pkg/ctrl: |
| 377 |
|
Add flag to reduce all tapelev I/O to single-prec. |
| 378 |
|
In data.ctrl set |
| 379 |
|
doSinglePrecTapelev = .TRUE. |
| 380 |
|
o model/src/ini_curvilinear_grid.F, new grid-file format without EXCH2: |
| 381 |
|
check in hack for SX8 compiler (for dxV, dyU); remove it afterwards. |
| 382 |
|
o pkg/shelfice: fix bug with SHELFICEconserve flag, prepare for |
| 383 |
|
real fresh water flux (not yet) |
| 384 |
|
o pkg/mdsio & rw: |
| 385 |
|
- add argument & option to S/R MDS_WRITEVEC_LOC (avoid Open/Close & write-meta) |
| 386 |
|
- add simple interface S/R to MDS_WRITEVEC_LOC in pkg/rw: WRITE_GLVEC_RX. |
| 387 |
|
o pkg/flt: |
| 388 |
|
- replace FLT_INIT by 3-steps standard initialization S/R: readparms, |
| 389 |
|
init_fixed & ini_varia. |
| 390 |
|
- clean-up & simplify linear interpolation S/R: |
| 391 |
|
move flt_bilinear.F -> flt_interp_linear.F ; add arg. myThid. |
| 392 |
|
- fix some indices (mainly vertical index) ; add IMPLICIT NONE. |
| 393 |
|
- more efficient I/O, using new options of MDS_WRITEVEC_LOC S/R. |
| 394 |
|
- add vert. coordinate & horiz. indices to output files. |
| 395 |
|
- change vertical position in initial condition, from index to depth [m]. |
| 396 |
|
- store horizontal (decimal) indices i,j in common block (instead of coord. x,y) |
| 397 |
|
(easier to get to a curvilinear grid) ; delX,delY no longer used. |
| 398 |
|
o pkg/ggl90: a few modifications: |
| 399 |
|
- fix bottom boundary condition, and interpolation of KappaE |
| 400 |
|
near top and bottom |
| 401 |
|
- use same set of viscosity/diffusivity for TKE/momnetum/tracer |
| 402 |
|
- add smoothing option as in Blanke and Delecluse (1993) (--> ALLOW_GGL90_SMOOTH) |
| 403 |
|
- add a few options for mixing-length upper limit (--> mxlMaxFlag) |
| 404 |
|
o rename thetaMin,phiMin -> xgOrigin,ygOrigin |
| 405 |
|
(maintain temporary backward compatibility, until next checkpoint) |
| 406 |
|
|
| 407 |
|
checkpoint61h |
| 408 |
|
o pkg/diagnostics with "periodic averaging diagnostics": |
| 409 |
|
fix S/R DIAGNOSTICS_COUNT ; hack diagnostics_out.F to get NetCDF output. |
| 410 |
|
o pkg/my82: add missing "_d 0" ; update output of exp. vermix.my82 |
| 411 |
|
o pkg/obcs: fix loop ranges for balancing code |
| 412 |
|
o pkg/flt: |
| 413 |
|
- improve criteria for finding which tile owns a float. |
| 414 |
|
- fix FLT_EXCH for case without MPI ; apply cyclic BC + fix also the MPI case. |
| 415 |
|
o Add well-mixed CO2 box in aim_v23 (which includes changes in pkg |
| 416 |
|
aim_compon_interf, ocn_compon_interf, gchem, and dic to get coupling |
| 417 |
|
with ocean biogeo) |
| 418 |
|
o pkg/flt: |
| 419 |
|
- do some cleaning and fix the restart ; |
| 420 |
|
- add output.txt in flt_example/results to get this pkg tested. |
| 421 |
|
o genmake2: add an EXTENDED_SRC option and flag. |
| 422 |
|
for now, cannot be turned on on command line (only through genmake_local) |
| 423 |
|
o pkg/mdsio: read/write vector: |
| 424 |
|
- singleCpuIO: fix RL/RS in MDSWRITEVECTOR by calling new S/R MDS_BUFFERtoRL/RS |
| 425 |
|
- singleCpuIO=F: fix arrType & filePrec & _BYTESWAPIO in both MDSREADVECTOR |
| 426 |
|
& MDSWRITEVECTOR by calling new S/R MDS_RD/WR_VEC_RL/RS. |
| 427 |
|
- affects gradient of test-exp "bottom_ctrl_5x5" (not due to _BYTESWAPIO) |
| 428 |
|
(drop to 4 digits matching for grad). But this test does not look very |
| 429 |
|
reliable (was already failling on eddy, fc5, at 6.digits). Update output. |
| 430 |
|
|
| 431 |
|
checkpoint61g |
| 432 |
|
o pkg/flt: |
| 433 |
|
- move FLT_CPPOPTIONS.h to FLT_OPTIONS.h (standard name) |
| 434 |
|
+ make OPTIONS file more standard. |
| 435 |
|
- rename S/R MDSREADVECTOR_FLT to FLT_MDSREADVECTOR (to mach src file name) |
| 436 |
|
- fix _BYTESWAPIO CPP-Flag |
| 437 |
|
- standard reading of file-parameter "data.flt" |
| 438 |
|
- fix argument list of S/R FLT_RESTART |
| 439 |
|
still need to fix _BYTESWAPIO in pkg/mdsio/mdsio_writevector.F |
| 440 |
|
o pkg/obcs: fix a CPP-flag, bug reported by Jeff Blundell |
| 441 |
|
o gather_2d.F/scatter_2d.F: suppress vectorisation on NEC SX in respond to |
| 442 |
|
a still unfixed compiler/optimization bug |
| 443 |
|
|
| 444 |
|
checkpoint61f |
| 445 |
|
o pkg/seaice, LSR solver: fix bug in GLOBAL_MAX calls ; |
| 446 |
|
update results of global_ocean.cs32x15.icedyn test. |
| 447 |
|
o move getcon.F from model/src to pkg/fizhi. |
| 448 |
|
o pkg/exf: add parameter for extrapolation of temp up to the surface |
| 449 |
|
and option to prevent negative evap (in bulk_largeyeager04 only). |
| 450 |
|
o Prather Advection scheme: fix tracer conservation for divergent flow |
| 451 |
|
(e.g., when using NonLin Free-Surface). |
| 452 |
|
o kpp: retire KPPmld diagnostics --> use MXLDEPTH instead |
| 453 |
|
o gmredi (Visbeck-variable-K): |
| 454 |
|
- add more parameters to Visbeck-variable-K. |
| 455 |
|
- use a 5 points average for dSigmaR in Visbeck-K calculation |
| 456 |
|
(more "homogenous": same stencil and same weights as in dSigmaH) |
| 457 |
|
- update output of ideal_2D_oce experiment. |
| 458 |
|
o fix CPP-flag REAL4_IS_SLOW, when _RS expands into real*4 |
| 459 |
|
(#undef REAL4_IS_SLOW) |
| 460 |
|
- pkg/mnc/mnc_cw_cvars.F: write _RS-grid variable as netcdf-real*4 |
| 461 |
|
coordinate variable |
| 462 |
|
- pkg/monitor/monitor.F: call mon_printstats_rs for _RS variables |
| 463 |
|
(surface forcing fields), removes some of the functionality |
| 464 |
|
- model/src/write_grid.F: write _RS variables as RS-netcdf variables |
| 465 |
|
- model/src/diags_oceanic_surf_flux.F: fix a few diagnostics, but |
| 466 |
|
probably not all: copy _RS surface flux fields to RL field before |
| 467 |
|
calling DIAGNOSTICS_FILL |
| 468 |
|
- model/inc/CPP_EEMACROS.h: make the _EXCH_*_RS macros expand into |
| 469 |
|
real*4 (CALL EXCH_*_RS) versions. |
| 470 |
|
- tested in 2 experiments: inverted_barometer & solid-body.cs-32x32x1 |
| 471 |
|
(generate new output). |
| 472 |
|
|
| 473 |
|
checkpoint61e |
| 474 |
|
o gmredi (Visbeck-variable-K): |
| 475 |
|
- fix the "OLD_VISBECK_CALC" option + move the #undef to GMREDI_OPTIONS.h |
| 476 |
|
- change computation of Visbeck-K where Slope > Smax : |
| 477 |
|
now: N*min(Slope,Smax) (similar to OLD_VISBECK_CALC with gkw91 taperFct) |
| 478 |
|
previously was: M*sqrt(min(Slope,Smax)) ; update ideal_2D_oce output. |
| 479 |
|
o bottom-drag in P-coord.: change units of bottomDragLinear & bottomDragQuadratic |
| 480 |
|
to be the same as with Z-coord. (i.e., m/s & no-units respectively). |
| 481 |
|
o calc_viscosity: fix index range (was wrong for CD-Scheme & explicit Visc) |
| 482 |
|
o pkg gmredi, linear & fm07 tapering: put an upper limit on Slope^2 so that Kwz |
| 483 |
|
does not become too large (to avoid precision problems in implicit-diffusion |
| 484 |
|
solver); update ideal_2D_oce output. |
| 485 |
|
o pkg ggl90: |
| 486 |
|
- in ggl90_cal.F: compute only one set of visc/diff, used to |
| 487 |
|
step forward TKE/T/S/momentum |
| 488 |
|
- default value of GGL90viscMax/GGL90diffMax larger and equal (to |
| 489 |
|
have Prandlt =1) |
| 490 |
|
o gmredi (fm07): |
| 491 |
|
- add lower limit on Transition layer thickness + lower limit on 1/lambda |
| 492 |
|
- allow to set few more params from data.gmredi |
| 493 |
|
o pkg ggl90: |
| 494 |
|
- add missing sqrt(2) factor in computation of mixing length |
| 495 |
|
scale in ggl90_calc.F |
| 496 |
|
(see Eq. (2.35) in Blanke and Delecluse, JPO, 1993) |
| 497 |
|
|
| 498 |
|
checkpoint61d |
| 499 |
|
o adjoint modifs |
| 500 |
|
- adapt to new field rhoInSitu |
| 501 |
|
- allow to revert from StoreDynVars2D, StoreDynVars3D |
| 502 |
|
to individual fields |
| 503 |
|
(switches AUTODIFF_USE_OLDSTORE_2D, AUTODIFF_USE_OLDSTORE_3D) |
| 504 |
|
o store 3-D (in-situ) density in commom block (DYNVARS.h) |
| 505 |
|
- save 1 rho computation. |
| 506 |
|
- no longer modify T & S inland when using down_slope pkg. |
| 507 |
|
o gad_som : allow to switch to SOM advection for T & S without corresponding |
| 508 |
|
pickup files (using new S/R: MDS_CHECK4FILE). |
| 509 |
|
o keep removing _BEGIN/_END_MASTER between MDSIO S/R call |
| 510 |
|
(for useSingleCpuIO to work in multi-threaded) |
| 511 |
|
o pkg/shelfice: |
| 512 |
|
- disentangle parameters: retire shelfIceFile in data/PARM05 and substitute |
| 513 |
|
with SHELFICEtopoFile in data.shelfice |
| 514 |
|
- move code for reading ice shelf topography and modifying hFacC into separate |
| 515 |
|
subroutines of the shelfice package |
| 516 |
|
- separate initialisation of "fixed" and "variable" variables |
| 517 |
|
- kTopC is not (yet) replaced by kSurfC, although this is possible |
| 518 |
|
o fix broken diagnostic SIatmFW and changed the units from m/s to kg/m^2/s |
| 519 |
|
o add initialisation of deepFac if using Pcoords (new S/R set_grid_factors) |
| 520 |
|
and rename: |
| 521 |
|
ini_phiref.F --> set_ref_state.F (+ set anelastic factors) |
| 522 |
|
ini_reference_state.F --> load_ref_files.F (- set anelastic factors) |
| 523 |
|
o change FIND_RHO_SCALAR : return rho (instead of rho - rhoConst) |
| 524 |
|
|
| 525 |
|
checkpoint61c |
| 526 |
|
o add option ALLOW_ADDFLUID and run-time selector "selectAddFluid" |
| 527 |
|
to add mass source/sink of fluid in the interior (3-D generalisation |
| 528 |
|
of oceanic real-fresh water flux). |
| 529 |
|
o pkg/monitor: fix recip_dr argument in mon_advcflw2 call (-> advcfl_W_hf_max) |
| 530 |
|
o vermix test experiment: switch from LINEAR EOS to MDJWF (not tested before) |
| 531 |
|
o new pkg: down_slope |
| 532 |
|
density-driven downsloping flow parameterisation (Tellus, 1999, 412-430). |
| 533 |
|
- presently, modify T & S inland (dwnslp_calc_rho.F). |
| 534 |
|
can be avoided if rho was stored in common bloc and used in calc_phi_hyd. |
| 535 |
|
- implementation for ocean in P-coords not tested. |
| 536 |
|
- add secondary test to global_ocean.90x40x15 (input.dwnslp) to check this pkg. |
| 537 |
|
o move kSurfC,kSurfW & kSurfS from SURFACE.h to GRID.h (next to kLowC) |
| 538 |
|
(to facilitate conversion of oceanic pkg to p-coordinate). |
| 539 |
|
o change FIND_RHO to FIND_RHO_2D : |
| 540 |
|
pass arguments tFld & sFld as local (tile) 2D-arrays ; +fix EOS_CHECK. |
| 541 |
|
o new pkg: cheapaml |
| 542 |
|
|
| 543 |
|
checkpoint61b |
| 544 |
|
o exch2: |
| 545 |
|
change index bounds in rx2_cube exchanges (new S/R: EXCH2_GET_UV_BOUNDS) |
| 546 |
|
- no longer depend on the order sequence (N,S,E,W). |
| 547 |
|
- 3rd exchange no longer needed (tested with 24 tiles). |
| 548 |
|
- same modif to hand-written adjoint S/R (global_ocean.cs32x15: zero diff) |
| 549 |
|
- exch_UV_A-grid readily available (but not yet tested). |
| 550 |
|
comment out 3rd exch call and remove copy of V to U at SE & NE face-corners |
| 551 |
|
(both are no longer needed) in exch_uv: no effect in forward run; but |
| 552 |
|
get truncation error differences with adjoint exch. |
| 553 |
|
o exch2: |
| 554 |
|
- change index-bounds storage (moved from target to local tile, |
| 555 |
|
more intuitive this way) ; rename/remove some variables. |
| 556 |
|
- change utils/exch2/matlab-topology-generator & code_mods accordingly. |
| 557 |
|
|
| 558 |
|
checkpoint61a |
| 559 |
|
o exch2/matlab-topology-generator: |
| 560 |
|
fix bug in index bounds for N-S internal exchange (hard to tell if this |
| 561 |
|
had any effect on the solution). |
| 562 |
|
o pkg/mnc: small fix in mnc_handle_err: make sure that length of msgbuf |
| 563 |
|
is exceeded |
| 564 |
|
o testreport: modify syntax of awk, so that it works also with |
| 565 |
|
awk, and not only with nawk and gawk |
| 566 |
|
|
| 567 |
|
checkpoint61 |
| 568 |
|
o autodiff |
| 569 |
|
Change default for TAF usage by removing argument '-nonew_arg' |
| 570 |
|
This changes TAF subroutine argument list (ordering of active var.) |
| 571 |
|
Omission of this flag leads to incompatibility w.r.t. TAMC |
| 572 |
|
To restore TAMC-compatibility, need following modifs: |
| 573 |
|
* use adoptfile tools/adjoint_options/adjoint_tamc_compatibility |
| 574 |
|
* use CPP option #define AUTODIFF_TAMC_COMPATIBILITY |
| 575 |
|
Tested TAF version is 1.9.22 |
| 576 |
|
N.B.: exch2 hand-written adjoint code currently not TAMC compatible |
| 577 |
|
|
| 578 |
|
checkpoint60 |
| 579 |
|
--->>> This is the last checkpoint for which generating the adjoint |
| 580 |
|
--->>> is done via the TAMC-compatibility TAF-flag "-nonewarg" |
| 581 |
|
--->>> by default. |
| 582 |
|
--->>> Future checkpoints will ommit this flag by default. |
| 583 |
|
o pkg/generic_advdiff, os7mp: simplify and avoid division by zero. |
| 584 |
|
o pkg/grdchk: Add gradient check to etan0 perturbations. |
| 585 |
|
o pkg/exf: read ice area from file (#ifdef ALLOW_ICE_AREAMASK). |
| 586 |
|
o pkg/autodiff: more flexibility in zeroadj. |
| 587 |
|
model/src: modifying do_oceanic_phys.F accordingly. |
| 588 |
|
o pkg/ctrl: Bounds for (kapgm,kapredi,eddypsi) parameter estimation. |
| 589 |
|
o model/src and pkg/gmredi: GMREDI_WITH_STABLE_ADJOINT CPP option |
| 590 |
|
special setup of gmredi for which the adjoint is stable |
| 591 |
|
enough for parameter optimization. |
| 592 |
|
o bridging the gap between eddy stress and GM. |
| 593 |
|
-> eddyTau is replaced with eddyPsi (eddyTau = f x rho0 x eddyPsi) |
| 594 |
|
along with a change in CPP option (now ALLOW_EDDYPSI). |
| 595 |
|
-> when using GM w/ GM_AdvForm: |
| 596 |
|
The total eddy streamfunction (Psi = eddyPsi + K x Slope) |
| 597 |
|
is applied either in the tracer Eq. or in momentum Eq. |
| 598 |
|
depending on data.gmredi (intro. GM_InMomAsStress). |
| 599 |
|
-> ALLOW_EDDYPSI_CONTROL for estimation purpose. |
| 600 |
|
The key modifications are in model/src/taueddy_external_forcing.F |
| 601 |
|
pkg/gmredi/gmredi_calc_*F pkg/gmredi/gmredi_*transport.F |
| 602 |
|
|
| 603 |
|
checkpoint59r |
| 604 |
|
o new S/R (pkg/mdsio/mdsio_facef_read.F) reading of sNx+1 x sNy+1 array |
| 605 |
|
from per-face file (take S/R READSYMTILE_RS out of ini_curvilinear_grid.F); |
| 606 |
|
fix option to read coriolis(@ cell-corner) from files with CS-grid. |
| 607 |
|
o pkg/mnc: add some attributes to standard 1D-coordinate variables |
| 608 |
|
o pkg/diagnostics: enforce missing_value attribute for scalar variables at |
| 609 |
|
mass points, when using mnc for output |
| 610 |
|
- add runtime parameter (missing_value, missing_value_int) to override |
| 611 |
|
default (which is the value of getcon('UNDEF')) |
| 612 |
|
o pkg/mnc: prepare mnc for the actual use of missing values with the |
| 613 |
|
diagnostics package: small fix in mnc_cw_readwrite.template and more |
| 614 |
|
initialisation of never used fields |
| 615 |
|
- replace mnc_common.h and mnc_id_header.h with corresponding upper case |
| 616 |
|
versions |
| 617 |
|
o pkg/thsice/thsice_ini_vars.F added default initial values so that |
| 618 |
|
thermodynamics sea ice solver does not blow up when some initial fields |
| 619 |
|
are missing. |
| 620 |
|
o move from external_forcing_surf.F to ini_forcing.F |
| 621 |
|
the p-coord. hack consisting in using pLoad to set phi0surf ; |
| 622 |
|
update output of tutorial_global_oce_in_p (affected @ truncation level). |
| 623 |
|
o Freshen up a bit hs94.1x64x5, notably: |
| 624 |
|
remove rotationPeriod and tRef=5*0. (adjoint only), and add |
| 625 |
|
exactConserv=.TRUE. |
| 626 |
|
o pkg/generic_advdiff: |
| 627 |
|
change option GAD_ALLOW_SOM_ADVECT to GAD_ALLOW_TS_SOM_ADV which only |
| 628 |
|
applies to files where Temperature & Salinity 2nd Order moments are used. |
| 629 |
|
o pkg/ptracers: add second-order moment advection schemes (80 and 81); |
| 630 |
|
this uses a dynamically allocated internal state data structure |
| 631 |
|
(#define PTRACERS_ALLOW_DYN_STATE in PTRACERS_OPTIONS.h) |
| 632 |
|
and requires a fortran 90 compiler |
| 633 |
|
|
| 634 |
|
checkpoint59q |
| 635 |
|
o pkg/mom_vecinv: Add energy & enstrophy conserving scheme (selectVortScheme=3) |
| 636 |
|
(from Sadourny, described by Burridge & Haseler, ECMWF Rep.4, 1977) |
| 637 |
|
o Refresh tutorial_global_oce_biogeo, notably: |
| 638 |
|
- change bathymetry (put back seamounts in ACC, use hFacs) |
| 639 |
|
- change EOS (POLY3 --> JMD95Z) |
| 640 |
|
- use Bryan-Lewis vertical diffusivity |
| 641 |
|
- use multidimensional advection |
| 642 |
|
- remove old virtual virtual in dic pkg, now done through ptracer pkg |
| 643 |
|
- change a couple of parameters in dic pkg |
| 644 |
|
o pkg/ctrl: change formula in adctrl_bound.F and add a parameter to ctrl_map_ini_gen.F |
| 645 |
|
o pkg/obcs: change default to OBCSfixTopo = .true., |
| 646 |
|
- set OBCSfixTopo=.false. in exp4/input/data.obcs to reproduce old result |
| 647 |
|
- replace "debugMode" with "debugLevel .GE. debLevB" |
| 648 |
|
o implementation of TAF directives for gchem,cfc,dic |
| 649 |
|
o remove "exp5" (replaced by tutorial_deep_convection). |
| 650 |
|
o pkg/obcs: add code to fix topography gradients normal to open boundaries; |
| 651 |
|
this requires computing the index fields OB_Jn/Js/Ie/Iw in obcs_readparms; |
| 652 |
|
the code can be turned on by setting OBCSfixTopo = .true. in data.obcs |
| 653 |
|
--> changes results in exp4, seaice_obcs |
| 654 |
|
o tutorial_deep_convection : |
| 655 |
|
update the set-up and increase resolution and domain size ; start |
| 656 |
|
from pseudo initial conditions = output at t=120mn in order to see |
| 657 |
|
something happening when running testreport. |
| 658 |
|
o pkg/seaice: add os7mp as an advection scheme |
| 659 |
|
add check for advection schemes |
| 660 |
|
add a flag for restoring T and S underneath sea ice |
| 661 |
|
o pkg/my82: add netcdf-support and diagnostics |
| 662 |
|
o thsice pkg: |
| 663 |
|
- Now hsMax limits snow height by turning it into ice following |
| 664 |
|
flooding scheme (and now conserving energy) |
| 665 |
|
- Slight rewriting of the formula in thsice_calc_thick.F |
| 666 |
|
- Parameter rhowi eliminated to be replaced by floodFac = (rhosw-rhoi)/rhos |
| 667 |
|
--> changes results of global_ocean.cs32x15.icedyn and global_ocean.cs32x15.thsice |
| 668 |
|
|
| 669 |
|
checkpoint59p |
| 670 |
|
o gchem / dic / cfc : |
| 671 |
|
- add useDIC, useCFC , read from "data.gchem" (& hold in GCHEM.h); |
| 672 |
|
- add new parameter files: "data.dic" & "data.cfc" ; |
| 673 |
|
- various re-arrangement in initialisation & header file ; |
| 674 |
|
- fix tutorial_global_oce_biogeo for multi-threaded test. |
| 675 |
|
o pkg/dic: test for "pickup_dic" file when restarting ; |
| 676 |
|
if no pickup-file, can restart with a re-initialised pH (same as it did |
| 677 |
|
before) providing pickupStrictlyMatch is set to False. |
| 678 |
|
o change argument list of S/R PTRACERS_WRITE_PICKUP & MYPACKAGE_WRITE_PICKUP |
| 679 |
|
+ fix call to S/R GGL90_WRITE_PICKUP & DIC_WRITE_PICKUP |
| 680 |
|
o add a "warning" (to Error msg file) when an Active Tracer is not using AB-2 |
| 681 |
|
and staggerTimeStep is off (needed for stability of Internal-wave dynamics). |
| 682 |
|
o move out of PARAMS.h & data the last pieces of old-ptracer code: tauTr1ClimRelax, |
| 683 |
|
& lambdaTr1ClimRelax ; put those 2 params in PTRACERS_PARAMS.h & data.ptracers |
| 684 |
|
(note: not clear to me what lambdaTr1ClimRelax is still used for ...) |
| 685 |
|
o pkg/mom_vecinv: - new parameter "selectVortScheme" to select which |
| 686 |
|
scheme to use for vorticty-term ; |
| 687 |
|
- compute upwindVorticity=T case within mom_vi_u/v_coriolis_c4.F |
| 688 |
|
(with default selectVortScheme, return to original discretisation) |
| 689 |
|
- remove weird combination (e.g.: upwindVorticity & highOrderVorticity) |
| 690 |
|
o pkg/seaice: add a line to the summary to indicate grid type (B/C) |
| 691 |
|
o in mom_calc_visc, fix average value of viscAh_W & viscA4_W next to the |
| 692 |
|
bottom ; only used with variable horizontal viscosity and non-hydrostatic. |
| 693 |
|
also fix diagnostics VISCAHW & VISCA4W. |
| 694 |
|
|
| 695 |
|
checkpoint59o |
| 696 |
|
o dome/code/obcs_calc.F: avoid division by zero (detected using gfortran). |
| 697 |
|
o change the loop ordering in most gad_*_adv_x.F to improve vectorization: |
| 698 |
|
move a few statemens out the main loop into separate loops |
| 699 |
|
o pkg/shelfice: |
| 700 |
|
- sort out freshwater flux; convert freshwater fluxes to mass fluxes |
| 701 |
|
(kg/m^2/s), does not break tests, because in verification/isomip, |
| 702 |
|
rhoConstFresh=rhoConst (by accident) |
| 703 |
|
- rearrange computation of tLoc, sLoc, pLoc to make code more efficient |
| 704 |
|
- move S/R find_rho_scalar, pkg/ecco/sw_ptmp.F, pkg/ecco/sw_adtg.F into |
| 705 |
|
new file model/src/seawater.F, so that they are available for all pkgs. |
| 706 |
|
- convert potential temperature into in-situ temperature. This changes the |
| 707 |
|
isomip tests => update tests |
| 708 |
|
o add a flag writePickupAtEnd (default=true) to be able to suppress |
| 709 |
|
writing a pickup at the last timestep |
| 710 |
|
o tools/mpack-1.6 : |
| 711 |
|
- disable automake (not working) and autoconf (not needed). |
| 712 |
|
- update to version 1.6.4 which fix MD5 code on some 64 bits platforms |
| 713 |
|
also cleaner with much less compilation warnings. |
| 714 |
|
o pkg/profiles: |
| 715 |
|
rename profiles_interp_mean_genericgrid as profiles_interp_mean_gg |
| 716 |
|
(for "less than 32 characters name" compiler requirement) |
| 717 |
|
o pkg/obcs and pkg/exf: added capability to specify seaice open boundary |
| 718 |
|
conditions that have a different sampling frequency than S/T/U/V obcs |
| 719 |
|
o pkg/diagnostics (stats-diags): |
| 720 |
|
- fix global Min/Max in case 1 processor get only empty tiles |
| 721 |
|
o genmake2: replace (4 times) |
| 722 |
|
make genmake_tc_1.o >> genmake_warnings 2>&1 |
| 723 |
|
with |
| 724 |
|
COMM="$CC $CFLAGS -c genmake_tc_1.c" |
| 725 |
|
echo $COMM >> genmake_warnings |
| 726 |
|
$COMM >> genmake_warnings 2>&1 |
| 727 |
|
to make genmake2 always see the value of CC as specified in the optfile. |
| 728 |
|
o generic_advdiff: - prather advection scheme (SOM) coded for CS-grid. |
| 729 |
|
- add diagnostics for 1srt & 2nd Order moments and sub-grid variance. |
| 730 |
|
- modify verification advect_cs test to test SOM-advection on CS-grid. |
| 731 |
|
o pkg/ctrl: |
| 732 |
|
- Rewrite of ctrl_map_ini_ecco.F, |
| 733 |
|
introducing a generic routine (ctrl_map_ini_gen.F). |
| 734 |
|
- Modification of ctrl_bound/adctrl_bound handling control vector bounds. |
| 735 |
|
|
| 736 |
|
checkpoint59n |
| 737 |
|
o pkg/diagnostics: for large number of diagnostics, store diagnostic mate |
| 738 |
|
number in dedicate array "hdiag": |
| 739 |
|
- new version of S/R DIAGNOSTICS_ADD2LIST : DIAGNOSTICS_ADDTOLIST |
| 740 |
|
with 1 more argument (mate number); modify old version DIAGNOSTICS_ADD2LIST. |
| 741 |
|
- many small changes (integer format) for large number of diagnostics |
| 742 |
|
- start to use DIAGNOSTICS_ADDTOLIST (necessary for diagnostics with |
| 743 |
|
a counter mate) in pkg diagnostics, ptracers, thsice & aim_v23. |
| 744 |
|
o add parameter rotateGrid and Euler angles EulerPhi/Theta/Psi. For |
| 745 |
|
usingSphericalGrid, this allows to define the rotated grid coordinates |
| 746 |
|
via phiMin/thetaMin/dxSpacing/dySpacing, etc., but then re-compute the |
| 747 |
|
geographical coordinates according to the inverse of the rotation defined |
| 748 |
|
by the Euler angles, so that Coriolis parameter and online-interpolation by |
| 749 |
|
exf works with the geographical coordinates on XC/YC/XG/YG. |
| 750 |
|
Naturally, this feature does not work with all packages, so some |
| 751 |
|
combinations are prohibited in config_summary (flt, flt_zonal, ecco, |
| 752 |
|
profiles), because there the coordinates are assumed to be regular |
| 753 |
|
spherical grid coordinates. |
| 754 |
|
o pkg/gmredi,ctrl,ecco,autodiff,grdchk and model/src,inc: |
| 755 |
|
- introduce isopycnal diffusion coefficient control. |
| 756 |
|
o tools/adjoint_options: |
| 757 |
|
- additional control vector components. |
| 758 |
|
o pkg/mnc: have mnc create marginally meaning full coordinate variables |
| 759 |
|
(that is the grid indices) if usingCurvilinearGrid and NOT EXCH2 |
| 760 |
|
o pkg/mypackage: |
| 761 |
|
- add example of read/write pickup for state-var ; |
| 762 |
|
- add entry points to the main code for state-vars diags & write-pickup. |
| 763 |
|
o pkg/exf: rewrite of exf_getffieldrec.F to properly deal with year |
| 764 |
|
transitions for useExfYearlyFields |
| 765 |
|
- add new subroutine that determines the file to read from for |
| 766 |
|
use*YearlyFields = .TRUE. and .FALSE. |
| 767 |
|
- add a verification experiment to global_with_exf that tests |
| 768 |
|
useExfYearlyFields with USE_EXF_INTERPOLATION defined |
| 769 |
|
o pkg/obcs/exf: add useOBCSYearlyFields (=.FALSE.) to obcs with exf in |
| 770 |
|
analogy to useExfYearlyFields; rearrange obcs_prescribe_read: two new |
| 771 |
|
subroutines (which could be generated from a template, because they are |
| 772 |
|
almost identical), for now they are included in obcs_prescribe_read.F for |
| 773 |
|
simplicity |
| 774 |
|
o pkg/exf: |
| 775 |
|
- add a little more diagnostic to exf_interp_read (in analogy to |
| 776 |
|
mds_read_field, can be turned off with debugLevel < debugLevA=1) |
| 777 |
|
- improve vectorizability of exf_interp for TARGET_NEC_SX, makes code |
| 778 |
|
ugly but fast by unrolling short inner loops, inserting a unroll=8 |
| 779 |
|
directive in routine lagran, and splitting a loop and making do while the |
| 780 |
|
outermost loop (the latter requires the intoduction of index arrays) |
| 781 |
|
o pkg/obcs: replace obcs_apply_area/heff/hsalt/hsnow with obcs_apply_seaice |
| 782 |
|
o pkg/seaice: moved DIFFERENT_MULTIPLE from seaice_model to seaice_dynsolver |
| 783 |
|
http://forge.csail.mit.edu/pipermail/mitgcm-devel/2008-January/003173.html |
| 784 |
|
o verification/seaice_obcs: updated for restart test and latest options |
| 785 |
|
o pkg/seaice: add a new flag SEAICEuseTEM to use a slightly different |
| 786 |
|
ice rheology (so-called truncated ellipse, that gets rid of tensile stress); |
| 787 |
|
for now this is only available for the C-grid code and also within |
| 788 |
|
#ifdef SEAICE_ALLOW_TEM, because this option may slow down the EVP code |
| 789 |
|
|
| 790 |
|
checkpoint59m |
| 791 |
|
o pkg/seaice: use different time constant for melting (SEAICE_gamma_t) |
| 792 |
|
and freezing (SEAICE_gamma_t_frz) ice due to mixed layer temperature |
| 793 |
|
o gad_som : fix flux output (& diagnostics) to have same units as other |
| 794 |
|
advection scheme fluxes (was previously multiplied by deltaT). |
| 795 |
|
o added verification/seaice_obcs both to test seaice open boundaries |
| 796 |
|
and to provide an example matlab scrpt for generating them |
| 797 |
|
o added verification/lab_sea/input.salt_plume for testing pkg/salt_plume |
| 798 |
|
o pkg/salt_plume: clean up salt_plume_frac.F to |
| 799 |
|
remove redundancy in PlumeMethod 1 and 4 |
| 800 |
|
o pkg/kpp: added saltplume diagnostics |
| 801 |
|
o pkg/obcs and pkg/seaice: |
| 802 |
|
- do not set uice and vice to zero when OB*icefile are unspecified |
| 803 |
|
- OBCS_SEAICE_AVOID_CONVERGENCE is undefined by default |
| 804 |
|
- moved seaice tracer obcs after call to seaice_growth |
| 805 |
|
o pkg/salt_plume: added various options for salt plume depth |
| 806 |
|
criterion and for vertical distribution of the salt |
| 807 |
|
|
| 808 |
|
checkpoint59l |
| 809 |
|
o pkg/ptracers: new version of ptracers pickup: |
| 810 |
|
read meta file and write only fields which are needed to restart. |
| 811 |
|
( same logic as main pickup file ; also using pickupStrictlyMatch ) |
| 812 |
|
o pkg/seaice: |
| 813 |
|
- add timescale for melting due to warm mixed layer as a means of |
| 814 |
|
setting SEAICE_availHeatFrac more conveniently |
| 815 |
|
- add a CPP-flag/runtime parameter check for flooding algorithm |
| 816 |
|
- reformulated availHeat in seaice_growth.F to be independent of AREA |
| 817 |
|
o change units attribute of EmPmR netcdf variables to kg/m^2/s to reflect recent |
| 818 |
|
unit changes |
| 819 |
|
o pkg/obcs: added OBCS_SEAICE_AVOID_CONVERGENCE constraint |
| 820 |
|
o cg2d.F: add 3 compiler directives that speed up this routine by 30% on a NEC |
| 821 |
|
SX vector computer. |
| 822 |
|
o pkg/seaice: |
| 823 |
|
- removed SEAICE_FFIELDS.h and seaice_get_forcing.F |
| 824 |
|
seaice forcing fields can now be read only through pkg/exf |
| 825 |
|
- removed some unused halos |
| 826 |
|
o no longer write pickup from THE_MODEL_MAIN but always from FORWARD_STEP |
| 827 |
|
o pkg/exf: added useRelativeWind EXF_PARAM.h option for subtracting U/VVEL |
| 828 |
|
or U/VICE from U/VWIND before computing U/VSTRESS |
| 829 |
|
|
| 830 |
|
checkpoint59k |
| 831 |
|
o pkg/seaice: ICE2WATR=SEAICE_rhoIce/rhoConst for consistency between |
| 832 |
|
dynamics and thermodynamics. Set ICE2WATR=0.92 to reproduce older results. |
| 833 |
|
o fix un-initialised variable problem (in mom_vecinv & shap_filt): |
| 834 |
|
all experiments pass when compile with un-initialised var. checking option. |
| 835 |
|
o added pkg/salt_plume |
| 836 |
|
o script to test restart (for now, in MITgcm_contrib/jmc_script) |
| 837 |
|
o pkg/seaice: new read/write pickup version. |
| 838 |
|
read meta file and write only fields which are needed to restart. |
| 839 |
|
( same logic as main pickup file ; also using pickupStrictlyMatch ) |
| 840 |
|
o pkg/seaice: fix bug in seaice_ocean_stress (call of seaice_calc_strainrates) |
| 841 |
|
o lab_sea.hb87: modify the domain & update output.hb87.txt : |
| 842 |
|
lat-long grid & no-slip BC in seaice-dynamics produce different sigma12 |
| 843 |
|
at j=1 & j=Ny+1 : this case is not treated correctly in the restart |
| 844 |
|
process. Fixed here by closing the domain at the Northern boundary. |
| 845 |
|
o pkg/rw: cleaning-up: call directly new MDSIO S/R MDS_READ/WRITE_FIELD. |
| 846 |
|
o pkg/mdsio: add new arguments to MDS_READ/WRITE_FIELD for reading/writing |
| 847 |
|
a set of consecutive levels in/from a 3-D array. |
| 848 |
|
o pkg/ptracers: |
| 849 |
|
use a 2 characters string ioLabel to identify tracer (if more than 99 tracers). |
| 850 |
|
to-do: fix pkg/diagnostics when large number of diagnostics are defined. |
| 851 |
|
|
| 852 |
|
checkpoint59j |
| 853 |
|
o in pkgs: dic, obcs, offline, rbcs: |
| 854 |
|
standard way to compute coeff. for time interpolation between 2 time reccords |
| 855 |
|
which retains full precision (& make results less dependent on compiler). |
| 856 |
|
update output of exp: tutorial_cfc_offline & tutorial_global_oce_biogeo. |
| 857 |
|
o pkg/cfc: if compiled with exf and seaice, cfc now can use fields from those |
| 858 |
|
packages instead of reading ice cover and wind speed separately |
| 859 |
|
o split PTRACERS.h in 2 header files: PTRACERS_FIELDS.h & PTRACERS_PARAMS.h |
| 860 |
|
(keep a temporary version of PTRACERS.h in verification/OpenAD/code_ad_openad |
| 861 |
|
to allow to compile customized code before the update) |
| 862 |
|
o cleaning-up: |
| 863 |
|
- fix CPP instruction syntax in pkg/obcs |
| 864 |
|
- replace (some) call to MDSIO S/R with call to RW interface S/R ; and |
| 865 |
|
add #ifdef ALLOW_MDSIO elsewhere (allows to compile without pkg/mdsio) |
| 866 |
|
- fix some threads issue in IO parts. |
| 867 |
|
o pkg/dic: |
| 868 |
|
- add tons of "_d 0" (--> much better testreports !) |
| 869 |
|
and then update outputs of tutorial_global_oce_biogeo |
| 870 |
|
o pkg/mom_fluxform: |
| 871 |
|
add a special version of momentum advection intended to conserve momentum |
| 872 |
|
next to a bathymetry step or a coastline edge. (default = off = #undef) |
| 873 |
|
o new read/write pickup version: |
| 874 |
|
- for now, only implemented for main (mdsio) pickup file. |
| 875 |
|
- write out only what is needed to restart; merge pickup_nh , pickup_ph |
| 876 |
|
and main pickup together. |
| 877 |
|
- read meta file; read only what is needed to restart; stop if a field |
| 878 |
|
is missing (if pickupStrictlyMatch=T, = the default) or try to restart |
| 879 |
|
if it make sense (even if the restart is not perfect). |
| 880 |
|
- if no meta file, assume that pickup to read corresponds exactly to |
| 881 |
|
a pickup that would currently be written. |
| 882 |
|
- read pickup written in the old format (until checkpoint59i) if it |
| 883 |
|
recognizes an old meta file (no field-list). |
| 884 |
|
- add a meta file in exp. which starts from a pickup: 2 cases: |
| 885 |
|
a) minimal meta file (with just file precision) + pickupStrictlyMatch=F |
| 886 |
|
e.g.: global_ocean.90x40x15/input/pickup.0000036000.meta |
| 887 |
|
b) a meta file describing the content of the associated pickup file |
| 888 |
|
e.g.: tutorial_global_oce_biogeo/input/pickup.0004248000.meta |
| 889 |
|
o pkg/mdsio & pkg/rw: |
| 890 |
|
- new routine to read a meta file ; new set of routine to read |
| 891 |
|
Multiple-fields file (with meta file). |
| 892 |
|
o added open boundary conditions capability for seaice |
| 893 |
|
HSNOW, HSALT, UICE, and VICE |
| 894 |
|
|
| 895 |
|
checkpoint59i |
| 896 |
|
o adjoint: |
| 897 |
|
* fix multiDimAdvection adjoint |
| 898 |
|
(partial recomputation problem by TAF for fVerT(:,:,kDown) |
| 899 |
|
and comlev1 size definition (maxpass vs. max. number of tracers) |
| 900 |
|
* verification/global_ocean.90x45x15 adjoint now tests |
| 901 |
|
NLFS and multiDimAdvection using DST3 (=30) |
| 902 |
|
* verification/lab_sea now tests multiDimAdvection using DST3 (=30) |
| 903 |
|
o pkg/kpp: add "_d 0" to real constant (if missing); |
| 904 |
|
update output of exp: natl_box (10.digits); vermix (std, 7.digits) |
| 905 |
|
and lab_sea, 3.FW (only 6,4,6 digits match) & AD (8.digits). |
| 906 |
|
o prepare for "clever pickup" implementation: add new header file "RESTART.h" |
| 907 |
|
for internal parameters related to restart process (formerly from PARAMS.h) |
| 908 |
|
and add startAB parameter to argument list of S/R ADAMS_BASHFORTH2. |
| 909 |
|
o more standard interface to {PKG}_WRITE_PICKUP with pickup suffix passed |
| 910 |
|
as argument. (only atm2d & obcs write_pickup have not yet been updated) |
| 911 |
|
o pkg/monitor: |
| 912 |
|
- use GLOBAL_SUM_TILE instead of _GLOBAL_SUM |
| 913 |
|
- fix mon_stats_rs (statistics over the full domain, even where field is zero) |
| 914 |
|
- account for deep Atmosphere factor and density factor (anelastic) |
| 915 |
|
o added open boundary conditions capability for seaice HEFF and AREA |
| 916 |
|
o pkg/shelfice: add option for convservative form of Hellmer&Olbers (1989) |
| 917 |
|
thermodynamics |
| 918 |
|
- requires a little reorganization, which affects the testreport results |
| 919 |
|
of isomip.htd (only 7 digits of cg2d agree) => update/modify experiment, |
| 920 |
|
so that now the conservative form is tested |
| 921 |
|
- add a few comments |
| 922 |
|
o add missing cvs Header: or Name: in eesupp/*, pkg/* & verification/code* |
| 923 |
|
o add a little bit of code to gad_os7mp_adv_?.F to help vectorization |
| 924 |
|
o add new diagnostics to seaice: advective, diffusive fluxes (only for |
| 925 |
|
multidim-advection, for scheme 2 they are not filled) and transports, |
| 926 |
|
thermodynamic growth rates |
| 927 |
|
o change units of EmPmR (inside the code, + within coupling interface) |
| 928 |
|
from m/s to kg/m2/s (mass flux) but leave input file unchanged. |
| 929 |
|
Affects results @ truncation level (cg2d match) and update output of |
| 930 |
|
experiments: lab_sea(6), global_ocean.90x40x15(10), |
| 931 |
|
global_ocean.cs32x15(11x3,10), natl_box(11), tutorial_global_oce_latlon(11) |
| 932 |
|
+ adjoint results: global_ocean_ebm(11) and lab_sea (12). |
| 933 |
|
Coupled set-up: allow to restart from previous pickups (cpl_oldPickup=T). |
| 934 |
|
Next: will retire convertEmP2rUnit (simply using mass2rUnit instead). |
| 935 |
|
|
| 936 |
|
checkpoint59h |
| 937 |
|
o pkg/exf: |
| 938 |
|
- improve vectorization by moving if-statement out of loops in |
| 939 |
|
exf_mapfields, exf_radiation |
| 940 |
|
- exf_bulkformulae.F: introduce 2D fields and vectorize code |
| 941 |
|
o pkg/kpp: added the salt plume scheme (ALLOW_SALT_PLUME) to KPP package |
| 942 |
|
o testreport: |
| 943 |
|
- allow to test for Qnet & SeaIce monitor output; clean-up ALLOW_BULK_OFFLINE |
| 944 |
|
monitor & update offline_exf_seaice exp. output. |
| 945 |
|
- AD testing: pass/FAIL according to Grad. output accuracy (instead of Cost) |
| 946 |
|
o pkg/seaice: |
| 947 |
|
- bug fix in the evp solver: boundary conditions were affected be |
| 948 |
|
masking of zMax/zMin (changes results) |
| 949 |
|
- minor bug fix in boundary conditions in seaice_calc_strainrates |
| 950 |
|
(changes results for no_slip) |
| 951 |
|
- seaice_lsr.F: make interpolation of eta dependent on boundaries |
| 952 |
|
- replace hardcoded lower limit for zeta (zMin) by runtime parameter |
| 953 |
|
- add a test to lab_sea, that tests the Hibler and Bryan (1987) ocean |
| 954 |
|
stress formulation and no-slip boundary conditions |
| 955 |
|
o pkg/ptracers: Temporary fix for PTRACERS_useGMRedi & PTRACERS_useKPP |
| 956 |
|
in gad_calc_rhs.F ; add few safety stops in initialisation phase. |
| 957 |
|
o pkg/seaice: a first HSALT time stepping equation has been checked in |
| 958 |
|
o pkg/seaice: replaced maskW with seaiceMaskU and maskS with seaiceMaskV |
| 959 |
|
in seaice_lsr.F; this solves the pkg/seaice-pkg/obcs problem |
| 960 |
|
without requiring DO-IF statements |
| 961 |
|
o pkg/thsice: |
| 962 |
|
use continuous power-law function for partition of energy between lateral |
| 963 |
|
melting/freezing and thinning/thickening ; old code using step function |
| 964 |
|
still available with #undef THSICE_FRACEN_POWERLAW |
| 965 |
|
update output of exp: aim.5l_cs.thSI, global_ocean.cs32x15.icedyn & .thsice |
| 966 |
|
o testreport: change AD testing : check against results/output_adm.txt |
| 967 |
|
using same scripts as for forward test. |
| 968 |
|
|
| 969 |
|
checkpoint59g |
| 970 |
|
o adjoint testing: in preparation for changing testreport: |
| 971 |
|
- output format: cost and grad written on separated lines |
| 972 |
|
- ad output results in directory "results" (instead of "results_ad") |
| 973 |
|
o pkg/seaice: adding ice salinity HSALT as a prognostic variable |
| 974 |
|
o pkg/seaice: changes for using pkg/seaice with pkg/obcs |
| 975 |
|
o pkg/ecco: allow user defined cost function contributions |
| 976 |
|
o testreport: |
| 977 |
|
Allow to choose (per experiment) the list of tested output variables |
| 978 |
|
and the main variable (used to issue a pass/FAIL ) ; |
| 979 |
|
- for now, done by adding the specific list in file: [exp]/input/tr_checklist |
| 980 |
|
- default is unchanged: >cg2d< , (T,S,U,V,5 tracers)_[min,max,mean,StD] ; |
| 981 |
|
Also modify printing of summary: |
| 982 |
|
a) ">" NN "<" indicates the "main" variable (used for pass/FAIL) |
| 983 |
|
b) echo the list of tested variables in the individual summary.txt of |
| 984 |
|
each experiment. |
| 985 |
|
o new S/R GLOBAL_SUM_TILE to compute global sum independently of number of |
| 986 |
|
threads and number of processes (with #define GLOBAL_SUM_SEND_RECV) |
| 987 |
|
(but still depend on the tile decompostion of the domain). |
| 988 |
|
o pkg/seaice: change a discretization detail to make the B-grid code |
| 989 |
|
"more symmetric". This change is likely to remove all "ridges/leads" that |
| 990 |
|
where quasi-aligned with the grid in B-grid solutions. It may also be |
| 991 |
|
the solution to the stress coupling issues with the B-grid. |
| 992 |
|
o each tested exp: add a "run" directory with a standard ".cvsignore" file ; |
| 993 |
|
remove .cvsignore from input dir. (since testreport no longer run here). |
| 994 |
|
o pkg/thsice: |
| 995 |
|
- cleaning: move common block out of "THSICE_2DYN.h" (removed) to "THSICE_VARS.h" |
| 996 |
|
- fix reshaping of sea-ice just after advection: |
| 997 |
|
melt all the ice only if ice-volume is too small. |
| 998 |
|
- re-visit lateral/thinning repartition of melting (modifs from May 04, 2007): |
| 999 |
|
prevent lateral melting if sea-ice fraction is too close to iceMaskMin ; |
| 1000 |
|
and update experiment global_ocean.cs32x15.icedyn (+start from pickup files). |
| 1001 |
|
o external_forcing_surf : extend the use of salt_EvPrRn & temp_EvPrRn (fresh-water |
| 1002 |
|
tracer content) to linFS or no RealFreshWaterFlux ; default remains unchanged. |
| 1003 |
|
o define mass2rUnit & rUnit2mass as units conversion factor, used for surface |
| 1004 |
|
forcing. mass2rUnit: from mass per unit area [kg/m2] to r-coordinate unit |
| 1005 |
|
(z-coord: =1/rhoConst ; p-coord: =gravity) ; rUnit2mass is just the reverse; |
| 1006 |
|
and remove horiVertRatio (& recip_horiVertRatio). Affects truncation error |
| 1007 |
|
of exp. global_oce_in_p: 10 16 16 14 16 13 16 16 16 13 13 13 16 13 13 12 16 |
| 1008 |
|
-> update output.txt |
| 1009 |
|
o pkg/cd_code: add brackets in multiple terms sum (S/R CD_CODE_SCHEME): |
| 1010 |
|
this affects truncation error: -> update output.txt of exp: |
| 1011 |
|
global_ocean.90x40x15 (fw&adm), lab_sea (fw&adm) & lab_sea.lsr, |
| 1012 |
|
ideal_2D_oce, isomip.htd, natl_box, tutorial_global_oce_latlon. |
| 1013 |
|
|
| 1014 |
|
checkpoint59f |
| 1015 |
|
o pkg/autodiff: zero_adj resets an ajoint variable to zero (in adjoint mode) |
| 1016 |
|
o pkg/ctrl: ctrl_bound forces parameter corrections to stay in |
| 1017 |
|
a bounded range (in forward mode) |
| 1018 |
|
o pkg/ecco, ctrl, autodiff and mom_common: |
| 1019 |
|
internal parameter controls, completements of implementations |
| 1020 |
|
o add few EXCH S/R (UV_BGRID, UV_DGRID, SM) for B & D-Grid velocity & 2nd Moment Sxy. |
| 1021 |
|
o use UV_BGRID exch for dxV,dyU: for now, only with pkg/exch2 & forward ; |
| 1022 |
|
(not seem any difference in testing results). |
| 1023 |
|
o pkg/cd_code: use the right EXCH calls (for CS-grid); but problem remains |
| 1024 |
|
at face corners. |
| 1025 |
|
o pkg/generic_advdiff: |
| 1026 |
|
- in GAD.h, define as parameters (iMinAdvR,iMaxAdvR,jMinAdvR,jMaxAdvR) |
| 1027 |
|
loop range indices for computing vertical advection tendency |
| 1028 |
|
and do the calculation in the interior only (no overlap) ; |
| 1029 |
|
for now, only implemented for SOM advection (to save CPU time). |
| 1030 |
|
- add argument "withSigns" to S/R FILL_CS_CORNER_TR_RL (needed for SOM_xy moment) |
| 1031 |
|
o exch2 adjoint |
| 1032 |
|
First set of changes: |
| 1033 |
|
- add exch2 hand-written adjoint templates |
| 1034 |
|
- exch2 hand-written no longer use TAF-flag 'nownew_arg' |
| 1035 |
|
This will require cleanup in pkg/autodiff/*.F |
| 1036 |
|
(changed routines currently kept separate in verif. code/) |
| 1037 |
|
- Comment all relevant #ifndef ALLOW_AUTODIFF_TAMC |
| 1038 |
|
that used to hide exch2 or cubed-sphere specific code |
| 1039 |
|
(commented via 'cph-exch2') |
| 1040 |
|
o pkg/seaice |
| 1041 |
|
- Close southern and western boundaries for UICE/VICE when useOBCS=.TRUE. |
| 1042 |
|
o pkg/bulk_force: fix loading into Qsw of Short-Wave flux; and update |
| 1043 |
|
output of global_ocean.cs32x15.thsice . |
| 1044 |
|
|
| 1045 |
|
checkpoint59e |
| 1046 |
|
o exch2: new S/R that only use the cube-tracer (center-position) exchange: |
| 1047 |
|
for B-grid vector (not yet tested) and C-grid vector (<- only used |
| 1048 |
|
when option W2_USE_R1_ONLY in W2_OPTIONS.h is defined). |
| 1049 |
|
o starting implementation of Duffy et al. (GRL 1999) salt plume scheme |
| 1050 |
|
(#ifdef ALLOW_SALT_PLUME) |
| 1051 |
|
o gather_2d/scatter_2d: removed halo regions |
| 1052 |
|
o gmredi: add option (GM_taper_scheme='fm07') for Ferrari & McWilliams 2007 |
| 1053 |
|
scheme and the corresponding test case (under front_relax dir). For now, |
| 1054 |
|
only available with Skew-flux form and not yet tested in realistic set-up. |
| 1055 |
|
adjoint: store directives updated, but gradient checks deteriorated, |
| 1056 |
|
so maybe GM/Redi adjoint is now broken. |
| 1057 |
|
o seaice adjoint |
| 1058 |
|
* add AREA, HEFF, HSNOW as control variable |
| 1059 |
|
(should not change lab_sea results) |
| 1060 |
|
* CTRL_OPTIONS.h needs new flag: CTRL_SET_OLD_MAXCVARS_40 |
| 1061 |
|
o pkg/seaice: |
| 1062 |
|
* added computation of saltFlux in seaice_growth; |
| 1063 |
|
For time being, sea ice salinity is assumed constant |
| 1064 |
|
contribution of snow flooding to freshening of sea ice is neglected. |
| 1065 |
|
SEAICE_salinity is set in SEAICE_PARM01 of data.seaice and it |
| 1066 |
|
defaults to 0.0 in order to maintain backward compatibility. |
| 1067 |
|
Typical values for SEAICE_salinity are 4 to 10 g/kg. |
| 1068 |
|
* replaced dRf(1) with dRf(kSurface)*hFacC(kSurface) in seaice_growth.F |
| 1069 |
|
* added SEAICE_availHeatFrac, which specifies fraction of surface level |
| 1070 |
|
heat content used to melt or grow ice |
| 1071 |
|
* commented out cap of HICE: it helps keep ice thinner |
| 1072 |
|
* reintroduced cap of HEFF via MAX_HEFF and SEAICE_CAP_HEFF option |
| 1073 |
|
* applied OBCS T/S mask to HEFFM sea ice mask |
| 1074 |
|
|
| 1075 |
|
checkpoint59d |
| 1076 |
|
o standard name: {PKG}_DIAGNOSTICS_STATE to fill diagnostics array |
| 1077 |
|
for {PKG} state variables, and called from DO_STATEVARS_DIAGS. |
| 1078 |
|
(keep {PKG}_DIAGNOSTICS_FILL for non-state variables diagnostics) |
| 1079 |
|
o pkg/gmredi (gmredi_readparms.F): add some missing "_d 0" |
| 1080 |
|
and change default value of parameter "GM_Small_Number"; |
| 1081 |
|
update output of exp: lab_sea (x2), cfc_example, global_ocean.90x40x15, |
| 1082 |
|
global_ocean.cs32x15 (x4), global_ocean_ebm, global_with_exf, |
| 1083 |
|
tutorial_global_oce_biogeo, tutorial_global_oce_latlon |
| 1084 |
|
o pkg/ecco: cost function when applying pkg/smooth to controls |
| 1085 |
|
o pkg/ctrl: add forcingPrecond run time parameter |
| 1086 |
|
o pkg/seaice: |
| 1087 |
|
- replace ZMIN=4.e8 with ZMIN=0. in dynsolver.F as in C-grid code |
| 1088 |
|
- fix bug in metric terms of u-equation in LSR solver (implicit part), |
| 1089 |
|
changes verification/lab_sea |
| 1090 |
|
- rearrange implicit part of u-equation in LSR solver to make it easier to |
| 1091 |
|
read, understand, and debug. This causes changes at the truncation level. |
| 1092 |
|
- fix (serious) bug in the boundary conditions (sign error in the implicit |
| 1093 |
|
part) of the LSR solver. Changes all LSR results. |
| 1094 |
|
- fixed problem with HSNOW initialization to avoid thick snow when AREA |
| 1095 |
|
is initilized with small values - does not change lab_sea results. |
| 1096 |
|
- added HsnowFile initialization capability |
| 1097 |
|
o pkg/smooth: addition to model/src and pkg/ctrl so allow |
| 1098 |
|
initialization of pkg/smooth and application to control vector |
| 1099 |
|
o pkg/seaice: fix another bug in the LSR no-slip boundary conditons |
| 1100 |
|
o dependencies: pkg/profiles requires pkg/cal |
| 1101 |
|
o pkg/profiles: |
| 1102 |
|
- added option ALLOW_PROFILES_GENERICGRID |
| 1103 |
|
-> pkg/profiles can thus be used with any grid (e.g. cs32x15) assuming |
| 1104 |
|
that interpolation information (grid points and coefficients) is provided |
| 1105 |
|
within the netcdf input files. |
| 1106 |
|
-> sample matlab scripts can be found in MITgcm_contrib/gael |
| 1107 |
|
that allow you to prepare netcdf input files. |
| 1108 |
|
- also modified: cleaner include statements, cleaner error print statements, |
| 1109 |
|
cleaner stops when error, and more tests of the netcdf input files consistency. |
| 1110 |
|
o additional test (in global_ocean.cs32x15) using seaice+thsice pkgs. |
| 1111 |
|
o pkg/seaice: |
| 1112 |
|
- move seaice-diagnostics from seaice_do_diags to do_statevars_diags; this |
| 1113 |
|
requires a new routine: seaice_diagnostics_fill.F |
| 1114 |
|
- make sure that seaice does not move if not forced (pressure replacement |
| 1115 |
|
method, Hibler and Ip, 1995), changes results |
| 1116 |
|
- and new damping criterion for EVP solver according to Hunke, JCP, 2001 |
| 1117 |
|
- SEAICE_evpDampC = > 0. turns it on (615. is the recommended value). |
| 1118 |
|
It is turned off by default (=-1.), because it changes the results. |
| 1119 |
|
- make it possible to read AREA from a file, too. |
| 1120 |
|
|
| 1121 |
|
checkpoint59c |
| 1122 |
|
o add S/R and diagnostics for oceanic mixed-layer depth |
| 1123 |
|
o move GMRedi call after all vertical mixing schemes (including KPP) |
| 1124 |
|
o pkg/thsice: |
| 1125 |
|
- ensure iceMask > iceMaskMin : this problem appeared after May-04 modifs |
| 1126 |
|
(melt only laterally if thin ice): update output of global_ocean.cs32x15.thsice |
| 1127 |
|
o pkg/obcs: |
| 1128 |
|
- bug fix for balance code |
| 1129 |
|
o pkg/seaice: |
| 1130 |
|
- allow values of SEAICE_elasticParm > 1 |
| 1131 |
|
- add new parameter SEAICE_evpTauRelax as an alternative |
| 1132 |
|
to SEAICE_elasticParm |
| 1133 |
|
- make lsr boundary conditions free slip (by default), changes result |
| 1134 |
|
- add code for no slip boundary conditions for lsr |
| 1135 |
|
- set minimum of zeta to zero (and not 4e8) (changes results) |
| 1136 |
|
- add a cap on AREA after advecting AREA if seaice_growth is not called |
| 1137 |
|
o change calculation of Visbeck K: |
| 1138 |
|
- no longer depend on tapering scheme; instead, compute slope (limited |
| 1139 |
|
by GM_maxSlope). this is equivalent to what was comuted before with |
| 1140 |
|
clipping or linear tappering. |
| 1141 |
|
- fix vertical averaging (wrong by 1/2 level) |
| 1142 |
|
- leave the old version (but will not be maintained) within |
| 1143 |
|
#ifdef OLD_VISBECK_CALC / #endif |
| 1144 |
|
- update output of exp. ideal_2D_oce |
| 1145 |
|
o change error catch in calc_r_star to improve vectorization |
| 1146 |
|
o exf runoff and seaice: remove ALLOW_SEAICE from exf pkg files and |
| 1147 |
|
add #define ALLOW_RUNOFF in SEAICE_OPTIONS.h (when not using exf). |
| 1148 |
|
o adjoint: |
| 1149 |
|
Re-organized adjoint checkpointing according to Matt Mazloff |
| 1150 |
|
(but with modifs/completions/cleanups) |
| 1151 |
|
Storing is now bundled into large arrays to optimized I/O |
| 1152 |
|
(and second step in cleanup of the_main_loop) |
| 1153 |
|
|
| 1154 |
|
checkpoint59b |
| 1155 |
|
o coupler (pkg/atm_ocn_coupler, pkg/ocn_compon_interf, pkg/atm2d): |
| 1156 |
|
- export/import (between ocean & coupler) fields needed for ocean DIC. |
| 1157 |
|
o pkg/seaice: |
| 1158 |
|
- get rid of three more exchanges seaice_calc_viscosities (required |
| 1159 |
|
different loop boundaries in seaice_lsr and seaice_ocean_stress) |
| 1160 |
|
- bug fix in seaice_ocean_stress (update of lab_sea required) |
| 1161 |
|
- reduce loop boundaries to necessary minimum also in seaice_evp |
| 1162 |
|
- go back to the old way of computing deltaC/Z as the adjoint likes that |
| 1163 |
|
better |
| 1164 |
|
o Refresh of tutorial_global_oce_latlon (includes changing salinity-like |
| 1165 |
|
passive tracer to an Age Tracer) + update output.txt |
| 1166 |
|
o pkg/exf: |
| 1167 |
|
- implement A-grid / C-grid selection for wind-stress input files. |
| 1168 |
|
- clean-up exf_wind.F (remove us, use wspeed instead ; add wStress) |
| 1169 |
|
for now, in exf_bulk_largeyeager04.F only : |
| 1170 |
|
- change implementation for case where windspeed + 2. components wind-stress |
| 1171 |
|
are read-in. AND use rhoConstFresh to convert evap. |
| 1172 |
|
o pkg/seaice: |
| 1173 |
|
- use correct EXCH_UV for wind-forcing (on A-grid). |
| 1174 |
|
- change SEAICE_OPTIONS.h to limit the number of option combinations (regarding |
| 1175 |
|
SEAICE_EXTERNAL_FORCING & SEAICE_EXTERNAL_FLUXES); add corresponding stops. |
| 1176 |
|
o pkg/exf: |
| 1177 |
|
- default EXF options are now set in EXF_OPTIONS.h (ifndef ALLOW_AUTODIFF_TAMC) |
| 1178 |
|
EXF_INTERPOLATION: |
| 1179 |
|
- merge global_with_exf/code version of exf_interp_read.F |
| 1180 |
|
to the main code ; |
| 1181 |
|
- Add new option: EXF_INTERP_USE_DYNALLOC to use Dynamical Allocation when |
| 1182 |
|
reading the file ; Important: This options needs to be defined to recover |
| 1183 |
|
previous code. |
| 1184 |
|
otherwise, use fixed size array to read in (size=exf_interp_bufferSize). |
| 1185 |
|
- no longer loose real*8 precision along the way when using exf_iprec=64. |
| 1186 |
o pkg/seaice: rearrangement of common blocks (really needs more cleaning up) |
o pkg/seaice: rearrangement of common blocks (really needs more cleaning up) |
| 1187 |
|
- change discretisation of evp-solver in order to avoid another exchange |
| 1188 |
|
(changes lab_sea) and clean up a little |
| 1189 |
|
- replace SQRT(MAX(deltaC,SEAICE_EPS)) by MAX(SQRT(deltaC),SEAICE_EPS) |
| 1190 |
|
help the adjoint (this also changes the results slightly) |
| 1191 |
|
- add a few "_d 0" where they had been missing in seaice_evp.F |
| 1192 |
|
- cleaning up: remove unused seaice_calc_rhs.F |
| 1193 |
o pkg/exf: some cleaning-up: |
o pkg/exf: some cleaning-up: |
| 1194 |
- change various "constants" into runtime parameters |
- change various "constants" into runtime parameters |
| 1195 |
- cleaned-up Large&Yeager04 routine which should eventually |
- cleaned-up Large&Yeager04 routine which should eventually |
| 1203 |
o pkg/thsice: |
o pkg/thsice: |
| 1204 |
fix few little problems, in thsice_calc_thickn.F: |
fix few little problems, in thsice_calc_thickn.F: |
| 1205 |
- growth vertically (and not laterally) if iceFrac == iceMaskMax |
- growth vertically (and not laterally) if iceFrac == iceMaskMax |
| 1206 |
- melt laterally only if hIce < hThinIce (as the comments say) |
- melt only laterally if hIce < hThinIce (as the comments say) |
| 1207 |
and in thsice_extend.F: |
and in thsice_extend.F: |
| 1208 |
- allow to form ice even when iceFrac == iceMaskMax (by increasing thickness) |
- allow to form ice even when iceFrac == iceMaskMax (by increasing thickness) |
| 1209 |
- start to form ice as soon as the minimum ice-volume is reachable. |
- start to form ice as soon as the minimum ice-volume is reachable. |
| 1219 |
o pkg/seaice |
o pkg/seaice |
| 1220 |
- check for inconsistent evp parameter/cpp-flag combination |
- check for inconsistent evp parameter/cpp-flag combination |
| 1221 |
- remove leftover errIO flat for obsolete name list error handling |
- remove leftover errIO flat for obsolete name list error handling |
| 1222 |
|
o OpenAD |
| 1223 |
|
- changed verification/OpenAD to full baroclinic setup (including GM/Redi) |
| 1224 |
|
|
| 1225 |
checkpoint59a |
checkpoint59a |
| 1226 |
o pkg/seaice: some parameter clarifications and a little bit of clean up |
o pkg/seaice: some parameter clarifications and a little bit of clean up |
| 1240 |
ATMOSPHERIC_LOADING is #define). |
ATMOSPHERIC_LOADING is #define). |
| 1241 |
o pkg/kpp: replaced _KPP_RL with _RL |
o pkg/kpp: replaced _KPP_RL with _RL |
| 1242 |
o bug fixes for vertical diffusivity computations when both KPP and |
o bug fixes for vertical diffusivity computations when both KPP and |
| 1243 |
3D diffusivity arrays are used. |
3D diffusivity arrays are used; pkg/kpp/kpp_calc_diff_s & _t.F |
| 1244 |
|
are no longer updating the vertical diffusivity array |
| 1245 |
|
(passed as argument) but are (re-) setting those arrays. |
| 1246 |
o pkg/seaice: fix bug in evp solver, while doing that |
o pkg/seaice: fix bug in evp solver, while doing that |
| 1247 |
- change (improve?) discretization of stress computations for both |
- change (improve?) discretization of stress computations for both |
| 1248 |
cgrid-lsr and evp solver |
cgrid-lsr and evp solver |
| 2724 |
- my82 (Mellor and Yamada, 1982) level 2 turbulence closure scheme |
- my82 (Mellor and Yamada, 1982) level 2 turbulence closure scheme |
| 2725 |
- these scheme operate in a similar manner as KPP (without ghat, of |
- these scheme operate in a similar manner as KPP (without ghat, of |
| 2726 |
course), however there is only one diffusivity that is used for both |
course), however there is only one diffusivity that is used for both |
| 2727 |
temperature and salinity (and passive tracers)ç |
temperature and salinity (and passive tracers) |
| 2728 |
o add offline package |
o add offline package |
| 2729 |
o add "verification/dic_example" which contains a dic-gchem-ptracer setup |
o add "verification/dic_example" which contains a dic-gchem-ptracer setup |
| 2730 |
provided by Stephanie Dutkiewicz |
provided by Stephanie Dutkiewicz |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch