| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o model/src/external_forcing_surf.F |
| 8 |
|
- add storage directives for EmPmR and PmEpR to avoid recomputation of seaice_model |
| 9 |
|
in the adjoint that is problematic when seaice_model is turned off in the adjoint. |
| 10 |
|
The resolved issue dated back to july when EXTERNAL_FORCING_SURF call was moved. |
| 11 |
|
Update global_ocean.cs32x15/results/output_adm.seaice_dynmix.txt accordingly. |
| 12 |
|
|
| 13 |
|
o pkg/exf/exf_check.F |
| 14 |
|
- fix a small bug again (originally found by Wentao Liu, now found again) |
| 15 |
|
- streamline error output |
| 16 |
|
o pkg/streamice and aim_v23: |
| 17 |
|
replace a few "_EXCH_XY_RL (" with "_EXCH_XY_RL(", so that |
| 18 |
|
Apple's /usr/bin/cpp knows what to do: |
| 19 |
|
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn) |
| 20 |
|
Target: x86_64-apple-darwin13.0.0 |
| 21 |
|
|
| 22 |
|
checkpoint64s (2014/01/05) |
| 23 |
|
o tools/adjoint_options: |
| 24 |
|
- switch to fastopt.net TAF server (instead of default fastopt.de) for |
| 25 |
|
AD optfiles adjoint_diva & adjoint_f95 (similar to adjoint_default). |
| 26 |
|
o model/src: |
| 27 |
|
- remove some unnecessary TAF storage directives in forward_step.F and |
| 28 |
|
in dynamics.F (note: not always removed by TAF, e.g., double storage |
| 29 |
|
of kappaRU,kappaRV in former version of dynamics.F). |
| 30 |
|
o model/src & pkg/ptracers: |
| 31 |
|
- call directly GAD_IMPLICIT_R & IMPLDIFF + DWNSLP_APPLY from temp_integrate.F |
| 32 |
|
salt_integrate.F and ptracers_integrate.F (instead of from thermodynamics.F) |
| 33 |
|
and remove ptracers_dwnslp_apply.F & ptracers_implicit.F |
| 34 |
|
- call MATRIX_STORE_TENDENCY_EXP for each tracer (in ptracers_integrate.F) |
| 35 |
|
- add fZon & fMer as output argument of S/R GAD_CALC_RHS. |
| 36 |
|
- update TAF AD-output of experiments global_ocean.90x40x15 (13 for AD-grad). |
| 37 |
|
o useSingleCpuInput separates single-CPU input from single-CPU output; |
| 38 |
|
for now only implemented for in exf_interp_read.F |
| 39 |
|
o verification/advect_xy: |
| 40 |
|
- fix missing EXCH call in local version of ini_salt.F and update output. |
| 41 |
|
o momentum diagnostics: |
| 42 |
|
- fix which deltaT is used in Total-Tendency diagnostics. |
| 43 |
|
- fix typo in diagnostics for momentum tendency from AB. |
| 44 |
|
o pkg/seaice/seaice_lsr.F: fix an initialisation bug for the |
| 45 |
|
SEAICE_VECTORIZE_LSR_ZEBRA option that lead to NaNs on a NEC-SX8 |
| 46 |
|
|
| 47 |
|
checkpoint64r (2013/12/08) |
| 48 |
|
o verification/*/results: |
| 49 |
|
- Update reference output of experiments that were passing with just 13 digits |
| 50 |
|
(make it easier to detect future changes in results) |
| 51 |
|
o model/src & pkg/ptracers: |
| 52 |
|
- move calls to GAD_ADVECTION (Multi-Dim advection) from thermodynamics.F to |
| 53 |
|
inside temp_integrate.F and salt_integrate.F and from ptracers_advection.F |
| 54 |
|
to inside ptracers_integrate.F ; remove ptracers_advection.F |
| 55 |
|
o coupling interface pkgs: |
| 56 |
|
[atm_compon_interf, ocn_compon_interf & atm_ocn_coupler] |
| 57 |
|
- change the config check to test the agreement of Ocean Depth |
| 58 |
|
with ATM land/sea mask (instead of ATM orography); |
| 59 |
|
- send to coupler the number of coupler time-steps to do for this run: |
| 60 |
|
this allows to check for consistency and don't need anymore to be |
| 61 |
|
specified in parameter file "data"; |
| 62 |
|
in coupler: |
| 63 |
|
- check consistency of RunOff map versus Ocean Depth and ATM land/sea mask. |
| 64 |
|
- improve report to log-file of config setting (pass log-file unit to few S/R) |
| 65 |
|
o pkg/compon_communic: |
| 66 |
|
- add coupling send/receive for non-tiled integer vector; |
| 67 |
|
- add S/R to check and stop if any proc has an error (similar to |
| 68 |
|
eesupp/src/stop_if_error.F but single thread and across Comm_World). |
| 69 |
|
o pkg/exch2: |
| 70 |
|
- in exch2*_get_rx[1,2]: use new list "W2_tileIndex" to replace search |
| 71 |
|
through list of all tiles my proc owns. |
| 72 |
|
o model/src: |
| 73 |
|
- AUTODIFF only: in calc_adv_flow.F, recompute rTransKp (instead of copying |
| 74 |
|
from rTrans) to simplify dependencies (no need to store rTrans anymore in |
| 75 |
|
calling S/R); this affects AD results at machine truncation level: |
| 76 |
|
update AD-output (TAF) of experiments: 1D_ocean_ice_column, |
| 77 |
|
bottom_ctrl_5x5 & obcs_ctrl (12 digits for AD grad, same FWD grad). |
| 78 |
|
o tools/build_options: |
| 79 |
|
- simplify Warnings options (-ieee & -devel cases) in linux_amd64_gfortran |
| 80 |
|
o coupling interface pkgs: |
| 81 |
|
[compon_communic, atm_compon_interf & ocn_compon_interf] |
| 82 |
|
- move declaration of local array "ibuf" out of header file "CPLR_SIG.h" |
| 83 |
|
to each S/R that needs it; remove un-used variables. |
| 84 |
|
- change component tile registration (cpl_register.F in both compon_interf |
| 85 |
|
and mitcomponent_tile_register.F) to pass the full list of tiles |
| 86 |
|
information (including bi,bj) in 1 vector (instead of in a bi,bj matrix). |
| 87 |
|
- with pkg/exch2: adopt the same convention used for I/O to define mapping |
| 88 |
|
towards coupler global array (unless W2_useE2ioLayOut=F): |
| 89 |
|
a) can now use different tiling between atm & ocn comp. |
| 90 |
|
b) no needs to modify the run-Off map when changing tiling (was needed |
| 91 |
|
even if using the same tiling between atm & ocn). |
| 92 |
|
c) will allow to run with blank-tiles in 1 component (e.g., for ocean |
| 93 |
|
full land tiles); not yet tested. |
| 94 |
|
- check for valid mapping from comp. tile to coupler global array |
| 95 |
|
- improve report of tile registration results to log file. |
| 96 |
|
o pkg/exch2: |
| 97 |
|
- in eesupp/src/eeboot.F: move call to W2_EEBOOT before Coupler |
| 98 |
|
tile-registration (CPL_REGISTER); |
| 99 |
|
- activate (un-comment) definition and setting of "W2_tileIndex" list to |
| 100 |
|
store the local bi,bj indices of each tile; |
| 101 |
|
- also print bi,bj in local report to log file; |
| 102 |
|
- fix pkg/debug/debug_cs_corner_uv.F for the case nSy > 1 (left from |
| 103 |
|
Jun 2009 modif of pkg/exch2). |
| 104 |
|
o testing on baudelaire: |
| 105 |
|
- run 2 tests at a time: no significant slow down (since enough cpu) and |
| 106 |
|
get the full set of test done earlier |
| 107 |
|
- switch the ifort test to "-devel" ; run the OpenAD test everyday. |
| 108 |
|
o model/src/thermodynamics.F and routines called from it: |
| 109 |
|
- pkg/gmredi: gmredi_residual_flow.F (replacing gmredi_calc_uvflow.F & |
| 110 |
|
gmredi_calc_wflow.F) to update eulerian velocity (input) into residual |
| 111 |
|
velocity (outp) by adding bolus velocity. |
| 112 |
|
- model/src: calc_adv_flow.F (replacing calc_common_factors.F) to compute |
| 113 |
|
mass transport from velocity + lateral grid cell area |
| 114 |
|
- rename calc_gt.F to temp_integrate.F (includes call to TIMESTEP_TRACER) |
| 115 |
|
- rename calc_gs.F to salt_integrate.F (includes call to TIMESTEP_TRACER) |
| 116 |
|
in thermodynamics.F |
| 117 |
|
- remove k from thermodynamics.F and move it to temp_integrate.F |
| 118 |
|
salt_integrate.F and ptracers_integrate.F (now done inside the tracer |
| 119 |
|
loop). |
| 120 |
|
- compute locally (in thermodynamics.F) 3-D velocity field that is used to |
| 121 |
|
advect tracers; pass it as argument to GAD_ADVECTION, GAD_SOM_ADVECT, |
| 122 |
|
PTRACERS_ADVECTION, TEMP_INTEGRATE, SALT_INTEGRATE, PTRACERS_INTEGRATE, |
| 123 |
|
GAD_IMPLICIT_R and PTRACERS_IMPLICIT |
| 124 |
|
- update AD-output (TAF & OAD) of experiments: 1D_ocean_ice_column, |
| 125 |
|
global_ocean.90x40x15, tutorial_global_oce_biogeo and |
| 126 |
|
tutorial_tracer_adjsens (+ TLM output). |
| 127 |
|
o tools/OAD_support and (verification/*/) code_oad: |
| 128 |
|
- OAD_support/cb2mGetModules.csh: add PACKAGES_CONFIG.h in header file to |
| 129 |
|
module conversion ; remove unneeded CPP_EEOPTIONS.h. |
| 130 |
|
- code_oad/CPP_OPTIONS.h: remove PACKAGES_CONFIG.h and use a more standard |
| 131 |
|
version (closer to model/inc/CPP_OPTIONS.h). |
| 132 |
|
o model/src: |
| 133 |
|
- remove parameter "useOldFreezing" from PARAMS.h and push it to the |
| 134 |
|
retired list of parameters (routine FREEZE has been replace by surface |
| 135 |
|
freezing (10.yrs ago) and by pkg/frazil (interior freezing). |
| 136 |
|
o pkg/gmredi: |
| 137 |
|
- add option (GM_CALC_TRANSP_FROM_VEL) to compute transport directly from |
| 138 |
|
velocity (same scheme but affects machine truncation) for GM_AdvForm. |
| 139 |
|
- update output of FWD experiments: front_relax.bvp, |
| 140 |
|
global_ocean.90x40x15.dwnslp, global_ocean.cs32x15 and ideal_2D_oce. |
| 141 |
|
|
| 142 |
|
checkpoint64q (2013/11/17) |
| 143 |
|
o verification: |
| 144 |
|
- generate new output on baudelaire (gfortran, -ieee) for OpenAD experiments |
| 145 |
|
tutorial_global_oce_biogeo and global_ocean.90x40x15. |
| 146 |
|
- generate new output (growth & melt) for seaice_itd experiment after |
| 147 |
|
updating the input pickup_seaice files (previously wrong). |
| 148 |
|
o pkg/cost: |
| 149 |
|
- define a "final cost function" for each tile, and use GLOBAL_SUM_TILE_RL |
| 150 |
|
(instead of _GLOBAL_SUM_RL) to get the final cost from all procs & threads: |
| 151 |
|
o this fixes global-sum value if multi-threads (since GLOBAL_SUM_TILE_RL |
| 152 |
|
cannot be applied to var in common block). |
| 153 |
|
o allows to get results independent of tile-per-proc setting (if using |
| 154 |
|
slower GLOBAL_SUM_SEND_RECV option). |
| 155 |
|
- update accordingly: seaice_cost_final.F, shelfice_cost_final.F, |
| 156 |
|
thsice_cost_final.F and ecco_cost_final.F (this one affects lab_sea |
| 157 |
|
forward gradients: update output). |
| 158 |
|
- update */code_oad/externalDummies.F by adding dummy GLOBAL_SUM_TILE_RL |
| 159 |
|
S/R and, for most exp., also comment out GLOBAL_SUM_R8. |
| 160 |
|
o pkg/mom_common: |
| 161 |
|
- move to pkg/mom_common and model/src (previously in tutorial_deep_convection |
| 162 |
|
code) 2nd version of isotropic 3-D Smagorinsky code interface: strain and |
| 163 |
|
viscosity are locally declared in dynmics.F and pass as argument to CALC_GW; |
| 164 |
|
ensure that all field value that are used are set. |
| 165 |
|
o tutorial_deep_convection (smag3d): |
| 166 |
|
- add missing scaling in mom_calc_smag_3d.F; |
| 167 |
|
- set smag3D_coeff in input.smag3d such that results do not change. |
| 168 |
|
o pkg/dic: |
| 169 |
|
- change dic_cost.F to compute cost on each tile first and then apply |
| 170 |
|
GLOBAL_SUM_TILE_RL: this affects forward gradient of AD experiments |
| 171 |
|
tutorial_dic_adjoffline & tutorial_global_oce_biogeo; update output. |
| 172 |
|
- remove kLev argument and use GLOBAL_SUM_TILE_RL in tracer_meanarea. |
| 173 |
|
o eesupp/src & pkg/mdsio: |
| 174 |
|
- remove gather/scatter_vector.F (from eesupp) and mdsio_read/writevector.F |
| 175 |
|
(from pkg/mdsio) since they are no longer used for tape IO. |
| 176 |
|
- move simple C subroutine "setdir.c" from pkg/compon_communic to eesupp/src |
| 177 |
|
(+ keep a copy in pkg/atm_ocn_coupler). |
| 178 |
|
o verification/isomip: |
| 179 |
|
- split domain in 8 squared tiles (instead of just 2) for FWD, AD & OAD tests. |
| 180 |
|
o tools/build_options: |
| 181 |
|
- optfile linux_amd64_ifort11, fast (no ieee) case: |
| 182 |
|
to get a working restart for all experiments, add "-fp-model source" |
| 183 |
|
to FOPTIM (also remove "-opt-streaming-stores auto" <- this is the default). |
| 184 |
|
|
| 185 |
|
checkpoint64p (2013/10/20) |
| 186 |
|
o pkg/autodiff: |
| 187 |
|
- adread_adwrite.F: when type and length do not match ALLOW_AUTODIFF_WHTAPEIO |
| 188 |
|
criteria, return to simple (default) tape IO format. |
| 189 |
|
o pkg/mdsio (+ eesupp/src): |
| 190 |
|
- rewrite/simplify tape-IO S/R (new S/R MDS_READ/WRITE_TAPE replace |
| 191 |
|
previous MDSREAD/WRITEVECTOR) with 2 array argument from each type (R4/R8); |
| 192 |
|
- fix globalFile and singleCpuIO options using simpler global mapping. |
| 193 |
|
- new pairs of scatter/gather vector S/R (one for each type, generated from |
| 194 |
|
template) corresponding to simpler global mapping. |
| 195 |
|
- adread_write.F: switch to new S/R (but leave old calls commented) and write |
| 196 |
|
to globalFile when parameter globalFiles is set to True. |
| 197 |
|
- switch on useSingleCpuIO in AD experiments: global_ocean.90x40x15 & isomip. |
| 198 |
|
o pkg/autodiff: |
| 199 |
|
- adread_adwrite.F: add a hack for RS arrays (when RS=real*4); |
| 200 |
|
with ALLOW_AUTODIFF_WHTAPEIO defined, since corresponding (real*4) is |
| 201 |
|
missing, just add a STOP if array type do not match. |
| 202 |
|
o pkg/exf: |
| 203 |
|
- to allow to use seaice-fraction from pkg/exf in other pkgs than pkg/seaice: |
| 204 |
|
rename CPP option EXF_ALLOW_SEAICE_RELAX to EXF_SEAICE_FRACTION |
| 205 |
|
and rename array obsSIce to exf_iceFraction. |
| 206 |
|
o tutorial_deep_convection: |
| 207 |
|
- add 1rst version of isotropic 3-D Smagorinsky code (from Louis-Philippe), |
| 208 |
|
for now all in this exp. code dir. |
| 209 |
|
- add secondary test using Smag-3D viscosity (keep very low backgroud visc for |
| 210 |
|
testing) and flux-limter advection scheme for Temp. (no explicit diffusion). |
| 211 |
|
o eesupp/src: |
| 212 |
|
- added SINGLE_DISK_IO option because reading of parameter files on |
| 213 |
|
very large number of processors did not work with existing set-up |
| 214 |
|
|
| 215 |
|
checkpoint64o (2013/09/25) |
| 216 |
|
o pkg/atm_phys & atm_compon_interf: |
| 217 |
|
- allows for coupling of gray-atmosphere (atm_phys) with ocean. |
| 218 |
|
o tools/build_options: |
| 219 |
|
- switch from "-fPIC" to "-mcmodel=medium" in optfiles: linux_amd64_gfortran |
| 220 |
|
& linux_amd64_ifort11 and in linux_amd64_g77 & linux_amd64_open64 also |
| 221 |
|
remove CPP setting (was identical to genmake2 default). |
| 222 |
|
o pkg/gmredi & model/src: Some updating and work done on the residual model. |
| 223 |
|
- created new file model/src/calc_eddy_stress.F to calculate the eddy stress. |
| 224 |
|
- fixed up the calculation of the eddy stress and how it is added to the |
| 225 |
|
external forcing via taueddy_external_forcing.F |
| 226 |
|
- at the moment, it is very experimental and only works with the variable eddy |
| 227 |
|
diffusivity calculated in gmredi_k3d.F |
| 228 |
|
o pkg/seaice/seaice_check.F: add a check to catch the case of specifying |
| 229 |
|
lw/swfluxfile instead of lw/swdownfile in data.exf together with pkg/seaice |
| 230 |
|
o testreport (& tools/do_tst_2+2): |
| 231 |
|
- for MPI test, set default COMMAND to 'mpirun -v -np TR_NPROC ./{executable}' |
| 232 |
|
o tools/build_options: linux_amd64_gfortran & linux_amd64_ifort11: |
| 233 |
|
- remove CPP='cpp -traditional -P' (this is genmake2 default) |
| 234 |
|
- add switch (for big setups) to use 'medium' memory-model (but leave it |
| 235 |
|
commented out for now). Note: needed with FC 19 to compile big setups. |
| 236 |
|
o pkg/atm_compon_interf: |
| 237 |
|
- regroup per field origin (model & pkgs) the coupling storage routines |
| 238 |
|
(which accumalate in time each coupling field) |
| 239 |
|
- move bi,bj loops inside atm_store_my_data.F and store also wind-stress; |
| 240 |
|
update accordingly + simplify aim_do_physics.F |
| 241 |
|
|
| 242 |
|
checkpoint64n (2013/08/26) |
| 243 |
|
o pkg/bbl: |
| 244 |
|
- update formulation to reduce dispersion of tracer properties in bbl |
| 245 |
|
- replaced horizontal and vertical transport parameters with velocities |
| 246 |
|
- changes results for verification/global_with_exf.yearly |
| 247 |
|
o verification/halfpipe_streamice: |
| 248 |
|
- change to matrix construction; update both Fwd & AD output. |
| 249 |
|
o verification/tutorial_tracer_adjsens: |
| 250 |
|
- OpenAD test: switch to vector-invariant momentum since fluxform with |
| 251 |
|
rStar causes problems with OpenAD; update output. |
| 252 |
|
o tools: |
| 253 |
|
- genmake2: define a common prefix for all temp-file names ; move them |
| 254 |
|
to local /tmp disk (but would be easy to move them back); |
| 255 |
|
- xmakedepend: apply the same switch for temp-files. |
| 256 |
|
o pkg/offline: |
| 257 |
|
- changes for use with rStar (NLFS): assume that we continue to provide |
| 258 |
|
UVELMASS/hFacW_ini & VVELMASS/hFacS_ini (hFacWi,S_ini as written in grid |
| 259 |
|
output files) and apply r* scaling at each time-step (function of the time |
| 260 |
|
varying Eta field); use normal pickup files (needed for restart with NLFS). |
| 261 |
|
o adjoint with OpenAD: |
| 262 |
|
- move OpenAD-specific files from verification/OpenAD/code_oad_all to a new |
| 263 |
|
package openad. This package has to be compiled for all runs with OpenAD |
| 264 |
|
instead of specifying code_oad_all as a modification directory. |
| 265 |
|
- link the fortran templates from tools/OAD_support to the build directory |
| 266 |
|
for preprocessing to avoid conflicts between different setups compiled |
| 267 |
|
simultaneously and simplify cleanup. |
| 268 |
|
o pkg/exf: |
| 269 |
|
- in exf_getforcing.F: comment out most of the EXCH calls (fields used by |
| 270 |
|
main model or other pkgs are exchanged in EXF_MAPFIELDS). |
| 271 |
|
o model/src: |
| 272 |
|
- do_stagger_fields_exchanges.F: skip EXCH calls when using pkg/offline |
| 273 |
|
(similar to do_fields_blocking_exchanges.F). |
| 274 |
|
o tools/genmake2: |
| 275 |
|
- remove TAF output src code just before calling staf (when not doing a fresh |
| 276 |
|
built, will stop if things go wrong with staf). |
| 277 |
|
- fix target "adobj" (left from TAF version-2 transition) |
| 278 |
|
o pkg/diagnostics: |
| 279 |
|
- add a parameter to track the status of pkg/diagnostics activation; |
| 280 |
|
this replace/extend the use of logical param "settingDiags" (to check |
| 281 |
|
when adding diag to the list) to also check any DIAGNOSTICS_[]FILL* call. |
| 282 |
|
New S/R to print error message and stop when pkgStatus is not right. |
| 283 |
|
- to try: add a warning when "data.diagnostics" exist but useDiagnostics=F. |
| 284 |
|
|
| 285 |
|
checkpoint64m (2013/08/13) |
| 286 |
|
o model/inc: |
| 287 |
|
- move FCORI_MACROS.h from PARAMS(_MACROS).h to GRID_MACROS.h (left from |
| 288 |
|
8 yrs ago modif when Coriolis arrays were moved from PARAMS.h to GRID.h) |
| 289 |
|
o pkg/kpp & aim_v23: |
| 290 |
|
- only call DIAGNOSTICS_FILL when useDiagnostics=TRUE. |
| 291 |
|
o pkg/seaice: |
| 292 |
|
- restore (last time on 2011/12/24) ability to compile pkg/seaice with |
| 293 |
|
undefined pkg/exf ALLOW_ATM_TEMP or ALLOW_RUNOFF CPP-options. |
| 294 |
|
- only call DIAGNOSTICS_FILL when useDiagnostics=TRUE. |
| 295 |
|
o eesupp/src: |
| 296 |
|
- fix check for overlap-size argument (myOLn.GT.MAX_OLY_EXCH) |
| 297 |
|
in exch1_rx[_ad].template (thanks to Francois Lefeuvre report). |
| 298 |
|
o switch to TAF version-2: |
| 299 |
|
- add flow directives to "freeze" naming convention for ad-routines that |
| 300 |
|
are used in I/O routines of adjoint state and associated common blocks |
| 301 |
|
that are used in adcommon.h (backward compatible with version-1) |
| 302 |
|
- update all ad-optfiles (in tools/adjoint_options + few local to some |
| 303 |
|
verification exp) to switch to latest TAF version (currently 2.5.5); |
| 304 |
|
merge "*_mpi" adoptfiles into the corresponding non-mpi (but commented |
| 305 |
|
out except for diva). |
| 306 |
|
- the major change with TAF version-2 is that both the differentiated |
| 307 |
|
routines and the forward routines (new) are returned as part of the TAF |
| 308 |
|
output source code. Update genmake2 accordingly. |
| 309 |
|
- new output for AD experiment tutorial_global_oce_biogeo (better AD gradient |
| 310 |
|
with version-2 when compared to TLM or FWD gradient); other experiments |
| 311 |
|
output show minor changes (machine truncation level); update the few AD & |
| 312 |
|
TLM output with 12 matching digits only (some prior to version-2 switch). |
| 313 |
|
|
| 314 |
|
checkpoint64l (2013/08/05) |
| 315 |
|
o model/src: |
| 316 |
|
- in dynamics.F, skip the call to CALC_VISCOSITY if momViscosity=F |
| 317 |
|
- main_do_loop.F: no longer includes additional (AUTODIFF) header files |
| 318 |
|
when using TAF but only if using OpenAD. |
| 319 |
|
o pkg/mom_common+fluxform+vecinv: |
| 320 |
|
- always set horiz. viscosity arrays to background value before calling |
| 321 |
|
MOM_CALC_VISC (in MOM_FLUXFORM & MOM_VECINV) and call S/R MOM_CALC_VISC |
| 322 |
|
only when using variable horiz. viscosity (useVariableVisc=T); |
| 323 |
|
- simplify mom_vecinv.F (only 1 block for momViscosity). |
| 324 |
|
o pkg/mom_common: variable horiz. viscosity in NH code |
| 325 |
|
- move horiz-viscosity 3-D arrays viscAh_W & viscA4_W (used in calc_gw.F) |
| 326 |
|
from model/inc/NH_VARS.h to pkg/mom_common/MOM_VISC.h |
| 327 |
|
- store in common block (in MOM_VISC.h) logical parameters: useHarmonicVisc, |
| 328 |
|
useBiharmonicVisc & useVariableVisc. |
| 329 |
|
- fix old bug (already in 1rst implementation of variable horizontal viscosity |
| 330 |
|
in calc_gw.F, version 1.27, 2006/06/20): |
| 331 |
|
horizontal bi-harmonic viscosity in gW was missing when wiscA4W=0 |
| 332 |
|
even if variable bi-harmonic viscosity (e.g., viscA4Grid) was non-zero. |
| 333 |
|
- change background horiz viscosity in vertical momentum (gW) to always be |
| 334 |
|
viscAhW,viscA4W (instead of switching to viscAhD, viscA4D when using |
| 335 |
|
any type of variable viscosity, e.g., viscAh/4Grid) |
| 336 |
|
- change default value of viscAhW,viscA4W to viscAhD,viscA4D (instead of |
| 337 |
|
viscAh,viscA4) which default to viscAh,viscA4 : this avoid missing |
| 338 |
|
horiz. viscosity in W eq when just setting viscAhD/Z,viscA4D/Z (since |
| 339 |
|
default viscAh,viscA4 is zero). |
| 340 |
|
o model/src: |
| 341 |
|
- extend length of drC & recip_drC from Nr to Nr+1. |
| 342 |
o Divided Adjoint (DIVA) with MPI: |
o Divided Adjoint (DIVA) with MPI: |
| 343 |
- genmake2: do not create local ./mpi_headers dir when no file to copy into. |
- genmake2: do not create local ./mpi_headers dir when no file to copy into. |
| 344 |
- remove option ALLOW_DIVIDED_ADJOINT_MPI (replaced by ALLOW_DIVIDED_ADJOINT |
- remove option ALLOW_DIVIDED_ADJOINT_MPI (replaced by ALLOW_DIVIDED_ADJOINT |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch