| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/obcs: |
| 8 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
| 9 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
| 10 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
| 11 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
| 12 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
| 13 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
| 14 |
|
o pkg/obcs: |
| 15 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
| 16 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
| 17 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
| 18 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
| 19 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
| 20 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
| 21 |
|
to replace hard-coded null index value of zero. |
| 22 |
|
o pkg/exch2: |
| 23 |
|
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
| 24 |
|
always check buffer-size (but outside the loop); move checking for valid |
| 25 |
|
index from W2_USE_E2_SAFEMODE to W2_E2_DEBUG_ON; in W2_E2_DEBUG_ON, |
| 26 |
|
print each tile and point connection only if |W2_printMsg|>= 2 and 3. |
| 27 |
|
o pkg/ctrl (pack & unpack): |
| 28 |
|
- in ctrl_pack.F & ctrl_unpack.F, use the same local file-name variable |
| 29 |
|
(locally defined) for different variables (+ remove the variable-specific |
| 30 |
|
file name in CTRL_GENARR.h). For now, only implemented for GENARR2/3D_CONTROL |
| 31 |
|
(to be extended to other local file names in ctrl.h). |
| 32 |
|
o pkg/flt: |
| 33 |
|
- add a FLT_Iter0 option (similar to PTRACERS_Iter0). |
| 34 |
|
o pkg/mdsio: |
| 35 |
|
- fix missing STOP in mdsio_readvec_loc.F (case ioUnit=0) when file is missing |
| 36 |
|
o tools/genmake2: |
| 37 |
|
- add similar dependences for target EXE_AD & EXE_FTL as we have for EXECUTABLE |
| 38 |
|
(added by Alistair in version 1.51 for building without make depend); |
| 39 |
|
- remove Header files list (H_SRC_FILES) from the dependence of targets |
| 40 |
|
ad_input_code.f & ftl_input_code.f (not clear why it was added in the first |
| 41 |
|
place in version 1.23): this save going through staf when unrelated header |
| 42 |
|
file has been modified. |
| 43 |
|
Note: for an intermediate target (e.g., ad_input_code.f or adtaf) without |
| 44 |
|
"make depend" step, still need to do "make links" before "make adtaf". |
| 45 |
|
o eesupp/src (+ few pkg src files) & genmake2: |
| 46 |
|
- finish to remove ALWAYS_USE_MPI in source code that TAF does not see; |
| 47 |
|
- no longer set ALWAYS_USE_MPI in Makefile (was done by genmake2). |
| 48 |
|
- improve genmake2 checking for ALLOW_${PKG} in CPP_OPTIONS.h files (distinguish |
| 49 |
|
upper/lower case ; account for space between "#" and undef/define) |
| 50 |
|
o pkg/flt (with exch2): |
| 51 |
|
- cleaning: fix so that it compiles; move remaining MPI calls out of flt_exch2.F; |
| 52 |
|
- simplify threads synchronisation; fix (many issues) multi-threaded with MPI. |
| 53 |
|
|
| 54 |
|
checkpoint63s (2012/09/05) |
| 55 |
|
o pkg/ecco: |
| 56 |
|
- remove #ifdef ALLOW_SMOOTH_CORREL3D brackets. |
| 57 |
|
- add more relevant #ifdef ALLOW_SMOOTH ones. |
| 58 |
|
- sort out useAtmWind, useSMOOTH, ctrlSmoothCorrel2D. |
| 59 |
|
o pkg/ctrl: |
| 60 |
|
- CTRL_OPTIONS.h : document CPPs related to smoothing; ALLOW_SMOOTH_CORREL2D/3D, |
| 61 |
|
ALLOW_CTRL_SMOOTH, ALLOW_SMOOTH_CTRL2D, ALLOW_SMOOTH_CTRL3D. |
| 62 |
|
- ctrl.h : document run time params doInitXX, doMainPack, doMainUnpack, doPackDiag, |
| 63 |
|
doSinglePrecTapelev (audodiff param!), ctrlSmoothCorrel2D (new) and |
| 64 |
|
ctrlSmoothCorrel3D (new). |
| 65 |
|
The added ctrlSmoothCorrel2D/3D replace the old ALLOW_SMOOTH_CORREL2D/3D CPP. |
| 66 |
|
- ctrl_readparms.F : initialise ctrlSmoothCorrel2D/3D and read from namelist. |
| 67 |
|
- ctrl_init.F ctrl_pack.F ctrl_unpack.F : switch off ustress/vstress |
| 68 |
|
controls when useAtmWind, and vice versa. |
| 69 |
|
- ctrl_map_ini_ecco.F : UVEL0, VVEL0, edtaux, edtauy cannot be smoothed as tracers. |
| 70 |
|
- ctrl_get_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL2D with |
| 71 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel2D, IF useSMOOTH. |
| 72 |
|
- ctrl_map_ini_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL3D with |
| 73 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel3D, IF useSMOOTH. |
| 74 |
|
- ctrl_set_pack_xy[z].F, ctrl_set_unpack_xy[z].F: |
| 75 |
|
replace ALLOW_SMOOTH_CORREL2D/3D brackets with ctrlSmoothCorrel2D/3D. |
| 76 |
|
o pkg/smooth: |
| 77 |
|
- remove un-necessary includes. |
| 78 |
|
- remove ALLOW_SMOOTH*D and ALLOW_SMOOTH_CORREL*D brakets. |
| 79 |
|
Those CPP options were never defined, and not necessary. |
| 80 |
|
o model/src: |
| 81 |
|
- fix CPP brackets in ini_mixing.F (GM_background_K belongs to gmredi). |
| 82 |
|
- standard treatment of useSMOOTH. |
| 83 |
|
o pkg/autodiff: |
| 84 |
|
- add LOGICAL useGGL90inAdMode, useGGL90inFwdMode, useSALT_PLUMEinAdMode, |
| 85 |
|
useSALT_PLUMEInFwdMode allowing to switch off ggl90 and salt_plume adjoint. |
| 86 |
|
o pkg/exch2: |
| 87 |
|
- add "if usingMPI" where it was missing (in exch2_rx?_cube*.template) |
| 88 |
|
+ start to remove ALWAYS_USE_MPI in source code that TAF does not see. |
| 89 |
|
- make new S/R W2_MAP_PROCS out of w2_eeboot.F to setup exch2 CommonFlag |
| 90 |
|
and tiles to process mapping. |
| 91 |
|
- re-arrange 3 header files (W2_EXCH2_PARAMS.h, _BUFFER.h & _TOPOLOGY.h) |
| 92 |
|
moving /EXCH2_FILLVAL_RX/ & /W2_EXCH2_COMMFLAG/ to W2_EXCH2_TOPOLOGY.h; |
| 93 |
|
rename "exch2_tProc" to "W2_tileProc" and move seting of e2FillValue_RX |
| 94 |
|
from w2_eeboot.F to w2_readparms.F. |
| 95 |
|
o eesupp/src: |
| 96 |
|
- set exchNeedsMemsync & exchUsesBarrier according to "usingMPI" (instead of |
| 97 |
|
ALWAYS_USE_MPI) + moved from ini_communication_patterns.F to eeset_parms.F; |
| 98 |
|
also move setting of exchCollectStatistics from exch_init.F to eeset_parms.F |
| 99 |
|
- in eedie.F and all_proc_die.F, always call MPI_FINALIZE when ALLOW_USE_MPI |
| 100 |
|
is defined (remove condition on usingMPI) to match cases where MPI_INIT |
| 101 |
|
has been called. |
| 102 |
|
- fix bug I put in previous modif of exch_sm_3d_rx.template (not much used); |
| 103 |
|
- change default (non-MPI) value of myPid (from 1 to 0) to match MPI settings |
| 104 |
|
(so that on 1 proc, get same myPid independently of usingMPI) |
| 105 |
|
- add a stop if multi-procs but usingMPI=F ; stop also if usingMPI=T and |
| 106 |
|
useCubedSphereExchange with EXCH-1 (safer). |
| 107 |
|
- add "if usingMPI" where it was missing (+ start to remove ALWAYS_USE_MPI). |
| 108 |
|
o pkg/ggl90: |
| 109 |
|
- fix bug in filling corner mask array "mskCor" (FILL_CS_CORNER_TR_RL call) |
| 110 |
|
used in ALLOW_GGL90_SMOOTH code. |
| 111 |
|
o pkg/flt: |
| 112 |
|
- fix typo in FLT_WITHOUT_Y_PERIODICITY (the effect was to ignore stopping |
| 113 |
|
floats at the Southern end of the domain). |
| 114 |
|
o eesupp/inc: |
| 115 |
|
- add a list of CPP-options which can be set by Makefile (DEF_IN_MAKEFILE.h); |
| 116 |
|
but not used (and not to be used) anywhere, just for documentation. |
| 117 |
|
o pkg/autodiff, exf, ptracers & seaice (AD & TL output): |
| 118 |
|
- comment out the very nasty "writeBinaryPrec = writeStatePrec" line, since: |
| 119 |
|
a) can damage previously written records in any other multi-record files. |
| 120 |
|
b) if needed, can easily do it cleanly, by calling S/R WRITE_REC_3D_RL/S. |
| 121 |
|
o tools/genmake2: |
| 122 |
|
- define variable MAKE within Makefile and use it in place of 'make'; |
| 123 |
|
- update AD_CONFIG.h (if needed) before building any of the executable |
| 124 |
|
(forward, adjoint or tangent-lin); this involves a 2nd invocation of make; |
| 125 |
|
and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h; |
| 126 |
|
- always print usual warning comment 'this file is automatically generated' |
| 127 |
|
from script convert_cpp_cmd2defines (+ remove this warning from genmake2). |
| 128 |
|
o pkg/cheapaml: |
| 129 |
|
- updated to correspond to the code used in accepted paper (Nico Wienders). |
| 130 |
|
o pkg/exf: |
| 131 |
|
added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch. |
| 132 |
|
ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F) |
| 133 |
|
and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h). |
| 134 |
|
o pkg/exf, autodiff, ctrl, ecco and seaice: |
| 135 |
|
remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones. |
| 136 |
|
o pkg/ctrl, ecco: |
| 137 |
|
allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL. |
| 138 |
|
Depending on useAtmWind, one is inactive, and the other is active (see |
| 139 |
|
exf_getffields.F/exf_getsurfacefluxes.F). |
| 140 |
|
o tools/genmake2: |
| 141 |
|
- improve error msg when failing in 2nd test of check_for_broken_Ff |
| 142 |
|
- fix option '-makefile' short-name (-mf according to genmake2 -help) |
| 143 |
|
- source local config file "genmake_local" just after processing the genmake2 |
| 144 |
|
command arguments (previously done before processing arg). |
| 145 |
|
o pkg/grdchk: |
| 146 |
|
- add a call to TURNOFF_MODEL_IO for Tangent-Linear run (in this case, call |
| 147 |
|
to this routine from cost_final has been dropped in g_cost_final) |
| 148 |
|
- improve printed information (more explicit msg, no longer using "print *," |
| 149 |
|
fix fcpertminus printed value). |
| 150 |
|
o model/src: |
| 151 |
|
- move call to COST_INIT_VARIA out of packages_init_variables.F directly |
| 152 |
|
into initialise_varia.F (just after calling PACKAGES_INIT_VARIABLES): |
| 153 |
|
this prevents getting cost-funct reset in adinitialise_varia recomputations. |
| 154 |
|
o pkg/dic: |
| 155 |
|
- move initialisation of "freefe" array from from dic_biotic_forcing.F to |
| 156 |
|
fe_chem.F: this prevents TAF from dropping this initialisation in TLM code. |
| 157 |
|
o pkg/grdchk: |
| 158 |
|
- grdchk_main.F : added CALL GLOBAL_SUM_INT( ierr , myThid ) |
| 159 |
|
- grdchk_getadxx.F etc. : omit I/O if ierr.EQ.0 |
| 160 |
|
o pkg/autodiff/ctrl/grdchk : |
| 161 |
|
- attempt to sort out what works and what does not, |
| 162 |
|
with regard to I/O, and to warn/stop accordingly. |
| 163 |
|
o pkg/grdchk: |
| 164 |
|
- attempt to fix grdchk in the case of useSingleCpuIO. |
| 165 |
|
- "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )" |
| 166 |
|
statements were moved from grdchk_main.F and into |
| 167 |
|
grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F. |
| 168 |
|
- a global sum is applied to record numbers icvrec/layer |
| 169 |
|
out of grdchk_loc so that they be passed to I/O routines. |
| 170 |
|
o pkg/smooth: |
| 171 |
|
- fix recomputation that appeared with nlfs : use smooth_recip_hFacC, |
| 172 |
|
smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case. |
| 173 |
o verification/testreport: |
o verification/testreport: |
| 174 |
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
| 175 |
- can also use compressed (gzip) reference output file; |
- can also use compressed (gzip) reference output file; |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch