/[MITgcm]/MITgcm/doc/tag-index
ViewVC logotype

Diff of /MITgcm/doc/tag-index

Parent Directory Parent Directory | Revision Log Revision Log | View Revision Graph Revision Graph | View Patch Patch

revision 1.1596 by gforget, Mon Feb 13 23:45:41 2012 UTC revision 1.1712 by gforget, Fri Aug 10 14:52:02 2012 UTC
# Line 4  $Name$ Line 4  $Name$
4      Notes on tags used in MITgcmUV      Notes on tags used in MITgcmUV
5      ==============================      ==============================
6    
7  o pkg/seaice :  o pkg/cost and pkg/ecco : attempt to sort out some of the limiting intricacies.
8    - simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula.EQ.    - pkg/cost.cost_final.F : allow for use of pkg/ecco and pkg/cost cost functions jointly.
9    1 or 2, using newly added run time parameter SEAICE_availHeatTaper.     The exclusive ifdefs were removed, to add costs terms (when defined) from both packages.
10      - the fc global sum in pkg/ecco/ecco_cost_final.F was removed accordingly.
11      - for objf_atl we use either the pkg/ecco or the pkg/cost term depending on CPPs.
12      - pkg/ecco and model/src : add CPP brackets around pkg/cost and pkg/ctrl includes of
13       "CTRL_SIZE.h" "ctrl.h" "ctrl_dummy.h" "optim.h" / "cost.h" accordingly.
14    o pkg/cost : add comments to explain special and/or untested setups.
15    o pkg/exf:
16      - use EXF_OPTIONS.h to set pkg/exf options except if done in ECCO_CPPOPTIONS.h
17        (previously, ALLOW_AUTODIFF_TAMC was controling this switch).
18    o verification/*/code_ad:
19      mimimal cleaning of AD experiments ECCO_CPPOPTIONS.h option-file:
20      - reccord when this file is included (define ECCO_CPPOPTIONS_H)
21      - remove the most obvious obsolete features (e.g., #define ALLOW_COST not
22        allowed since Oct 2003 in any option-file except in PACKAGES_CONFIG.h)
23    o pkg/seaice :
24      - added possibility to change ice strength/PRESS0 relationship to
25        HEFF, according to the following run time parameters
26        SEAICEpresPow0 :: HEFF exponent for ice strength below SEAICEpresH0 (integer, >0)
27        SEAICEpresPow1 :: HEFF exponent for ice strength above SEAICEpresH0 (integer, >0)
28        SEAICEpresH0   :: HEFF threshold for ice strength            (m)
29    o pkg/ggl90 :
30      - added run time flag mxlSurfFlag to include the code that ensure
31        mixing between first and second level (previously included as a comment)
32    o verification/1D_ocean_ice_column/input_ad/data.autodiff :
33      - add test of newly added dumpAdByRec=T option where
34        we write all records to one file per variable.
35    o verification/global_ocean.cs32x15/code_ad/CPP_OPTIONS.h :
36      - switch to #define ALLOW_BALANCE_RELAX and ALLOW_BALANCE_FLUXES
37        to check that this code is ok with taf and compiles in adjoint.
38    o pkg/autodiff :
39      - added run time param dumpAdByRec : ad dump format switch.
40        If true then write all records to one file per variable.
41        Else write one file per record (remains the default).
42      - revise seaice_ad_dump.F and exf_adjoint_snapshots_ad.F accordingly.
43    o pkg/seaice:
44     - Added SEAICEuseTILT run time switch : if set to
45       false then omit the tilt term in seaice dynamics.
46     - Fix free drift calculation.
47    o pkg/shelfice:
48      When initializing SHELFICEDragQuadratic, set default to be
49      consistent with shiCdrag in case SHELFICEuseGammaFrict is used,
50      but retain option to set it independently
51      (inconsistenty spotted by Veronique Dansereau)
52    o eesupp/inc:
53      - in EEPARAMS.h, add real-type constant for some frequently used simple number
54         (0,1,2,1/2), with name explicitly referring to RS/RL type.
55    o model/src:
56      - move balancing of relaxation terms to new S/R balance_relax.F.
57    o pkg/autodiff:
58      re-write active I/O high-level (control) S/R:
59      - rename  S/R ACTIVE_READ/WRITE_RL to ACTIVE_READ/WRITE_3D_RL
60      - add 1 more argument (useCurrentDir) to replace the "_LOC" 2nd set of S/R.
61      - use standard pkg/mdsio I/O routines (MDS_READ/WRITE_SEC_XZ/YZ  and
62        MDS_READ/WRITE_FIELD); change loops to multi-threads.
63      - update and merge active_file_control_slice.flow into active_file_control.flow
64      - update the calls in lower level S/R (active_file.F, active_file_g.F and
65        active_file_ad.F) keeping the argument list and function unchanged.
66      - also update lower-level "_LOC" version (call same S/R with "useCurrentDir
67        =.TRUE.") and remove high-level (control) _loc version (not called anymore).
68      - new low-level active I/O routines, one for each type (RL/RS), for active var
69        of various (XY,XZ,YZ) shape and level number (arguments: arrShape, myNr);
70        fix ctrl_init_wet.F & ecco_cost_weights.F by calling the new S/R with the
71        right type.
72    o autodiff and RS=real*4:
73      - call the right type (_RS instead of _RL) of S/R in few output S/R (pkg/exf
74        ad-monitor and snapshots); disable arrType='RS' in mdsio_gl*.F ;
75      - change argument type of 3-D mask argument to _RS to match type in the call
76        (in seaice_cost*.F, ctrl_*_gen.F and *ctrl_bound.F); to be continued.
77    o pkg/thsice:
78      - re-anable balanceEmPmR when useSEAICE=T with useThSIce=T.
79      - option to correct ocean fresh-water flux for imbalance of Atmos+Land
80        fresh-water flux: uniform correction or proportional to local precip.
81    o pkg/ctrl:
82      - new header file CTRL_SIZE.h for parameters maxCtrlArr2D, maxCtrlArr3D
83      - redefine CPP option ALLOW_BOTTOMDRAG_CONTROL to
84                            ALLOW_BOTTOMDRAG_CONTROL_NONGENERIC
85      - verification/hs94.1x64x5/ tests ALLOW_GENARR{2D,3D}_CONTROL
86    
87    checkpoint63q (2012/07/30)
88    o pkg/autodiff:
89      note about monitor and snap-shot of ad-variables:
90      a) need to apply ADEXCH before monitor or output of ad-vars to include
91       overlap contributions (was done for adjDump but missing for monitor).
92      b) since ADEXCH implies adding overlap values to interior array, machine
93       truncation error is expected when adding an ADEXCH call in the middle of
94       the time-stepping (although mathematically identical).
95      modifs:
96      - fix some incorrect type (RL/RS, UV/scalar) in ADEXCH calls and ad-vars
97        declaration (adEddyPsiX,adEddyPsiY in adcommon.h).
98      - add new run-time params (dumpAdVarExch & mon_AdVarExch) to select how  to
99        apply ADEXCH before monitor or snap-shot of ad-variables:
100           =0 : no ADEXCH ; =1 : do ADEXCH ; =2 : apply ADEXCH on a local copy.
101      - implement new method (copy+adexch) for snap-shot and monitor of main model
102        ad-vars (initially not used by default -> output unchanged).
103      - change default (set to 2) to use new method and update few output_adm.txt
104        with accurate ad-monitor (global_ocean.90x40x15, tutorial_global_oce_biogeo
105        and both tutorial_tracer_adjsens tests).
106      - switch 2 global_ocean.cs32x15 AD-tests to AB-2 (seaice_dynmix & thsice)
107        and turn off momDissip_In_AB in the 2 other (needed for stable AB-3).
108    o pkg/ctrl:
109      enable the use of a variable number (maxCtrlArr2D, maxCtrlArr3D) of
110      generic control variables via
111      #define ALLOW_GENARR2D_CONTROL and/or #define ALLOW_GENARR3D_CONTROL
112      Only required customization should be S/R ctrl_map_ini_genarr.F
113      (routine in repository contains example)
114    o pkg/exf:
115      - fix and refine checking of surface-relaxation setting when using EXF
116    o verification (adjoint exp):
117      - reduce length of simulation by half for experiment global_ocean.cs32x15
118        (std, seaice & seaice_dynmix) and exp tutorial_dic_adjoffline; update output.
119    o pkg/mom_common (mom_u/v_bottomdrag), pkg/shelfice (shelfice_u/v_drag)
120      - replace if statements KE.ne.0 with KE.gt.0 to avoid sqrt of negative numbers
121        of KE that can occur with aggressive optimization
122      + put quadratic bottom drag calculation in separated loops (only done if
123        using bottomDragQuadratic)
124    o model/src: CG2D_NSA
125      - clean-up:  stop if cg2dNormaliseRHS=T and AUTODIFF
126         and replace GLOBAL_SUM calls with GLOBAL_SUM_TILE.
127      - in test-exp that uses CG2D_NSA (bottom_ctrl & tutorial_tracer_adjsens),
128         change cg2d residual target to be expressed in Wunits (=> do not normalise
129         RHS ; this fix global_max Pb with TAF); update output.
130    o verification/tutorial_tracer_adjsens:
131       improve parameter consistency (and get rid of warnings):
132       - use deltaTFreeSurf=deltaTtracer (better with NonLin FreeSurf);
133       - switch Temp Adv Scheme from 81 to 80 (no limiter since theta < 0 is physical)
134       - use staggerTimeStep (for stability) in som81; use default rotation period.
135    o pkg/exch2:
136      - with empty facet: fix compact-format (W2_mapIO=1) definition (was previously
137        reset to 0 = 1 long line in X)
138    o pkg/mdsio:
139      - fix reading of dimensions from meta file for large-size domain
140    o model/src:
141      - fix saltIsActiveTr setting for IdealGas eosType (eosType is 6 character long);
142      - to refine CS-grid check, add logical flag "hasWetCSCorners": true if using
143        Cubed-Sphere Exch with CS-corners inside the domain;
144        make new S/R INI_GLOBAL_DOMAIN from code in ini_linear_phisurf.F to calculate
145        globalArea and to set hasWetCSCorners.
146      - add warning if usingCurvilinearGrid and momAdvection in flux-form (missing
147        metric terms); stop if hasWetCSCorners=T and momAdvection in flux-form.
148      - re-activate the stop if useCDscheme and hasWetCSCorners=T (previously if
149        useCDscheme and useCubedSphereExchange).
150    o pkg/seaice/seaice_growth.F :
151      - compute the SEAICE_DISABLE_HEATCONSFIX term accordingly
152        for the (.NOT.useRealFreshWaterFlux).OR.(nonlinFreeSurf.EQ.0)
153        when the previous code was not correct.
154      - in all cases diagnoze the boundary condition mismatch to SIaaflux
155      - in the case of useRealFreshWaterFlux.AND.(nonlinFreeSurf.GT.0) add
156        that term to QNET (essentially to set the melt/freeze water to 0degC).
157        when SEAICEheatConsFix is true, so that the ocean+ice budget heat is closed.
158    o verification/global_ocean.cs32x15/input.seaice :
159      - add SEAICEheatConsFix in data.seaice, ensuring closed ocean+ice heat budget.
160      - add diagnostics (commented out) for budget test using my matlab codes (gcmfaces).
161      - update results (output.seaice.txt) accordingly.
162    o verification/lab_sea/input/data.seaice :
163      - remove SEAICEheatConsFix, which is now be tested
164        in global_ocean.cs32x15. The presently coded fix
165        is only consistent with real fresh water + nlfs.
166      - update results (output.txt) accordingly.
167    o pkg/salt_plume: added diagnotic for salt tendency (oceSPtnd).
168    o AD_CONFIG.h file:
169      - in genmake2: remove "#undef ALLOW_ECCO_OPTIMIZATION" from AD_CONFIG.h;
170      - remove #include "AD_CONFIG.h" from all included OPTIONS files and
171        add it explicitly in each fortran src file where it is needed.
172        motivation: header file AD_CONFIG.h is generated/modified after "make depend"
173        thus introducing potentially wrong dependency; therefore, better to include
174        it only where it's really needed, and after any other included OPTIONS file
175        (less tempting to bring conditional includes according to ALLOW_ADJOINT_RUN
176        or ALLOW_TANGENTLINEAR_RUN).
177    
178    checkpoint63p (2012/07/06)
179    o pkg/autodiff:
180      - rename S/R INI_AUTODIFF to AUTODIFF_INIT_VARIA ;
181      - create new header file "AUTODIFF_PARAMS.h" for pkg/autodiff parameters
182        which are now read from new parameter file "data.autodiff" (inAdExact
183        previously in "data", use{KPP/GMRedi/SEAICE}inAdMode previously in data.pkg)
184      - add file "data.autodiff" in all verification/*/input_ad/ directories.
185      - add run-time parameter to turn On/Off SEAICEuseFREEDRIFT in adjoint/forward
186        mode (used in global_ocean.cs32x15.seaice_dynmix test exp.)
187    o verification/tutorial_tracer_adjsens/
188      - add extra sub-verification which uses "SOM" advection scheme
189        (2nd Order-Moment Advection Scheme, Prather Limiter) with
190          #define GAD_ALLOW_TS_SOM_ADV in GAD_OPTIONS.h
191        and in data:
192          multiDimAdvection=.TRUE.,
193          tempAdvScheme=81,
194          saltAdvScheme=81,
195    o model/src:
196      - introduce ALLOW_BALANCE_RELAX which allow the removal
197       of the global mean of relaxation terms by setting
198       balanceThetaClimRelax and balanceSaltClimRelax
199      - disable balanceEmPmR and balanceQnet in the case when useSeaice.
200       This case is now treated appropriately in seaice_growth.F
201    o pkg/seaice:
202      - do balanceEmPmR and balanceQnet based on the net fluxes
203        (SItflux) that enter the ocean+ice system rather than QNET
204        and EMPMR. Works best in real fresh water.
205      - SIatmFW, SIatmQnet, and SItflux computations had to be moved
206        out of the diagnotics bloc, and stored in global arrays.
207    
208    checkpoint63o (2012/06/29)
209    o vertical mixing schemes:
210      - remove unused S/R CALC_BUOYANCY (left from branch-atmos merging)
211      - replace computation of density (in Function STATE1, opps_calc.F) by a call
212        to S/R FIND_RHO_SCALAR
213      - pass sigmaR to S/R PP81_CALC, MY82_CALC (but not yet used) and to GGL90_CALC
214        and use it for N^2 calculation in ggl90_calc.F (save 2 density computations);
215        affects output (vermix.ggl90) at truncation level.
216    o testreport:
217      - change adjustment of SIZE.h for mpi+mth testing: preserve enough tiles
218        (nSx,nSy) for the number of threads (from eedata.mth)
219    o model/src:
220      - remove 2nd set of calls at the top of initialise_varia.F (Adjoint part)
221        related to Non_Lin Free-Surf or Bottom-Control (but not longer necessary).
222    o verification/tutorial_tracer_adjsens/
223      - compile with ALLOW_CG2D_NSA
224      - run with nonlinFreeSurf=3
225      - update reference output_adm.txt
226    o tools/genmake2:
227      - add "-DHAVE_NETCDF" to the DEFINES list when NetCDF is available ;
228        refine usePROFILES switching off (only when NetCDF is not available).
229    o verification (atmospheric set-up):
230      - change eosType='IDEALGAS' to eosType='IDEALG' to match variable declaration
231    o pkg/profiles : refine profiles and files handling.
232    o model/src and pkg/ecco : introduce run-time switch usePROFILES.
233    o model/src/the_main_loop.F, forward_step.F and pkg/exf/EXF_OPTIONS.h :
234      - changes to use model/src/the_main_loop.F rather than the ecco version
235        in ecco type adjoint runs.
236    o model/src:
237      - move computation of recip of grid distance & area from INI_MASKS_ETC to INI_GRID
238      - move setting of h0Fac[C,W,S] from INI_LINEAR_PHISURF to INI_MASKS_ETC
239      - update_masks_etc.F: rename SMOOTH*_R4,R8 function to the corresponding type (RS,RL)
240    o model/src:
241      - fix S/R UPDATE_CG2D for ALLOW_DEPTH_CONTROL case (was empty before);
242        update output of test experiment bottom_ctrl_5x5.
243    o pkg/generic_advdiff:
244      - implement vertical bi-harmonic diffusion (for now, only for T & S and
245        only explicitly).
246    o verification/bottom_ctrl_5x5/
247      update reference output (results changed quite some time ago,
248      not sure when; but new reference results look ok in terms of grdchk)
249    o verification/1D_ocean_ice_column/
250      For verification purposes, the exact adjoint rather than an approx.
251      should be used (e.g., to comare against F.D. or TLM).
252      removed autodiff_inadmode*_ad.F routines in code_ad/
253      Update results/ accordingly.
254    o pkg/cal:
255      - change cal_getdate.F so that output date is function of input time only
256        (less ambiguous, not mixed up with input iteration number).
257      - fix calendarDumps for non-zero phase-lag (S/R CAL_TIME2DUMP).
258    o pkg/diagnostics:
259      - implement calendarDumps also for stats-diags
260      - implement calendarDumps also for snap-shot output (negative freq)
261      - for now, ignores calendarDumps if non-zero phase-lag.
262    
263    checkpoint63n (2012/06/04)
264    o model/src:
265      - recompute rSurfW & S to ensure consistent column thickness (needed for rStar)
266        between Sum_k(hFac*drF) and rSurf-rLow, for now only when using pkg/shelfice;
267      - use h0FacC, W & S to compute hFac_surfC, W & S in calc_surf_dr.F (more
268        similar to calc_r_star.F); update results of experiment internal_wave and
269        tutorial_global_oce_in_p (affected @ truncation level).
270    o pkg/shelfice:
271      - add parameterisation of advective-diffusive flux into the ice shelf
272        according to Holland and Jenkins (1999), eq.22-33, as suggested by Jan De Ryd
273      - simply eps3/3a computation
274    o eesupp:
275     - add new CPP option (DISCONNECTED_TILES) to disconnect tiles (no exchange
276       between tiles, just fill-in edges assuming locally periodic subdomain) and
277       add corresponding exchange subroutines (EXCH0);
278     - new CG-solver version (_EX0) for disconnected-tiles special case.
279    o model/src (CG-solvers):
280     - modify Single-Reduction version (CG2D_SR) in case cg2dMaxIters is reached
281       (similar final residual output and max-Iter number as with standard version);
282     - allows to store and use lowest-residual solution (standard & _SR versions);
283     - cleaning up (remove old, commented out code, LETS_MAKE_JAM ...).
284     - by default, also compile CG2D_SR version (define ALLOW_SRCG in CPP_OPTIONS.h)
285    o eesup/src:
286     - global_vec_sum.F cleaning: add a BARRIER ; update comments ; remove ndef
287       ALWAYS_USE_MPI (no longer needed after fixing usingMPI settings - March 2012)
288    o pkg/salt_plume added to lab_sea/input_ad.noseaicedyn
289    
290    checkpoint63m (2012/04/27)
291    o pkg/shelfice:
292     - account for partical cells in surface level below ice-shelf for hydrostatic
293       pressure calculion (set uniformFreeSurfLev to F); update isomip experiments.
294    o ad test experiments:
295     - update and rename to "ad_optfile.local" local AD-optfile specific to a
296       particular adjoint verification experiment (in verification/*/code_ad/)
297    o pkg/seaice & pkg/exf:
298     - Part two of ECCO-CLIVAR code merges.
299       Completes merge of seaice area relax. code.
300       Requires unified CPP option EXF_ALLOW_SEAICE_RELAX
301       to be set in EXF_OPTIONS.h since this pkg controls its I/O
302       (and avoids second CPP option in SEAICE_OPTIONS.h)
303     - change default value of costIceStart & costIceEnd to a valid date.
304     - add snowPrecip to HSNOW in seaice_growth
305    o pkg/ptracers:
306     - move ptracers summary and setup check into separated S/R ; add a check for
307       valid PTRACERS_Iter0 value (error+stop or just warning).
308    o pkg/cal (+ pkg/ecco):
309     - avoid calling a S/R with 2 times the same arg (FWD: unless both are only used
310       as input; and for AD, unless both are not differentiable (e.g., k index)).
311    o model/src:
312     - define internal flag "uniformFreeSurfLev" (=T when free-surface level-index
313       is everywhere k=1) to speed-up some calculations (by pass kSurf reference);
314       temporary set to usingZCoords value (to be changed to F when using shelfice).
315     - hydrostatic pressure: implement partial cell near the surface also for
316       Z-coordinates (for the case where uniformFreeSurfLev=F); replace test on
317       usingZCoords with test on uniformFreeSurfLev where needed (in NonHyd code).
318    o pkg/ctrl/ctrl_init.F:
319     - add a formal parameter to s/r ctrl_init_rec to print
320       xx_$(ctrl_valiable)_file for easier debugging
321     - move call of cal_* routines into the if-block where they are really
322       needed so that xx_$(ctrl_variable)_period can be 0 or -12 without having
323       to specify a startdate
324    o pkg/seaice:
325     - update comments in SEAICE_OPTIONS.h (+ similar update of lab_sea/code and
326       global_ocean.cs32x15/code versions).
327     - turn on seaice Multi-category (in data.seaice, SEAICE_multDim=7) for
328       verification experiment global_ocean.cs32x15.seaice and update results.
329    o pkg/exf:
330     - new S/R EXF_GETFIELD_START to return starting-time of a forcing field
331       (according to useExfYearlyFields).
332    o pkg/cal:
333     - move calendar setting & summary (previously in cal_readparams.F) into new
334       S/R CAL_INIT_FIXED to be called later in the initialisation process, once
335       length of the simulation is set (after SET_PARMS call); This is an attempt
336       to fix Pb when, e.g.: pkg/longstep, modifies the length of the run.
337     - For safety: keep a record of pkg/cal parameter settings status
338               to allow to STOP if one pkg/cal S/R is called too early.
339     - add a stop in all basic pkg/cal subroutines if called before setting is done.
340     - modify cal_getdate.F: stop when nothing was returned;
341       if called with myIter=-1, simply retrun modelBaseDate (1,2 = startDate_1,_2);
342       this allows to remove "cal.h" from seaice_read_parms.F & init_mnc_vars.F.
343    
344    checkpoint63l (2012/04/04)
345    o pkg/bbl:
346      - fix call to FIND_RHO_2D in bbl_calc_rho.F (case multi-tiles per proc);
347        update global_with_exf output.yearly.txt file.
348    o pkg/cal:
349      - start to clean-up cal_set.F ; fix for the case where baseTime is non-zero.
350      - remove 2 unsused and very short (1 line only) functions ;
351      - remove unsused subroutines from AD-Diff list.
352    o model/src:
353      - start to implement clean wait to stop in initialization S/R (config_check.F,
354         packages_check.F, ini_parms.F and pkg/obcs/obcs_check.F + pkg/mypackage)
355    o folowing PRINT_MESSAGE changes:
356      - remove reminder multiple print to the same file (STDOUT) when multi-threads.
357    o pkg/bbl:
358      - modification so it can work with z*
359      - replace deltaT with dTtracerLev(k) for asynchronous time stepping
360      - global_with_exf/input.yearly verification; changes output.yearly.txt
361    o eesupp/src:
362      - PRINT_MESSAGE: use OpenMP critical instruction (similar to PRINT_ERROR);
363        writing to unit 0 (if unit=errorMessageUnit) extended to the case myThid=1
364      - CHECK_THREADS: specific code if using OpenMP threading: improve checking of
365        # of threads across processors (e.g., different env OMP_NUM_THREADS setting)
366      - improve special preliminary call to EESET_PARMS (if eedata is read 2 times).
367      - when using MPI, always set usingMPI=T ; set default accordingly and stop
368        if not consistent.
369      - ALL_PROC_DIE: add a BARRIER after MPI_FINALIZE call ; skip this when thread
370        argument is zero (in case called within single-thread section).
371    o pkg/fizhi:
372        clean-up turbulence cold-start switch: decided in fizhi_init_vars.F, stored
373        in common bloc (fizhi_coms.h) and then passed as argument up to S/R TURBIO.
374    o pkg/exch2:
375      - add argument "updateCorners" to S/R exch2_get_uv_bounds (enable to
376        activate EXCH_IGNORE_CORNERS in vector EXCH S/R).
377      - switch 1rst EXCH call to IGNORE_CORNERS (instead of UPDATE_CORNERS)
378        but keep the 2nd with UPDATE_CORNERS: this prevents overwriting good data
379        with bad ones coming from a not-yet-updated halo.
380        This should fix the problem when sNx <> sNy and GCD(sNx,sNy) < 2*Olx.
381    o pkg/frazil:
382        move FrzForcT diag from frazil_diagnostics_state.F to frazil_calc_rhs.F
383        http://mitgcm.org/pipermail/mitgcm-devel/2012-March/005384.html
384    o model/src/config_check.F: add a check for OLx>sNx/OLy>sNy
385    o verification/lab_sea
386      * #undef SEAICE_EXCLUDE_FOR_EXACT_AD_TESTING
387      * #define ALLOW_SST_CONTROL & ALLOW_SST_CONTROL
388      * nTimeSteps 3 -> 4
389      * changed reference output accordingly
390    o pkg/ctrl:
391      * fix ctrl_get_gen for xx_sst, xx_sss
392    o pkg/fizhi:
393      - fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F
394        update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d)
395      - by default, use new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE);
396        fix few out-of-bounds indices in referencing vars (initialise igrd to 1);
397        clean-up fizhi_turb.F (remove unused & uninitialised qdiaglsm array).
398    o pkg/gmredi:
399      - add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp
400    o pkg/fizhi:
401      - fix few initialisation and multi-tile Pb: aqualev & gridalt now pass the
402        (old)aces open64 tuv test.
403    o pkg/icefront: fix bug and reorder loop in icefront_init_varia.F
404    o pkg/mom_vecinv:
405      - fix 1 loop range in mom_vecinv.F to be like all the other loops which
406        set/update gu,gv/Diss (fix Pb of uninitialised fVerUkp in admom_vecinv
407        with non-lin free-surf).
408    o model/src: move k-loop outside of i/j-loops when (re-)computing R_low
409      in ini/update_masks_etc.F in order to avoid -O3 optimization problems with
410      some compilers (gfortran 4.6.0 on MacOS)
411    o momentum:
412      - separate fVer?(:,:,kUp) & fVer?(:,:,kDown) in argument list of MOM_FLUXFORM
413        & MOM_VECINV subroutines (to help TAF). This fixes Pb of uninitialised
414        fVer?(kUp) in admom_fluxform with non-lin free-surf or bottom control.
415    
416    checkpoint63k (2012/03/17)
417    o model/src:
418       - selectAddFluid (ALLOW_ADDFLUID): add missing term in horizontal momentum
419         flux-form (mom_fluxform.F) and vertical momentum (calc_gw.F) equations.
420       - SOLVE_DIAGONAL: switch default to use adjoinable & vectorized version
421         (#undef SOLVE_DIAGONAL_LOWMEMORY); update output of exp. front_relax.bvp.
422    o model/src: solve_*diagonal.F
423       - replace division with multiplication by inverse (similar to original version)
424         update output of AD exp. global_ocean.90x40x15.
425       - fix pkg/gmredi/gmredi_calc_psi_bvp.F & pkg/ggl90/ggl90_calc.F
426         to enable the use of the vectorized & differentiable solve_tridiagonal.F
427       - test exp. global_ocean.90x40x15/input_ad: switch to advection scheme 20 for
428         vertical advection (to get solve_tridiagonal tested in AD mode).
429    o pkg/seaice: ECCO-CLIVAR merge:
430      1. seaice AREA relaxation
431         * CPP option: SEAICE_ALLOW_AREA_RELAXATION
432         * runtime flag: SEAICE_tauAreaObsRelax
433      2. modified global mean cost imbalance code: CPP option
434          ALLOW_SSH_GLOBMEAN_COST_CONTRIBUTION
435    o another iteration on solve_*diagonal.F
436       Make choices independent of AUTODIFF
437       Default will be the adjoinable vectorized version.
438       Alternative choices are:
439       * non-adjoinable original version with low memory footprint:
440         #define SOLVE_DIAGONAL_LOWMEMORY
441       * still adjoinable but does not vectorize (k as inner-most loop):
442         #define SOLVE_DIAGONAL_KINNER (keeping SOLVE_DIAGONAL_LOWMEMORY undef)
443    o testreport
444     - add option to use a home made wrapper around "make"
445     - remove MITGCM_IEEE env. variable (no longer active)
446    o pkg/shelfice
447     - improve computation of friction velocity for velocity dependent
448       exchange coefficients: include velocities into SHELFICEBoundaryLayer
449       block to average velocities vertically
450     - add TAF store directives for SHI_ALLOW_GAMMAFRICT
451    o Modify diagonal solvers, now three versions (upon request):
452      #ifndef SOLVE_DIAGONAL_AUTODIFF
453        1. default version (dating back a while ago)
454      #else /* def SOLVE_DIAGONAL_AUTODIFF */
455      # ifdef SOLVE_DIAGONAL_KINNER
456        2. adjoinable version with k-innermost loop (G. Forget)
457      # else
458        3. adjoinable vectorized version of 2.
459      # endif
460      #endif /* SOLVE_DIAGONAL_AUTODIFF */
461      All flags are currently set within routines, but could/should be moved to CPP-options.
462      Array bounds for 1. are as before, for 2.,3. cover the entire domain
463      (could be changed for 1. too).
464    o verification/lab_sea (fwd):
465      - update the 4 fwd lab_sea test experiment: no longer SEAICE_GROWTH_LEGACY,
466        use 7 categories (except hb87), new solve4temp params (except salt_plume),
467        constant salinity (=4) or variable salinity (salt_plume) done through
468        SItracer.
469    o pkg/seaice:
470      - rename parameters: SIsalFrac to SEAICE_saltFrac & SIsal0 to SEAICE_salt0;
471      - remove old parameters ( SEAICE_freeze, SEAICEturbFluxFormula, SEAICE_gamma_t,
472         SEAICE_gamma_t_frz, SEAICE_availHeatTaper & SEAICE_availHeatFracFrz)
473        from SEAICE_PARMS.h ; still need to fix seaice_cost_sst.F (broken when
474        SEAICE_freeze got retired) but already better than previously with
475        SEAICE_freeze=123456.7 deg.C;
476      - move setting of facOpenGrow/Melt from SEAICE_INIT_FIXED to SEAICE_READPARMS
477        (safer multi-threaded setting); always set SEAICEuseEVP;
478      - setting of ocean-ice turb. flux coeff: moved from SEAICE_CHECK to
479        SEAICE_READPARMS & SEAICE_INIT_FIXED (this fixes wrong summary report);
480        stop if multiple specifications for the same coeff; make sure default
481        SEAICE_mcPheePiston is compatible with drF(1) & deltaT.
482    o pkg/obcs:
483      - allow to switch to upwind 1rst order advection scheme for the advective
484        flux computation at the open-boundary; disabled for adjoint built.
485    o pkg/ptracers:
486      - rename PTRACERS_RESTART.h -> PTRACERS_START.h
487      - rename ptracers_fields_blocking_exchanges.F -> ptracers_fields_blocking_exch.F
488      - add parameter to decide when to start a tracer; use internal flag to
489        know which tracer to step-forward; switch this internal flag at the top
490        of forward_step.F (new S/R PTRACERS_SWITCH_ONOFF); for now, not enabled
491        for adjoint built.
492    o pkg/seaice:
493      - add SEAICE_SIZE.h anywhere in the code where SEAICE.h is included ;
494      - move MULTDIM declaration and setting from SEAICE.h to SEAICE_SIZE.h ;
495      - keep experiment offline_exf_seaice truly single category (set MULTDIM=1).
496    o pkg/ecco:
497      - fix writing of output file DiagnosCost_ClimSalt/Theta
498        and DiagnosCost_DriftSalt/Theta (if multi-tiles per proc).
499    o pkg/seaice:
500      - add missing initialisation of COR_ICE array in dynsolver.F
501      - merging SEAICE_MULTICATEGORY define and undef cases. Now the same code is
502        compiled either way, and is tested in all exps (multidim was only tested
503        in lab_sea ad before).
504      - cosmetic change to prepare for future addition of ITD. no change to results.
505        no defaults change.
506      - added run time param SEAICE_multDim (7 for SEAICE_MULTICATEGORY, 1 otherwise).
507      - by lack of adequate verification experiments, I further used custom versions
508        of global_ocean.cs32x15 to test multicat or not, with pickup or not. All
509        should be correct.
510      - avoid recomputations in ad.
511    o array initialisation in adjoint mode:
512      1) pkg/mom_common/mom_calc_ke.F:
513        add full array initialisation of KE inside mom_calc_ke.F (ALLOW_AUTODIFF_TAMC):
514        The S/R which calls MOM_CALC_KE initialises KE but in some recomputation
515        part this initialisation is gone, resulting in Floating Point Exception
516        (caught by open64 compiler with debug option).
517      2) model/src/convective_weights.F
518        set output convectCount over the full array range (instead of doing
519        an update): this fix a similar issue when called within recomputation (adjoint)
520        which could by-pass the initialisation (normally done in the caller S/R).
521    o pkg/seaice:
522      - final version of turbulent flux params, as agreed at MIT ice meet:
523           SEAICE_mcPheePiston (default is ~ 0.000875)
524           SEAICE_mcPheeTaper (default is 0.)
525           SEAICE_frazilFrac (defualt is 1.)
526           SEAICE_mcPheeStepFunc (default is false)
527      - changes results at trunction error level
528      - ifdef SEAICE_EXTERNAL_FLUXES, disallow SEAICE_waterAlbedo
529    o added pkg/frazil:
530      - see frazil_description.tex for details
531      - verification experiment is global_with_exf/input.yearly; changes output.yearly.txt
532    o pkg/shelfice/shelfice_thermodynamics.F
533      - fix exponents for velocity dependent exchange coefficients: change
534        from 2/3(=0) to 0.66666666666666667
535      - move computation of velocity dependent exchange coefficients into
536        separate loop, so that it applies to both thermodynamics
537      - move some divisions by constants out of loops
538    
539    checkpoint63j (2012/02/16)
540    o pkg/seaice:
541      - overhaul of seaice_summary.F after feb 2012 clean-up of seaice_growth.F etc.
542      - SItracer:  added run time params, and allow coupling to ocn salinity.
543    o pkg/seaice: remove (almost) all divisions by constants within loops
544      in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d
545      results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only
546      those, caused by 1/QI -> recip_QI) -> update output.seaice.txt,
547      output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt
548    o pkg/seaice :
549      - simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula
550        = 1 or 2, using newly added run time parameter SEAICE_availHeatTaper.
551    - fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148.    - fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148.
552    - add permanent SItflux diag that corresponds to TFLUX but includes    - add permanent SItflux diag that corresponds to TFLUX but includes
553    ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget.      ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget.
554    - allow activation/testing of a fix for suspected missing term in    - allow activation/testing of a fix for suspected missing term in
555    ocn-ice heat budget (to be confirmed). To test this, you want to      ocn-ice heat budget (to be confirmed). To test this, you want to
556    undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param      undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param
557    SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic.      SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic.
558    - no change in results, fwd or ad.    - no change in results, fwd or ad.
559  o global_ocean.cs32x15/results: three changes following from the pkg/seaice commit below.  o global_ocean.cs32x15/results: 3 changes following from the pkg/seaice commit below:
560    - switch to variable freezing point.    - switch to variable freezing point.
561         Results change : cg2d -> 1 digits; ad -> 3-6-6 digits.         Results change : cg2d -> 1 digits; ad -> 3-6-6 digits.
562    - bug fix : the sublimation term that was missing is now activated.    - bug fix : the sublimation term that was missing is now activated.
563         Results change : cg2d -> 2 digits; ad -> 8-6-6 digits.         Results change : cg2d -> 2 digits; ad -> 8-6-6 digits.
564    - bug fix : flooding sign term for SIsal0.NE.0.    - bug fix : flooding sign term for SIsal0.NE.0.
565         Result change : cg2d -> 8 digits; ad -> 11-12-9 digits.         Result change : cg2d -> 8 digits; ad -> 11-12-9 digits.
566  o pkg/seaice:  o pkg/seaice:
567    - unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT    - unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT
568   is now the default, and the old default constant freezing point is recovered with      is now the default, and the old default constant freezing point is recovered
569   SEAICE_tempFrz0    = -1.96,      with SEAICE_tempFrz0    = -1.96,
570   SEAICE_dTempFrz_dS = 0.,           SEAICE_dTempFrz_dS = 0.,
571    - retire SEAICE_freeze that was the old way of specifycing the constant freezing point.    - retire SEAICE_freeze (= the old way of specifycing the constant freezing point)
572    - remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there.    - remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there.
573    - bug fix (thanks to M. Losch) : the sublimation term that was missing is now    - bug fix (thanks to M. Losch) : the sublimation term that was missing is now
574   activated. To reproduce old results that had this bug define SEAICE_DISABLE_SUBLIM.      activated. To reproduce old results with this bug define SEAICE_DISABLE_SUBLIM.
575    - bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211)    - bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211)
576   was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail).      was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail).
577    - bug fix (thanks to O. Jahn) : area loss for melting  got messed up in    - bug fix (thanks to O. Jahn) : area loss for melting  got messed up in
578   seaice_growth r149 for legacy branch (no results change).      seaice_growth r149 for legacy branch (no results change).
579    - introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code from I. Fenty).    - introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code
580    - results did not change except for global_ocean.cs32x15, mostly due to the switch      from I. Fenty).
581    to variable freezing point (see above item for detail).    - results did not change except for global_ocean.cs32x15, mostly due to the
582        switch to variable freezing point (see above item for detail).
583  o pkg/thsice:  o pkg/thsice:
584    - fix and simplify interface to salt_plume pkg ; diagnose directly amount of    - fix and simplify interface to salt_plume pkg ; diagnose directly amount of
585      seawater freezing in thsice_calc_thickn (not used).      seawater freezing in thsice_calc_thickn (not used).
586  o pkg/seaice: turbulent flux term specification via run time params.  o pkg/seaice: turbulent flux term specification via run time params.
587    - replace CPP switches with run time switches to facilitate testing    - replace CPP switches with run time switches to facilitate testing
588    - retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR    - retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX,
589                       GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR
590    - added runtime parameter : SEAICEturbFluxFormula    - added runtime parameter : SEAICEturbFluxFormula
591    - move Mcphee constants to SEAICE_PARAMS.h    - move Mcphee constants to SEAICE_PARAMS.h
592    - seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula;    - seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula;
593      SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); remove               SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply);
594      seaice_summary call (moved to seaice_init_fixed)               remove seaice_summary call (moved to seaice_init_fixed)
595    - seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on    - seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on
596      SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms)      SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms)
597    - seaice_summary.F : add missing report of read turbulent flux term set up (and SITRACER).    - seaice_summary.F : add missing report of read turbulent flux term set up
598    - seaice_check.F : check range; inform and stop if retired CPPs are used (incl. SEAICE_AGE).                         and SITRACER.
599      - seaice_check.F : check range; inform and stop if retired CPPs are used
600                         (incl. SEAICE_AGE).
601    - seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without    - seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without
602          CPP switch, same computation as before for the different options.           CPP switch, same computation as before for the different options.
603    - change results at the truncation level.    - change results at the truncation level.
604  o pkg/seaice:  o pkg/seaice:
605    - remove un-used parameters LAD & MAX_TICE ; add new run-time parameters:    - remove un-used parameters LAD & MAX_TICE ; add new run-time parameters:

Legend:
Removed from v.1.1596  
changed lines
  Added in v.1.1712

  ViewVC Help
Powered by ViewVC 1.1.22