| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o exp4 test-exp: |
| 8 |
|
- add secondary set-up (.nlfs) using NonLin FreeSurf (z*) + mom_vecinv |
| 9 |
|
and biharmonic-viscosity ; prescribe time varying OB but without pkg/exf. |
| 10 |
|
o pkg/obcs: |
| 11 |
|
fix bug in OBWeta,OBWeta indices in obcs_apply_r_star.F |
| 12 |
|
o model/src: |
| 13 |
|
- fix startTime setting when baseTime<>0 & nIter0=0 are specified ; |
| 14 |
|
- initialise startTime & nIter0 with unlikely values: allows to set one |
| 15 |
|
from the other without ambiguity. |
| 16 |
|
o seaice_obcs test-exp.: |
| 17 |
|
add small diffK4T,S to test biharmonic diffusivity with OBCS ; update output. |
| 18 |
|
o pkg/obcs: |
| 19 |
|
- remove calls to OBCS_COPY_TRACER after EXCH for T,S & pTracer: |
| 20 |
|
no longer needed with maskInC,W,S in pkg/generic_advdiff. |
| 21 |
|
o pkg/seaice: |
| 22 |
|
- retired SEAICE_SALINITY and SEAICE_salinity in favor of |
| 23 |
|
SEAICE_VARIABLE_SALINITY and SIsalFRAC, respectively. |
| 24 |
|
- fixed bug in the initialization of sea ice salinity variable HSALT |
| 25 |
|
in seaice_init_varia.F (removed dependence on ICE2WATR) |
| 26 |
|
o fizhi-cs test exp.: |
| 27 |
|
switch reference output convention for these 2 non-standard test-exp, |
| 28 |
|
from: pgi 6.1-5 on faulks (FC.6, -of linux_ia32_pgf77+authors_fc5) |
| 29 |
|
to: ifort 11.1 on baudelaire (FC.13, -of linux_amd64_ifort11) |
| 30 |
|
reason: faulks might get retired soon and pkg/fizhi has still Pb with gfortran |
| 31 |
|
o model/inc: |
| 32 |
|
- change type of PmEpR array (from _RS to _RL) to fix restart (with "-use_r4") |
| 33 |
|
of exp. global_ocean.90x40x15 (Suncronous time-stepping + Real-FW + NonLin-FS) |
| 34 |
|
o pkg/seaice: |
| 35 |
|
- fix calculation of saltFlux and saltPlumeFlux when using SEAICE_SALINITY |
| 36 |
|
o verification/lab_sea, 1D_ocean_ice_column, seaice_obcs, global_ocean.cs32x15 |
| 37 |
|
- updated output*.txt files due to bug fixes in salt, saltPlumeFlux, |
| 38 |
|
and initial HSALT |
| 39 |
|
|
| 40 |
|
checkpoint62w (2011/04/26) |
| 41 |
|
o pkg/mom_fluxform: |
| 42 |
|
- fix calculation of del2u & del2v (no-slip BC) when using Non-Lin Free-Surf. |
| 43 |
|
- use parameter "sideDragFactor" in no-slip BC side-drag part. |
| 44 |
|
- update output of exp. global_ocean.90x40x15 |
| 45 |
|
o pkg/mom_vecinv: |
| 46 |
|
mask del2u & del2v (no effect on results, but cleaner & closer to mom_fluxform) |
| 47 |
|
o update seaice exp.: |
| 48 |
|
use more consistent parameter values (remove "backward compatability only": |
| 49 |
|
ICE2WATR, SEAICE_lhSublim, SEAICE_cpAir, SEAICE_rhoAir + set rhoConstFresh) |
| 50 |
|
related to thermodynamics seaice. Update output (fwd+AD) of exp.: |
| 51 |
|
1D_ocean_ice_column (x2), lab_sea (x8), ioffline_exf_seaice (x2) & seaice_obcs |
| 52 |
|
o update test-exp global_ocean.90x40x15: |
| 53 |
|
o use default CD_CODE_OPTIONS file (Adams-Bashforth on CD Mom & Coriolis). |
| 54 |
|
o increase Overlap size from 2 to 3 (to allow to test bi-harmonic Visc.) |
| 55 |
|
o new pickup-files from a 100.yr run with pkg/down_slope (input.dwnslp params) |
| 56 |
|
o turn on zStar & viscA4 in standard set-up (dir input/) |
| 57 |
|
and update output files: output.txt & output.dwnslp.txt |
| 58 |
|
o new AD-test experiment: obcs_ctrl |
| 59 |
|
(From Matt MITgcm_Contrib/SOSE/BoxAdj) to test OBCS as control vector. |
| 60 |
|
o pkg/dic: |
| 61 |
|
fix two bugs in handling water vapour pressure in carbonate chemistry |
| 62 |
|
and air-sea fluxes. Found by Val Bennington and Galen McKinley |
| 63 |
|
(add DIC Option = WATERVAP_BUG to recover old results) |
| 64 |
|
update output of tutorial_global_oce_biogeo (fwd+AD) & tutorial_dic_adjoffline |
| 65 |
|
o adding allowInteriorFreezing option to check for water below freezing point |
| 66 |
|
at depth and bring the negative heat anomaly to the surface level |
| 67 |
|
o pkgs _fields_load: |
| 68 |
|
- extend GET_PERIODIC_INTERVAL to deal with non-periodic case (from pkg/rbcs) |
| 69 |
|
- use new S/R GET_PERIODIC_INTERVAL in pkgs: |
| 70 |
|
bulk_force, cheapaml, cfc, dic, obcs (+ ctrl/ctrl_get_gen_rec), offline and |
| 71 |
|
rbcs to get interpolation weights and time reccord number. |
| 72 |
|
- fix multi-threading in aim_fields_load.F |
| 73 |
|
- apply EXCH to temp arrays [0,1] after reading in dic_fields_load.F |
| 74 |
|
o external_fields_load: |
| 75 |
|
new S/R GET_PERIODIC_INTERVAL to calculate which time-record (and linear |
| 76 |
|
interpolation weights) to use in a periodic time-series ; do not divide by |
| 77 |
|
time-step to convert to integer: |
| 78 |
|
- this fixes case where externForcingPeriod is not multiple of time-step |
| 79 |
|
(Thanks to Christopher L. Wolfe) |
| 80 |
|
- this fixes case where externForcingPeriod is an odd multiple of time-step |
| 81 |
|
(was wrong by half of time-step); update results of tutorial_global_oce_in_p. |
| 82 |
|
store index of time-record which is currently loaded: |
| 83 |
|
- works without any assumption on sequence of calls to EXTERNAL_FIELDS_LOAD ; |
| 84 |
|
- needed for the adjoint but not yet used because of extensive recomputations; |
| 85 |
|
(to be fixed soon) |
| 86 |
|
|
| 87 |
|
checkpoint62v (2011/04/02) |
| 88 |
|
o verification/1D_ocean_ice_column added to test Ian Fenty's |
| 89 |
|
pkg/seaice_growth.F modifications for improving sea ice code differentiability |
| 90 |
|
o update output of exp4, internal_wave, seaice_obcs, tutorial_plume_on_slope |
| 91 |
|
(new velocity statistics after changing maskInW & maskInS definition) |
| 92 |
|
o pkg/generic_advdiff with OBCS: |
| 93 |
|
use maksInW & maskInS in advective flux and in biharmonic diffusion calculation: |
| 94 |
|
equivalent to assumption of no tracer gradient outside the OB region. |
| 95 |
|
This will affect the results if using obcs+biharmonic diffusion. |
| 96 |
|
update output_adm.txt of experiment bottom_ctrl_5x5 (not expected since no obc) |
| 97 |
|
o pkg/obcs: |
| 98 |
|
change definition of maskInW & maskInS: leave OB edges inside (maskIn=1) |
| 99 |
|
(e.g., maskInW(OB_Ie)=1 ) so that velocity normal-component at OB is still |
| 100 |
|
in Interior region. No impact on solution but affects Velocity monitor stats. |
| 101 |
|
o pkg/ptracers (adjoint) |
| 102 |
|
New option AUTODIFF_PTRACERS_SPLIT_FILES for writing separate |
| 103 |
|
tape file for each tracer |
| 104 |
|
o model/inc/src and pkg/autodiff: add parameters that allow to turn |
| 105 |
|
of parts of the adjoint code at run time. For now, there are only |
| 106 |
|
useKPPinAdMode, useGMrediInAdMode, and useSEAICEinAdMode. These |
| 107 |
|
parameters are set in data.pkg. |
| 108 |
|
This is the lazy coward's version of doing this, but still useful for |
| 109 |
|
debugging. In order to do it right, everything needs to be moved to |
| 110 |
|
pkg/autodiff. |
| 111 |
|
o pkg/autodiff: fix global_sum_tile_ad.F by resetting adsumPhi at |
| 112 |
|
the end; this fixes the adjoint balancing code for open boundaries. |
| 113 |
|
o pkg/ctrl: |
| 114 |
|
- change behavior of xx_${varname}period to be analogous to exf-conventions: |
| 115 |
|
xx_${varname}period = 0., means time-independent control part |
| 116 |
|
xx_${varname}period = -12., means one-year-periodic monthly control part |
| 117 |
|
- introduce helper routine ctrl_init_rec (part of ctrl_init.F) to |
| 118 |
|
clean up ctrl_init a little, remove unused variables |
| 119 |
|
- ctrl_init: fixed the handling of the start/endrec for obcs-variables |
| 120 |
|
- move "call cal_GetMonthsRec" from s/r ctrl_get_gen to s/r ctrl_get_gen_rec |
| 121 |
|
|
| 122 |
|
checkpoint62u (2011/03/15) |
| 123 |
|
o model/src: |
| 124 |
|
- for the adjoint, change NonLin-FreeSurf initialisation sequence: fill-in |
| 125 |
|
h0Fac from INITIALISE_FIXED and reset hFac to h0Fac in INITIALISE_VARIA ; |
| 126 |
|
- in initialise_varia.F (except for ALLOW_DEPTH_CONTROL) remove 2nd call to |
| 127 |
|
INI_DEPTHS, INI_MASKS_ETC & INI_LINEAR_PHISURF. |
| 128 |
|
o pkg/ctrl/obcs/ecco: |
| 129 |
|
- remove obsolete, unused, and partially broken code: |
| 130 |
|
ctrl_obcsvol/ctrl_obcsbal/ctrl_volflux and code within |
| 131 |
|
ALLOW_CTRL_OBCS_BALANCE |
| 132 |
|
- put a stop statement into ecco/cost_obcsvol.F, but also add |
| 133 |
|
cost_obcsvol to ecco_ad_diff.list |
| 134 |
|
o pkg/ecco: fix counting cost function contributions for obcs (code |
| 135 |
|
by Matt M.) and diffkr for diagnostics |
| 136 |
|
o pkg/ecco, pkg/ctrl, pkg/grdchk: |
| 137 |
|
add cost penalty terms for initial uvel, vvel, eta controls |
| 138 |
|
and I/O for prior error files |
| 139 |
|
o pkg/mdsio: |
| 140 |
|
move mds_check4file.F from eesupp/src to mdsio_check4file.F ; add option |
| 141 |
|
(new argument) to check for tiled file in mdsioLocalDir : this fix the |
| 142 |
|
restart from pickup_som , pickup_dic (& dic_co2atm) with mdsioLocalDir. |
| 143 |
|
o pkg/ctrl: |
| 144 |
|
- ctrl_obcsbal.F, ctrl_obcsvol.F: replace last calls of ctrl_getrec by |
| 145 |
|
ctrl_get_gen_rec, put a stop statement into ctrl_getrec. Remove |
| 146 |
|
unused and superfluous variables |
| 147 |
|
- ctrl_get_gen_rec.F: catch the case of xx_genperiod=0. |
| 148 |
|
o pkg/ecco |
| 149 |
|
- enable adjoint of Stevens OB |
| 150 |
|
o pkg/ctrl/ecco/grdchk: |
| 151 |
|
- remove global declaration of tmpfldx/yz and tmpfldx/yz2. |
| 152 |
|
Fortunately, we do not have any tests for the numerous cpp-flagged |
| 153 |
|
option of "obcs as control parameters" so we will never know |
| 154 |
|
if this is an improvement (but at least now things compile). |
| 155 |
|
- remove an obsolete initialization from ecco_cost_init_barfiles.F |
| 156 |
|
- fix some problems within never used ifdefs to make the code compile |
| 157 |
|
o pkg/obcs: |
| 158 |
|
- Refine Interior mask definition to work with more complex OB (e.g. |
| 159 |
|
if OB_Ie < OB_Iw); In case default setting is not sufficient, allows to |
| 160 |
|
read in Interior mask from file. Check if Interior mask is consistent |
| 161 |
|
with OB list of indices. |
| 162 |
|
o pkg/seaice |
| 163 |
|
- beginning code for a seaice tracer package, |
| 164 |
|
but currently only used for seaice age: SEAICE_AGE |
| 165 |
|
SEAICE_num = 4 |
| 166 |
|
iTracer = 1: area-weighted ice age |
| 167 |
|
= 2: volume-weighted ice age |
| 168 |
|
= 3, 4: template for one-year vs. multi-year ice |
| 169 |
|
data.seaice has new namelist SEAICE_PARM03 for arrays related to |
| 170 |
|
SEAICE_num |
| 171 |
|
|
| 172 |
|
checkpoint62t (2011/03/05) |
| 173 |
|
o pkg/obcs: |
| 174 |
|
- obcs_apply_uv.F: change to a 2 steps method, first tangential component; |
| 175 |
|
then normal component. This ensures that the normal component is set |
| 176 |
|
correctly even when it conficts with tangential setting from an other OB. |
| 177 |
|
Affects results of test-experiment seaice_obcs: update the output.txt |
| 178 |
|
o pkg/obcs: |
| 179 |
|
- add code to monitor statistics of dynamical fields at OB. |
| 180 |
|
- take OBCS_BALANCE code out of obcs_calc.F into new S/R OBCS_BALANCE_FLOW : |
| 181 |
|
- fix to OBCS_BALANCE code (right hFac ; deal with simple OB intersection). |
| 182 |
|
- change default: balance the Net inflow through all OB (instead of balancing |
| 183 |
|
each OB separately); keep the old method if setting OBC_balanceFacX < 0. |
| 184 |
|
- switch on useOBCSbalance in dome experiment: only correct Western OB outflow |
| 185 |
|
to match Nortern OB inflow (OBCS_balanceFacN=0). |
| 186 |
|
o pkg/seaice: |
| 187 |
|
- redefined actual sea ice age to be ICEAGE/HEFF ifdef SEAICE_AGE_VOL |
| 188 |
|
o pkg/seaice (seaice_growth v 1.113): |
| 189 |
|
- reverting seaice_growth to v 1.111 in order to have code with exact bit |
| 190 |
|
compatibility with MITgcm_contrib/ifenty/Fenty_seaice_thermo_code_merge |
| 191 |
|
CPP option SEAICE_OCN_MELT_ACT_ON_AREA removed in v 1.112 is reintroduced |
| 192 |
|
runtime flag SEAICEareaFormula is kept but is inactive |
| 193 |
|
o model/src: |
| 194 |
|
- add new param to scale curvilinear grid distance and area when using |
| 195 |
|
a different sphere radius from the grid-files. |
| 196 |
|
- test/check multi-threads EXCH applied to local variable (cg2d_x) |
| 197 |
|
o adjoint: |
| 198 |
|
- enable adjoint of Stevens OB |
| 199 |
|
- add dummy_in_dynamics to enable extraction of ADJrhoinsitu |
| 200 |
|
(a bit delicate because of potentially modified adj. common block structure; |
| 201 |
|
current switch is ALLOW_AUTODIFF_MONITOR_DIAG, could be changed later) |
| 202 |
|
|
| 203 |
|
checkpoint62s (2011/02/15) |
| 204 |
|
o pkg/seaice (seaice_growth v 1.112): |
| 205 |
|
- introduce SEAICEareaFormula run time parameter, which selects the recipe for |
| 206 |
|
computing the ice cover tendency from effective thickness tendencies. Include |
| 207 |
|
Ian Fenty's formula. |
| 208 |
|
- remove 'undef SEAICE_OCN_MELT_ACT_ON_AREA' which may now be achieved using |
| 209 |
|
SEAICEareaFormula. |
| 210 |
|
- simplify notations for the various d_HEFF/d_AREA terms. |
| 211 |
|
o pkg/gmredi: |
| 212 |
|
- add Boundary-Value-Problem bolus transport (Ferrari etal, OM 2010) code |
| 213 |
|
from Christopher Wolfe (UCSD); add partial cell factor in vertical derivative; |
| 214 |
|
add a verification test-run (front_relax.bvp) to test GM_useBVP. |
| 215 |
|
o pkg/seaice (seaice_growth v 1.111): |
| 216 |
|
- for SEAICE_DO_OPEN_WATER_GROWTH, replace Gael's implementation with Ian's. |
| 217 |
|
- the new SEAICE_DO_OPEN_WATER_MELT allows open-water air-sea heat fluxes to |
| 218 |
|
also melt ice. |
| 219 |
|
o pkg/seaice: |
| 220 |
|
- McPhee formula for Ice-Ocean fluxes (provided by Ian Fenty). |
| 221 |
|
- can be used by #define MCPHEE_OCEAN_ICE_HEAT_FLUX in SEAICE_OPTIONS.h |
| 222 |
|
o pkg/cheapaml: |
| 223 |
|
- from Nico Wienders: New version of this package. |
| 224 |
|
o pkg/flt: |
| 225 |
|
- add CPP options to prevent floats to re-enter the opposite side of |
| 226 |
|
a periodic domain (default: keep periodicity) |
| 227 |
|
o pkg/gmredi: |
| 228 |
|
- apply exchange to GM_PsiX,GM_PsiY to get valid values near CS-corners |
| 229 |
|
(needed for multi-dim advection). |
| 230 |
|
- switch on GM Advective form in global_ocean.cs32x15 and update output.txt |
| 231 |
|
o model/src: |
| 232 |
|
- fix wrong re-setting of addMass array (ALLOW_ADDFLUID) for atmospheric run. |
| 233 |
|
o tutorial_tracer_adjsens |
| 234 |
|
- extend to NLFS and replace maskC by hFacC |
| 235 |
|
(change reference output accordingly) |
| 236 |
|
|
| 237 |
|
checkpoint62r (2011/01/24) |
| 238 |
|
o testreport: |
| 239 |
|
- add option -deloutp (-do) to remove output file after successful run |
| 240 |
|
- add option -mfile (-mf) for MPI machile-file and for each test-exp, |
| 241 |
|
extract exact list of procs from this file ; adjust COMMAND by |
| 242 |
|
replacing TR_MFILE & TR_NPROC with local machile-file & Nb of MPI procs. |
| 243 |
|
o pkg/ecco: replace old ineffective way of penalizing deviations from |
| 244 |
|
first guess (of obcs) with code by Matt Mazloff |
| 245 |
|
o pkg/ctrl: add code that allows the use of ALLOW_OBCS?_CONTROL without |
| 246 |
|
exf/cal |
| 247 |
|
- ctrl_init: fix initialisation (computation of diffrec) for obcs-ctrl |
| 248 |
|
and handle case of obcs?period == 0 |
| 249 |
|
Not affected by these changes: There is still an inconsistency in |
| 250 |
|
the computation of start/endrec for the obcs variables for ALLOW_CAL |
| 251 |
|
defined (see comment by Menemenlis, 7-Mar-2003) |
| 252 |
|
- make S/R ctrl_get_gen_rec return something meaningful even if |
| 253 |
|
ALLOW_CAL is not defined |
| 254 |
|
- ctrl_getobcs?: simplify code so that it does not need to use |
| 255 |
|
S/R exf_swapfields |
| 256 |
|
o testreport: |
| 257 |
|
allow to test MPI with different number of processors for each experiment: |
| 258 |
|
create file "SIZE.h.mpi" in each build dir. |
| 259 |
|
Note: update of "-command" argument not yet implemented. |
| 260 |
|
o model/src, pkg/autodiff, pkg/ecco, pkg/seaice: |
| 261 |
|
alleviate the need for additional 3D tapes when using |
| 262 |
|
the non-inear free surface in the adjoint. This is done |
| 263 |
|
by adding an 'update' of hfacc etc. to their current |
| 264 |
|
value at the beginning of forward_step.F. |
| 265 |
|
o pkg/seaice |
| 266 |
|
seaice_lsr: move stress-divergence computations out of outer pseudo- |
| 267 |
|
timestepping loop |
| 268 |
|
o pkg/obcs/obcs_prescribe_read.F: move 'CALL OBCS_EXTERNAL_FIELDS_LOAD' |
| 269 |
|
up, so that the calls of the ctrl_* subroutines are really at the end |
| 270 |
|
of the routine. |
| 271 |
|
o pkg/gmredi: |
| 272 |
|
allow to specify a 2-D horizontal map and a 1-D vertical profil |
| 273 |
|
as scaling factor for Isopycnal diffusivity (Redi) and GM diffusivity. |
| 274 |
|
o pkg/seaice: |
| 275 |
|
move lsr iterations from seaice_dynsolver to seaice_lsr. |
| 276 |
|
o pkg/seaice: |
| 277 |
|
reduce memory footprint of seaice mutldim advection tapes, |
| 278 |
|
by using a 2D tape independent of the generic_advdiff ones, |
| 279 |
|
and setting GAD_AREA=1 etc. rather than GAD_AREA=101 etc. |
| 280 |
|
|
| 281 |
|
checkpoint62q (2010/12/29) |
| 282 |
|
o model/src: |
| 283 |
|
- check horizontal grid-spacing for unset or zero/negative values. |
| 284 |
|
- change AD test hs94.1x64x5 to be truly a 2-D set-up. |
| 285 |
|
o pkg/flt: |
| 286 |
|
- use (recent) mdsio S/R MDS_READVEC_LOC instead of local FLT_MDSREADVECTOR |
| 287 |
|
- precision of input and output files set according to readBinaryPrec |
| 288 |
|
and writeBinaryPrec (previously always 64.b), pickup remains at 64 bits. |
| 289 |
|
- initial float position from tiled file was not converted to index space |
| 290 |
|
(looks like a bug): fixed to make it similar to initial pos. global file. |
| 291 |
|
o global_ocean.cs32x15: |
| 292 |
|
change SIZE.h of AD set-up to get same tiling as with MPI. |
| 293 |
|
Update output_adm, output_adm.thsice (pass@14) & output_adm.seaice (fail@11) |
| 294 |
|
o model/src: |
| 295 |
|
add flag to control printing of domain fields (bathymetry, hFac ...) in |
| 296 |
|
ini_mask_etc (call to plot_fieds_xy*). |
| 297 |
|
o pkg/thsice: |
| 298 |
|
if useEXF, some forcing fields are not valid in overlap: fixed by computing |
| 299 |
|
over the interior only + apply EXCH at the end (like with SEAICE advection). |
| 300 |
|
o pkg/mdsio: |
| 301 |
|
- add 2 arguments to S/R MDS_PASS_R4/8toRL/S for overlap size of buffer |
| 302 |
|
to copy to/from, so that it can be used to replace MDS_PASS_WH_R8toRL/RS. |
| 303 |
|
- change barrier call for safe multi-threads access to 3-D shared buffer. |
| 304 |
|
- MDS_READ/WRITEVEC_LOC use buffers from MDSIO_BUFF_3D.h (instead of local ones) |
| 305 |
|
- replace call to MDS_PASS_WH_R4/8toRL with call to MDS_PASS_R4/8toRL and |
| 306 |
|
remove the 4 S/R MDS_PASS_WH_R4/8toRL/S. |
| 307 |
|
o pkg/flt: |
| 308 |
|
- add fourth-order Runge-Kutta integration |
| 309 |
|
- add basic exch2 support (only 1 facet supported so far!) |
| 310 |
|
o pkg/mdsio+rw: |
| 311 |
|
new S/R to read local (or tile independent) vector (read counterpart of |
| 312 |
|
mds_writevec_loc, and front-end write_glvec_rl/rs). |
| 313 |
|
o global_ocean.cs32x15: additional input_ad.seaice experiment |
| 314 |
|
that uses pkg/seaice rather than pkg/thsice. |
| 315 |
|
(using multidim advection for seaice) |
| 316 |
|
o towards more F95 syntax for array specification in namelist: |
| 317 |
|
- change "data.diagnostics" (data.ptracers was changed before checkpoint62p) |
| 318 |
|
of all verification experiments. |
| 319 |
|
e.g.: line: fields(1,3)='ETAN ','ETANSQ ', |
| 320 |
|
was changed to: fields(1:2,3)='ETAN ','ETANSQ ', |
| 321 |
|
- finish adding "-DNML_EXTENDED_F77" to DEFINES list in pgf77 and g77 optfiles |
| 322 |
|
o global_ocean.cs32x15: additional input.seaice experiment |
| 323 |
|
that uses pkg/seaice rather than pkg/thsice. |
| 324 |
|
|
| 325 |
|
checkpoint62p (2010/12/17) |
| 326 |
|
o pkg/thsice: rename (ad tape index) iicekey as ticekey, and move it |
| 327 |
|
to THSICE_SIZE.h to avoid conflict with pkg/seaice. |
| 328 |
|
o pkg/seaice: add seaice_diffusion.f seaice_map_thsice.f to adjoint. |
| 329 |
|
allow for use of multim. advection in seaice adjoint. |
| 330 |
|
o pkg/seaice: add diagnostics for snow precipitation and sublimation flux |
| 331 |
|
- first attempt to close budgets by taking into account the freshwater |
| 332 |
|
flux implied by the sublimation of snow and ice. So far only the |
| 333 |
|
volume budget is closed, turn on with soon-to-be-retired-again CPP-Flag |
| 334 |
|
SEAICE_ADD_SUBLIMATION_TO_FWBUDGET |
| 335 |
|
o eesupp/src: |
| 336 |
|
new S/R with new option (NML_EXTENDED_F77) to change array specification |
| 337 |
|
from F95 standard to commonly accepted extended F77 form. |
| 338 |
|
This would allow to use F95 syntax in namelist (needed with gfortran 4.4.5) |
| 339 |
|
and to revert back to the original syntax (with -DNML_EXTENDED_F77) |
| 340 |
|
for less tolerant f77 compiler (e.g., pgf77, g77). |
| 341 |
|
o globalFiles: |
| 342 |
|
commented out in parameter file "data" since it's not safe with MPI |
| 343 |
|
(e.g., wrong on aces); keep it if useSingleCpuIO=T (but not doing much |
| 344 |
|
in this case); no longer commented out in restart test (tst_2+2). |
| 345 |
|
o add adTapeDir to specify a special directory where adjoint tapes are |
| 346 |
|
written/read (adread_adwrite.F). adTapeDir is specified in data/PARM05 |
| 347 |
|
and cannot be used together with mdsioLocalDir. |
| 348 |
|
o nesting pkgs: |
| 349 |
|
- packages_init_variables : put call to OBCS_INIT_VARIABLES in last position |
| 350 |
|
- update Gianmaria's Nesting pkgs (from Contrib/nesting_sannino) |
| 351 |
|
- add parameter files + utils dir + output from short run on beagle. |
| 352 |
|
o pkg/seaice: |
| 353 |
|
fix seaice_growth.F store directives; update results of exp. lab_sea.ad |
| 354 |
|
o pkg/seaice: explicitly store tsurfloc in seaice_solve4temp.F to avoid |
| 355 |
|
unnecessary copying in adjoint code, requires new parameter NMAX_ITER |
| 356 |
|
|
| 357 |
|
checkpoint62o (2010/11/25) |
| 358 |
|
o pkg/exf: |
| 359 |
|
- change CPP option EXF_VERBOSE to run-time logical param exf_verbose. |
| 360 |
|
o pkg/seaice: |
| 361 |
|
- seaice_ocean_stress: split a loop for better vectorization of the |
| 362 |
|
adjoint code |
| 363 |
|
- seaice_growth.F: fix bug in conservation of freshwater connected to |
| 364 |
|
capping of heff, put contribution into d_HEFFbyNEG |
| 365 |
|
- replace irritating parameters SEAICE_latentWater/Ice and SEAICE_sensHeat |
| 366 |
|
by something more sensible (parameters that are what their name implies) |
| 367 |
|
- change some defaults, so that by default exf-parameters are used for |
| 368 |
|
things like rhoAir, cpAir,latent/sensible heat parameters, in order |
| 369 |
|
to reproduce the old results, many data.seaice now contain funny values |
| 370 |
|
for cpAir and latent heat of sublimation |
| 371 |
|
o packages_readparms.F: move exf_readparms up in line so that |
| 372 |
|
exf-parameters are visible for other packages (e.g. seaice) |
| 373 |
|
o debugMode & debugLevel=2: |
| 374 |
|
- differentiate between debugMode & debugLevel=2: |
| 375 |
|
debugMode: controls printing of debug messages (sequence of S/R calls). |
| 376 |
|
debugLevel: controls printing of algorithm intermediate results and stats. |
| 377 |
|
- remove "if debugLevel=2 => debugMode" but keep "debugMode => debugLevel=2"; |
| 378 |
|
=> allows to print debug-stats without all sequence of call messages. |
| 379 |
|
- switch control of debug print from debugLevel to debugMode in many S/R. |
| 380 |
|
o pkg/obcs (obcs-sponge): |
| 381 |
|
fix bug that was introduced on Oct 25 (in dynamics.F v1.151): put back the |
| 382 |
|
call to OBCS_PRESCRIBE_EXCHANGES (need to exch gU,gV when using obcs-sponge) |
| 383 |
|
o pkg/generic_advdiff: |
| 384 |
|
- record overlap minimum size for each advection scheme; |
| 385 |
|
- refine criteria on overlap minimum size; |
| 386 |
|
- check and stop (in gad_check) if overlap size is too small. |
| 387 |
|
o pkg/obcs: |
| 388 |
|
- with ptracers: remove multiple calls to obcs_apply_ptracer (only done |
| 389 |
|
once, in ptracers_implicit.F) |
| 390 |
|
- with seaice: remove test on empty file name in obcs_apply_seaice (always |
| 391 |
|
apply OB values when tile has OB) |
| 392 |
|
o model/src, coriolis setting: |
| 393 |
|
- integer parameter "selectCoriMap" (=0,1,2) replaces 3 logical |
| 394 |
|
useConstantF, useBetaPlaneF, useSphereF ; can now read coriolis from |
| 395 |
|
files (selectCoriMap=3) with any grid. |
| 396 |
|
- add parameter "fPrime" for constant second Coriolis coeff (default=0). |
| 397 |
|
o pkg/seaice/seaice_growth.F: |
| 398 |
|
a few cosmetic changes that reduce the number of lines of code |
| 399 |
|
o pkg/obcs: add boundary conditions following Stevens (1990) |
| 400 |
|
- the code follows old MOM/NAOSIM code |
| 401 |
|
- so far it is only implemented for the eastern and western boundaries |
| 402 |
|
and NOT for pTracers |
| 403 |
|
o pkg/rbcs: |
| 404 |
|
- replace rbcsInIter by rbcsForcingOffset, the time in seconds at the |
| 405 |
|
beginning of the first rbcs forcing period. |
| 406 |
|
- add option rbcsSingleTimeFiles that makes rbcs read forcing data like the |
| 407 |
|
offline package, i.e., one file per time, labeled by iteration number; |
| 408 |
|
deltaTrbcs sets the timestep with which the data was generated; |
| 409 |
|
rbcsIter0 is the forcing iteration corresponding to rbcsForcingOffset. |
| 410 |
|
- rbcsForcingCycle=0 makes forcing non-cyclic. |
| 411 |
|
- make arithmetic safe for negative times and odd forcing periods. |
| 412 |
|
|
| 413 |
|
checkpoint62n (2010/11/09) |
| 414 |
|
o pkg/seaice: |
| 415 |
|
fix masking in free-drift S/R ; update results of exp. lab_sea.fd |
| 416 |
|
o pkg/obcs: |
| 417 |
|
New S/R to copy tracer value from the OB location to narrow band region |
| 418 |
|
(width = same as overlap) beyond the OB: preserve OB value (needed for |
| 419 |
|
high-order scheme) which were overwritten by EXCH call if in overlap |
| 420 |
|
region. Applied to theta, salt, ptracer and advected seaice variables. |
| 421 |
|
With seaice: use maskInC in similar way as in gad_advection.F, |
| 422 |
|
in seaice_advection.F and advect.F. |
| 423 |
|
Update output of experiment seaice_obcs and change exp4 to test OBCS with |
| 424 |
|
4th order Adv.Scheme. for pasive salt and ptracer. |
| 425 |
|
o tools/genmake2: |
| 426 |
|
- when looking for an optfile (not specified), only search for Fortran compiler |
| 427 |
|
(remove sym-link test + setting of CPP + makedepend check + C-compiler check) |
| 428 |
|
- in get_fortran_c_namemangling: use "$CC $CFLAG" to compile C test programm |
| 429 |
|
(instead of "$MAKE genmake_test.o" since an existing Makefile can be wrong) |
| 430 |
|
- set default for CPP to "cpp -traditional -P" (was the case without specifying |
| 431 |
|
an optfile, but otherwise default was just "cpp". |
| 432 |
|
- comment out PLATFORM=$p_PLATFORM (no idea where p_PLATFORM comes from) |
| 433 |
|
- when "CC" is not set in the optfile, look for possible C compiler |
| 434 |
|
(instead of just setting CC=cc) |
| 435 |
|
- put back version v.169 modif (from 2008/02/15), was dropped in v.173 changes: |
| 436 |
|
=> add a ".F" to ".o" rule for source files with no "#include" (such as |
| 437 |
|
port_rand.F); otherwise, default ignores FOPTIM and just uses FFLAGS. |
| 438 |
|
- move gfortran before g77 in list of possible Fortran compiler (consistent |
| 439 |
|
with reference compiler switch from g77 to gfortran) |
| 440 |
|
o pkg/seaice: |
| 441 |
|
o remove SEAICE_OLD_AND_BAD_DISCRETIZATION-code, add a test to |
| 442 |
|
seaice_check that stops the model, when the CPP flag is used. |
| 443 |
|
o seaice_growth.F: make capping of ice volume conserving by returning the |
| 444 |
|
capped ice as freshwater to EmPmR. This does not change the verification |
| 445 |
|
experiments but will change runs where the capping is acutally active |
| 446 |
|
o change reference platform+compiler from faulks+g77 to baudelaire+gfortran |
| 447 |
|
(except the 2 fizhi test exp.); update output of exp.: bottom_ctrl_5x5, |
| 448 |
|
global_ocean.cs32x15 (icedyn, thsice, AD thsice), global_ocean_ebm (AD), |
| 449 |
|
lab_sea (fd, hb87, salt_plume), MLAdjust (3/5) and vermix (dd) |
| 450 |
|
o tools/genmake2: |
| 451 |
|
- merge genmake_warnings & genmake_errors into 1 log file: "genmake.log") |
| 452 |
|
- change DUMPSTATE default to false (can use "-ds" option to switch it to T) |
| 453 |
|
- clean previous genmake log files before anything else. |
| 454 |
|
- change Makefile to remove testreport log files (*.tr_log) and genmake log |
| 455 |
|
files only with "CLEAN" target (instead of "Clean"); |
| 456 |
|
o pkg/generic_advdiff: |
| 457 |
|
Change OBCS in multiDim advection (gad_advection.F): |
| 458 |
|
Use maskInC to prevent intermediate update of tracer-field in OB regions, |
| 459 |
|
thus keeping current-time-step OB values; and remove the call to OBCS_APPLY |
| 460 |
|
which were applying future time-step OB values. |
| 461 |
|
This way, all explicit calculations use current-time-step OB values |
| 462 |
|
(simpler and more consistent). |
| 463 |
|
Affects results when set-up uses time-varying OBC and multi-dim advection; |
| 464 |
|
update output of experiment seaice_obcs. |
| 465 |
|
o pkg/seaice: |
| 466 |
|
move OPTIONS (formerly locally defined) to SEAICE_OPTIONS.h: |
| 467 |
|
this includes SEAICE_GROWTH_LEGACY (+ SEAICE_DO_OPEN_WATER_GROWTH & |
| 468 |
|
SEAICE_OCN_MELT_ACT_ON_AREA ) and SEAICE_SOLVE4TEMP_LEGACY. |
| 469 |
|
Default (pkg/seaice/SEAICE_OPTIONS.h) is to define SEAICE_SOLVE4TEMP_LEGACY |
| 470 |
|
but leave SEAICE_GROWTH_LEGACY undef ; For now, keep verification exp |
| 471 |
|
unchanged (SEAICE_GROWTH_LEGACY defined in */code*/SEAICE_OPTIONS.h) |
| 472 |
|
o pkg aim (2010/10/26): |
| 473 |
|
- Introduce ALLOW_INSOLATION, moving toward a more general incoming solar radiation |
| 474 |
|
formulation with obliquity, eccentricity, ... as run-time parameters, |
| 475 |
|
- Introduce diagnostics for top-of-the-atmaophere incoming solar radiation and |
| 476 |
|
upward shortwave radition at the surface (all-sky and clear-sky). |
| 477 |
|
o pkg/obcs: |
| 478 |
|
- writing sections with globalFiles=T does not work: switch to tiled-files |
| 479 |
|
when writing sections for OBCS (change pkg/rw/write_rec.F accordingly). |
| 480 |
|
- fix index bug (OB_Ie -> OB_Iw_) in obcs_apply_uvice.F |
| 481 |
|
- apply OBCS_SEAICE_COMPUTE_UVICE to both uice and vice at all obcs |
| 482 |
|
|
| 483 |
|
checkpoint62m (2010/10/21) |
| 484 |
|
o pkg/seaice: vectorize seaice_solve4temp.F |
| 485 |
|
- move iterations loops outside of i/j-loops |
| 486 |
|
- requires 2D arrays for TB and effConduct |
| 487 |
|
- add 2D iceOrNot to replace HICE_ACTUAL.GT.0, as HICE_ACTUAL is |
| 488 |
|
modified in this routine |
| 489 |
|
- a little bit of clean up, adjusting indentation, etc. |
| 490 |
|
- replaced a few TEN**a by exp(a*log(10.)) in new code for better |
| 491 |
|
performance and '**TWO' by '**2' (because TWO is a float), |
| 492 |
|
replaced ONE, ZERO |
| 493 |
|
o eesupp/src: |
| 494 |
|
fix flow dir for exch1_z_RX_cube, exch1_uv_RX_cube & exch1_bg_RX_cube |
| 495 |
|
o pkg/seaice/seaice_growth.F |
| 496 |
|
Revision 1.89 of seaice_growth.F completes the overall october 2010 revision and |
| 497 |
|
merging process. The merged routine has two branches, and one activates the 'evolution' |
| 498 |
|
branch by setting SEAICE_GROWTH_LEGACY to undef (at the top of the routine for now). |
| 499 |
|
In summary, here is what the '10/10 revision' did consist of |
| 500 |
|
part 1: seaice_growth.F revisions 1.71 to 1.75 |
| 501 |
|
- Preliminary seaice_growth.F clean-up, keeping test results strictly unchanged. |
| 502 |
|
The emphasis here was on improving readability (e.g. by trying to use meaningful |
| 503 |
|
variable names) and modularity (e.g. by adding arrays to store heff etc. updates). |
| 504 |
|
part 1.5: |
| 505 |
|
- revising the lab_sea experiment to make it a more useful (i.e. stable |
| 506 |
|
and representative of an actual model run). This was done by generating a |
| 507 |
|
(winter) pickup to start from, switching back the main experiment dynamic |
| 508 |
|
solver from evp to lsr, having one of the experiments use the free drift solution. |
| 509 |
|
part 2: seaice_growth.F revisions 1.76 to 1.85 |
| 510 |
|
- Sorting out hard-coded constants that prevented heat and fresh water conservation. |
| 511 |
|
- Sorting out the various fields units and sign (set early on and reset at the end) |
| 512 |
|
to avoid numerous scalings/re-scalings. By v1.85 the basic unit for ice, heat and |
| 513 |
|
fresh water stock is 'effective ice meters', and >0 implies more ice/snow. |
| 514 |
|
- Using tendency terms arrays (d_HEFF* etc.) to alleviate remaining code locks, |
| 515 |
|
and simplifying logical expressions to further improve readibility. |
| 516 |
|
part 3: seaice_growth.F revisions 1.86 to 1.89 |
| 517 |
|
- Re-organize the blocks of code more logically. |
| 518 |
|
- Merging the '_if.F' pieces that add something new. |
| 519 |
|
o pkg/thsice: |
| 520 |
|
- vectorize thsice_solve4temp and thsice_get_exf. |
| 521 |
|
Problem: thsice_solve4temp has an unvectorizable statement that |
| 522 |
|
might also be problematic for TAF |
| 523 |
|
- thsice_get_exf: add the ALLOW_BULK_LARGEYEAGER04 CPP-flag. This |
| 524 |
|
does not change the verifcation experiment, but will change all |
| 525 |
|
experiments that have this flag undefined (not tested in verification); |
| 526 |
|
a little reorganization to save a few 2D fields and recomputations |
| 527 |
|
- 1st step of revisiting thsice adjoint (major recomp. sorted out) |
| 528 |
|
- 2nd step: fix some store dirs |
| 529 |
|
o seems to work somewhat, i.e. using ifort but not g77 |
| 530 |
|
o likely cause are incomplete init. or recomputation |
| 531 |
|
o start verification/global_ocean.cs32x15/input_ad.thsice |
| 532 |
|
o pkg/obcs: add support for exch2 |
| 533 |
|
- the position of the boundary and prescribed values are specified using |
| 534 |
|
a global domain with exch2 facets stacked |
| 535 |
|
- in x for N,S boundaries (like W2_mapIO=-1) |
| 536 |
|
- in y for E,W boundaries (so E,W boundaries do not overlap) |
| 537 |
|
o pkg/mdsio: add support for writing global sections with exch2 |
| 538 |
|
file layout is as for obcs described above: |
| 539 |
|
- for x-z sections, facets are stacked in x (like W2_mapIO=-1) |
| 540 |
|
- for y-z sections, facets are stacked in y |
| 541 |
|
o pkg/thsice: |
| 542 |
|
- change a few routines for better vectorization: thsice_albedo.F, |
| 543 |
|
thsice_step_temp.F, and in thsice_calc_thickn.F. Results are |
| 544 |
|
not affected, but in particular the latter routine has changed |
| 545 |
|
dramatically (not necessarily easier to read now). |
| 546 |
|
- re-arrange calculation in THSICE_SOLVE4TEMP: move outside of i,j loops |
| 547 |
|
iteration loop and call to S/R THSICE_GET_BULKF & THSICE_GET_EXF. |
| 548 |
|
o verification/lab_sea: |
| 549 |
|
- overhaul of the forward model experiments. The main motivation |
| 550 |
|
for this revision is that lab_sea has proven quite fragile (when |
| 551 |
|
changing the sea-ice code, and switching platforms) to a point |
| 552 |
|
when failures were very hard to attribute to specific code problems. |
| 553 |
|
- the suspected reason for this fragility is noise amplification by evp so, |
| 554 |
|
to start with, we decided to replace evp with lsr in the main experiment. |
| 555 |
|
- the input.lsr experiment thus became obsolete and was removed. |
| 556 |
|
- it was replaced with the input.fd experiment that uses an |
| 557 |
|
analytical "free drift" solution as the ice velocity field. |
| 558 |
|
- Taken together, input (lsr), input.fd (free drift) and input.hb87 (evp) |
| 559 |
|
will hopefully allow us to discriminate problems due to dynamic solvers |
| 560 |
|
from problems due to the thermodynamic code. input.salt_plume (lsr) allows |
| 561 |
|
us to test additional options, along with the salt plume package. |
| 562 |
|
- Finally a pickup was generated (at the end of a one year run) to |
| 563 |
|
make the tests more representative of an actual model run. Previously |
| 564 |
|
the tests starting point was a 1m thickness of ice everywhere. |
| 565 |
|
o pkg/seaice: |
| 566 |
|
- introducing S\R seaice_freedrift.F that compute the |
| 567 |
|
analytical solution to an approximate ice momentum |
| 568 |
|
equation (i.e. the simple stress/coriolis balance). |
| 569 |
|
- define SEAICE_ALLOW_FREEDRIFT to trigger the computation |
| 570 |
|
of the free drift velocity field, and enable its use. |
| 571 |
|
To actually use the free drift solution as the model ice |
| 572 |
|
velocity field set SEAICEuseFREEDRIFT to .TRUE. in data.seaice. |
| 573 |
|
o move "useOASIS" from PARAMS.h to EEPARAMS.h and read it from "eedata" |
| 574 |
|
|
| 575 |
|
checkpoint62l (2010/10/04) |
| 576 |
|
o pkg/seaice: |
| 577 |
|
-fix the USE_ORIGINAL_SBI version (for variable freezing point); |
| 578 |
|
-use "celsius2K" in SEAICE_VARIABLE_FREEZING_POINT and in new |
| 579 |
|
version (with USE_ORIGINAL_SBI undef); |
| 580 |
|
o add hooks for new packages OASIS, the package will follow |
| 581 |
|
(hooks exclude the seaice pkg for now) |
| 582 |
|
o pkg/autodiff: ALLOW_AUTODIFF_WHTAPEIO |
| 583 |
|
Option to use mdsio_read_whalos.F/mdsio_write_whalos.F, |
| 584 |
|
rather than mdsio_readvector.F/mdsio_writevector.F, within |
| 585 |
|
adread_adwrite.F to read/write adjoint-related tapes to disk. |
| 586 |
|
o eesupp and pkg/mdsio: ALLOW_WHIO |
| 587 |
|
Option to write/read 2D fields to files including tiles halos. |
| 588 |
|
The main purpose is for adjoint related "tape I/O". |
| 589 |
|
The secondary purpose is for debugging phases. |
| 590 |
|
A word on those rather specifically intended purposes. |
| 591 |
|
The code was meant to be stripped down to the bare minimum. |
| 592 |
|
Typically, there is a unique and basic mapping to the global |
| 593 |
|
buffer (tile by tile, then proc by proc, then level by level), and |
| 594 |
|
byteswaps and meta-files are omitted. Indeed the (*_WH*) code is not |
| 595 |
|
meant to generate user friendly outputs of various shapes and forms. |
| 596 |
|
Rather it is intended, for the knowledgeabale developers, |
| 597 |
|
to be largely independent of the many mdsio options, to allow |
| 598 |
|
outputs of tiles+halos in debugging phases and in adjoint runs, |
| 599 |
|
and to allow some flexibility in tuning (adoint) I/O depending on each |
| 600 |
|
file system behavior. With regard to tuning, most of the potential knobs |
| 601 |
|
(to leave files open, to allocate the I/O indep. of usesinglecpuio, |
| 602 |
|
to specify directories, to specify the typical size of I/O calls, etc.) |
| 603 |
|
are not yet included, and will be added if they prove useful. |
| 604 |
|
o pkg/seaice: |
| 605 |
|
fix uninitialised arrays in USE_ORIGINAL_SBI version of seaice_solve4temp.F |
| 606 |
|
o pkg/seaice: |
| 607 |
|
new S/R seaice_solve4temp.F: this is the merged version of Ian Fenty |
| 608 |
|
code (seaice_budget_ice_if.F) which enable to recover old standard |
| 609 |
|
code (seaice_budget_ice.F) when option USE_ORIGINAL_SBI is defined. |
| 610 |
|
temporary: add "#define USE_ORIGINAL_SBI" at the top of seaice_solve4temp.F. |
| 611 |
|
o model/src (rStar): |
| 612 |
|
use simple average (not area weighted) of rStarFac at U,V point when using |
| 613 |
|
vectorInvariant and selectKEscheme=1,3 (consistent with mom. vertical advection) |
| 614 |
|
update output of exp. fizhi-cs-32x32x40 and fizhi-cs-aqualev20. |
| 615 |
|
|
| 616 |
|
checkpoint62k (2010/09/17) |
| 617 |
|
o adjoint |
| 618 |
|
* changed verification/global_ocean.cs32x15 ; adjoint now tests |
| 619 |
|
Adams-Bashforth 3 + NLFS + RSTAR |
| 620 |
|
* some more modifs required for ECCO-GODAE v4 |
| 621 |
|
o pkg/seaice |
| 622 |
|
add SEAICE_AGE_VOL option to use volume instead of area for |
| 623 |
|
integrating SEAICE_AGE |
| 624 |
o model/src: |
o model/src: |
| 625 |
first check-in of sigma & hybrid-sigma coordinate code ; also includes |
first check-in of sigma & hybrid-sigma coordinate code ; also includes |
| 626 |
non-linear free-surface parts ; but pressure-gradient not yet coded. |
non-linear free-surface parts ; but pressure-gradient not yet coded. |
| 890 |
but keep the former optfile for few weeks for smooth transition |
but keep the former optfile for few weeks for smooth transition |
| 891 |
o pkg/ecco |
o pkg/ecco |
| 892 |
- allow user defined cost function contributions |
- allow user defined cost function contributions |
| 893 |
CPP: ALLOW_USERCOST_CONTRIBUTION |
CPP: ALLOW_USERCOST_CONTRIBUTION |
| 894 |
USAGE: compute contributions in cost_usercost_all.F |
USAGE: compute contributions in cost_usercost_all.F |
| 895 |
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
| 896 |
the two options are complementary. |
the two options are complementary. |
| 897 |
o pkg/smooth |
o pkg/smooth |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch