| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o verification/testreport |
| 8 |
|
- add new option -small_f |
| 9 |
|
with this option testreport first makes the target small_f (*.f files) |
| 10 |
|
before running make (all). This is useful for explicit inlining when |
| 11 |
|
all sources need to be full available. |
| 12 |
|
|
| 13 |
|
checkpoint65k (2015/04/01) |
| 14 |
|
o pkg/ecco: |
| 15 |
|
fix missing cosphi initialization; use eccoiter in place of optimcycle; |
| 16 |
|
if autodiff is not compiled then use READ_REC_XY_RL/READ_REC_XYZ_RL |
| 17 |
|
instead of active read/write |
| 18 |
|
o pkg/ctrl: |
| 19 |
|
if autodiff is not compiled then use READ_REC_XY_RL/READ_REC_XYZ_RL |
| 20 |
|
instead of active read/write. |
| 21 |
|
o pkg/autodiff: make autodiff_readparms.F and autodiff_whtapeio_sync.F |
| 22 |
|
return if .NOT.useAUTODIFF |
| 23 |
|
o pkg/seaice: add CPP brackets (cost function related). |
| 24 |
|
o model/src: |
| 25 |
|
add useAUTODIFF run time switch. |
| 26 |
|
o pkg/exf/exf_interp.F: |
| 27 |
|
add code to allow input grids with latitude starting in the north (i.e. when |
| 28 |
|
j=1 corresponds to northern edge of field); modify global_with_exf to test |
| 29 |
|
this feature. |
| 30 |
|
o verification/testreport: |
| 31 |
|
- replace "grep -A3" with POSIX conformal sed command, because there are |
| 32 |
|
implementations of grep that cannot do contextual searches |
| 33 |
|
- replace "cat -n" by "nl" (two occurrences), because not all implementations |
| 34 |
|
of "cat" have the option "-n" |
| 35 |
|
o model/src: |
| 36 |
|
add new file gsw_teos10.F that contains 3 functions, more or less a copy |
| 37 |
|
of the gsw_toolbox.f90 of the TEOS-10 fortran interface, that are used to |
| 38 |
|
convert from conservative to potential temperature. For now they are not |
| 39 |
|
called anywhere. |
| 40 |
|
o pkg/ggl90: make "useIDEMIX" useful |
| 41 |
|
- re-organize code in s/r ggl90_calc a little to move computations that |
| 42 |
|
are different for idemix into separate loops (changes verification |
| 43 |
|
experiment idemix at truncation level, 12 digits remain -> updated) |
| 44 |
|
- requires 2 new 2D fields KappaM, verticalShear |
| 45 |
|
- make hFacI and recip_hFacI local 3D variables that are passed to |
| 46 |
|
s/r ggl90_idemix |
| 47 |
|
- fix and improve some comments |
| 48 |
|
|
| 49 |
|
checkpoint65j (2015/02/25) |
| 50 |
|
o pkg/openad |
| 51 |
|
- synchronize seawater.F with version in model/src: replace routine |
| 52 |
|
body of sw_temp by calling sw_ptmp and fix/add a few comments. |
| 53 |
|
o pkg/mnc: |
| 54 |
|
- change default value of pickup_read/write_mnc params to FALSE |
| 55 |
|
(since few features are missing in reading MNC pickup files). |
| 56 |
|
o model/src: |
| 57 |
|
- change default (background) vertical diffusivity for salt to be the |
| 58 |
|
temperature (background) vertical diffusivity. |
| 59 |
|
- change background vertical diffusivity in vertical mixing pkgs ggl90, |
| 60 |
|
kl10, my82 and pp81 from temperature diffusivity to salinity diffusivity. |
| 61 |
|
This makes ptracers default diffusivity (that uses salt diffKr) more |
| 62 |
|
consistent with vertical mixing schemes. |
| 63 |
|
o verification/testreport: |
| 64 |
|
- fix typo in "-pcls" option ; |
| 65 |
|
- put temp files in /tmp (instead of in local dir) |
| 66 |
|
- add option "-ncad" to use genmake2 new option "-nocat4ad" |
| 67 |
|
- allow to use "-j" option (for multi-procs make) for AD, OAD and TLM. |
| 68 |
|
o pkg/ggl90 (idemix code): |
| 69 |
|
- apply few fixes ; add some missing "_d 0" ; update output of exp. |
| 70 |
|
global_ocean.90x40x15.idemix |
| 71 |
|
o OpenAD |
| 72 |
|
- enable active file I/O and begin removal of work-around code |
| 73 |
|
for OpenAD for handling control variables (memory vs. active files) |
| 74 |
|
- new CPP options file OPENAD_OPTIONS.h |
| 75 |
|
- revert to genarr2d gradient check for hs94.1x64x5 |
| 76 |
|
- (genarr3d tested by tutorial_global_oce_biogeo, tutorial_tracer_adjsens) |
| 77 |
|
- gentim2d works for halfpipe_streamice but not yet hs94.1x64x5 |
| 78 |
|
o tools/genmake2: |
| 79 |
|
- add option for an alternative Makefile (from Martin) where multiple |
| 80 |
|
source files are sent to TAF (instead of all in one file). |
| 81 |
|
o pkg/ggl90: add IDEMIX (Olbers and Eden, 2013) |
| 82 |
|
- code provided by Carsten Eden as an extension of ggl90 |
| 83 |
|
- so far the code is turned on within ggl90 by setting a CPP-flag at |
| 84 |
|
compile time; a runtime flag implementation is not yet complete |
| 85 |
|
- tested in new verification experiment global_ocean.90x40x15.idemix |
| 86 |
|
o verification: |
| 87 |
|
- reduce length of the AD test run by half for experiments |
| 88 |
|
global_ocean.cs32x15 (std + thsice) and isomip |
| 89 |
|
- enable active file I/O for OpenAD, adjust verifications accordingly |
| 90 |
|
- halfpipe_streamice: change gradient check from genarr2d to gentim2d |
| 91 |
|
o verification/testreport: |
| 92 |
|
- fix two non-POSIX sed statements so that there are no error messages |
| 93 |
|
on Mac OS X |
| 94 |
|
- replace hostname -s with hostname | sed 's/\..*$//' |
| 95 |
|
o model/src/seawater.F: |
| 96 |
|
- simplify SW_TEMP to just calling SW_PTMP with P and PR exchanged |
| 97 |
|
(following the matlab code), which would have avoided the bug caught |
| 98 |
|
by Matt (see below) in the first place |
| 99 |
|
o pkg/shelfice: |
| 100 |
|
- implement alternative discretisation of quadratic drag (selectBotDragQuadr) |
| 101 |
|
and true distance in no-slip BC (bottomVisc_pCell) similar to bottom-drag. |
| 102 |
|
- fix sign of friction tendency (no-slip BC) and fix u,v drag for thin |
| 103 |
|
ice-shelf case (i.e., within surface level). |
| 104 |
|
- add config summary in shelfice_check.F |
| 105 |
|
- remove global variable recip_SHELFICElatentHeat and replace by a local |
| 106 |
|
variable recip_latentHeat |
| 107 |
|
- introduce diagnostics for friction velocity uStar (in case of |
| 108 |
|
SHELFICEuseGammaFrict) |
| 109 |
|
- change verification experiment isomip.htd: |
| 110 |
|
+ start from pickup (as input_ad at nIter0=8640) |
| 111 |
|
+ start from SHELFICEmassFile instead of SHELFICEloadAnomaly file |
| 112 |
|
+ test SHELFICEuseGammaFrict = .TRUE. |
| 113 |
|
+ test SHELFICEadvDiffHeatFlux = .TRUE. |
| 114 |
|
o model/src: |
| 115 |
|
- fix bug (Thanks to Matt) in function SW_TEMP (to convert Pot.Temp to |
| 116 |
|
in-situ Temp) and in routine SW_TEMP (in pkg/openad); |
| 117 |
|
update output of experiments global_with_exf.yearly and isomip (all 6). |
| 118 |
|
o pkg/shelfice: |
| 119 |
|
- change setting of kTopC to also be zero where there is no ice-shelf. |
| 120 |
|
- zero out surface forcing arrays (for now, for T & S + EmPmR) where |
| 121 |
|
ice-shelf is. |
| 122 |
|
- first attempt to get RealFreshWaterFlux effects: for now, only without |
| 123 |
|
SHELFICEboundaryLayer ; not consistent if using synchronous time-stepping. |
| 124 |
|
o pkg/seaice: add the option to prescribe a fixed thickness PDF |
| 125 |
|
for thermodynamic calculations |
| 126 |
|
- because of divisions of the type 7/7 not exactly equal to 1, this change |
| 127 |
|
affects results of some verification experiments by up to 4 digits: |
| 128 |
|
global_ocean.cs32x15.seaice, lab_sea, lab_sea.fd, lab_sea.salt_plume, |
| 129 |
|
seaice_obcs, seaice_obcs.seaiceSponge, seaice_obcs.tides |
| 130 |
|
adjoint: lab_sea, lab_sea.noseaicedyn |
| 131 |
|
-> updated |
| 132 |
|
|
| 133 |
|
checkpoint65i (2015/01/23) |
| 134 |
|
o model/src: |
| 135 |
|
- change units of frictionHeating field from W to W/m^2 |
| 136 |
|
- fix bug in frictional heating from stratospheric drag in |
| 137 |
|
S/R ATM_PHYS_TENDENCY_APPLY_V |
| 138 |
|
- with synchronous time-stepping: move resetting to zero of frictionHeating |
| 139 |
|
field from load_fields_driver.F to thermodynamics.F ; |
| 140 |
|
- add diagnostics for frictional heating. |
| 141 |
|
o model/src & gmredi K3D: |
| 142 |
|
- add frictionHeating field to pickup-files (for synchronous time-stepping) |
| 143 |
|
- move ALLOW_EDDYPSI block out of DYNVARS.h and merge it into FFIELDS.h |
| 144 |
|
- rename uMean,vMean --> uEulerMean,vEulerMean (+ change diagnostics name |
| 145 |
|
and name in pickup file). |
| 146 |
|
- fix arguments of few DIAGNOSTICS_FILL calls in gmredi_k3d.F |
| 147 |
|
o model/src: |
| 148 |
|
- move (from ini_forcing.F) initialisation of all arrays in header file |
| 149 |
|
FFIELDS.h into new S/R ini_ffields.F ; this fix broken restart |
| 150 |
|
(since Nov 2012) with option selectAddFluid=1. |
| 151 |
|
o pkg/shelfice: |
| 152 |
|
- change units (+ document) of newly added field "shelfIceMassDynTendency" |
| 153 |
|
- upgrade from _RS to _RL shelficeMass & shelficeLoadAnomaly arrays. |
| 154 |
|
o pkg/obcs: re-organize obcs_calc_stevens.F to prepare for passive tracers |
| 155 |
|
o pkg/seaice: two new runtime parameters: |
| 156 |
|
- SEAICE_cStar replaces the hard wired "20" in the strength formulation, |
| 157 |
|
long overdue |
| 158 |
|
- SEAICE_tensilFac: preparation for Koenig-Beatty+Holland (2012) |
| 159 |
|
parameterization of tensil stress for fast ice (does not do anything yet) |
| 160 |
|
o pkg/seaice/seaice_check.F: left over from restricted addtive Schwarz method |
| 161 |
|
for LSR: move checking overlaps out of JFNK-if-block |
| 162 |
|
o pkg/atm_phys: |
| 163 |
|
- move copy of grid and dynamical fields out of atm_phys_driver.F into |
| 164 |
|
new S/R ATM_PHYS_DYN2PHYS. |
| 165 |
|
- fix level height for Linear Free-Surf case (to be consistent with |
| 166 |
|
fixed-in-time pressure levels). |
| 167 |
|
o pkg/mom_common (bottomdrag): |
| 168 |
|
- average bottomDragFld (ALLOW_BOTTOMDRAG_CONTROL) from grid-cell center |
| 169 |
|
to correct location (U & V point) in S/R MOM_U/V_BOTTOMDRAG; |
| 170 |
|
update output (adm & tlm) of experiment global_ocean.90x40x15.bottomdrag. |
| 171 |
|
o pkg/shelfice (u/v_drag): |
| 172 |
|
- add one argument (the other velocity component) to S/R SHELFICE_U/V_DRAG; |
| 173 |
|
- use SHELFICEDragLinear & SHELFICEDragQuadratic in shelfice_v_drag.F |
| 174 |
|
(now similar to shelfice_u_drag.F) |
| 175 |
|
- remove condition on bottomDragTerms when calling SHELFICE_U/V_DRAG |
| 176 |
|
from mom_vecinv.F (similar to mom_fluxform calls). |
| 177 |
|
o pkg/mom_common (bottomdrag): |
| 178 |
|
- add one argument (the other velocity component) to S/R MOM_U/V_BOTTOMDRAG; |
| 179 |
|
- add options for alternative discretisation of velocity norm in quadratic |
| 180 |
|
bottom drag: averaging of grid-cell-center KE to U.point and V.point |
| 181 |
|
(selectBotDragQuadr=0, original code) can produce noisy patterns; this |
| 182 |
|
improves when averaging only the other component (e.g. vVel for U bottom |
| 183 |
|
drag) using wet-point method (selectBotDragQuadr=2) or not (=1). |
| 184 |
|
- add options (bottomVisc_pCell) to account for partial-cell in bottom |
| 185 |
|
friction (no-slip BC) thus getting the true distance from the bottom; |
| 186 |
|
off by default since this also reduces model stability (explicit bottom |
| 187 |
|
friction). Changes produce different machine truncation with linear-drag |
| 188 |
|
+ no-slip BC: update output of experiments exp4.stevens (10 digits) and |
| 189 |
|
front_relax (bvp & mxl, 10 & 11 digits). |
| 190 |
|
o model/src & mom pkgs: |
| 191 |
|
- add one more level to vertical viscosity local arrays (Nr+1, previously Nr) |
| 192 |
|
since no-slip bottom BC uses viscosity @ k+1 to update velocity @ level k |
| 193 |
|
- for now and until vertical mixing scheme are updated to fill up level Nr+1, |
| 194 |
|
just copy level Nr value to level Nr+1. |
| 195 |
|
o doc: |
| 196 |
|
- add notes form Abhisek Chakraborty on how to close Heat & Salt budgets. |
| 197 |
|
o pkg/streamice: |
| 198 |
|
- shelfice_init_varia.F, shelfice_init_fixed.F, shelfice_readparms.F, |
| 199 |
|
SHELFICE.h: move array shelficemass to init_varia, initialise |
| 200 |
|
from array shelficemassinit, which is set in init_fixed and |
| 201 |
|
has option to be set from file; introduce array |
| 202 |
|
shelficeMassDynTend array, set thru file in init_fixed |
| 203 |
|
- NEW FILE: shelfice_step_icemass.F: update shelficemass from either |
| 204 |
|
shelfIceFreshWaterFlux and shelficeMassDynTend or H_streamice in |
| 205 |
|
pkg/streamice |
| 206 |
|
- shelfice_thermodynamics.F: call shelfice_step_icemass if |
| 207 |
|
SHELFICEMassStepping = .true. |
| 208 |
|
- shelfice_ad_diff.list: add new subroutine shelfice_step_icemass.f |
| 209 |
|
|
| 210 |
|
checkpoint65h (2014/12/17) |
| 211 |
|
o verification/global_ocean.90x40x15, global_ocean_ebm: |
| 212 |
|
- update to generic controls. |
| 213 |
|
o pkg/ctrl: |
| 214 |
|
- ctrl_map_ini_genarr.F: test for igen>0 |
| 215 |
|
- ctrl_init_variables.F: add call to CTRL_MAP_INI_GENTIM2D. |
| 216 |
|
- move gentim2d part of ctrl_map_ini_genarr.F to |
| 217 |
|
new separate routine : ctrl_map_ini_gentim2d.F |
| 218 |
|
- ctrl_cost_driver.F,ctrl_init.F ctrl_map_ini_genarr.F: |
| 219 |
|
add time variable weights and cyclic controls (time mean, |
| 220 |
|
seasonal cycle, etc) capabilities to gentim2d |
| 221 |
|
o pkg/ecco: |
| 222 |
|
- move reading of error, conversion to weights from |
| 223 |
|
ecco_cost_init_fixed.F to ecco_toolbox.F (ecco_readwei) |
| 224 |
|
o global_oce_llc90, cs32: |
| 225 |
|
- activte sbo. |
| 226 |
|
- CTRL_SIZE.h : add maxCtrlProc. |
| 227 |
|
- activate the new genctrl capabilities. |
| 228 |
|
- update following reorganization of global_oce_input_fields.tar.gz |
| 229 |
|
o pkg/ctrl/ctrl_ad_diff.list: |
| 230 |
|
- add missing ctrl_init_rec.f |
| 231 |
|
o tools/OAD_support/keepOriginal: |
| 232 |
|
- add ctrl_init_rec.F |
| 233 |
|
o model/src/the_main_loop.F, pkg/ctrl/ctrl_map_ini_genarr.F: |
| 234 |
|
- avoid recomputations of xx_gentim2d_dummy. |
| 235 |
|
o momentum diagnostics: |
| 236 |
|
- move filling of diagnostics Um_Diss & Vm_Diss from mom_fluxform.F and |
| 237 |
|
mom_vecinv.F to timestep.F (to include Smag-3D contribution). |
| 238 |
|
o pkg/seaice/seaice_lsr.F: |
| 239 |
|
- fix computation of BU/BV, make sure they are non-zero, only necessary |
| 240 |
|
for cubed sphere exchanges and SEAICE_OLx/y>0. |
| 241 |
|
This makes calling s/r fill_cs_corner_rl obsolete (removed). |
| 242 |
|
o verification/global_ocean.cs32x15/input.seaice |
| 243 |
|
- add test for strong implicit coupling and restricted addtive Schwarz |
| 244 |
|
methods for LSR |
| 245 |
|
- update results/output.seaice.txt |
| 246 |
|
o verification/tutorial_global_oce_biogeo: |
| 247 |
|
- AD & OAD set-up: switch off ALLOW_OLD_VIRTUALFLUX (like in fwd set-up) |
| 248 |
|
and set PTRACERS_EvPrRn(1,2) to zero (for DIC & ALK); |
| 249 |
|
update output_adm,_oadm,_tlm.txt |
| 250 |
|
o pkg/dic: |
| 251 |
|
- change default to "#undef ALLOW_OLD_VIRTUALFLUX" in DIC_OPTIONS.h |
| 252 |
|
- add a stop when ALLOW_OLD_VIRTUALFLUX is defined and PTRACERS_EvPrRn |
| 253 |
|
for tracer 1 & 2 is set (to avoid double counting of dilution effect). |
| 254 |
|
o verification/tutorial_global_oce_biogeo: |
| 255 |
|
- AD & OAD set-up: do not set PTRACERS_EvPrRn for tracer 1 & 2 since |
| 256 |
|
dilution is already added by pkg/dic ALLOW_OLD_VIRTUALFLUX ; |
| 257 |
|
update output_adm,_oadm,_tlm.txt |
| 258 |
|
o eesupp/src: |
| 259 |
|
- add fill_cs_corner_rl.F (_RL-copy of fill_cs_corner_rs.F) |
| 260 |
|
and call it in seaice_lsr when using nonzero SEAICE_OLx/y |
| 261 |
|
o pkg/seaice: introduce strongly implicit coupling, intended for stabilizing |
| 262 |
|
LSR (following Hutchings et al. 2004) |
| 263 |
|
- introduce zetaZ as a global variable (requires adjustments in |
| 264 |
|
seaice_evp.F and seaice_jfnk.F) and compute analoguously to etaZ |
| 265 |
|
in seaice_calc_viscosities.F |
| 266 |
|
- new flag SEAICEuseStrImpCpl (default off) |
| 267 |
|
- add new terms zetaZ*du/dy and zetaZ*dv/dx on both sides of the |
| 268 |
|
momentum equations |
| 269 |
|
- JFNK-solver (preconditioner) adjusted to allow using this method |
| 270 |
|
(where it does not have any positive effect) |
| 271 |
|
o pkg/seaice |
| 272 |
|
- add overlap for restrictive additive Schwartz method also to LSR, but |
| 273 |
|
turn it off by default (because it only seems to work for non-cubed |
| 274 |
|
sphere/llc topologies) |
| 275 |
|
o pkg/autodiff |
| 276 |
|
- add extra exchanges in addummy_in_steppging also for mnc output |
| 277 |
|
o pkg/seaice: |
| 278 |
|
- add extra exchanges before dumping adjoint fields in seaice_ad_dump.F |
| 279 |
|
to avoid stripes in the adjoint output (similar to addummy_in_stepping.F) |
| 280 |
|
o pkg/obcs: |
| 281 |
|
- add option to specify domain-connected piece Id along OB though files |
| 282 |
|
(for now, only used to diagnose PhiVel; default =1 -> global correction) |
| 283 |
|
- modify obcs_diag_balance.F to process each connected-part separately; |
| 284 |
|
exclude OB where Id = 0 but keep the full divergence there (-> constant |
| 285 |
|
Psi along this portion of OB and all inflow derived from grad(Phi)) |
| 286 |
|
- add example of OB-conect files in verification/so_box_biogeo/input. |
| 287 |
|
o pkg/diagnostics: |
| 288 |
|
- improve treatment of Open-Boundaries in Velocity-Potential calculation: |
| 289 |
|
a) use non zero matrix element across OB and solve for Phi 1 grid point |
| 290 |
|
outside OB (i.e, where tracer OBCS are applied). |
| 291 |
|
b) global imbalance of inFlow/outFlow across OB: instead of modifying |
| 292 |
|
velocity across OB, spread it uniformly along the OB in the RHS. |
| 293 |
|
|
| 294 |
|
checkpoint65g (2014/11/19) |
| 295 |
|
o pkg/diagnostcis: |
| 296 |
|
- add preconditioner off-diagonal factor (diagCG_pcOffDFac) as run-time param |
| 297 |
|
o pkg/my82,pp81,kl10: |
| 298 |
|
- fix ALLOW_3D_DIFFKR implementation (previously had no effect): use 3-D |
| 299 |
|
field diffKr as background diffusivity to set minimum diffusivity value. |
| 300 |
|
o pkg/seaice: |
| 301 |
|
- add new parameter SEAICEuseEVPrev (for revisited EVP by |
| 302 |
|
Bouillon et al 2013) |
| 303 |
|
- add SEAICE_evpAlpha/Beta to namelist |
| 304 |
|
- modify seaice_evp code to able to use SEAICEuseEVPrev. These changes |
| 305 |
|
involve trivial re-ordering of divisions/multiplications that should not |
| 306 |
|
have any effects, but ... they do change the results of lab_sea.hb87 so |
| 307 |
|
that only 2 digits of agreement remain, in line with the general |
| 308 |
|
instability/fragility of the evp-code. For now, I do not care and just |
| 309 |
|
update the verification experiment |
| 310 |
|
o pkg/ctrl : add generic pre-processing (xx_genarr2d_preproc etc) |
| 311 |
|
- remove xx_genarr2d_numsmooth etc |
| 312 |
|
- use xx_genarr2d_preproc etc instead |
| 313 |
|
- carry out smooth_correl2D at initialization stage rather than during |
| 314 |
|
time stepping. |
| 315 |
|
- get smoothOpNb from xx_gentim2d_preproc |
| 316 |
|
o global_oce_cs32 : |
| 317 |
|
- add test of generic ecco capabilities. |
| 318 |
|
o pkg/exf/exf_getsurfacefluxes.F : |
| 319 |
|
- add to tmpUE/tmpVN rather than re-initializing them (conventional behavior). |
| 320 |
|
o pkg/ctrl,ecco : |
| 321 |
|
- omit un-necessary arguments to ctrl_cost_gen.F unless ECCO_CTRL_DEPRECATED |
| 322 |
|
is defined. |
| 323 |
|
o pkg/seaice: add diagnostics for Delta (deformation parameter) |
| 324 |
|
o model/src: |
| 325 |
|
- when ALLOW_3D_DIFFKR is defined, add a Warning if any of the vertical |
| 326 |
|
diffusivity (background) is specified but ignored. |
| 327 |
|
o verification: |
| 328 |
|
- in testreport, convert hostname to lower case for default output dir name |
| 329 |
|
o model, pkg : add useCTRL, useECCO parameters (on/off run time switch). |
| 330 |
|
o pkg/dic: add modifications from Hajoon: |
| 331 |
|
- add iron sedimentation flux function of the flux of PO4 out of bottom layer |
| 332 |
|
- light attenuation: add self-shading effect by climatological Chlorophyll |
| 333 |
|
(read from file). |
| 334 |
|
o pkg/seaice/seaice_preconditioner.F : fix cpp flags, so that code also |
| 335 |
|
compiles when SEAICE_ALLOW_DYNAMICS is undefined |
| 336 |
|
o global_oce_llc90,cs32 : ecco_v4 verification exps now use separate |
| 337 |
|
AUTODIFF_OPTIONS.h, CTRL_OPTIONS.h, ECCO_OPTIONS.h rather than |
| 338 |
|
ECCO_CPPOPTIONS.h (i.e. replacing the deprecated, circumvoluted, |
| 339 |
|
approach where CPP_OPTIONS.h includes an omnipotent |
| 340 |
|
ECCO_CPPOPTIONS.h that superseeds pkgs '_OPTIONS.h'). |
| 341 |
|
o pkg/ctrl/ctrl_map_ini_genarr.F : include GMREDI_OPTIONS.h where |
| 342 |
|
ALLOW_3D_KAPGM, ALLOW_3D_KAPREDI (to be added later) belong. |
| 343 |
|
o pkg/seaice/SEAICE_SIZE.h : replace ALLOW_AUTODIFF_TAMC with ALLOW_AUTODIFF |
| 344 |
|
to avoid needing AUTODIFF_OPTIONS.h anytime SEAICE_SIZE.h is included |
| 345 |
|
(it seems that THSICE_SIZE.h, PTRACERS_SIZE.h have the same issue...) |
| 346 |
|
o model/src, pkg/smooth, profiles, salt_plume, seaice, exf, ecco, ctrl : |
| 347 |
|
add ECCO_OPTIONS.h, AUTODIFF_OPTIONS.h, CTRL_OPTIONS.h when needed |
| 348 |
|
- ECCO_OPTIONS.h is needed when including ecco_cost.h, ecco.h |
| 349 |
|
- AUTODIFF_OPTIONS.h is needed when including tamc.h, tamc_keys.h |
| 350 |
|
- CTRL_OPTIONS.h is needed when including ctrl.h, optim.h, etc |
| 351 |
|
o pkg/ctrl,ecco,exf : |
| 352 |
|
- remove variables associated with NON-generic costs, |
| 353 |
|
unless ECCO_CTRL_DEPRECATED is defined. |
| 354 |
|
- remove NON-generic NON-obcs controls, |
| 355 |
|
unless ECCO_CTRL_DEPRECATED is defined. |
| 356 |
|
o pkg/ctrl : added ctrl_local_params.h |
| 357 |
|
o pkg/ecco : added ecco_local_params.h |
| 358 |
|
o verification : added ECCO_CTRL_DEPRECATED to most as and oad |
| 359 |
|
experiments, which will progressively be removed once the |
| 360 |
|
experiments are revised to use only generic controls/costs. |
| 361 |
|
|
| 362 |
|
checkpoint65f (2014/10/13) |
| 363 |
|
o pkg/ctrl, ecco, seaice : minor changes in headers |
| 364 |
|
o global_oce_llc90,cs32 : ecco_v4 verification exps now test generic |
| 365 |
|
cost function and control capabilities added since checkpoint65c. |
| 366 |
|
o pkg/ctrl: regroup all obcs ctrl variables in CTRL_OBCS.h. |
| 367 |
|
o pkg/ecco: increase modularity and improve logic |
| 368 |
|
- ecco_toolbox.F (new) : basic operations that are often used, |
| 369 |
|
including ecco_zero, ecco_cp, ecco_cprsrl, ecco_diffmsk, |
| 370 |
|
ecco_addcost, ecco_add, ecco_div, ecco_readbar. |
| 371 |
|
- cost_gencal.F (new) : determine filnames and records. |
| 372 |
|
- cost_genread.F, cost_generic.F : condense code using ecco_toolbox. |
| 373 |
|
- cost_generic.F : use spzeroloc rather than hard-coded -9999, |
| 374 |
|
and exploit the above functions leading to more compact code. |
| 375 |
|
- cost_genread.F : rm un-necessary arguments, re-arrange args order. |
| 376 |
|
- ecco_check.F, ecco_readparms.F : bring logic up to date (using_tpj, |
| 377 |
|
using_ers, using_gfo, using_mdt is now only defined within gencost) |
| 378 |
|
o pkg/ecco: extend generic cost capabilities |
| 379 |
|
- pkg/ecco : added 3D gencost (ALLOW_GENCOST3D), added gencost |
| 380 |
|
capabilities via gencost_preproc (+ _c,_i,_r related params), |
| 381 |
|
gencost_posproc (+ _c,_i,_r related params), gencost_nrecperiod, |
| 382 |
|
gencost_outputlevel arguments to cost_generic |
| 383 |
|
- pkg/ecco/cost_genread.F (new) : interface between cost_generic |
| 384 |
|
and active_read, making room for gencost_preproc to take effect. |
| 385 |
|
Added preproc code ('climmon') to replace GENERIC_BAR_MONTH. |
| 386 |
|
- pkg/ecco/cost_generic.F : |
| 387 |
|
compute and store misfit maks*(model-data) in localdif that is |
| 388 |
|
then used in cost and for output, output misfit if outlev.GT.0 |
| 389 |
|
- pkg/ecco/cost_averagesfields.F : depend on gencost_barskip |
| 390 |
|
rather gencost_barfile for deciding whether to write barfile |
| 391 |
|
- pkg/ecco/ecco_cost_driver.F : extract call to cost_profiles from cost_hyd |
| 392 |
|
- pkg/ecco/ecco_cost_init_fixed.F : extract gencost weights from |
| 393 |
|
ecco_cost_weights, re-activate ecco_summary, determine gencost_barskip |
| 394 |
|
- pkg/ecco/ecco_summary.F : report gencost variables |
| 395 |
|
- pkg/ecco/cost_gencost_customize.F : treat case of scatterometer costs |
| 396 |
|
o pkg/sea/SEAICE_OPTIONS.h : add ALLOW_COST_ICE, ALLOW_SEAICE_COST_SMR_AREA |
| 397 |
|
o pkg/ecco: internal re-organization |
| 398 |
|
- resolve un-necessary dependancies within pkg/ecco and to pkg/ctrl |
| 399 |
|
(rm includes of optim.h and ctrl.h, replace optimcycle with eccoiter, |
| 400 |
|
mv relevant variables definition from ecco_cost.h to ecco.h, |
| 401 |
|
make sure gencost routines only include ecco.h) |
| 402 |
|
- throughout : add missing CCP switches, rm unused variables, |
| 403 |
|
and rm un-necessary CPP switches |
| 404 |
|
- throughout gencost routines : replace modelstartdate with |
| 405 |
|
gencost_startdate when needed |
| 406 |
|
- cost_bp_read.F : use arguments, instead of common blocs |
| 407 |
|
so that it can be used also by (new) cost_gencost_bpv4.F |
| 408 |
|
- ecco_init_varia.F : initialize RHOsumGlob_0, VOLsumGlob_0 |
| 409 |
|
- ecco_phys.F : compute etanFull |
| 410 |
|
- ecco_readparms.F : rename using_topex as using_tpj, add |
| 411 |
|
bpv4-grace to gencost list, initialize added parameters |
| 412 |
|
- ecco_summary.F : include SIZE.h needed for augmented ecco.h |
| 413 |
|
|
| 414 |
|
checkpoint65e (2014/09/28) |
| 415 |
|
o pkg/obcs: |
| 416 |
|
- replaced the just-added CPP options with run-time variables |
| 417 |
|
(see pkg/obcs/OBCS_PARAMS.h for details) |
| 418 |
|
o pkg/obcs: |
| 419 |
|
- add additional CPP options for sponge boundary layers |
| 420 |
|
(see pkg/obcs/OBCS_OPTIONS.h for details) |
| 421 |
|
o pkg/atm_phys: |
| 422 |
|
- implement simple (obliquity only, assuming circular planet orbit) |
| 423 |
|
seasonal cycle for incoming insolation ; used when run-time parameter |
| 424 |
|
"select_incSW" is set to 1 ; by default (=0), uses old unchanged formula. |
| 425 |
|
o pkg/exf, pkg/ecco, pkg/ctrl: |
| 426 |
|
- add ctrlUseGen and .NOT.ctrlUseGen exclusive brackets |
| 427 |
|
- activate gentim2d for xx_atemp,xx_aqh,xx_swdown,xx_lwdown,xx_precip |
| 428 |
|
- implement gentim2d for xx_tauu, xx_tauv |
| 429 |
|
o pkg/ctrl, pkg/ecco : |
| 430 |
|
- fix and complement the generic controls implementation |
| 431 |
|
o pkg/exf/exf_getclim.F, exf_getffields.F, exf_getsurfacefluxes.F, |
| 432 |
|
pkg/shelfice/shelfice_thermodynamics.F, |
| 433 |
|
verification/hs94.1x64x5/code_ad/ctrl_map_gentim2d.F, |
| 434 |
|
verification/hs94.1x64x5/code_oad/ctrl_map_gentim2d.F : |
| 435 |
|
- add weight in CTRL_GET_GEN calls |
| 436 |
|
o pkg/ctrl : |
| 437 |
|
- ctrl_get_gen.F : add weight as input parameter, and apply |
| 438 |
|
it directly rather than using smooth_correl2Dw (to be retired). |
| 439 |
|
- ctrl_map_gentim2d.F : add wgentim2d in CTRL_GET_GEN call |
| 440 |
|
o pkg/ctrl : |
| 441 |
|
- introduce run time switch ctrlUseGen (in ctrl.h, ctrl_check.F, |
| 442 |
|
ctrl_init_variables.F, ctrl_readparms.F, ctrl_summary.F) |
| 443 |
|
- re-activate ctrl_summary (call in ctrl_init.F) |
| 444 |
|
o pkg/ctrl/ctrl_cost_gen.F : |
| 445 |
|
- fix CCP brackets, remove un-necessary myiter, mytime |
| 446 |
|
o pkg/ecco, pkg/ctrl : |
| 447 |
|
- remove cost_genctrl.F (now pkg/ctrl/ctrl_cost_driver.F) |
| 448 |
|
- remove cost_forcing_gen.F (now pkg/ctrl/ctrl_cost_gen2d.F) |
| 449 |
|
- add ctrl_cost_driver.F (replaces pkg/ecco/cost_genctrl.F) |
| 450 |
|
- add ctrl_cost_gen2d.F (replaces pkg/ecco/cost_forcing_gen.F) |
| 451 |
|
|
| 452 |
|
checkpoint65d (2014/09/15) |
| 453 |
|
o pkg/ctrl/CTRL_GENARR.h, ctrl_readparms.F : |
| 454 |
|
- add xx_genarr2d_bounds,xx_genarr3d_bounds, |
| 455 |
|
xx_genarr2d_numsmooth, xx_genarr3d_numsmooth |
| 456 |
|
o pkg/ctrl/ctrl_map_ini_genarr.F : |
| 457 |
|
- remove compilation failure |
| 458 |
|
- replace hard coded example |
| 459 |
|
- use ctrl_map_ini_gen2D, 3D |
| 460 |
|
o pkg/ctrl/ctrl_pack.F, ctrl_unpack.F : |
| 461 |
|
- on/off switch based upon xx_genarr2d_weight,3d |
| 462 |
|
o src/packages_init_variables.F : |
| 463 |
|
- regroup pkg/estimation calls |
| 464 |
|
- remove CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
| 465 |
|
(moved to ctrl_init_variables) |
| 466 |
|
o cost/cost_init_varia.F : |
| 467 |
|
- remove ecco_cost_init_varia |
| 468 |
|
(moved to ecco_init_varia) |
| 469 |
|
o ctrl/ctrl_init_variables.F : |
| 470 |
|
- add CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
| 471 |
|
- add CTRL_MAP_INI_GENARR, SEAICE_CTRL_MAP_INI |
| 472 |
|
o ctrl/ctrl_map_ini.F : |
| 473 |
|
- remove ctrl_map_ini_genarr, seaice_ctrl_map_ini |
| 474 |
|
(moved to ctrl_init_variables) |
| 475 |
|
o ctrl/ctrl_map_ini_ecco.F : |
| 476 |
|
- remove ECCO_PHYS (mv to ecco_init_varia) |
| 477 |
|
- remove seaice_ctrl_map_ini (mv to ctrl_init_variables) |
| 478 |
|
o ecco/ecco_ad_diff.list : |
| 479 |
|
- add ecco_init_varia.f |
| 480 |
|
o ecco/ecco_init_varia.F |
| 481 |
|
- new routine |
| 482 |
|
o pkg/streamice: |
| 483 |
|
- move call to STREAMICE_INITIALIZE_PETSC from the_model_main.F |
| 484 |
|
to streamice_init_fixed.F ; fix setting of STREAMICEisOn. |
| 485 |
|
- from model/src, only call pkg/streamice routines if useStreamIce is TRUE. |
| 486 |
|
o pkg/generic_advdiff: |
| 487 |
|
- fix bug causing negatives in GAD_SMOLARKIEWICZ_HACK, introduced 8/8/2014. |
| 488 |
|
o pkg/exf: |
| 489 |
|
- exf_getffields.F : add xxg_atemp, xxg_aqh, xxg_swdown, xxg_lwdown, |
| 490 |
|
xxg_precip capability |
| 491 |
|
- exf_wind.F : no need for ALLOW_WSPEED_CONTROL cpp switch |
| 492 |
|
o pkg/ctrl: |
| 493 |
|
- ctrl_pack.F, ctrl_unpack.F : omit (un)packing of undefined xx_gentim2d |
| 494 |
|
o model/src/load_fields_driver.F : |
| 495 |
|
- move call to CTRL_MAP_GENTIM2D ahead of BULKF_FIELDS_LOAD, EXF_GETFORCING |
| 496 |
|
so xx_gentim2d can be applied to e.g. exf fields in a timely manner. |
| 497 |
|
o OpenAD verification experiments: |
| 498 |
|
- Include explicitly AUTODIFF_OPTIONS.h, COST_OPTIONS.h, and CTRL_OPTIONS.h |
| 499 |
|
in src files (to enable to skip the ECCO_CPPOPTIONS.h); |
| 500 |
|
for now, only in pkgs used in OpenAD verification experiments. |
| 501 |
|
- Change all except one (halfpipe_streamice) OpenAD experiments to use pkg |
| 502 |
|
specific option file (AUTODIFF_OPTIONS.h, COST_OPTIONS.h & CTRL_OPTIONS.h) |
| 503 |
|
instead of using ECCO_CPPOPTIONS.h (with all relevant options in it). |
| 504 |
|
This applies to both TAF (*/code_ad/) and OpenAD (*/code_oad/) tests. |
| 505 |
|
o OpenAD verification tests: |
| 506 |
|
- finish removing ALLOW_AUTODIFF_OPENAD (replaced by ALLOW_OPENAD); |
| 507 |
|
- finish replacing ALLOW_AUTODIFF_TAMC by ALLOW_AUTODIFF (except for |
| 508 |
|
tape/storage which are specific to TAF/TAMC) in pkgs used in OpenAD exp. |
| 509 |
|
- leave ALLOW_AUTODIFF_TAMC undef in OpenAD verification tests (*/code_oad/) |
| 510 |
|
and remove local copy of "tamc.h" (needed only if ALLOW_AUTODIFF_TAMC). |
| 511 |
|
o model/src & generic_advdiff: |
| 512 |
|
- change hard-coded loop-range in S/R APPLY_FORCING_T/S to set T & S |
| 513 |
|
forcing over 0:sNx+1, 0:sNy=1 (instead of just 1:sNx,1:sNy): Model |
| 514 |
|
dynamics requires valid tracer forcing only over tile interior but, for |
| 515 |
|
some diagnostics, may need to extend it over 1 point in tile halo region. |
| 516 |
|
- in gad_calc_rhs.F, update calls to gmredi_x/ytransport to get valid |
| 517 |
|
tendency over i,j_Min,Max range. This allows to simplfy i,j_Min,Max |
| 518 |
|
setting in temp/salt/ptracer_integrate.F |
| 519 |
|
o pkg/dic: |
| 520 |
|
- multiply tracer tendencies by maskInC (if ussing OBCS) before updating |
| 521 |
|
gchem tracers: this allows to skip the 2nd call to OBCS_APPLY_PTRACER |
| 522 |
|
in gchem_forcing_sep.F |
| 523 |
|
o pkg/autodiff & obcs: |
| 524 |
|
- add storage of current OB values for U & V (was already done for T & S). |
| 525 |
|
|
| 526 |
|
checkpoint65c (2014/08/30) |
| 527 |
|
o pkg/dic: |
| 528 |
|
- take out of dic_atmos.F the initialisation part (corresponding to istate=0) |
| 529 |
|
and move it to new S/R DIC_INI_ATMOS ; also simplify the dependencies for |
| 530 |
|
AD compilers (but still a Pb with multi-threading and Ajoint dependencies). |
| 531 |
|
o verification: |
| 532 |
|
- new experiment testing OBCS and DIC pkgs, using params & output from |
| 533 |
|
tutorial_global_oce_biogeo but limited to a sub-domain around Drake |
| 534 |
|
passage: take OBCS from the last year of a 2 yrs simulation and initial |
| 535 |
|
conditions from t=1.yr while keeping the same forcing. |
| 536 |
|
o model/src: |
| 537 |
|
- when allowFreezing=T, only reset below freezing initial Temp to Tfreezing |
| 538 |
|
(at any k) if checkIniTemp is not set to FALSE (default checkIniTemp=T). |
| 539 |
|
o pkg/diagnostics (Stats-Diags): |
| 540 |
|
- re-write S/R DIAGSTATS_CALC (more similar to TARGET_NEC_SX part) to: |
| 541 |
|
a) refine region where stats are computed, excluding where arrhFac=0 ; |
| 542 |
|
b) fix missing interior mask (use with OBCS) in 3-D fields statistics; |
| 543 |
|
c) extend regional stats over the region edges (for U or V pt location). |
| 544 |
|
o pkg/gchem: |
| 545 |
|
- add a (2nd) call to OBCS_APPLY_PTRACER in gchem_forcing_sep.F (needed since |
| 546 |
|
pkg/dic is currently changing/updating ptracers values beyond the OB). |
| 547 |
|
o verification (hs94): |
| 548 |
|
- convert Held & Suarez external_forcing.F (from hs94.cs, with Sigma-coords |
| 549 |
|
bits) to apply_forcing.F and undef USE_OLD_EXTERNAL_FORCING in experiments |
| 550 |
|
hs94.cs-32x32x5 and tutorial_held_suarez_cs ; also use the same version of |
| 551 |
|
apply_forcing.F in 2D hs94 (fwd, ad & oad) but keep LatLon hs94 unchanged. |
| 552 |
|
o pkg/ptracers: |
| 553 |
|
- implement Adams-Bashforth on pTracers (instead of on tracer tendency), |
| 554 |
|
switched on by setting PTRACERS_doAB_onGpTr=F (default set to doAB_onGtGs) |
| 555 |
|
- change exp4 secondary test (input.nlfs) to test AB on T & S & pTracer |
| 556 |
|
with AB-2 code (so that it get tested). |
| 557 |
|
o model/src: |
| 558 |
|
- allow to apply Adams-Bashforth on Temp & Salt (instead of on gT,gS) |
| 559 |
|
with AB-2 code (previously only available with AB-3 code). |
| 560 |
|
Also move the code (call to ADAMS_BASHFORTH S/R) form thermodynamics.F |
| 561 |
|
to temp/salt_integrate.F (since the 2nd part of gt/sNm1 update is done |
| 562 |
|
there, by calling CYCLE_AB_TRACER). |
| 563 |
|
o pkg/generic_advdiff: |
| 564 |
|
- change Tracer argument (drop bi,bj indices) in S/R GAD_CALC_RHS, |
| 565 |
|
GAD_C2_ADV_R, GAD_U3_ADV_R, GAD_C4_ADV_R, GAD_DIFF_R, GAD_BIHARM_R |
| 566 |
|
+ also in GMREDI_X/Y/RTRANSPORT ; and update corresponding calls in |
| 567 |
|
S/R temp/salt/ptracers_integrate.F |
| 568 |
|
o model/src & pkg/ptracers: |
| 569 |
|
- remove common block variables gT,gS (in DYNVARS.h), except when |
| 570 |
|
USE_OLD_EXTERNAL_FORCING is defined; update TAF storage accordingly. |
| 571 |
|
- remove common block variable gPtr. |
| 572 |
|
o model/src & pkgs: |
| 573 |
|
- change gTracer (and/or tracer) argument (drop bi,bj indices) in S/R |
| 574 |
|
ADAMS_BASHFORTH(2&3), CYCLE_(AB_)TRACER, FREESURF_RESCALE_G, |
| 575 |
|
IMPLDIFF, SOLVE_TRIDIAGONAL & _PENTADIAGONAL, GAD_SOM_ADVECT, |
| 576 |
|
GAD_ADVECTION, GAD_CALC_RHS, GAD_IMPLICIT_R, TIMEAVE_CUMUL_DIF_1T |
| 577 |
|
+ change accordingly all calling S/R. |
| 578 |
|
- use local temperature/salinity/ptracer tendency array (without bi,bj) |
| 579 |
|
in S/R temp/salt/ptracers_integrate.F |
| 580 |
|
o pkg/seaice: |
| 581 |
|
- move computation of stress contributions to rhsU/V in s/r seaice_lsr |
| 582 |
|
to separate s/r seaice_lsr_rhsu/v in order to be able to re-use code |
| 583 |
|
- make u/vIceC local variables if SEAICE_CGRID is defined only to be used |
| 584 |
|
in seaice_lsr |
| 585 |
|
- seaice_lsr.F: make local 4D arrays UXX, VYY, etc 2D |
| 586 |
|
in s/r seaice_lsr_calc_coeffs |
| 587 |
|
o pkg/mdsio: |
| 588 |
|
- in MDS_READ/WRITE_FIELD, stop if file-name (+prefix) is too long |
| 589 |
|
(e.g., > MAX_LEN_MBUF -90 ) or, in INI_MODEL_IO, if mdsioLocalDir is |
| 590 |
|
too long (e.g., > MAX_LEN_FNAM/2 ) |
| 591 |
|
|
| 592 |
|
checkpoint65b (2014/08/12) |
| 593 |
|
o pkg/matrix: |
| 594 |
|
- pass, as argument, updated tracer field to S/R MATRIX_STORE_TENDENCY_EXP |
| 595 |
|
o model/src: |
| 596 |
|
- fix initialisation of geothermalFile; compile geothermal-flux code in |
| 597 |
|
natl_box verification experiment. |
| 598 |
|
o model/src & pkg/down_slope: |
| 599 |
|
- push the k loop inside S/R TIMESTEP_TRACER (now called outside the k loop). |
| 600 |
|
- in dwnslp_apply.F, update tracer tendency instead of the future tracer |
| 601 |
|
field and call S/R DWNSLP_APPLY before TIMESTEP_TRACER; this affects |
| 602 |
|
results at machine truncation level: update output of experiments |
| 603 |
|
global_ocean.90x40x15.dwnslp (FWD) and lab_sea.noseaicedyn (AD). |
| 604 |
|
o pkg/diagnostics (Stats-Diags): |
| 605 |
|
- do not cumulate the full volume when DIAGNOSTICS_FILL is |
| 606 |
|
called with bibjFlg < 0 (no increment of the counter for 2D/3D diag); |
| 607 |
|
This fix the mean statistics when DIAGNOSTICS_FILL is called multiple |
| 608 |
|
times (but Min,Max and StD are still wrong). |
| 609 |
|
o model/src: |
| 610 |
|
- add geothermal flux forcing: read in ini_forcing.F as time-constant |
| 611 |
|
field "geothermalFlux" applied in S/R APPLY_FORCING_T (apply_forcing.F) |
| 612 |
|
o model/src: |
| 613 |
|
- move CYCLE_TRACER calls from tracers_correction_step.F to temp/salt/ptracer |
| 614 |
|
_integrate.F so that, when leaving S/R THERMODYANMICS, theta,salt and pTrac |
| 615 |
|
arrays are already updated while adjustments (filters, conv.adjustment) are |
| 616 |
|
still applied later, in S/R TRACERS_CORRECTION_STEP. |
| 617 |
|
o model/src: |
| 618 |
|
- store in common bloc array "rhoInSitu" the virtual potential temperature |
| 619 |
|
anomaly that is used to compute geopotential: this make the atmos code |
| 620 |
|
more similar to ocean code which already uses rhoInSitu in calc_phi_hyd.F |
| 621 |
|
o pkg/seaice/seaice_lsr.F |
| 622 |
|
- rename integer variable ilcall to ipass (that's what it is called |
| 623 |
|
in the residual diagnostics |
| 624 |
|
- change time stepping for NPSEUDOTIMESTEP > 2 (does not change the |
| 625 |
|
default) for improved non-linear convergence of the first few steps |
| 626 |
|
- adjust a few comments and add new ones to explain some of the store |
| 627 |
|
directives |
| 628 |
|
o pkg/generic_advdiff (& ptracers): |
| 629 |
|
- re-work the code to check for valid advection scheme and for minimum |
| 630 |
|
size of overlap (now stored in local common bloc in gad_advscheme.F) |
| 631 |
|
o pkg/seaice: another attempt to make the adjoint work for sea ice dynamics |
| 632 |
|
- re-initialize more variables in seaice_lsr: u/vIceC, u/vIceNm1 |
| 633 |
|
- add an auxilliary variable "bet" and fix store directives and keys in |
| 634 |
|
seaice_lsr_tridiagu/v, this seems to do the trick (i.e. more or |
| 635 |
|
less exact gradients in my tests); but there are still |
| 636 |
|
recomputation warning (although gradients are sort of OK), when |
| 637 |
|
SEAICE_LSR_VECTORIZE is not defined, so this flag and |
| 638 |
|
SEAICE_LSR_VECTORIZE_ZEBRA are recommended for efficiency. |
| 639 |
|
- update verification experiments lab_sea. |
| 640 |
|
- change some comments in S/R seaice_calc_viscosities |
| 641 |
|
o model/src: |
| 642 |
|
- if staggerTimeStep=T, always apply exchange to velocity field in |
| 643 |
|
do_stagger_fields_exchanges.F instead of in do_fields_blocking_exchanges.F |
| 644 |
|
(independent of using multi-dim advection or not); no effect on FWD run |
| 645 |
|
but affects AD results (at machine truncation level): update output of |
| 646 |
|
experiment 1D_ocean_ice_column (ad: 12 digits), hs94.1x64x5 (ad,oad: 13.d) |
| 647 |
|
and isomip (oad: 12.d). |
| 648 |
|
o pkg/generic_advdiff: |
| 649 |
|
- stop if doAB_onGtGs is set to FALSE but ignored |
| 650 |
|
- refine warning related to stability of tracer time-stepping |
| 651 |
|
regarding internal wave dynamics. |
| 652 |
|
- setting of AdamsBashforth_T,S when doAB_onGtGs=F: remove condition |
| 653 |
|
on staggerTimeStep & implicitIntGravWave (will now get a warning |
| 654 |
|
if potentially unstable). |
| 655 |
|
o pkg/kl10: |
| 656 |
|
- add new pkg "kl10" for mixing due to internal wave breaking, from |
| 657 |
|
http://www.sciencedirect.com/science/article/pii/S1463500310000144 |
| 658 |
|
(contribution from Jody Klymak), tested in verification experiment |
| 659 |
|
verification/internal_wave/input.kl10/ |
| 660 |
|
o isomip experiment: |
| 661 |
|
- test pkg/shelfice with Non-Lin Free-Surf in one of the FWD set-up |
| 662 |
|
(input.htd) and update the output. |
| 663 |
|
o cd_code experiments: |
| 664 |
|
- use default cd_code options (#undef CD_CODE_NO_AB_MOMENTUM & |
| 665 |
|
#undef CD_CODE_NO_AB_CORIOLIS) in experiments: cfc_example (fwd) |
| 666 |
|
global_ocean.90x40x15 (ad & oad) and OpenAD (ad & oad) and |
| 667 |
|
update the corresponding output. |
| 668 |
|
o pkg/seaice: |
| 669 |
|
- reduce the number of include files and store directives in |
| 670 |
|
S/R seaice_lsr_tridiagu/v |
| 671 |
|
- change the order of loops in one case in S/R seaice_lsr_tridiagv |
| 672 |
|
(only for SEAICE_VECTORIZE_LSR_ZEBRA defined), which allows me to |
| 673 |
|
get rid off one store directive (a TAF bug?) |
| 674 |
|
- add one more instance of ifdef SEAICE_VECTORIZE_LSR_ZEBRA in |
| 675 |
|
S/R seaice_lsr_tridiagv to change the loop range for consistency |
| 676 |
|
- remove ilcall, m from parameter list of S/R seaice_lsr_tridiagu/v |
| 677 |
|
- fix a bug that affects the JFNK solver: replace sNx/y by i/jMax in |
| 678 |
|
S/R seaice_lsr_tridiagu/v (requires update of |
| 679 |
|
offline_exf_seaice/input.dyn_jfnk) |
| 680 |
|
|
| 681 |
|
checkpoint65a (2014/07/27) |
| 682 |
|
o model/src: |
| 683 |
|
- Non-Lin Free-Surf in p/z coords: allows hFacW,S to be larger than |
| 684 |
|
surrounding hFacC=1 @ edge of a step with different kSurfC on either side |
| 685 |
|
(topo in p-coords, ice-shelf in z-coords); update output of experiments |
| 686 |
|
tutorial_global_oce_in_p and isomip (both AD and OpenAD output). |
| 687 |
|
o model/src: |
| 688 |
|
- collect momentum forcing tendency into local 2-D array (passed as argument |
| 689 |
|
to apply_forcing S/R); this simplifies mom. Forcing diagnostics and CD_CODE |
| 690 |
|
parts in timestep.F (without CD_CODE_NO_AB_MOMENTUM defined = the default); |
| 691 |
|
affects results at machine truncation level (e.g., if using OBCS_SPONGE). |
| 692 |
|
- collect T & S forcing tendency into local 2-D array (passed as argument to |
| 693 |
|
apply_forcing S/R); add 3-D diagnostics for temp & salt forcing tendency. |
| 694 |
|
affects results at machine truncation level (e.g., ocean: if using |
| 695 |
|
SHORTWAVE_HEATING ; atmos: if using FrictionHeating or (atm_Rq<>0) moist |
| 696 |
|
correction due to vertical advection). |
| 697 |
|
- update output of experiments: fizhi-cs-32x32x40 (13 digits), |
| 698 |
|
global_ocean.cs32x15 (fwd: icedyn, seaice, thsice, all 3 @ 11d; adm & tml: |
| 699 |
|
seaice_dynmix & thsice, fwd grd @ 3 & 8), hs94.1x64x5 (ad grd @ 13), |
| 700 |
|
obcs_ctrl (ad & fwd grd @ 12 & 7). |
| 701 |
|
o pkg/ptracers & diagnostics: |
| 702 |
|
- use ptracers (short) name (instead of long one) to make ptracers diagnostics |
| 703 |
|
title (to avoid some unexpected truncation); sort out ptracers diags units. |
| 704 |
|
- collect ptracer forcing tendency into local 2-D array (passed as argument |
| 705 |
|
to apply_forcing S/R); add 3-D diagnostics for ptracers forcing tendency. |
| 706 |
|
|
| 707 |
|
checkpoint65 (2014/07/18) |
| 708 |
|
o pkg/fizhi: |
| 709 |
|
- add parenthesis around fizhi tendencies in fizhi_tendency_apply.F: this |
| 710 |
|
affects results at machine truncation level. Update output of experiments |
| 711 |
|
fizhi-cs-32x32x40 (12 digits for cg2d) & fizhi-cs-aqualev20 (13 digits). |
| 712 |
|
o pkg/seaice: more clean up |
| 713 |
|
- rename TAF common block tapes to be more consistent and remove |
| 714 |
|
unnecessary duplicates |
| 715 |
|
- add store directives to remove more recomputations, but use smaller |
| 716 |
|
tapes (and adjust keys) when SEAICE_LSR_ADJOINT_ITER is undefined. |
| 717 |
|
The idea behind this flag is to reduce the memory footprint when the |
| 718 |
|
adjoint of the LSR is not required. As of now, defining the flag |
| 719 |
|
SEAICE_LSR_ADJOINT_ITER increases 4 common block tapes for 2D field by |
| 720 |
|
a factor of SOLV_MAX_FIXED (=500 by default in SEAICE_SIZE.h). |
| 721 |
|
For experiment offline_exf_seaice, this means on a linux box with gfortran |
| 722 |
|
nearly a factor of 10 (but keep in mind there is mostly seaice code in |
| 723 |
|
this experiment): |
| 724 |
|
> size mitgcmuv_ad |
| 725 |
|
text data bss dec hex |
| 726 |
|
5100659 1216 220458952 225560827 d71c8fb |
| 727 |
|
5339425 1200 1868783272 1874123897 6fb4dc79 (SEAICE_LSR_ADJOINT_ITER) |
| 728 |
|
but only a moderate increase of 36% for global_ocean.cs32x15: |
| 729 |
|
text data bss dec hex |
| 730 |
|
6695027 1648 1014578664 1021275339 3cdf6ccb |
| 731 |
|
6695203 1648 1382505320 1389202171 52cd8afb (SEAICE_LSR_ADJOINT_ITER) |
| 732 |
|
- note: there are still recomputations in global_ocean.cs32x15 and |
| 733 |
|
offline_exf_seaice and the gradient agreement changes (gets a |
| 734 |
|
little worse) for global_ocean.cs32x15 (-> update output_adm.seaice.txt) |
| 735 |
|
- in general, the AD gradients still are wrong |
| 736 |
|
o OpenAD |
| 737 |
|
- clean up code_oad/ directories somewhat by moving files |
| 738 |
|
dontCompile, dontTransform, keepOriginal to OAD_support/ |
| 739 |
|
o model/src: |
| 740 |
|
- using MOM fluxform and Non-Lin Free-Surf with momDissip_In_AB=F |
| 741 |
|
(not currently tested): add dissipation terms before NLFS rescaling of |
| 742 |
|
tendencies (previously done after). |
| 743 |
|
o pkg/diagnostics: |
| 744 |
|
- write stats-diags in ascii file with more digits (same as in monitor). |
| 745 |
|
o pkg/down_slope: |
| 746 |
|
- drop the bi,bj dimension of argument recip_hFac in S/R DWNSLP_APPLY; with |
| 747 |
|
NLFS (not tested), use new recip_hFac value in order to conserve tracer. |
| 748 |
|
o model/src: |
| 749 |
|
- new file "apply_forcing.F" containing all the code previously in |
| 750 |
|
external_forcing.F, but with new argument list: pass, as new argument, |
| 751 |
|
the current level tendency array to update (instead of a direct update |
| 752 |
|
of the common bloc array). Change the corresponding calls. |
| 753 |
|
- add CPP option USE_OLD_EXTERNAL_FORCING (default is undef) to use |
| 754 |
|
EXTERNAL_FORCING_U,V,T,S subroutines (for backward compatibility). |
| 755 |
|
o pkg/seaice/seaice_lsr, a little bit of clean up |
| 756 |
|
- rearrange some code blocks, so that now all calculations for |
| 757 |
|
setting up the right-hand-sides done within one single block |
| 758 |
|
(I find that easier to read and understand) |
| 759 |
|
- rearrange freedrift-code to reduce the number of ifdefs |
| 760 |
|
- adjust some indentations and comments |
| 761 |
|
|
| 762 |
|
checkpoint64z (2014/07/10) |
| 763 |
|
o model/src and several pkgs: |
| 764 |
|
- change argument list of all S/R called from external_forcing.F and |
| 765 |
|
called from ptracers_forcing.F (renamed to ptracers_apply_forcing.F) |
| 766 |
|
to pass, as argument, the current level tendency array to update |
| 767 |
|
(instead of a direct update of the common bloc array). |
| 768 |
|
- change also (in the same way) argument list of PTRACERS_APPLY_FORCING; |
| 769 |
|
- rename taueddy_external_forcing.f to taueddy_tendency_apply.F |
| 770 |
|
o pkg/seaice/seaice_lsr.F |
| 771 |
|
- always initialize local arrays in seaice_lsr_tridiagu/v |
| 772 |
|
- add more local tapes to seaice_lsr_tridiagu/v |
| 773 |
|
- move storing u/vice(:,:,bi,bj) out of seaice_lsr_tridiagu/v, but |
| 774 |
|
keep it in bi/bj loop; this seems to be essential |
| 775 |
|
- gradients are still wrong but only by 4-7 orders of magnitude |
| 776 |
|
instead of 15 orders of magnitude, lab_sea improves a little |
| 777 |
|
o pkg/seaice |
| 778 |
|
- (pkg/autodiff) remove storing/restoring of seaiceMaskU/V that |
| 779 |
|
generates unnecessary code in seaice_lsr_ad |
| 780 |
|
- add more store directives in seaice_lsr to avoid unnecessary code |
| 781 |
|
in seaice_lsr_ad |
| 782 |
|
- exclude some residual computations in seaice_lsr when |
| 783 |
|
ALLOW_AUTODIFF_TAMC is defined in order to avoid unnecessary code |
| 784 |
|
in seaice_lsr_ad |
| 785 |
|
- add more storing, a new tape (model/src/the_main_loop.F) and |
| 786 |
|
another key for SEAICE_LSR_VECTORIZE_ZEBRA (the local keys ilockey |
| 787 |
|
and klockey should be checked by a specialist) |
| 788 |
|
- modify ( define SEAICE_VECTORIZE_LSR and SEAICE_LSR_ADJOINT_ITER ) |
| 789 |
|
and update lab_sea after previous changes in pkg/seaice below |
| 790 |
|
o pkg/autodiff: |
| 791 |
|
- introduce useSmoothCorrel2DinAdMode, SEAICEapproxLevInAd, and |
| 792 |
|
viscFacInAd : run time parameters allowing for adjoint switches |
| 793 |
|
note : logic for useSmoothCorrel2DinAdMode is in ctrl_readparms.F |
| 794 |
|
o pkg/ecco: |
| 795 |
|
- introduce cost_gencost_boxmean.F that computes a box mean |
| 796 |
|
temperature (for use in adjoint sensitivity studies). |
| 797 |
|
o model/src/set_defaults.F : initialize viscFacAdj to 1. |
| 798 |
|
o pkg/mom_common/mom_calc_visc.F: |
| 799 |
|
- ifdef ALLOW_AUTODIFF then include viscFacAdj factor. |
| 800 |
|
o pkg/seaice/seaice_summary.F: |
| 801 |
|
- statement for SEAICEadjMODE now in autodiff_readparms.F |
| 802 |
|
o pkg/seaice: |
| 803 |
|
- remove some store directives and add new ones in an effort to get |
| 804 |
|
finally rid off the recomputation warnings. This is successful |
| 805 |
|
when SEAICE_VECTORIZE_LSR ***and*** SEAICE_LSR_ADJOINT_ITER are |
| 806 |
|
defined (i.e. no extensive recomputation warnings left), but there |
| 807 |
|
are still too many recomputations on the solver iteration level |
| 808 |
|
- define SEAICE_VECTORISZE_LSR in offline_exf_seaice/code_ad/SEAICE_OPTIONS.h |
| 809 |
|
- move definition of MPSEUDOTIMESTEPS into TAMC-block in |
| 810 |
|
SEAICE_SIZE.h |
| 811 |
|
- add a store directive in S/R seaice_calc_viscosities |
| 812 |
|
o pkg/seaice (ITD code): |
| 813 |
|
- fix definition of Hlimit for multi-threaded case |
| 814 |
|
- use double precision arithmetic to compute Hlimit: this affects results; |
| 815 |
|
update output of experiment seaice_itd. |
| 816 |
o replace content of verification/seaice_itd |
o replace content of verification/seaice_itd |
| 817 |
- instead of a 1D column use the configuration of offline_exf_seaice |
- instead of a 1D column use the configuration of offline_exf_seaice |
| 818 |
to test the ice thickness distribution code with ridging |
to test the ice thickness distribution code with ridging |
| 819 |
- this is a first shot at this experiment |
- this is a first shot at this experiment |
| 820 |
- change of some defaults of ridging parameters SEAICEhStar (from |
- change of some defaults of ridging parameters SEAICEhStar (from |
| 821 |
100 to 25) and SEAICEmuRidging (from 5 to 3) in seaice_readparms.F |
100 to 25) and SEAICEmuRidging (from 5 to 3) in seaice_readparms.F |
| 822 |
and lost of new comments |
and lot of new comments. |
| 823 |
|
|
| 824 |
checkpoint64y (2014/06/20) |
checkpoint64y (2014/06/20) |
| 825 |
o pkg/seaice/seaice_reg_ridge.F: |
o pkg/seaice/seaice_reg_ridge.F: |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch