4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
5 |
============================== |
============================== |
6 |
|
|
7 |
|
o pkg/ctrl/CTRL_GENARR.h, ctrl_readparms.F : |
8 |
|
- add xx_genarr2d_bounds,xx_genarr3d_bounds, |
9 |
|
xx_genarr2d_numsmooth, xx_genarr3d_numsmooth |
10 |
|
o pkg/ctrl/ctrl_map_ini_genarr.F : |
11 |
|
- remove compilation failure |
12 |
|
- replace hard coded example |
13 |
|
- use ctrl_map_ini_gen2D, 3D |
14 |
|
o pkg/ctrl/ctrl_pack.F, ctrl_unpack.F : |
15 |
|
- on/off switch based upon xx_genarr2d_weight,3d |
16 |
|
o src/packages_init_variables.F : |
17 |
|
- regroup pkg/estimation calls |
18 |
|
- remove CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
19 |
|
(moved to ctrl_init_variables) |
20 |
|
o cost/cost_init_varia.F : |
21 |
|
- remove ecco_cost_init_varia |
22 |
|
(moved to ecco_init_varia) |
23 |
|
o ctrl/ctrl_init_variables.F : |
24 |
|
- add CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
25 |
|
- add CTRL_MAP_INI_GENARR, SEAICE_CTRL_MAP_INI |
26 |
|
o ctrl/ctrl_map_ini.F : |
27 |
|
- remove ctrl_map_ini_genarr, seaice_ctrl_map_ini |
28 |
|
(moved to ctrl_init_variables) |
29 |
|
o ctrl/ctrl_map_ini_ecco.F : |
30 |
|
- remove ECCO_PHYS (mv to ecco_init_varia) |
31 |
|
- remove seaice_ctrl_map_ini (mv to ctrl_init_variables) |
32 |
|
o ecco/ecco_ad_diff.list : |
33 |
|
- add ecco_init_varia.f |
34 |
|
o ecco/ecco_init_varia.F |
35 |
|
- new routine |
36 |
|
o pkg/streamice: |
37 |
|
- move call to STREAMICE_INITIALIZE_PETSC from the_model_main.F |
38 |
|
to streamice_init_fixed.F ; fix setting of STREAMICEisOn. |
39 |
|
- from model/src, only call pkg/streamice routines if useStreamIce is TRUE. |
40 |
|
o pkg/generic_advdiff: |
41 |
|
- fix bug causing negatives in GAD_SMOLARKIEWICZ_HACK, introduced 8/8/2014. |
42 |
|
o pkg/exf: |
43 |
|
- exf_getffields.F : add xxg_atemp, xxg_aqh, xxg_swdown, xxg_lwdown, |
44 |
|
xxg_precip capability |
45 |
|
- exf_wind.F : no need for ALLOW_WSPEED_CONTROL cpp switch |
46 |
|
o pkg/ctrl: |
47 |
|
- ctrl_pack.F, ctrl_unpack.F : omit (un)packing of undefined xx_gentim2d |
48 |
|
o model/src/load_fields_driver.F : |
49 |
|
- move call to CTRL_MAP_GENTIM2D ahead of BULKF_FIELDS_LOAD, EXF_GETFORCING |
50 |
|
so xx_gentim2d can be applied to e.g. exf fields in a timely manner. |
51 |
|
o OpenAD verification experiments: |
52 |
|
- Include explicitly AUTODIFF_OPTIONS.h, COST_OPTIONS.h, and CTRL_OPTIONS.h |
53 |
|
in src files (to enable to skip the ECCO_CPPOPTIONS.h); |
54 |
|
for now, only in pkgs used in OpenAD verification experiments. |
55 |
|
- Change all except one (halfpipe_streamice) OpenAD experiments to use pkg |
56 |
|
specific option file (AUTODIFF_OPTIONS.h, COST_OPTIONS.h & CTRL_OPTIONS.h) |
57 |
|
instead of using ECCO_CPPOPTIONS.h (with all relevant options in it). |
58 |
|
This applies to both TAF (*/code_ad/) and OpenAD (*/code_oad/) tests. |
59 |
|
o OpenAD verification tests: |
60 |
|
- finish removing ALLOW_AUTODIFF_OPENAD (replaced by ALLOW_OPENAD); |
61 |
|
- finish replacing ALLOW_AUTODIFF_TAMC by ALLOW_AUTODIFF (except for |
62 |
|
tape/storage which are specific to TAF/TAMC) in pkgs used in OpenAD exp. |
63 |
|
- leave ALLOW_AUTODIFF_TAMC undef in OpenAD verification tests (*/code_oad/) |
64 |
|
and remove local copy of "tamc.h" (needed only if ALLOW_AUTODIFF_TAMC). |
65 |
|
o model/src & generic_advdiff: |
66 |
|
- change hard-coded loop-range in S/R APPLY_FORCING_T/S to set T & S |
67 |
|
forcing over 0:sNx+1, 0:sNy=1 (instead of just 1:sNx,1:sNy): Model |
68 |
|
dynamics requires valid tracer forcing only over tile interior but, for |
69 |
|
some diagnostics, may need to extend it over 1 point in tile halo region. |
70 |
|
- in gad_calc_rhs.F, update calls to gmredi_x/ytransport to get valid |
71 |
|
tendency over i,j_Min,Max range. This allows to simplfy i,j_Min,Max |
72 |
|
setting in temp/salt/ptracer_integrate.F |
73 |
|
o pkg/dic: |
74 |
|
- multiply tracer tendencies by maskInC (if ussing OBCS) before updating |
75 |
|
gchem tracers: this allows to skip the 2nd call to OBCS_APPLY_PTRACER |
76 |
|
in gchem_forcing_sep.F |
77 |
|
o pkg/autodiff & obcs: |
78 |
|
- add storage of current OB values for U & V (was already done for T & S). |
79 |
|
|
80 |
|
checkpoint65c (2014/08/30) |
81 |
|
o pkg/dic: |
82 |
|
- take out of dic_atmos.F the initialisation part (corresponding to istate=0) |
83 |
|
and move it to new S/R DIC_INI_ATMOS ; also simplify the dependencies for |
84 |
|
AD compilers (but still a Pb with multi-threading and Ajoint dependencies). |
85 |
|
o verification: |
86 |
|
- new experiment testing OBCS and DIC pkgs, using params & output from |
87 |
|
tutorial_global_oce_biogeo but limited to a sub-domain around Drake |
88 |
|
passage: take OBCS from the last year of a 2 yrs simulation and initial |
89 |
|
conditions from t=1.yr while keeping the same forcing. |
90 |
|
o model/src: |
91 |
|
- when allowFreezing=T, only reset below freezing initial Temp to Tfreezing |
92 |
|
(at any k) if checkIniTemp is not set to FALSE (default checkIniTemp=T). |
93 |
|
o pkg/diagnostics (Stats-Diags): |
94 |
|
- re-write S/R DIAGSTATS_CALC (more similar to TARGET_NEC_SX part) to: |
95 |
|
a) refine region where stats are computed, excluding where arrhFac=0 ; |
96 |
|
b) fix missing interior mask (use with OBCS) in 3-D fields statistics; |
97 |
|
c) extend regional stats over the region edges (for U or V pt location). |
98 |
|
o pkg/gchem: |
99 |
|
- add a (2nd) call to OBCS_APPLY_PTRACER in gchem_forcing_sep.F (needed since |
100 |
|
pkg/dic is currently changing/updating ptracers values beyond the OB). |
101 |
|
o verification (hs94): |
102 |
|
- convert Held & Suarez external_forcing.F (from hs94.cs, with Sigma-coords |
103 |
|
bits) to apply_forcing.F and undef USE_OLD_EXTERNAL_FORCING in experiments |
104 |
|
hs94.cs-32x32x5 and tutorial_held_suarez_cs ; also use the same version of |
105 |
|
apply_forcing.F in 2D hs94 (fwd, ad & oad) but keep LatLon hs94 unchanged. |
106 |
|
o pkg/ptracers: |
107 |
|
- implement Adams-Bashforth on pTracers (instead of on tracer tendency), |
108 |
|
switched on by setting PTRACERS_doAB_onGpTr=F (default set to doAB_onGtGs) |
109 |
|
- change exp4 secondary test (input.nlfs) to test AB on T & S & pTracer |
110 |
|
with AB-2 code (so that it get tested). |
111 |
|
o model/src: |
112 |
|
- allow to apply Adams-Bashforth on Temp & Salt (instead of on gT,gS) |
113 |
|
with AB-2 code (previously only available with AB-3 code). |
114 |
|
Also move the code (call to ADAMS_BASHFORTH S/R) form thermodynamics.F |
115 |
|
to temp/salt_integrate.F (since the 2nd part of gt/sNm1 update is done |
116 |
|
there, by calling CYCLE_AB_TRACER). |
117 |
|
o pkg/generic_advdiff: |
118 |
|
- change Tracer argument (drop bi,bj indices) in S/R GAD_CALC_RHS, |
119 |
|
GAD_C2_ADV_R, GAD_U3_ADV_R, GAD_C4_ADV_R, GAD_DIFF_R, GAD_BIHARM_R |
120 |
|
+ also in GMREDI_X/Y/RTRANSPORT ; and update corresponding calls in |
121 |
|
S/R temp/salt/ptracers_integrate.F |
122 |
|
o model/src & pkg/ptracers: |
123 |
|
- remove common block variables gT,gS (in DYNVARS.h), except when |
124 |
|
USE_OLD_EXTERNAL_FORCING is defined; update TAF storage accordingly. |
125 |
|
- remove common block variable gPtr. |
126 |
|
o model/src & pkgs: |
127 |
|
- change gTracer (and/or tracer) argument (drop bi,bj indices) in S/R |
128 |
|
ADAMS_BASHFORTH(2&3), CYCLE_(AB_)TRACER, FREESURF_RESCALE_G, |
129 |
|
IMPLDIFF, SOLVE_TRIDIAGONAL & _PENTADIAGONAL, GAD_SOM_ADVECT, |
130 |
|
GAD_ADVECTION, GAD_CALC_RHS, GAD_IMPLICIT_R, TIMEAVE_CUMUL_DIF_1T |
131 |
|
+ change accordingly all calling S/R. |
132 |
|
- use local temperature/salinity/ptracer tendency array (without bi,bj) |
133 |
|
in S/R temp/salt/ptracers_integrate.F |
134 |
|
o pkg/seaice: |
135 |
|
- move computation of stress contributions to rhsU/V in s/r seaice_lsr |
136 |
|
to separate s/r seaice_lsr_rhsu/v in order to be able to re-use code |
137 |
|
- make u/vIceC local variables if SEAICE_CGRID is defined only to be used |
138 |
|
in seaice_lsr |
139 |
|
- seaice_lsr.F: make local 4D arrays UXX, VYY, etc 2D |
140 |
|
in s/r seaice_lsr_calc_coeffs |
141 |
|
o pkg/mdsio: |
142 |
|
- in MDS_READ/WRITE_FIELD, stop if file-name (+prefix) is too long |
143 |
|
(e.g., > MAX_LEN_MBUF -90 ) or, in INI_MODEL_IO, if mdsioLocalDir is |
144 |
|
too long (e.g., > MAX_LEN_FNAM/2 ) |
145 |
|
|
146 |
|
checkpoint65b (2014/08/12) |
147 |
|
o pkg/matrix: |
148 |
|
- pass, as argument, updated tracer field to S/R MATRIX_STORE_TENDENCY_EXP |
149 |
|
o model/src: |
150 |
|
- fix initialisation of geothermalFile; compile geothermal-flux code in |
151 |
|
natl_box verification experiment. |
152 |
|
o model/src & pkg/down_slope: |
153 |
|
- push the k loop inside S/R TIMESTEP_TRACER (now called outside the k loop). |
154 |
|
- in dwnslp_apply.F, update tracer tendency instead of the future tracer |
155 |
|
field and call S/R DWNSLP_APPLY before TIMESTEP_TRACER; this affects |
156 |
|
results at machine truncation level: update output of experiments |
157 |
|
global_ocean.90x40x15.dwnslp (FWD) and lab_sea.noseaicedyn (AD). |
158 |
|
o pkg/diagnostics (Stats-Diags): |
159 |
|
- do not cumulate the full volume when DIAGNOSTICS_FILL is |
160 |
|
called with bibjFlg < 0 (no increment of the counter for 2D/3D diag); |
161 |
|
This fix the mean statistics when DIAGNOSTICS_FILL is called multiple |
162 |
|
times (but Min,Max and StD are still wrong). |
163 |
|
o model/src: |
164 |
|
- add geothermal flux forcing: read in ini_forcing.F as time-constant |
165 |
|
field "geothermalFlux" applied in S/R APPLY_FORCING_T (apply_forcing.F) |
166 |
|
o model/src: |
167 |
|
- move CYCLE_TRACER calls from tracers_correction_step.F to temp/salt/ptracer |
168 |
|
_integrate.F so that, when leaving S/R THERMODYANMICS, theta,salt and pTrac |
169 |
|
arrays are already updated while adjustments (filters, conv.adjustment) are |
170 |
|
still applied later, in S/R TRACERS_CORRECTION_STEP. |
171 |
o model/src: |
o model/src: |
172 |
- store in common bloc array "rhoInSitu" the virtual potential temperature |
- store in common bloc array "rhoInSitu" the virtual potential temperature |
173 |
anomaly that is used to compute geopotential: this make the atmos code |
anomaly that is used to compute geopotential: this make the atmos code |
246 |
- collect T & S forcing tendency into local 2-D array (passed as argument to |
- collect T & S forcing tendency into local 2-D array (passed as argument to |
247 |
apply_forcing S/R); add 3-D diagnostics for temp & salt forcing tendency. |
apply_forcing S/R); add 3-D diagnostics for temp & salt forcing tendency. |
248 |
affects results at machine truncation level (e.g., ocean: if using |
affects results at machine truncation level (e.g., ocean: if using |
249 |
SHORTWAVE_HEATING and atmos:, if using FrictionHeating or (atm_Rq<>0) |
SHORTWAVE_HEATING ; atmos: if using FrictionHeating or (atm_Rq<>0) moist |
250 |
moist correction due to vertical advection). |
correction due to vertical advection). |
251 |
- update output of experiments: fizhi-cs-32x32x40 (13 digits), |
- update output of experiments: fizhi-cs-32x32x40 (13 digits), |
252 |
global_ocean.cs32x15 (fwd: icedyn, seaice, thsice, all 3 @ 11d; adm & tml: |
global_ocean.cs32x15 (fwd: icedyn, seaice, thsice, all 3 @ 11d; adm & tml: |
253 |
seaice_dynmix & thsice, fwd grd @ 3 & 8), hs94.1x64x5 (ad grd @ 13), |
seaice_dynmix & thsice, fwd grd @ 3 & 8), hs94.1x64x5 (ad grd @ 13), |