4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
5 |
============================== |
============================== |
6 |
|
|
7 |
o pkg/seaice: remove (almost) all divisions by constants within loops |
o pkg/shelfice |
8 |
in seaice_growth.F and seaice_solve4temp.F |
- improve computation of friction velocity for velocity dependent |
9 |
o pkg/seaice : |
exchange coefficients: include velocities into SHELFICEBoundaryLayer |
10 |
- simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula.EQ. |
block to average velocities vertically |
11 |
1 or 2, using newly added run time parameter SEAICE_availHeatTaper. |
- add TAF store directives for SHI_ALLOW_GAMMAFRICT |
12 |
|
o Modify diagonal solvers, now three versions (upon request): |
13 |
|
#ifndef SOLVE_DIAGONAL_AUTODIFF |
14 |
|
1. default version (dating back a while ago) |
15 |
|
#else /* def SOLVE_DIAGONAL_AUTODIFF */ |
16 |
|
# ifdef SOLVE_DIAGONAL_KINNER |
17 |
|
2. adjoinable version with k-innermost loop (G. Forget) |
18 |
|
# else |
19 |
|
3. adjoinable vectorized version of 2. |
20 |
|
# endif |
21 |
|
#endif /* SOLVE_DIAGONAL_AUTODIFF */ |
22 |
|
All flags are currently set within routines, but could/should be moved to CPP-options. |
23 |
|
Array bounds for 1. are as before, for 2.,3. cover the entire domain |
24 |
|
(could be changed for 1. too). |
25 |
|
o verification/lab_sea (fwd): |
26 |
|
- update the 4 fwd lab_sea test experiment: no longer SEAICE_GROWTH_LEGACY, |
27 |
|
use 7 categories (except hb87), new solve4temp params (except salt_plume), |
28 |
|
constant salinity (=4) or variable salinity (salt_plume) done through |
29 |
|
SItracer. |
30 |
|
o pkg/seaice: |
31 |
|
- rename parameters: SIsalFrac to SEAICE_saltFrac & SIsal0 to SEAICE_salt0; |
32 |
|
- remove old parameters ( SEAICE_freeze, SEAICEturbFluxFormula, SEAICE_gamma_t, |
33 |
|
SEAICE_gamma_t_frz, SEAICE_availHeatTaper & SEAICE_availHeatFracFrz) |
34 |
|
from SEAICE_PARMS.h ; still need to fix seaice_cost_sst.F (broken when |
35 |
|
SEAICE_freeze got retired) but already better than previously with |
36 |
|
SEAICE_freeze=123456.7 deg.C; |
37 |
|
- move setting of facOpenGrow/Melt from SEAICE_INIT_FIXED to SEAICE_READPARMS |
38 |
|
(safer multi-threaded setting); always set SEAICEuseEVP; |
39 |
|
- setting of ocean-ice turb. flux coeff: moved from SEAICE_CHECK to |
40 |
|
SEAICE_READPARMS & SEAICE_INIT_FIXED (this fixes wrong summary report); |
41 |
|
stop if multiple specifications for the same coeff; make sure default |
42 |
|
SEAICE_mcPheePiston is compatible with drF(1) & deltaT. |
43 |
|
o pkg/obcs: |
44 |
|
- allow to switch to upwind 1rst order advection scheme for the advective |
45 |
|
flux computation at the open-boundary; disabled for adjoint built. |
46 |
|
o pkg/ptracers: |
47 |
|
- rename PTRACERS_RESTART.h -> PTRACERS_START.h |
48 |
|
- rename ptracers_fields_blocking_exchanges.F -> ptracers_fields_blocking_exch.F |
49 |
|
- add parameter to decide when to start a tracer; use internal flag to |
50 |
|
know which tracer to step-forward; switch this internal flag at the top |
51 |
|
of forward_step.F (new S/R PTRACERS_SWITCH_ONOFF); for now, not enabled |
52 |
|
for adjoint built. |
53 |
|
o pkg/seaice: |
54 |
|
- add SEAICE_SIZE.h anywhere in the code where SEAICE.h is included ; |
55 |
|
- move MULTDIM declaration and setting from SEAICE.h to SEAICE_SIZE.h ; |
56 |
|
- keep experiment offline_exf_seaice truly single category (set MULTDIM=1). |
57 |
|
o pkg/ecco: |
58 |
|
- fix writing of output file DiagnosCost_ClimSalt/Theta |
59 |
|
and DiagnosCost_DriftSalt/Theta (if multi-tiles per proc). |
60 |
|
o pkg/seaice: |
61 |
|
- add missing initialisation of COR_ICE array in dynsolver.F |
62 |
|
- merging SEAICE_MULTICATEGORY define and undef cases. Now the same code is |
63 |
|
compiled either way, and is tested in all exps (multidim was only tested |
64 |
|
in lab_sea ad before). |
65 |
|
- cosmetic change to prepare for future addition of ITD. no change to results. |
66 |
|
no defaults change. |
67 |
|
- added run time param SEAICE_multDim (7 for SEAICE_MULTICATEGORY, 1 otherwise). |
68 |
|
- by lack of adequate verification experiments, I further used custom versions |
69 |
|
of global_ocean.cs32x15 to test multicat or not, with pickup or not. All |
70 |
|
should be correct. |
71 |
|
- avoid recomputations in ad. |
72 |
|
o array initialisation in adjoint mode: |
73 |
|
1) pkg/mom_common/mom_calc_ke.F: |
74 |
|
add full array initialisation of KE inside mom_calc_ke.F (ALLOW_AUTODIFF_TAMC): |
75 |
|
The S/R which calls MOM_CALC_KE initialises KE but in some recomputation |
76 |
|
part this initialisation is gone, resulting in Floating Point Exception |
77 |
|
(caught by open64 compiler with debug option). |
78 |
|
2) model/src/convective_weights.F |
79 |
|
set output convectCount over the full array range (instead of doing |
80 |
|
an update): this fix a similar issue when called within recomputation (adjoint) |
81 |
|
which could by-pass the initialisation (normally done in the caller S/R). |
82 |
|
o pkg/seaice: |
83 |
|
- final version of turbulent flux params, as agreed at MIT ice meet: |
84 |
|
SEAICE_mcPheePiston (default is ~ 0.000875) |
85 |
|
SEAICE_mcPheeTaper (default is 0.) |
86 |
|
SEAICE_frazilFrac (defualt is 1.) |
87 |
|
SEAICE_mcPheeStepFunc (default is false) |
88 |
|
- changes results at trunction error level |
89 |
|
- ifdef SEAICE_EXTERNAL_FLUXES, disallow SEAICE_waterAlbedo |
90 |
|
o added pkg/frazil: |
91 |
|
- see frazil_description.tex for details |
92 |
|
- verification experiment is global_with_exf/input.yearly; changes output.yearly.txt |
93 |
|
o pkg/shelfice/shelfice_thermodynamics.F |
94 |
|
- fix exponents for velocity dependent exchange coefficients: change |
95 |
|
from 2/3(=0) to 0.66666666666666667 |
96 |
|
- move computation of velocity dependent exchange coefficients into |
97 |
|
separate loop, so that it applies to both thermodynamics |
98 |
|
- move some divisions by constants out of loops |
99 |
|
|
100 |
|
checkpoint63j (2012/02/16) |
101 |
|
o pkg/seaice: |
102 |
|
- overhaul of seaice_summary.F after feb 2012 clean-up of seaice_growth.F etc. |
103 |
|
- SItracer: added run time params, and allow coupling to ocn salinity. |
104 |
|
o pkg/seaice: remove (almost) all divisions by constants within loops |
105 |
|
in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d |
106 |
|
results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only |
107 |
|
those, caused by 1/QI -> recip_QI) -> update output.seaice.txt, |
108 |
|
output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt |
109 |
|
o pkg/seaice : |
110 |
|
- simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula |
111 |
|
= 1 or 2, using newly added run time parameter SEAICE_availHeatTaper. |
112 |
- fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148. |
- fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148. |
113 |
- add permanent SItflux diag that corresponds to TFLUX but includes |
- add permanent SItflux diag that corresponds to TFLUX but includes |
114 |
ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget. |
ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget. |
115 |
- allow activation/testing of a fix for suspected missing term in |
- allow activation/testing of a fix for suspected missing term in |
116 |
ocn-ice heat budget (to be confirmed). To test this, you want to |
ocn-ice heat budget (to be confirmed). To test this, you want to |
117 |
undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param |
undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param |
118 |
SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic. |
SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic. |
119 |
- no change in results, fwd or ad. |
- no change in results, fwd or ad. |
120 |
o global_ocean.cs32x15/results: three changes following from the pkg/seaice commit below. |
o global_ocean.cs32x15/results: 3 changes following from the pkg/seaice commit below: |
121 |
- switch to variable freezing point. |
- switch to variable freezing point. |
122 |
Results change : cg2d -> 1 digits; ad -> 3-6-6 digits. |
Results change : cg2d -> 1 digits; ad -> 3-6-6 digits. |
123 |
- bug fix : the sublimation term that was missing is now activated. |
- bug fix : the sublimation term that was missing is now activated. |
124 |
Results change : cg2d -> 2 digits; ad -> 8-6-6 digits. |
Results change : cg2d -> 2 digits; ad -> 8-6-6 digits. |
125 |
- bug fix : flooding sign term for SIsal0.NE.0. |
- bug fix : flooding sign term for SIsal0.NE.0. |
126 |
Result change : cg2d -> 8 digits; ad -> 11-12-9 digits. |
Result change : cg2d -> 8 digits; ad -> 11-12-9 digits. |
127 |
o pkg/seaice: |
o pkg/seaice: |
128 |
- unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT |
- unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT |
129 |
is now the default, and the old default constant freezing point is recovered with |
is now the default, and the old default constant freezing point is recovered |
130 |
SEAICE_tempFrz0 = -1.96, |
with SEAICE_tempFrz0 = -1.96, |
131 |
SEAICE_dTempFrz_dS = 0., |
SEAICE_dTempFrz_dS = 0., |
132 |
- retire SEAICE_freeze that was the old way of specifycing the constant freezing point. |
- retire SEAICE_freeze (= the old way of specifycing the constant freezing point) |
133 |
- remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there. |
- remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there. |
134 |
- bug fix (thanks to M. Losch) : the sublimation term that was missing is now |
- bug fix (thanks to M. Losch) : the sublimation term that was missing is now |
135 |
activated. To reproduce old results that had this bug define SEAICE_DISABLE_SUBLIM. |
activated. To reproduce old results with this bug define SEAICE_DISABLE_SUBLIM. |
136 |
- bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211) |
- bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211) |
137 |
was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail). |
was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail). |
138 |
- bug fix (thanks to O. Jahn) : area loss for melting got messed up in |
- bug fix (thanks to O. Jahn) : area loss for melting got messed up in |
139 |
seaice_growth r149 for legacy branch (no results change). |
seaice_growth r149 for legacy branch (no results change). |
140 |
- introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code from I. Fenty). |
- introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code |
141 |
- results did not change except for global_ocean.cs32x15, mostly due to the switch |
from I. Fenty). |
142 |
to variable freezing point (see above item for detail). |
- results did not change except for global_ocean.cs32x15, mostly due to the |
143 |
|
switch to variable freezing point (see above item for detail). |
144 |
o pkg/thsice: |
o pkg/thsice: |
145 |
- fix and simplify interface to salt_plume pkg ; diagnose directly amount of |
- fix and simplify interface to salt_plume pkg ; diagnose directly amount of |
146 |
seawater freezing in thsice_calc_thickn (not used). |
seawater freezing in thsice_calc_thickn (not used). |
147 |
o pkg/seaice: turbulent flux term specification via run time params. |
o pkg/seaice: turbulent flux term specification via run time params. |
148 |
- replace CPP switches with run time switches to facilitate testing |
- replace CPP switches with run time switches to facilitate testing |
149 |
- retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR |
- retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, |
150 |
|
GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR |
151 |
- added runtime parameter : SEAICEturbFluxFormula |
- added runtime parameter : SEAICEturbFluxFormula |
152 |
- move Mcphee constants to SEAICE_PARAMS.h |
- move Mcphee constants to SEAICE_PARAMS.h |
153 |
- seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula; |
- seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula; |
154 |
SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); remove |
SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); |
155 |
seaice_summary call (moved to seaice_init_fixed) |
remove seaice_summary call (moved to seaice_init_fixed) |
156 |
- seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on |
- seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on |
157 |
SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms) |
SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms) |
158 |
- seaice_summary.F : add missing report of read turbulent flux term set up (and SITRACER). |
- seaice_summary.F : add missing report of read turbulent flux term set up |
159 |
- seaice_check.F : check range; inform and stop if retired CPPs are used (incl. SEAICE_AGE). |
and SITRACER. |
160 |
|
- seaice_check.F : check range; inform and stop if retired CPPs are used |
161 |
|
(incl. SEAICE_AGE). |
162 |
- seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without |
- seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without |
163 |
CPP switch, same computation as before for the different options. |
CPP switch, same computation as before for the different options. |
164 |
- change results at the truncation level. |
- change results at the truncation level. |
165 |
o pkg/seaice: |
o pkg/seaice: |
166 |
- remove un-used parameters LAD & MAX_TICE ; add new run-time parameters: |
- remove un-used parameters LAD & MAX_TICE ; add new run-time parameters: |