4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
5 |
============================== |
============================== |
6 |
|
|
7 |
|
o pkg/seaice: |
8 |
|
- improve I/O of diagnostics of JFNK in seaice_jfnk.F: |
9 |
|
+ add (SEAICE.h) and rename some counters (initiliased in |
10 |
|
seaice_init_fixed.F) |
11 |
|
+ add _BEGIN/END_MASTER (myThid) around print statements |
12 |
|
+ print total number of iterations and failures over SEAICE_monFreq |
13 |
|
interval to STDOUT |
14 |
|
- move control over output-messages by fgmres to seaice_jfnk to save |
15 |
|
some operations |
16 |
|
- move resetting initial guess for fgmres outside of seaice_fgmres_driver |
17 |
|
in order to make restarts with sol .ne. zero (fgmres with restarts) |
18 |
|
(seaice_jfnk.F, seaice_fgmres.F) |
19 |
|
- seaice_calc_l/rhs.F: replace maskW/S by maskInW/S; this fixes |
20 |
|
a serious convergence problem when open boundaries are involved |
21 |
|
o pkg/ggl90: fix computation of control volumes for the case of |
22 |
|
ALLOW_GGL90_HORIZDIFF (probably not used very often): move control volumes |
23 |
|
up half a grid cell from C-centered to W-centered (pointed out by C. Eden) |
24 |
|
o pkg/seaice: simplify seaice_evp by avoiding use of extra fields u/vIceC |
25 |
|
o pkg/autodiff |
26 |
|
- Add inAdMode switch for SEAICEuseDYNAMICS: |
27 |
|
SEAICEuseDYNAMICSinAdMode |
28 |
|
(extend logic in ADAUTODIFF_INADMODE_SET) |
29 |
|
o pkg/seaice |
30 |
|
- Step 1 of merging ice-thickness distribution (ITD) code from |
31 |
|
MITgcm_contrib/torge/itd/ (author: Torge Martin) |
32 |
|
The code implements concept laid out in Thorndike et al. (1975); |
33 |
|
code is enabled via CPP flag SEAICE_ITD |
34 |
|
nITD (in SEAICE_SIZE.h) defines number of ice thickness categories; |
35 |
|
code is not complete yet!! |
36 |
|
- SEAICE_SIZE.h now included in almost all seaice routines |
37 |
|
o verification (using seaice): |
38 |
|
- switch back seaice-dynamics (+ lower SOLV_MAX_ITERS) in ADM exp. |
39 |
|
global_ocean.cs32x15.seaice ; update results. |
40 |
|
- compile B-grid dynamics in FW test exp 1D_ocean_ice_column ; |
41 |
|
- compile C-grid dynamics with #define SEAICE_ALLOW_JFNK in FW test exp |
42 |
|
offline_exf_seaice (previously compiling B-grid). |
43 |
|
o pkg/exf: |
44 |
|
- fix some STOP conditions in exf_check.F (from Aug 28, modifs did not allow |
45 |
|
to specify neither just 1 comp of wind or wind-stress, nor no surface momentum |
46 |
|
forcing): just replace CPP option ALLOW_ATM_WIND with run-time param useAtmWind. |
47 |
|
o pkg/layers (adjust changes from Sept 19): |
48 |
|
- do snap-shot output and fill diagnostics from inside iLa loop (layers_calc.F) |
49 |
|
this allows to remove "layers_maxNum" dimension from all layers arrays. |
50 |
|
o pkg/layers (adjust changes from Sept 19): |
51 |
|
- remove ALLOW_LAYERS_OUTPUT ; fix snap-shot and time-ave output ; |
52 |
|
- snap-shot extended to all type of layers (not just the 1rst type); |
53 |
|
- remove layers variables when corresponding CPP option is undef. |
54 |
|
o pkg/layers: |
55 |
|
- rename pkg/layers variable and add new output (layer exist & un-weighted |
56 |
|
velocity in layer) |
57 |
|
o pkg/seaice: |
58 |
|
- simplify (?) ocean-drag coefficent computations by using |
59 |
|
the same routine in all three solvers (saves some code lines) |
60 |
|
- remove global fields DRAGA and DRAGS from C-grid code and |
61 |
|
declare them locally in lsr.F (the only place where they are |
62 |
|
still used) |
63 |
|
- update AD output of lab_sea.evp (very sensitive anyway). |
64 |
|
o pkg/seaice: add Jacobian-free Newton Krylov solver for ice dynamics |
65 |
|
(Lemieux et al. 2010, 2012). Turn on with the usual SEAICE_ALLOW_JFNK |
66 |
|
and SEAICEuseJFNK=.true. A few things to note: |
67 |
|
- involves a FGMRES, that is parallel but very inefficient, |
68 |
|
because of many scalar products (global sums) in the Gram-Schmidt |
69 |
|
orthogonalization method. Needs to be replaced. Original code |
70 |
|
from J.-F. Lemieux |
71 |
|
- preconditioner for FGMRES is a stripped down version of LSOR |
72 |
|
- SOLV_MAX_ITERS is now used for LSOR as a solver and as a |
73 |
|
preconditioner. For the preconditioner, the default is set to 10. |
74 |
|
- Jacobian times vector is computed with finite differences |
75 |
|
- marginally related to JFNK-solver: add a smooth regularization for |
76 |
|
zeta with tanh that will improve convergence (Lemieux and Tremblay, |
77 |
|
2009) for any implicit solver (not implemented for EVP because EVP |
78 |
|
does not need this regularization in the first place). Define |
79 |
|
SEAICE_ZETA_SMOOTHREG in SEAICE_OPTIONS.h to use. |
80 |
|
o eesupp/src: |
81 |
|
- check in genmake2 that intrinsic S/R flush is available. |
82 |
|
- add S/R to flush IO unit (if intrinsic S/R flush is available) |
83 |
|
- flush standard & error msg unit before MPI termination |
84 |
|
- if debugMode, flush IO unit after printing msg |
85 |
|
o pkg/ctrl: |
86 |
|
- ctrl_unpack.F, ALLOW_GENARR3D_CONTROL code: fix missing argument in call |
87 |
|
to ctrl_set_unpack_xyz. |
88 |
|
|
89 |
|
checkpoint64 (2012/10/09) |
90 |
|
o pkg/shelfice |
91 |
|
- in mom_fluxform.F, mom_vecinv.F: |
92 |
|
CALL SHELFICE_V_DRAG(bi,bj,k,vFld,KE,KappaRU,vF,myThid) |
93 |
|
Bug fix KappaRU -> KappaRV |
94 |
|
does not change verification/isomip but may change other setups |
95 |
|
(presumably constant KappaRU=KappaRV) |
96 |
|
- fix diagnostics SHIU/Vdrag (thanks to Tom Millgate) |
97 |
|
o pkg/obcs: |
98 |
|
- fixed some indexing bugs in obcs_seaice_sponge.F |
99 |
|
- added obcs relaxation subroutines for HSALT and HSNOW |
100 |
|
- changes verification/seaice_obcs/results/obcs_seaice_sponge.F |
101 |
|
o pkg/seaice: |
102 |
|
- add "multicategory" parameterization for snow in analogy to ice, |
103 |
|
default is off for now. |
104 |
|
o pkg/obcs: |
105 |
|
- added obcs_seaice_sponge.F for obcs relaxation of seaice variables; |
106 |
|
see verification/seaice_obcs/input.seaiceSponge for example application. |
107 |
|
- remove local commom bloc "OBCS_GLOBAL" in obcs_readparms.F and do all the OB |
108 |
|
index setting by master-thread. This fix multi-threads Pb in previous modifs. |
109 |
|
o pkg/layers : |
110 |
|
- add diagnostics to pkg/layers |
111 |
|
- move the meat of pkg/layers from layers_calc.F to layers_fluxcalc.F |
112 |
|
(from R.Tulloch). Layers_calc.F now calls layers_fluxcalc.F accordingly. |
113 |
|
o pkg/generic_advdiff/gad_implicit_r.F : |
114 |
|
- fix ADVr diagnostics in case of both implicit vertical advection and diffusion. |
115 |
|
o pkg/seaice/seaice_growth.F: |
116 |
|
- fix SItflux diagnostics in virtual salt flux + balanceEmpmr case. |
117 |
|
o pkg/obcs: |
118 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
119 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
120 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
121 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
122 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
123 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
124 |
|
o pkg/obcs: |
125 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
126 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
127 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
128 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
129 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
130 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
131 |
|
to replace hard-coded null index value of zero. |
132 |
o pkg/exch2: |
o pkg/exch2: |
133 |
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
134 |
always check buffer-size (but outside the loop); move checking for valid |
always check buffer-size (but outside the loop); move checking for valid |