| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/seaice/seaice_calc_l/rhs.F: replace maskW/S by maskInW/S; this fixes |
| 8 |
|
a serious convergence problem when open boundaries are involved |
| 9 |
|
o pkg/ggl90: fix computation of control volumes for the case of |
| 10 |
|
ALLOW_GGL90_HORIZDIFF (probably not used very often): move control volumes |
| 11 |
|
up half a grid cell from C-centered to W-centered (pointed out by C. Eden) |
| 12 |
|
o pkg/seaice: simplify seaice_evp by avoiding use of extra fields u/vIceC |
| 13 |
|
o pkg/autodiff |
| 14 |
|
- Add inAdMode switch for SEAICEuseDYNAMICS: |
| 15 |
|
SEAICEuseDYNAMICSinAdMode |
| 16 |
|
(extend logic in ADAUTODIFF_INADMODE_SET) |
| 17 |
|
o pkg/seaice |
| 18 |
|
- Step 1 of merging ice-thickness distribution (ITD) code from |
| 19 |
|
MITgcm_contrib/torge/itd/ (author: Torge Martin) |
| 20 |
|
The code implements concept laid out in Thorndike et al. (1975); |
| 21 |
|
code is enabled via CPP flag SEAICE_ITD |
| 22 |
|
nITD (in SEAICE_SIZE.h) defines number of ice thickness categories; |
| 23 |
|
code is not complete yet!! |
| 24 |
|
- SEAICE_SIZE.h now included in almost all seaice routines |
| 25 |
|
o verification (using seaice): |
| 26 |
|
- switch back seaice-dynamics (+ lower SOLV_MAX_ITERS) in ADM exp. |
| 27 |
|
global_ocean.cs32x15.seaice ; update results. |
| 28 |
|
- compile B-grid dynamics in FW test exp 1D_ocean_ice_column ; |
| 29 |
|
- compile C-grid dynamics with #define SEAICE_ALLOW_JFNK in FW test exp |
| 30 |
|
offline_exf_seaice (previously compiling B-grid). |
| 31 |
|
o pkg/exf: |
| 32 |
|
- fix some STOP conditions in exf_check.F (from Aug 28, modifs did not allow |
| 33 |
|
to specify neither just 1 comp of wind or wind-stress, nor no surface momentum |
| 34 |
|
forcing): just replace CPP option ALLOW_ATM_WIND with run-time param useAtmWind. |
| 35 |
|
o pkg/layers (adjust changes from Sept 19): |
| 36 |
|
- do snap-shot output and fill diagnostics from inside iLa loop (layers_calc.F) |
| 37 |
|
this allows to remove "layers_maxNum" dimension from all layers arrays. |
| 38 |
|
o pkg/layers (adjust changes from Sept 19): |
| 39 |
|
- remove ALLOW_LAYERS_OUTPUT ; fix snap-shot and time-ave output ; |
| 40 |
|
- snap-shot extended to all type of layers (not just the 1rst type); |
| 41 |
|
- remove layers variables when corresponding CPP option is undef. |
| 42 |
|
o pkg/layers: |
| 43 |
|
- rename pkg/layers variable and add new output (layer exist & un-weighted |
| 44 |
|
velocity in layer) |
| 45 |
|
o pkg/seaice: |
| 46 |
|
- simplify (?) ocean-drag coefficent computations by using |
| 47 |
|
the same routine in all three solvers (saves some code lines) |
| 48 |
|
- remove global fields DRAGA and DRAGS from C-grid code and |
| 49 |
|
declare them locally in lsr.F (the only place where they are |
| 50 |
|
still used) |
| 51 |
|
- update AD output of lab_sea.evp (very sensitive anyway). |
| 52 |
|
o pkg/seaice: add Jacobian-free Newton Krylov solver for ice dynamics |
| 53 |
|
(Lemieux et al. 2010, 2012). Turn on with the usual SEAICE_ALLOW_JFNK |
| 54 |
|
and SEAICEuseJFNK=.true. A few things to note: |
| 55 |
|
- involves a FGMRES, that is parallel but very inefficient, |
| 56 |
|
because of many scalar products (global sums) in the Gram-Schmidt |
| 57 |
|
orthogonalization method. Needs to be replaced. Original code |
| 58 |
|
from J.-F. Lemieux |
| 59 |
|
- preconditioner for FGMRES is a stripped down version of LSOR |
| 60 |
|
- SOLV_MAX_ITERS is now used for LSOR as a solver and as a |
| 61 |
|
preconditioner. For the preconditioner, the default is set to 10. |
| 62 |
|
- Jacobian times vector is computed with finite differences |
| 63 |
|
- marginally related to JFNK-solver: add a smooth regularization for |
| 64 |
|
zeta with tanh that will improve convergence (Lemieux and Tremblay, |
| 65 |
|
2009) for any implicit solver (not implemented for EVP because EVP |
| 66 |
|
does not need this regularization in the first place). Define |
| 67 |
|
SEAICE_ZETA_SMOOTHREG in SEAICE_OPTIONS.h to use. |
| 68 |
|
o eesupp/src: |
| 69 |
|
- check in genmake2 that intrinsic S/R flush is available. |
| 70 |
|
- add S/R to flush IO unit (if intrinsic S/R flush is available) |
| 71 |
|
- flush standard & error msg unit before MPI termination |
| 72 |
|
- if debugMode, flush IO unit after printing msg |
| 73 |
|
o pkg/ctrl: |
| 74 |
|
- ctrl_unpack.F, ALLOW_GENARR3D_CONTROL code: fix missing argument in call |
| 75 |
|
to ctrl_set_unpack_xyz. |
| 76 |
|
|
| 77 |
|
checkpoint64 (2012/10/09) |
| 78 |
|
o pkg/shelfice |
| 79 |
|
- in mom_fluxform.F, mom_vecinv.F: |
| 80 |
|
CALL SHELFICE_V_DRAG(bi,bj,k,vFld,KE,KappaRU,vF,myThid) |
| 81 |
|
Bug fix KappaRU -> KappaRV |
| 82 |
|
does not change verification/isomip but may change other setups |
| 83 |
|
(presumably constant KappaRU=KappaRV) |
| 84 |
|
- fix diagnostics SHIU/Vdrag (thanks to Tom Millgate) |
| 85 |
|
o pkg/obcs: |
| 86 |
|
- fixed some indexing bugs in obcs_seaice_sponge.F |
| 87 |
|
- added obcs relaxation subroutines for HSALT and HSNOW |
| 88 |
|
- changes verification/seaice_obcs/results/obcs_seaice_sponge.F |
| 89 |
|
o pkg/seaice: |
| 90 |
|
- add "multicategory" parameterization for snow in analogy to ice, |
| 91 |
|
default is off for now. |
| 92 |
|
o pkg/obcs: |
| 93 |
|
- added obcs_seaice_sponge.F for obcs relaxation of seaice variables; |
| 94 |
|
see verification/seaice_obcs/input.seaiceSponge for example application. |
| 95 |
|
- remove local commom bloc "OBCS_GLOBAL" in obcs_readparms.F and do all the OB |
| 96 |
|
index setting by master-thread. This fix multi-threads Pb in previous modifs. |
| 97 |
|
o pkg/layers : |
| 98 |
|
- add diagnostics to pkg/layers |
| 99 |
|
- move the meat of pkg/layers from layers_calc.F to layers_fluxcalc.F |
| 100 |
|
(from R.Tulloch). Layers_calc.F now calls layers_fluxcalc.F accordingly. |
| 101 |
|
o pkg/generic_advdiff/gad_implicit_r.F : |
| 102 |
|
- fix ADVr diagnostics in case of both implicit vertical advection and diffusion. |
| 103 |
|
o pkg/seaice/seaice_growth.F: |
| 104 |
|
- fix SItflux diagnostics in virtual salt flux + balanceEmpmr case. |
| 105 |
|
o pkg/obcs: |
| 106 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
| 107 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
| 108 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
| 109 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
| 110 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
| 111 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
| 112 |
|
o pkg/obcs: |
| 113 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
| 114 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
| 115 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
| 116 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
| 117 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
| 118 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
| 119 |
|
to replace hard-coded null index value of zero. |
| 120 |
|
o pkg/exch2: |
| 121 |
|
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
| 122 |
|
always check buffer-size (but outside the loop); move checking for valid |
| 123 |
|
index from W2_USE_E2_SAFEMODE to W2_E2_DEBUG_ON; in W2_E2_DEBUG_ON, |
| 124 |
|
print each tile and point connection only if |W2_printMsg|>= 2 and 3. |
| 125 |
|
o pkg/ctrl (pack & unpack): |
| 126 |
|
- in ctrl_pack.F & ctrl_unpack.F, use the same local file-name variable |
| 127 |
|
(locally defined) for different variables (+ remove the variable-specific |
| 128 |
|
file name in CTRL_GENARR.h). For now, only implemented for GENARR2/3D_CONTROL |
| 129 |
|
(to be extended to other local file names in ctrl.h). |
| 130 |
|
o pkg/flt: |
| 131 |
|
- add a FLT_Iter0 option (similar to PTRACERS_Iter0). |
| 132 |
|
o pkg/mdsio: |
| 133 |
|
- fix missing STOP in mdsio_readvec_loc.F (case ioUnit=0) when file is missing |
| 134 |
|
o tools/genmake2: |
| 135 |
|
- add similar dependences for target EXE_AD & EXE_FTL as we have for EXECUTABLE |
| 136 |
|
(added by Alistair in version 1.51 for building without make depend); |
| 137 |
|
- remove Header files list (H_SRC_FILES) from the dependence of targets |
| 138 |
|
ad_input_code.f & ftl_input_code.f (not clear why it was added in the first |
| 139 |
|
place in version 1.23): this save going through staf when unrelated header |
| 140 |
|
file has been modified. |
| 141 |
|
Note: for an intermediate target (e.g., ad_input_code.f or adtaf) without |
| 142 |
|
"make depend" step, still need to do "make links" before "make adtaf". |
| 143 |
|
o eesupp/src (+ few pkg src files) & genmake2: |
| 144 |
|
- finish to remove ALWAYS_USE_MPI in source code that TAF does not see; |
| 145 |
|
- no longer set ALWAYS_USE_MPI in Makefile (was done by genmake2). |
| 146 |
|
- improve genmake2 checking for ALLOW_${PKG} in CPP_OPTIONS.h files (distinguish |
| 147 |
|
upper/lower case ; account for space between "#" and undef/define) |
| 148 |
|
o pkg/flt (with exch2): |
| 149 |
|
- cleaning: fix so that it compiles; move remaining MPI calls out of flt_exch2.F; |
| 150 |
|
- simplify threads synchronisation; fix (many issues) multi-threaded with MPI. |
| 151 |
|
|
| 152 |
|
checkpoint63s (2012/09/05) |
| 153 |
|
o pkg/ecco: |
| 154 |
|
- remove #ifdef ALLOW_SMOOTH_CORREL3D brackets. |
| 155 |
|
- add more relevant #ifdef ALLOW_SMOOTH ones. |
| 156 |
|
- sort out useAtmWind, useSMOOTH, ctrlSmoothCorrel2D. |
| 157 |
|
o pkg/ctrl: |
| 158 |
|
- CTRL_OPTIONS.h : document CPPs related to smoothing; ALLOW_SMOOTH_CORREL2D/3D, |
| 159 |
|
ALLOW_CTRL_SMOOTH, ALLOW_SMOOTH_CTRL2D, ALLOW_SMOOTH_CTRL3D. |
| 160 |
|
- ctrl.h : document run time params doInitXX, doMainPack, doMainUnpack, doPackDiag, |
| 161 |
|
doSinglePrecTapelev (audodiff param!), ctrlSmoothCorrel2D (new) and |
| 162 |
|
ctrlSmoothCorrel3D (new). |
| 163 |
|
The added ctrlSmoothCorrel2D/3D replace the old ALLOW_SMOOTH_CORREL2D/3D CPP. |
| 164 |
|
- ctrl_readparms.F : initialise ctrlSmoothCorrel2D/3D and read from namelist. |
| 165 |
|
- ctrl_init.F ctrl_pack.F ctrl_unpack.F : switch off ustress/vstress |
| 166 |
|
controls when useAtmWind, and vice versa. |
| 167 |
|
- ctrl_map_ini_ecco.F : UVEL0, VVEL0, edtaux, edtauy cannot be smoothed as tracers. |
| 168 |
|
- ctrl_get_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL2D with |
| 169 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel2D, IF useSMOOTH. |
| 170 |
|
- ctrl_map_ini_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL3D with |
| 171 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel3D, IF useSMOOTH. |
| 172 |
|
- ctrl_set_pack_xy[z].F, ctrl_set_unpack_xy[z].F: |
| 173 |
|
replace ALLOW_SMOOTH_CORREL2D/3D brackets with ctrlSmoothCorrel2D/3D. |
| 174 |
|
o pkg/smooth: |
| 175 |
|
- remove un-necessary includes. |
| 176 |
|
- remove ALLOW_SMOOTH*D and ALLOW_SMOOTH_CORREL*D brakets. |
| 177 |
|
Those CPP options were never defined, and not necessary. |
| 178 |
|
o model/src: |
| 179 |
|
- fix CPP brackets in ini_mixing.F (GM_background_K belongs to gmredi). |
| 180 |
|
- standard treatment of useSMOOTH. |
| 181 |
|
o pkg/autodiff: |
| 182 |
|
- add LOGICAL useGGL90inAdMode, useGGL90inFwdMode, useSALT_PLUMEinAdMode, |
| 183 |
|
useSALT_PLUMEInFwdMode allowing to switch off ggl90 and salt_plume adjoint. |
| 184 |
|
o pkg/exch2: |
| 185 |
|
- add "if usingMPI" where it was missing (in exch2_rx?_cube*.template) |
| 186 |
|
+ start to remove ALWAYS_USE_MPI in source code that TAF does not see. |
| 187 |
|
- make new S/R W2_MAP_PROCS out of w2_eeboot.F to setup exch2 CommonFlag |
| 188 |
|
and tiles to process mapping. |
| 189 |
|
- re-arrange 3 header files (W2_EXCH2_PARAMS.h, _BUFFER.h & _TOPOLOGY.h) |
| 190 |
|
moving /EXCH2_FILLVAL_RX/ & /W2_EXCH2_COMMFLAG/ to W2_EXCH2_TOPOLOGY.h; |
| 191 |
|
rename "exch2_tProc" to "W2_tileProc" and move seting of e2FillValue_RX |
| 192 |
|
from w2_eeboot.F to w2_readparms.F. |
| 193 |
|
o eesupp/src: |
| 194 |
|
- set exchNeedsMemsync & exchUsesBarrier according to "usingMPI" (instead of |
| 195 |
|
ALWAYS_USE_MPI) + moved from ini_communication_patterns.F to eeset_parms.F; |
| 196 |
|
also move setting of exchCollectStatistics from exch_init.F to eeset_parms.F |
| 197 |
|
- in eedie.F and all_proc_die.F, always call MPI_FINALIZE when ALLOW_USE_MPI |
| 198 |
|
is defined (remove condition on usingMPI) to match cases where MPI_INIT |
| 199 |
|
has been called. |
| 200 |
|
- fix bug I put in previous modif of exch_sm_3d_rx.template (not much used); |
| 201 |
|
- change default (non-MPI) value of myPid (from 1 to 0) to match MPI settings |
| 202 |
|
(so that on 1 proc, get same myPid independently of usingMPI) |
| 203 |
|
- add a stop if multi-procs but usingMPI=F ; stop also if usingMPI=T and |
| 204 |
|
useCubedSphereExchange with EXCH-1 (safer). |
| 205 |
|
- add "if usingMPI" where it was missing (+ start to remove ALWAYS_USE_MPI). |
| 206 |
|
o pkg/ggl90: |
| 207 |
|
- fix bug in filling corner mask array "mskCor" (FILL_CS_CORNER_TR_RL call) |
| 208 |
|
used in ALLOW_GGL90_SMOOTH code. |
| 209 |
|
o pkg/flt: |
| 210 |
|
- fix typo in FLT_WITHOUT_Y_PERIODICITY (the effect was to ignore stopping |
| 211 |
|
floats at the Southern end of the domain). |
| 212 |
|
o eesupp/inc: |
| 213 |
|
- add a list of CPP-options which can be set by Makefile (DEF_IN_MAKEFILE.h); |
| 214 |
|
but not used (and not to be used) anywhere, just for documentation. |
| 215 |
|
o pkg/autodiff, exf, ptracers & seaice (AD & TL output): |
| 216 |
|
- comment out the very nasty "writeBinaryPrec = writeStatePrec" line, since: |
| 217 |
|
a) can damage previously written records in any other multi-record files. |
| 218 |
|
b) if needed, can easily do it cleanly, by calling S/R WRITE_REC_3D_RL/S. |
| 219 |
|
o tools/genmake2: |
| 220 |
|
- define variable MAKE within Makefile and use it in place of 'make'; |
| 221 |
|
- update AD_CONFIG.h (if needed) before building any of the executable |
| 222 |
|
(forward, adjoint or tangent-lin); this involves a 2nd invocation of make; |
| 223 |
|
and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h; |
| 224 |
|
- always print usual warning comment 'this file is automatically generated' |
| 225 |
|
from script convert_cpp_cmd2defines (+ remove this warning from genmake2). |
| 226 |
|
o pkg/cheapaml: |
| 227 |
|
- updated to correspond to the code used in accepted paper (Nico Wienders). |
| 228 |
|
o pkg/exf: |
| 229 |
|
added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch. |
| 230 |
|
ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F) |
| 231 |
|
and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h). |
| 232 |
|
o pkg/exf, autodiff, ctrl, ecco and seaice: |
| 233 |
|
remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones. |
| 234 |
|
o pkg/ctrl, ecco: |
| 235 |
|
allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL. |
| 236 |
|
Depending on useAtmWind, one is inactive, and the other is active (see |
| 237 |
|
exf_getffields.F/exf_getsurfacefluxes.F). |
| 238 |
|
o tools/genmake2: |
| 239 |
|
- improve error msg when failing in 2nd test of check_for_broken_Ff |
| 240 |
|
- fix option '-makefile' short-name (-mf according to genmake2 -help) |
| 241 |
|
- source local config file "genmake_local" just after processing the genmake2 |
| 242 |
|
command arguments (previously done before processing arg). |
| 243 |
|
o pkg/grdchk: |
| 244 |
|
- add a call to TURNOFF_MODEL_IO for Tangent-Linear run (in this case, call |
| 245 |
|
to this routine from cost_final has been dropped in g_cost_final) |
| 246 |
|
- improve printed information (more explicit msg, no longer using "print *," |
| 247 |
|
fix fcpertminus printed value). |
| 248 |
|
o model/src: |
| 249 |
|
- move call to COST_INIT_VARIA out of packages_init_variables.F directly |
| 250 |
|
into initialise_varia.F (just after calling PACKAGES_INIT_VARIABLES): |
| 251 |
|
this prevents getting cost-funct reset in adinitialise_varia recomputations. |
| 252 |
|
o pkg/dic: |
| 253 |
|
- move initialisation of "freefe" array from from dic_biotic_forcing.F to |
| 254 |
|
fe_chem.F: this prevents TAF from dropping this initialisation in TLM code. |
| 255 |
|
o pkg/grdchk: |
| 256 |
|
- grdchk_main.F : added CALL GLOBAL_SUM_INT( ierr , myThid ) |
| 257 |
|
- grdchk_getadxx.F etc. : omit I/O if ierr.EQ.0 |
| 258 |
o pkg/autodiff/ctrl/grdchk : |
o pkg/autodiff/ctrl/grdchk : |
| 259 |
- attempt to sort out what works and what does not, |
- attempt to sort out what works and what does not, |
| 260 |
with regard to I/O, and to warn/stop accordingly. |
with regard to I/O, and to warn/stop accordingly. |
| 261 |
o pkg/grdchk : |
o pkg/grdchk: |
| 262 |
- attempt to fix grdchk in the case of useSingleCpuIO. |
- attempt to fix grdchk in the case of useSingleCpuIO. |
| 263 |
- "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )" |
- "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )" |
| 264 |
statements were moved from grdchk_main.F and into |
statements were moved from grdchk_main.F and into |
| 265 |
grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F. |
grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F. |
| 266 |
- a global sum is applied to record numbers icvrec/layer |
- a global sum is applied to record numbers icvrec/layer |
| 267 |
out of grdchk_loc so that they be passed to I/O routines. |
out of grdchk_loc so that they be passed to I/O routines. |
| 268 |
o pkg/smooth : |
o pkg/smooth: |
| 269 |
- fix recomputation that appeared with nlfs : use smooth_recip_hFacC, |
- fix recomputation that appeared with nlfs : use smooth_recip_hFacC, |
| 270 |
smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case. |
smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case. |
| 271 |
o verification/testreport: |
o verification/testreport: |
| 272 |
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch