4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
5 |
============================== |
============================== |
6 |
|
|
7 |
|
o pkg/ggl90: fix computation of control volumes for the case of |
8 |
|
ALLOW_GGL90_HORIZDIFF (probably not used very often): move control volumes |
9 |
|
up half a grid cell from C-centered to W-centered (pointed out by C. Eden) |
10 |
|
o pkg/seaice: simplify seaice_evp by avoiding use of extra fields u/vIceC |
11 |
|
o pkg/autodiff |
12 |
|
- Add inAdMode switch for SEAICEuseDYNAMICS: |
13 |
|
SEAICEuseDYNAMICSinAdMode |
14 |
|
(extend logic in ADAUTODIFF_INADMODE_SET) |
15 |
|
o pkg/seaice |
16 |
|
- Step 1 of merging ice-thickness distribution (ITD) code from |
17 |
|
MITgcm_contrib/torge/itd/ (author: Torge Martin) |
18 |
|
The code implements concept laid out in Thorndike et al. (1975); |
19 |
|
code is enabled via CPP flag SEAICE_ITD |
20 |
|
nITD (in SEAICE_SIZE.h) defines number of ice thickness categories; |
21 |
|
code is not complete yet!! |
22 |
|
- SEAICE_SIZE.h now included in almost all seaice routines |
23 |
|
o verification (using seaice): |
24 |
|
- switch back seaice-dynamics (+ lower SOLV_MAX_ITERS) in ADM exp. |
25 |
|
global_ocean.cs32x15.seaice ; update results. |
26 |
|
- compile B-grid dynamics in FW test exp 1D_ocean_ice_column ; |
27 |
|
- compile C-grid dynamics with #define SEAICE_ALLOW_JFNK in FW test exp |
28 |
|
offline_exf_seaice (previously compiling B-grid). |
29 |
|
o pkg/exf: |
30 |
|
- fix some STOP conditions in exf_check.F (from Aug 28, modifs did not allow |
31 |
|
to specify neither just 1 comp of wind or wind-stress, nor no surface momentum |
32 |
|
forcing): just replace CPP option ALLOW_ATM_WIND with run-time param useAtmWind. |
33 |
|
o pkg/layers (adjust changes from Sept 19): |
34 |
|
- do snap-shot output and fill diagnostics from inside iLa loop (layers_calc.F) |
35 |
|
this allows to remove "layers_maxNum" dimension from all layers arrays. |
36 |
|
o pkg/layers (adjust changes from Sept 19): |
37 |
|
- remove ALLOW_LAYERS_OUTPUT ; fix snap-shot and time-ave output ; |
38 |
|
- snap-shot extended to all type of layers (not just the 1rst type); |
39 |
|
- remove layers variables when corresponding CPP option is undef. |
40 |
|
o pkg/layers: |
41 |
|
- rename pkg/layers variable and add new output (layer exist & un-weighted |
42 |
|
velocity in layer) |
43 |
|
o pkg/seaice: |
44 |
|
- simplify (?) ocean-drag coefficent computations by using |
45 |
|
the same routine in all three solvers (saves some code lines) |
46 |
|
- remove global fields DRAGA and DRAGS from C-grid code and |
47 |
|
declare them locally in lsr.F (the only place where they are |
48 |
|
still used) |
49 |
|
- update AD output of lab_sea.evp (very sensitive anyway). |
50 |
|
o pkg/seaice: add Jacobian-free Newton Krylov solver for ice dynamics |
51 |
|
(Lemieux et al. 2010, 2012). Turn on with the usual SEAICE_ALLOW_JFNK |
52 |
|
and SEAICEuseJFNK=.true. A few things to note: |
53 |
|
- involves a FGMRES, that is parallel but very inefficient, |
54 |
|
because of many scalar products (global sums) in the Gram-Schmidt |
55 |
|
orthogonalization method. Needs to be replaced. Original code |
56 |
|
from J.-F. Lemieux |
57 |
|
- preconditioner for FGMRES is a stripped down version of LSOR |
58 |
|
- SOLV_MAX_ITERS is now used for LSOR as a solver and as a |
59 |
|
preconditioner. For the preconditioner, the default is set to 10. |
60 |
|
- Jacobian times vector is computed with finite differences |
61 |
|
- marginally related to JFNK-solver: add a smooth regularization for |
62 |
|
zeta with tanh that will improve convergence (Lemieux and Tremblay, |
63 |
|
2009) for any implicit solver (not implemented for EVP because EVP |
64 |
|
does not need this regularization in the first place). Define |
65 |
|
SEAICE_ZETA_SMOOTHREG in SEAICE_OPTIONS.h to use. |
66 |
|
o eesupp/src: |
67 |
|
- check in genmake2 that intrinsic S/R flush is available. |
68 |
|
- add S/R to flush IO unit (if intrinsic S/R flush is available) |
69 |
|
- flush standard & error msg unit before MPI termination |
70 |
|
- if debugMode, flush IO unit after printing msg |
71 |
|
o pkg/ctrl: |
72 |
|
- ctrl_unpack.F, ALLOW_GENARR3D_CONTROL code: fix missing argument in call |
73 |
|
to ctrl_set_unpack_xyz. |
74 |
|
|
75 |
|
checkpoint64 (2012/10/09) |
76 |
|
o pkg/shelfice |
77 |
|
- in mom_fluxform.F, mom_vecinv.F: |
78 |
|
CALL SHELFICE_V_DRAG(bi,bj,k,vFld,KE,KappaRU,vF,myThid) |
79 |
|
Bug fix KappaRU -> KappaRV |
80 |
|
does not change verification/isomip but may change other setups |
81 |
|
(presumably constant KappaRU=KappaRV) |
82 |
|
- fix diagnostics SHIU/Vdrag (thanks to Tom Millgate) |
83 |
|
o pkg/obcs: |
84 |
|
- fixed some indexing bugs in obcs_seaice_sponge.F |
85 |
|
- added obcs relaxation subroutines for HSALT and HSNOW |
86 |
|
- changes verification/seaice_obcs/results/obcs_seaice_sponge.F |
87 |
|
o pkg/seaice: |
88 |
|
- add "multicategory" parameterization for snow in analogy to ice, |
89 |
|
default is off for now. |
90 |
|
o pkg/obcs: |
91 |
|
- added obcs_seaice_sponge.F for obcs relaxation of seaice variables; |
92 |
|
see verification/seaice_obcs/input.seaiceSponge for example application. |
93 |
|
- remove local commom bloc "OBCS_GLOBAL" in obcs_readparms.F and do all the OB |
94 |
|
index setting by master-thread. This fix multi-threads Pb in previous modifs. |
95 |
|
o pkg/layers : |
96 |
|
- add diagnostics to pkg/layers |
97 |
|
- move the meat of pkg/layers from layers_calc.F to layers_fluxcalc.F |
98 |
|
(from R.Tulloch). Layers_calc.F now calls layers_fluxcalc.F accordingly. |
99 |
|
o pkg/generic_advdiff/gad_implicit_r.F : |
100 |
|
- fix ADVr diagnostics in case of both implicit vertical advection and diffusion. |
101 |
|
o pkg/seaice/seaice_growth.F: |
102 |
|
- fix SItflux diagnostics in virtual salt flux + balanceEmpmr case. |
103 |
|
o pkg/obcs: |
104 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
105 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
106 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
107 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
108 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
109 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
110 |
|
o pkg/obcs: |
111 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
112 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
113 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
114 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
115 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
116 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
117 |
|
to replace hard-coded null index value of zero. |
118 |
|
o pkg/exch2: |
119 |
|
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
120 |
|
always check buffer-size (but outside the loop); move checking for valid |
121 |
|
index from W2_USE_E2_SAFEMODE to W2_E2_DEBUG_ON; in W2_E2_DEBUG_ON, |
122 |
|
print each tile and point connection only if |W2_printMsg|>= 2 and 3. |
123 |
|
o pkg/ctrl (pack & unpack): |
124 |
|
- in ctrl_pack.F & ctrl_unpack.F, use the same local file-name variable |
125 |
|
(locally defined) for different variables (+ remove the variable-specific |
126 |
|
file name in CTRL_GENARR.h). For now, only implemented for GENARR2/3D_CONTROL |
127 |
|
(to be extended to other local file names in ctrl.h). |
128 |
|
o pkg/flt: |
129 |
|
- add a FLT_Iter0 option (similar to PTRACERS_Iter0). |
130 |
|
o pkg/mdsio: |
131 |
|
- fix missing STOP in mdsio_readvec_loc.F (case ioUnit=0) when file is missing |
132 |
|
o tools/genmake2: |
133 |
|
- add similar dependences for target EXE_AD & EXE_FTL as we have for EXECUTABLE |
134 |
|
(added by Alistair in version 1.51 for building without make depend); |
135 |
|
- remove Header files list (H_SRC_FILES) from the dependence of targets |
136 |
|
ad_input_code.f & ftl_input_code.f (not clear why it was added in the first |
137 |
|
place in version 1.23): this save going through staf when unrelated header |
138 |
|
file has been modified. |
139 |
|
Note: for an intermediate target (e.g., ad_input_code.f or adtaf) without |
140 |
|
"make depend" step, still need to do "make links" before "make adtaf". |
141 |
|
o eesupp/src (+ few pkg src files) & genmake2: |
142 |
|
- finish to remove ALWAYS_USE_MPI in source code that TAF does not see; |
143 |
|
- no longer set ALWAYS_USE_MPI in Makefile (was done by genmake2). |
144 |
|
- improve genmake2 checking for ALLOW_${PKG} in CPP_OPTIONS.h files (distinguish |
145 |
|
upper/lower case ; account for space between "#" and undef/define) |
146 |
|
o pkg/flt (with exch2): |
147 |
|
- cleaning: fix so that it compiles; move remaining MPI calls out of flt_exch2.F; |
148 |
|
- simplify threads synchronisation; fix (many issues) multi-threaded with MPI. |
149 |
|
|
150 |
|
checkpoint63s (2012/09/05) |
151 |
|
o pkg/ecco: |
152 |
|
- remove #ifdef ALLOW_SMOOTH_CORREL3D brackets. |
153 |
|
- add more relevant #ifdef ALLOW_SMOOTH ones. |
154 |
|
- sort out useAtmWind, useSMOOTH, ctrlSmoothCorrel2D. |
155 |
|
o pkg/ctrl: |
156 |
|
- CTRL_OPTIONS.h : document CPPs related to smoothing; ALLOW_SMOOTH_CORREL2D/3D, |
157 |
|
ALLOW_CTRL_SMOOTH, ALLOW_SMOOTH_CTRL2D, ALLOW_SMOOTH_CTRL3D. |
158 |
|
- ctrl.h : document run time params doInitXX, doMainPack, doMainUnpack, doPackDiag, |
159 |
|
doSinglePrecTapelev (audodiff param!), ctrlSmoothCorrel2D (new) and |
160 |
|
ctrlSmoothCorrel3D (new). |
161 |
|
The added ctrlSmoothCorrel2D/3D replace the old ALLOW_SMOOTH_CORREL2D/3D CPP. |
162 |
|
- ctrl_readparms.F : initialise ctrlSmoothCorrel2D/3D and read from namelist. |
163 |
|
- ctrl_init.F ctrl_pack.F ctrl_unpack.F : switch off ustress/vstress |
164 |
|
controls when useAtmWind, and vice versa. |
165 |
|
- ctrl_map_ini_ecco.F : UVEL0, VVEL0, edtaux, edtauy cannot be smoothed as tracers. |
166 |
|
- ctrl_get_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL2D with |
167 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel2D, IF useSMOOTH. |
168 |
|
- ctrl_map_ini_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL3D with |
169 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel3D, IF useSMOOTH. |
170 |
|
- ctrl_set_pack_xy[z].F, ctrl_set_unpack_xy[z].F: |
171 |
|
replace ALLOW_SMOOTH_CORREL2D/3D brackets with ctrlSmoothCorrel2D/3D. |
172 |
|
o pkg/smooth: |
173 |
|
- remove un-necessary includes. |
174 |
|
- remove ALLOW_SMOOTH*D and ALLOW_SMOOTH_CORREL*D brakets. |
175 |
|
Those CPP options were never defined, and not necessary. |
176 |
|
o model/src: |
177 |
|
- fix CPP brackets in ini_mixing.F (GM_background_K belongs to gmredi). |
178 |
|
- standard treatment of useSMOOTH. |
179 |
|
o pkg/autodiff: |
180 |
|
- add LOGICAL useGGL90inAdMode, useGGL90inFwdMode, useSALT_PLUMEinAdMode, |
181 |
|
useSALT_PLUMEInFwdMode allowing to switch off ggl90 and salt_plume adjoint. |
182 |
|
o pkg/exch2: |
183 |
|
- add "if usingMPI" where it was missing (in exch2_rx?_cube*.template) |
184 |
|
+ start to remove ALWAYS_USE_MPI in source code that TAF does not see. |
185 |
|
- make new S/R W2_MAP_PROCS out of w2_eeboot.F to setup exch2 CommonFlag |
186 |
|
and tiles to process mapping. |
187 |
|
- re-arrange 3 header files (W2_EXCH2_PARAMS.h, _BUFFER.h & _TOPOLOGY.h) |
188 |
|
moving /EXCH2_FILLVAL_RX/ & /W2_EXCH2_COMMFLAG/ to W2_EXCH2_TOPOLOGY.h; |
189 |
|
rename "exch2_tProc" to "W2_tileProc" and move seting of e2FillValue_RX |
190 |
|
from w2_eeboot.F to w2_readparms.F. |
191 |
|
o eesupp/src: |
192 |
|
- set exchNeedsMemsync & exchUsesBarrier according to "usingMPI" (instead of |
193 |
|
ALWAYS_USE_MPI) + moved from ini_communication_patterns.F to eeset_parms.F; |
194 |
|
also move setting of exchCollectStatistics from exch_init.F to eeset_parms.F |
195 |
|
- in eedie.F and all_proc_die.F, always call MPI_FINALIZE when ALLOW_USE_MPI |
196 |
|
is defined (remove condition on usingMPI) to match cases where MPI_INIT |
197 |
|
has been called. |
198 |
|
- fix bug I put in previous modif of exch_sm_3d_rx.template (not much used); |
199 |
|
- change default (non-MPI) value of myPid (from 1 to 0) to match MPI settings |
200 |
|
(so that on 1 proc, get same myPid independently of usingMPI) |
201 |
|
- add a stop if multi-procs but usingMPI=F ; stop also if usingMPI=T and |
202 |
|
useCubedSphereExchange with EXCH-1 (safer). |
203 |
|
- add "if usingMPI" where it was missing (+ start to remove ALWAYS_USE_MPI). |
204 |
|
o pkg/ggl90: |
205 |
|
- fix bug in filling corner mask array "mskCor" (FILL_CS_CORNER_TR_RL call) |
206 |
|
used in ALLOW_GGL90_SMOOTH code. |
207 |
|
o pkg/flt: |
208 |
|
- fix typo in FLT_WITHOUT_Y_PERIODICITY (the effect was to ignore stopping |
209 |
|
floats at the Southern end of the domain). |
210 |
|
o eesupp/inc: |
211 |
|
- add a list of CPP-options which can be set by Makefile (DEF_IN_MAKEFILE.h); |
212 |
|
but not used (and not to be used) anywhere, just for documentation. |
213 |
|
o pkg/autodiff, exf, ptracers & seaice (AD & TL output): |
214 |
|
- comment out the very nasty "writeBinaryPrec = writeStatePrec" line, since: |
215 |
|
a) can damage previously written records in any other multi-record files. |
216 |
|
b) if needed, can easily do it cleanly, by calling S/R WRITE_REC_3D_RL/S. |
217 |
|
o tools/genmake2: |
218 |
|
- define variable MAKE within Makefile and use it in place of 'make'; |
219 |
|
- update AD_CONFIG.h (if needed) before building any of the executable |
220 |
|
(forward, adjoint or tangent-lin); this involves a 2nd invocation of make; |
221 |
|
and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h; |
222 |
|
- always print usual warning comment 'this file is automatically generated' |
223 |
|
from script convert_cpp_cmd2defines (+ remove this warning from genmake2). |
224 |
|
o pkg/cheapaml: |
225 |
|
- updated to correspond to the code used in accepted paper (Nico Wienders). |
226 |
|
o pkg/exf: |
227 |
|
added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch. |
228 |
|
ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F) |
229 |
|
and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h). |
230 |
|
o pkg/exf, autodiff, ctrl, ecco and seaice: |
231 |
|
remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones. |
232 |
|
o pkg/ctrl, ecco: |
233 |
|
allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL. |
234 |
|
Depending on useAtmWind, one is inactive, and the other is active (see |
235 |
|
exf_getffields.F/exf_getsurfacefluxes.F). |
236 |
|
o tools/genmake2: |
237 |
|
- improve error msg when failing in 2nd test of check_for_broken_Ff |
238 |
|
- fix option '-makefile' short-name (-mf according to genmake2 -help) |
239 |
|
- source local config file "genmake_local" just after processing the genmake2 |
240 |
|
command arguments (previously done before processing arg). |
241 |
|
o pkg/grdchk: |
242 |
|
- add a call to TURNOFF_MODEL_IO for Tangent-Linear run (in this case, call |
243 |
|
to this routine from cost_final has been dropped in g_cost_final) |
244 |
|
- improve printed information (more explicit msg, no longer using "print *," |
245 |
|
fix fcpertminus printed value). |
246 |
|
o model/src: |
247 |
|
- move call to COST_INIT_VARIA out of packages_init_variables.F directly |
248 |
|
into initialise_varia.F (just after calling PACKAGES_INIT_VARIABLES): |
249 |
|
this prevents getting cost-funct reset in adinitialise_varia recomputations. |
250 |
|
o pkg/dic: |
251 |
|
- move initialisation of "freefe" array from from dic_biotic_forcing.F to |
252 |
|
fe_chem.F: this prevents TAF from dropping this initialisation in TLM code. |
253 |
|
o pkg/grdchk: |
254 |
|
- grdchk_main.F : added CALL GLOBAL_SUM_INT( ierr , myThid ) |
255 |
|
- grdchk_getadxx.F etc. : omit I/O if ierr.EQ.0 |
256 |
|
o pkg/autodiff/ctrl/grdchk : |
257 |
|
- attempt to sort out what works and what does not, |
258 |
|
with regard to I/O, and to warn/stop accordingly. |
259 |
|
o pkg/grdchk: |
260 |
|
- attempt to fix grdchk in the case of useSingleCpuIO. |
261 |
|
- "if ( myProcId .EQ. grdchkwhichproc .AND. ierr .EQ. 0 )" |
262 |
|
statements were moved from grdchk_main.F and into |
263 |
|
grdchk_getadxx.F grdchk_getxx.F grdchk_setxx.F. |
264 |
|
- a global sum is applied to record numbers icvrec/layer |
265 |
|
out of grdchk_loc so that they be passed to I/O routines. |
266 |
|
o pkg/smooth: |
267 |
|
- fix recomputation that appeared with nlfs : use smooth_recip_hFacC, |
268 |
|
smooth_hFacW, smooth_hFacS (copied at init_fixed) in 3d case. |
269 |
|
o verification/testreport: |
270 |
|
- add option '-tlm' for Tangent-Linear test (-adm,-oad,-tlm are all exclusive); |
271 |
|
- can also use compressed (gzip) reference output file; |
272 |
|
- change format (in pkg/grdchk) of TLM output (+ add forward gradient) |
273 |
|
to be easier to collect by testreport. |
274 |
|
- update existing TLM output (half out-of-date by more than 3 yrs). |
275 |
|
- report NETCDF & LAPACK settings (from genmake2) in output dir. |
276 |
|
- report run-time in each individual summary (previously only for AD test); |
277 |
|
for TLM test, add also TAF version. |
278 |
|
- add daily TLM test on (old) aces cluster + weekly test on baudelaire. |
279 |
|
|
280 |
|
checkpoint63r (2012/08/15) |
281 |
|
o tools/genmake2: |
282 |
|
- fix Makefile for target ftlall (+ update files to clean after make ftlall) |
283 |
|
o pkg/ecco/ecco_cost_final.F : |
284 |
|
- fix fc print statements (to stdout and costfunction0000) so |
285 |
|
that the printed value is always after the global sum. |
286 |
|
o pkg/seaice/seaice_dynsolver.F : |
287 |
|
- fix ice strength assymptote at SEAICE_area_max<1 |
288 |
|
(no change for the standard case of SEAICE_area_max=1) |
289 |
|
o some cleaning: |
290 |
|
- pkg source files: ensure that all *.F files from each pkg included the |
291 |
|
corresponding ${PKG}_OPTIONS.h file (except stand-alone src file which |
292 |
|
only includes CPP_EEOPTIONS.h); fix S/R CTRL_SMOOTH ; update AD experiment |
293 |
|
code_ad/*.F src files; add new option-file in pkg/admtlm + corresponding |
294 |
|
includes; |
295 |
|
- model/src: add PACKAGES_CONFIG.h wherever ALLOW_AUTODIFF[_TAMC] is used. |
296 |
|
- ALLOW_DIFFKR_CONTROL: add a stop in S/R CTRL_CHECK in case ALLOW_3D_DIFFKR |
297 |
|
is undef; also define /DYNVARS_DIFFKR/ common block in DYNVARS.h when |
298 |
|
ALLOW_DIFFKR_CONTROL is defined, to allow to compile and reach this stop. |
299 |
|
- update option-file CPP_OPTIONS.h of all AD experiments: |
300 |
|
* no longer include PACKAGES_CONFIG.h ; |
301 |
|
* includes ECCO_CPPOPTIONS.h if PACKAGES_CONFIG.h has been included ; |
302 |
|
* def/undef ALLOW_3D_DIFFKR independently of ALLOW_DIFFKR_CONTROL (before |
303 |
|
including ECCO_CPPOPTIONS.h). |
304 |
|
o pkg/cost, pkg/ctrl, pkg/ecco option-file: |
305 |
|
- clean-up and split content of old pkg/ecco/ECCO_CPPOPTIONS.h file into |
306 |
|
separated pkg option-file (done according to old doc from ECCO_CPPOPTIONS.h, |
307 |
|
not necessary accurate). |
308 |
|
- add a template for option-file ECCO_CPPOPTIONS.h, mostly empty, in |
309 |
|
pkg/autodiff, i.e., the 1rst pkg to compile for adjoint built, with lines to |
310 |
|
deliberately break compilation (a remainder that it needs to be customized) |
311 |
|
- in pkg/ecco, includes ECCO_OPTIONS.h instead of COST_OPTIONS.h |
312 |
|
- rename COST_CPPOPTIONS.h to COST_OPTIONS.h |
313 |
|
- rename CTRL_CPPOPTIONS.h to CTRL_OPTIONS.h |
314 |
|
o tools/genamke2: |
315 |
|
- check for lapack. |
316 |
|
o pkg/cost and pkg/ecco : attempt to sort out some of the limiting intricacies. |
317 |
|
- pkg/cost.cost_final.F : allow for use of pkg/ecco and pkg/cost cost functions |
318 |
|
jointly. The exclusive ifdefs were removed, to add costs terms (when defined) |
319 |
|
from both packages. |
320 |
|
- the fc global sum in pkg/ecco/ecco_cost_final.F was removed accordingly. |
321 |
|
- for objf_atl we use either the pkg/ecco or the pkg/cost term depending on CPPs. |
322 |
|
- pkg/ecco and model/src : add CPP brackets around pkg/cost and pkg/ctrl includes |
323 |
|
of "CTRL_SIZE.h" "ctrl.h" "ctrl_dummy.h" "optim.h" / "cost.h" accordingly. |
324 |
|
o pkg/cost : add comments to explain special and/or untested setups. |
325 |
|
o pkg/exf: |
326 |
|
- use EXF_OPTIONS.h to set pkg/exf options except if done in ECCO_CPPOPTIONS.h |
327 |
|
(previously, ALLOW_AUTODIFF_TAMC was controling this switch). |
328 |
|
o verification/*/code_ad: |
329 |
|
mimimal cleaning of AD experiments ECCO_CPPOPTIONS.h option-file: |
330 |
|
- reccord when this file is included (define ECCO_CPPOPTIONS_H) |
331 |
|
- remove the most obvious obsolete features (e.g., #define ALLOW_COST not |
332 |
|
allowed since Oct 2003 in any option-file except in PACKAGES_CONFIG.h) |
333 |
|
o pkg/seaice : |
334 |
|
- added possibility to change ice strength/PRESS0 relationship to |
335 |
|
HEFF, according to the following run time parameters |
336 |
|
SEAICEpresPow0 :: HEFF exponent for ice strength below SEAICEpresH0 (integer, >0) |
337 |
|
SEAICEpresPow1 :: HEFF exponent for ice strength above SEAICEpresH0 (integer, >0) |
338 |
|
SEAICEpresH0 :: HEFF threshold for ice strength (m) |
339 |
|
o pkg/ggl90 : |
340 |
|
- added run time flag mxlSurfFlag to include the code that ensure |
341 |
|
mixing between first and second level (previously included as a comment) |
342 |
|
o verification/1D_ocean_ice_column/input_ad/data.autodiff : |
343 |
|
- add test of newly added dumpAdByRec=T option where |
344 |
|
we write all records to one file per variable. |
345 |
|
o verification/global_ocean.cs32x15/code_ad/CPP_OPTIONS.h : |
346 |
|
- switch to #define ALLOW_BALANCE_RELAX and ALLOW_BALANCE_FLUXES |
347 |
|
to check that this code is ok with taf and compiles in adjoint. |
348 |
|
o pkg/autodiff : |
349 |
|
- added run time param dumpAdByRec : ad dump format switch. |
350 |
|
If true then write all records to one file per variable. |
351 |
|
Else write one file per record (remains the default). |
352 |
|
- revise seaice_ad_dump.F and exf_adjoint_snapshots_ad.F accordingly. |
353 |
|
o pkg/seaice: |
354 |
|
- Added SEAICEuseTILT run time switch : if set to |
355 |
|
false then omit the tilt term in seaice dynamics. |
356 |
|
- Fix free drift calculation. |
357 |
|
o pkg/shelfice: |
358 |
|
When initializing SHELFICEDragQuadratic, set default to be |
359 |
|
consistent with shiCdrag in case SHELFICEuseGammaFrict is used, |
360 |
|
but retain option to set it independently |
361 |
|
(inconsistenty spotted by Veronique Dansereau) |
362 |
|
o eesupp/inc: |
363 |
|
- in EEPARAMS.h, add real-type constant for some frequently used simple number |
364 |
|
(0,1,2,1/2), with name explicitly referring to RS/RL type. |
365 |
|
o model/src: |
366 |
|
- move balancing of relaxation terms to new S/R balance_relax.F. |
367 |
|
o pkg/autodiff: |
368 |
|
re-write active I/O high-level (control) S/R: |
369 |
|
- rename S/R ACTIVE_READ/WRITE_RL to ACTIVE_READ/WRITE_3D_RL |
370 |
|
- add 1 more argument (useCurrentDir) to replace the "_LOC" 2nd set of S/R. |
371 |
|
- use standard pkg/mdsio I/O routines (MDS_READ/WRITE_SEC_XZ/YZ and |
372 |
|
MDS_READ/WRITE_FIELD); change loops to multi-threads. |
373 |
|
- update and merge active_file_control_slice.flow into active_file_control.flow |
374 |
|
- update the calls in lower level S/R (active_file.F, active_file_g.F and |
375 |
|
active_file_ad.F) keeping the argument list and function unchanged. |
376 |
|
- also update lower-level "_LOC" version (call same S/R with "useCurrentDir |
377 |
|
=.TRUE.") and remove high-level (control) _loc version (not called anymore). |
378 |
|
- new low-level active I/O routines, one for each type (RL/RS), for active var |
379 |
|
of various (XY,XZ,YZ) shape and level number (arguments: arrShape, myNr); |
380 |
|
fix ctrl_init_wet.F & ecco_cost_weights.F by calling the new S/R with the |
381 |
|
right type. |
382 |
|
o autodiff and RS=real*4: |
383 |
|
- call the right type (_RS instead of _RL) of S/R in few output S/R (pkg/exf |
384 |
|
ad-monitor and snapshots); disable arrType='RS' in mdsio_gl*.F ; |
385 |
|
- change argument type of 3-D mask argument to _RS to match type in the call |
386 |
|
(in seaice_cost*.F, ctrl_*_gen.F and *ctrl_bound.F); to be continued. |
387 |
|
o pkg/thsice: |
388 |
|
- re-anable balanceEmPmR when useSEAICE=T with useThSIce=T. |
389 |
|
- option to correct ocean fresh-water flux for imbalance of Atmos+Land |
390 |
|
fresh-water flux: uniform correction or proportional to local precip. |
391 |
|
o pkg/ctrl: |
392 |
|
- new header file CTRL_SIZE.h for parameters maxCtrlArr2D, maxCtrlArr3D |
393 |
|
- redefine CPP option ALLOW_BOTTOMDRAG_CONTROL to |
394 |
|
ALLOW_BOTTOMDRAG_CONTROL_NONGENERIC |
395 |
|
- verification/hs94.1x64x5/ tests ALLOW_GENARR{2D,3D}_CONTROL |
396 |
|
|
397 |
|
checkpoint63q (2012/07/30) |
398 |
|
o pkg/autodiff: |
399 |
|
note about monitor and snap-shot of ad-variables: |
400 |
|
a) need to apply ADEXCH before monitor or output of ad-vars to include |
401 |
|
overlap contributions (was done for adjDump but missing for monitor). |
402 |
|
b) since ADEXCH implies adding overlap values to interior array, machine |
403 |
|
truncation error is expected when adding an ADEXCH call in the middle of |
404 |
|
the time-stepping (although mathematically identical). |
405 |
|
modifs: |
406 |
|
- fix some incorrect type (RL/RS, UV/scalar) in ADEXCH calls and ad-vars |
407 |
|
declaration (adEddyPsiX,adEddyPsiY in adcommon.h). |
408 |
|
- add new run-time params (dumpAdVarExch & mon_AdVarExch) to select how to |
409 |
|
apply ADEXCH before monitor or snap-shot of ad-variables: |
410 |
|
=0 : no ADEXCH ; =1 : do ADEXCH ; =2 : apply ADEXCH on a local copy. |
411 |
|
- implement new method (copy+adexch) for snap-shot and monitor of main model |
412 |
|
ad-vars (initially not used by default -> output unchanged). |
413 |
|
- change default (set to 2) to use new method and update few output_adm.txt |
414 |
|
with accurate ad-monitor (global_ocean.90x40x15, tutorial_global_oce_biogeo |
415 |
|
and both tutorial_tracer_adjsens tests). |
416 |
|
- switch 2 global_ocean.cs32x15 AD-tests to AB-2 (seaice_dynmix & thsice) |
417 |
|
and turn off momDissip_In_AB in the 2 other (needed for stable AB-3). |
418 |
|
o pkg/ctrl: |
419 |
|
enable the use of a variable number (maxCtrlArr2D, maxCtrlArr3D) of |
420 |
|
generic control variables via |
421 |
|
#define ALLOW_GENARR2D_CONTROL and/or #define ALLOW_GENARR3D_CONTROL |
422 |
|
Only required customization should be S/R ctrl_map_ini_genarr.F |
423 |
|
(routine in repository contains example) |
424 |
|
o pkg/exf: |
425 |
|
- fix and refine checking of surface-relaxation setting when using EXF |
426 |
|
o verification (adjoint exp): |
427 |
|
- reduce length of simulation by half for experiment global_ocean.cs32x15 |
428 |
|
(std, seaice & seaice_dynmix) and exp tutorial_dic_adjoffline; update output. |
429 |
|
o pkg/mom_common (mom_u/v_bottomdrag), pkg/shelfice (shelfice_u/v_drag) |
430 |
|
- replace if statements KE.ne.0 with KE.gt.0 to avoid sqrt of negative numbers |
431 |
|
of KE that can occur with aggressive optimization |
432 |
|
+ put quadratic bottom drag calculation in separated loops (only done if |
433 |
|
using bottomDragQuadratic) |
434 |
|
o model/src: CG2D_NSA |
435 |
|
- clean-up: stop if cg2dNormaliseRHS=T and AUTODIFF |
436 |
|
and replace GLOBAL_SUM calls with GLOBAL_SUM_TILE. |
437 |
|
- in test-exp that uses CG2D_NSA (bottom_ctrl & tutorial_tracer_adjsens), |
438 |
|
change cg2d residual target to be expressed in Wunits (=> do not normalise |
439 |
|
RHS ; this fix global_max Pb with TAF); update output. |
440 |
|
o verification/tutorial_tracer_adjsens: |
441 |
|
improve parameter consistency (and get rid of warnings): |
442 |
|
- use deltaTFreeSurf=deltaTtracer (better with NonLin FreeSurf); |
443 |
|
- switch Temp Adv Scheme from 81 to 80 (no limiter since theta < 0 is physical) |
444 |
|
- use staggerTimeStep (for stability) in som81; use default rotation period. |
445 |
|
o pkg/exch2: |
446 |
|
- with empty facet: fix compact-format (W2_mapIO=1) definition (was previously |
447 |
|
reset to 0 = 1 long line in X) |
448 |
|
o pkg/mdsio: |
449 |
|
- fix reading of dimensions from meta file for large-size domain |
450 |
|
o model/src: |
451 |
|
- fix saltIsActiveTr setting for IdealGas eosType (eosType is 6 character long); |
452 |
|
- to refine CS-grid check, add logical flag "hasWetCSCorners": true if using |
453 |
|
Cubed-Sphere Exch with CS-corners inside the domain; |
454 |
|
make new S/R INI_GLOBAL_DOMAIN from code in ini_linear_phisurf.F to calculate |
455 |
|
globalArea and to set hasWetCSCorners. |
456 |
|
- add warning if usingCurvilinearGrid and momAdvection in flux-form (missing |
457 |
|
metric terms); stop if hasWetCSCorners=T and momAdvection in flux-form. |
458 |
|
- re-activate the stop if useCDscheme and hasWetCSCorners=T (previously if |
459 |
|
useCDscheme and useCubedSphereExchange). |
460 |
|
o pkg/seaice/seaice_growth.F : |
461 |
|
- compute the SEAICE_DISABLE_HEATCONSFIX term accordingly |
462 |
|
for the (.NOT.useRealFreshWaterFlux).OR.(nonlinFreeSurf.EQ.0) |
463 |
|
when the previous code was not correct. |
464 |
|
- in all cases diagnoze the boundary condition mismatch to SIaaflux |
465 |
|
- in the case of useRealFreshWaterFlux.AND.(nonlinFreeSurf.GT.0) add |
466 |
|
that term to QNET (essentially to set the melt/freeze water to 0degC). |
467 |
|
when SEAICEheatConsFix is true, so that the ocean+ice budget heat is closed. |
468 |
|
o verification/global_ocean.cs32x15/input.seaice : |
469 |
|
- add SEAICEheatConsFix in data.seaice, ensuring closed ocean+ice heat budget. |
470 |
|
- add diagnostics (commented out) for budget test using my matlab codes (gcmfaces). |
471 |
|
- update results (output.seaice.txt) accordingly. |
472 |
|
o verification/lab_sea/input/data.seaice : |
473 |
|
- remove SEAICEheatConsFix, which is now be tested |
474 |
|
in global_ocean.cs32x15. The presently coded fix |
475 |
|
is only consistent with real fresh water + nlfs. |
476 |
|
- update results (output.txt) accordingly. |
477 |
|
o pkg/salt_plume: added diagnotic for salt tendency (oceSPtnd). |
478 |
|
o AD_CONFIG.h file: |
479 |
|
- in genmake2: remove "#undef ALLOW_ECCO_OPTIMIZATION" from AD_CONFIG.h; |
480 |
|
- remove #include "AD_CONFIG.h" from all included OPTIONS files and |
481 |
|
add it explicitly in each fortran src file where it is needed. |
482 |
|
motivation: header file AD_CONFIG.h is generated/modified after "make depend" |
483 |
|
thus introducing potentially wrong dependency; therefore, better to include |
484 |
|
it only where it's really needed, and after any other included OPTIONS file |
485 |
|
(less tempting to bring conditional includes according to ALLOW_ADJOINT_RUN |
486 |
|
or ALLOW_TANGENTLINEAR_RUN). |
487 |
|
|
488 |
|
checkpoint63p (2012/07/06) |
489 |
|
o pkg/autodiff: |
490 |
|
- rename S/R INI_AUTODIFF to AUTODIFF_INIT_VARIA ; |
491 |
|
- create new header file "AUTODIFF_PARAMS.h" for pkg/autodiff parameters |
492 |
|
which are now read from new parameter file "data.autodiff" (inAdExact |
493 |
|
previously in "data", use{KPP/GMRedi/SEAICE}inAdMode previously in data.pkg) |
494 |
|
- add file "data.autodiff" in all verification/*/input_ad/ directories. |
495 |
|
- add run-time parameter to turn On/Off SEAICEuseFREEDRIFT in adjoint/forward |
496 |
|
mode (used in global_ocean.cs32x15.seaice_dynmix test exp.) |
497 |
|
o verification/tutorial_tracer_adjsens/ |
498 |
|
- add extra sub-verification which uses "SOM" advection scheme |
499 |
|
(2nd Order-Moment Advection Scheme, Prather Limiter) with |
500 |
|
#define GAD_ALLOW_TS_SOM_ADV in GAD_OPTIONS.h |
501 |
|
and in data: |
502 |
|
multiDimAdvection=.TRUE., |
503 |
|
tempAdvScheme=81, |
504 |
|
saltAdvScheme=81, |
505 |
|
o model/src: |
506 |
|
- introduce ALLOW_BALANCE_RELAX which allow the removal |
507 |
|
of the global mean of relaxation terms by setting |
508 |
|
balanceThetaClimRelax and balanceSaltClimRelax |
509 |
|
- disable balanceEmPmR and balanceQnet in the case when useSeaice. |
510 |
|
This case is now treated appropriately in seaice_growth.F |
511 |
|
o pkg/seaice: |
512 |
|
- do balanceEmPmR and balanceQnet based on the net fluxes |
513 |
|
(SItflux) that enter the ocean+ice system rather than QNET |
514 |
|
and EMPMR. Works best in real fresh water. |
515 |
|
- SIatmFW, SIatmQnet, and SItflux computations had to be moved |
516 |
|
out of the diagnotics bloc, and stored in global arrays. |
517 |
|
|
518 |
|
checkpoint63o (2012/06/29) |
519 |
|
o vertical mixing schemes: |
520 |
|
- remove unused S/R CALC_BUOYANCY (left from branch-atmos merging) |
521 |
|
- replace computation of density (in Function STATE1, opps_calc.F) by a call |
522 |
|
to S/R FIND_RHO_SCALAR |
523 |
|
- pass sigmaR to S/R PP81_CALC, MY82_CALC (but not yet used) and to GGL90_CALC |
524 |
|
and use it for N^2 calculation in ggl90_calc.F (save 2 density computations); |
525 |
|
affects output (vermix.ggl90) at truncation level. |
526 |
|
o testreport: |
527 |
|
- change adjustment of SIZE.h for mpi+mth testing: preserve enough tiles |
528 |
|
(nSx,nSy) for the number of threads (from eedata.mth) |
529 |
|
o model/src: |
530 |
|
- remove 2nd set of calls at the top of initialise_varia.F (Adjoint part) |
531 |
|
related to Non_Lin Free-Surf or Bottom-Control (but not longer necessary). |
532 |
|
o verification/tutorial_tracer_adjsens/ |
533 |
|
- compile with ALLOW_CG2D_NSA |
534 |
|
- run with nonlinFreeSurf=3 |
535 |
|
- update reference output_adm.txt |
536 |
|
o tools/genmake2: |
537 |
|
- add "-DHAVE_NETCDF" to the DEFINES list when NetCDF is available ; |
538 |
|
refine usePROFILES switching off (only when NetCDF is not available). |
539 |
|
o verification (atmospheric set-up): |
540 |
|
- change eosType='IDEALGAS' to eosType='IDEALG' to match variable declaration |
541 |
|
o pkg/profiles : refine profiles and files handling. |
542 |
|
o model/src and pkg/ecco : introduce run-time switch usePROFILES. |
543 |
|
o model/src/the_main_loop.F, forward_step.F and pkg/exf/EXF_OPTIONS.h : |
544 |
|
- changes to use model/src/the_main_loop.F rather than the ecco version |
545 |
|
in ecco type adjoint runs. |
546 |
|
o model/src: |
547 |
|
- move computation of recip of grid distance & area from INI_MASKS_ETC to INI_GRID |
548 |
|
- move setting of h0Fac[C,W,S] from INI_LINEAR_PHISURF to INI_MASKS_ETC |
549 |
|
- update_masks_etc.F: rename SMOOTH*_R4,R8 function to the corresponding type (RS,RL) |
550 |
|
o model/src: |
551 |
|
- fix S/R UPDATE_CG2D for ALLOW_DEPTH_CONTROL case (was empty before); |
552 |
|
update output of test experiment bottom_ctrl_5x5. |
553 |
|
o pkg/generic_advdiff: |
554 |
|
- implement vertical bi-harmonic diffusion (for now, only for T & S and |
555 |
|
only explicitly). |
556 |
|
o verification/bottom_ctrl_5x5/ |
557 |
|
update reference output (results changed quite some time ago, |
558 |
|
not sure when; but new reference results look ok in terms of grdchk) |
559 |
|
o verification/1D_ocean_ice_column/ |
560 |
|
For verification purposes, the exact adjoint rather than an approx. |
561 |
|
should be used (e.g., to comare against F.D. or TLM). |
562 |
|
removed autodiff_inadmode*_ad.F routines in code_ad/ |
563 |
|
Update results/ accordingly. |
564 |
|
o pkg/cal: |
565 |
|
- change cal_getdate.F so that output date is function of input time only |
566 |
|
(less ambiguous, not mixed up with input iteration number). |
567 |
|
- fix calendarDumps for non-zero phase-lag (S/R CAL_TIME2DUMP). |
568 |
|
o pkg/diagnostics: |
569 |
|
- implement calendarDumps also for stats-diags |
570 |
|
- implement calendarDumps also for snap-shot output (negative freq) |
571 |
|
- for now, ignores calendarDumps if non-zero phase-lag. |
572 |
|
|
573 |
|
checkpoint63n (2012/06/04) |
574 |
|
o model/src: |
575 |
|
- recompute rSurfW & S to ensure consistent column thickness (needed for rStar) |
576 |
|
between Sum_k(hFac*drF) and rSurf-rLow, for now only when using pkg/shelfice; |
577 |
|
- use h0FacC, W & S to compute hFac_surfC, W & S in calc_surf_dr.F (more |
578 |
|
similar to calc_r_star.F); update results of experiment internal_wave and |
579 |
|
tutorial_global_oce_in_p (affected @ truncation level). |
580 |
|
o pkg/shelfice: |
581 |
|
- add parameterisation of advective-diffusive flux into the ice shelf |
582 |
|
according to Holland and Jenkins (1999), eq.22-33, as suggested by Jan De Ryd |
583 |
|
- simply eps3/3a computation |
584 |
|
o eesupp: |
585 |
|
- add new CPP option (DISCONNECTED_TILES) to disconnect tiles (no exchange |
586 |
|
between tiles, just fill-in edges assuming locally periodic subdomain) and |
587 |
|
add corresponding exchange subroutines (EXCH0); |
588 |
|
- new CG-solver version (_EX0) for disconnected-tiles special case. |
589 |
|
o model/src (CG-solvers): |
590 |
|
- modify Single-Reduction version (CG2D_SR) in case cg2dMaxIters is reached |
591 |
|
(similar final residual output and max-Iter number as with standard version); |
592 |
|
- allows to store and use lowest-residual solution (standard & _SR versions); |
593 |
|
- cleaning up (remove old, commented out code, LETS_MAKE_JAM ...). |
594 |
|
- by default, also compile CG2D_SR version (define ALLOW_SRCG in CPP_OPTIONS.h) |
595 |
|
o eesup/src: |
596 |
|
- global_vec_sum.F cleaning: add a BARRIER ; update comments ; remove ndef |
597 |
|
ALWAYS_USE_MPI (no longer needed after fixing usingMPI settings - March 2012) |
598 |
|
o pkg/salt_plume added to lab_sea/input_ad.noseaicedyn |
599 |
|
|
600 |
|
checkpoint63m (2012/04/27) |
601 |
|
o pkg/shelfice: |
602 |
|
- account for partical cells in surface level below ice-shelf for hydrostatic |
603 |
|
pressure calculion (set uniformFreeSurfLev to F); update isomip experiments. |
604 |
|
o ad test experiments: |
605 |
|
- update and rename to "ad_optfile.local" local AD-optfile specific to a |
606 |
|
particular adjoint verification experiment (in verification/*/code_ad/) |
607 |
|
o pkg/seaice & pkg/exf: |
608 |
|
- Part two of ECCO-CLIVAR code merges. |
609 |
|
Completes merge of seaice area relax. code. |
610 |
|
Requires unified CPP option EXF_ALLOW_SEAICE_RELAX |
611 |
|
to be set in EXF_OPTIONS.h since this pkg controls its I/O |
612 |
|
(and avoids second CPP option in SEAICE_OPTIONS.h) |
613 |
|
- change default value of costIceStart & costIceEnd to a valid date. |
614 |
|
- add snowPrecip to HSNOW in seaice_growth |
615 |
|
o pkg/ptracers: |
616 |
|
- move ptracers summary and setup check into separated S/R ; add a check for |
617 |
|
valid PTRACERS_Iter0 value (error+stop or just warning). |
618 |
|
o pkg/cal (+ pkg/ecco): |
619 |
|
- avoid calling a S/R with 2 times the same arg (FWD: unless both are only used |
620 |
|
as input; and for AD, unless both are not differentiable (e.g., k index)). |
621 |
|
o model/src: |
622 |
|
- define internal flag "uniformFreeSurfLev" (=T when free-surface level-index |
623 |
|
is everywhere k=1) to speed-up some calculations (by pass kSurf reference); |
624 |
|
temporary set to usingZCoords value (to be changed to F when using shelfice). |
625 |
|
- hydrostatic pressure: implement partial cell near the surface also for |
626 |
|
Z-coordinates (for the case where uniformFreeSurfLev=F); replace test on |
627 |
|
usingZCoords with test on uniformFreeSurfLev where needed (in NonHyd code). |
628 |
|
o pkg/ctrl/ctrl_init.F: |
629 |
|
- add a formal parameter to s/r ctrl_init_rec to print |
630 |
|
xx_$(ctrl_valiable)_file for easier debugging |
631 |
|
- move call of cal_* routines into the if-block where they are really |
632 |
|
needed so that xx_$(ctrl_variable)_period can be 0 or -12 without having |
633 |
|
to specify a startdate |
634 |
|
o pkg/seaice: |
635 |
|
- update comments in SEAICE_OPTIONS.h (+ similar update of lab_sea/code and |
636 |
|
global_ocean.cs32x15/code versions). |
637 |
|
- turn on seaice Multi-category (in data.seaice, SEAICE_multDim=7) for |
638 |
|
verification experiment global_ocean.cs32x15.seaice and update results. |
639 |
|
o pkg/exf: |
640 |
|
- new S/R EXF_GETFIELD_START to return starting-time of a forcing field |
641 |
|
(according to useExfYearlyFields). |
642 |
|
o pkg/cal: |
643 |
|
- move calendar setting & summary (previously in cal_readparams.F) into new |
644 |
|
S/R CAL_INIT_FIXED to be called later in the initialisation process, once |
645 |
|
length of the simulation is set (after SET_PARMS call); This is an attempt |
646 |
|
to fix Pb when, e.g.: pkg/longstep, modifies the length of the run. |
647 |
|
- For safety: keep a record of pkg/cal parameter settings status |
648 |
|
to allow to STOP if one pkg/cal S/R is called too early. |
649 |
|
- add a stop in all basic pkg/cal subroutines if called before setting is done. |
650 |
|
- modify cal_getdate.F: stop when nothing was returned; |
651 |
|
if called with myIter=-1, simply retrun modelBaseDate (1,2 = startDate_1,_2); |
652 |
|
this allows to remove "cal.h" from seaice_read_parms.F & init_mnc_vars.F. |
653 |
|
|
654 |
|
checkpoint63l (2012/04/04) |
655 |
|
o pkg/bbl: |
656 |
|
- fix call to FIND_RHO_2D in bbl_calc_rho.F (case multi-tiles per proc); |
657 |
|
update global_with_exf output.yearly.txt file. |
658 |
|
o pkg/cal: |
659 |
|
- start to clean-up cal_set.F ; fix for the case where baseTime is non-zero. |
660 |
|
- remove 2 unsused and very short (1 line only) functions ; |
661 |
|
- remove unsused subroutines from AD-Diff list. |
662 |
|
o model/src: |
663 |
|
- start to implement clean wait to stop in initialization S/R (config_check.F, |
664 |
|
packages_check.F, ini_parms.F and pkg/obcs/obcs_check.F + pkg/mypackage) |
665 |
|
o folowing PRINT_MESSAGE changes: |
666 |
|
- remove reminder multiple print to the same file (STDOUT) when multi-threads. |
667 |
|
o pkg/bbl: |
668 |
|
- modification so it can work with z* |
669 |
|
- replace deltaT with dTtracerLev(k) for asynchronous time stepping |
670 |
|
- global_with_exf/input.yearly verification; changes output.yearly.txt |
671 |
|
o eesupp/src: |
672 |
|
- PRINT_MESSAGE: use OpenMP critical instruction (similar to PRINT_ERROR); |
673 |
|
writing to unit 0 (if unit=errorMessageUnit) extended to the case myThid=1 |
674 |
|
- CHECK_THREADS: specific code if using OpenMP threading: improve checking of |
675 |
|
# of threads across processors (e.g., different env OMP_NUM_THREADS setting) |
676 |
|
- improve special preliminary call to EESET_PARMS (if eedata is read 2 times). |
677 |
|
- when using MPI, always set usingMPI=T ; set default accordingly and stop |
678 |
|
if not consistent. |
679 |
|
- ALL_PROC_DIE: add a BARRIER after MPI_FINALIZE call ; skip this when thread |
680 |
|
argument is zero (in case called within single-thread section). |
681 |
|
o pkg/fizhi: |
682 |
|
clean-up turbulence cold-start switch: decided in fizhi_init_vars.F, stored |
683 |
|
in common bloc (fizhi_coms.h) and then passed as argument up to S/R TURBIO. |
684 |
|
o pkg/exch2: |
685 |
|
- add argument "updateCorners" to S/R exch2_get_uv_bounds (enable to |
686 |
|
activate EXCH_IGNORE_CORNERS in vector EXCH S/R). |
687 |
|
- switch 1rst EXCH call to IGNORE_CORNERS (instead of UPDATE_CORNERS) |
688 |
|
but keep the 2nd with UPDATE_CORNERS: this prevents overwriting good data |
689 |
|
with bad ones coming from a not-yet-updated halo. |
690 |
|
This should fix the problem when sNx <> sNy and GCD(sNx,sNy) < 2*Olx. |
691 |
|
o pkg/frazil: |
692 |
|
move FrzForcT diag from frazil_diagnostics_state.F to frazil_calc_rhs.F |
693 |
|
http://mitgcm.org/pipermail/mitgcm-devel/2012-March/005384.html |
694 |
|
o model/src/config_check.F: add a check for OLx>sNx/OLy>sNy |
695 |
|
o verification/lab_sea |
696 |
|
* #undef SEAICE_EXCLUDE_FOR_EXACT_AD_TESTING |
697 |
|
* #define ALLOW_SST_CONTROL & ALLOW_SST_CONTROL |
698 |
|
* nTimeSteps 3 -> 4 |
699 |
|
* changed reference output accordingly |
700 |
|
o pkg/ctrl: |
701 |
|
* fix ctrl_get_gen for xx_sst, xx_sss |
702 |
o pkg/fizhi: |
o pkg/fizhi: |
703 |
- fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F |
- fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F |
704 |
update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d) |
update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d) |
705 |
|
- by default, use new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE); |
706 |
|
fix few out-of-bounds indices in referencing vars (initialise igrd to 1); |
707 |
|
clean-up fizhi_turb.F (remove unused & uninitialised qdiaglsm array). |
708 |
o pkg/gmredi: |
o pkg/gmredi: |
709 |
- add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp |
- add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp |
710 |
o pkg/fizhi: |
o pkg/fizhi: |