4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
5 |
============================== |
============================== |
6 |
|
|
7 |
|
o pkg/shelfice |
8 |
|
in mom_fluxform.F, mom_vecinv.F: |
9 |
|
CALL SHELFICE_V_DRAG(bi,bj,k,vFld,KE,KappaRU,vF,myThid) |
10 |
|
Bug fix KappaRU -> KappaRV |
11 |
|
does not change verification/isomip but may change other setups |
12 |
|
(presumably constant KappaRU=KappaRV) |
13 |
|
- fix diagnostics SHIU/Vdrag (thanks to Tom Millgate) |
14 |
|
o pkg/obcs: |
15 |
|
- fixed some indexing bugs in obcs_seaice_sponge.F |
16 |
|
- added obcs relaxation subroutines for HSALT and HSNOW |
17 |
|
- changes verification/seaice_obcs/results/obcs_seaice_sponge.F |
18 |
|
o pkg/seaice: |
19 |
|
- add "multicategory" parameterization for snow in analogy to ice, |
20 |
|
default is off for now. |
21 |
|
o pkg/obcs: |
22 |
|
- added obcs_seaice_sponge.F for obcs relaxation of seaice variables; |
23 |
|
see verification/seaice_obcs/input.seaiceSponge for example application. |
24 |
|
- remove local commom bloc "OBCS_GLOBAL" in obcs_readparms.F and do all the OB |
25 |
|
index setting by master-thread. This fix multi-threads Pb in previous modifs. |
26 |
|
o pkg/layers : |
27 |
|
- add diagnostics to pkg/layers |
28 |
|
- move the meat of pkg/layers from layers_calc.F to layers_fluxcalc.F |
29 |
|
(from R.Tulloch). Layers_calc.F now calls layers_fluxcalc.F accordingly. |
30 |
|
o pkg/generic_advdiff/gad_implicit_r.F : |
31 |
|
- fix ADVr diagnostics in case of both implicit vertical advection and diffusion. |
32 |
|
o pkg/seaice/seaice_growth.F: |
33 |
|
- fix SItflux diagnostics in virtual salt flux + balanceEmpmr case. |
34 |
|
o pkg/obcs: |
35 |
|
- change default setting of OBCS_UVICE_OLD from defined to undef; |
36 |
|
- use new parameter OB_indexNone for null index value (instead of hard-coded 0) |
37 |
|
in all pkg/obcs code and in other pkgs; remove k loop in obcs_check_depths.F; |
38 |
|
- pass OB_indexNone as (new) argument to S/R CTRL_MASK_SET_[X,Y]Z; |
39 |
|
- change OB null index value (OB_indexNone) to -99 ; this fix the problem |
40 |
|
with Southern & Western OB at a tile edge (at least in a simple set-up). |
41 |
|
o pkg/obcs: |
42 |
|
- change settings of OB index in case OB coincides with tile edge (shared by |
43 |
|
2 tiles), so that common OB location is registered by both tiles (instead of |
44 |
|
only 1). However, for Southern and Western OB, index value = 0 is not |
45 |
|
recognized as valid OB index (=default null value) and needs to be fixed. |
46 |
|
- modify accordingly OBCS_BALANCE_FLOW and OBCS_MONITOR (avoid double counting) |
47 |
|
- new parameter "OB_indexNone" for null index value (for now, still zero) |
48 |
|
to replace hard-coded null index value of zero. |
49 |
|
o pkg/exch2: |
50 |
|
- improve W2_USE_E2_SAFEMODE (faster) and W2_E2_DEBUG_ON: |
51 |
|
always check buffer-size (but outside the loop); move checking for valid |
52 |
|
index from W2_USE_E2_SAFEMODE to W2_E2_DEBUG_ON; in W2_E2_DEBUG_ON, |
53 |
|
print each tile and point connection only if |W2_printMsg|>= 2 and 3. |
54 |
|
o pkg/ctrl (pack & unpack): |
55 |
|
- in ctrl_pack.F & ctrl_unpack.F, use the same local file-name variable |
56 |
|
(locally defined) for different variables (+ remove the variable-specific |
57 |
|
file name in CTRL_GENARR.h). For now, only implemented for GENARR2/3D_CONTROL |
58 |
|
(to be extended to other local file names in ctrl.h). |
59 |
|
o pkg/flt: |
60 |
|
- add a FLT_Iter0 option (similar to PTRACERS_Iter0). |
61 |
|
o pkg/mdsio: |
62 |
|
- fix missing STOP in mdsio_readvec_loc.F (case ioUnit=0) when file is missing |
63 |
|
o tools/genmake2: |
64 |
|
- add similar dependences for target EXE_AD & EXE_FTL as we have for EXECUTABLE |
65 |
|
(added by Alistair in version 1.51 for building without make depend); |
66 |
|
- remove Header files list (H_SRC_FILES) from the dependence of targets |
67 |
|
ad_input_code.f & ftl_input_code.f (not clear why it was added in the first |
68 |
|
place in version 1.23): this save going through staf when unrelated header |
69 |
|
file has been modified. |
70 |
|
Note: for an intermediate target (e.g., ad_input_code.f or adtaf) without |
71 |
|
"make depend" step, still need to do "make links" before "make adtaf". |
72 |
|
o eesupp/src (+ few pkg src files) & genmake2: |
73 |
|
- finish to remove ALWAYS_USE_MPI in source code that TAF does not see; |
74 |
|
- no longer set ALWAYS_USE_MPI in Makefile (was done by genmake2). |
75 |
|
- improve genmake2 checking for ALLOW_${PKG} in CPP_OPTIONS.h files (distinguish |
76 |
|
upper/lower case ; account for space between "#" and undef/define) |
77 |
|
o pkg/flt (with exch2): |
78 |
|
- cleaning: fix so that it compiles; move remaining MPI calls out of flt_exch2.F; |
79 |
|
- simplify threads synchronisation; fix (many issues) multi-threaded with MPI. |
80 |
|
|
81 |
|
checkpoint63s (2012/09/05) |
82 |
|
o pkg/ecco: |
83 |
|
- remove #ifdef ALLOW_SMOOTH_CORREL3D brackets. |
84 |
|
- add more relevant #ifdef ALLOW_SMOOTH ones. |
85 |
|
- sort out useAtmWind, useSMOOTH, ctrlSmoothCorrel2D. |
86 |
|
o pkg/ctrl: |
87 |
|
- CTRL_OPTIONS.h : document CPPs related to smoothing; ALLOW_SMOOTH_CORREL2D/3D, |
88 |
|
ALLOW_CTRL_SMOOTH, ALLOW_SMOOTH_CTRL2D, ALLOW_SMOOTH_CTRL3D. |
89 |
|
- ctrl.h : document run time params doInitXX, doMainPack, doMainUnpack, doPackDiag, |
90 |
|
doSinglePrecTapelev (audodiff param!), ctrlSmoothCorrel2D (new) and |
91 |
|
ctrlSmoothCorrel3D (new). |
92 |
|
The added ctrlSmoothCorrel2D/3D replace the old ALLOW_SMOOTH_CORREL2D/3D CPP. |
93 |
|
- ctrl_readparms.F : initialise ctrlSmoothCorrel2D/3D and read from namelist. |
94 |
|
- ctrl_init.F ctrl_pack.F ctrl_unpack.F : switch off ustress/vstress |
95 |
|
controls when useAtmWind, and vice versa. |
96 |
|
- ctrl_map_ini_ecco.F : UVEL0, VVEL0, edtaux, edtauy cannot be smoothed as tracers. |
97 |
|
- ctrl_get_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL2D with |
98 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel2D, IF useSMOOTH. |
99 |
|
- ctrl_map_ini_gen.F : replace #ifdef ALLOW_SMOOTH_CORREL3D with |
100 |
|
#ifdef ALLOW_SMOOTH, IF ctrlSmoothCorrel3D, IF useSMOOTH. |
101 |
|
- ctrl_set_pack_xy[z].F, ctrl_set_unpack_xy[z].F: |
102 |
|
replace ALLOW_SMOOTH_CORREL2D/3D brackets with ctrlSmoothCorrel2D/3D. |
103 |
|
o pkg/smooth: |
104 |
|
- remove un-necessary includes. |
105 |
|
- remove ALLOW_SMOOTH*D and ALLOW_SMOOTH_CORREL*D brakets. |
106 |
|
Those CPP options were never defined, and not necessary. |
107 |
|
o model/src: |
108 |
|
- fix CPP brackets in ini_mixing.F (GM_background_K belongs to gmredi). |
109 |
|
- standard treatment of useSMOOTH. |
110 |
|
o pkg/autodiff: |
111 |
|
- add LOGICAL useGGL90inAdMode, useGGL90inFwdMode, useSALT_PLUMEinAdMode, |
112 |
|
useSALT_PLUMEInFwdMode allowing to switch off ggl90 and salt_plume adjoint. |
113 |
|
o pkg/exch2: |
114 |
|
- add "if usingMPI" where it was missing (in exch2_rx?_cube*.template) |
115 |
|
+ start to remove ALWAYS_USE_MPI in source code that TAF does not see. |
116 |
|
- make new S/R W2_MAP_PROCS out of w2_eeboot.F to setup exch2 CommonFlag |
117 |
|
and tiles to process mapping. |
118 |
|
- re-arrange 3 header files (W2_EXCH2_PARAMS.h, _BUFFER.h & _TOPOLOGY.h) |
119 |
|
moving /EXCH2_FILLVAL_RX/ & /W2_EXCH2_COMMFLAG/ to W2_EXCH2_TOPOLOGY.h; |
120 |
|
rename "exch2_tProc" to "W2_tileProc" and move seting of e2FillValue_RX |
121 |
|
from w2_eeboot.F to w2_readparms.F. |
122 |
|
o eesupp/src: |
123 |
|
- set exchNeedsMemsync & exchUsesBarrier according to "usingMPI" (instead of |
124 |
|
ALWAYS_USE_MPI) + moved from ini_communication_patterns.F to eeset_parms.F; |
125 |
|
also move setting of exchCollectStatistics from exch_init.F to eeset_parms.F |
126 |
|
- in eedie.F and all_proc_die.F, always call MPI_FINALIZE when ALLOW_USE_MPI |
127 |
|
is defined (remove condition on usingMPI) to match cases where MPI_INIT |
128 |
|
has been called. |
129 |
|
- fix bug I put in previous modif of exch_sm_3d_rx.template (not much used); |
130 |
|
- change default (non-MPI) value of myPid (from 1 to 0) to match MPI settings |
131 |
|
(so that on 1 proc, get same myPid independently of usingMPI) |
132 |
|
- add a stop if multi-procs but usingMPI=F ; stop also if usingMPI=T and |
133 |
|
useCubedSphereExchange with EXCH-1 (safer). |
134 |
|
- add "if usingMPI" where it was missing (+ start to remove ALWAYS_USE_MPI). |
135 |
|
o pkg/ggl90: |
136 |
|
- fix bug in filling corner mask array "mskCor" (FILL_CS_CORNER_TR_RL call) |
137 |
|
used in ALLOW_GGL90_SMOOTH code. |
138 |
|
o pkg/flt: |
139 |
|
- fix typo in FLT_WITHOUT_Y_PERIODICITY (the effect was to ignore stopping |
140 |
|
floats at the Southern end of the domain). |
141 |
|
o eesupp/inc: |
142 |
|
- add a list of CPP-options which can be set by Makefile (DEF_IN_MAKEFILE.h); |
143 |
|
but not used (and not to be used) anywhere, just for documentation. |
144 |
|
o pkg/autodiff, exf, ptracers & seaice (AD & TL output): |
145 |
|
- comment out the very nasty "writeBinaryPrec = writeStatePrec" line, since: |
146 |
|
a) can damage previously written records in any other multi-record files. |
147 |
|
b) if needed, can easily do it cleanly, by calling S/R WRITE_REC_3D_RL/S. |
148 |
|
o tools/genmake2: |
149 |
|
- define variable MAKE within Makefile and use it in place of 'make'; |
150 |
|
- update AD_CONFIG.h (if needed) before building any of the executable |
151 |
|
(forward, adjoint or tangent-lin); this involves a 2nd invocation of make; |
152 |
|
and add the usual #ifndef/#define AD_CONFIG_H in AD_CONFIG.h; |
153 |
|
- always print usual warning comment 'this file is automatically generated' |
154 |
|
from script convert_cpp_cmd2defines (+ remove this warning from genmake2). |
155 |
|
o pkg/cheapaml: |
156 |
|
- updated to correspond to the code used in accepted paper (Nico Wienders). |
157 |
|
o pkg/exf: |
158 |
|
added run time switch useAtmWind to replace ALLOW_ATM_WIND cpp switch. |
159 |
|
ALLOW_ATM_WIND now just sets the useAtmWind default (see exf_readparms.F) |
160 |
|
and force defines ALLOW_BULKFORMULAE (EXF_OPTIONS.h). |
161 |
|
o pkg/exf, autodiff, ctrl, ecco and seaice: |
162 |
|
remove ALLOW_ATM_WIND brackets, or replace them with useAtmWind ones. |
163 |
|
o pkg/ctrl, ecco: |
164 |
|
allow to compile both ALLOW_U/VSTRESS_CONTROL and ALLOW_U/VWIND_CONTROL. |
165 |
|
Depending on useAtmWind, one is inactive, and the other is active (see |
166 |
|
exf_getffields.F/exf_getsurfacefluxes.F). |
167 |
o tools/genmake2: |
o tools/genmake2: |
168 |
- improve error msg when failing in 2nd test of check_for_broken_Ff |
- improve error msg when failing in 2nd test of check_for_broken_Ff |
169 |
- fix option '-makefile' short-name (-mf according to genmake2 -help) |
- fix option '-makefile' short-name (-mf according to genmake2 -help) |