| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/diagnostics/diagstats_calc.F |
| 8 |
|
- for TARGET_NEC_SX fix the treatment of the scaling factor tmpFac=scaleFact |
| 9 |
|
o pkg/obcs (with exch2): |
| 10 |
|
- derive OB indices in overlap region from OB-InsideMask (in obcs_init_fixed.F) |
| 11 |
|
and remove code (in obcs_readparms.F) which was based on EXCH of indices |
| 12 |
|
(through buffer) and did not account for exch2 (e.g., CS-grid) topology. |
| 13 |
|
o pkg/exf and seaice exp: |
| 14 |
|
- change offline_exf_seaice.seaicetd test exp. to use default DIFF1 value (=0) |
| 15 |
|
so that switching off area & heff advection flags does not affect results. |
| 16 |
|
- change default EXF_LWDOWN_WITH_EMISSIVITY to #define in EXF_OPTIONS.h |
| 17 |
|
- keep exp. seaice_obcs & 1D_ocean_ice_column(ad) unchanged (using #undef |
| 18 |
|
EXF_LWDOWN_WITH_EMISSIVITY) and, using pkg/exf default emissivities, update |
| 19 |
|
results of verification experiments: 1D_ocean_ice_column(fwd), |
| 20 |
|
global_ocean.cs32x15.seaice(fwd+ad) & seaice_dynmix(ad), lab_sea (all 8) |
| 21 |
|
and offline_exf_seaice (all 4). |
| 22 |
|
o pkg/seaice: |
| 23 |
|
- remove array YNEG, RIVER, TMIX (replaced by local var) from common block; |
| 24 |
|
remove also areaNm1 & hEffNm1 when SEAICE_GROWTH_LEGACY is undef. |
| 25 |
|
- fix bug: areaNm1 & hEffNm1 are needed in seaice_growth (SEAICE_GROWTH_LEGACY) |
| 26 |
|
but were not filled when resp. SEAICEadvArea=F & SEAICEadvHeff=F and |
| 27 |
|
not multi-dim advection; |
| 28 |
|
- fix seaice_growth.F to compile with both SEAICE_GROWTH_LEGACY and |
| 29 |
|
SHORTWAVE_HEATING #undef. |
| 30 |
|
o optim: make Makefile more robust (?) |
| 31 |
|
o pkg/obcs: |
| 32 |
|
* fix treatment of obcs_read_pickup for TAF |
| 33 |
|
o pkg/shelfice: |
| 34 |
|
* add missing initialisation of num_shifwflx |
| 35 |
|
* new adjoint verification exp. for isomip |
| 36 |
|
* change Prandtl and Schmidt numbers from generic formulations |
| 37 |
|
(in terms of model diffus. and visc.) to separate runtime |
| 38 |
|
parameters, with Holland and Jenkins (1999) default values. |
| 39 |
|
o pkg/exf (interpolation): |
| 40 |
|
- extended input field (2 rows) near the N & S poles: |
| 41 |
|
* fill in with the symetric value (when even Nb of data in longitude) |
| 42 |
|
* add average value at the poles only for scalar quantities ; for vector |
| 43 |
|
component interpolation, skip the averaging and keep duplicated values, |
| 44 |
|
unless the 2 components have same location (uvInterp=T) in which case |
| 45 |
|
interpolate the 2 components together using S/R EXF_INTERP_UV. |
| 46 |
|
- new S/R EXF_INTERP_UV to interpolate the 2 components of a vector field |
| 47 |
|
together: this allows to account properly for local orientation when |
| 48 |
|
averaging at N & S pole. |
| 49 |
|
- add CPP option EXF_USE_OLD_INTERP_POLE to recover old results regarding |
| 50 |
|
exf-interpolation near N & S poles. Undef by default. |
| 51 |
|
- add debug check/print on 1rst iter if debugLevel >=2. |
| 52 |
|
o pkg/exf: |
| 53 |
|
- change masking flags definition (no longer "parameter"), put them in |
| 54 |
|
common block and set them in S/R EXF_INIT_FIXED. |
| 55 |
|
- change recognized masking flag from s,u,v to c,w,s since the mask |
| 56 |
|
to use (maskC,W,S) depends on position on model grid and has little to |
| 57 |
|
do with scalar/vector difference; fix masking if using P-coordinates. |
| 58 |
|
- fix masking of wind-stress (was wrong if interpolated or read on A-grid) |
| 59 |
|
and update results of exp. global_with_exf (x2). |
| 60 |
|
- fix setting of zenith-angle table when SHORTWAVE_HEATING is undef. |
| 61 |
|
o pkg/obcs |
| 62 |
|
- S/R obcs_calc_stevens: fix a small bug (gammat -> gammas where appropriate) |
| 63 |
|
o pkg/exf (interpolation): |
| 64 |
|
- assume periodicity in X only if input field cover full longitude range. |
| 65 |
|
- improve search for lat. index (supposed to be faster, in ~log2(ny) steps, |
| 66 |
|
and should vectorise). |
| 67 |
|
- fix input lat of the 2 added row (in case we provide N.pole data). |
| 68 |
|
|
| 69 |
|
checkpoint63h (2011/12/30) |
| 70 |
|
o pkg/seaice: |
| 71 |
|
- change declaration of UVM from _RL to _RS in order to get B-grid |
| 72 |
|
uIce,vIce monitor when _RS = real*4 |
| 73 |
|
o pkg/offline: |
| 74 |
|
- new S/R OFFLINE_RESET_PARMS for resetting main-model params (switch off flags); |
| 75 |
|
- compute vertical velocity if not read from file (switch on exactConserv |
| 76 |
|
& staggerTimeStep); |
| 77 |
|
- fix output of ptracer monitor iter & time for default PTRACERS_monitorFreq. |
| 78 |
|
o verification: |
| 79 |
|
- update grid-files (in tutorial_held_suarez_cs/input and fizhi-cs-32x32x40/input) |
| 80 |
|
with grid-angle generated using "utils/matlab/cs_grid/cubeCalcAngle.m": |
| 81 |
|
fix Pb in yG definition @ 2 missing corners (previously yG was averaged); |
| 82 |
|
- update output of exp. global_ocean.cs32x15.viscA4 after changing |
| 83 |
|
grid-file angles (used here for coriolis-3d); |
| 84 |
|
- remove (or gzip) few files not needed to run fizhi-cs experiments. |
| 85 |
|
o pkg/exf (vector interpolation): |
| 86 |
|
- rotate vector component toward local grid-axis orientation using grid-angles |
| 87 |
|
(stored in GRID.h) instead of locally computed rotation angle; keep old code |
| 88 |
|
available with exf option EXF_USE_OLD_VEC_ROTATION (undef by default). |
| 89 |
|
o pkg/seaice: |
| 90 |
|
- allow to compile with exf options ALLOW_ATM_TEMP or ALLOW_DOWNWARD_RADIATION |
| 91 |
|
undefined. Fix and remove the stop when ALLOW_RUNOFF is undefined. |
| 92 |
|
o pkg/PKG_OPTIONS.h files: |
| 93 |
|
- move #include "CPP_OPTIONS.h" just after #include "PACKAGES_CONFIG.h", |
| 94 |
|
outside of the #ifdef ALLOW_THISPKG / #endif block. |
| 95 |
|
- update verification/*/code/PKG_OPTIONS.h files. |
| 96 |
|
o add a verification experiment (offline_exf_seaice/input.seaice) that test |
| 97 |
|
the B-grid LSOR solver |
| 98 |
|
o pkg/seaice: sort out emissivity and long wave radiation step 2: |
| 99 |
|
- add emissivity for snow and ice as new run-time parameters |
| 100 |
|
(unfortunately) that default to the corresponding exf values; this |
| 101 |
|
changes results in most verification experiments so that for backward |
| 102 |
|
compatibility these parameter have to be set explicitly to inconsistent |
| 103 |
|
values (ugly); |
| 104 |
|
- the exf-flag EXF_LWDOWN_WITH_EMISSIVITY then gets rid off the hard-wired |
| 105 |
|
emissivities of 0.97 associated with lwdownloc in S/R seaice_solve4temp |
| 106 |
|
until we agree how to handle this bug properly |
| 107 |
|
o pkg/exf (interpolation): |
| 108 |
|
- add a set of run-time param ({inputfield}_interpMethod), one for |
| 109 |
|
each interpolated input field, to select the interpolation method |
| 110 |
|
with a value of zero switching off the interpolation; |
| 111 |
|
- print interpolation parameters to standard output; |
| 112 |
|
- refine exf_check.F accordingly ; stop if USE_NO_INTERP_RUNOFF is defined |
| 113 |
|
(to use instead runoff_interpMethod=0 in data.exf). |
| 114 |
|
- simplify default setting of interpolation parameters (for all fields, |
| 115 |
|
set position to match model grid cell-center position, leading to trivial |
| 116 |
|
interpolation in case of regular Lat-Lon grid) and fix for the case of |
| 117 |
|
non-uniform delY. |
| 118 |
|
o pkg/exf/exf_radiation.F: add the factor ocean_emissivity to lwdown, for |
| 119 |
|
within #ifdef EXF_LWDOWN_WITH_EMISSIVITY/#endif. Unless ocean_emissivity=1. |
| 120 |
|
this factor is absolutely required, because the lw exitance (= out-going |
| 121 |
|
long wave radiation) is emissivity*stefanBoltzmann*T^4 + rho*lwdown, |
| 122 |
|
where the reflectivity rho = 1-emissivity for conservation reasons. Once |
| 123 |
|
this is established, we can remove the CPP-Flag (if we want to). |
| 124 |
|
o pkg/seaice: |
| 125 |
|
- qualify a stop statement in S/R seaice_check: EXF_READ_EVAP and |
| 126 |
|
ALLOW_BULKFORMULAE are only required if SEAICE_EXTERNAL_FLUXES is defined |
| 127 |
|
- sort out emissivity and long wave radiation, step 1: make SEAICE_emissivity |
| 128 |
|
what the name implies (and not emissivity*BoltzmannConstant), this means |
| 129 |
|
the old default value of 5.5e-8 now means |
| 130 |
|
5.5e-8/5.670e-8 = 0.97001763668430343479 as ocean_emissivity in |
| 131 |
|
S/R exf_readparms |
| 132 |
|
- FV-discretization of the B-grid LSOR solver, turn on with |
| 133 |
|
SEAICE_LSRBNEW. This new solver also involves a slight re-organization |
| 134 |
|
of the calling routine dynsolver, so that B and C-grid code look a |
| 135 |
|
little more alike. |
| 136 |
|
- fix index bugs in ostres.F (B-grid code) |
| 137 |
|
o pkg/seaice/seaice_ocean_budget.F: change (unused) code to make it look better |
| 138 |
|
o pkg/seaice/seaice_readparms.F: make ocean_emissivity*stefanBoltzmann the |
| 139 |
|
default for SEAICE_emissivity, if useEXF; requires setting a wrong |
| 140 |
|
parameter value in global_ocean.cs32x15/input.seaice/data.seaice for |
| 141 |
|
backward compatiblity |
| 142 |
|
o model/src: use sigmaR in calc_ivdc |
| 143 |
|
|
| 144 |
|
checkpoint63g (2011/12/16) |
| 145 |
|
o pkg/seaice/seaice_growth.F: |
| 146 |
|
fix heat conservation of the coupled ocean-seaice system. |
| 147 |
|
when SEAICE_HEAT_CONSERV_FIX is defined, the mismatch of |
| 148 |
|
solid vs liquid water treatment is resolved via QNET. |
| 149 |
|
o pkg/seaice/seaice_growth.F: |
| 150 |
|
add missing term for sublimation in saltFlux, which was breaking conservation. |
| 151 |
|
o pkg/seaice/seaice_model.F: |
| 152 |
|
Remove this patholigical case treatment in evolution branch, |
| 153 |
|
where it is un-necessary and breaks conservation. |
| 154 |
|
Update global_ocean.cs32x15/results accordingly for |
| 155 |
|
output.seaice.txt output_adm.seaice.txt and output_adm.seaice_dynmix.txt |
| 156 |
|
o model/src: |
| 157 |
|
useRealFreshWaterFlux: remove masking of EmPmP (using maskInC) in |
| 158 |
|
external_forcing_surf.F and apply mask directly in S/R SOLVE_FOR_PRESSURE. |
| 159 |
|
o pkg/obcs: |
| 160 |
|
modify Stevens boundary conditions so that S/R obcs_calc_stevens computes |
| 161 |
|
tendency for temperature and salinity that is then applied to update |
| 162 |
|
theta and salt in S/R obcs_apply_ts; this requires proper masking of all |
| 163 |
|
horizontal advection and diffusion contributions on the boundary (in |
| 164 |
|
S/Rs gad_advection, gad_calc_rhs, gmredi_rtransport, gmredi_calc_diff), and |
| 165 |
|
removing the mask in S/R timestep_tracer. The advantage of this approach is |
| 166 |
|
that the updated tracer values include contributions from the surface |
| 167 |
|
forcing and vertical diffusion. |
| 168 |
|
This modification changes exp4.stevens because of vertical diffusion. |
| 169 |
|
o model/src: |
| 170 |
|
change non-curvilinear grid setting to also work with exch2 + blank tiles: |
| 171 |
|
- move delX,delY to new header file (SET_GRID.h) and adjust length to 1rst |
| 172 |
|
face dimensions. |
| 173 |
|
- new S/R INI_LOCAL_GRID to define model tile-local grid (using same units |
| 174 |
|
as delX,delY) and called from S/R INI_CARTESIAN_GRID, INI_CYLINDER_GRID |
| 175 |
|
and INI_SPHERICAL_POLAR_GRID. |
| 176 |
|
change test-experiment global_ocean.90x40x15: |
| 177 |
|
- split the domain in many more tiles (9x4 tiles of 10x10 each); |
| 178 |
|
- switch to exch2 and remove 1 blank-tile (but only for MPI test). |
| 179 |
|
- update results of both test (std & dwnslp). |
| 180 |
|
o pkg/diagnostics/diagstat_calc.F: fix problem with non-initialised halos in |
| 181 |
|
tmp-fields for TARGET_NEC_SX at the cost of extra loops and less vectorisation |
| 182 |
|
o model/src: |
| 183 |
|
- take sigma-coords related code out of update_etah.F into new S/R UPDATE_ETAWS |
| 184 |
|
and fix initialisation when using sigma-coords. |
| 185 |
|
o model/src: |
| 186 |
|
- improve Gael's changes from Jan 14, 2011 "addition of an 'update' of hfacc etc. |
| 187 |
|
to their current value at the beginning of forward_step.F": add a new run-time |
| 188 |
|
switch "doResetHFactors" (default=false) and use it to do (or not) the resetting. |
| 189 |
|
- set doResetHFactors=T in the following test exp: |
| 190 |
|
global_ocean.90x40x15/input (rStar) & input.dwnslp (linFS), |
| 191 |
|
global_ocean.cs32x15/input.seaice (rStar), hs94.cs-32x32x5/input.impIGW (linFS) |
| 192 |
|
and tutorial_global_oce_in_p (nonLinFS in p) |
| 193 |
|
o pkg/ecco |
| 194 |
|
- added IES cost term |
| 195 |
|
o verification/advect_xz |
| 196 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 197 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 198 |
|
- add note (check_conserve_TS.txt) and matlab script to check global |
| 199 |
|
conservation of T & S with NonLin-FreeSurf and Adams-Bashforth. |
| 200 |
|
o pkg/rbcs: |
| 201 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 202 |
|
o pkg/obcs (Stevens BCs): |
| 203 |
|
- fix various problems in the phase speed computations of the Stevens |
| 204 |
|
boundary conditions: |
| 205 |
|
- sign error for western and southern boundaries, |
| 206 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 207 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 208 |
|
from difference between previous (n) time level and the one before (n-1); |
| 209 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 210 |
|
files. |
| 211 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 212 |
|
- set default phase velocity to cflMer/Zon |
| 213 |
|
- update verification experiment exp4.stevens |
| 214 |
|
o pkg/generic_advdiff (implicit_r): |
| 215 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 216 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 217 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 218 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 219 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 220 |
|
solver S/R ; |
| 221 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 222 |
|
when using implicit vert. advection; |
| 223 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 224 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 225 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 226 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 227 |
|
o pkg/diagnostics: |
| 228 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 229 |
|
|
| 230 |
|
checkpoint63f (2011/11/30) |
| 231 |
o pkg/obcs/obcs_calc_stevens.F: |
o pkg/obcs/obcs_calc_stevens.F: |
| 232 |
|
- join some loops to reduce number of if-statements |
| 233 |
- fix a bug in code for northern and southern boundaries. |
- fix a bug in code for northern and southern boundaries. |
| 234 |
o pkg/seaice/seaice_init_varia.F |
o pkg/seaice/seaice_init_varia.F |
| 235 |
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 236 |
caused zero ice-velocities for the B-grid code |
caused zero ice-velocities for the B-grid code |
| 237 |
o pkg/seaice/seaice_init_fixed.F |
o pkg/seaice/seaice_init_fixed.F |
| 238 |
- fix a bug in the initialisation of the second metric terms |
- fix a bug in the initialisation of the second metric terms |
| 239 |
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 240 |
- this affects all seaice configurations with useCurviLinearGrid = .true. |
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 241 |
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch