| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/seaice/seaice_growth.F: |
| 8 |
|
fix heat conservation of the coupled ocean-seaice system. |
| 9 |
|
when SEAICE_HEAT_CONSERV_FIX is defined, the mismatch of |
| 10 |
|
solid vs liquid water treatment is resolved via QNET. |
| 11 |
|
o pkg/seaice/seaice_growth.F: |
| 12 |
|
add missing term for sublimation in saltFlux, which was breaking conservation. |
| 13 |
|
o pkg/seaice/seaice_model.F: |
| 14 |
|
Remove this patholigical case treatment in evolution branch, |
| 15 |
|
where it is un-necessary and breaks conservation. |
| 16 |
|
Update global_ocean.cs32x15/results accordingly for |
| 17 |
|
output.seaice.txt output_adm.seaice.txt and output_adm.seaice_dynmix.txt |
| 18 |
|
o model/src: |
| 19 |
|
useRealFreshWaterFlux: remove masking of EmPmP (using maskInC) in |
| 20 |
|
external_forcing_surf.F and apply mask directly in S/R SOLVE_FOR_PRESSURE. |
| 21 |
|
o pkg/obcs: |
| 22 |
|
modify Stevens boundary conditions so that S/R obcs_calc_stevens computes |
| 23 |
|
tendency for temperature and salinity that is then applied to update |
| 24 |
|
theta and salt in S/R obcs_apply_ts; this requires proper masking of all |
| 25 |
|
horizontal advection and diffusion contributions on the boundary (in |
| 26 |
|
S/Rs gad_advection, gad_calc_rhs, gmredi_rtransport, gmredi_calc_diff), and |
| 27 |
|
removing the mask in S/R timestep_tracer. The advantage of this approach is |
| 28 |
|
that the updated tracer values include contributions from the surface |
| 29 |
|
forcing and vertical diffusion. |
| 30 |
|
This modification changes exp4.stevens because of vertical diffusion. |
| 31 |
|
o model/src: |
| 32 |
|
change non-curvilinear grid setting to also work with exch2 + blank tiles: |
| 33 |
|
- move delX,delY to new header file (SET_GRID.h) and adjust length to 1rst |
| 34 |
|
face dimensions. |
| 35 |
|
- new S/R INI_LOCAL_GRID to define model tile-local grid (using same units |
| 36 |
|
as delX,delY) and called from S/R INI_CARTESIAN_GRID, INI_CYLINDER_GRID |
| 37 |
|
and INI_SPHERICAL_POLAR_GRID. |
| 38 |
|
change test-experiment global_ocean.90x40x15: |
| 39 |
|
- split the domain in many more tiles (9x4 tiles of 10x10 each); |
| 40 |
|
- switch to exch2 and remove 1 blank-tile (but only for MPI test). |
| 41 |
|
- update results of both test (std & dwnslp). |
| 42 |
|
o pkg/diagnostics/diagstat_calc.F: fix problem with non-initialised halos in |
| 43 |
|
tmp-fields for TARGET_NEC_SX at the cost of extra loops and less vectorisation |
| 44 |
|
o model/src: |
| 45 |
|
- take sigma-coords related code out of update_etah.F into new S/R UPDATE_ETAWS |
| 46 |
|
and fix initialisation when using sigma-coords. |
| 47 |
|
o model/src: |
| 48 |
|
- improve Gael's changes from Jan 14, 2011 "addition of an 'update' of hfacc etc. |
| 49 |
|
to their current value at the beginning of forward_step.F": add a new run-time |
| 50 |
|
switch "doResetHFactors" (default=false) and use it to do (or not) the resetting. |
| 51 |
|
- set doResetHFactors=T in the following test exp: |
| 52 |
|
global_ocean.90x40x15/input (rStar) & input.dwnslp (linFS), |
| 53 |
|
global_ocean.cs32x15/input.seaice (rStar), hs94.cs-32x32x5/input.impIGW (linFS) |
| 54 |
|
and tutorial_global_oce_in_p (nonLinFS in p) |
| 55 |
|
o pkg/ecco |
| 56 |
|
- added IES cost term |
| 57 |
|
o verification/advect_xz |
| 58 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 59 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 60 |
|
- add note (check_conserve_TS.txt) and matlab script to check global |
| 61 |
|
conservation of T & S with NonLin-FreeSurf and Adams-Bashforth. |
| 62 |
|
o pkg/rbcs: |
| 63 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 64 |
|
o pkg/obcs (Stevens BCs): |
| 65 |
|
- fix various problems in the phase speed computations of the Stevens |
| 66 |
|
boundary conditions: |
| 67 |
|
- sign error for western and southern boundaries, |
| 68 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 69 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 70 |
|
from difference between previous (n) time level and the one before (n-1); |
| 71 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 72 |
|
files. |
| 73 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 74 |
|
- set default phase velocity to cflMer/Zon |
| 75 |
|
- update verification experiment exp4.stevens |
| 76 |
|
o pkg/generic_advdiff (implicit_r): |
| 77 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 78 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 79 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 80 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 81 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 82 |
|
solver S/R ; |
| 83 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 84 |
|
when using implicit vert. advection; |
| 85 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 86 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 87 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 88 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 89 |
|
o pkg/diagnostics: |
| 90 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 91 |
|
|
| 92 |
|
checkpoint63f (2011/11/30) |
| 93 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 94 |
|
- join some loops to reduce number of if-statements |
| 95 |
|
- fix a bug in code for northern and southern boundaries. |
| 96 |
|
o pkg/seaice/seaice_init_varia.F |
| 97 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 98 |
|
caused zero ice-velocities for the B-grid code |
| 99 |
|
o pkg/seaice/seaice_init_fixed.F |
| 100 |
|
- fix a bug in the initialisation of the second metric terms |
| 101 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 102 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 103 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 104 |
|
= .true. (default) |
| 105 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 106 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 107 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 108 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 109 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 110 |
|
o model/src: |
| 111 |
|
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 112 |
|
- call INTEGR_CONTINUITY directly from forward_step.F |
| 113 |
|
(previously called from momentum_correction_step.F) |
| 114 |
|
- call UPDATE_ETAH from integr_continuity.F and update initialise_varia.F, |
| 115 |
|
forward_step.F and pkg/ecco/the_main_loop.F |
| 116 |
|
o model/src/do_oceanic_phys.F: |
| 117 |
|
- reset addMass to zero only if useICEFRONT ; |
| 118 |
|
- separated k-loop for rhoInSitu calculation ; |
| 119 |
|
- add 2 diagnostics for wVel*delta^k(Rho) at constant pressure (= WdRHO_P) |
| 120 |
|
and at constant T,S (= WdRHOdP); |
| 121 |
|
NOTE: change diagnostics WRHOMASS : this is now simply the Vertical transport |
| 122 |
|
of In-Situ Density (Anomaly) (=wVel*rho^bar-k) (previously was Vertical |
| 123 |
|
transport of locally-referenced potential density); |
| 124 |
|
to recover old diag: (WRHOMASS)_old = (WRHOMASS)_new -1/2 * (WdRHOdP) |
| 125 |
|
o gluemnc: |
| 126 |
|
- replace ncrcat with ncks when adding variables to *.glob.nc |
| 127 |
|
- change the way variables without record dimensions are handled so that |
| 128 |
|
files that have variables with and without record variables can be glued: |
| 129 |
|
add a record dimension with a new unique name to be able to differentiate |
| 130 |
|
between variable with and without a-prior record dimensions. Remove |
| 131 |
|
this record dimension before adding the variable to the *.glob.nc file. |
| 132 |
|
This procedure automatically works also for grid.*.nc files that do not |
| 133 |
|
have any record dimension. |
| 134 |
|
o verification/cpl_aim+ocn: |
| 135 |
|
- generate new reference output on baudelaire (gfortran, mpich2) (previously |
| 136 |
|
from old aces-grid cluster, ao + ifort) and update 'run_cpl_test' script. |
| 137 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 138 |
|
- add code for northern and southern boundaries. |
| 139 |
|
- reorder some loops to save some operations and so that drFBar can be scalar |
| 140 |
|
o model/src: |
| 141 |
|
- re-arrange extrapolation calculation in Adams-Bashforth S/R (affects machine |
| 142 |
|
truncation) and add diagnostics for Adams-Bashforth tendency increment. |
| 143 |
|
- update test-exp. AD output: |
| 144 |
|
1D_ocean_ice_column, bottom_ctrl_5x5, lab_sea.noseaicedyn, obcs_ctrl; |
| 145 |
|
and FWD output: exp4 (x3), fizhi-cs-32x32x40, fizhi-cs-aqualev20, |
| 146 |
|
front_relax (x3), global_ocean.90x40x15 (x2), global_ocean.cs32x15 (x5), |
| 147 |
|
global_ocean_ebm, ideal_2D_oce, internal_wave, isomip (x3), lab_sea (x4), |
| 148 |
|
matrix_example, MLAdjust (x5), natl_box (x2), tutorial_advection_in_gyre, |
| 149 |
|
tutorial_global_oce_in_p, tutorial_global_oce_latlon and |
| 150 |
|
tutorial_plume_on_slope. |
| 151 |
|
o pkg/diagnostics/diagstats_calc.F: add special code for TARGET_NEC_SX |
| 152 |
|
that vectorises. This code uses 3 extra 2D fields, F90 array assignments |
| 153 |
|
and F90 intrinsic routines SUM, MINVAL, MAXVAL, but since TARGET_NEC_SX |
| 154 |
|
does not even come with an F77 compiler anymore, this should not be |
| 155 |
|
a limitation |
| 156 |
|
|
| 157 |
|
checkpoint63e (2011/11/06) |
| 158 |
|
o pkg/seaice adjoint of LSR: |
| 159 |
|
- substantially rework STORE dirs. |
| 160 |
|
- add new flag SEAICE_LSR_ADJOINT_ITER and parameter SOLV_MAX_FIXED |
| 161 |
|
this flag will do SOLV_MAX_ITERS but only store SOLV_MAX_FIXED fields |
| 162 |
|
and only perform SOLV_MAX_FIXED adjoint iters. |
| 163 |
|
If flag SEAICE_LSR_ADJOINT_ITER is undef-ined, the store in the iteration |
| 164 |
|
always goes to same record, meaning that the last forward field will be |
| 165 |
|
the one used in the adjoint - an approximation. |
| 166 |
|
- now produces non-zero LSR-related gradients, and acceptable gradients for |
| 167 |
|
An's zonal (x-z) test case (to be checked in) |
| 168 |
|
- lab_sea: produces acceptable gradients for lab_sea with forward/backward LSR |
| 169 |
|
(but these are screwed up by the thermodynamics in the first place); |
| 170 |
|
reduce from 4 to 3 timesteps to avoid t.d. issue as temporary solution; |
| 171 |
|
output_adm.txt also reflects changes to seaice_lsr |
| 172 |
|
- global_ocean.cs32x15: |
| 173 |
|
* the "default" input_ad.seaice has been re-defined to always exclude dynamics |
| 174 |
|
(output_adm.seaice.txt was updated) |
| 175 |
|
* new input_ad.seaice_dynmix tests a forward LSR / backward free-drift |
| 176 |
|
(output_adm.seaice_dynmix.txt) |
| 177 |
|
o test-exp. exp4+stevens: |
| 178 |
|
- switch off pTracers and nonHydrostatic (restart problems with NH); update output |
| 179 |
|
o pkg/seaice (lsr solver): |
| 180 |
|
- put coriolis term into FORCEX,Y (as in seaice_evp.F; previously in rhsU,V only); |
| 181 |
|
update output (change truncation) of FWD test exp lab_sea & global_ocean.cs32x15 |
| 182 |
|
- fix SEAICEuseFREEDRIFT for new OBCS version (ndef OBCS_UVICE_OLD) |
| 183 |
|
- new parameter "LSR_mixIniGuess" allows (if=2,4) to mix free-drift solution |
| 184 |
|
into initial guess for linearised solver; use weight ~ (1/err)^2,4. |
| 185 |
|
- compute (with new S/R) and print initial (+ free-driff sol. if available) |
| 186 |
|
and final residual of linearised system. |
| 187 |
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
| 188 |
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
| 189 |
o pkg/obcs: Stevens BCs (still only for east and west) |
o pkg/obcs: Stevens BCs (still only for east and west) |
| 190 |
- fix Stevens BCs by using intermediate velocities of previous |
- fix Stevens BCs by using intermediate velocities of previous |
| 191 |
time step as "baroclinic" contribution rather velocity of one grid cell |
time step as "baroclinic" contribution rather velocity of one grid cell |
| 192 |
inside the boundaries; more consistent but makes the entire treatment |
inside the boundaries; more consistent but makes the entire treatment |
| 193 |
more complicated, requires new pickup files and two new S/Rs: |
more complicated, requires new pickup files and two new S/Rs: |
| 194 |
obcs_copy_uv_n and obcs_save_uv_n |
obcs_copy_uv_n and obcs_save_uv_n |
| 195 |
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
| 196 |
(undefined by default) |
(undefined by default) |
| 197 |
- silently move computation of some grid factors into separate loops to |
- silently move computation of some grid factors into separate loops to |
| 198 |
save some recomputations |
save some recomputations |
| 199 |
- add a hack for non-linear free surface |
- add a hack for non-linear free surface |
| 200 |
- add a verification experiment to exp4 that tests this code |
- add a verification experiment to exp4 that tests this code |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch