| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/seaice: remove (almost) all divisions by constants within loops |
| 8 |
|
in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d |
| 9 |
|
results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only |
| 10 |
|
those, caused by 1/QI -> recip_QI) -> update output.seaice.txt, |
| 11 |
|
output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt |
| 12 |
|
o pkg/seaice : |
| 13 |
|
- simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula.EQ. |
| 14 |
|
1 or 2, using newly added run time parameter SEAICE_availHeatTaper. |
| 15 |
|
- fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148. |
| 16 |
|
- add permanent SItflux diag that corresponds to TFLUX but includes |
| 17 |
|
ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget. |
| 18 |
|
- allow activation/testing of a fix for suspected missing term in |
| 19 |
|
ocn-ice heat budget (to be confirmed). To test this, you want to |
| 20 |
|
undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param |
| 21 |
|
SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic. |
| 22 |
|
- no change in results, fwd or ad. |
| 23 |
|
o global_ocean.cs32x15/results: three changes following from the pkg/seaice commit below. |
| 24 |
|
- switch to variable freezing point. |
| 25 |
|
Results change : cg2d -> 1 digits; ad -> 3-6-6 digits. |
| 26 |
|
- bug fix : the sublimation term that was missing is now activated. |
| 27 |
|
Results change : cg2d -> 2 digits; ad -> 8-6-6 digits. |
| 28 |
|
- bug fix : flooding sign term for SIsal0.NE.0. |
| 29 |
|
Result change : cg2d -> 8 digits; ad -> 11-12-9 digits. |
| 30 |
|
o pkg/seaice: |
| 31 |
|
- unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT |
| 32 |
|
is now the default, and the old default constant freezing point is recovered with |
| 33 |
|
SEAICE_tempFrz0 = -1.96, |
| 34 |
|
SEAICE_dTempFrz_dS = 0., |
| 35 |
|
- retire SEAICE_freeze that was the old way of specifycing the constant freezing point. |
| 36 |
|
- remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there. |
| 37 |
|
- bug fix (thanks to M. Losch) : the sublimation term that was missing is now |
| 38 |
|
activated. To reproduce old results that had this bug define SEAICE_DISABLE_SUBLIM. |
| 39 |
|
- bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211) |
| 40 |
|
was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail). |
| 41 |
|
- bug fix (thanks to O. Jahn) : area loss for melting got messed up in |
| 42 |
|
seaice_growth r149 for legacy branch (no results change). |
| 43 |
|
- introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code from I. Fenty). |
| 44 |
|
- results did not change except for global_ocean.cs32x15, mostly due to the switch |
| 45 |
|
to variable freezing point (see above item for detail). |
| 46 |
|
o pkg/thsice: |
| 47 |
|
- fix and simplify interface to salt_plume pkg ; diagnose directly amount of |
| 48 |
|
seawater freezing in thsice_calc_thickn (not used). |
| 49 |
|
o pkg/seaice: turbulent flux term specification via run time params. |
| 50 |
|
- replace CPP switches with run time switches to facilitate testing |
| 51 |
|
- retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR |
| 52 |
|
- added runtime parameter : SEAICEturbFluxFormula |
| 53 |
|
- move Mcphee constants to SEAICE_PARAMS.h |
| 54 |
|
- seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula; |
| 55 |
|
SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); remove |
| 56 |
|
seaice_summary call (moved to seaice_init_fixed) |
| 57 |
|
- seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on |
| 58 |
|
SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms) |
| 59 |
|
- seaice_summary.F : add missing report of read turbulent flux term set up (and SITRACER). |
| 60 |
|
- seaice_check.F : check range; inform and stop if retired CPPs are used (incl. SEAICE_AGE). |
| 61 |
|
- seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without |
| 62 |
|
CPP switch, same computation as before for the different options. |
| 63 |
|
- change results at the truncation level. |
| 64 |
|
o pkg/seaice: |
| 65 |
|
- remove un-used parameters LAD & MAX_TICE ; add new run-time parameters: |
| 66 |
|
useMaykutSatVapPoly (default=F), postSolvTempIter (default=2) and |
| 67 |
|
SEAICE_wetAlbTemp (default=-1e-3). Remove option SEAICE_SOLVE4TEMP_LEGACY. |
| 68 |
|
- update verification/*/input*/data.seaice: |
| 69 |
|
to reproduce previous results with former #defined SEAICE_SOLVE4TEMP_LEGACY |
| 70 |
|
code, set useMaykutSatVapPoly=T & postSolvTempIter=0 ; |
| 71 |
|
and to reproduce previous results with former non-SOLVE4TEMP_LEGACY code, |
| 72 |
|
set SEAICE_wetAlbTemp=0 & SEAICE_snowThick=0. |
| 73 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY): |
| 74 |
|
- remove LEGACY code for solving for tsurf (A1,A2,A3) but maintain the same |
| 75 |
|
algorithm (same choice: useMaykutPolySatVap=T, postSolvTempIter=0); |
| 76 |
|
difference in results only due to machine truncation. |
| 77 |
|
- remove MAX_TICE (tsurf is always =< TMELT anyway); keep MIN_TICE if using |
| 78 |
|
MaykutPolySatVap; keep MIN_LWDOWN. |
| 79 |
|
- adapt SEAICE_MODIFY_GROWTH_ADJ code (untested) to non-legacy formulation. |
| 80 |
|
- update output of verification exp. lab_sea (4 fwd: 11 cg2d digits except hb87, |
| 81 |
|
+ 3 AD: 6 digits except evp) and offline_exf_seaice.seaice (12 digits). |
| 82 |
|
o pkg/salt_plume: |
| 83 |
|
- isolate saltPlumeFlux array exch into a specific S/R called from |
| 84 |
|
do_oceanic_phys.F |
| 85 |
|
- add interface to pkg/salt_plume (filling of saltPlumeFlux) in pkg/thsice. |
| 86 |
|
o verification: |
| 87 |
|
- move untested set-up to MITgcm_contrib/verification_other. |
| 88 |
|
o pkg/seaice: |
| 89 |
|
- retire old way of SEAICE_AGE. Now replaced with ALLOW_SITRACER. |
| 90 |
|
o pkg/seaice: |
| 91 |
|
- seaice_solve4temp.F (keeping results unchanged): |
| 92 |
|
* add 2 future run-time params to select which saturation vapor pressure |
| 93 |
|
formula is used and how post-iteration fluxes are set. |
| 94 |
|
Temporary set these 2 params according to option SOLVE4TEMP_LEGACY; |
| 95 |
|
* New piece of code (not used) to update surf. atmos. heat flux F_ia using |
| 96 |
|
the linearized expression to stay consistent with tsurf finding. |
| 97 |
|
- seaice_freedrift.F avoid floating exception in sqrt(y) since y=sqrt(x*x)-x |
| 98 |
|
can be < 0. |
| 99 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY undef): |
| 100 |
|
- remove from F_ia (and from it's derivative dFiDTs1) the contribution of |
| 101 |
|
conductive heat flux F_c , and add it explicitly when updating tsurf as |
| 102 |
|
solution of: Fc = Fia + d/dT(Fia - Fc) *delta.tsurf |
| 103 |
|
so that now F_ia has a consistent meaning through the entire routine. |
| 104 |
|
This causes differences at truncation level: update output of fwd exp. |
| 105 |
|
global_ocean.cs32x15.seaice. |
| 106 |
|
o pkg/seaice: |
| 107 |
|
- lots of editing/cleaning in seaice_solve4temp.F + better documentation |
| 108 |
|
of arrays, sign/direction of fluxes; no effect on results. |
| 109 |
|
- replace hard coded 273.16 (=previous value of celsius2K) by celsius2K |
| 110 |
|
in seaice_budget_ocean.F & seaice_solve4temp.F (SOLVE4TEMP_LEGACY part); |
| 111 |
|
note: this should have been done before changing celsius2K default. |
| 112 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 113 |
|
exp. input*/data : lab_sea (AD), offline_exf_seaice (fwd+AD) & seaice_obcs |
| 114 |
|
- replace hard coded seawater freezing temp in seaice_solve4temp.F (part |
| 115 |
|
SOLVE4TEMP_LEGACY) of 271.20 (=previous value of celsius2K + default |
| 116 |
|
value of SEAICE_freeze) by celsius2K+SEAICE_freeze so that seawater |
| 117 |
|
freezing temp is consistent with value in seaice_growth.F ; this causes |
| 118 |
|
differences at machine truncation level: update lab_sea AD output (3/4). |
| 119 |
|
o pkg/seaice: |
| 120 |
|
- mask (in exf_init_fixed.F) atemp,aqh,evap,precip,runoff,lwflx,areamask |
| 121 |
|
and climsst/sss even when using seaice (to prevent calculation that might |
| 122 |
|
use SST on land); does not affect any verification exp. |
| 123 |
|
- apply mask to taux,tauy (in seaice_get_dynforcing.F); update output |
| 124 |
|
of lab_sea.fd & lab_sea.hb87 and global_ocean.cs32x15.seaice_dynmix. |
| 125 |
|
o pkg/seaice/seaice_growth.F: add mask to avoid non-zero ice thickness |
| 126 |
|
over land (non-legacy code) |
| 127 |
|
o vectorize salt_plume package: |
| 128 |
|
- add extra code to salt_plume_frac and salt_plume_tendency_apply_s |
| 129 |
|
- this code computes plumebk everywhere (also over land), thus requires |
| 130 |
|
code to avoid divisions by zero and catch the case of kLev=Nr. |
| 131 |
|
- efficiency of salt_plume_frac is still sub-optimal |
| 132 |
|
o tools (genmake2): |
| 133 |
|
- fix makefile NAME specification (option: -makefile NAME) by adding |
| 134 |
|
"-f $MAKEFILE" in few places where it was missing including makedepend |
| 135 |
|
command (contribution from Paul). |
| 136 |
|
|
| 137 |
|
checkpoint63i (2012/01/24) |
| 138 |
|
o model/src: |
| 139 |
|
- add factorized versions of some EOS code to find_rho.F, |
| 140 |
|
define USE_FACTORIZED_EOS to turn it on (default for TARGET_NEC_SX) |
| 141 |
|
o model/src: |
| 142 |
|
- add celsius2K to namelist PARM01; remove unused recip_rhoNil from PARAMS.h; |
| 143 |
|
- change default celsius2K from 273.16 to 273.15 |
| 144 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 145 |
|
exp. input*/data : aim.5l_cs, 1D_ocean_ice_column, lab_sea (fwd), |
| 146 |
|
global_ocean.cs32x15(seaice) & cpl_aim+ocn(input_atm). |
| 147 |
|
o model/src: add a little initialisation trick to find_rho.F and find_alpha.F |
| 148 |
|
to make TAF generate vectorizable code |
| 149 |
|
o pkg/seaice/seaice_evp.F: add code (copied from CICE) that avoids underflows. |
| 150 |
|
Turn on by defining SEAICE_EVP_ELIMINATE_UNDERFLOWS. Most compilers |
| 151 |
|
have flags that do this more efficiently. |
| 152 |
|
o pkg/diagnostics/diagstats_calc.F |
| 153 |
|
- for TARGET_NEC_SX fix the treatment of the scaling factor tmpFac=scaleFact |
| 154 |
|
o pkg/obcs (with exch2): |
| 155 |
|
- derive OB indices in overlap region from OB-InsideMask (in obcs_init_fixed.F) |
| 156 |
|
and remove code (in obcs_readparms.F) which was based on EXCH of indices |
| 157 |
|
(through buffer) and did not account for exch2 (e.g., CS-grid) topology. |
| 158 |
|
o pkg/exf and seaice exp: |
| 159 |
|
- change offline_exf_seaice.seaicetd test exp. to use default DIFF1 value (=0) |
| 160 |
|
so that switching off area & heff advection flags does not affect results. |
| 161 |
|
- change default EXF_LWDOWN_WITH_EMISSIVITY to #define in EXF_OPTIONS.h |
| 162 |
|
- keep exp. seaice_obcs & 1D_ocean_ice_column(ad) unchanged (using #undef |
| 163 |
|
EXF_LWDOWN_WITH_EMISSIVITY) and, using pkg/exf default emissivities, update |
| 164 |
|
results of verification experiments: 1D_ocean_ice_column(fwd), |
| 165 |
|
global_ocean.cs32x15.seaice(fwd+ad) & seaice_dynmix(ad), lab_sea (all 8) |
| 166 |
|
and offline_exf_seaice (all 4). |
| 167 |
|
o pkg/seaice: |
| 168 |
|
- remove array YNEG, RIVER, TMIX (replaced by local var) from common block; |
| 169 |
|
remove also areaNm1 & hEffNm1 when SEAICE_GROWTH_LEGACY is undef. |
| 170 |
|
- fix bug: areaNm1 & hEffNm1 are needed in seaice_growth (SEAICE_GROWTH_LEGACY) |
| 171 |
|
but were not filled when resp. SEAICEadvArea=F & SEAICEadvHeff=F and |
| 172 |
|
not multi-dim advection; |
| 173 |
|
- fix seaice_growth.F to compile with both SEAICE_GROWTH_LEGACY and |
| 174 |
|
SHORTWAVE_HEATING #undef. |
| 175 |
|
o optim: make Makefile more robust (?) |
| 176 |
|
o pkg/obcs: |
| 177 |
|
* fix treatment of obcs_read_pickup for TAF |
| 178 |
|
o pkg/shelfice: |
| 179 |
|
* add missing initialisation of num_shifwflx |
| 180 |
|
* new adjoint verification exp. for isomip |
| 181 |
|
* change Prandtl and Schmidt numbers from generic formulations |
| 182 |
|
(in terms of model diffus. and visc.) to separate runtime |
| 183 |
|
parameters, with Holland and Jenkins (1999) default values. |
| 184 |
|
o pkg/exf (interpolation): |
| 185 |
|
- extended input field (2 rows) near the N & S poles: |
| 186 |
|
* fill in with the symetric value (when even Nb of data in longitude) |
| 187 |
|
* add average value at the poles only for scalar quantities ; for vector |
| 188 |
|
component interpolation, skip the averaging and keep duplicated values, |
| 189 |
|
unless the 2 components have same location (uvInterp=T) in which case |
| 190 |
|
interpolate the 2 components together using S/R EXF_INTERP_UV. |
| 191 |
|
- new S/R EXF_INTERP_UV to interpolate the 2 components of a vector field |
| 192 |
|
together: this allows to account properly for local orientation when |
| 193 |
|
averaging at N & S pole. |
| 194 |
|
- add CPP option EXF_USE_OLD_INTERP_POLE to recover old results regarding |
| 195 |
|
exf-interpolation near N & S poles. Undef by default. |
| 196 |
|
- add debug check/print on 1rst iter if debugLevel >=2. |
| 197 |
|
o pkg/exf: |
| 198 |
|
- change masking flags definition (no longer "parameter"), put them in |
| 199 |
|
common block and set them in S/R EXF_INIT_FIXED. |
| 200 |
|
- change recognized masking flag from s,u,v to c,w,s since the mask |
| 201 |
|
to use (maskC,W,S) depends on position on model grid and has little to |
| 202 |
|
do with scalar/vector difference; fix masking if using P-coordinates. |
| 203 |
|
- fix masking of wind-stress (was wrong if interpolated or read on A-grid) |
| 204 |
|
and update results of exp. global_with_exf (x2). |
| 205 |
|
- fix setting of zenith-angle table when SHORTWAVE_HEATING is undef. |
| 206 |
|
o pkg/obcs |
| 207 |
|
- S/R obcs_calc_stevens: fix a small bug (gammat -> gammas where appropriate) |
| 208 |
|
o pkg/exf (interpolation): |
| 209 |
|
- assume periodicity in X only if input field cover full longitude range. |
| 210 |
|
- improve search for lat. index (supposed to be faster, in ~log2(ny) steps, |
| 211 |
|
and should vectorise). |
| 212 |
|
- fix input lat of the 2 added row (in case we provide N.pole data). |
| 213 |
|
|
| 214 |
|
checkpoint63h (2011/12/30) |
| 215 |
|
o pkg/seaice: |
| 216 |
|
- change declaration of UVM from _RL to _RS in order to get B-grid |
| 217 |
|
uIce,vIce monitor when _RS = real*4 |
| 218 |
|
o pkg/offline: |
| 219 |
|
- new S/R OFFLINE_RESET_PARMS for resetting main-model params (switch off flags); |
| 220 |
|
- compute vertical velocity if not read from file (switch on exactConserv |
| 221 |
|
& staggerTimeStep); |
| 222 |
|
- fix output of ptracer monitor iter & time for default PTRACERS_monitorFreq. |
| 223 |
|
o verification: |
| 224 |
|
- update grid-files (in tutorial_held_suarez_cs/input and fizhi-cs-32x32x40/input) |
| 225 |
|
with grid-angle generated using "utils/matlab/cs_grid/cubeCalcAngle.m": |
| 226 |
|
fix Pb in yG definition @ 2 missing corners (previously yG was averaged); |
| 227 |
|
- update output of exp. global_ocean.cs32x15.viscA4 after changing |
| 228 |
|
grid-file angles (used here for coriolis-3d); |
| 229 |
|
- remove (or gzip) few files not needed to run fizhi-cs experiments. |
| 230 |
|
o pkg/exf (vector interpolation): |
| 231 |
|
- rotate vector component toward local grid-axis orientation using grid-angles |
| 232 |
|
(stored in GRID.h) instead of locally computed rotation angle; keep old code |
| 233 |
|
available with exf option EXF_USE_OLD_VEC_ROTATION (undef by default). |
| 234 |
|
o pkg/seaice: |
| 235 |
|
- allow to compile with exf options ALLOW_ATM_TEMP or ALLOW_DOWNWARD_RADIATION |
| 236 |
|
undefined. Fix and remove the stop when ALLOW_RUNOFF is undefined. |
| 237 |
|
o pkg/PKG_OPTIONS.h files: |
| 238 |
|
- move #include "CPP_OPTIONS.h" just after #include "PACKAGES_CONFIG.h", |
| 239 |
|
outside of the #ifdef ALLOW_THISPKG / #endif block. |
| 240 |
|
- update verification/*/code/PKG_OPTIONS.h files. |
| 241 |
|
o add a verification experiment (offline_exf_seaice/input.seaice) that test |
| 242 |
|
the B-grid LSOR solver |
| 243 |
|
o pkg/seaice: sort out emissivity and long wave radiation step 2: |
| 244 |
|
- add emissivity for snow and ice as new run-time parameters |
| 245 |
|
(unfortunately) that default to the corresponding exf values; this |
| 246 |
|
changes results in most verification experiments so that for backward |
| 247 |
|
compatibility these parameter have to be set explicitly to inconsistent |
| 248 |
|
values (ugly); |
| 249 |
|
- the exf-flag EXF_LWDOWN_WITH_EMISSIVITY then gets rid off the hard-wired |
| 250 |
|
emissivities of 0.97 associated with lwdownloc in S/R seaice_solve4temp |
| 251 |
|
until we agree how to handle this bug properly |
| 252 |
|
o pkg/exf (interpolation): |
| 253 |
|
- add a set of run-time param ({inputfield}_interpMethod), one for |
| 254 |
|
each interpolated input field, to select the interpolation method |
| 255 |
|
with a value of zero switching off the interpolation; |
| 256 |
|
- print interpolation parameters to standard output; |
| 257 |
|
- refine exf_check.F accordingly ; stop if USE_NO_INTERP_RUNOFF is defined |
| 258 |
|
(to use instead runoff_interpMethod=0 in data.exf). |
| 259 |
|
- simplify default setting of interpolation parameters (for all fields, |
| 260 |
|
set position to match model grid cell-center position, leading to trivial |
| 261 |
|
interpolation in case of regular Lat-Lon grid) and fix for the case of |
| 262 |
|
non-uniform delY. |
| 263 |
|
o pkg/exf/exf_radiation.F: add the factor ocean_emissivity to lwdown, for |
| 264 |
|
within #ifdef EXF_LWDOWN_WITH_EMISSIVITY/#endif. Unless ocean_emissivity=1. |
| 265 |
|
this factor is absolutely required, because the lw exitance (= out-going |
| 266 |
|
long wave radiation) is emissivity*stefanBoltzmann*T^4 + rho*lwdown, |
| 267 |
|
where the reflectivity rho = 1-emissivity for conservation reasons. Once |
| 268 |
|
this is established, we can remove the CPP-Flag (if we want to). |
| 269 |
|
o pkg/seaice: |
| 270 |
|
- qualify a stop statement in S/R seaice_check: EXF_READ_EVAP and |
| 271 |
|
ALLOW_BULKFORMULAE are only required if SEAICE_EXTERNAL_FLUXES is defined |
| 272 |
|
- sort out emissivity and long wave radiation, step 1: make SEAICE_emissivity |
| 273 |
|
what the name implies (and not emissivity*BoltzmannConstant), this means |
| 274 |
|
the old default value of 5.5e-8 now means |
| 275 |
|
5.5e-8/5.670e-8 = 0.97001763668430343479 as ocean_emissivity in |
| 276 |
|
S/R exf_readparms |
| 277 |
|
- FV-discretization of the B-grid LSOR solver, turn on with |
| 278 |
|
SEAICE_LSRBNEW. This new solver also involves a slight re-organization |
| 279 |
|
of the calling routine dynsolver, so that B and C-grid code look a |
| 280 |
|
little more alike. |
| 281 |
|
- fix index bugs in ostres.F (B-grid code) |
| 282 |
|
o pkg/seaice/seaice_ocean_budget.F: change (unused) code to make it look better |
| 283 |
|
o pkg/seaice/seaice_readparms.F: make ocean_emissivity*stefanBoltzmann the |
| 284 |
|
default for SEAICE_emissivity, if useEXF; requires setting a wrong |
| 285 |
|
parameter value in global_ocean.cs32x15/input.seaice/data.seaice for |
| 286 |
|
backward compatiblity |
| 287 |
|
o model/src: use sigmaR in calc_ivdc |
| 288 |
|
|
| 289 |
|
checkpoint63g (2011/12/16) |
| 290 |
|
o pkg/seaice/seaice_growth.F: |
| 291 |
|
fix heat conservation of the coupled ocean-seaice system. |
| 292 |
|
when SEAICE_HEAT_CONSERV_FIX is defined, the mismatch of |
| 293 |
|
solid vs liquid water treatment is resolved via QNET. |
| 294 |
|
o pkg/seaice/seaice_growth.F: |
| 295 |
|
add missing term for sublimation in saltFlux, which was breaking conservation. |
| 296 |
|
o pkg/seaice/seaice_model.F: |
| 297 |
|
Remove this patholigical case treatment in evolution branch, |
| 298 |
|
where it is un-necessary and breaks conservation. |
| 299 |
|
Update global_ocean.cs32x15/results accordingly for |
| 300 |
|
output.seaice.txt output_adm.seaice.txt and output_adm.seaice_dynmix.txt |
| 301 |
|
o model/src: |
| 302 |
|
useRealFreshWaterFlux: remove masking of EmPmP (using maskInC) in |
| 303 |
|
external_forcing_surf.F and apply mask directly in S/R SOLVE_FOR_PRESSURE. |
| 304 |
|
o pkg/obcs: |
| 305 |
|
modify Stevens boundary conditions so that S/R obcs_calc_stevens computes |
| 306 |
|
tendency for temperature and salinity that is then applied to update |
| 307 |
|
theta and salt in S/R obcs_apply_ts; this requires proper masking of all |
| 308 |
|
horizontal advection and diffusion contributions on the boundary (in |
| 309 |
|
S/Rs gad_advection, gad_calc_rhs, gmredi_rtransport, gmredi_calc_diff), and |
| 310 |
|
removing the mask in S/R timestep_tracer. The advantage of this approach is |
| 311 |
|
that the updated tracer values include contributions from the surface |
| 312 |
|
forcing and vertical diffusion. |
| 313 |
|
This modification changes exp4.stevens because of vertical diffusion. |
| 314 |
|
o model/src: |
| 315 |
|
change non-curvilinear grid setting to also work with exch2 + blank tiles: |
| 316 |
|
- move delX,delY to new header file (SET_GRID.h) and adjust length to 1rst |
| 317 |
|
face dimensions. |
| 318 |
|
- new S/R INI_LOCAL_GRID to define model tile-local grid (using same units |
| 319 |
|
as delX,delY) and called from S/R INI_CARTESIAN_GRID, INI_CYLINDER_GRID |
| 320 |
|
and INI_SPHERICAL_POLAR_GRID. |
| 321 |
|
change test-experiment global_ocean.90x40x15: |
| 322 |
|
- split the domain in many more tiles (9x4 tiles of 10x10 each); |
| 323 |
|
- switch to exch2 and remove 1 blank-tile (but only for MPI test). |
| 324 |
|
- update results of both test (std & dwnslp). |
| 325 |
|
o pkg/diagnostics/diagstat_calc.F: fix problem with non-initialised halos in |
| 326 |
|
tmp-fields for TARGET_NEC_SX at the cost of extra loops and less vectorisation |
| 327 |
|
o model/src: |
| 328 |
|
- take sigma-coords related code out of update_etah.F into new S/R UPDATE_ETAWS |
| 329 |
|
and fix initialisation when using sigma-coords. |
| 330 |
|
o model/src: |
| 331 |
|
- improve Gael's changes from Jan 14, 2011 "addition of an 'update' of hfacc etc. |
| 332 |
|
to their current value at the beginning of forward_step.F": add a new run-time |
| 333 |
|
switch "doResetHFactors" (default=false) and use it to do (or not) the resetting. |
| 334 |
|
- set doResetHFactors=T in the following test exp: |
| 335 |
|
global_ocean.90x40x15/input (rStar) & input.dwnslp (linFS), |
| 336 |
|
global_ocean.cs32x15/input.seaice (rStar), hs94.cs-32x32x5/input.impIGW (linFS) |
| 337 |
|
and tutorial_global_oce_in_p (nonLinFS in p) |
| 338 |
|
o pkg/ecco |
| 339 |
|
- added IES cost term |
| 340 |
|
o verification/advect_xz |
| 341 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 342 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 343 |
|
- add note (check_conserve_TS.txt) and matlab script to check global |
| 344 |
|
conservation of T & S with NonLin-FreeSurf and Adams-Bashforth. |
| 345 |
|
o pkg/rbcs: |
| 346 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 347 |
|
o pkg/obcs (Stevens BCs): |
| 348 |
|
- fix various problems in the phase speed computations of the Stevens |
| 349 |
|
boundary conditions: |
| 350 |
|
- sign error for western and southern boundaries, |
| 351 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 352 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 353 |
|
from difference between previous (n) time level and the one before (n-1); |
| 354 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 355 |
|
files. |
| 356 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 357 |
|
- set default phase velocity to cflMer/Zon |
| 358 |
|
- update verification experiment exp4.stevens |
| 359 |
|
o pkg/generic_advdiff (implicit_r): |
| 360 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 361 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 362 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 363 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 364 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 365 |
|
solver S/R ; |
| 366 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 367 |
|
when using implicit vert. advection; |
| 368 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 369 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 370 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 371 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 372 |
|
o pkg/diagnostics: |
| 373 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 374 |
|
|
| 375 |
|
checkpoint63f (2011/11/30) |
| 376 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 377 |
|
- join some loops to reduce number of if-statements |
| 378 |
|
- fix a bug in code for northern and southern boundaries. |
| 379 |
|
o pkg/seaice/seaice_init_varia.F |
| 380 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 381 |
|
caused zero ice-velocities for the B-grid code |
| 382 |
|
o pkg/seaice/seaice_init_fixed.F |
| 383 |
|
- fix a bug in the initialisation of the second metric terms |
| 384 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 385 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 386 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 387 |
|
= .true. (default) |
| 388 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 389 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 390 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 391 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 392 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 393 |
|
o model/src: |
| 394 |
|
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 395 |
|
- call INTEGR_CONTINUITY directly from forward_step.F |
| 396 |
|
(previously called from momentum_correction_step.F) |
| 397 |
|
- call UPDATE_ETAH from integr_continuity.F and update initialise_varia.F, |
| 398 |
|
forward_step.F and pkg/ecco/the_main_loop.F |
| 399 |
|
o model/src/do_oceanic_phys.F: |
| 400 |
|
- reset addMass to zero only if useICEFRONT ; |
| 401 |
|
- separated k-loop for rhoInSitu calculation ; |
| 402 |
|
- add 2 diagnostics for wVel*delta^k(Rho) at constant pressure (= WdRHO_P) |
| 403 |
|
and at constant T,S (= WdRHOdP); |
| 404 |
|
NOTE: change diagnostics WRHOMASS : this is now simply the Vertical transport |
| 405 |
|
of In-Situ Density (Anomaly) (=wVel*rho^bar-k) (previously was Vertical |
| 406 |
|
transport of locally-referenced potential density); |
| 407 |
|
to recover old diag: (WRHOMASS)_old = (WRHOMASS)_new -1/2 * (WdRHOdP) |
| 408 |
|
o gluemnc: |
| 409 |
|
- replace ncrcat with ncks when adding variables to *.glob.nc |
| 410 |
|
- change the way variables without record dimensions are handled so that |
| 411 |
|
files that have variables with and without record variables can be glued: |
| 412 |
|
add a record dimension with a new unique name to be able to differentiate |
| 413 |
|
between variable with and without a-prior record dimensions. Remove |
| 414 |
|
this record dimension before adding the variable to the *.glob.nc file. |
| 415 |
|
This procedure automatically works also for grid.*.nc files that do not |
| 416 |
|
have any record dimension. |
| 417 |
|
o verification/cpl_aim+ocn: |
| 418 |
|
- generate new reference output on baudelaire (gfortran, mpich2) (previously |
| 419 |
|
from old aces-grid cluster, ao + ifort) and update 'run_cpl_test' script. |
| 420 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 421 |
|
- add code for northern and southern boundaries. |
| 422 |
|
- reorder some loops to save some operations and so that drFBar can be scalar |
| 423 |
|
o model/src: |
| 424 |
|
- re-arrange extrapolation calculation in Adams-Bashforth S/R (affects machine |
| 425 |
|
truncation) and add diagnostics for Adams-Bashforth tendency increment. |
| 426 |
|
- update test-exp. AD output: |
| 427 |
|
1D_ocean_ice_column, bottom_ctrl_5x5, lab_sea.noseaicedyn, obcs_ctrl; |
| 428 |
|
and FWD output: exp4 (x3), fizhi-cs-32x32x40, fizhi-cs-aqualev20, |
| 429 |
|
front_relax (x3), global_ocean.90x40x15 (x2), global_ocean.cs32x15 (x5), |
| 430 |
|
global_ocean_ebm, ideal_2D_oce, internal_wave, isomip (x3), lab_sea (x4), |
| 431 |
|
matrix_example, MLAdjust (x5), natl_box (x2), tutorial_advection_in_gyre, |
| 432 |
|
tutorial_global_oce_in_p, tutorial_global_oce_latlon and |
| 433 |
|
tutorial_plume_on_slope. |
| 434 |
|
o pkg/diagnostics/diagstats_calc.F: add special code for TARGET_NEC_SX |
| 435 |
|
that vectorises. This code uses 3 extra 2D fields, F90 array assignments |
| 436 |
|
and F90 intrinsic routines SUM, MINVAL, MAXVAL, but since TARGET_NEC_SX |
| 437 |
|
does not even come with an F77 compiler anymore, this should not be |
| 438 |
|
a limitation |
| 439 |
|
|
| 440 |
|
checkpoint63e (2011/11/06) |
| 441 |
|
o pkg/seaice adjoint of LSR: |
| 442 |
|
- substantially rework STORE dirs. |
| 443 |
|
- add new flag SEAICE_LSR_ADJOINT_ITER and parameter SOLV_MAX_FIXED |
| 444 |
|
this flag will do SOLV_MAX_ITERS but only store SOLV_MAX_FIXED fields |
| 445 |
|
and only perform SOLV_MAX_FIXED adjoint iters. |
| 446 |
|
If flag SEAICE_LSR_ADJOINT_ITER is undef-ined, the store in the iteration |
| 447 |
|
always goes to same record, meaning that the last forward field will be |
| 448 |
|
the one used in the adjoint - an approximation. |
| 449 |
|
- now produces non-zero LSR-related gradients, and acceptable gradients for |
| 450 |
|
An's zonal (x-z) test case (to be checked in) |
| 451 |
|
- lab_sea: produces acceptable gradients for lab_sea with forward/backward LSR |
| 452 |
|
(but these are screwed up by the thermodynamics in the first place); |
| 453 |
|
reduce from 4 to 3 timesteps to avoid t.d. issue as temporary solution; |
| 454 |
|
output_adm.txt also reflects changes to seaice_lsr |
| 455 |
|
- global_ocean.cs32x15: |
| 456 |
|
* the "default" input_ad.seaice has been re-defined to always exclude dynamics |
| 457 |
|
(output_adm.seaice.txt was updated) |
| 458 |
|
* new input_ad.seaice_dynmix tests a forward LSR / backward free-drift |
| 459 |
|
(output_adm.seaice_dynmix.txt) |
| 460 |
|
o test-exp. exp4+stevens: |
| 461 |
|
- switch off pTracers and nonHydrostatic (restart problems with NH); update output |
| 462 |
|
o pkg/seaice (lsr solver): |
| 463 |
|
- put coriolis term into FORCEX,Y (as in seaice_evp.F; previously in rhsU,V only); |
| 464 |
|
update output (change truncation) of FWD test exp lab_sea & global_ocean.cs32x15 |
| 465 |
|
- fix SEAICEuseFREEDRIFT for new OBCS version (ndef OBCS_UVICE_OLD) |
| 466 |
|
- new parameter "LSR_mixIniGuess" allows (if=2,4) to mix free-drift solution |
| 467 |
|
into initial guess for linearised solver; use weight ~ (1/err)^2,4. |
| 468 |
|
- compute (with new S/R) and print initial (+ free-driff sol. if available) |
| 469 |
|
and final residual of linearised system. |
| 470 |
|
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
| 471 |
|
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
| 472 |
|
o pkg/obcs: Stevens BCs (still only for east and west) |
| 473 |
|
- fix Stevens BCs by using intermediate velocities of previous |
| 474 |
|
time step as "baroclinic" contribution rather velocity of one grid cell |
| 475 |
|
inside the boundaries; more consistent but makes the entire treatment |
| 476 |
|
more complicated, requires new pickup files and two new S/Rs: |
| 477 |
|
obcs_copy_uv_n and obcs_save_uv_n |
| 478 |
|
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
| 479 |
|
(undefined by default) |
| 480 |
|
- silently move computation of some grid factors into separate loops to |
| 481 |
|
save some recomputations |
| 482 |
|
- add a hack for non-linear free surface |
| 483 |
|
- add a verification experiment to exp4 that tests this code |
| 484 |
|
o make gluemnc/xplodemnc work with (moron) non-GNU shell tools |
| 485 |
|
|
| 486 |
|
checkpoint63d (2011/10/25) |
| 487 |
|
o pkg/obcs + seaice-dynamics: |
| 488 |
|
- new implementation calls OBCS_APPLY_UVICE (in seaice_dynsolver.F) before |
| 489 |
|
solving for uIce,vIce and prevent SEAICE_LSR or SEAICE_EVP to modify OB |
| 490 |
|
values (consistent with an implicit method). |
| 491 |
|
- add option OBCS_UVICE_OLD (in OBCS_OPTIONS.h, defined by default) to |
| 492 |
|
return to older implementation (same results as before); note that none of |
| 493 |
|
the "experimental" OBCS_SEAICE options are implemented in the new version. |
| 494 |
|
- switch test exp. seaice_obcs to use new version (update output). |
| 495 |
|
o pkg/seaice: |
| 496 |
|
- add few stop (B-grid & CS-exch, B-grid & obcs, AUTODIFF & SEAICE_maskRHS) |
| 497 |
|
- add parenthesis in Water-Ice drag calculations (evp & lsr); |
| 498 |
|
- in seaice_lsr.F, simplify and fix AA3 setting in case sNx or sNy=1; |
| 499 |
|
and fix case SEAICE_waterDrag=0 (but unstable if no or little seaice) |
| 500 |
|
- update output of test exp lab_sea that uses evp or lsr (fwd+ad) |
| 501 |
|
and global_ocean.cs32x15 (icedyn & seaice fwd+ad). |
| 502 |
|
o pkg/layers: |
| 503 |
|
- Include potential density as new coordinate (Thanks to David Munday) |
| 504 |
|
o pkg/dic: |
| 505 |
|
- Remove subroutine CALC_PCO2_APPROX_CO3 from carbon_chem.F and add |
| 506 |
|
carbonate computation/output to CALC_PCO2_APPROX |
| 507 |
|
o pkg/generic_advdiff |
| 508 |
|
- make TAF generate code that vectorizes: |
| 509 |
|
gad_dst3fl_adv_*.F, gad_u3c4_impl_r.F |
| 510 |
|
o model/src: |
| 511 |
|
- improve vectorization also for adjoint code of |
| 512 |
|
solve_tridiagonal and solve_pentadiagonal. As this requires up to |
| 513 |
|
5 new 3D-fields, this code is only turned on for the combination of |
| 514 |
|
ALLOW_AUTODIFF_TAMC and TARGET_NEC_SX. Also remove error message |
| 515 |
|
for singular matrix check (only for TARGET_NEC_SX). |
| 516 |
|
- remove hard-wiring of CPP-flag ALLOW_SOLVERS_KLOOPINSIDE to |
| 517 |
|
ALLOW_AUTODIFF. This flag now needs to be set outside of |
| 518 |
|
solve_tri/pentadiagonal.F |
| 519 |
|
o pkg/exf: |
| 520 |
|
- fix previous modif in exf_readparms.F (revision 1.66: treatment of |
| 521 |
|
optional namelist EXF_NML_OBCS). |
| 522 |
|
- add many debug-print (to trace down where pkg/cal error msg comes from) |
| 523 |
|
o pkg/mom_vecinv/mom_vi_hdissip.F |
| 524 |
|
- rearrange loops so that vectorization is improved and in particular |
| 525 |
|
the adjoint routine vectorizes. The code is a little longer now, but I |
| 526 |
|
think easier to read. |
| 527 |
|
Note: CPP-flag MOM_VI_ORIGINAL_VISCA4 is not tested. |
| 528 |
|
o pkg/seaice: |
| 529 |
|
- allow to specify initial seaice velocity from files (uIceFile,vIceFile) |
| 530 |
|
o pkg/exch2: |
| 531 |
|
- alternative code (without tile x tile matrix) for cumulated (global) sum; |
| 532 |
|
used as default; keep using matrix version in adjustment.cs-32x32x1. |
| 533 |
|
o tools/build_options: |
| 534 |
|
- after merging some MPI and/or multi-threads specific optfiles so that |
| 535 |
|
the modified default optfile support both built (using genmake2 -mpi |
| 536 |
|
for the MPI built, using genmake2 -omp for OpenMP built), |
| 537 |
|
move now obsolete optfiles to tools/build_options/unsupported/ |
| 538 |
|
(add copy of email sent to support list in doc/optfiles_changes.txt) |
| 539 |
|
|
| 540 |
|
checkpoint63c (2011/09/28) |
| 541 |
|
o pkg/ebm: |
| 542 |
|
- fix ebm_zonalmean.F for several procs in Ydir (nPy > 1); update output of |
| 543 |
|
test exp. global_ocean_ebm (affects machine truncation, 12 digits for cg2d) |
| 544 |
|
o pkg/seaice (SItracer pickup) |
| 545 |
|
* Simple code for pickup of SItracer fields (#define ALLOW_SITRACER) |
| 546 |
|
To be done: |
| 547 |
|
- thorough testing of missing fields in S/R seaice_read_pickup |
| 548 |
|
- thorough matching between generic tracers and specific fields used |
| 549 |
|
(e.g. volume-weighted age, area-weighted age, salinity, ...) |
| 550 |
|
o pkg/grdchk: |
| 551 |
|
- all procs calculate and print finite-difference gradient (for testreport) |
| 552 |
|
- change description output used by testreport; |
| 553 |
|
- AD testing: also compare and report Finite-difference gradient; |
| 554 |
|
=> update all output_adm*.txt |
| 555 |
|
o test exp. global_ocean_ebm: |
| 556 |
|
- switch back useRealFreshWaterFlux (no problem anymore with run-off); |
| 557 |
|
and turn on exactConserve; update (fwd) output. |
| 558 |
|
o pkg/seaice (LSR): |
| 559 |
|
- print to STDOUT number of solver iterations at SEAICE_monFreq interval. |
| 560 |
|
- modify solver to deal cleanly with u/v switch at face edges (CS-grid): |
| 561 |
|
* identical results with non-CS topology (but save up to half of EXCH calls) |
| 562 |
|
* no much changes in cs-32 verification tests since no ice at face edges |
| 563 |
|
(differences due to convergence criteria, since nb of iterations changed) |
| 564 |
|
* expect some differences on lat-lon-cap grid. |
| 565 |
|
update FWD results of global_ocean.cs32x15 test exp. (icedyn & seaice) |
| 566 |
|
o pkg/exch2: |
| 567 |
|
- add new CPP option to disable Cumul-Sum matrix (to save storage when using |
| 568 |
|
many tiles); until alternative coding is added, just add a stop. |
| 569 |
|
o pkg/kpp: |
| 570 |
|
- move ptracer/salt correction to KPP diffusivity from calc_3d_diffusivity.F |
| 571 |
|
to S/R KPP_CALC_DIFF_PTR (+ add tracer-index to argument list). |
| 572 |
|
o optfiles: |
| 573 |
|
- merged few MPI specific (*+mpi*) and multi-threads specific (*+mth) optfiles |
| 574 |
|
into corresponding standard one, which now support different build: |
| 575 |
|
(when using "genmake2 -mpi" for MPI built, "genmake2 -omp" for OpenMP built) |
| 576 |
|
- add "darwin_amd64_gfortran" optfile (initially from Constantinos, tested by Gael) |
| 577 |
|
o pkg/obcs (seaice): |
| 578 |
|
- add missing EXCH for uIce,vIce after applying OBCS; |
| 579 |
|
- remove S/R EXF_SWAPFFIELDS_X/Y , disable S/R EXF_SET_OBCS_X/Y by adding |
| 580 |
|
argument = number of levels to S/R EXF_SWAPFFIELDS_XZ/YZ and S/R |
| 581 |
|
EXF_SET_OBCS_XZ/YZ ; update obcs_exf_load.F; |
| 582 |
|
- fix EXF_SET_OBCS_XZ/YZ for multi-threaded (assuming loaded arrays are shared) |
| 583 |
|
- verification exp. seaice_obcs: split domain in 2 tiles ; add SIZE.h_mpi |
| 584 |
|
and eedata.mth for MPI and mutlti-threaded testing. |
| 585 |
|
o pkg/flt: |
| 586 |
|
- make FLT EXCH working with multi-threads (and MPI + multi-threads); |
| 587 |
|
- use buffer for floats IO (trajectories & profiles); size set in FLT_SIZE.h; |
| 588 |
|
- fix pickup and trajectories + profiles output with multi-threads; |
| 589 |
|
- add parameter to select group of fields to write along trajectory and |
| 590 |
|
profile (default unchanged); |
| 591 |
|
- only call PORT_RAND* function when flt_noise <> 0; |
| 592 |
|
- add multi-threaded test for verification exp. flt_example. |
| 593 |
|
o eesupp/src: |
| 594 |
|
- fix S/R ALL_PROC_DIE for MPI+multi-threads. |
| 595 |
|
- USE_OMP_THREADING: check that number of threads (from eedata) matches |
| 596 |
|
actual number (from env.var. setting). |
| 597 |
o pkg/ebm: |
o pkg/ebm: |
| 598 |
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
| 599 |
- add multi-threaded test for verification exp. global_ocean_ebm |
- add multi-threaded test for verification exp. global_ocean_ebm |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch