| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o verification/advect_xz |
| 8 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 9 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 10 |
|
o pkg/rbcs: |
| 11 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 12 |
|
o pkg/obcs (Stevens BCs): |
| 13 |
|
- fix various problems in the phase speed computations of the Stevens |
| 14 |
|
boundary conditions: |
| 15 |
|
- sign error for western and southern boundaries, |
| 16 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 17 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 18 |
|
from difference between previous (n) time level and the one before (n-1); |
| 19 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 20 |
|
files. |
| 21 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 22 |
|
- set default phase velocity to cflMer/Zon |
| 23 |
|
- update verification experiment exp4.stevens |
| 24 |
|
o pkg/generic_advdiff (implicit_r): |
| 25 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 26 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 27 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 28 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 29 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 30 |
|
solver S/R ; |
| 31 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 32 |
|
when using implicit vert. advection; |
| 33 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 34 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 35 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 36 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 37 |
|
o pkg/diagnostics: |
| 38 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 39 |
|
|
| 40 |
|
checkpoint63f (2011/11/30) |
| 41 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 42 |
|
- join some loops to reduce number of if-statements |
| 43 |
|
- fix a bug in code for northern and southern boundaries. |
| 44 |
|
o pkg/seaice/seaice_init_varia.F |
| 45 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 46 |
|
caused zero ice-velocities for the B-grid code |
| 47 |
|
o pkg/seaice/seaice_init_fixed.F |
| 48 |
|
- fix a bug in the initialisation of the second metric terms |
| 49 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 50 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 51 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 52 |
|
= .true. (default) |
| 53 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 54 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 55 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 56 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 57 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 58 |
|
o model/src: |
| 59 |
|
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 60 |
|
- call INTEGR_CONTINUITY directly from forward_step.F |
| 61 |
|
(previously called from momentum_correction_step.F) |
| 62 |
|
- call UPDATE_ETAH from integr_continuity.F and update initialise_varia.F, |
| 63 |
|
forward_step.F and pkg/ecco/the_main_loop.F |
| 64 |
|
o model/src/do_oceanic_phys.F: |
| 65 |
|
- reset addMass to zero only if useICEFRONT ; |
| 66 |
|
- separated k-loop for rhoInSitu calculation ; |
| 67 |
|
- add 2 diagnostics for wVel*delta^k(Rho) at constant pressure (= WdRHO_P) |
| 68 |
|
and at constant T,S (= WdRHOdP); |
| 69 |
|
NOTE: change diagnostics WRHOMASS : this is now simply the Vertical transport |
| 70 |
|
of In-Situ Density (Anomaly) (=wVel*rho^bar-k) (previously was Vertical |
| 71 |
|
transport of locally-referenced potential density); |
| 72 |
|
to recover old diag: (WRHOMASS)_old = (WRHOMASS)_new -1/2 * (WdRHOdP) |
| 73 |
|
o gluemnc: |
| 74 |
|
- replace ncrcat with ncks when adding variables to *.glob.nc |
| 75 |
|
- change the way variables without record dimensions are handled so that |
| 76 |
|
files that have variables with and without record variables can be glued: |
| 77 |
|
add a record dimension with a new unique name to be able to differentiate |
| 78 |
|
between variable with and without a-prior record dimensions. Remove |
| 79 |
|
this record dimension before adding the variable to the *.glob.nc file. |
| 80 |
|
This procedure automatically works also for grid.*.nc files that do not |
| 81 |
|
have any record dimension. |
| 82 |
|
o verification/cpl_aim+ocn: |
| 83 |
|
- generate new reference output on baudelaire (gfortran, mpich2) (previously |
| 84 |
|
from old aces-grid cluster, ao + ifort) and update 'run_cpl_test' script. |
| 85 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 86 |
|
- add code for northern and southern boundaries. |
| 87 |
|
- reorder some loops to save some operations and so that drFBar can be scalar |
| 88 |
|
o model/src: |
| 89 |
|
- re-arrange extrapolation calculation in Adams-Bashforth S/R (affects machine |
| 90 |
|
truncation) and add diagnostics for Adams-Bashforth tendency increment. |
| 91 |
|
- update test-exp. AD output: |
| 92 |
|
1D_ocean_ice_column, bottom_ctrl_5x5, lab_sea.noseaicedyn, obcs_ctrl; |
| 93 |
|
and FWD output: exp4 (x3), fizhi-cs-32x32x40, fizhi-cs-aqualev20, |
| 94 |
|
front_relax (x3), global_ocean.90x40x15 (x2), global_ocean.cs32x15 (x5), |
| 95 |
|
global_ocean_ebm, ideal_2D_oce, internal_wave, isomip (x3), lab_sea (x4), |
| 96 |
|
matrix_example, MLAdjust (x5), natl_box (x2), tutorial_advection_in_gyre, |
| 97 |
|
tutorial_global_oce_in_p, tutorial_global_oce_latlon and |
| 98 |
|
tutorial_plume_on_slope. |
| 99 |
|
o pkg/diagnostics/diagstats_calc.F: add special code for TARGET_NEC_SX |
| 100 |
|
that vectorises. This code uses 3 extra 2D fields, F90 array assignments |
| 101 |
|
and F90 intrinsic routines SUM, MINVAL, MAXVAL, but since TARGET_NEC_SX |
| 102 |
|
does not even come with an F77 compiler anymore, this should not be |
| 103 |
|
a limitation |
| 104 |
|
|
| 105 |
|
checkpoint63e (2011/11/06) |
| 106 |
|
o pkg/seaice adjoint of LSR: |
| 107 |
|
- substantially rework STORE dirs. |
| 108 |
|
- add new flag SEAICE_LSR_ADJOINT_ITER and parameter SOLV_MAX_FIXED |
| 109 |
|
this flag will do SOLV_MAX_ITERS but only store SOLV_MAX_FIXED fields |
| 110 |
|
and only perform SOLV_MAX_FIXED adjoint iters. |
| 111 |
|
If flag SEAICE_LSR_ADJOINT_ITER is undef-ined, the store in the iteration |
| 112 |
|
always goes to same record, meaning that the last forward field will be |
| 113 |
|
the one used in the adjoint - an approximation. |
| 114 |
|
- now produces non-zero LSR-related gradients, and acceptable gradients for |
| 115 |
|
An's zonal (x-z) test case (to be checked in) |
| 116 |
|
- lab_sea: produces acceptable gradients for lab_sea with forward/backward LSR |
| 117 |
|
(but these are screwed up by the thermodynamics in the first place); |
| 118 |
|
reduce from 4 to 3 timesteps to avoid t.d. issue as temporary solution; |
| 119 |
|
output_adm.txt also reflects changes to seaice_lsr |
| 120 |
|
- global_ocean.cs32x15: |
| 121 |
|
* the "default" input_ad.seaice has been re-defined to always exclude dynamics |
| 122 |
|
(output_adm.seaice.txt was updated) |
| 123 |
|
* new input_ad.seaice_dynmix tests a forward LSR / backward free-drift |
| 124 |
|
(output_adm.seaice_dynmix.txt) |
| 125 |
|
o test-exp. exp4+stevens: |
| 126 |
|
- switch off pTracers and nonHydrostatic (restart problems with NH); update output |
| 127 |
|
o pkg/seaice (lsr solver): |
| 128 |
|
- put coriolis term into FORCEX,Y (as in seaice_evp.F; previously in rhsU,V only); |
| 129 |
|
update output (change truncation) of FWD test exp lab_sea & global_ocean.cs32x15 |
| 130 |
|
- fix SEAICEuseFREEDRIFT for new OBCS version (ndef OBCS_UVICE_OLD) |
| 131 |
|
- new parameter "LSR_mixIniGuess" allows (if=2,4) to mix free-drift solution |
| 132 |
|
into initial guess for linearised solver; use weight ~ (1/err)^2,4. |
| 133 |
|
- compute (with new S/R) and print initial (+ free-driff sol. if available) |
| 134 |
|
and final residual of linearised system. |
| 135 |
|
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
| 136 |
|
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
| 137 |
|
o pkg/obcs: Stevens BCs (still only for east and west) |
| 138 |
|
- fix Stevens BCs by using intermediate velocities of previous |
| 139 |
|
time step as "baroclinic" contribution rather velocity of one grid cell |
| 140 |
|
inside the boundaries; more consistent but makes the entire treatment |
| 141 |
|
more complicated, requires new pickup files and two new S/Rs: |
| 142 |
|
obcs_copy_uv_n and obcs_save_uv_n |
| 143 |
|
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
| 144 |
|
(undefined by default) |
| 145 |
|
- silently move computation of some grid factors into separate loops to |
| 146 |
|
save some recomputations |
| 147 |
|
- add a hack for non-linear free surface |
| 148 |
|
- add a verification experiment to exp4 that tests this code |
| 149 |
|
o make gluemnc/xplodemnc work with (moron) non-GNU shell tools |
| 150 |
|
|
| 151 |
|
checkpoint63d (2011/10/25) |
| 152 |
|
o pkg/obcs + seaice-dynamics: |
| 153 |
|
- new implementation calls OBCS_APPLY_UVICE (in seaice_dynsolver.F) before |
| 154 |
|
solving for uIce,vIce and prevent SEAICE_LSR or SEAICE_EVP to modify OB |
| 155 |
|
values (consistent with an implicit method). |
| 156 |
|
- add option OBCS_UVICE_OLD (in OBCS_OPTIONS.h, defined by default) to |
| 157 |
|
return to older implementation (same results as before); note that none of |
| 158 |
|
the "experimental" OBCS_SEAICE options are implemented in the new version. |
| 159 |
|
- switch test exp. seaice_obcs to use new version (update output). |
| 160 |
|
o pkg/seaice: |
| 161 |
|
- add few stop (B-grid & CS-exch, B-grid & obcs, AUTODIFF & SEAICE_maskRHS) |
| 162 |
|
- add parenthesis in Water-Ice drag calculations (evp & lsr); |
| 163 |
|
- in seaice_lsr.F, simplify and fix AA3 setting in case sNx or sNy=1; |
| 164 |
|
and fix case SEAICE_waterDrag=0 (but unstable if no or little seaice) |
| 165 |
|
- update output of test exp lab_sea that uses evp or lsr (fwd+ad) |
| 166 |
|
and global_ocean.cs32x15 (icedyn & seaice fwd+ad). |
| 167 |
|
o pkg/layers: |
| 168 |
|
- Include potential density as new coordinate (Thanks to David Munday) |
| 169 |
|
o pkg/dic: |
| 170 |
|
- Remove subroutine CALC_PCO2_APPROX_CO3 from carbon_chem.F and add |
| 171 |
|
carbonate computation/output to CALC_PCO2_APPROX |
| 172 |
|
o pkg/generic_advdiff |
| 173 |
|
- make TAF generate code that vectorizes: |
| 174 |
|
gad_dst3fl_adv_*.F, gad_u3c4_impl_r.F |
| 175 |
|
o model/src: |
| 176 |
|
- improve vectorization also for adjoint code of |
| 177 |
|
solve_tridiagonal and solve_pentadiagonal. As this requires up to |
| 178 |
|
5 new 3D-fields, this code is only turned on for the combination of |
| 179 |
|
ALLOW_AUTODIFF_TAMC and TARGET_NEC_SX. Also remove error message |
| 180 |
|
for singular matrix check (only for TARGET_NEC_SX). |
| 181 |
|
- remove hard-wiring of CPP-flag ALLOW_SOLVERS_KLOOPINSIDE to |
| 182 |
|
ALLOW_AUTODIFF. This flag now needs to be set outside of |
| 183 |
|
solve_tri/pentadiagonal.F |
| 184 |
|
o pkg/exf: |
| 185 |
|
- fix previous modif in exf_readparms.F (revision 1.66: treatment of |
| 186 |
|
optional namelist EXF_NML_OBCS). |
| 187 |
|
- add many debug-print (to trace down where pkg/cal error msg comes from) |
| 188 |
|
o pkg/mom_vecinv/mom_vi_hdissip.F |
| 189 |
|
- rearrange loops so that vectorization is improved and in particular |
| 190 |
|
the adjoint routine vectorizes. The code is a little longer now, but I |
| 191 |
|
think easier to read. |
| 192 |
|
Note: CPP-flag MOM_VI_ORIGINAL_VISCA4 is not tested. |
| 193 |
|
o pkg/seaice: |
| 194 |
|
- allow to specify initial seaice velocity from files (uIceFile,vIceFile) |
| 195 |
|
o pkg/exch2: |
| 196 |
|
- alternative code (without tile x tile matrix) for cumulated (global) sum; |
| 197 |
|
used as default; keep using matrix version in adjustment.cs-32x32x1. |
| 198 |
|
o tools/build_options: |
| 199 |
|
- after merging some MPI and/or multi-threads specific optfiles so that |
| 200 |
|
the modified default optfile support both built (using genmake2 -mpi |
| 201 |
|
for the MPI built, using genmake2 -omp for OpenMP built), |
| 202 |
|
move now obsolete optfiles to tools/build_options/unsupported/ |
| 203 |
|
(add copy of email sent to support list in doc/optfiles_changes.txt) |
| 204 |
|
|
| 205 |
|
checkpoint63c (2011/09/28) |
| 206 |
|
o pkg/ebm: |
| 207 |
|
- fix ebm_zonalmean.F for several procs in Ydir (nPy > 1); update output of |
| 208 |
|
test exp. global_ocean_ebm (affects machine truncation, 12 digits for cg2d) |
| 209 |
|
o pkg/seaice (SItracer pickup) |
| 210 |
|
* Simple code for pickup of SItracer fields (#define ALLOW_SITRACER) |
| 211 |
|
To be done: |
| 212 |
|
- thorough testing of missing fields in S/R seaice_read_pickup |
| 213 |
|
- thorough matching between generic tracers and specific fields used |
| 214 |
|
(e.g. volume-weighted age, area-weighted age, salinity, ...) |
| 215 |
|
o pkg/grdchk: |
| 216 |
|
- all procs calculate and print finite-difference gradient (for testreport) |
| 217 |
|
- change description output used by testreport; |
| 218 |
|
- AD testing: also compare and report Finite-difference gradient; |
| 219 |
|
=> update all output_adm*.txt |
| 220 |
|
o test exp. global_ocean_ebm: |
| 221 |
|
- switch back useRealFreshWaterFlux (no problem anymore with run-off); |
| 222 |
|
and turn on exactConserve; update (fwd) output. |
| 223 |
|
o pkg/seaice (LSR): |
| 224 |
|
- print to STDOUT number of solver iterations at SEAICE_monFreq interval. |
| 225 |
|
- modify solver to deal cleanly with u/v switch at face edges (CS-grid): |
| 226 |
|
* identical results with non-CS topology (but save up to half of EXCH calls) |
| 227 |
|
* no much changes in cs-32 verification tests since no ice at face edges |
| 228 |
|
(differences due to convergence criteria, since nb of iterations changed) |
| 229 |
|
* expect some differences on lat-lon-cap grid. |
| 230 |
|
update FWD results of global_ocean.cs32x15 test exp. (icedyn & seaice) |
| 231 |
|
o pkg/exch2: |
| 232 |
|
- add new CPP option to disable Cumul-Sum matrix (to save storage when using |
| 233 |
|
many tiles); until alternative coding is added, just add a stop. |
| 234 |
|
o pkg/kpp: |
| 235 |
|
- move ptracer/salt correction to KPP diffusivity from calc_3d_diffusivity.F |
| 236 |
|
to S/R KPP_CALC_DIFF_PTR (+ add tracer-index to argument list). |
| 237 |
|
o optfiles: |
| 238 |
|
- merged few MPI specific (*+mpi*) and multi-threads specific (*+mth) optfiles |
| 239 |
|
into corresponding standard one, which now support different build: |
| 240 |
|
(when using "genmake2 -mpi" for MPI built, "genmake2 -omp" for OpenMP built) |
| 241 |
|
- add "darwin_amd64_gfortran" optfile (initially from Constantinos, tested by Gael) |
| 242 |
|
o pkg/obcs (seaice): |
| 243 |
|
- add missing EXCH for uIce,vIce after applying OBCS; |
| 244 |
|
- remove S/R EXF_SWAPFFIELDS_X/Y , disable S/R EXF_SET_OBCS_X/Y by adding |
| 245 |
|
argument = number of levels to S/R EXF_SWAPFFIELDS_XZ/YZ and S/R |
| 246 |
|
EXF_SET_OBCS_XZ/YZ ; update obcs_exf_load.F; |
| 247 |
|
- fix EXF_SET_OBCS_XZ/YZ for multi-threaded (assuming loaded arrays are shared) |
| 248 |
|
- verification exp. seaice_obcs: split domain in 2 tiles ; add SIZE.h_mpi |
| 249 |
|
and eedata.mth for MPI and mutlti-threaded testing. |
| 250 |
|
o pkg/flt: |
| 251 |
|
- make FLT EXCH working with multi-threads (and MPI + multi-threads); |
| 252 |
|
- use buffer for floats IO (trajectories & profiles); size set in FLT_SIZE.h; |
| 253 |
|
- fix pickup and trajectories + profiles output with multi-threads; |
| 254 |
|
- add parameter to select group of fields to write along trajectory and |
| 255 |
|
profile (default unchanged); |
| 256 |
|
- only call PORT_RAND* function when flt_noise <> 0; |
| 257 |
|
- add multi-threaded test for verification exp. flt_example. |
| 258 |
|
o eesupp/src: |
| 259 |
|
- fix S/R ALL_PROC_DIE for MPI+multi-threads. |
| 260 |
|
- USE_OMP_THREADING: check that number of threads (from eedata) matches |
| 261 |
|
actual number (from env.var. setting). |
| 262 |
o pkg/ebm: |
o pkg/ebm: |
| 263 |
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
| 264 |
- add multi-threaded test for verification exp. global_ocean_ebm |
- add multi-threaded test for verification exp. global_ocean_ebm |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch