| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o tools/genmake2: |
| 8 |
|
- add "-DHAVE_NETCDF" to the DEFINES list when NetCDF is available ; |
| 9 |
|
refine usePROFILES switching off (only when NetCDF is not available). |
| 10 |
|
o verification (atmospheric set-up): |
| 11 |
|
- change eosType='IDEALGAS' to eosType='IDEALG' to match variable declaration |
| 12 |
|
o pkg/profiles : refine profiles and files handling. |
| 13 |
|
o model/src and pkg/ecco : introduce run-time switch usePROFILES. |
| 14 |
|
o model/src/the_main_loop.F, forward_step.F and pkg/exf/EXF_OPTIONS.h : |
| 15 |
|
- changes to use model/src/the_main_loop.F rather than the ecco version |
| 16 |
|
in ecco type adjoint runs. |
| 17 |
|
o model/src: |
| 18 |
|
- move computation of recip of grid distance & area from INI_MASKS_ETC to INI_GRID |
| 19 |
|
- move setting of h0Fac[C,W,S] from INI_LINEAR_PHISURF to INI_MASKS_ETC |
| 20 |
|
- update_masks_etc.F: rename SMOOTH*_R4,R8 function to the corresponding type (RS,RL) |
| 21 |
|
o model/src: |
| 22 |
|
- fix S/R UPDATE_CG2D for ALLOW_DEPTH_CONTROL case (was empty before); |
| 23 |
|
update output of test experiment bottom_ctrl_5x5. |
| 24 |
|
o pkg/generic_advdiff: |
| 25 |
|
- implement vertical bi-harmonic diffusion (for now, only for T & S and |
| 26 |
|
only explicitly). |
| 27 |
|
o verification/bottom_ctrl_5x5/ |
| 28 |
|
update reference output (results changed quite some time ago, |
| 29 |
|
not sure when; but new reference results look ok in terms of grdchk) |
| 30 |
|
o verification/1D_ocean_ice_column/ |
| 31 |
|
For verification purposes, the exact adjoint rather than an approx. |
| 32 |
|
should be used (e.g., to comare against F.D. or TLM). |
| 33 |
|
removed autodiff_inadmode*_ad.F routines in code_ad/ |
| 34 |
|
Update results/ accordingly. |
| 35 |
|
o pkg/cal: |
| 36 |
|
- change cal_getdate.F so that output date is function of input time only |
| 37 |
|
(less ambiguous, not mixed up with input iteration number). |
| 38 |
|
- fix calendarDumps for non-zero phase-lag (S/R CAL_TIME2DUMP). |
| 39 |
|
o pkg/diagnostics: |
| 40 |
|
- implement calendarDumps also for stats-diags |
| 41 |
|
- implement calendarDumps also for snap-shot output (negative freq) |
| 42 |
|
- for now, ignores calendarDumps if non-zero phase-lag. |
| 43 |
|
|
| 44 |
|
checkpoint63n (2012/06/04) |
| 45 |
|
o model/src: |
| 46 |
|
- recompute rSurfW & S to ensure consistent column thickness (needed for rStar) |
| 47 |
|
between Sum_k(hFac*drF) and rSurf-rLow, for now only when using pkg/shelfice; |
| 48 |
|
- use h0FacC, W & S to compute hFac_surfC, W & S in calc_surf_dr.F (more |
| 49 |
|
similar to calc_r_star.F); update results of experiment internal_wave and |
| 50 |
|
tutorial_global_oce_in_p (affected @ truncation level). |
| 51 |
|
o pkg/shelfice: |
| 52 |
|
- add parameterisation of advective-diffusive flux into the ice shelf |
| 53 |
|
according to Holland and Jenkins (1999), eq.22-33, as suggested by Jan De Ryd |
| 54 |
|
- simply eps3/3a computation |
| 55 |
|
o eesupp: |
| 56 |
|
- add new CPP option (DISCONNECTED_TILES) to disconnect tiles (no exchange |
| 57 |
|
between tiles, just fill-in edges assuming locally periodic subdomain) and |
| 58 |
|
add corresponding exchange subroutines (EXCH0); |
| 59 |
|
- new CG-solver version (_EX0) for disconnected-tiles special case. |
| 60 |
|
o model/src (CG-solvers): |
| 61 |
|
- modify Single-Reduction version (CG2D_SR) in case cg2dMaxIters is reached |
| 62 |
|
(similar final residual output and max-Iter number as with standard version); |
| 63 |
|
- allows to store and use lowest-residual solution (standard & _SR versions); |
| 64 |
|
- cleaning up (remove old, commented out code, LETS_MAKE_JAM ...). |
| 65 |
|
- by default, also compile CG2D_SR version (define ALLOW_SRCG in CPP_OPTIONS.h) |
| 66 |
|
o eesup/src: |
| 67 |
|
- global_vec_sum.F cleaning: add a BARRIER ; update comments ; remove ndef |
| 68 |
|
ALWAYS_USE_MPI (no longer needed after fixing usingMPI settings - March 2012) |
| 69 |
|
o pkg/salt_plume added to lab_sea/input_ad.noseaicedyn |
| 70 |
|
|
| 71 |
|
checkpoint63m (2012/04/27) |
| 72 |
|
o pkg/shelfice: |
| 73 |
|
- account for partical cells in surface level below ice-shelf for hydrostatic |
| 74 |
|
pressure calculion (set uniformFreeSurfLev to F); update isomip experiments. |
| 75 |
|
o ad test experiments: |
| 76 |
|
- update and rename to "ad_optfile.local" local AD-optfile specific to a |
| 77 |
|
particular adjoint verification experiment (in verification/*/code_ad/) |
| 78 |
|
o pkg/seaice & pkg/exf: |
| 79 |
|
- Part two of ECCO-CLIVAR code merges. |
| 80 |
|
Completes merge of seaice area relax. code. |
| 81 |
|
Requires unified CPP option EXF_ALLOW_SEAICE_RELAX |
| 82 |
|
to be set in EXF_OPTIONS.h since this pkg controls its I/O |
| 83 |
|
(and avoids second CPP option in SEAICE_OPTIONS.h) |
| 84 |
|
- change default value of costIceStart & costIceEnd to a valid date. |
| 85 |
|
- add snowPrecip to HSNOW in seaice_growth |
| 86 |
|
o pkg/ptracers: |
| 87 |
|
- move ptracers summary and setup check into separated S/R ; add a check for |
| 88 |
|
valid PTRACERS_Iter0 value (error+stop or just warning). |
| 89 |
|
o pkg/cal (+ pkg/ecco): |
| 90 |
|
- avoid calling a S/R with 2 times the same arg (FWD: unless both are only used |
| 91 |
|
as input; and for AD, unless both are not differentiable (e.g., k index)). |
| 92 |
|
o model/src: |
| 93 |
|
- define internal flag "uniformFreeSurfLev" (=T when free-surface level-index |
| 94 |
|
is everywhere k=1) to speed-up some calculations (by pass kSurf reference); |
| 95 |
|
temporary set to usingZCoords value (to be changed to F when using shelfice). |
| 96 |
|
- hydrostatic pressure: implement partial cell near the surface also for |
| 97 |
|
Z-coordinates (for the case where uniformFreeSurfLev=F); replace test on |
| 98 |
|
usingZCoords with test on uniformFreeSurfLev where needed (in NonHyd code). |
| 99 |
|
o pkg/ctrl/ctrl_init.F: |
| 100 |
|
- add a formal parameter to s/r ctrl_init_rec to print |
| 101 |
|
xx_$(ctrl_valiable)_file for easier debugging |
| 102 |
|
- move call of cal_* routines into the if-block where they are really |
| 103 |
|
needed so that xx_$(ctrl_variable)_period can be 0 or -12 without having |
| 104 |
|
to specify a startdate |
| 105 |
|
o pkg/seaice: |
| 106 |
|
- update comments in SEAICE_OPTIONS.h (+ similar update of lab_sea/code and |
| 107 |
|
global_ocean.cs32x15/code versions). |
| 108 |
|
- turn on seaice Multi-category (in data.seaice, SEAICE_multDim=7) for |
| 109 |
|
verification experiment global_ocean.cs32x15.seaice and update results. |
| 110 |
|
o pkg/exf: |
| 111 |
|
- new S/R EXF_GETFIELD_START to return starting-time of a forcing field |
| 112 |
|
(according to useExfYearlyFields). |
| 113 |
|
o pkg/cal: |
| 114 |
|
- move calendar setting & summary (previously in cal_readparams.F) into new |
| 115 |
|
S/R CAL_INIT_FIXED to be called later in the initialisation process, once |
| 116 |
|
length of the simulation is set (after SET_PARMS call); This is an attempt |
| 117 |
|
to fix Pb when, e.g.: pkg/longstep, modifies the length of the run. |
| 118 |
|
- For safety: keep a record of pkg/cal parameter settings status |
| 119 |
|
to allow to STOP if one pkg/cal S/R is called too early. |
| 120 |
|
- add a stop in all basic pkg/cal subroutines if called before setting is done. |
| 121 |
|
- modify cal_getdate.F: stop when nothing was returned; |
| 122 |
|
if called with myIter=-1, simply retrun modelBaseDate (1,2 = startDate_1,_2); |
| 123 |
|
this allows to remove "cal.h" from seaice_read_parms.F & init_mnc_vars.F. |
| 124 |
|
|
| 125 |
|
checkpoint63l (2012/04/04) |
| 126 |
|
o pkg/bbl: |
| 127 |
|
- fix call to FIND_RHO_2D in bbl_calc_rho.F (case multi-tiles per proc); |
| 128 |
|
update global_with_exf output.yearly.txt file. |
| 129 |
|
o pkg/cal: |
| 130 |
|
- start to clean-up cal_set.F ; fix for the case where baseTime is non-zero. |
| 131 |
|
- remove 2 unsused and very short (1 line only) functions ; |
| 132 |
|
- remove unsused subroutines from AD-Diff list. |
| 133 |
|
o model/src: |
| 134 |
|
- start to implement clean wait to stop in initialization S/R (config_check.F, |
| 135 |
|
packages_check.F, ini_parms.F and pkg/obcs/obcs_check.F + pkg/mypackage) |
| 136 |
|
o folowing PRINT_MESSAGE changes: |
| 137 |
|
- remove reminder multiple print to the same file (STDOUT) when multi-threads. |
| 138 |
|
o pkg/bbl: |
| 139 |
|
- modification so it can work with z* |
| 140 |
|
- replace deltaT with dTtracerLev(k) for asynchronous time stepping |
| 141 |
|
- global_with_exf/input.yearly verification; changes output.yearly.txt |
| 142 |
|
o eesupp/src: |
| 143 |
|
- PRINT_MESSAGE: use OpenMP critical instruction (similar to PRINT_ERROR); |
| 144 |
|
writing to unit 0 (if unit=errorMessageUnit) extended to the case myThid=1 |
| 145 |
|
- CHECK_THREADS: specific code if using OpenMP threading: improve checking of |
| 146 |
|
# of threads across processors (e.g., different env OMP_NUM_THREADS setting) |
| 147 |
|
- improve special preliminary call to EESET_PARMS (if eedata is read 2 times). |
| 148 |
|
- when using MPI, always set usingMPI=T ; set default accordingly and stop |
| 149 |
|
if not consistent. |
| 150 |
|
- ALL_PROC_DIE: add a BARRIER after MPI_FINALIZE call ; skip this when thread |
| 151 |
|
argument is zero (in case called within single-thread section). |
| 152 |
|
o pkg/fizhi: |
| 153 |
|
clean-up turbulence cold-start switch: decided in fizhi_init_vars.F, stored |
| 154 |
|
in common bloc (fizhi_coms.h) and then passed as argument up to S/R TURBIO. |
| 155 |
|
o pkg/exch2: |
| 156 |
|
- add argument "updateCorners" to S/R exch2_get_uv_bounds (enable to |
| 157 |
|
activate EXCH_IGNORE_CORNERS in vector EXCH S/R). |
| 158 |
|
- switch 1rst EXCH call to IGNORE_CORNERS (instead of UPDATE_CORNERS) |
| 159 |
|
but keep the 2nd with UPDATE_CORNERS: this prevents overwriting good data |
| 160 |
|
with bad ones coming from a not-yet-updated halo. |
| 161 |
|
This should fix the problem when sNx <> sNy and GCD(sNx,sNy) < 2*Olx. |
| 162 |
|
o pkg/frazil: |
| 163 |
|
move FrzForcT diag from frazil_diagnostics_state.F to frazil_calc_rhs.F |
| 164 |
|
http://mitgcm.org/pipermail/mitgcm-devel/2012-March/005384.html |
| 165 |
|
o model/src/config_check.F: add a check for OLx>sNx/OLy>sNy |
| 166 |
|
o verification/lab_sea |
| 167 |
|
* #undef SEAICE_EXCLUDE_FOR_EXACT_AD_TESTING |
| 168 |
|
* #define ALLOW_SST_CONTROL & ALLOW_SST_CONTROL |
| 169 |
|
* nTimeSteps 3 -> 4 |
| 170 |
|
* changed reference output accordingly |
| 171 |
|
o pkg/ctrl: |
| 172 |
|
* fix ctrl_get_gen for xx_sst, xx_sss |
| 173 |
|
o pkg/fizhi: |
| 174 |
|
- fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F |
| 175 |
|
update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d) |
| 176 |
|
- by default, use new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE); |
| 177 |
|
fix few out-of-bounds indices in referencing vars (initialise igrd to 1); |
| 178 |
|
clean-up fizhi_turb.F (remove unused & uninitialised qdiaglsm array). |
| 179 |
|
o pkg/gmredi: |
| 180 |
|
- add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp |
| 181 |
|
o pkg/fizhi: |
| 182 |
|
- fix few initialisation and multi-tile Pb: aqualev & gridalt now pass the |
| 183 |
|
(old)aces open64 tuv test. |
| 184 |
|
o pkg/icefront: fix bug and reorder loop in icefront_init_varia.F |
| 185 |
|
o pkg/mom_vecinv: |
| 186 |
|
- fix 1 loop range in mom_vecinv.F to be like all the other loops which |
| 187 |
|
set/update gu,gv/Diss (fix Pb of uninitialised fVerUkp in admom_vecinv |
| 188 |
|
with non-lin free-surf). |
| 189 |
|
o model/src: move k-loop outside of i/j-loops when (re-)computing R_low |
| 190 |
|
in ini/update_masks_etc.F in order to avoid -O3 optimization problems with |
| 191 |
|
some compilers (gfortran 4.6.0 on MacOS) |
| 192 |
|
o momentum: |
| 193 |
|
- separate fVer?(:,:,kUp) & fVer?(:,:,kDown) in argument list of MOM_FLUXFORM |
| 194 |
|
& MOM_VECINV subroutines (to help TAF). This fixes Pb of uninitialised |
| 195 |
|
fVer?(kUp) in admom_fluxform with non-lin free-surf or bottom control. |
| 196 |
|
|
| 197 |
|
checkpoint63k (2012/03/17) |
| 198 |
|
o model/src: |
| 199 |
|
- selectAddFluid (ALLOW_ADDFLUID): add missing term in horizontal momentum |
| 200 |
|
flux-form (mom_fluxform.F) and vertical momentum (calc_gw.F) equations. |
| 201 |
|
- SOLVE_DIAGONAL: switch default to use adjoinable & vectorized version |
| 202 |
|
(#undef SOLVE_DIAGONAL_LOWMEMORY); update output of exp. front_relax.bvp. |
| 203 |
|
o model/src: solve_*diagonal.F |
| 204 |
|
- replace division with multiplication by inverse (similar to original version) |
| 205 |
|
update output of AD exp. global_ocean.90x40x15. |
| 206 |
|
- fix pkg/gmredi/gmredi_calc_psi_bvp.F & pkg/ggl90/ggl90_calc.F |
| 207 |
|
to enable the use of the vectorized & differentiable solve_tridiagonal.F |
| 208 |
|
- test exp. global_ocean.90x40x15/input_ad: switch to advection scheme 20 for |
| 209 |
|
vertical advection (to get solve_tridiagonal tested in AD mode). |
| 210 |
|
o pkg/seaice: ECCO-CLIVAR merge: |
| 211 |
|
1. seaice AREA relaxation |
| 212 |
|
* CPP option: SEAICE_ALLOW_AREA_RELAXATION |
| 213 |
|
* runtime flag: SEAICE_tauAreaObsRelax |
| 214 |
|
2. modified global mean cost imbalance code: CPP option |
| 215 |
|
ALLOW_SSH_GLOBMEAN_COST_CONTRIBUTION |
| 216 |
|
o another iteration on solve_*diagonal.F |
| 217 |
|
Make choices independent of AUTODIFF |
| 218 |
|
Default will be the adjoinable vectorized version. |
| 219 |
|
Alternative choices are: |
| 220 |
|
* non-adjoinable original version with low memory footprint: |
| 221 |
|
#define SOLVE_DIAGONAL_LOWMEMORY |
| 222 |
|
* still adjoinable but does not vectorize (k as inner-most loop): |
| 223 |
|
#define SOLVE_DIAGONAL_KINNER (keeping SOLVE_DIAGONAL_LOWMEMORY undef) |
| 224 |
|
o testreport |
| 225 |
|
- add option to use a home made wrapper around "make" |
| 226 |
|
- remove MITGCM_IEEE env. variable (no longer active) |
| 227 |
|
o pkg/shelfice |
| 228 |
|
- improve computation of friction velocity for velocity dependent |
| 229 |
|
exchange coefficients: include velocities into SHELFICEBoundaryLayer |
| 230 |
|
block to average velocities vertically |
| 231 |
|
- add TAF store directives for SHI_ALLOW_GAMMAFRICT |
| 232 |
|
o Modify diagonal solvers, now three versions (upon request): |
| 233 |
|
#ifndef SOLVE_DIAGONAL_AUTODIFF |
| 234 |
|
1. default version (dating back a while ago) |
| 235 |
|
#else /* def SOLVE_DIAGONAL_AUTODIFF */ |
| 236 |
|
# ifdef SOLVE_DIAGONAL_KINNER |
| 237 |
|
2. adjoinable version with k-innermost loop (G. Forget) |
| 238 |
|
# else |
| 239 |
|
3. adjoinable vectorized version of 2. |
| 240 |
|
# endif |
| 241 |
|
#endif /* SOLVE_DIAGONAL_AUTODIFF */ |
| 242 |
|
All flags are currently set within routines, but could/should be moved to CPP-options. |
| 243 |
|
Array bounds for 1. are as before, for 2.,3. cover the entire domain |
| 244 |
|
(could be changed for 1. too). |
| 245 |
|
o verification/lab_sea (fwd): |
| 246 |
|
- update the 4 fwd lab_sea test experiment: no longer SEAICE_GROWTH_LEGACY, |
| 247 |
|
use 7 categories (except hb87), new solve4temp params (except salt_plume), |
| 248 |
|
constant salinity (=4) or variable salinity (salt_plume) done through |
| 249 |
|
SItracer. |
| 250 |
|
o pkg/seaice: |
| 251 |
|
- rename parameters: SIsalFrac to SEAICE_saltFrac & SIsal0 to SEAICE_salt0; |
| 252 |
|
- remove old parameters ( SEAICE_freeze, SEAICEturbFluxFormula, SEAICE_gamma_t, |
| 253 |
|
SEAICE_gamma_t_frz, SEAICE_availHeatTaper & SEAICE_availHeatFracFrz) |
| 254 |
|
from SEAICE_PARMS.h ; still need to fix seaice_cost_sst.F (broken when |
| 255 |
|
SEAICE_freeze got retired) but already better than previously with |
| 256 |
|
SEAICE_freeze=123456.7 deg.C; |
| 257 |
|
- move setting of facOpenGrow/Melt from SEAICE_INIT_FIXED to SEAICE_READPARMS |
| 258 |
|
(safer multi-threaded setting); always set SEAICEuseEVP; |
| 259 |
|
- setting of ocean-ice turb. flux coeff: moved from SEAICE_CHECK to |
| 260 |
|
SEAICE_READPARMS & SEAICE_INIT_FIXED (this fixes wrong summary report); |
| 261 |
|
stop if multiple specifications for the same coeff; make sure default |
| 262 |
|
SEAICE_mcPheePiston is compatible with drF(1) & deltaT. |
| 263 |
|
o pkg/obcs: |
| 264 |
|
- allow to switch to upwind 1rst order advection scheme for the advective |
| 265 |
|
flux computation at the open-boundary; disabled for adjoint built. |
| 266 |
|
o pkg/ptracers: |
| 267 |
|
- rename PTRACERS_RESTART.h -> PTRACERS_START.h |
| 268 |
|
- rename ptracers_fields_blocking_exchanges.F -> ptracers_fields_blocking_exch.F |
| 269 |
|
- add parameter to decide when to start a tracer; use internal flag to |
| 270 |
|
know which tracer to step-forward; switch this internal flag at the top |
| 271 |
|
of forward_step.F (new S/R PTRACERS_SWITCH_ONOFF); for now, not enabled |
| 272 |
|
for adjoint built. |
| 273 |
|
o pkg/seaice: |
| 274 |
|
- add SEAICE_SIZE.h anywhere in the code where SEAICE.h is included ; |
| 275 |
|
- move MULTDIM declaration and setting from SEAICE.h to SEAICE_SIZE.h ; |
| 276 |
|
- keep experiment offline_exf_seaice truly single category (set MULTDIM=1). |
| 277 |
|
o pkg/ecco: |
| 278 |
|
- fix writing of output file DiagnosCost_ClimSalt/Theta |
| 279 |
|
and DiagnosCost_DriftSalt/Theta (if multi-tiles per proc). |
| 280 |
|
o pkg/seaice: |
| 281 |
|
- add missing initialisation of COR_ICE array in dynsolver.F |
| 282 |
|
- merging SEAICE_MULTICATEGORY define and undef cases. Now the same code is |
| 283 |
|
compiled either way, and is tested in all exps (multidim was only tested |
| 284 |
|
in lab_sea ad before). |
| 285 |
|
- cosmetic change to prepare for future addition of ITD. no change to results. |
| 286 |
|
no defaults change. |
| 287 |
|
- added run time param SEAICE_multDim (7 for SEAICE_MULTICATEGORY, 1 otherwise). |
| 288 |
|
- by lack of adequate verification experiments, I further used custom versions |
| 289 |
|
of global_ocean.cs32x15 to test multicat or not, with pickup or not. All |
| 290 |
|
should be correct. |
| 291 |
|
- avoid recomputations in ad. |
| 292 |
|
o array initialisation in adjoint mode: |
| 293 |
|
1) pkg/mom_common/mom_calc_ke.F: |
| 294 |
|
add full array initialisation of KE inside mom_calc_ke.F (ALLOW_AUTODIFF_TAMC): |
| 295 |
|
The S/R which calls MOM_CALC_KE initialises KE but in some recomputation |
| 296 |
|
part this initialisation is gone, resulting in Floating Point Exception |
| 297 |
|
(caught by open64 compiler with debug option). |
| 298 |
|
2) model/src/convective_weights.F |
| 299 |
|
set output convectCount over the full array range (instead of doing |
| 300 |
|
an update): this fix a similar issue when called within recomputation (adjoint) |
| 301 |
|
which could by-pass the initialisation (normally done in the caller S/R). |
| 302 |
|
o pkg/seaice: |
| 303 |
|
- final version of turbulent flux params, as agreed at MIT ice meet: |
| 304 |
|
SEAICE_mcPheePiston (default is ~ 0.000875) |
| 305 |
|
SEAICE_mcPheeTaper (default is 0.) |
| 306 |
|
SEAICE_frazilFrac (defualt is 1.) |
| 307 |
|
SEAICE_mcPheeStepFunc (default is false) |
| 308 |
|
- changes results at trunction error level |
| 309 |
|
- ifdef SEAICE_EXTERNAL_FLUXES, disallow SEAICE_waterAlbedo |
| 310 |
|
o added pkg/frazil: |
| 311 |
|
- see frazil_description.tex for details |
| 312 |
|
- verification experiment is global_with_exf/input.yearly; changes output.yearly.txt |
| 313 |
|
o pkg/shelfice/shelfice_thermodynamics.F |
| 314 |
|
- fix exponents for velocity dependent exchange coefficients: change |
| 315 |
|
from 2/3(=0) to 0.66666666666666667 |
| 316 |
|
- move computation of velocity dependent exchange coefficients into |
| 317 |
|
separate loop, so that it applies to both thermodynamics |
| 318 |
|
- move some divisions by constants out of loops |
| 319 |
|
|
| 320 |
|
checkpoint63j (2012/02/16) |
| 321 |
|
o pkg/seaice: |
| 322 |
|
- overhaul of seaice_summary.F after feb 2012 clean-up of seaice_growth.F etc. |
| 323 |
|
- SItracer: added run time params, and allow coupling to ocn salinity. |
| 324 |
|
o pkg/seaice: remove (almost) all divisions by constants within loops |
| 325 |
|
in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d |
| 326 |
|
results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only |
| 327 |
|
those, caused by 1/QI -> recip_QI) -> update output.seaice.txt, |
| 328 |
|
output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt |
| 329 |
|
o pkg/seaice : |
| 330 |
|
- simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula |
| 331 |
|
= 1 or 2, using newly added run time parameter SEAICE_availHeatTaper. |
| 332 |
|
- fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148. |
| 333 |
|
- add permanent SItflux diag that corresponds to TFLUX but includes |
| 334 |
|
ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget. |
| 335 |
|
- allow activation/testing of a fix for suspected missing term in |
| 336 |
|
ocn-ice heat budget (to be confirmed). To test this, you want to |
| 337 |
|
undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param |
| 338 |
|
SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic. |
| 339 |
|
- no change in results, fwd or ad. |
| 340 |
|
o global_ocean.cs32x15/results: 3 changes following from the pkg/seaice commit below: |
| 341 |
|
- switch to variable freezing point. |
| 342 |
|
Results change : cg2d -> 1 digits; ad -> 3-6-6 digits. |
| 343 |
|
- bug fix : the sublimation term that was missing is now activated. |
| 344 |
|
Results change : cg2d -> 2 digits; ad -> 8-6-6 digits. |
| 345 |
|
- bug fix : flooding sign term for SIsal0.NE.0. |
| 346 |
|
Result change : cg2d -> 8 digits; ad -> 11-12-9 digits. |
| 347 |
|
o pkg/seaice: |
| 348 |
|
- unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT |
| 349 |
|
is now the default, and the old default constant freezing point is recovered |
| 350 |
|
with SEAICE_tempFrz0 = -1.96, |
| 351 |
|
SEAICE_dTempFrz_dS = 0., |
| 352 |
|
- retire SEAICE_freeze (= the old way of specifycing the constant freezing point) |
| 353 |
|
- remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there. |
| 354 |
|
- bug fix (thanks to M. Losch) : the sublimation term that was missing is now |
| 355 |
|
activated. To reproduce old results with this bug define SEAICE_DISABLE_SUBLIM. |
| 356 |
|
- bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211) |
| 357 |
|
was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail). |
| 358 |
|
- bug fix (thanks to O. Jahn) : area loss for melting got messed up in |
| 359 |
|
seaice_growth r149 for legacy branch (no results change). |
| 360 |
|
- introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code |
| 361 |
|
from I. Fenty). |
| 362 |
|
- results did not change except for global_ocean.cs32x15, mostly due to the |
| 363 |
|
switch to variable freezing point (see above item for detail). |
| 364 |
|
o pkg/thsice: |
| 365 |
|
- fix and simplify interface to salt_plume pkg ; diagnose directly amount of |
| 366 |
|
seawater freezing in thsice_calc_thickn (not used). |
| 367 |
|
o pkg/seaice: turbulent flux term specification via run time params. |
| 368 |
|
- replace CPP switches with run time switches to facilitate testing |
| 369 |
|
- retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, |
| 370 |
|
GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR |
| 371 |
|
- added runtime parameter : SEAICEturbFluxFormula |
| 372 |
|
- move Mcphee constants to SEAICE_PARAMS.h |
| 373 |
|
- seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula; |
| 374 |
|
SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); |
| 375 |
|
remove seaice_summary call (moved to seaice_init_fixed) |
| 376 |
|
- seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on |
| 377 |
|
SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms) |
| 378 |
|
- seaice_summary.F : add missing report of read turbulent flux term set up |
| 379 |
|
and SITRACER. |
| 380 |
|
- seaice_check.F : check range; inform and stop if retired CPPs are used |
| 381 |
|
(incl. SEAICE_AGE). |
| 382 |
|
- seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without |
| 383 |
|
CPP switch, same computation as before for the different options. |
| 384 |
|
- change results at the truncation level. |
| 385 |
|
o pkg/seaice: |
| 386 |
|
- remove un-used parameters LAD & MAX_TICE ; add new run-time parameters: |
| 387 |
|
useMaykutSatVapPoly (default=F), postSolvTempIter (default=2) and |
| 388 |
|
SEAICE_wetAlbTemp (default=-1e-3). Remove option SEAICE_SOLVE4TEMP_LEGACY. |
| 389 |
|
- update verification/*/input*/data.seaice: |
| 390 |
|
to reproduce previous results with former #defined SEAICE_SOLVE4TEMP_LEGACY |
| 391 |
|
code, set useMaykutSatVapPoly=T & postSolvTempIter=0 ; |
| 392 |
|
and to reproduce previous results with former non-SOLVE4TEMP_LEGACY code, |
| 393 |
|
set SEAICE_wetAlbTemp=0 & SEAICE_snowThick=0. |
| 394 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY): |
| 395 |
|
- remove LEGACY code for solving for tsurf (A1,A2,A3) but maintain the same |
| 396 |
|
algorithm (same choice: useMaykutPolySatVap=T, postSolvTempIter=0); |
| 397 |
|
difference in results only due to machine truncation. |
| 398 |
|
- remove MAX_TICE (tsurf is always =< TMELT anyway); keep MIN_TICE if using |
| 399 |
|
MaykutPolySatVap; keep MIN_LWDOWN. |
| 400 |
|
- adapt SEAICE_MODIFY_GROWTH_ADJ code (untested) to non-legacy formulation. |
| 401 |
|
- update output of verification exp. lab_sea (4 fwd: 11 cg2d digits except hb87, |
| 402 |
|
+ 3 AD: 6 digits except evp) and offline_exf_seaice.seaice (12 digits). |
| 403 |
|
o pkg/salt_plume: |
| 404 |
|
- isolate saltPlumeFlux array exch into a specific S/R called from |
| 405 |
|
do_oceanic_phys.F |
| 406 |
|
- add interface to pkg/salt_plume (filling of saltPlumeFlux) in pkg/thsice. |
| 407 |
|
o verification: |
| 408 |
|
- move untested set-up to MITgcm_contrib/verification_other. |
| 409 |
|
o pkg/seaice: |
| 410 |
|
- retire old way of SEAICE_AGE. Now replaced with ALLOW_SITRACER. |
| 411 |
|
o pkg/seaice: |
| 412 |
|
- seaice_solve4temp.F (keeping results unchanged): |
| 413 |
|
* add 2 future run-time params to select which saturation vapor pressure |
| 414 |
|
formula is used and how post-iteration fluxes are set. |
| 415 |
|
Temporary set these 2 params according to option SOLVE4TEMP_LEGACY; |
| 416 |
|
* New piece of code (not used) to update surf. atmos. heat flux F_ia using |
| 417 |
|
the linearized expression to stay consistent with tsurf finding. |
| 418 |
|
- seaice_freedrift.F avoid floating exception in sqrt(y) since y=sqrt(x*x)-x |
| 419 |
|
can be < 0. |
| 420 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY undef): |
| 421 |
|
- remove from F_ia (and from it's derivative dFiDTs1) the contribution of |
| 422 |
|
conductive heat flux F_c , and add it explicitly when updating tsurf as |
| 423 |
|
solution of: Fc = Fia + d/dT(Fia - Fc) *delta.tsurf |
| 424 |
|
so that now F_ia has a consistent meaning through the entire routine. |
| 425 |
|
This causes differences at truncation level: update output of fwd exp. |
| 426 |
|
global_ocean.cs32x15.seaice. |
| 427 |
|
o pkg/seaice: |
| 428 |
|
- lots of editing/cleaning in seaice_solve4temp.F + better documentation |
| 429 |
|
of arrays, sign/direction of fluxes; no effect on results. |
| 430 |
|
- replace hard coded 273.16 (=previous value of celsius2K) by celsius2K |
| 431 |
|
in seaice_budget_ocean.F & seaice_solve4temp.F (SOLVE4TEMP_LEGACY part); |
| 432 |
|
note: this should have been done before changing celsius2K default. |
| 433 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 434 |
|
exp. input*/data : lab_sea (AD), offline_exf_seaice (fwd+AD) & seaice_obcs |
| 435 |
|
- replace hard coded seawater freezing temp in seaice_solve4temp.F (part |
| 436 |
|
SOLVE4TEMP_LEGACY) of 271.20 (=previous value of celsius2K + default |
| 437 |
|
value of SEAICE_freeze) by celsius2K+SEAICE_freeze so that seawater |
| 438 |
|
freezing temp is consistent with value in seaice_growth.F ; this causes |
| 439 |
|
differences at machine truncation level: update lab_sea AD output (3/4). |
| 440 |
|
o pkg/seaice: |
| 441 |
|
- mask (in exf_init_fixed.F) atemp,aqh,evap,precip,runoff,lwflx,areamask |
| 442 |
|
and climsst/sss even when using seaice (to prevent calculation that might |
| 443 |
|
use SST on land); does not affect any verification exp. |
| 444 |
|
- apply mask to taux,tauy (in seaice_get_dynforcing.F); update output |
| 445 |
|
of lab_sea.fd & lab_sea.hb87 and global_ocean.cs32x15.seaice_dynmix. |
| 446 |
|
o pkg/seaice/seaice_growth.F: add mask to avoid non-zero ice thickness |
| 447 |
|
over land (non-legacy code) |
| 448 |
|
o vectorize salt_plume package: |
| 449 |
|
- add extra code to salt_plume_frac and salt_plume_tendency_apply_s |
| 450 |
|
- this code computes plumebk everywhere (also over land), thus requires |
| 451 |
|
code to avoid divisions by zero and catch the case of kLev=Nr. |
| 452 |
|
- efficiency of salt_plume_frac is still sub-optimal |
| 453 |
|
o tools (genmake2): |
| 454 |
|
- fix makefile NAME specification (option: -makefile NAME) by adding |
| 455 |
|
"-f $MAKEFILE" in few places where it was missing including makedepend |
| 456 |
|
command (contribution from Paul). |
| 457 |
|
|
| 458 |
|
checkpoint63i (2012/01/24) |
| 459 |
|
o model/src: |
| 460 |
|
- add factorized versions of some EOS code to find_rho.F, |
| 461 |
|
define USE_FACTORIZED_EOS to turn it on (default for TARGET_NEC_SX) |
| 462 |
|
o model/src: |
| 463 |
|
- add celsius2K to namelist PARM01; remove unused recip_rhoNil from PARAMS.h; |
| 464 |
|
- change default celsius2K from 273.16 to 273.15 |
| 465 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 466 |
|
exp. input*/data : aim.5l_cs, 1D_ocean_ice_column, lab_sea (fwd), |
| 467 |
|
global_ocean.cs32x15(seaice) & cpl_aim+ocn(input_atm). |
| 468 |
|
o model/src: add a little initialisation trick to find_rho.F and find_alpha.F |
| 469 |
|
to make TAF generate vectorizable code |
| 470 |
|
o pkg/seaice/seaice_evp.F: add code (copied from CICE) that avoids underflows. |
| 471 |
|
Turn on by defining SEAICE_EVP_ELIMINATE_UNDERFLOWS. Most compilers |
| 472 |
|
have flags that do this more efficiently. |
| 473 |
|
o pkg/diagnostics/diagstats_calc.F |
| 474 |
|
- for TARGET_NEC_SX fix the treatment of the scaling factor tmpFac=scaleFact |
| 475 |
|
o pkg/obcs (with exch2): |
| 476 |
|
- derive OB indices in overlap region from OB-InsideMask (in obcs_init_fixed.F) |
| 477 |
|
and remove code (in obcs_readparms.F) which was based on EXCH of indices |
| 478 |
|
(through buffer) and did not account for exch2 (e.g., CS-grid) topology. |
| 479 |
|
o pkg/exf and seaice exp: |
| 480 |
|
- change offline_exf_seaice.seaicetd test exp. to use default DIFF1 value (=0) |
| 481 |
|
so that switching off area & heff advection flags does not affect results. |
| 482 |
|
- change default EXF_LWDOWN_WITH_EMISSIVITY to #define in EXF_OPTIONS.h |
| 483 |
|
- keep exp. seaice_obcs & 1D_ocean_ice_column(ad) unchanged (using #undef |
| 484 |
|
EXF_LWDOWN_WITH_EMISSIVITY) and, using pkg/exf default emissivities, update |
| 485 |
|
results of verification experiments: 1D_ocean_ice_column(fwd), |
| 486 |
|
global_ocean.cs32x15.seaice(fwd+ad) & seaice_dynmix(ad), lab_sea (all 8) |
| 487 |
|
and offline_exf_seaice (all 4). |
| 488 |
|
o pkg/seaice: |
| 489 |
|
- remove array YNEG, RIVER, TMIX (replaced by local var) from common block; |
| 490 |
|
remove also areaNm1 & hEffNm1 when SEAICE_GROWTH_LEGACY is undef. |
| 491 |
|
- fix bug: areaNm1 & hEffNm1 are needed in seaice_growth (SEAICE_GROWTH_LEGACY) |
| 492 |
|
but were not filled when resp. SEAICEadvArea=F & SEAICEadvHeff=F and |
| 493 |
|
not multi-dim advection; |
| 494 |
|
- fix seaice_growth.F to compile with both SEAICE_GROWTH_LEGACY and |
| 495 |
|
SHORTWAVE_HEATING #undef. |
| 496 |
|
o optim: make Makefile more robust (?) |
| 497 |
|
o pkg/obcs: |
| 498 |
|
* fix treatment of obcs_read_pickup for TAF |
| 499 |
|
o pkg/shelfice: |
| 500 |
|
* add missing initialisation of num_shifwflx |
| 501 |
|
* new adjoint verification exp. for isomip |
| 502 |
|
* change Prandtl and Schmidt numbers from generic formulations |
| 503 |
|
(in terms of model diffus. and visc.) to separate runtime |
| 504 |
|
parameters, with Holland and Jenkins (1999) default values. |
| 505 |
|
o pkg/exf (interpolation): |
| 506 |
|
- extended input field (2 rows) near the N & S poles: |
| 507 |
|
* fill in with the symetric value (when even Nb of data in longitude) |
| 508 |
|
* add average value at the poles only for scalar quantities ; for vector |
| 509 |
|
component interpolation, skip the averaging and keep duplicated values, |
| 510 |
|
unless the 2 components have same location (uvInterp=T) in which case |
| 511 |
|
interpolate the 2 components together using S/R EXF_INTERP_UV. |
| 512 |
|
- new S/R EXF_INTERP_UV to interpolate the 2 components of a vector field |
| 513 |
|
together: this allows to account properly for local orientation when |
| 514 |
|
averaging at N & S pole. |
| 515 |
|
- add CPP option EXF_USE_OLD_INTERP_POLE to recover old results regarding |
| 516 |
|
exf-interpolation near N & S poles. Undef by default. |
| 517 |
|
- add debug check/print on 1rst iter if debugLevel >=2. |
| 518 |
|
o pkg/exf: |
| 519 |
|
- change masking flags definition (no longer "parameter"), put them in |
| 520 |
|
common block and set them in S/R EXF_INIT_FIXED. |
| 521 |
|
- change recognized masking flag from s,u,v to c,w,s since the mask |
| 522 |
|
to use (maskC,W,S) depends on position on model grid and has little to |
| 523 |
|
do with scalar/vector difference; fix masking if using P-coordinates. |
| 524 |
|
- fix masking of wind-stress (was wrong if interpolated or read on A-grid) |
| 525 |
|
and update results of exp. global_with_exf (x2). |
| 526 |
|
- fix setting of zenith-angle table when SHORTWAVE_HEATING is undef. |
| 527 |
|
o pkg/obcs |
| 528 |
|
- S/R obcs_calc_stevens: fix a small bug (gammat -> gammas where appropriate) |
| 529 |
|
o pkg/exf (interpolation): |
| 530 |
|
- assume periodicity in X only if input field cover full longitude range. |
| 531 |
|
- improve search for lat. index (supposed to be faster, in ~log2(ny) steps, |
| 532 |
|
and should vectorise). |
| 533 |
|
- fix input lat of the 2 added row (in case we provide N.pole data). |
| 534 |
|
|
| 535 |
|
checkpoint63h (2011/12/30) |
| 536 |
|
o pkg/seaice: |
| 537 |
|
- change declaration of UVM from _RL to _RS in order to get B-grid |
| 538 |
|
uIce,vIce monitor when _RS = real*4 |
| 539 |
|
o pkg/offline: |
| 540 |
|
- new S/R OFFLINE_RESET_PARMS for resetting main-model params (switch off flags); |
| 541 |
|
- compute vertical velocity if not read from file (switch on exactConserv |
| 542 |
|
& staggerTimeStep); |
| 543 |
|
- fix output of ptracer monitor iter & time for default PTRACERS_monitorFreq. |
| 544 |
|
o verification: |
| 545 |
|
- update grid-files (in tutorial_held_suarez_cs/input and fizhi-cs-32x32x40/input) |
| 546 |
|
with grid-angle generated using "utils/matlab/cs_grid/cubeCalcAngle.m": |
| 547 |
|
fix Pb in yG definition @ 2 missing corners (previously yG was averaged); |
| 548 |
|
- update output of exp. global_ocean.cs32x15.viscA4 after changing |
| 549 |
|
grid-file angles (used here for coriolis-3d); |
| 550 |
|
- remove (or gzip) few files not needed to run fizhi-cs experiments. |
| 551 |
|
o pkg/exf (vector interpolation): |
| 552 |
|
- rotate vector component toward local grid-axis orientation using grid-angles |
| 553 |
|
(stored in GRID.h) instead of locally computed rotation angle; keep old code |
| 554 |
|
available with exf option EXF_USE_OLD_VEC_ROTATION (undef by default). |
| 555 |
|
o pkg/seaice: |
| 556 |
|
- allow to compile with exf options ALLOW_ATM_TEMP or ALLOW_DOWNWARD_RADIATION |
| 557 |
|
undefined. Fix and remove the stop when ALLOW_RUNOFF is undefined. |
| 558 |
|
o pkg/PKG_OPTIONS.h files: |
| 559 |
|
- move #include "CPP_OPTIONS.h" just after #include "PACKAGES_CONFIG.h", |
| 560 |
|
outside of the #ifdef ALLOW_THISPKG / #endif block. |
| 561 |
|
- update verification/*/code/PKG_OPTIONS.h files. |
| 562 |
|
o add a verification experiment (offline_exf_seaice/input.seaice) that test |
| 563 |
|
the B-grid LSOR solver |
| 564 |
|
o pkg/seaice: sort out emissivity and long wave radiation step 2: |
| 565 |
|
- add emissivity for snow and ice as new run-time parameters |
| 566 |
|
(unfortunately) that default to the corresponding exf values; this |
| 567 |
|
changes results in most verification experiments so that for backward |
| 568 |
|
compatibility these parameter have to be set explicitly to inconsistent |
| 569 |
|
values (ugly); |
| 570 |
|
- the exf-flag EXF_LWDOWN_WITH_EMISSIVITY then gets rid off the hard-wired |
| 571 |
|
emissivities of 0.97 associated with lwdownloc in S/R seaice_solve4temp |
| 572 |
|
until we agree how to handle this bug properly |
| 573 |
|
o pkg/exf (interpolation): |
| 574 |
|
- add a set of run-time param ({inputfield}_interpMethod), one for |
| 575 |
|
each interpolated input field, to select the interpolation method |
| 576 |
|
with a value of zero switching off the interpolation; |
| 577 |
|
- print interpolation parameters to standard output; |
| 578 |
|
- refine exf_check.F accordingly ; stop if USE_NO_INTERP_RUNOFF is defined |
| 579 |
|
(to use instead runoff_interpMethod=0 in data.exf). |
| 580 |
|
- simplify default setting of interpolation parameters (for all fields, |
| 581 |
|
set position to match model grid cell-center position, leading to trivial |
| 582 |
|
interpolation in case of regular Lat-Lon grid) and fix for the case of |
| 583 |
|
non-uniform delY. |
| 584 |
|
o pkg/exf/exf_radiation.F: add the factor ocean_emissivity to lwdown, for |
| 585 |
|
within #ifdef EXF_LWDOWN_WITH_EMISSIVITY/#endif. Unless ocean_emissivity=1. |
| 586 |
|
this factor is absolutely required, because the lw exitance (= out-going |
| 587 |
|
long wave radiation) is emissivity*stefanBoltzmann*T^4 + rho*lwdown, |
| 588 |
|
where the reflectivity rho = 1-emissivity for conservation reasons. Once |
| 589 |
|
this is established, we can remove the CPP-Flag (if we want to). |
| 590 |
|
o pkg/seaice: |
| 591 |
|
- qualify a stop statement in S/R seaice_check: EXF_READ_EVAP and |
| 592 |
|
ALLOW_BULKFORMULAE are only required if SEAICE_EXTERNAL_FLUXES is defined |
| 593 |
|
- sort out emissivity and long wave radiation, step 1: make SEAICE_emissivity |
| 594 |
|
what the name implies (and not emissivity*BoltzmannConstant), this means |
| 595 |
|
the old default value of 5.5e-8 now means |
| 596 |
|
5.5e-8/5.670e-8 = 0.97001763668430343479 as ocean_emissivity in |
| 597 |
|
S/R exf_readparms |
| 598 |
|
- FV-discretization of the B-grid LSOR solver, turn on with |
| 599 |
|
SEAICE_LSRBNEW. This new solver also involves a slight re-organization |
| 600 |
|
of the calling routine dynsolver, so that B and C-grid code look a |
| 601 |
|
little more alike. |
| 602 |
|
- fix index bugs in ostres.F (B-grid code) |
| 603 |
|
o pkg/seaice/seaice_ocean_budget.F: change (unused) code to make it look better |
| 604 |
|
o pkg/seaice/seaice_readparms.F: make ocean_emissivity*stefanBoltzmann the |
| 605 |
|
default for SEAICE_emissivity, if useEXF; requires setting a wrong |
| 606 |
|
parameter value in global_ocean.cs32x15/input.seaice/data.seaice for |
| 607 |
|
backward compatiblity |
| 608 |
|
o model/src: use sigmaR in calc_ivdc |
| 609 |
|
|
| 610 |
|
checkpoint63g (2011/12/16) |
| 611 |
|
o pkg/seaice/seaice_growth.F: |
| 612 |
|
fix heat conservation of the coupled ocean-seaice system. |
| 613 |
|
when SEAICE_HEAT_CONSERV_FIX is defined, the mismatch of |
| 614 |
|
solid vs liquid water treatment is resolved via QNET. |
| 615 |
|
o pkg/seaice/seaice_growth.F: |
| 616 |
|
add missing term for sublimation in saltFlux, which was breaking conservation. |
| 617 |
|
o pkg/seaice/seaice_model.F: |
| 618 |
|
Remove this patholigical case treatment in evolution branch, |
| 619 |
|
where it is un-necessary and breaks conservation. |
| 620 |
|
Update global_ocean.cs32x15/results accordingly for |
| 621 |
|
output.seaice.txt output_adm.seaice.txt and output_adm.seaice_dynmix.txt |
| 622 |
|
o model/src: |
| 623 |
|
useRealFreshWaterFlux: remove masking of EmPmP (using maskInC) in |
| 624 |
|
external_forcing_surf.F and apply mask directly in S/R SOLVE_FOR_PRESSURE. |
| 625 |
|
o pkg/obcs: |
| 626 |
|
modify Stevens boundary conditions so that S/R obcs_calc_stevens computes |
| 627 |
|
tendency for temperature and salinity that is then applied to update |
| 628 |
|
theta and salt in S/R obcs_apply_ts; this requires proper masking of all |
| 629 |
|
horizontal advection and diffusion contributions on the boundary (in |
| 630 |
|
S/Rs gad_advection, gad_calc_rhs, gmredi_rtransport, gmredi_calc_diff), and |
| 631 |
|
removing the mask in S/R timestep_tracer. The advantage of this approach is |
| 632 |
|
that the updated tracer values include contributions from the surface |
| 633 |
|
forcing and vertical diffusion. |
| 634 |
|
This modification changes exp4.stevens because of vertical diffusion. |
| 635 |
|
o model/src: |
| 636 |
|
change non-curvilinear grid setting to also work with exch2 + blank tiles: |
| 637 |
|
- move delX,delY to new header file (SET_GRID.h) and adjust length to 1rst |
| 638 |
|
face dimensions. |
| 639 |
|
- new S/R INI_LOCAL_GRID to define model tile-local grid (using same units |
| 640 |
|
as delX,delY) and called from S/R INI_CARTESIAN_GRID, INI_CYLINDER_GRID |
| 641 |
|
and INI_SPHERICAL_POLAR_GRID. |
| 642 |
|
change test-experiment global_ocean.90x40x15: |
| 643 |
|
- split the domain in many more tiles (9x4 tiles of 10x10 each); |
| 644 |
|
- switch to exch2 and remove 1 blank-tile (but only for MPI test). |
| 645 |
|
- update results of both test (std & dwnslp). |
| 646 |
|
o pkg/diagnostics/diagstat_calc.F: fix problem with non-initialised halos in |
| 647 |
|
tmp-fields for TARGET_NEC_SX at the cost of extra loops and less vectorisation |
| 648 |
|
o model/src: |
| 649 |
|
- take sigma-coords related code out of update_etah.F into new S/R UPDATE_ETAWS |
| 650 |
|
and fix initialisation when using sigma-coords. |
| 651 |
|
o model/src: |
| 652 |
|
- improve Gael's changes from Jan 14, 2011 "addition of an 'update' of hfacc etc. |
| 653 |
|
to their current value at the beginning of forward_step.F": add a new run-time |
| 654 |
|
switch "doResetHFactors" (default=false) and use it to do (or not) the resetting. |
| 655 |
|
- set doResetHFactors=T in the following test exp: |
| 656 |
|
global_ocean.90x40x15/input (rStar) & input.dwnslp (linFS), |
| 657 |
|
global_ocean.cs32x15/input.seaice (rStar), hs94.cs-32x32x5/input.impIGW (linFS) |
| 658 |
|
and tutorial_global_oce_in_p (nonLinFS in p) |
| 659 |
|
o pkg/ecco |
| 660 |
|
- added IES cost term |
| 661 |
|
o verification/advect_xz |
| 662 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 663 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 664 |
|
- add note (check_conserve_TS.txt) and matlab script to check global |
| 665 |
|
conservation of T & S with NonLin-FreeSurf and Adams-Bashforth. |
| 666 |
|
o pkg/rbcs: |
| 667 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 668 |
|
o pkg/obcs (Stevens BCs): |
| 669 |
|
- fix various problems in the phase speed computations of the Stevens |
| 670 |
|
boundary conditions: |
| 671 |
|
- sign error for western and southern boundaries, |
| 672 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 673 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 674 |
|
from difference between previous (n) time level and the one before (n-1); |
| 675 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 676 |
|
files. |
| 677 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 678 |
|
- set default phase velocity to cflMer/Zon |
| 679 |
|
- update verification experiment exp4.stevens |
| 680 |
|
o pkg/generic_advdiff (implicit_r): |
| 681 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 682 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 683 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 684 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 685 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 686 |
|
solver S/R ; |
| 687 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 688 |
|
when using implicit vert. advection; |
| 689 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 690 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 691 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 692 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 693 |
|
o pkg/diagnostics: |
| 694 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 695 |
|
|
| 696 |
|
checkpoint63f (2011/11/30) |
| 697 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 698 |
|
- join some loops to reduce number of if-statements |
| 699 |
|
- fix a bug in code for northern and southern boundaries. |
| 700 |
|
o pkg/seaice/seaice_init_varia.F |
| 701 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 702 |
|
caused zero ice-velocities for the B-grid code |
| 703 |
|
o pkg/seaice/seaice_init_fixed.F |
| 704 |
|
- fix a bug in the initialisation of the second metric terms |
| 705 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 706 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 707 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 708 |
|
= .true. (default) |
| 709 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 710 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 711 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 712 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 713 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 714 |
|
o model/src: |
| 715 |
|
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 716 |
|
- call INTEGR_CONTINUITY directly from forward_step.F |
| 717 |
|
(previously called from momentum_correction_step.F) |
| 718 |
|
- call UPDATE_ETAH from integr_continuity.F and update initialise_varia.F, |
| 719 |
|
forward_step.F and pkg/ecco/the_main_loop.F |
| 720 |
|
o model/src/do_oceanic_phys.F: |
| 721 |
|
- reset addMass to zero only if useICEFRONT ; |
| 722 |
|
- separated k-loop for rhoInSitu calculation ; |
| 723 |
|
- add 2 diagnostics for wVel*delta^k(Rho) at constant pressure (= WdRHO_P) |
| 724 |
|
and at constant T,S (= WdRHOdP); |
| 725 |
|
NOTE: change diagnostics WRHOMASS : this is now simply the Vertical transport |
| 726 |
|
of In-Situ Density (Anomaly) (=wVel*rho^bar-k) (previously was Vertical |
| 727 |
|
transport of locally-referenced potential density); |
| 728 |
|
to recover old diag: (WRHOMASS)_old = (WRHOMASS)_new -1/2 * (WdRHOdP) |
| 729 |
|
o gluemnc: |
| 730 |
|
- replace ncrcat with ncks when adding variables to *.glob.nc |
| 731 |
|
- change the way variables without record dimensions are handled so that |
| 732 |
|
files that have variables with and without record variables can be glued: |
| 733 |
|
add a record dimension with a new unique name to be able to differentiate |
| 734 |
|
between variable with and without a-prior record dimensions. Remove |
| 735 |
|
this record dimension before adding the variable to the *.glob.nc file. |
| 736 |
|
This procedure automatically works also for grid.*.nc files that do not |
| 737 |
|
have any record dimension. |
| 738 |
|
o verification/cpl_aim+ocn: |
| 739 |
|
- generate new reference output on baudelaire (gfortran, mpich2) (previously |
| 740 |
|
from old aces-grid cluster, ao + ifort) and update 'run_cpl_test' script. |
| 741 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 742 |
|
- add code for northern and southern boundaries. |
| 743 |
|
- reorder some loops to save some operations and so that drFBar can be scalar |
| 744 |
|
o model/src: |
| 745 |
|
- re-arrange extrapolation calculation in Adams-Bashforth S/R (affects machine |
| 746 |
|
truncation) and add diagnostics for Adams-Bashforth tendency increment. |
| 747 |
|
- update test-exp. AD output: |
| 748 |
|
1D_ocean_ice_column, bottom_ctrl_5x5, lab_sea.noseaicedyn, obcs_ctrl; |
| 749 |
|
and FWD output: exp4 (x3), fizhi-cs-32x32x40, fizhi-cs-aqualev20, |
| 750 |
|
front_relax (x3), global_ocean.90x40x15 (x2), global_ocean.cs32x15 (x5), |
| 751 |
|
global_ocean_ebm, ideal_2D_oce, internal_wave, isomip (x3), lab_sea (x4), |
| 752 |
|
matrix_example, MLAdjust (x5), natl_box (x2), tutorial_advection_in_gyre, |
| 753 |
|
tutorial_global_oce_in_p, tutorial_global_oce_latlon and |
| 754 |
|
tutorial_plume_on_slope. |
| 755 |
|
o pkg/diagnostics/diagstats_calc.F: add special code for TARGET_NEC_SX |
| 756 |
|
that vectorises. This code uses 3 extra 2D fields, F90 array assignments |
| 757 |
|
and F90 intrinsic routines SUM, MINVAL, MAXVAL, but since TARGET_NEC_SX |
| 758 |
|
does not even come with an F77 compiler anymore, this should not be |
| 759 |
|
a limitation |
| 760 |
|
|
| 761 |
|
checkpoint63e (2011/11/06) |
| 762 |
|
o pkg/seaice adjoint of LSR: |
| 763 |
|
- substantially rework STORE dirs. |
| 764 |
|
- add new flag SEAICE_LSR_ADJOINT_ITER and parameter SOLV_MAX_FIXED |
| 765 |
|
this flag will do SOLV_MAX_ITERS but only store SOLV_MAX_FIXED fields |
| 766 |
|
and only perform SOLV_MAX_FIXED adjoint iters. |
| 767 |
|
If flag SEAICE_LSR_ADJOINT_ITER is undef-ined, the store in the iteration |
| 768 |
|
always goes to same record, meaning that the last forward field will be |
| 769 |
|
the one used in the adjoint - an approximation. |
| 770 |
|
- now produces non-zero LSR-related gradients, and acceptable gradients for |
| 771 |
|
An's zonal (x-z) test case (to be checked in) |
| 772 |
|
- lab_sea: produces acceptable gradients for lab_sea with forward/backward LSR |
| 773 |
|
(but these are screwed up by the thermodynamics in the first place); |
| 774 |
|
reduce from 4 to 3 timesteps to avoid t.d. issue as temporary solution; |
| 775 |
|
output_adm.txt also reflects changes to seaice_lsr |
| 776 |
|
- global_ocean.cs32x15: |
| 777 |
|
* the "default" input_ad.seaice has been re-defined to always exclude dynamics |
| 778 |
|
(output_adm.seaice.txt was updated) |
| 779 |
|
* new input_ad.seaice_dynmix tests a forward LSR / backward free-drift |
| 780 |
|
(output_adm.seaice_dynmix.txt) |
| 781 |
|
o test-exp. exp4+stevens: |
| 782 |
|
- switch off pTracers and nonHydrostatic (restart problems with NH); update output |
| 783 |
|
o pkg/seaice (lsr solver): |
| 784 |
|
- put coriolis term into FORCEX,Y (as in seaice_evp.F; previously in rhsU,V only); |
| 785 |
|
update output (change truncation) of FWD test exp lab_sea & global_ocean.cs32x15 |
| 786 |
|
- fix SEAICEuseFREEDRIFT for new OBCS version (ndef OBCS_UVICE_OLD) |
| 787 |
|
- new parameter "LSR_mixIniGuess" allows (if=2,4) to mix free-drift solution |
| 788 |
|
into initial guess for linearised solver; use weight ~ (1/err)^2,4. |
| 789 |
|
- compute (with new S/R) and print initial (+ free-driff sol. if available) |
| 790 |
|
and final residual of linearised system. |
| 791 |
|
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
| 792 |
|
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
| 793 |
|
o pkg/obcs: Stevens BCs (still only for east and west) |
| 794 |
|
- fix Stevens BCs by using intermediate velocities of previous |
| 795 |
|
time step as "baroclinic" contribution rather velocity of one grid cell |
| 796 |
|
inside the boundaries; more consistent but makes the entire treatment |
| 797 |
|
more complicated, requires new pickup files and two new S/Rs: |
| 798 |
|
obcs_copy_uv_n and obcs_save_uv_n |
| 799 |
|
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
| 800 |
|
(undefined by default) |
| 801 |
|
- silently move computation of some grid factors into separate loops to |
| 802 |
|
save some recomputations |
| 803 |
|
- add a hack for non-linear free surface |
| 804 |
|
- add a verification experiment to exp4 that tests this code |
| 805 |
|
o make gluemnc/xplodemnc work with (moron) non-GNU shell tools |
| 806 |
|
|
| 807 |
|
checkpoint63d (2011/10/25) |
| 808 |
|
o pkg/obcs + seaice-dynamics: |
| 809 |
|
- new implementation calls OBCS_APPLY_UVICE (in seaice_dynsolver.F) before |
| 810 |
|
solving for uIce,vIce and prevent SEAICE_LSR or SEAICE_EVP to modify OB |
| 811 |
|
values (consistent with an implicit method). |
| 812 |
|
- add option OBCS_UVICE_OLD (in OBCS_OPTIONS.h, defined by default) to |
| 813 |
|
return to older implementation (same results as before); note that none of |
| 814 |
|
the "experimental" OBCS_SEAICE options are implemented in the new version. |
| 815 |
|
- switch test exp. seaice_obcs to use new version (update output). |
| 816 |
|
o pkg/seaice: |
| 817 |
|
- add few stop (B-grid & CS-exch, B-grid & obcs, AUTODIFF & SEAICE_maskRHS) |
| 818 |
|
- add parenthesis in Water-Ice drag calculations (evp & lsr); |
| 819 |
|
- in seaice_lsr.F, simplify and fix AA3 setting in case sNx or sNy=1; |
| 820 |
|
and fix case SEAICE_waterDrag=0 (but unstable if no or little seaice) |
| 821 |
|
- update output of test exp lab_sea that uses evp or lsr (fwd+ad) |
| 822 |
|
and global_ocean.cs32x15 (icedyn & seaice fwd+ad). |
| 823 |
|
o pkg/layers: |
| 824 |
|
- Include potential density as new coordinate (Thanks to David Munday) |
| 825 |
|
o pkg/dic: |
| 826 |
|
- Remove subroutine CALC_PCO2_APPROX_CO3 from carbon_chem.F and add |
| 827 |
|
carbonate computation/output to CALC_PCO2_APPROX |
| 828 |
|
o pkg/generic_advdiff |
| 829 |
|
- make TAF generate code that vectorizes: |
| 830 |
|
gad_dst3fl_adv_*.F, gad_u3c4_impl_r.F |
| 831 |
|
o model/src: |
| 832 |
|
- improve vectorization also for adjoint code of |
| 833 |
|
solve_tridiagonal and solve_pentadiagonal. As this requires up to |
| 834 |
|
5 new 3D-fields, this code is only turned on for the combination of |
| 835 |
|
ALLOW_AUTODIFF_TAMC and TARGET_NEC_SX. Also remove error message |
| 836 |
|
for singular matrix check (only for TARGET_NEC_SX). |
| 837 |
|
- remove hard-wiring of CPP-flag ALLOW_SOLVERS_KLOOPINSIDE to |
| 838 |
|
ALLOW_AUTODIFF. This flag now needs to be set outside of |
| 839 |
|
solve_tri/pentadiagonal.F |
| 840 |
|
o pkg/exf: |
| 841 |
|
- fix previous modif in exf_readparms.F (revision 1.66: treatment of |
| 842 |
|
optional namelist EXF_NML_OBCS). |
| 843 |
|
- add many debug-print (to trace down where pkg/cal error msg comes from) |
| 844 |
|
o pkg/mom_vecinv/mom_vi_hdissip.F |
| 845 |
|
- rearrange loops so that vectorization is improved and in particular |
| 846 |
|
the adjoint routine vectorizes. The code is a little longer now, but I |
| 847 |
|
think easier to read. |
| 848 |
|
Note: CPP-flag MOM_VI_ORIGINAL_VISCA4 is not tested. |
| 849 |
|
o pkg/seaice: |
| 850 |
|
- allow to specify initial seaice velocity from files (uIceFile,vIceFile) |
| 851 |
|
o pkg/exch2: |
| 852 |
|
- alternative code (without tile x tile matrix) for cumulated (global) sum; |
| 853 |
|
used as default; keep using matrix version in adjustment.cs-32x32x1. |
| 854 |
|
o tools/build_options: |
| 855 |
|
- after merging some MPI and/or multi-threads specific optfiles so that |
| 856 |
|
the modified default optfile support both built (using genmake2 -mpi |
| 857 |
|
for the MPI built, using genmake2 -omp for OpenMP built), |
| 858 |
|
move now obsolete optfiles to tools/build_options/unsupported/ |
| 859 |
|
(add copy of email sent to support list in doc/optfiles_changes.txt) |
| 860 |
|
|
| 861 |
|
checkpoint63c (2011/09/28) |
| 862 |
|
o pkg/ebm: |
| 863 |
|
- fix ebm_zonalmean.F for several procs in Ydir (nPy > 1); update output of |
| 864 |
|
test exp. global_ocean_ebm (affects machine truncation, 12 digits for cg2d) |
| 865 |
|
o pkg/seaice (SItracer pickup) |
| 866 |
|
* Simple code for pickup of SItracer fields (#define ALLOW_SITRACER) |
| 867 |
|
To be done: |
| 868 |
|
- thorough testing of missing fields in S/R seaice_read_pickup |
| 869 |
|
- thorough matching between generic tracers and specific fields used |
| 870 |
|
(e.g. volume-weighted age, area-weighted age, salinity, ...) |
| 871 |
|
o pkg/grdchk: |
| 872 |
|
- all procs calculate and print finite-difference gradient (for testreport) |
| 873 |
|
- change description output used by testreport; |
| 874 |
|
- AD testing: also compare and report Finite-difference gradient; |
| 875 |
|
=> update all output_adm*.txt |
| 876 |
|
o test exp. global_ocean_ebm: |
| 877 |
|
- switch back useRealFreshWaterFlux (no problem anymore with run-off); |
| 878 |
|
and turn on exactConserve; update (fwd) output. |
| 879 |
|
o pkg/seaice (LSR): |
| 880 |
|
- print to STDOUT number of solver iterations at SEAICE_monFreq interval. |
| 881 |
|
- modify solver to deal cleanly with u/v switch at face edges (CS-grid): |
| 882 |
|
* identical results with non-CS topology (but save up to half of EXCH calls) |
| 883 |
|
* no much changes in cs-32 verification tests since no ice at face edges |
| 884 |
|
(differences due to convergence criteria, since nb of iterations changed) |
| 885 |
|
* expect some differences on lat-lon-cap grid. |
| 886 |
|
update FWD results of global_ocean.cs32x15 test exp. (icedyn & seaice) |
| 887 |
|
o pkg/exch2: |
| 888 |
|
- add new CPP option to disable Cumul-Sum matrix (to save storage when using |
| 889 |
|
many tiles); until alternative coding is added, just add a stop. |
| 890 |
|
o pkg/kpp: |
| 891 |
|
- move ptracer/salt correction to KPP diffusivity from calc_3d_diffusivity.F |
| 892 |
|
to S/R KPP_CALC_DIFF_PTR (+ add tracer-index to argument list). |
| 893 |
|
o optfiles: |
| 894 |
|
- merged few MPI specific (*+mpi*) and multi-threads specific (*+mth) optfiles |
| 895 |
|
into corresponding standard one, which now support different build: |
| 896 |
|
(when using "genmake2 -mpi" for MPI built, "genmake2 -omp" for OpenMP built) |
| 897 |
|
- add "darwin_amd64_gfortran" optfile (initially from Constantinos, tested by Gael) |
| 898 |
|
o pkg/obcs (seaice): |
| 899 |
|
- add missing EXCH for uIce,vIce after applying OBCS; |
| 900 |
|
- remove S/R EXF_SWAPFFIELDS_X/Y , disable S/R EXF_SET_OBCS_X/Y by adding |
| 901 |
|
argument = number of levels to S/R EXF_SWAPFFIELDS_XZ/YZ and S/R |
| 902 |
|
EXF_SET_OBCS_XZ/YZ ; update obcs_exf_load.F; |
| 903 |
|
- fix EXF_SET_OBCS_XZ/YZ for multi-threaded (assuming loaded arrays are shared) |
| 904 |
|
- verification exp. seaice_obcs: split domain in 2 tiles ; add SIZE.h_mpi |
| 905 |
|
and eedata.mth for MPI and mutlti-threaded testing. |
| 906 |
|
o pkg/flt: |
| 907 |
|
- make FLT EXCH working with multi-threads (and MPI + multi-threads); |
| 908 |
|
- use buffer for floats IO (trajectories & profiles); size set in FLT_SIZE.h; |
| 909 |
|
- fix pickup and trajectories + profiles output with multi-threads; |
| 910 |
|
- add parameter to select group of fields to write along trajectory and |
| 911 |
|
profile (default unchanged); |
| 912 |
|
- only call PORT_RAND* function when flt_noise <> 0; |
| 913 |
|
- add multi-threaded test for verification exp. flt_example. |
| 914 |
|
o eesupp/src: |
| 915 |
|
- fix S/R ALL_PROC_DIE for MPI+multi-threads. |
| 916 |
|
- USE_OMP_THREADING: check that number of threads (from eedata) matches |
| 917 |
|
actual number (from env.var. setting). |
| 918 |
|
o pkg/ebm: |
| 919 |
|
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
| 920 |
|
- add multi-threaded test for verification exp. global_ocean_ebm |
| 921 |
|
|
| 922 |
|
checkpoint63b (2011/08/29) |
| 923 |
|
o pkg/ebm: |
| 924 |
|
- fix sign of runoff; |
| 925 |
|
- update directly forcing fields (Qnet,EmPmR) to use standard |
| 926 |
|
external_forcing_surf.F (remove ebm_forcing_surf.F); |
| 927 |
|
- avoid loading forcing fields a 2nd time (1rst time from ini_forcing.F); |
| 928 |
|
- set either tauThetaClimRelax (in data) or tauThetaZonRelax (in data.ebm) |
| 929 |
|
and apply relaxation towards corresponding SST field (2-D map or ZonAver). |
| 930 |
|
- update global_ocean_ebm parameters file data and update output (fwd+ad). |
| 931 |
|
o verification/matrix_example: |
| 932 |
|
- split domain in 8 tiles (2x4); add SIZE.h_mpi and eedata.mth for |
| 933 |
|
MPI and mutlti-threaded testing. |
| 934 |
|
o pkg/matrix: |
| 935 |
|
- change name of S/R MATRIX_INIT to S/R MATRIX_INIT_VARIA ; |
| 936 |
|
- fix for multi-tiles (add bi,bj indices to exp/impMatrixCounter); |
| 937 |
|
- fix for multi-threaded (remove DATA statement); |
| 938 |
|
- use standard DIFFERENT_MULTIPLE function; |
| 939 |
|
- add MATRIX_OPTIONS.h |
| 940 |
|
o verification/matrix_example: |
| 941 |
|
To allow to split the domain in several tiles, change the domain size |
| 942 |
|
from 31x31 to 32x32 by adding 1 row (on Southern side) + 1 column (on |
| 943 |
|
Western side) of land points. |
| 944 |
|
o (*_)write_pickup: |
| 945 |
|
- fix few bugs in mypackage_read/write_pickup.F |
| 946 |
|
- in MDS_WR_METAFILES calls, replace "myTime" by a local copy into |
| 947 |
|
array of length 1 (was caught by compiler syntax-check). |
| 948 |
|
o pkg/diagnostics (velocity potential solver): |
| 949 |
|
- fix initialisation of main diagonal matrix (for overlap values) |
| 950 |
|
o tools/build_options: |
| 951 |
|
- towards single optfile for MPI and non-MPI built: merge few +mpi optfile |
| 952 |
|
into previously non MPI one (linux_am64 pgf77,open64,pathf90,ifort11) |
| 953 |
|
- linux_amd64_gfortran: merge +mpi_generic version into standard optfile: |
| 954 |
|
* move IEEE flags to DEVEL section; take IEEE flags from +mpi_generic ; |
| 955 |
|
* FAST case: for now, keep -O3 with ini_masks_etc.F in NOOPTFILES list; |
| 956 |
|
and use "-devel" testreport option for standard testing on baudelaire. |
| 957 |
|
o pkg/grdchk: |
| 958 |
|
- Assume that all gradient-check position are within the same tile |
| 959 |
|
corresponding to global indices (iGloTile,jGloTile) and that |
| 960 |
|
positions (i,j indices or nbeg) are local to this tile; |
| 961 |
|
- set tile local-indices and proc. number according to tile global-indices; |
| 962 |
|
- remove grdchkwhichproc from namelist (retired param); |
| 963 |
|
- send adjoint gradient to all procs so that all procs print it to STDOUT; |
| 964 |
|
- switch on MPI test for global_ocean.90x40x15 AD test experiment. |
| 965 |
|
o adding package bbl (Bottom Boundary Layer) |
| 966 |
|
description in MITgcm/pkg/bbl/bbl_description.tex |
| 967 |
|
example/test experiment in MITgcm_contrib/bbl |
| 968 |
|
o adjoint verifications |
| 969 |
|
- changed 5 experiments to multi-tiles |
| 970 |
|
* global_ocean.90x40x15 |
| 971 |
|
* obcs_ctrl |
| 972 |
|
* offline_exf_seaice |
| 973 |
|
* tutorial_dic_adjoffline |
| 974 |
|
* tutorial_tracer_adjsens |
| 975 |
|
changed reference output for those that crossed tile boundaries |
| 976 |
|
(changed choices of gradient check positions) |
| 977 |
|
- with same tiling, switch on MPI test for the last 4 (add SIZE.h_mpi) |
| 978 |
|
- temporary bug fix in grdchk_loc.F for obcs |
| 979 |
|
o genmake2 & testreport |
| 980 |
|
- add target "obj" (just for OBJFILES files) to Makefile; |
| 981 |
|
- add option to specify FEXTRAFLAGS on command line. |
| 982 |
|
o pkg/mypackage: |
| 983 |
|
- remove bi,bj arguments from argument list of S/R MYPACKAGE_CALC_RHS |
| 984 |
|
|
| 985 |
|
checkpoint63a (2011/08/02) |
| 986 |
|
o pkg/diagnostics (velocity potential): |
| 987 |
|
- fix velocity-potential calculation when using OBCS: balance net inflow |
| 988 |
|
at each level (new S/R OBCS_DIAG_BALANCE). |
| 989 |
|
- fix some of the problems with OBCS in stream-function calculation. |
| 990 |
|
o pkg/exf/exf_readparms.F |
| 991 |
|
- make treatment of optional namelists (EXF_NML_04, EXF_NML_SGRUNOFF, |
| 992 |
|
EXF_NML_OBCS) more consistent, so that you need not have these lists |
| 993 |
|
in data.exf when they are not used. |
| 994 |
|
o optim/optim_readdata.F: |
| 995 |
|
- add some output about obcs variables that might help debugging |
| 996 |
|
- add a check about nvarlength |
| 997 |
|
o pkg/ctrl: once again, fix computation of endrec in s/r ctrl_init_rec |
| 998 |
|
o pkg/diagnostics (velocity potential): |
| 999 |
|
- fix mask for OBCS (still problems in stream-function with OBCS); |
| 1000 |
|
- add specific parameter (default = main code CG2D params) for solver; |
| 1001 |
|
- in case of poor convergence, use solution corresponding to lowest residual. |
| 1002 |
|
o pkg/seaice/seaice_growth.F: small changes that permit vectorizable |
| 1003 |
|
adjoint code. In general statements like tmpscal=fld(i,j) are problematic |
| 1004 |
|
and should be avoided where possible. |
| 1005 |
|
o model/src (rStar): |
| 1006 |
|
- include r* effect on reference-state (PhiRef) in totPhiHyd |
| 1007 |
|
(so that it's really the potential anomaly at the cell center); |
| 1008 |
|
affect solution only if z* with full pressure in EOS. |
| 1009 |
|
- test-exp global_ocean.90x40x15: reduce viscA4 (was not stable) and |
| 1010 |
|
update output (because of z* in totPhiHyd and viscA4 changes); |
| 1011 |
|
- keep the previous diagnostics as "PHIHYDcR" (closer to potential anomaly |
| 1012 |
|
@ constant r) until interpolation at constant r is implemented. |
| 1013 |
|
o pkg/diagnostics |
| 1014 |
|
- fix RCENTER diagnostics in case cell center is not at interface middle |
| 1015 |
|
o add code for TEOS-10 (www.teos-10.org, McDougall et al. 2011). Use |
| 1016 |
|
this eos with eosType = 'TEOS10', in data (PARM01). This eos implies |
| 1017 |
|
that THETA and SALT are "conservative temperature" and "absolute |
| 1018 |
|
salinity" |
| 1019 |
|
o pkg/ctrl |
| 1020 |
|
- fix computation of endrec in s/r ctrl_init_rec |
| 1021 |
|
- ctrl_pack/unpack_*: remove unused variables and some obsolete code |
| 1022 |
|
o pkg/seaice/seaice_growth.F |
| 1023 |
|
- fix recomputation with FENTY_AREA_EXPANSION_CONTRACTION code, |
| 1024 |
|
remove then obsolete STORE directives |
| 1025 |
|
- fix STORE directives for tice and tices, so that only the |
| 1026 |
|
appropriate part of the fields are stored (and not the entire |
| 1027 |
|
field); update global_ocean.cs32x15.seaice AD output. |
| 1028 |
|
- cosmetic changes: adjust CPP flags and indentation for better |
| 1029 |
|
legibilty |
| 1030 |
|
o pkg/autodiff: add mnc-output of adBottomDragFld (code contributed by |
| 1031 |
|
Chris Wilson) |
| 1032 |
|
o pkg/gmredi: |
| 1033 |
|
Add Sub-Meso Eddies parameterisation from Baylor (for now, disabled with TAF), |
| 1034 |
|
and test it in verification exp. "front_relax.bvp" (update output.bvp.txt) |
| 1035 |
|
|
| 1036 |
|
checkpoint63 (2011/07/11) |
| 1037 |
|
o pkg/exch2: |
| 1038 |
|
- rename+move: nTiles in W2_EXCH2_PARAMS.h --> exch2_nTiles in W2_EXCH2_TOPOLOGY.h |
| 1039 |
|
- exch2 version of Cumul-Sum routine: S/R W2_SET_MAP_CUMSUM set up the |
| 1040 |
|
(2*nTiles)x(nTiles) Cumul-Sum matrix and Master Proc collects all tiles X,Y |
| 1041 |
|
increments, calculates Cumul-Sum @ tile origin and sends results to each tile. |
| 1042 |
|
o pkg/diagnostics: |
| 1043 |
|
- deal with pairs of post-processed diags which are computed together; in |
| 1044 |
|
particular, re-order list of diags within 1 file to save 2nd computation. |
| 1045 |
|
- add S/R to compute velocity stream-function (called after velocity-potential |
| 1046 |
|
calculation) from divergence free transport -> new diagnostics "PsiVEL". |
| 1047 |
|
- add parameter to select grid-point location where PsiVEL == 0. |
| 1048 |
|
o eesupp/src: |
| 1049 |
|
new S/R to calculate cumulated sum on tiled array, corner grid-cell location |
| 1050 |
|
(specific S/R needed with exch2 topology - for now, just print an error msg) |
| 1051 |
|
o pkg/shelfice |
| 1052 |
|
- Implement friction velocity-dependent transfer coefficients following |
| 1053 |
|
Holland and Jenkins, JPO, 1999 |
| 1054 |
|
Original code by M. Losch with small modifs. |
| 1055 |
|
Enable with CPP option SHI_ALLOW_GAMMAFRICT |
| 1056 |
|
and runtime flag SHELFICEuseGammaFrict |
| 1057 |
|
o verification lab_sea & global_ocean.cs32x15: |
| 1058 |
|
- use tools/xmakedepend (instead of cyrus_makedepend, in genmake_local): |
| 1059 |
|
does not miss some dependencies (but is slower) and also works with many files |
| 1060 |
|
(default makedepend limitation for AD built). |
| 1061 |
|
- use cyrus_makedepend in adjustment.128x64x1 (so that it still tested). |
| 1062 |
|
o pkg/diagnostics: |
| 1063 |
|
- add run-time parameter "useMissingValue" (def=False) to fill land-point |
| 1064 |
|
(i.e., where mask=0) with MissingValue ; used only in MNC output file. |
| 1065 |
|
This replaces CPP-option DIAGNOSTICS_MISSING_VALUE. |
| 1066 |
|
- Extend the use of "missing_value" setting from data.diagnostics for the case |
| 1067 |
|
of counter-diagnostics (where fraction-weight is zero). This applies both to |
| 1068 |
|
MNC and MDS output files. |
| 1069 |
|
o pkg/seaice/seaice_growth.F: |
| 1070 |
|
- add 'a priori' cap of latent heat flux based on actual mass considerations |
| 1071 |
|
when SEAICE_ADD_SUBLIMATION_TO_FWBUDGET is used in conjunction with the |
| 1072 |
|
non-legacy seaice_solve4temp. |
| 1073 |
|
- add diagnostic of the residual sublimation freshwater flux (the freshwater |
| 1074 |
|
flux taken from the ocean if the total actual latent heat fluxes exceed |
| 1075 |
|
the maximum) |
| 1076 |
|
- remove the CPP switch around the *_FWbySublim unit change and move diagnostic |
| 1077 |
|
fill for SIatmQnt, SIfwSubl, SIatmFW to the end of seaice_growth.F. |
| 1078 |
|
- add diagnostic of the actual sublimation freshwater flux (that is 0. ifndef |
| 1079 |
|
SEAICE_ADD_SUBLIMATION_TO_FWBUDGET) and of the latent heat flux (evap+sublim). |
| 1080 |
|
- bug fix : frWtrAtm needs a_FWbySublim ifdef SEAICE_ADD_SUBLIMATION_TO_FWBUDGET. |
| 1081 |
|
- bug fix : missing part to Martin's r_FWbySublim pathological case fix. |
| 1082 |
|
o verification 1D_ocean_ice_column: |
| 1083 |
|
made model domain truly 1x1x23 instead of 5x5x23 with only center cell (3,3,:) wet |
| 1084 |
|
update results |
| 1085 |
|
o pkg/diagnostics: |
| 1086 |
|
- Implement setting of "Post-Processed" diagnostics (corresponding to gdiag(5)='P') |
| 1087 |
|
which are not filled-up but computed from other diags ; In this case, the mate |
| 1088 |
|
diag points to the primary (filled-up) diag to used for post processing. |
| 1089 |
|
- Update Velocity-potential computation using post-processed diag framework. |
| 1090 |
|
==> Change the ordering of fields and time-periods in MDS output file |
| 1091 |
|
when using periodic averaging: now writes one time record with the full set |
| 1092 |
|
of fields for this time period, then the next time reccord (it used to be |
| 1093 |
|
one field with the full set of time records then the next field). |
| 1094 |
|
Note: this is now similar to NetCDF (MNC) output file. <== |
| 1095 |
|
|
| 1096 |
|
checkpoint62z (2011/06/21) |
| 1097 |
|
o adjoint monitor: |
| 1098 |
|
- Add adjoint monitor output for packages exf, seaice |
| 1099 |
|
and update relevant testreport output |
| 1100 |
|
o pkg/seaice: |
| 1101 |
|
- re-order diags inits so that they appear in order in available_diagnostics.log |
| 1102 |
|
- added diags: hsnow thermo. rates of change, area preceeding ridiging process, |
| 1103 |
|
area/heff/hsnow preceeding thermodynamic growth/melt. |
| 1104 |
|
- modified diag: SIdA; output actual effect, as the description states. |
| 1105 |
|
- modified description: SIqneti, SIqneto, SIuheff, SIvheff, SIdAb*, HSNOW. |
| 1106 |
|
- retired redundant diags: SIyneg, SIfice, SIsnwice, SIthdgrh. |
| 1107 |
|
(SIyneg->SIdHbOCN; SIfice->SIdHbATC; SIsnwice->SIdHbFLO; |
| 1108 |
|
and SIthdgrh->SIdHbOCN+SIdHbATC+SIdHbATO) |
| 1109 |
|
- modified diags (2) : switch all SIdA*, SIdH*, SIdS* from delta to rates. |
| 1110 |
|
- added diagnostics for seaice generic tracers (SItr*). |
| 1111 |
|
- added SItrUnit and SItrNameLong run time param (for SItr* diags). |
| 1112 |
|
- in diag names, replaced 'PrTh' abbrev. of 'preceeding thermo' with 'PT'. |
| 1113 |
|
I. Fenty: 18-Jun-2011: |
| 1114 |
|
Minor changes to seaice package: |
| 1115 |
|
1) Retired old variables (A22, SEAICE_lhsublim, areaMax, areaMin, hiceMin) and |
| 1116 |
|
added some new ones (SEAICE_area_reg, SEAICE_hice_reg, SEAICE_area_floor) |
| 1117 |
|
- Differentiated "regularization variables" from "floor variables" |
| 1118 |
|
* areaMin became SEAICE_area_reg (old A22) and SEAICE_area_floor |
| 1119 |
|
* hiceMin became SEAICE_hice_reg (old hiceMin) |
| 1120 |
|
(with _reg meaning regularization variable) |
| 1121 |
|
- SEAICE_lhSublim becomes lhSublim, the sum of SEAICE_lhEvap and SEAICE_lhFusion |
| 1122 |
|
so as to ensure energy conservation when going between phases |
| 1123 |
|
- A22 was not used anywhere |
| 1124 |
|
2) Changed regularization procedure for heffActual and hsnowActual to ensure |
| 1125 |
|
well-boundedness and smooth adjoint in seaice_growth.F |
| 1126 |
|
3) Fixed a bug where seaice_solve4temp would not recognize ice-free grid cells |
| 1127 |
|
because the old regularization always set heffActual >= 0.05 cm |
| 1128 |
|
4) Changed the model so that the default behavior is to put a small (10^-5) "floor" |
| 1129 |
|
on AREA when HEFF > 0. |
| 1130 |
|
- went from requiring ALLOW_PRECLUDE_INFINITESIMAL_AREA to be defined to |
| 1131 |
|
requiring that DISABLE_AREA_FLOOR *not* be defined |
| 1132 |
|
Affected verifications: |
| 1133 |
|
- 1D_ocean_ice_column (output.txt output_adm.txt) |
| 1134 |
|
- global_ocean.cs32x15 (output.seaice.txt output_adm.seaice.txt) |
| 1135 |
|
o pkg/diagnostics: |
| 1136 |
|
- move MNC code from diagnostics_out.F into new diagnostics_mnc_out.F (2 S/R). |
| 1137 |
|
- rename S/R GETDIAG to DIAGNOSTICS_GET_DIAG and change type of 1rst argument |
| 1138 |
|
(was _RL, now integer) with option = 0 to retrieve all levels. |
| 1139 |
|
- add pieces of code to compute velocity potential at each level (new diagnostics |
| 1140 |
|
PhiVEL, works only when UVELMASS & VVELMASS are also turned on); |
| 1141 |
|
for now, using same params as CG2D (target-resisual, max Nb of iter ...). |
| 1142 |
|
- fix few issues with counter diagnostics in diagnostics_setdiag.F & |
| 1143 |
|
diagstats_setdiag.F (if diagnostic counter is itself a counter diag) |
| 1144 |
|
and in diagnostics_fract_fill.F (do not need a valid pointer for the |
| 1145 |
|
diagnostics counter-mate); check that definition of counter-diagnostic |
| 1146 |
|
includes a valid counter-mate (in diagnostics_set_levels.F). |
| 1147 |
|
o model/src (rStar): |
| 1148 |
|
- add rStar scaling factor in diags_phi_hyd.F (similar to calc_grad_phi_hyd.F); |
| 1149 |
|
affect solution only if z* with full pressure in EOS; |
| 1150 |
|
update output of test-exp global_ocean.90x40x15. |
| 1151 |
|
o pkg/seaice: |
| 1152 |
|
- introduce siEps=1e-5 parameter |
| 1153 |
|
- use areaMax in AREA update (part 4), consistent with ridging step (part 2.5). |
| 1154 |
|
- re-organize SEAICE_ADD_SUBLIMATION_TO_FWBUDGET code. |
| 1155 |
|
- introduce ALLOW_SITRACER and seaice_tracer_phys.F to handle generic seaice tracer. |
| 1156 |
|
For now it covers, and was tested for, ice salinity and age (attached to HEFF), |
| 1157 |
|
as well as ice cover age and ridging index (attached to AREA). |
| 1158 |
|
For now the run time parameters (in data.seaice/SEAICE_PARM03) are |
| 1159 |
|
SItrName (e.g. 'age') and SItrMate ('HEFF', which is the default, or 'AREA'). |
| 1160 |
|
Up to SItrMaxNum=3 tracers can be used simultaneously. |
| 1161 |
|
o pkg/salt_plume: |
| 1162 |
|
-introduce SPsalFRAC run time parameter that sets the fraction of the |
| 1163 |
|
salt by-product of ice growth (SPsalFRAC*(1-SIsalFRAC)*salt typically) |
| 1164 |
|
that gets vertically redistributed (fluxed down) by pkg/salt_plume. |
| 1165 |
|
o model debug options: |
| 1166 |
|
- Switch reading of debugMode from S/R INI_PARMS (parameter file "data", stored |
| 1167 |
|
in PARAMS.h) to S/R EESET_PARMS (parameter file "eedata", stored in EEPARAMS.h). |
| 1168 |
|
- Refine debug-msg printing selection (3 new levels): |
| 1169 |
|
debugMode : controls printing of debug messages (sequence of S/R calls). |
| 1170 |
|
debugLevel : controls printing of algorithm-relevant auxiliary/debug messages |
| 1171 |
|
debLevZero = 0 ; /* level of disabled aux. msg printing */ |
| 1172 |
|
debLevA = 1 ; /* level of minimum aux. msg printing */ |
| 1173 |
|
debLevB = 2 ; /* level of low aux. print (report read-file opening)*/ |
| 1174 |
|
debLevC = 3 ; /* level of moderate debug prt (most pkgs debug msg) */ |
| 1175 |
|
debLevD = 4 ; /* level of enhanced debug prt (add DEBUG_STATS prt) */ |
| 1176 |
|
debLevE = 5 ; /* level of extensive debug printing */ |
| 1177 |
|
New debugLevel default: with default debugMode value (=F), |
| 1178 |
|
= 2 (debLevB) or = 1 (debLevA) in case ALLOW_AUTODIFF is defined.; |
| 1179 |
|
and if debugMode=T, default debugLevel = 4 (debLevD). |
| 1180 |
|
Relation with previous settings: |
| 1181 |
|
debLevB (=2) corresponds to former debLevA (=1) |
| 1182 |
|
debLevD (=4) corresponds to former debLevB (=2) |
| 1183 |
|
Note: |
| 1184 |
|
a) if debugLevel=0, skip WRITE_GRID call when nIter0 > 0 (same as before); |
| 1185 |
|
b) default debugLevel=1 is convenient in AD runs (avoid many file opening msgs); |
| 1186 |
|
to recover previous default, set debugLevel=2 (e.g. AD-test hs94.1x64x5) |
| 1187 |
|
- Add new parameter (printResidualFreq, read from PARM02 namelist) to print |
| 1188 |
|
detailed CG solvers convergence; off (=0) by default, except if debugLevel=5. |
| 1189 |
|
o pkg/obcs: |
| 1190 |
|
- change OBCSfixTopo default from True to False (should not change the results); |
| 1191 |
|
keep OBCSfixTopo=T in verification-exp. seaice_obcs. |
| 1192 |
|
o pkg/thsice: |
| 1193 |
|
- fix bug in thsice_calc_thickn.F (was introduced in version 1.18) in |
| 1194 |
|
2nd layer seaice sublimation (unlikely to happen) |
| 1195 |
|
- use Interior mask for OBCS in thsice_advection.F (similar to what is |
| 1196 |
|
done in gad_advection & seaice_advection). |
| 1197 |
|
o adjoint: |
| 1198 |
|
bug fix spotted by Gael Forget: |
| 1199 |
|
seaice_advection and thsice_advection still had |
| 1200 |
|
legacy CPP options to avoid CS corner updates for adjoint |
| 1201 |
|
o pkg/seaice: |
| 1202 |
|
=> Change some of the defaults (2011/05/29): |
| 1203 |
|
- change SEAICEuseFluxForm default (from False to True) |
| 1204 |
|
- change DIFF1 default (from 0.004 m/s to 0. m/s) |
| 1205 |
|
And print warnings if DIFF1 is not set in data.seaice and centered |
| 1206 |
|
avection scheme is used without any diffusion. |
| 1207 |
|
also: |
| 1208 |
|
- fix seaice_diffusion calls in default AdvScheme part of seaice_advdiff.F; |
| 1209 |
|
- set SEAICEdiffKh[] default in the same way as SEAICEadvSch[] |
| 1210 |
|
- stop if DIFF1<>0 with SEAICEadvScheme <> 2, if DIFF1<>0 with any |
| 1211 |
|
other non-zero SEAICEdiffKh[] diffusivity, if SEAICEadvSalt=T with |
| 1212 |
|
#undef SEAICE_VARIABLE_SALINITY, if SEAICEadvAge=T with #undef SEAICE_AGE. |
| 1213 |
|
update results of test exp.: |
| 1214 |
|
lab_sea: output.fd (switch to AdvScheme=33 with diffKh=20) |
| 1215 |
|
output.hb87, output_adm.evp (SEAICEuseFluxForm=T and diffKh=200) |
| 1216 |
|
output_adm.noseaicedyn (SEAICEuseFluxForm=T) |
| 1217 |
|
offline_exf_seaice: output.seaicetd, output_adm (SEAICEuseFluxForm=T) |
| 1218 |
|
seaice_obcs: output (SEAICEuseFluxForm=T) |
| 1219 |
|
and prescribe old default for SEAICEuseFluxForm (=F) and DIFF1 (=0.004) |
| 1220 |
|
for standard fwd & AD lab_sea tests (to keep the same output). |
| 1221 |
|
o pkg/seaice/seaice_growth.F: |
| 1222 |
|
- use Ian Fenty's capping formulas for actual ice |
| 1223 |
|
thickness thoughout EVOLUTION branch. |
| 1224 |
|
- put treatment pathological case #2) in CPP brackets |
| 1225 |
|
(ALLOW_AVOID_INFINITESIMAL_AREA, undef by default). |
| 1226 |
|
- update global_ocean.cs32x15 and 1D_ocean_ice_colum results accordingly. |
| 1227 |
|
o pkg/seaice: |
| 1228 |
|
- seaice_diffusion.F : remove the min(DX,DY) factor permanently; |
| 1229 |
|
pass the Laplacian diffusivity (in m^2/s) diffKh as a parameter; |
| 1230 |
|
also pass fac as a param, which can be 1. (to update the tendency |
| 1231 |
|
field) or the time step (to update the field itself). |
| 1232 |
|
- seaice_advdiff.F: for multidim, call seaice_diffusion with |
| 1233 |
|
e.g. SEAICEdiffKhHeff and with fac=1; for single-dim, call |
| 1234 |
|
seaice_diffusion with e.g. SEAICEdiffKhHeff and with fac=time step. |
| 1235 |
|
- SEAICE_PARAMS.h, seaice_readparms.F, seaice_check.F : |
| 1236 |
|
hooks to handle SEAICEdiffKhHeff, SEAICEdiffKhArea, etc. |
| 1237 |
|
o pkg/seaice: |
| 1238 |
|
diffusion with centered advection scheme (diffus.F & advect.F): |
| 1239 |
|
- simplify S/R DIFFUS (put deltaT & DIFF1 factor outside, move EXCH outside) |
| 1240 |
|
to just compute the laplacian of input-field. |
| 1241 |
|
- unroll k loop (harmonic,biharmonic diff) in advect.F to save 1 exch call. |
| 1242 |
|
- fix flux-form version in diffus.F to conserve tracer. |
| 1243 |
|
update output of lab_sea.fd & lab_sea.hb87 (1rst set of modif affects |
| 1244 |
|
machine truncation) and lab_sea.salt_plume (conservative flux-form modif) |
| 1245 |
|
|
| 1246 |
|
checkpoint62y (2011/05/26) |
| 1247 |
|
o pkg/seaice: |
| 1248 |
|
- seaice_growth.F : in EVOLUTION branch, always include |
| 1249 |
|
a_QSWbyATM_cover in qnet (as it should be). |
| 1250 |
|
- verification/global_ocean.cs32x15 : update results accordingly |
| 1251 |
|
(output.seaice.txt output_adm.seaice.txt). |
| 1252 |
|
o pkg/seaice + obcs: |
| 1253 |
|
- use maskInW & maskInS in multi-dim advection and biharmonic diffusion: |
| 1254 |
|
equivalent of assuming no tracer gradient outside the OB region. |
| 1255 |
|
update output of seaice_obcs (uses DIFF1 <>0 => biharmonic diffusion) |
| 1256 |
|
- remove calls to OBCS_COPY_TRACER after EXCH calls (no longer needed |
| 1257 |
|
after changes above); |
| 1258 |
|
- obcs+seaice cleaning: apply seaice-tracer OB values to tracer field |
| 1259 |
|
only at OB location (instead of over a band of OLx width). |
| 1260 |
|
o pkg/seaice: |
| 1261 |
|
- fix wrong indices in old (non Flux-Form) diffusion default S/R diffus.F |
| 1262 |
|
(dxG(I+1, ...) changed to dxG(I, ...), no impact on Lat-Lon grid) |
| 1263 |
|
o pkg/obcs: |
| 1264 |
|
- split header file "OBCS.h" into 4 separated files: |
| 1265 |
|
OBCS_PARAMS.h, OBCS_GRID.h, OBCS_FIELDS.h & OBCS_SEAICE.h |
| 1266 |
|
Note: OBCS_PARAMS.h & OBCS_GRID.h can be included without OBCS_OPTIONS.h |
| 1267 |
|
(contain no conditional statement which depends on OBCS options). |
| 1268 |
|
- move "useOBCSYearlyFields" from "data.obcs" (hold in OBCS_PARAMS.h) |
| 1269 |
|
to parameter file "data.exf", namelist EXF_NML_OBCS (in EXF_PARAM.h). |
| 1270 |
|
o ctrl, cost, grdchk & autodiff pkgs: |
| 1271 |
|
- make options file more standard (like other {PKG}_OPTIONS.h file but |
| 1272 |
|
with AD_CONFIG.h); clean-up some of the included header files. |
| 1273 |
|
o pkg/obcs: |
| 1274 |
|
- do not mask tracer when applying OB (tracer == 0 could generate problems) |
| 1275 |
|
- apply tracer OB values to tracer field only at OB location (instead of |
| 1276 |
|
over a band of OLx width) |
| 1277 |
|
- clean-up obcs_apply_w.F & obcs_apply_eta.F (since less calls to these S/R) |
| 1278 |
|
- remove OBCS_MULTIDIM_OLD_VERSION code in gad_advection.F and remove |
| 1279 |
|
obcs_apply_tloc.F & obcs_apply_sloc.F |
| 1280 |
|
o obcs in model/src: |
| 1281 |
|
- call OBCS_APPLY_W only if NonHydrostatic. |
| 1282 |
|
- call OBCS_APPLY_ETA only if NonLinFreeSurf. |
| 1283 |
|
- reset dEtaHdt and wVel to zero outside OB interior region ; |
| 1284 |
|
- leave tracer unchanged outside OB interior region: This has no effect |
| 1285 |
|
on the solution but just to prevent unrealistic tracer value outside OB. |
| 1286 |
|
- zero out velocity outside OB interior region: This has no effect on |
| 1287 |
|
the solution but just to prevent unrealistic velocity outside OB. |
| 1288 |
|
o obcs and non-lin free-surf: |
| 1289 |
|
move call to OBCS_APPLY_R_STAR from update_r_star.F to calc_r_star.F |
| 1290 |
|
and call to OBCS_APPLY_SURF_DR from update_surf_dr.F to calc_surf_dr.F |
| 1291 |
|
+ add argument "etaFld" to OBCS_APPLY_R_STAR & OBCS_APPLY_SURF_DR: |
| 1292 |
|
this fixes missing EXCH + get consistent eta OB value (+ fix restart). |
| 1293 |
|
update results of test-exp. exp4(nlfs). |
| 1294 |
|
o exp4 (nlfs) test-exp: |
| 1295 |
|
use OBC for Eta at Western & Eastern OB (to test prescribing Eta |
| 1296 |
|
with NonLin-FreeSurf); update output.nlfs.txt |
| 1297 |
|
o obcs and 2d/3d solver norm: |
| 1298 |
|
use interior masks (maskInC) to cancel out cg2d & cg3d matrix coeff at OB |
| 1299 |
|
and outside OB interior region (will allow to place OB further inside the |
| 1300 |
|
domain). Depending on the domain, can affects cg2d-Norm (previous |
| 1301 |
|
cancellation outside OB was only partial), e.g. in exp4 & obcs_ctrl, |
| 1302 |
|
and cg3d-Norm (previous Norm was computed before canceling OB terms), |
| 1303 |
|
e.g. in tutorial_plume_on_slope. |
| 1304 |
|
- update output of exp.: exp4 (x2), obcs_ctrl and tutorial_plume_on_slope. |
| 1305 |
|
o pkg rbcs: |
| 1306 |
|
- split RBCS.h into 3 files: RBCS_SIZE.h, RBCS_PARAMS.h & RBCS_FIELDS.h |
| 1307 |
|
- add capability to apply relaxation to horizontal velocity uVel & vVel. |
| 1308 |
|
o pkg/grdchk: add gradient check for control variable xx_shifwflx |
| 1309 |
|
o pkg/shelfice/shelfice_init_fixed.F |
| 1310 |
|
fix CPP-flag combinations |
| 1311 |
|
o pkg/seaice: Merge iceage code of Pierre Rampal |
| 1312 |
|
* update/change/correct ice age calculations |
| 1313 |
|
* add age updates for pathological cases |
| 1314 |
|
Probably needs more testing... |
| 1315 |
|
|
| 1316 |
|
checkpoint62x (2011/05/13) |
| 1317 |
|
o pkg/mom_vecinv: |
| 1318 |
|
high-order vorticity scheme: use interior masks (maskInW & S) |
| 1319 |
|
to zero-out (outside OB) gradient of vorticity. |
| 1320 |
|
o verification exp.: |
| 1321 |
|
turn on "useEnergyConservingCoriolis" (better discretisation) in exp. |
| 1322 |
|
hs94.128x64x5 and seaice_obcs ; update results. |
| 1323 |
|
o pkg/obcs: |
| 1324 |
|
fix bug in OBeta for YZ sections in obcs_exf_load.F |
| 1325 |
|
o pkg/ctrl, pkg/shelfice, and optim: |
| 1326 |
|
- add new control variable xx_shifwflx (fresh water flux underneath ice |
| 1327 |
|
shelves). This is almost as tedious as obcs-ctrl, because the |
| 1328 |
|
variables needs its own mask. |
| 1329 |
|
- add a cost function term that penalizes the deviation of xx_shifwflx |
| 1330 |
|
from the first guess (zero) in analogy to other control variables |
| 1331 |
|
o pkg/shelfice: |
| 1332 |
|
- start basic adjoint |
| 1333 |
|
o pkg/ctrl: |
| 1334 |
|
- remove extra 2D field "for good measure" when initializing in |
| 1335 |
|
ctrl_set_globfld_[xy/xz/yz].F |
| 1336 |
|
- replace hard coded precision 32 (a bug) in ctrl_map_ini_gen by ctrlprec |
| 1337 |
|
- improve error messages in ctrl_set_unpack_* |
| 1338 |
|
o OBC implementation in momentum: |
| 1339 |
|
use interior masks (maskInC,W & S) in momentum S/R: |
| 1340 |
|
- multiply divergence, tension and some del^i.u or del^j.v by maskInC |
| 1341 |
|
- multiply del2u,del2v by maskInW/S (biharmonic viscosity) |
| 1342 |
|
- multiply horiz. grad of vorticity by maskInW/S (in Leith scheme) |
| 1343 |
|
- multiply gradient of wVel by maskInW/S in del2w calculation (NonHyd) |
| 1344 |
|
Motivation: fix/clean implementation of OBC with biharmonic-viscosity |
| 1345 |
|
(and also with Leith/Smagorinsky harmonic-viscosity). |
| 1346 |
|
Update output of experiment dome and exp4 (+nlfs). |
| 1347 |
|
o exp4 test-exp: |
| 1348 |
|
- turn on: nonHydrostatic, exactConserv, viscA4 (with momDissip_In_AB=F) |
| 1349 |
|
and prescribe time-varying OB (without pkg/exf) for zonal-velocity |
| 1350 |
|
at Western & Eastern Boundaries (+/- 1 per-cent); Also prescribe |
| 1351 |
|
time-varying OB at Western-side for wVel (NonHyd); update output. |
| 1352 |
|
- add secondary set-up (.nlfs) using NonLin FreeSurf (z*) + mom_vecinv |
| 1353 |
|
and biharmonic-viscosity ; also use prescribed time varying OB. |
| 1354 |
|
o pkg/obcs: |
| 1355 |
|
fix bug in OBWeta,OBWeta indices in obcs_apply_r_star.F |
| 1356 |
|
o model/src: |
| 1357 |
|
- fix startTime setting when baseTime<>0 & nIter0=0 are specified ; |
| 1358 |
|
- initialise startTime & nIter0 with unlikely values: allows to set one |
| 1359 |
|
from the other without ambiguity. |
| 1360 |
|
o seaice_obcs test-exp.: |
| 1361 |
|
add small diffK4T,S to test biharmonic diffusivity with OBCS ; update output. |
| 1362 |
|
o pkg/obcs: |
| 1363 |
|
- remove calls to OBCS_COPY_TRACER after EXCH for T,S & pTracer: |
| 1364 |
|
no longer needed with maskInC,W,S in pkg/generic_advdiff. |
| 1365 |
|
o pkg/seaice: |
| 1366 |
|
- retired SEAICE_SALINITY and SEAICE_salinity in favor of |
| 1367 |
|
SEAICE_VARIABLE_SALINITY and SIsalFRAC, respectively. |
| 1368 |
|
- fixed bug in the initialization of sea ice salinity variable HSALT |
| 1369 |
|
in seaice_init_varia.F (removed dependence on ICE2WATR) |
| 1370 |
|
o fizhi-cs test exp.: |
| 1371 |
|
switch reference output convention for these 2 non-standard test-exp, |
| 1372 |
|
from: pgi 6.1-5 on faulks (FC.6, -of linux_ia32_pgf77+authors_fc5) |
| 1373 |
|
to: ifort 11.1 on baudelaire (FC.13, -of linux_amd64_ifort11) |
| 1374 |
|
reason: faulks might get retired soon and pkg/fizhi has still Pb with gfortran |
| 1375 |
|
o model/inc: |
| 1376 |
|
- change type of PmEpR array (from _RS to _RL) to fix restart (with "-use_r4") |
| 1377 |
|
of exp. global_ocean.90x40x15 (Suncronous time-stepping + Real-FW + NonLin-FS) |
| 1378 |
|
o pkg/seaice: |
| 1379 |
|
- fix calculation of saltFlux and saltPlumeFlux when using SEAICE_SALINITY |
| 1380 |
|
o verification/lab_sea, 1D_ocean_ice_column, seaice_obcs, global_ocean.cs32x15 |
| 1381 |
|
- updated output*.txt files due to bug fixes in salt, saltPlumeFlux, |
| 1382 |
|
and initial HSALT |
| 1383 |
|
|
| 1384 |
|
checkpoint62w (2011/04/26) |
| 1385 |
|
o pkg/mom_fluxform: |
| 1386 |
|
- fix calculation of del2u & del2v (no-slip BC) when using Non-Lin Free-Surf. |
| 1387 |
|
- use parameter "sideDragFactor" in no-slip BC side-drag part. |
| 1388 |
|
- update output of exp. global_ocean.90x40x15 |
| 1389 |
|
o pkg/mom_vecinv: |
| 1390 |
|
mask del2u & del2v (no effect on results, but cleaner & closer to mom_fluxform) |
| 1391 |
|
o update seaice exp.: |
| 1392 |
|
use more consistent parameter values (remove "backward compatability only": |
| 1393 |
|
ICE2WATR, SEAICE_lhSublim, SEAICE_cpAir, SEAICE_rhoAir + set rhoConstFresh) |
| 1394 |
|
related to thermodynamics seaice. Update output (fwd+AD) of exp.: |
| 1395 |
|
1D_ocean_ice_column (x2), lab_sea (x8), ioffline_exf_seaice (x2) & seaice_obcs |
| 1396 |
|
o update test-exp global_ocean.90x40x15: |
| 1397 |
|
o use default CD_CODE_OPTIONS file (Adams-Bashforth on CD Mom & Coriolis). |
| 1398 |
|
o increase Overlap size from 2 to 3 (to allow to test bi-harmonic Visc.) |
| 1399 |
|
o new pickup-files from a 100.yr run with pkg/down_slope (input.dwnslp params) |
| 1400 |
|
o turn on zStar & viscA4 in standard set-up (dir input/) |
| 1401 |
|
and update output files: output.txt & output.dwnslp.txt |
| 1402 |
|
o new AD-test experiment: obcs_ctrl |
| 1403 |
|
(From Matt MITgcm_Contrib/SOSE/BoxAdj) to test OBCS as control vector. |
| 1404 |
|
o pkg/dic: |
| 1405 |
|
fix two bugs in handling water vapour pressure in carbonate chemistry |
| 1406 |
|
and air-sea fluxes. Found by Val Bennington and Galen McKinley |
| 1407 |
|
(add DIC Option = WATERVAP_BUG to recover old results) |
| 1408 |
|
update output of tutorial_global_oce_biogeo (fwd+AD) & tutorial_dic_adjoffline |
| 1409 |
|
o adding allowInteriorFreezing option to check for water below freezing point |
| 1410 |
|
at depth and bring the negative heat anomaly to the surface level |
| 1411 |
|
o pkgs _fields_load: |
| 1412 |
|
- extend GET_PERIODIC_INTERVAL to deal with non-periodic case (from pkg/rbcs) |
| 1413 |
|
- use new S/R GET_PERIODIC_INTERVAL in pkgs: |
| 1414 |
|
bulk_force, cheapaml, cfc, dic, obcs (+ ctrl/ctrl_get_gen_rec), offline and |
| 1415 |
|
rbcs to get interpolation weights and time reccord number. |
| 1416 |
|
- fix multi-threading in aim_fields_load.F |
| 1417 |
|
- apply EXCH to temp arrays [0,1] after reading in dic_fields_load.F |
| 1418 |
o external_fields_load: |
o external_fields_load: |
| 1419 |
new S/R GET_PERIODIC_INTERVAL to calculate which time-record (and linear |
new S/R GET_PERIODIC_INTERVAL to calculate which time-record (and linear |
| 1420 |
interpolation weights) to use in a periodic time-series ; do not divide by |
interpolation weights) to use in a periodic time-series ; do not divide by |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch