| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
o pkg/ctrl/ctrl_get_gen_rec.F: catch the case of xx_genperiod=0. |
o pkg/seaice (LSR): |
| 8 |
|
- print to STDOUT number of solver iterations at SEAICE_monFreq interval. |
| 9 |
|
- modify solver to deal cleanly with u/v switch at face edges (CS-grid): |
| 10 |
|
* identical results with non-CS topology (but save up to half of EXCH calls) |
| 11 |
|
* no much changes in cs-32 verification tests since no ice at face edges |
| 12 |
|
(differences due to convergence criteria, since nb of iterations changed) |
| 13 |
|
* expect some differences on lat-lon-cap grid. |
| 14 |
|
update FWD results of global_ocean.cs32x15 test exp. (icedyn & seaice) |
| 15 |
|
o pkg/exch2: |
| 16 |
|
- add new CPP option to disable Cumul-Sum matrix (to save storage when using |
| 17 |
|
many tiles); until alternative coding is added, just add a stop. |
| 18 |
|
o pkg/kpp: |
| 19 |
|
- move ptracer/salt correction to KPP diffusivity from calc_3d_diffusivity.F |
| 20 |
|
to S/R KPP_CALC_DIFF_PTR (+ add tracer-index to argument list). |
| 21 |
|
o optfiles: |
| 22 |
|
- merged few MPI specific (*+mpi*) and multi-threads specific (*+mth) optfiles |
| 23 |
|
into corresponding standard one, which now support different build: |
| 24 |
|
(when using "genmake2 -mpi" for MPI built, "genmake2 -omp" for OpenMP built) |
| 25 |
|
- add "darwin_amd64_gfortran" optfile (initially from Constantinos, tested by Gael) |
| 26 |
|
o pkg/obcs (seaice): |
| 27 |
|
- add missing EXCH for uIce,vIce after applying OBCS; |
| 28 |
|
- remove S/R EXF_SWAPFFIELDS_X/Y , disable S/R EXF_SET_OBCS_X/Y by adding |
| 29 |
|
argument = number of levels to S/R EXF_SWAPFFIELDS_XZ/YZ and S/R |
| 30 |
|
EXF_SET_OBCS_XZ/YZ ; update obcs_exf_load.F; |
| 31 |
|
- fix EXF_SET_OBCS_XZ/YZ for multi-threaded (assuming loaded arrays are shared) |
| 32 |
|
- verification exp. seaice_obcs: split domain in 2 tiles ; add SIZE.h_mpi |
| 33 |
|
and eedata.mth for MPI and mutlti-threaded testing. |
| 34 |
|
o pkg/flt: |
| 35 |
|
- make FLT EXCH working with multi-threads (and MPI + multi-threads); |
| 36 |
|
- use buffer for floats IO (trajectories & profiles); size set in FLT_SIZE.h; |
| 37 |
|
- fix pickup and trajectories + profiles output with multi-threads; |
| 38 |
|
- add parameter to select group of fields to write along trajectory and |
| 39 |
|
profile (default unchanged); |
| 40 |
|
- only call PORT_RAND* function when flt_noise <> 0; |
| 41 |
|
- add multi-threaded test for verification exp. flt_example. |
| 42 |
|
o eesupp/src: |
| 43 |
|
- fix S/R ALL_PROC_DIE for MPI+multi-threads. |
| 44 |
|
- USE_OMP_THREADING: check that number of threads (from eedata) matches |
| 45 |
|
actual number (from env.var. setting). |
| 46 |
|
o pkg/ebm: |
| 47 |
|
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
| 48 |
|
- add multi-threaded test for verification exp. global_ocean_ebm |
| 49 |
|
|
| 50 |
|
checkpoint63b (2011/08/29) |
| 51 |
|
o pkg/ebm: |
| 52 |
|
- fix sign of runoff; |
| 53 |
|
- update directly forcing fields (Qnet,EmPmR) to use standard |
| 54 |
|
external_forcing_surf.F (remove ebm_forcing_surf.F); |
| 55 |
|
- avoid loading forcing fields a 2nd time (1rst time from ini_forcing.F); |
| 56 |
|
- set either tauThetaClimRelax (in data) or tauThetaZonRelax (in data.ebm) |
| 57 |
|
and apply relaxation towards corresponding SST field (2-D map or ZonAver). |
| 58 |
|
- update global_ocean_ebm parameters file data and update output (fwd+ad). |
| 59 |
|
o verification/matrix_example: |
| 60 |
|
- split domain in 8 tiles (2x4); add SIZE.h_mpi and eedata.mth for |
| 61 |
|
MPI and mutlti-threaded testing. |
| 62 |
|
o pkg/matrix: |
| 63 |
|
- change name of S/R MATRIX_INIT to S/R MATRIX_INIT_VARIA ; |
| 64 |
|
- fix for multi-tiles (add bi,bj indices to exp/impMatrixCounter); |
| 65 |
|
- fix for multi-threaded (remove DATA statement); |
| 66 |
|
- use standard DIFFERENT_MULTIPLE function; |
| 67 |
|
- add MATRIX_OPTIONS.h |
| 68 |
|
o verification/matrix_example: |
| 69 |
|
To allow to split the domain in several tiles, change the domain size |
| 70 |
|
from 31x31 to 32x32 by adding 1 row (on Southern side) + 1 column (on |
| 71 |
|
Western side) of land points. |
| 72 |
|
o (*_)write_pickup: |
| 73 |
|
- fix few bugs in mypackage_read/write_pickup.F |
| 74 |
|
- in MDS_WR_METAFILES calls, replace "myTime" by a local copy into |
| 75 |
|
array of length 1 (was caught by compiler syntax-check). |
| 76 |
|
o pkg/diagnostics (velocity potential solver): |
| 77 |
|
- fix initialisation of main diagonal matrix (for overlap values) |
| 78 |
|
o tools/build_options: |
| 79 |
|
- towards single optfile for MPI and non-MPI built: merge few +mpi optfile |
| 80 |
|
into previously non MPI one (linux_am64 pgf77,open64,pathf90,ifort11) |
| 81 |
|
- linux_amd64_gfortran: merge +mpi_generic version into standard optfile: |
| 82 |
|
* move IEEE flags to DEVEL section; take IEEE flags from +mpi_generic ; |
| 83 |
|
* FAST case: for now, keep -O3 with ini_masks_etc.F in NOOPTFILES list; |
| 84 |
|
and use "-devel" testreport option for standard testing on baudelaire. |
| 85 |
|
o pkg/grdchk: |
| 86 |
|
- Assume that all gradient-check position are within the same tile |
| 87 |
|
corresponding to global indices (iGloTile,jGloTile) and that |
| 88 |
|
positions (i,j indices or nbeg) are local to this tile; |
| 89 |
|
- set tile local-indices and proc. number according to tile global-indices; |
| 90 |
|
- remove grdchkwhichproc from namelist (retired param); |
| 91 |
|
- send adjoint gradient to all procs so that all procs print it to STDOUT; |
| 92 |
|
- switch on MPI test for global_ocean.90x40x15 AD test experiment. |
| 93 |
|
o adding package bbl (Bottom Boundary Layer) |
| 94 |
|
description in MITgcm/pkg/bbl/bbl_description.tex |
| 95 |
|
example/test experiment in MITgcm_contrib/bbl |
| 96 |
|
o adjoint verifications |
| 97 |
|
- changed 5 experiments to multi-tiles |
| 98 |
|
* global_ocean.90x40x15 |
| 99 |
|
* obcs_ctrl |
| 100 |
|
* offline_exf_seaice |
| 101 |
|
* tutorial_dic_adjoffline |
| 102 |
|
* tutorial_tracer_adjsens |
| 103 |
|
changed reference output for those that crossed tile boundaries |
| 104 |
|
(changed choices of gradient check positions) |
| 105 |
|
- with same tiling, switch on MPI test for the last 4 (add SIZE.h_mpi) |
| 106 |
|
- temporary bug fix in grdchk_loc.F for obcs |
| 107 |
|
o genmake2 & testreport |
| 108 |
|
- add target "obj" (just for OBJFILES files) to Makefile; |
| 109 |
|
- add option to specify FEXTRAFLAGS on command line. |
| 110 |
|
o pkg/mypackage: |
| 111 |
|
- remove bi,bj arguments from argument list of S/R MYPACKAGE_CALC_RHS |
| 112 |
|
|
| 113 |
|
checkpoint63a (2011/08/02) |
| 114 |
|
o pkg/diagnostics (velocity potential): |
| 115 |
|
- fix velocity-potential calculation when using OBCS: balance net inflow |
| 116 |
|
at each level (new S/R OBCS_DIAG_BALANCE). |
| 117 |
|
- fix some of the problems with OBCS in stream-function calculation. |
| 118 |
|
o pkg/exf/exf_readparms.F |
| 119 |
|
- make treatment of optional namelists (EXF_NML_04, EXF_NML_SGRUNOFF, |
| 120 |
|
EXF_NML_OBCS) more consistent, so that you need not have these lists |
| 121 |
|
in data.exf when they are not used. |
| 122 |
|
o optim/optim_readdata.F: |
| 123 |
|
- add some output about obcs variables that might help debugging |
| 124 |
|
- add a check about nvarlength |
| 125 |
|
o pkg/ctrl: once again, fix computation of endrec in s/r ctrl_init_rec |
| 126 |
|
o pkg/diagnostics (velocity potential): |
| 127 |
|
- fix mask for OBCS (still problems in stream-function with OBCS); |
| 128 |
|
- add specific parameter (default = main code CG2D params) for solver; |
| 129 |
|
- in case of poor convergence, use solution corresponding to lowest residual. |
| 130 |
|
o pkg/seaice/seaice_growth.F: small changes that permit vectorizable |
| 131 |
|
adjoint code. In general statements like tmpscal=fld(i,j) are problematic |
| 132 |
|
and should be avoided where possible. |
| 133 |
|
o model/src (rStar): |
| 134 |
|
- include r* effect on reference-state (PhiRef) in totPhiHyd |
| 135 |
|
(so that it's really the potential anomaly at the cell center); |
| 136 |
|
affect solution only if z* with full pressure in EOS. |
| 137 |
|
- test-exp global_ocean.90x40x15: reduce viscA4 (was not stable) and |
| 138 |
|
update output (because of z* in totPhiHyd and viscA4 changes); |
| 139 |
|
- keep the previous diagnostics as "PHIHYDcR" (closer to potential anomaly |
| 140 |
|
@ constant r) until interpolation at constant r is implemented. |
| 141 |
|
o pkg/diagnostics |
| 142 |
|
- fix RCENTER diagnostics in case cell center is not at interface middle |
| 143 |
|
o add code for TEOS-10 (www.teos-10.org, McDougall et al. 2011). Use |
| 144 |
|
this eos with eosType = 'TEOS10', in data (PARM01). This eos implies |
| 145 |
|
that THETA and SALT are "conservative temperature" and "absolute |
| 146 |
|
salinity" |
| 147 |
|
o pkg/ctrl |
| 148 |
|
- fix computation of endrec in s/r ctrl_init_rec |
| 149 |
|
- ctrl_pack/unpack_*: remove unused variables and some obsolete code |
| 150 |
|
o pkg/seaice/seaice_growth.F |
| 151 |
|
- fix recomputation with FENTY_AREA_EXPANSION_CONTRACTION code, |
| 152 |
|
remove then obsolete STORE directives |
| 153 |
|
- fix STORE directives for tice and tices, so that only the |
| 154 |
|
appropriate part of the fields are stored (and not the entire |
| 155 |
|
field); update global_ocean.cs32x15.seaice AD output. |
| 156 |
|
- cosmetic changes: adjust CPP flags and indentation for better |
| 157 |
|
legibilty |
| 158 |
|
o pkg/autodiff: add mnc-output of adBottomDragFld (code contributed by |
| 159 |
|
Chris Wilson) |
| 160 |
|
o pkg/gmredi: |
| 161 |
|
Add Sub-Meso Eddies parameterisation from Baylor (for now, disabled with TAF), |
| 162 |
|
and test it in verification exp. "front_relax.bvp" (update output.bvp.txt) |
| 163 |
|
|
| 164 |
|
checkpoint63 (2011/07/11) |
| 165 |
|
o pkg/exch2: |
| 166 |
|
- rename+move: nTiles in W2_EXCH2_PARAMS.h --> exch2_nTiles in W2_EXCH2_TOPOLOGY.h |
| 167 |
|
- exch2 version of Cumul-Sum routine: S/R W2_SET_MAP_CUMSUM set up the |
| 168 |
|
(2*nTiles)x(nTiles) Cumul-Sum matrix and Master Proc collects all tiles X,Y |
| 169 |
|
increments, calculates Cumul-Sum @ tile origin and sends results to each tile. |
| 170 |
|
o pkg/diagnostics: |
| 171 |
|
- deal with pairs of post-processed diags which are computed together; in |
| 172 |
|
particular, re-order list of diags within 1 file to save 2nd computation. |
| 173 |
|
- add S/R to compute velocity stream-function (called after velocity-potential |
| 174 |
|
calculation) from divergence free transport -> new diagnostics "PsiVEL". |
| 175 |
|
- add parameter to select grid-point location where PsiVEL == 0. |
| 176 |
|
o eesupp/src: |
| 177 |
|
new S/R to calculate cumulated sum on tiled array, corner grid-cell location |
| 178 |
|
(specific S/R needed with exch2 topology - for now, just print an error msg) |
| 179 |
|
o pkg/shelfice |
| 180 |
|
- Implement friction velocity-dependent transfer coefficients following |
| 181 |
|
Holland and Jenkins, JPO, 1999 |
| 182 |
|
Original code by M. Losch with small modifs. |
| 183 |
|
Enable with CPP option SHI_ALLOW_GAMMAFRICT |
| 184 |
|
and runtime flag SHELFICEuseGammaFrict |
| 185 |
|
o verification lab_sea & global_ocean.cs32x15: |
| 186 |
|
- use tools/xmakedepend (instead of cyrus_makedepend, in genmake_local): |
| 187 |
|
does not miss some dependencies (but is slower) and also works with many files |
| 188 |
|
(default makedepend limitation for AD built). |
| 189 |
|
- use cyrus_makedepend in adjustment.128x64x1 (so that it still tested). |
| 190 |
|
o pkg/diagnostics: |
| 191 |
|
- add run-time parameter "useMissingValue" (def=False) to fill land-point |
| 192 |
|
(i.e., where mask=0) with MissingValue ; used only in MNC output file. |
| 193 |
|
This replaces CPP-option DIAGNOSTICS_MISSING_VALUE. |
| 194 |
|
- Extend the use of "missing_value" setting from data.diagnostics for the case |
| 195 |
|
of counter-diagnostics (where fraction-weight is zero). This applies both to |
| 196 |
|
MNC and MDS output files. |
| 197 |
|
o pkg/seaice/seaice_growth.F: |
| 198 |
|
- add 'a priori' cap of latent heat flux based on actual mass considerations |
| 199 |
|
when SEAICE_ADD_SUBLIMATION_TO_FWBUDGET is used in conjunction with the |
| 200 |
|
non-legacy seaice_solve4temp. |
| 201 |
|
- add diagnostic of the residual sublimation freshwater flux (the freshwater |
| 202 |
|
flux taken from the ocean if the total actual latent heat fluxes exceed |
| 203 |
|
the maximum) |
| 204 |
|
- remove the CPP switch around the *_FWbySublim unit change and move diagnostic |
| 205 |
|
fill for SIatmQnt, SIfwSubl, SIatmFW to the end of seaice_growth.F. |
| 206 |
|
- add diagnostic of the actual sublimation freshwater flux (that is 0. ifndef |
| 207 |
|
SEAICE_ADD_SUBLIMATION_TO_FWBUDGET) and of the latent heat flux (evap+sublim). |
| 208 |
|
- bug fix : frWtrAtm needs a_FWbySublim ifdef SEAICE_ADD_SUBLIMATION_TO_FWBUDGET. |
| 209 |
|
- bug fix : missing part to Martin's r_FWbySublim pathological case fix. |
| 210 |
|
o verification 1D_ocean_ice_column: |
| 211 |
|
made model domain truly 1x1x23 instead of 5x5x23 with only center cell (3,3,:) wet |
| 212 |
|
update results |
| 213 |
|
o pkg/diagnostics: |
| 214 |
|
- Implement setting of "Post-Processed" diagnostics (corresponding to gdiag(5)='P') |
| 215 |
|
which are not filled-up but computed from other diags ; In this case, the mate |
| 216 |
|
diag points to the primary (filled-up) diag to used for post processing. |
| 217 |
|
- Update Velocity-potential computation using post-processed diag framework. |
| 218 |
|
==> Change the ordering of fields and time-periods in MDS output file |
| 219 |
|
when using periodic averaging: now writes one time record with the full set |
| 220 |
|
of fields for this time period, then the next time reccord (it used to be |
| 221 |
|
one field with the full set of time records then the next field). |
| 222 |
|
Note: this is now similar to NetCDF (MNC) output file. <== |
| 223 |
|
|
| 224 |
|
checkpoint62z (2011/06/21) |
| 225 |
|
o adjoint monitor: |
| 226 |
|
- Add adjoint monitor output for packages exf, seaice |
| 227 |
|
and update relevant testreport output |
| 228 |
|
o pkg/seaice: |
| 229 |
|
- re-order diags inits so that they appear in order in available_diagnostics.log |
| 230 |
|
- added diags: hsnow thermo. rates of change, area preceeding ridiging process, |
| 231 |
|
area/heff/hsnow preceeding thermodynamic growth/melt. |
| 232 |
|
- modified diag: SIdA; output actual effect, as the description states. |
| 233 |
|
- modified description: SIqneti, SIqneto, SIuheff, SIvheff, SIdAb*, HSNOW. |
| 234 |
|
- retired redundant diags: SIyneg, SIfice, SIsnwice, SIthdgrh. |
| 235 |
|
(SIyneg->SIdHbOCN; SIfice->SIdHbATC; SIsnwice->SIdHbFLO; |
| 236 |
|
and SIthdgrh->SIdHbOCN+SIdHbATC+SIdHbATO) |
| 237 |
|
- modified diags (2) : switch all SIdA*, SIdH*, SIdS* from delta to rates. |
| 238 |
|
- added diagnostics for seaice generic tracers (SItr*). |
| 239 |
|
- added SItrUnit and SItrNameLong run time param (for SItr* diags). |
| 240 |
|
- in diag names, replaced 'PrTh' abbrev. of 'preceeding thermo' with 'PT'. |
| 241 |
|
I. Fenty: 18-Jun-2011: |
| 242 |
|
Minor changes to seaice package: |
| 243 |
|
1) Retired old variables (A22, SEAICE_lhsublim, areaMax, areaMin, hiceMin) and |
| 244 |
|
added some new ones (SEAICE_area_reg, SEAICE_hice_reg, SEAICE_area_floor) |
| 245 |
|
- Differentiated "regularization variables" from "floor variables" |
| 246 |
|
* areaMin became SEAICE_area_reg (old A22) and SEAICE_area_floor |
| 247 |
|
* hiceMin became SEAICE_hice_reg (old hiceMin) |
| 248 |
|
(with _reg meaning regularization variable) |
| 249 |
|
- SEAICE_lhSublim becomes lhSublim, the sum of SEAICE_lhEvap and SEAICE_lhFusion |
| 250 |
|
so as to ensure energy conservation when going between phases |
| 251 |
|
- A22 was not used anywhere |
| 252 |
|
2) Changed regularization procedure for heffActual and hsnowActual to ensure |
| 253 |
|
well-boundedness and smooth adjoint in seaice_growth.F |
| 254 |
|
3) Fixed a bug where seaice_solve4temp would not recognize ice-free grid cells |
| 255 |
|
because the old regularization always set heffActual >= 0.05 cm |
| 256 |
|
4) Changed the model so that the default behavior is to put a small (10^-5) "floor" |
| 257 |
|
on AREA when HEFF > 0. |
| 258 |
|
- went from requiring ALLOW_PRECLUDE_INFINITESIMAL_AREA to be defined to |
| 259 |
|
requiring that DISABLE_AREA_FLOOR *not* be defined |
| 260 |
|
Affected verifications: |
| 261 |
|
- 1D_ocean_ice_column (output.txt output_adm.txt) |
| 262 |
|
- global_ocean.cs32x15 (output.seaice.txt output_adm.seaice.txt) |
| 263 |
|
o pkg/diagnostics: |
| 264 |
|
- move MNC code from diagnostics_out.F into new diagnostics_mnc_out.F (2 S/R). |
| 265 |
|
- rename S/R GETDIAG to DIAGNOSTICS_GET_DIAG and change type of 1rst argument |
| 266 |
|
(was _RL, now integer) with option = 0 to retrieve all levels. |
| 267 |
|
- add pieces of code to compute velocity potential at each level (new diagnostics |
| 268 |
|
PhiVEL, works only when UVELMASS & VVELMASS are also turned on); |
| 269 |
|
for now, using same params as CG2D (target-resisual, max Nb of iter ...). |
| 270 |
|
- fix few issues with counter diagnostics in diagnostics_setdiag.F & |
| 271 |
|
diagstats_setdiag.F (if diagnostic counter is itself a counter diag) |
| 272 |
|
and in diagnostics_fract_fill.F (do not need a valid pointer for the |
| 273 |
|
diagnostics counter-mate); check that definition of counter-diagnostic |
| 274 |
|
includes a valid counter-mate (in diagnostics_set_levels.F). |
| 275 |
|
o model/src (rStar): |
| 276 |
|
- add rStar scaling factor in diags_phi_hyd.F (similar to calc_grad_phi_hyd.F); |
| 277 |
|
affect solution only if z* with full pressure in EOS; |
| 278 |
|
update output of test-exp global_ocean.90x40x15. |
| 279 |
|
o pkg/seaice: |
| 280 |
|
- introduce siEps=1e-5 parameter |
| 281 |
|
- use areaMax in AREA update (part 4), consistent with ridging step (part 2.5). |
| 282 |
|
- re-organize SEAICE_ADD_SUBLIMATION_TO_FWBUDGET code. |
| 283 |
|
- introduce ALLOW_SITRACER and seaice_tracer_phys.F to handle generic seaice tracer. |
| 284 |
|
For now it covers, and was tested for, ice salinity and age (attached to HEFF), |
| 285 |
|
as well as ice cover age and ridging index (attached to AREA). |
| 286 |
|
For now the run time parameters (in data.seaice/SEAICE_PARM03) are |
| 287 |
|
SItrName (e.g. 'age') and SItrMate ('HEFF', which is the default, or 'AREA'). |
| 288 |
|
Up to SItrMaxNum=3 tracers can be used simultaneously. |
| 289 |
|
o pkg/salt_plume: |
| 290 |
|
-introduce SPsalFRAC run time parameter that sets the fraction of the |
| 291 |
|
salt by-product of ice growth (SPsalFRAC*(1-SIsalFRAC)*salt typically) |
| 292 |
|
that gets vertically redistributed (fluxed down) by pkg/salt_plume. |
| 293 |
|
o model debug options: |
| 294 |
|
- Switch reading of debugMode from S/R INI_PARMS (parameter file "data", stored |
| 295 |
|
in PARAMS.h) to S/R EESET_PARMS (parameter file "eedata", stored in EEPARAMS.h). |
| 296 |
|
- Refine debug-msg printing selection (3 new levels): |
| 297 |
|
debugMode : controls printing of debug messages (sequence of S/R calls). |
| 298 |
|
debugLevel : controls printing of algorithm-relevant auxiliary/debug messages |
| 299 |
|
debLevZero = 0 ; /* level of disabled aux. msg printing */ |
| 300 |
|
debLevA = 1 ; /* level of minimum aux. msg printing */ |
| 301 |
|
debLevB = 2 ; /* level of low aux. print (report read-file opening)*/ |
| 302 |
|
debLevC = 3 ; /* level of moderate debug prt (most pkgs debug msg) */ |
| 303 |
|
debLevD = 4 ; /* level of enhanced debug prt (add DEBUG_STATS prt) */ |
| 304 |
|
debLevE = 5 ; /* level of extensive debug printing */ |
| 305 |
|
New debugLevel default: with default debugMode value (=F), |
| 306 |
|
= 2 (debLevB) or = 1 (debLevA) in case ALLOW_AUTODIFF is defined.; |
| 307 |
|
and if debugMode=T, default debugLevel = 4 (debLevD). |
| 308 |
|
Relation with previous settings: |
| 309 |
|
debLevB (=2) corresponds to former debLevA (=1) |
| 310 |
|
debLevD (=4) corresponds to former debLevB (=2) |
| 311 |
|
Note: |
| 312 |
|
a) if debugLevel=0, skip WRITE_GRID call when nIter0 > 0 (same as before); |
| 313 |
|
b) default debugLevel=1 is convenient in AD runs (avoid many file opening msgs); |
| 314 |
|
to recover previous default, set debugLevel=2 (e.g. AD-test hs94.1x64x5) |
| 315 |
|
- Add new parameter (printResidualFreq, read from PARM02 namelist) to print |
| 316 |
|
detailed CG solvers convergence; off (=0) by default, except if debugLevel=5. |
| 317 |
|
o pkg/obcs: |
| 318 |
|
- change OBCSfixTopo default from True to False (should not change the results); |
| 319 |
|
keep OBCSfixTopo=T in verification-exp. seaice_obcs. |
| 320 |
|
o pkg/thsice: |
| 321 |
|
- fix bug in thsice_calc_thickn.F (was introduced in version 1.18) in |
| 322 |
|
2nd layer seaice sublimation (unlikely to happen) |
| 323 |
|
- use Interior mask for OBCS in thsice_advection.F (similar to what is |
| 324 |
|
done in gad_advection & seaice_advection). |
| 325 |
|
o adjoint: |
| 326 |
|
bug fix spotted by Gael Forget: |
| 327 |
|
seaice_advection and thsice_advection still had |
| 328 |
|
legacy CPP options to avoid CS corner updates for adjoint |
| 329 |
|
o pkg/seaice: |
| 330 |
|
=> Change some of the defaults (2011/05/29): |
| 331 |
|
- change SEAICEuseFluxForm default (from False to True) |
| 332 |
|
- change DIFF1 default (from 0.004 m/s to 0. m/s) |
| 333 |
|
And print warnings if DIFF1 is not set in data.seaice and centered |
| 334 |
|
avection scheme is used without any diffusion. |
| 335 |
|
also: |
| 336 |
|
- fix seaice_diffusion calls in default AdvScheme part of seaice_advdiff.F; |
| 337 |
|
- set SEAICEdiffKh[] default in the same way as SEAICEadvSch[] |
| 338 |
|
- stop if DIFF1<>0 with SEAICEadvScheme <> 2, if DIFF1<>0 with any |
| 339 |
|
other non-zero SEAICEdiffKh[] diffusivity, if SEAICEadvSalt=T with |
| 340 |
|
#undef SEAICE_VARIABLE_SALINITY, if SEAICEadvAge=T with #undef SEAICE_AGE. |
| 341 |
|
update results of test exp.: |
| 342 |
|
lab_sea: output.fd (switch to AdvScheme=33 with diffKh=20) |
| 343 |
|
output.hb87, output_adm.evp (SEAICEuseFluxForm=T and diffKh=200) |
| 344 |
|
output_adm.noseaicedyn (SEAICEuseFluxForm=T) |
| 345 |
|
offline_exf_seaice: output.seaicetd, output_adm (SEAICEuseFluxForm=T) |
| 346 |
|
seaice_obcs: output (SEAICEuseFluxForm=T) |
| 347 |
|
and prescribe old default for SEAICEuseFluxForm (=F) and DIFF1 (=0.004) |
| 348 |
|
for standard fwd & AD lab_sea tests (to keep the same output). |
| 349 |
|
o pkg/seaice/seaice_growth.F: |
| 350 |
|
- use Ian Fenty's capping formulas for actual ice |
| 351 |
|
thickness thoughout EVOLUTION branch. |
| 352 |
|
- put treatment pathological case #2) in CPP brackets |
| 353 |
|
(ALLOW_AVOID_INFINITESIMAL_AREA, undef by default). |
| 354 |
|
- update global_ocean.cs32x15 and 1D_ocean_ice_colum results accordingly. |
| 355 |
|
o pkg/seaice: |
| 356 |
|
- seaice_diffusion.F : remove the min(DX,DY) factor permanently; |
| 357 |
|
pass the Laplacian diffusivity (in m^2/s) diffKh as a parameter; |
| 358 |
|
also pass fac as a param, which can be 1. (to update the tendency |
| 359 |
|
field) or the time step (to update the field itself). |
| 360 |
|
- seaice_advdiff.F: for multidim, call seaice_diffusion with |
| 361 |
|
e.g. SEAICEdiffKhHeff and with fac=1; for single-dim, call |
| 362 |
|
seaice_diffusion with e.g. SEAICEdiffKhHeff and with fac=time step. |
| 363 |
|
- SEAICE_PARAMS.h, seaice_readparms.F, seaice_check.F : |
| 364 |
|
hooks to handle SEAICEdiffKhHeff, SEAICEdiffKhArea, etc. |
| 365 |
|
o pkg/seaice: |
| 366 |
|
diffusion with centered advection scheme (diffus.F & advect.F): |
| 367 |
|
- simplify S/R DIFFUS (put deltaT & DIFF1 factor outside, move EXCH outside) |
| 368 |
|
to just compute the laplacian of input-field. |
| 369 |
|
- unroll k loop (harmonic,biharmonic diff) in advect.F to save 1 exch call. |
| 370 |
|
- fix flux-form version in diffus.F to conserve tracer. |
| 371 |
|
update output of lab_sea.fd & lab_sea.hb87 (1rst set of modif affects |
| 372 |
|
machine truncation) and lab_sea.salt_plume (conservative flux-form modif) |
| 373 |
|
|
| 374 |
|
checkpoint62y (2011/05/26) |
| 375 |
|
o pkg/seaice: |
| 376 |
|
- seaice_growth.F : in EVOLUTION branch, always include |
| 377 |
|
a_QSWbyATM_cover in qnet (as it should be). |
| 378 |
|
- verification/global_ocean.cs32x15 : update results accordingly |
| 379 |
|
(output.seaice.txt output_adm.seaice.txt). |
| 380 |
|
o pkg/seaice + obcs: |
| 381 |
|
- use maskInW & maskInS in multi-dim advection and biharmonic diffusion: |
| 382 |
|
equivalent of assuming no tracer gradient outside the OB region. |
| 383 |
|
update output of seaice_obcs (uses DIFF1 <>0 => biharmonic diffusion) |
| 384 |
|
- remove calls to OBCS_COPY_TRACER after EXCH calls (no longer needed |
| 385 |
|
after changes above); |
| 386 |
|
- obcs+seaice cleaning: apply seaice-tracer OB values to tracer field |
| 387 |
|
only at OB location (instead of over a band of OLx width). |
| 388 |
|
o pkg/seaice: |
| 389 |
|
- fix wrong indices in old (non Flux-Form) diffusion default S/R diffus.F |
| 390 |
|
(dxG(I+1, ...) changed to dxG(I, ...), no impact on Lat-Lon grid) |
| 391 |
|
o pkg/obcs: |
| 392 |
|
- split header file "OBCS.h" into 4 separated files: |
| 393 |
|
OBCS_PARAMS.h, OBCS_GRID.h, OBCS_FIELDS.h & OBCS_SEAICE.h |
| 394 |
|
Note: OBCS_PARAMS.h & OBCS_GRID.h can be included without OBCS_OPTIONS.h |
| 395 |
|
(contain no conditional statement which depends on OBCS options). |
| 396 |
|
- move "useOBCSYearlyFields" from "data.obcs" (hold in OBCS_PARAMS.h) |
| 397 |
|
to parameter file "data.exf", namelist EXF_NML_OBCS (in EXF_PARAM.h). |
| 398 |
|
o ctrl, cost, grdchk & autodiff pkgs: |
| 399 |
|
- make options file more standard (like other {PKG}_OPTIONS.h file but |
| 400 |
|
with AD_CONFIG.h); clean-up some of the included header files. |
| 401 |
|
o pkg/obcs: |
| 402 |
|
- do not mask tracer when applying OB (tracer == 0 could generate problems) |
| 403 |
|
- apply tracer OB values to tracer field only at OB location (instead of |
| 404 |
|
over a band of OLx width) |
| 405 |
|
- clean-up obcs_apply_w.F & obcs_apply_eta.F (since less calls to these S/R) |
| 406 |
|
- remove OBCS_MULTIDIM_OLD_VERSION code in gad_advection.F and remove |
| 407 |
|
obcs_apply_tloc.F & obcs_apply_sloc.F |
| 408 |
|
o obcs in model/src: |
| 409 |
|
- call OBCS_APPLY_W only if NonHydrostatic. |
| 410 |
|
- call OBCS_APPLY_ETA only if NonLinFreeSurf. |
| 411 |
|
- reset dEtaHdt and wVel to zero outside OB interior region ; |
| 412 |
|
- leave tracer unchanged outside OB interior region: This has no effect |
| 413 |
|
on the solution but just to prevent unrealistic tracer value outside OB. |
| 414 |
|
- zero out velocity outside OB interior region: This has no effect on |
| 415 |
|
the solution but just to prevent unrealistic velocity outside OB. |
| 416 |
|
o obcs and non-lin free-surf: |
| 417 |
|
move call to OBCS_APPLY_R_STAR from update_r_star.F to calc_r_star.F |
| 418 |
|
and call to OBCS_APPLY_SURF_DR from update_surf_dr.F to calc_surf_dr.F |
| 419 |
|
+ add argument "etaFld" to OBCS_APPLY_R_STAR & OBCS_APPLY_SURF_DR: |
| 420 |
|
this fixes missing EXCH + get consistent eta OB value (+ fix restart). |
| 421 |
|
update results of test-exp. exp4(nlfs). |
| 422 |
|
o exp4 (nlfs) test-exp: |
| 423 |
|
use OBC for Eta at Western & Eastern OB (to test prescribing Eta |
| 424 |
|
with NonLin-FreeSurf); update output.nlfs.txt |
| 425 |
|
o obcs and 2d/3d solver norm: |
| 426 |
|
use interior masks (maskInC) to cancel out cg2d & cg3d matrix coeff at OB |
| 427 |
|
and outside OB interior region (will allow to place OB further inside the |
| 428 |
|
domain). Depending on the domain, can affects cg2d-Norm (previous |
| 429 |
|
cancellation outside OB was only partial), e.g. in exp4 & obcs_ctrl, |
| 430 |
|
and cg3d-Norm (previous Norm was computed before canceling OB terms), |
| 431 |
|
e.g. in tutorial_plume_on_slope. |
| 432 |
|
- update output of exp.: exp4 (x2), obcs_ctrl and tutorial_plume_on_slope. |
| 433 |
|
o pkg rbcs: |
| 434 |
|
- split RBCS.h into 3 files: RBCS_SIZE.h, RBCS_PARAMS.h & RBCS_FIELDS.h |
| 435 |
|
- add capability to apply relaxation to horizontal velocity uVel & vVel. |
| 436 |
|
o pkg/grdchk: add gradient check for control variable xx_shifwflx |
| 437 |
|
o pkg/shelfice/shelfice_init_fixed.F |
| 438 |
|
fix CPP-flag combinations |
| 439 |
|
o pkg/seaice: Merge iceage code of Pierre Rampal |
| 440 |
|
* update/change/correct ice age calculations |
| 441 |
|
* add age updates for pathological cases |
| 442 |
|
Probably needs more testing... |
| 443 |
|
|
| 444 |
|
checkpoint62x (2011/05/13) |
| 445 |
|
o pkg/mom_vecinv: |
| 446 |
|
high-order vorticity scheme: use interior masks (maskInW & S) |
| 447 |
|
to zero-out (outside OB) gradient of vorticity. |
| 448 |
|
o verification exp.: |
| 449 |
|
turn on "useEnergyConservingCoriolis" (better discretisation) in exp. |
| 450 |
|
hs94.128x64x5 and seaice_obcs ; update results. |
| 451 |
|
o pkg/obcs: |
| 452 |
|
fix bug in OBeta for YZ sections in obcs_exf_load.F |
| 453 |
|
o pkg/ctrl, pkg/shelfice, and optim: |
| 454 |
|
- add new control variable xx_shifwflx (fresh water flux underneath ice |
| 455 |
|
shelves). This is almost as tedious as obcs-ctrl, because the |
| 456 |
|
variables needs its own mask. |
| 457 |
|
- add a cost function term that penalizes the deviation of xx_shifwflx |
| 458 |
|
from the first guess (zero) in analogy to other control variables |
| 459 |
|
o pkg/shelfice: |
| 460 |
|
- start basic adjoint |
| 461 |
|
o pkg/ctrl: |
| 462 |
|
- remove extra 2D field "for good measure" when initializing in |
| 463 |
|
ctrl_set_globfld_[xy/xz/yz].F |
| 464 |
|
- replace hard coded precision 32 (a bug) in ctrl_map_ini_gen by ctrlprec |
| 465 |
|
- improve error messages in ctrl_set_unpack_* |
| 466 |
|
o OBC implementation in momentum: |
| 467 |
|
use interior masks (maskInC,W & S) in momentum S/R: |
| 468 |
|
- multiply divergence, tension and some del^i.u or del^j.v by maskInC |
| 469 |
|
- multiply del2u,del2v by maskInW/S (biharmonic viscosity) |
| 470 |
|
- multiply horiz. grad of vorticity by maskInW/S (in Leith scheme) |
| 471 |
|
- multiply gradient of wVel by maskInW/S in del2w calculation (NonHyd) |
| 472 |
|
Motivation: fix/clean implementation of OBC with biharmonic-viscosity |
| 473 |
|
(and also with Leith/Smagorinsky harmonic-viscosity). |
| 474 |
|
Update output of experiment dome and exp4 (+nlfs). |
| 475 |
|
o exp4 test-exp: |
| 476 |
|
- turn on: nonHydrostatic, exactConserv, viscA4 (with momDissip_In_AB=F) |
| 477 |
|
and prescribe time-varying OB (without pkg/exf) for zonal-velocity |
| 478 |
|
at Western & Eastern Boundaries (+/- 1 per-cent); Also prescribe |
| 479 |
|
time-varying OB at Western-side for wVel (NonHyd); update output. |
| 480 |
|
- add secondary set-up (.nlfs) using NonLin FreeSurf (z*) + mom_vecinv |
| 481 |
|
and biharmonic-viscosity ; also use prescribed time varying OB. |
| 482 |
|
o pkg/obcs: |
| 483 |
|
fix bug in OBWeta,OBWeta indices in obcs_apply_r_star.F |
| 484 |
|
o model/src: |
| 485 |
|
- fix startTime setting when baseTime<>0 & nIter0=0 are specified ; |
| 486 |
|
- initialise startTime & nIter0 with unlikely values: allows to set one |
| 487 |
|
from the other without ambiguity. |
| 488 |
|
o seaice_obcs test-exp.: |
| 489 |
|
add small diffK4T,S to test biharmonic diffusivity with OBCS ; update output. |
| 490 |
|
o pkg/obcs: |
| 491 |
|
- remove calls to OBCS_COPY_TRACER after EXCH for T,S & pTracer: |
| 492 |
|
no longer needed with maskInC,W,S in pkg/generic_advdiff. |
| 493 |
|
o pkg/seaice: |
| 494 |
|
- retired SEAICE_SALINITY and SEAICE_salinity in favor of |
| 495 |
|
SEAICE_VARIABLE_SALINITY and SIsalFRAC, respectively. |
| 496 |
|
- fixed bug in the initialization of sea ice salinity variable HSALT |
| 497 |
|
in seaice_init_varia.F (removed dependence on ICE2WATR) |
| 498 |
|
o fizhi-cs test exp.: |
| 499 |
|
switch reference output convention for these 2 non-standard test-exp, |
| 500 |
|
from: pgi 6.1-5 on faulks (FC.6, -of linux_ia32_pgf77+authors_fc5) |
| 501 |
|
to: ifort 11.1 on baudelaire (FC.13, -of linux_amd64_ifort11) |
| 502 |
|
reason: faulks might get retired soon and pkg/fizhi has still Pb with gfortran |
| 503 |
|
o model/inc: |
| 504 |
|
- change type of PmEpR array (from _RS to _RL) to fix restart (with "-use_r4") |
| 505 |
|
of exp. global_ocean.90x40x15 (Suncronous time-stepping + Real-FW + NonLin-FS) |
| 506 |
|
o pkg/seaice: |
| 507 |
|
- fix calculation of saltFlux and saltPlumeFlux when using SEAICE_SALINITY |
| 508 |
|
o verification/lab_sea, 1D_ocean_ice_column, seaice_obcs, global_ocean.cs32x15 |
| 509 |
|
- updated output*.txt files due to bug fixes in salt, saltPlumeFlux, |
| 510 |
|
and initial HSALT |
| 511 |
|
|
| 512 |
|
checkpoint62w (2011/04/26) |
| 513 |
|
o pkg/mom_fluxform: |
| 514 |
|
- fix calculation of del2u & del2v (no-slip BC) when using Non-Lin Free-Surf. |
| 515 |
|
- use parameter "sideDragFactor" in no-slip BC side-drag part. |
| 516 |
|
- update output of exp. global_ocean.90x40x15 |
| 517 |
|
o pkg/mom_vecinv: |
| 518 |
|
mask del2u & del2v (no effect on results, but cleaner & closer to mom_fluxform) |
| 519 |
|
o update seaice exp.: |
| 520 |
|
use more consistent parameter values (remove "backward compatability only": |
| 521 |
|
ICE2WATR, SEAICE_lhSublim, SEAICE_cpAir, SEAICE_rhoAir + set rhoConstFresh) |
| 522 |
|
related to thermodynamics seaice. Update output (fwd+AD) of exp.: |
| 523 |
|
1D_ocean_ice_column (x2), lab_sea (x8), ioffline_exf_seaice (x2) & seaice_obcs |
| 524 |
|
o update test-exp global_ocean.90x40x15: |
| 525 |
|
o use default CD_CODE_OPTIONS file (Adams-Bashforth on CD Mom & Coriolis). |
| 526 |
|
o increase Overlap size from 2 to 3 (to allow to test bi-harmonic Visc.) |
| 527 |
|
o new pickup-files from a 100.yr run with pkg/down_slope (input.dwnslp params) |
| 528 |
|
o turn on zStar & viscA4 in standard set-up (dir input/) |
| 529 |
|
and update output files: output.txt & output.dwnslp.txt |
| 530 |
|
o new AD-test experiment: obcs_ctrl |
| 531 |
|
(From Matt MITgcm_Contrib/SOSE/BoxAdj) to test OBCS as control vector. |
| 532 |
|
o pkg/dic: |
| 533 |
|
fix two bugs in handling water vapour pressure in carbonate chemistry |
| 534 |
|
and air-sea fluxes. Found by Val Bennington and Galen McKinley |
| 535 |
|
(add DIC Option = WATERVAP_BUG to recover old results) |
| 536 |
|
update output of tutorial_global_oce_biogeo (fwd+AD) & tutorial_dic_adjoffline |
| 537 |
|
o adding allowInteriorFreezing option to check for water below freezing point |
| 538 |
|
at depth and bring the negative heat anomaly to the surface level |
| 539 |
|
o pkgs _fields_load: |
| 540 |
|
- extend GET_PERIODIC_INTERVAL to deal with non-periodic case (from pkg/rbcs) |
| 541 |
|
- use new S/R GET_PERIODIC_INTERVAL in pkgs: |
| 542 |
|
bulk_force, cheapaml, cfc, dic, obcs (+ ctrl/ctrl_get_gen_rec), offline and |
| 543 |
|
rbcs to get interpolation weights and time reccord number. |
| 544 |
|
- fix multi-threading in aim_fields_load.F |
| 545 |
|
- apply EXCH to temp arrays [0,1] after reading in dic_fields_load.F |
| 546 |
|
o external_fields_load: |
| 547 |
|
new S/R GET_PERIODIC_INTERVAL to calculate which time-record (and linear |
| 548 |
|
interpolation weights) to use in a periodic time-series ; do not divide by |
| 549 |
|
time-step to convert to integer: |
| 550 |
|
- this fixes case where externForcingPeriod is not multiple of time-step |
| 551 |
|
(Thanks to Christopher L. Wolfe) |
| 552 |
|
- this fixes case where externForcingPeriod is an odd multiple of time-step |
| 553 |
|
(was wrong by half of time-step); update results of tutorial_global_oce_in_p. |
| 554 |
|
store index of time-record which is currently loaded: |
| 555 |
|
- works without any assumption on sequence of calls to EXTERNAL_FIELDS_LOAD ; |
| 556 |
|
- needed for the adjoint but not yet used because of extensive recomputations; |
| 557 |
|
(to be fixed soon) |
| 558 |
|
|
| 559 |
|
checkpoint62v (2011/04/02) |
| 560 |
|
o verification/1D_ocean_ice_column added to test Ian Fenty's |
| 561 |
|
pkg/seaice_growth.F modifications for improving sea ice code differentiability |
| 562 |
|
o update output of exp4, internal_wave, seaice_obcs, tutorial_plume_on_slope |
| 563 |
|
(new velocity statistics after changing maskInW & maskInS definition) |
| 564 |
|
o pkg/generic_advdiff with OBCS: |
| 565 |
|
use maksInW & maskInS in advective flux and in biharmonic diffusion calculation: |
| 566 |
|
equivalent to assumption of no tracer gradient outside the OB region. |
| 567 |
|
This will affect the results if using obcs+biharmonic diffusion. |
| 568 |
|
update output_adm.txt of experiment bottom_ctrl_5x5 (not expected since no obc) |
| 569 |
|
o pkg/obcs: |
| 570 |
|
change definition of maskInW & maskInS: leave OB edges inside (maskIn=1) |
| 571 |
|
(e.g., maskInW(OB_Ie)=1 ) so that velocity normal-component at OB is still |
| 572 |
|
in Interior region. No impact on solution but affects Velocity monitor stats. |
| 573 |
|
o pkg/ptracers (adjoint) |
| 574 |
|
New option AUTODIFF_PTRACERS_SPLIT_FILES for writing separate |
| 575 |
|
tape file for each tracer |
| 576 |
|
o model/inc/src and pkg/autodiff: add parameters that allow to turn |
| 577 |
|
of parts of the adjoint code at run time. For now, there are only |
| 578 |
|
useKPPinAdMode, useGMrediInAdMode, and useSEAICEinAdMode. These |
| 579 |
|
parameters are set in data.pkg. |
| 580 |
|
This is the lazy coward's version of doing this, but still useful for |
| 581 |
|
debugging. In order to do it right, everything needs to be moved to |
| 582 |
|
pkg/autodiff. |
| 583 |
|
o pkg/autodiff: fix global_sum_tile_ad.F by resetting adsumPhi at |
| 584 |
|
the end; this fixes the adjoint balancing code for open boundaries. |
| 585 |
|
o pkg/ctrl: |
| 586 |
|
- change behavior of xx_${varname}period to be analogous to exf-conventions: |
| 587 |
|
xx_${varname}period = 0., means time-independent control part |
| 588 |
|
xx_${varname}period = -12., means one-year-periodic monthly control part |
| 589 |
|
- introduce helper routine ctrl_init_rec (part of ctrl_init.F) to |
| 590 |
|
clean up ctrl_init a little, remove unused variables |
| 591 |
|
- ctrl_init: fixed the handling of the start/endrec for obcs-variables |
| 592 |
|
- move "call cal_GetMonthsRec" from s/r ctrl_get_gen to s/r ctrl_get_gen_rec |
| 593 |
|
|
| 594 |
|
checkpoint62u (2011/03/15) |
| 595 |
|
o model/src: |
| 596 |
|
- for the adjoint, change NonLin-FreeSurf initialisation sequence: fill-in |
| 597 |
|
h0Fac from INITIALISE_FIXED and reset hFac to h0Fac in INITIALISE_VARIA ; |
| 598 |
|
- in initialise_varia.F (except for ALLOW_DEPTH_CONTROL) remove 2nd call to |
| 599 |
|
INI_DEPTHS, INI_MASKS_ETC & INI_LINEAR_PHISURF. |
| 600 |
|
o pkg/ctrl/obcs/ecco: |
| 601 |
|
- remove obsolete, unused, and partially broken code: |
| 602 |
|
ctrl_obcsvol/ctrl_obcsbal/ctrl_volflux and code within |
| 603 |
|
ALLOW_CTRL_OBCS_BALANCE |
| 604 |
|
- put a stop statement into ecco/cost_obcsvol.F, but also add |
| 605 |
|
cost_obcsvol to ecco_ad_diff.list |
| 606 |
|
o pkg/ecco: fix counting cost function contributions for obcs (code |
| 607 |
|
by Matt M.) and diffkr for diagnostics |
| 608 |
|
o pkg/ecco, pkg/ctrl, pkg/grdchk: |
| 609 |
|
add cost penalty terms for initial uvel, vvel, eta controls |
| 610 |
|
and I/O for prior error files |
| 611 |
|
o pkg/mdsio: |
| 612 |
|
move mds_check4file.F from eesupp/src to mdsio_check4file.F ; add option |
| 613 |
|
(new argument) to check for tiled file in mdsioLocalDir : this fix the |
| 614 |
|
restart from pickup_som , pickup_dic (& dic_co2atm) with mdsioLocalDir. |
| 615 |
|
o pkg/ctrl: |
| 616 |
|
- ctrl_obcsbal.F, ctrl_obcsvol.F: replace last calls of ctrl_getrec by |
| 617 |
|
ctrl_get_gen_rec, put a stop statement into ctrl_getrec. Remove |
| 618 |
|
unused and superfluous variables |
| 619 |
|
- ctrl_get_gen_rec.F: catch the case of xx_genperiod=0. |
| 620 |
o pkg/ecco |
o pkg/ecco |
| 621 |
- enable adjoint of Stevens OB |
- enable adjoint of Stevens OB |
| 622 |
o pkg/ctrl/ecco/grdchk: |
o pkg/ctrl/ecco/grdchk: |
| 623 |
- remove global declaration of tmpfldx/yz and tmpfldx/yz2. |
- remove global declaration of tmpfldx/yz and tmpfldx/yz2. |
| 624 |
Fortunately, we do not have any tests for the numerous cpp-flagged |
Fortunately, we do not have any tests for the numerous cpp-flagged |
| 625 |
option of "obcs as control parameters" so we will never know |
option of "obcs as control parameters" so we will never know |
| 626 |
if this is an improvement (but at least now things compile). |
if this is an improvement (but at least now things compile). |
| 627 |
- remove an obsolete initialization from ecco_cost_init_barfiles.F |
- remove an obsolete initialization from ecco_cost_init_barfiles.F |
| 628 |
- fix some problems within never used ifdefs to make the code compile |
- fix some problems within never used ifdefs to make the code compile |
| 629 |
o pkg/obcs: |
o pkg/obcs: |
| 630 |
- Refine Interior mask definition to work with more complex OB (e.g. |
- Refine Interior mask definition to work with more complex OB (e.g. |
| 631 |
if OB_Ie < OB_Iw); In case default setting is not sufficient, allows to |
if OB_Ie < OB_Iw); In case default setting is not sufficient, allows to |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch