| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
o pkg/exf/exf_bulk_largeyeager04.F: rewrite for better vectorization, changes |
o pkg/obcs: |
| 8 |
|
writing sections with globalFiles=T does not work: add a STOP for this case. |
| 9 |
|
|
| 10 |
|
checkpoint62m (2010/10/21) |
| 11 |
|
o pkg/seaice: vectorize seaice_solve4temp.F |
| 12 |
|
- move iterations loops outside of i/j-loops |
| 13 |
|
- requires 2D arrays for TB and effConduct |
| 14 |
|
- add 2D iceOrNot to replace HICE_ACTUAL.GT.0, as HICE_ACTUAL is |
| 15 |
|
modified in this routine |
| 16 |
|
- a little bit of clean up, adjusting indentation, etc. |
| 17 |
|
- replaced a few TEN**a by exp(a*log(10.)) in new code for better |
| 18 |
|
performance and '**TWO' by '**2' (because TWO is a float), |
| 19 |
|
replaced ONE, ZERO |
| 20 |
|
o eesupp/src: |
| 21 |
|
fix flow dir for exch1_z_RX_cube, exch1_uv_RX_cube & exch1_bg_RX_cube |
| 22 |
|
o pkg/seaice/seaice_growth.F |
| 23 |
|
Revision 1.89 of seaice_growth.F completes the overall october 2010 revision and |
| 24 |
|
merging process. The merged routine has two branches, and one activates the 'evolution' |
| 25 |
|
branch by setting SEAICE_GROWTH_LEGACY to undef (at the top of the routine for now). |
| 26 |
|
In summary, here is what the '10/10 revision' did consist of |
| 27 |
|
part 1: seaice_growth.F revisions 1.71 to 1.75 |
| 28 |
|
- Preliminary seaice_growth.F clean-up, keeping test results strictly unchanged. |
| 29 |
|
The emphasis here was on improving readability (e.g. by trying to use meaningful |
| 30 |
|
variable names) and modularity (e.g. by adding arrays to store heff etc. updates). |
| 31 |
|
part 1.5: |
| 32 |
|
- revising the lab_sea experiment to make it a more useful (i.e. stable |
| 33 |
|
and representative of an actual model run). This was done by generating a |
| 34 |
|
(winter) pickup to start from, switching back the main experiment dynamic |
| 35 |
|
solver from evp to lsr, having one of the experiments use the free drift solution. |
| 36 |
|
part 2: seaice_growth.F revisions 1.76 to 1.85 |
| 37 |
|
- Sorting out hard-coded constants that prevented heat and fresh water conservation. |
| 38 |
|
- Sorting out the various fields units and sign (set early on and reset at the end) |
| 39 |
|
to avoid numerous scalings/re-scalings. By v1.85 the basic unit for ice, heat and |
| 40 |
|
fresh water stock is 'effective ice meters', and >0 implies more ice/snow. |
| 41 |
|
- Using tendency terms arrays (d_HEFF* etc.) to alleviate remaining code locks, |
| 42 |
|
and simplifying logical expressions to further improve readibility. |
| 43 |
|
part 3: seaice_growth.F revisions 1.86 to 1.89 |
| 44 |
|
- Re-organize the blocks of code more logically. |
| 45 |
|
- Merging the '_if.F' pieces that add something new. |
| 46 |
|
o pkg/thsice: |
| 47 |
|
- vectorize thsice_solve4temp and thsice_get_exf. |
| 48 |
|
Problem: thsice_solve4temp has an unvectorizable statement that |
| 49 |
|
might also be problematic for TAF |
| 50 |
|
- thsice_get_exf: add the ALLOW_BULK_LARGEYEAGER04 CPP-flag. This |
| 51 |
|
does not change the verifcation experiment, but will change all |
| 52 |
|
experiments that have this flag undefined (not tested in verification); |
| 53 |
|
a little reorganization to save a few 2D fields and recomputations |
| 54 |
|
- 1st step of revisiting thsice adjoint (major recomp. sorted out) |
| 55 |
|
- 2nd step: fix some store dirs |
| 56 |
|
o seems to work somewhat, i.e. using ifort but not g77 |
| 57 |
|
o likely cause are incomplete init. or recomputation |
| 58 |
|
o start verification/global_ocean.cs32x15/input_ad.thsice |
| 59 |
|
o pkg/obcs: add support for exch2 |
| 60 |
|
- the position of the boundary and prescribed values are specified using |
| 61 |
|
a global domain with exch2 facets stacked |
| 62 |
|
- in x for N,S boundaries (like W2_mapIO=-1) |
| 63 |
|
- in y for E,W boundaries (so E,W boundaries do not overlap) |
| 64 |
|
o pkg/mdsio: add support for writing global sections with exch2 |
| 65 |
|
file layout is as for obcs described above: |
| 66 |
|
- for x-z sections, facets are stacked in x (like W2_mapIO=-1) |
| 67 |
|
- for y-z sections, facets are stacked in y |
| 68 |
|
o pkg/thsice: |
| 69 |
|
- change a few routines for better vectorization: thsice_albedo.F, |
| 70 |
|
thsice_step_temp.F, and in thsice_calc_thickn.F. Results are |
| 71 |
|
not affected, but in particular the latter routine has changed |
| 72 |
|
dramatically (not necessarily easier to read now). |
| 73 |
|
- re-arrange calculation in THSICE_SOLVE4TEMP: move outside of i,j loops |
| 74 |
|
iteration loop and call to S/R THSICE_GET_BULKF & THSICE_GET_EXF. |
| 75 |
|
o verification/lab_sea: |
| 76 |
|
- overhaul of the forward model experiments. The main motivation |
| 77 |
|
for this revision is that lab_sea has proven quite fragile (when |
| 78 |
|
changing the sea-ice code, and switching platforms) to a point |
| 79 |
|
when failures were very hard to attribute to specific code problems. |
| 80 |
|
- the suspected reason for this fragility is noise amplification by evp so, |
| 81 |
|
to start with, we decided to replace evp with lsr in the main experiment. |
| 82 |
|
- the input.lsr experiment thus became obsolete and was removed. |
| 83 |
|
- it was replaced with the input.fd experiment that uses an |
| 84 |
|
analytical "free drift" solution as the ice velocity field. |
| 85 |
|
- Taken together, input (lsr), input.fd (free drift) and input.hb87 (evp) |
| 86 |
|
will hopefully allow us to discriminate problems due to dynamic solvers |
| 87 |
|
from problems due to the thermodynamic code. input.salt_plume (lsr) allows |
| 88 |
|
us to test additional options, along with the salt plume package. |
| 89 |
|
- Finally a pickup was generated (at the end of a one year run) to |
| 90 |
|
make the tests more representative of an actual model run. Previously |
| 91 |
|
the tests starting point was a 1m thickness of ice everywhere. |
| 92 |
|
o pkg/seaice: |
| 93 |
|
- introducing S\R seaice_freedrift.F that compute the |
| 94 |
|
analytical solution to an approximate ice momentum |
| 95 |
|
equation (i.e. the simple stress/coriolis balance). |
| 96 |
|
- define SEAICE_ALLOW_FREEDRIFT to trigger the computation |
| 97 |
|
of the free drift velocity field, and enable its use. |
| 98 |
|
To actually use the free drift solution as the model ice |
| 99 |
|
velocity field set SEAICEuseFREEDRIFT to .TRUE. in data.seaice. |
| 100 |
|
o move "useOASIS" from PARAMS.h to EEPARAMS.h and read it from "eedata" |
| 101 |
|
|
| 102 |
|
checkpoint62l (2010/10/04) |
| 103 |
|
o pkg/seaice: |
| 104 |
|
-fix the USE_ORIGINAL_SBI version (for variable freezing point); |
| 105 |
|
-use "celsius2K" in SEAICE_VARIABLE_FREEZING_POINT and in new |
| 106 |
|
version (with USE_ORIGINAL_SBI undef); |
| 107 |
|
o add hooks for new packages OASIS, the package will follow |
| 108 |
|
(hooks exclude the seaice pkg for now) |
| 109 |
|
o pkg/autodiff: ALLOW_AUTODIFF_WHTAPEIO |
| 110 |
|
Option to use mdsio_read_whalos.F/mdsio_write_whalos.F, |
| 111 |
|
rather than mdsio_readvector.F/mdsio_writevector.F, within |
| 112 |
|
adread_adwrite.F to read/write adjoint-related tapes to disk. |
| 113 |
|
o eesupp and pkg/mdsio: ALLOW_WHIO |
| 114 |
|
Option to write/read 2D fields to files including tiles halos. |
| 115 |
|
The main purpose is for adjoint related "tape I/O". |
| 116 |
|
The secondary purpose is for debugging phases. |
| 117 |
|
A word on those rather specifically intended purposes. |
| 118 |
|
The code was meant to be stripped down to the bare minimum. |
| 119 |
|
Typically, there is a unique and basic mapping to the global |
| 120 |
|
buffer (tile by tile, then proc by proc, then level by level), and |
| 121 |
|
byteswaps and meta-files are omitted. Indeed the (*_WH*) code is not |
| 122 |
|
meant to generate user friendly outputs of various shapes and forms. |
| 123 |
|
Rather it is intended, for the knowledgeabale developers, |
| 124 |
|
to be largely independent of the many mdsio options, to allow |
| 125 |
|
outputs of tiles+halos in debugging phases and in adjoint runs, |
| 126 |
|
and to allow some flexibility in tuning (adoint) I/O depending on each |
| 127 |
|
file system behavior. With regard to tuning, most of the potential knobs |
| 128 |
|
(to leave files open, to allocate the I/O indep. of usesinglecpuio, |
| 129 |
|
to specify directories, to specify the typical size of I/O calls, etc.) |
| 130 |
|
are not yet included, and will be added if they prove useful. |
| 131 |
|
o pkg/seaice: |
| 132 |
|
fix uninitialised arrays in USE_ORIGINAL_SBI version of seaice_solve4temp.F |
| 133 |
|
o pkg/seaice: |
| 134 |
|
new S/R seaice_solve4temp.F: this is the merged version of Ian Fenty |
| 135 |
|
code (seaice_budget_ice_if.F) which enable to recover old standard |
| 136 |
|
code (seaice_budget_ice.F) when option USE_ORIGINAL_SBI is defined. |
| 137 |
|
temporary: add "#define USE_ORIGINAL_SBI" at the top of seaice_solve4temp.F. |
| 138 |
|
o model/src (rStar): |
| 139 |
|
use simple average (not area weighted) of rStarFac at U,V point when using |
| 140 |
|
vectorInvariant and selectKEscheme=1,3 (consistent with mom. vertical advection) |
| 141 |
|
update output of exp. fizhi-cs-32x32x40 and fizhi-cs-aqualev20. |
| 142 |
|
|
| 143 |
|
checkpoint62k (2010/09/17) |
| 144 |
|
o adjoint |
| 145 |
|
* changed verification/global_ocean.cs32x15 ; adjoint now tests |
| 146 |
|
Adams-Bashforth 3 + NLFS + RSTAR |
| 147 |
|
* some more modifs required for ECCO-GODAE v4 |
| 148 |
|
o pkg/seaice |
| 149 |
|
add SEAICE_AGE_VOL option to use volume instead of area for |
| 150 |
|
integrating SEAICE_AGE |
| 151 |
|
o model/src: |
| 152 |
|
first check-in of sigma & hybrid-sigma coordinate code ; also includes |
| 153 |
|
non-linear free-surface parts ; but pressure-gradient not yet coded. |
| 154 |
|
o pkg/ptracers: |
| 155 |
|
option for ptracer to convert Salt Relax into additional EmP. |
| 156 |
|
tested in exp. global_ocean.90x40x15.dwnslp (update output) |
| 157 |
|
|
| 158 |
|
checkpoint62j (2010/08/25) |
| 159 |
|
o pkg/ggl90: |
| 160 |
|
other minor changes: remove 3-D temp array gTKE (+ add argument myIter) |
| 161 |
|
o pkg/dic: car_flux.F, phos_flux.F |
| 162 |
|
- reduce number of exp-calls in order to improve performance |
| 163 |
|
- clean up a little (replace fields by their macros, etc., fix |
| 164 |
|
typo in CPP-flag) |
| 165 |
|
o pkg/ggl90: minor changes |
| 166 |
|
- GGL90diffKrS was removed --> always use GGL90diffKr |
| 167 |
|
- GGL90viscAr was removed --> replaced with GGL90viscArU, GGL90viscArV |
| 168 |
|
- hack of mxlMaxFlag=2 --> ensure mixing between first and second level |
| 169 |
|
(commented out for now) |
| 170 |
|
- change in max/min operations to ensure that smoothing is ok |
| 171 |
|
- smoothing of GGL90viscAr was moved to ggl90_calc.F (as done for GGL90diffKr) |
| 172 |
|
- always use diffKrNrT as background profile (i.e. never use diffKr field) |
| 173 |
|
o pkg/cfc: bug fix, AREA(i,j,1,bi,bj) -> AREA(i,j,bi,bj) |
| 174 |
|
o pkg/dic: |
| 175 |
|
- model/src/impldiff.F: if TARGET_NEC_SX, extend loop ranges for better |
| 176 |
|
vectorization |
| 177 |
|
- small bug fix in insol for the unlikely case of a cartesian grid |
| 178 |
|
- towards vectorizing the dic package: bio_export.F, car_flux.F, phos_flux.F |
| 179 |
|
+ now vectorize, which also removes adjoint recomputations; |
| 180 |
|
+ replace integer maksp1 by _RL maskp1 |
| 181 |
|
+ replace a**x by exp(x*log(a)) in phos_flux.F for speed |
| 182 |
|
|
| 183 |
|
checkpoint62i (2010/07/21) |
| 184 |
|
o pkg/flt: |
| 185 |
|
- with OBCS: stop floats which enter the OB region |
| 186 |
|
o model/src: |
| 187 |
|
- use tempVertAdvScheme & saltVertAdvScheme (instead of horizontal ones) |
| 188 |
|
for implicit vertical advection. |
| 189 |
|
o pkg/seaice: |
| 190 |
|
- account for melting in seaice age evolution. |
| 191 |
|
- remove double counting of seaice ridging effect on seaice age. |
| 192 |
|
|
| 193 |
|
checkpoint62h (2010/06/18) |
| 194 |
|
o pkg/exch2: |
| 195 |
|
- remove exch2_*xy_rx files: call was replaced with exch2_*3d_rx(myNz=1). |
| 196 |
|
o tools/genmake2 |
| 197 |
|
- remove "-pdefault" option: redundant with the use of "packages.conf"; |
| 198 |
|
- remove file pkg/pkg_default : set the default as a pkg group |
| 199 |
|
("default_pkg_list") defined in pkg/pkg_groups; |
| 200 |
|
- fix for case pkg/pkg_depend is missing (was hanging before); |
| 201 |
|
- add option "-pgroups" to specify a different pkg_groups than the default. |
| 202 |
|
o verification/adjustment.cs-32x32x1: |
| 203 |
|
add a "minimal" set-up test (code_min & input_min) which only compiles |
| 204 |
|
eesupp/src and the 2 pkgs (exch2 & debug) which don't need model/src & inc. |
| 205 |
|
o tools/genmake2 |
| 206 |
|
- extend pkg_depend rules to model & eesupp (e.g., if model depend on [pkg])) |
| 207 |
|
- fix details of checking for mnc & profile pkg when NetCDF is unavailable. |
| 208 |
|
o pkg/exf: merge exf_bulk_largeyeager04 into exf_bulkformulae because these |
| 209 |
|
files are nearly the same anyway. |
| 210 |
|
Step 1: make exf_bulkformulae look like exf_bulk_largeyeager04: |
| 211 |
|
- redefinition of tau(i,i) (by a factor of ustar) |
| 212 |
|
- 1./exf(Const/T) -> exf(-Const/T) (big change in the results) |
| 213 |
|
- replace rhonil by rhoConstFresh in computation of evap (bug fix) |
| 214 |
|
- replace u/vstress=tau*rd*ws*cw by tau*rd*u/vwind (changes results) |
| 215 |
|
- replace |
| 216 |
|
rd(i,j)= rdn(i,j)/(exf_one - rdn(i,j)/karman*psimh ) |
| 217 |
|
shn = sh(i,j,bi,bj)*rd(i,j)/rdn(i,j) |
| 218 |
|
by |
| 219 |
|
shn = sh(i,j,bi,bj)/(exf_one - rdn(i,j)/karman*psimh ) |
| 220 |
|
(changes results) |
| 221 |
|
-> exf_bulkformulae v1.22, |
| 222 |
|
update verification experiments lab_sea, offline_exf_seaice, seaice_obcs |
| 223 |
|
(lab_sea: output.hb87.txt 1.11, output.lsr.txt 1.25, output.salt_plume.txt 1.13, |
| 224 |
|
output.txt 1.63 |
| 225 |
|
offline_exf_seaice: output.seaicetd.txt 1.7 |
| 226 |
|
seaice_obcs: output.txt 1.10) |
| 227 |
|
Step 2: do the actual merge and remove exf_bulk_largeyeager04.F |
| 228 |
|
-> exf_bulkformulae v1.23, |
| 229 |
|
unfortunately requires updating lab_sea.salt_plume (6 matching digits), |
| 230 |
|
and global_ocean.cs32x15.icedyn (only 11 matching digits) |
| 231 |
|
Also update output_adm of exp. lab_sea (all 4) and offline_exf_seaice. |
| 232 |
|
o adjoint of exch-1: |
| 233 |
|
- pass high-level EXCH S/R through TAF (eesupp/src/exch_ad_diff.list) |
| 234 |
|
(note: was already like this when using EXCH-2) and remove flow dir |
| 235 |
|
and hand-written AD version of high-level EXCH S/R (pkg/autodiff); |
| 236 |
|
- provide flow-dir for low-level exch1 S/R (eesupp/src/exch1_ad.flow); |
| 237 |
|
- update pkg/exch2 diff list. |
| 238 |
|
|
| 239 |
|
checkpoint62g (2010/05/19) |
| 240 |
|
o eesupp/src (exch-1): |
| 241 |
|
- split exch_rx.F into Forward S/R (exch1_rx.F) and Adjoint S/R (exch1_rx_ad.F) |
| 242 |
|
and remove argument "simulationMode"; same thing for all exch_*rx_cube.F |
| 243 |
|
(renamed to exch1_*rx_cube.F). |
| 244 |
|
- change accordingly exch_*_rx.template and AD version in pkg/autodiff |
| 245 |
|
to call new exch1 S/R ; update Makefile and .cvsignore. |
| 246 |
|
- replace call to exch2_xy_rx S/R with exch2_*3d_rx(myNz=1) (will remove |
| 247 |
|
exch2_xy_rx later) |
| 248 |
|
Note: after updating your code, need to run "make clean" in eesupp/src |
| 249 |
|
o test experiment bottom_ctrl_5x5: |
| 250 |
|
new output_adm.txt with fewer grdchk & less monitor output. |
| 251 |
|
o model/src: |
| 252 |
|
remove the call to ini_cori in initialise_varia.F (just keep the usual one |
| 253 |
|
in initialise_fixed.F). More consistent with coriolis & horizontal grid |
| 254 |
|
beeing treated in the same way (ini_grid is not called a 2nd time). |
| 255 |
|
o pkg/exf: |
| 256 |
|
- rewrite exf_bulk_largeyeager04.F for better vectorization, changes |
| 257 |
global_ocean.cs32x15/input.icedyn (11 digits of agreement), updated |
global_ocean.cs32x15/input.icedyn (11 digits of agreement), updated |
| 258 |
|
- fix adjoint (used worked for ALLOW_ATM_WIND defined, works for this now) |
| 259 |
|
- cosmetic changes to exf_bulkformulae.F to make it look more like |
| 260 |
|
exf_bulk_largeyeager04.F |
| 261 |
o eesupp/src (exch-1): |
o eesupp/src (exch-1): |
| 262 |
- Fix AD EXCH code for 2-D domain special cases (Nx=1 or Ny=1). |
- Fix AD EXCH code for 2-D domain special cases (Nx=1 or Ny=1). |
| 263 |
- Separate buffer filling and MPI sending: allow EXCH-1 to work for local |
- Separate buffer filling and MPI sending: allow EXCH-1 to work for local |
| 266 |
- Message mode: move RecvAck setting (indicator of buffer being ready) |
- Message mode: move RecvAck setting (indicator of buffer being ready) |
| 267 |
from send_put to recv_get S/R (was useless before, but not sure if |
from send_put to recv_get S/R (was useless before, but not sure if |
| 268 |
it's much more useful now); |
it's much more useful now); |
| 269 |
- switch the order of sync: MPI-proc 1rst and then threads; |
- Switch the order of sync: MPI-proc 1rst and then threads; |
| 270 |
- take out spin-waiting code (#undef EXCH_USE_SPINNING), use BARRIER instead. |
- take out spin-waiting code (#undef EXCH_USE_SPINNING), use BARRIER instead. |
| 271 |
|
- fix AD code for communication mode ='get' (but not used). |
| 272 |
o model/src: |
o model/src: |
| 273 |
initialise dPhiHydX,dPhiHydY inside calc_grad_phi_hyd.F (so that TAF does |
initialise dPhiHydX,dPhiHydY inside calc_grad_phi_hyd.F (so that TAF does |
| 274 |
not drop it in S/R mddynamics, producing NaN in hs94.1x64x5 AD-test exp). |
not drop it in S/R mddynamics, producing NaN in hs94.1x64x5 AD-test exp). |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch