| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/autodiff: |
| 8 |
|
- include PACKAGES_CONFIG.h in exch*ad.flow & exch*ad.F |
| 9 |
|
(not supposed to be in CPP_OPTIONS.h) to get ALLOW_EXCH2 defined correctly. |
| 10 |
|
+ clean-up comments (_RS is not always real*4) |
| 11 |
|
- fix bug in ADEXCH_UV_3D_RX (without EXCH2, was calling the forward exch S/R) |
| 12 |
|
- add a stop in ADEXCH_UV_AGRID_3D_RX if trying to use it with EXCH2: |
| 13 |
|
was calling a forward exch2, which is wrong ; used in SEAICE & EXF pkgs. |
| 14 |
|
o testreport (AD-tests): |
| 15 |
|
no longer link files from dir "../input" (1rst link files from |
| 16 |
|
"../input_ad.[xx]" if secondary test "xx" and then from "../input_ad") |
| 17 |
|
|
| 18 |
|
checkpoint62f (2010/04/29) |
| 19 |
|
o model/src/the_main_loop.F: |
| 20 |
|
adjust store directives for seaice evp and multicategory according to |
| 21 |
|
pkg/ecco/the_main_loop.F |
| 22 |
|
o adjoint: |
| 23 |
|
global_sum_ad was incomplete (noted many times by many people ;) |
| 24 |
|
nice description by Jean U. as follows: |
| 25 |
|
* allreduce(var) in global_sum.F can be interpreted as |
| 26 |
|
reduce(sum) followed by broadcast of sum. |
| 27 |
|
* The adjoint of that is |
| 28 |
|
sum(adjoint) followed by broadcast(summed adjoint value) |
| 29 |
|
or in other words, allreduce(sum, adjoint vars) |
| 30 |
|
We were missing the sum(adjoint)! |
| 31 |
|
Benign, except(!) for "global" scalars appearing in tile loops (bi,bj) |
| 32 |
|
(noted by J.M. Campin, e.g., in cost_ssh_mean, variable offset). |
| 33 |
|
The fix should produce 16-digit accuracy between |
| 34 |
|
single-CPU multi-tile (e.g. nSx=2, nPx=1) and |
| 35 |
|
multi-CPU single-tile (e.g. nSx=1, nPx-2) |
| 36 |
|
We'll probably change this yet again shortly |
| 37 |
|
o eesupp/src: |
| 38 |
|
- fix global_sum_r4 (wrong from previous modif in Jun 2009; ever used ?) |
| 39 |
|
o pkg/icefront |
| 40 |
|
- ALLOW_SUBGLACIAL_RUNOFF option adds capability for time-evolving |
| 41 |
|
specification of addmass array based on a 2D field, which is added |
| 42 |
|
at bottommost wet level at each horizontal location. |
| 43 |
|
o model/src: |
| 44 |
|
horizontal grid initialisation (other than curvilinear): add code for Exch2 IO |
| 45 |
|
layout; (not always compatible with delX,delY setting; commented out for now). |
| 46 |
|
o pkg/exch2: |
| 47 |
|
change tile to processor setting (case nSy*nPy > 1): allows default model mapping |
| 48 |
|
(myX and myYGlobalLow) to be used for simple (1 facet, no blank tile) config. |
| 49 |
|
|
| 50 |
|
checkpoint62e (2010/04/15) |
| 51 |
|
o pkg/obcs: |
| 52 |
|
- fix wrong index in OBCS_SPONGE_V for Eastern-OB (reported by David Hebert). |
| 53 |
|
o pkg/dic: |
| 54 |
|
-fix bug in fe_chem.F for multi-tile (nSx*nSy > 1) set-up; |
| 55 |
|
(note: not presently tested in any forward verification exp.) |
| 56 |
|
update tutorial_global_oce_biogeo AD output file. |
| 57 |
|
o pkg/exf: |
| 58 |
|
- account for the variation of albedo as a function of zenith angle |
| 59 |
|
by defining ALLOW_ZENITHANGLE in EXF_OPTIONS.h |
| 60 |
|
o build_options: |
| 61 |
|
- rename "linux_ia64_ifort+mpi_ice_nas" to "linux_amd64_ifort+mpi_ice_nas" |
| 62 |
|
o pkg/dic: |
| 63 |
|
change DIC atmos-CO2 box (method 3, dic_int1=3) initialisation & restart: |
| 64 |
|
- use binary pickup file for restart; |
| 65 |
|
- initialise atmos-CO2 box from dic_pCO2 parameter; |
| 66 |
|
- fix multi-threaded. |
| 67 |
|
o pkg/rbcs: |
| 68 |
|
- clean-up RBCS code: add RBCS_OPTIONS.h file ; fix multi-threaded ; |
| 69 |
|
change (+ fix IO calls) type of array RBC_mask from _RL to _RS. |
| 70 |
|
- add RBCS to exp4 passive tracer 01 (rbcs was previously untested) |
| 71 |
|
and update output.txt |
| 72 |
|
o pkg/kpp: |
| 73 |
|
- add diagnostics for KPP non-local flux of Temp, Salinity and pTracers; |
| 74 |
|
- change diagnostic of KPP non-local term: output average of KPPghat*KPPdiffKzS |
| 75 |
|
(= ratio of KPP non-local (salt) flux relative to surface-flux) when |
| 76 |
|
using pkg/timeave & pkg/diagnostics (diag 'KPPghatK' replaces 'KPPghat '); |
| 77 |
|
- change pkg/offline to read-in average KPPghat*KPPdiffKzS from file |
| 78 |
|
KPP_ghatKFile (instead of the average of KPPghat from file KPP_ghatFile). |
| 79 |
|
o pkg/offline: |
| 80 |
|
fix bug in S/R OFFLINE_FIELDS_LOAD regarding surfaceForcing conversion factor |
| 81 |
|
(bug was added in version 1.10 on 2007-08-23). |
| 82 |
|
o pkg/offline: |
| 83 |
|
- no need to specify periodicExternalForcing, etc ... to use offline pack |
| 84 |
|
- offline input files no longer just single prec --> parameter offlineLoadPrec |
| 85 |
|
o verification/lab_sea: |
| 86 |
|
change AD test to multi-tile setup and update all 4 AD output. |
| 87 |
|
NOTE: while cost function values remain very similar, |
| 88 |
|
gradients are very different, although gradient checks are self-consistent |
| 89 |
|
Should try to get to the bottom of this (cost function summation order?) |
| 90 |
o pkg/dic: |
o pkg/dic: |
| 91 |
in carbon_chem.F, replace log10 (AUTODIFF) with explicit form to avoid |
in carbon_chem.F, replace log10 (AUTODIFF) with explicit form to avoid |
| 92 |
a weakness of TAF that drops part of double precision in log10 derivative. |
a weakness of TAF that drops part of double precision in log10 derivative. |
| 93 |
|
<= changes removed since problem has been fixed in current TAF version 1.9.71 |
| 94 |
update AD output of exp. tutorial_dic_adjoffline & tutorial_global_oce_biogeo. |
update AD output of exp. tutorial_dic_adjoffline & tutorial_global_oce_biogeo. |
| 95 |
o pkg/ecco: |
o pkg/ecco: |
| 96 |
add missing "_d 0" in cost_readers.F, cost_readtopex.F & cost_readtopexmean.F |
add missing "_d 0" in cost_readers.F, cost_readtopex.F & cost_readtopexmean.F |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch