| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o adjoint: adding two new verification experiments |
| 8 |
|
* tutorial_global_biogeo: an online dic sensitivity experiment |
| 9 |
|
(work with G. Forget) |
| 10 |
|
* tutorial_dic_adjoffline: an offline dic sensitivity experiment |
| 11 |
|
(an update of the Dutkiewicz et al., 2006 paper) |
| 12 |
|
Both use the same CO2FLUX cost function, but different controls |
| 13 |
|
Gradient checks look good, but some recomp. could still be traightened out |
| 14 |
|
Should add xx_dic control variable to test at some point |
| 15 |
|
o model/src: |
| 16 |
|
add run-time parameters to check and/or mask initial Temp & Salt |
| 17 |
|
o pkg/ptracers: |
| 18 |
|
apply zonal filter (if used) to all passive tracers |
| 19 |
|
|
| 20 |
|
checkpoint61w |
| 21 |
|
o adjoint: |
| 22 |
|
* update and finish work on adjoint of dic package (G. Forget) |
| 23 |
|
* start adjoint of offline package |
| 24 |
|
* bug fix for cube-sphere TLM code (active_file_g.F) |
| 25 |
|
o tutorial_global_oce_optim: |
| 26 |
|
now tested with 4 tiles (change data.grdchk and update output_adm.txt) |
| 27 |
|
and add SIZE.h_mpi for MPI testing |
| 28 |
|
o pkg autodiff |
| 29 |
|
- fix bug in autodiff_restore |
| 30 |
|
- make genmake2 remove comments and empty lines from ad_input_code.f in |
| 31 |
|
order to reduce file size (new script file remove_comments_sed) |
| 32 |
|
o allows to specify vertical profile of vertical viscosity (viscArNr) |
| 33 |
|
o pkg autodiff |
| 34 |
|
autodiff_ini_model_io: comment out writing of grid information to netcdf |
| 35 |
|
files, because at this time the grid fields are a bunch of zeros |
| 36 |
|
(this is analogous to ini_mnc_vars.F) |
| 37 |
|
o pkg seaice/autodiff: |
| 38 |
|
left-over from removing the 3-time-level fields: |
| 39 |
|
- small rearrangement of common blocks (SEAICE.h) |
| 40 |
|
- fix field declaration in order to get meaningful output in |
| 41 |
|
adseaice.*.nc (adcommon.h) |
| 42 |
|
o pkg obcs: |
| 43 |
|
- go through NH code only if nonHydrostatic=T |
| 44 |
|
- fix restart for Orlanski (Hydrostatic; still to fix NH+Orlanski restart) |
| 45 |
|
- move call to OBCS_CALC before SEAICE_MODEL which needs seaice-obc fields |
| 46 |
|
=> Update output of experiment seaice_obcs |
| 47 |
|
- useOBCSbalance: code is wrong with multi-tile / proc: add a stop. |
| 48 |
|
- fix NH+Orlanski restart (add wvel OBC value in pickup file) |
| 49 |
|
- fix restart for useOBCSprescribe + useEXF |
| 50 |
|
o pkg ctrl |
| 51 |
|
- make obcs as control parameter work also with useSingleCPUio |
| 52 |
|
- replace a few sny and snx by Ny and Nx to be consistent with |
| 53 |
|
ctrl_set_globfld_x/yz.F |
| 54 |
|
o pkg seaice |
| 55 |
|
- re-introduce global field frWtrAtm for the case of |
| 56 |
|
ALLOW_MEAN_SFLUX_COST_CONTRIBUTION defined (SEAICE.h, seaice_growth.F) |
| 57 |
|
- catch the case of an empty filename in seaice_cost_init_fixed.F |
| 58 |
|
o pkg ecco: |
| 59 |
|
- small bug fixes in the_main_loop |
| 60 |
|
. fix order of monitor arguments |
| 61 |
|
. change SEAICE_MULTILEVEL to SEAICE_MULTICATEGORY |
| 62 |
|
. move include DYNVARS.h up outside the ALLOW_AUTODIFF_TAMC block so |
| 63 |
|
that ALLOW_ECCO_FORWARD_RUN works with NONLIN_FRSURF |
| 64 |
|
- replace cos(yc*deg2rad) by _rA in cost_mean_heat/saltflux.F, fix the |
| 65 |
|
imbalance diagnostics for wmean_h/sflux = 0 |
| 66 |
|
- add actual values to f_obcsn/s/w/e in ecco_cost_final.F |
| 67 |
|
- catch the case of empty filenames in ecco_cost_init_fixed.F |
| 68 |
|
and ecco_readparms.F |
| 69 |
|
- fix the logic of wsalt=0.and.wsalt2=0 to wsalt=0.or.wsalt2=0 (and theta) |
| 70 |
|
to make this statement meaningfull in ecco_cost_weights.F |
| 71 |
|
o pkg zonal_filt: |
| 72 |
|
- change ZONAL_FILTER S/R interface (allows to filter 2-D fields) |
| 73 |
|
- when using rStar, filter uVel*hFacW instead of uVel |
| 74 |
|
(tested without topography: fix a Pb of growing instability with NLFS) |
| 75 |
|
o pkg/aim/thsice: |
| 76 |
|
-Add capacity to read a Q-Flux to be applied in slab-mixed layer thsice_slab_ocean.F |
| 77 |
|
(works as SST restoring) |
| 78 |
|
o pkg/thsice: |
| 79 |
|
-add specific parameter for salt restoring in slab mixed-layer |
| 80 |
|
(by default equal to the temperature restoring) |
| 81 |
|
|
| 82 |
|
checkpoint61v |
| 83 |
|
o pkg/kpp: |
| 84 |
|
-add double diffusive contributions as a hack, turned off by default |
| 85 |
|
for now, and the code can be excluded with a CPP-flag |
| 86 |
|
EXCLUDE_KPP_DOUBLEDIFF just as EXCLUDE_KPP_SHEAR_MIX |
| 87 |
|
-add a verification experiments to "vermix" to test this code |
| 88 |
|
o pkg/mom_common: |
| 89 |
|
Move computation of length scales to mom_init_fixed.F (avoid recomputation |
| 90 |
|
at each time-steps*levels). |
| 91 |
|
o pkg/layers: |
| 92 |
|
Created a new package for computing volume fluxes in temperature or |
| 93 |
|
[not yet implemented] density layers, e.g. for calculating residual |
| 94 |
|
overturning circulations. |
| 95 |
|
o pkg/diagnostics: |
| 96 |
|
implement a RS type version for the set of DIAGNOSTICS-FILL subroutines |
| 97 |
|
o fix few RS/RL type mismatch (check with ifort 11.1 "-warn all" option) |
| 98 |
|
o pkg/mdsio (& pkg/rw): rework high level S/R interface: |
| 99 |
|
To avoid mixing type (RS/RL) of input/output array argument, |
| 100 |
|
replace single mixed-type array with a pair from each type (RS/RL). |
| 101 |
|
o setting pickupSuff force to start from a pickup (even if nIter0=0): this |
| 102 |
|
is now implemented for all pkgs (previously only done for the main pickup) |
| 103 |
|
|
| 104 |
|
checkpoint61u |
| 105 |
|
o pkg/obcs: |
| 106 |
|
- change OB?eta from _RS to _RL and put them into a separate commen block |
| 107 |
|
- add code to read OB?eta from a file via obcs_prescribe_read: the code |
| 108 |
|
compiles and does not destroy any other experiments, the data is read |
| 109 |
|
properly, but the code is not tested in actual applications |
| 110 |
|
o ini_mnc_vars.F: if available (ALLOW_CAL), use startTime_1 and 2 to |
| 111 |
|
create a meaningful unit attribute for the time coordinate variable |
| 112 |
|
o pkg/ebm: add plenty of missing "_d 0" ; |
| 113 |
|
update results of experiment global_ocean_ebm (fwd + adjoint tests) |
| 114 |
|
Notes: several pieces of code only works for (very) specific set up |
| 115 |
|
(domain size, lat range, etc ...); should be documented & stop if one |
| 116 |
|
of those assumptions is not meet. |
| 117 |
|
o pkg/seaice: add missing "_d 0" in HSNOW initialisation |
| 118 |
|
update results of experiments: lab_sea (3 fwd tests + 2 adjoint tests) |
| 119 |
|
and offline_exf_seaice (seaicetd + adjoint). |
| 120 |
|
o add missing "_d 0" in ShortWave flux penetration (S/R SWFRAC): |
| 121 |
|
update results of experiments: lab_sea (4 fwd tests + 3 adjoint), |
| 122 |
|
seaice_obcs, global_ocean.cs32x15 (icedyn & thsice) and natl_box (x2). |
| 123 |
|
o few changes to pass when compiling with strick checking of arguments |
| 124 |
|
across S/R (allow to find few bugs in S/R calls). |
| 125 |
|
o pkg/seaice: |
| 126 |
|
- seaice_evp: move if-statement out of loop (TEM) at the cost of 11 new |
| 127 |
|
2d-fields, for slightly better performance |
| 128 |
|
|
| 129 |
|
checkpoint61t |
| 130 |
|
o pkg/seaice: |
| 131 |
|
- remove unused variables in seaice_evp |
| 132 |
|
- reduce number of SQRT in seaice_evp and seaice_calc_viscosities |
| 133 |
|
o eeset_parms.F, open_copy_data_file.F & ini_parms.F: |
| 134 |
|
named file replacing SCRATCH files (for TARGET_BGL & TARGET_CRAYXT): |
| 135 |
|
each processor opens a different file (a fix from Matt). |
| 136 |
|
o cg2d: |
| 137 |
|
use simple EXCH (overlap size = 1 and ignore corners), like in cg3d.F : |
| 138 |
|
this reduces number of EXCH calls by 2 when using exch2. |
| 139 |
|
For now, keep previous size array for gc2d_nsa.F to avoid Pb with store |
| 140 |
|
directives and missing simple EXCH (exch_s3d_rx) adjoint code. |
| 141 |
|
o pkg/thsice: |
| 142 |
|
add code for Near Infra-Red albedo (from Jeff) |
| 143 |
|
(turned on with run-time flag: thSIce_calc_albNIR, in data.ice). |
| 144 |
|
o ini_model_io: |
| 145 |
|
move (from packages_readparms.F & initialise_fixed.F) to ini_model_io.F |
| 146 |
|
MNC & MONITOR initialisation calls; move MNC calls from {pkg}_readparms.F |
| 147 |
|
to {pkg}_init_fixed.F for {pkg}= kpp, seaice & shelfice. |
| 148 |
|
|
| 149 |
|
checkpoint61s |
| 150 |
|
o pkg/exch2 (exch2_rxN_cube*): |
| 151 |
|
remove last BARRIER (no need to synchronise after getting data from shared |
| 152 |
|
buffer (get) as long as any change to buffer (put,recv) is between BARRIER) |
| 153 |
|
o change tiling of natl_box (from 2 to 4 tiles) to get it tested with MPI+MTH |
| 154 |
|
and generate new output (for the 2 tests) using default rotationPeriod. |
| 155 |
|
o pkg/exch2: |
| 156 |
|
- always call exch2_*_cube, not exch-1 anymore, if useCubedSphereExchange=F |
| 157 |
|
(was already the case with AUTODIFF_EXCH2 defined) |
| 158 |
|
- add bj in exch2 arrays and S/R. |
| 159 |
|
- can now use pkg/exch2 for regular (non CS) set-up; switch test experiment |
| 160 |
|
MLAdjust to exch2 (identical results except with MPI -> truncation diff); |
| 161 |
|
o add pkg/longstep for ptracer timestep a multiple of U/V/T/S timestep |
| 162 |
|
- adds deltaT argument to the subroutines TIMESTEP_TRACER DWNSLP_APPLY |
| 163 |
|
GAD_ADVECTION GAD_CALC_RHS GAD_IMPLICIT_R GAD_SOM_ADVECT |
| 164 |
|
- verification experiment natl_box.longstep |
| 165 |
|
o build_options: ifort+mpi_aces optfile (following Constantinos advise): |
| 166 |
|
allow different versions of ifort (8 or 9) and different versions |
| 167 |
|
of mpi (mpich or mpich2) to be used with the same optfile. |
| 168 |
|
requires to load a netcdf module and set MPI_INC_DIR (see comments inside |
| 169 |
|
optfile). Change testing scripts (example_scripts/ACESgrid) accordingly. |
| 170 |
|
o pkg/seaice: |
| 171 |
|
fix previous modif (3-level field removed) for old-pickup reading |
| 172 |
|
|
| 173 |
|
checkpoint61r |
| 174 |
|
o pkg/seaice: |
| 175 |
|
- clean up the 3-time levels of UICE,VICE,HEFF,AREA in three steps: |
| 176 |
|
1. introduce fields for time step (N-1) |
| 177 |
|
2. do not use levels 2 and 3 anymore (but keep them) |
| 178 |
|
3. replace 3D versions of UICE,VICE,HEFF,AREA by 2D versions. This |
| 179 |
|
includes changes to pkg/thsice/thsice_get_velocity.F, |
| 180 |
|
model/src/external_forcing_surf.F, pkg/obcs/obcs_apply_seaice.F, and |
| 181 |
|
pkg/obcs/obcs_apply_uvice.F. |
| 182 |
|
- completely remove code for leap-frog time stepping for second order |
| 183 |
|
advection |
| 184 |
|
- adjusted adjoint accordingly; |
| 185 |
|
gradient checks have improved by an order of magnitude! |
| 186 |
|
|
| 187 |
|
checkpoint61q |
| 188 |
|
o pkg/seaice: fix bug in free slip boundary conditons for LSOR solver |
| 189 |
|
- the boundary conditions along open boundaries are unclear, because the |
| 190 |
|
associated masks are set to zero and are thus treated as closed when |
| 191 |
|
applying the slip-boundary conditions. |
| 192 |
|
- move initialisation of grid variables from seaice_init_varia to _fixed |
| 193 |
|
o adding doc/diags_changes.txt |
| 194 |
|
o model/src: |
| 195 |
|
do_the_model_io: rename few pkg S/R which are called from do_the_model_io, |
| 196 |
|
to avoid "_diags" naming if no relation to pkg/diagnostics. |
| 197 |
|
ini_theta,ini_salt: fix (at least compile the code) reading from NetCDF |
| 198 |
|
file and only call PLOT_FIELD_XYZ if debugMode=T. |
| 199 |
|
remove few PLOT_FIELD_XY calls outside initialisation. |
| 200 |
|
remove few unnecessary BARRIER. |
| 201 |
|
o pkg/salt_plume: add SaltPlumeSouthernOcean to allow disabling |
| 202 |
|
of salt_plume package in Southern Ocean |
| 203 |
|
o pkg/thsice: |
| 204 |
|
- fix hOceMxL in overlap (needed for sea-ice advection); |
| 205 |
|
update output of experiment global_ocean.cs32x15.icedyn. |
| 206 |
|
o pkg/seaice: |
| 207 |
|
- make the (placeholder-)tracer IceAge a little more meaningful |
| 208 |
|
by avoiding ridging of age due to convergent ice flow |
| 209 |
|
- add diagnostics for surface temperature, atmospheric and oceanic |
| 210 |
|
heat flux, and atmospheric and oceanic ice growth |
| 211 |
|
|
| 212 |
|
checkpoint61p |
| 213 |
|
o eesupp (global_max & global_sum): |
| 214 |
|
- add one more element to buffer (start at index 0) for GL_MAX/SUM output; |
| 215 |
|
- remove starting & endding barrier (no longer needed) |
| 216 |
|
o pkg/mdsio, writelocal: |
| 217 |
|
works also in multi-threaded when LOCBIN_IO_THREAD_SAFE is undefined |
| 218 |
|
(remove the STOP): uses shared buffer IO to store data from all threads |
| 219 |
|
and then let master-thread write nThreads tiles. |
| 220 |
|
o pkg/mdsio (read/write field): |
| 221 |
|
- tiled IO done in 1 piece (all levels at a time); |
| 222 |
|
- new header file "MDSIO_BUFF_3D.h" with 3-D buffers. |
| 223 |
|
- multi-threaded: allow to read/write local (non-shared) array |
| 224 |
|
(was already working with singleCpuIO ; now works also without); |
| 225 |
|
=> no longer needs barrier call after reading a file (added inside |
| 226 |
|
mds_read/write field). |
| 227 |
|
- move barrier calls outside gather/scatter_2d to mds_read/write_field |
| 228 |
|
o pkg/obcs/exf |
| 229 |
|
- exf_getffieldrec.F: add a few ". _d 0" and |
| 230 |
|
add code to catch the case fldperiod = 0. |
| 231 |
|
- obcs_precribe_read.F: change if statements so that they match |
| 232 |
|
the variable type (_RL) |
| 233 |
|
- add a separate exf_iprec_obcs to exf_set_obcs (by default equal to |
| 234 |
|
exf_iprec) as part of namelist EXF_NML_01 |
| 235 |
|
o pkg/mdsio: |
| 236 |
|
- read/write tiled (local) files: read/write 1-level tile chunk at a time |
| 237 |
|
(instead of segment of length sNx); expected to speed up tiled IO. |
| 238 |
|
o pkg/exch2: |
| 239 |
|
- take buffer copy from/to array out of S/R exch2_send/recv into new |
| 240 |
|
S/R exch2_put/get ; Exch of local variable now works with MPI+MTH |
| 241 |
|
(tested by removing commom block statement in SOLVE_FOR_PRESSURE.h). |
| 242 |
|
- ad version of send/recv no longer needed (but needs exch2_ad_put/ad_get) |
| 243 |
|
- simplify argument list of S/R exch2_get_uv_bounds and exch2_get_scal_bounds |
| 244 |
|
(which replaces exch2_get_recv_bounds & exch2_get_send_bounds) by |
| 245 |
|
including Topology header file (and common blocks). |
| 246 |
|
- implement EXCH_IGNORE_CORNERS in scalar exchange (rx1); |
| 247 |
|
remove 2nd exch call in exch2_s3d_rx (no longer needed). |
| 248 |
|
- document S/R arg. list (+ update some comments) |
| 249 |
|
o pkg/seaice: |
| 250 |
|
- added SEAICE_CLIM_AIR code, which permits modulation of surface air |
| 251 |
|
temperature and humidity over sea ice based on climatological values. |
| 252 |
|
- clean up computation of Hibler+Bryan (1987) stress coupling for the case |
| 253 |
|
of LSR (this change is expected to change the results slightly because now |
| 254 |
|
it uses slightly difference moduli from the second last LSR solution, but |
| 255 |
|
that is more consistent with the stress computations; this part of the code |
| 256 |
|
is not tested in the verification experiments) |
| 257 |
|
- fix diagnostics for flux of ice in case of B-grid |
| 258 |
|
- turn strain rates eij and press into global fields within global |
| 259 |
|
common block in SEAICE.h for more straighforward diagnostics |
| 260 |
|
- fix diagnostics for principal stress components, press, zeta, eta |
| 261 |
|
to give something meaning full |
| 262 |
|
o change tiling of global_ocean.cs32x15 (12 tiles, 32x16) and generate |
| 263 |
|
new output (all 4 tests) using default rotationPeriod. |
| 264 |
|
o pkg KPP: |
| 265 |
|
- add flag (LimitHblStable) to avoid limiting BL depth under stable conditions |
| 266 |
|
- fix vertical indices in RI_IWMIX (match between KPP grid from 0 to Nr+1 |
| 267 |
|
and normal grid from 1 to Nr) |
| 268 |
|
o Fix computations of L4rdt in mom_calc_visc.F |
| 269 |
|
o eesupp: |
| 270 |
|
new S/R ALL_PROC_DIE (like EEDIE, without irrelevant threads err msg): |
| 271 |
|
should be called before a "stop" if we know that all process are going |
| 272 |
|
to stop; if one Proc does call this S/R, will hang in MPI_FINALISE. |
| 273 |
|
|
| 274 |
|
checkpoint61o |
| 275 |
|
o pkg/exch2: change check_depths to issue just a warning (instead of error+stop) |
| 276 |
|
o model/src/ini_curvilinear_grid.F: |
| 277 |
|
compute angleSin/CosC when they are not read from a file |
| 278 |
|
o pkg/seaice: |
| 279 |
|
add pseudo time stepping for LSOR |
| 280 |
|
o pkg/exch2: |
| 281 |
|
temporary fix for exch2_s3d_rx; update results of exp. hs94.cs-32x32x5.impIGW |
| 282 |
|
o pkg/seaice: |
| 283 |
|
Adding separate sea ice albedo, drag coefficients, and HO in Southern |
| 284 |
|
Ocean from those in Arctic Ocean. See *_south in SEAICE_PARAMS.h |
| 285 |
|
o SingleCpuIO: |
| 286 |
|
fix bug put before chkp61n (May 11), when more than 2 MPI cpu are used. |
| 287 |
|
o pkg/seaice: |
| 288 |
|
put exchanged variable in (local) common block for MPI+Multi-Threads |
| 289 |
|
to work (necessary with exch1, and for now with exch2 too). |
| 290 |
|
o verification: to get more experiments tested with mpi, mth and mpi+mth, |
| 291 |
|
change tiling of: |
| 292 |
|
aim.5l_Equatorial_Channel, aim.5l_LatLon, dome, exp4, global_ocean.90x40x15, |
| 293 |
|
hs94.cs-32x32x5, MLAdjust, offline_exf_seaice & tutorial_plume_on_slope |
| 294 |
|
update output of exp: |
| 295 |
|
exp4, global_ocean.90x40x15(+.dwslp), MLAdjust(all 5), |
| 296 |
|
tutorial_plume_on_slope and hs94.cs-32x32x5 (use default rotationPeriod) |
| 297 |
|
+ ideal_2D_ocean: use default rotation period + test Global_Sum_SINGLECPU |
| 298 |
|
(note: output.txt generated on faulks using only 1 tile) |
| 299 |
|
o eesupp & mdsio (SingleCpuIO): |
| 300 |
|
- remove MISSING_TILE_IO (from MDSIO_OPTIONS.h), replaced by run-time |
| 301 |
|
parameter "W2_useE2ioLayOut" (read from file "data.exch2"). |
| 302 |
|
Note: was not effective for globalFile & useSingleCpuIO=F; now fixed. |
| 303 |
|
- move MDSIO_SCPU.h (pkg/mdsio) to EEBUFF_SCPU.h (eesupp/inc). |
| 304 |
|
- fix GLOBAL_SUM_SINGLECPU when using Exch2; re-use same buffers and same |
| 305 |
|
gather/scatter S/R as with SingleCpuIO (=> 1 less 2D global RL array). |
| 306 |
|
o pkg/exch2: |
| 307 |
|
- new code to set-up W2-Exch2 topology (replace matlab-topology-generator): |
| 308 |
|
read parameter file "data.exch2" if it exists; otherwise try default regular |
| 309 |
|
cube without blank-tile; new header file "W2_EXCH2_SIZE.h"; |
| 310 |
|
- update matlab-topology-generator (exch2_setup_cs6_print.m) to be compatible |
| 311 |
|
with new code (not to be used, just as a backup solution). |
| 312 |
|
- add examples (e.g., for lat-lon-cap_120) of parameter file "data.exch2" |
| 313 |
|
in utils/exch2/input. |
| 314 |
|
|
| 315 |
|
checkpoint61n |
| 316 |
|
o eesupp & mdsio (SingleCpuIO): |
| 317 |
|
- move mapping to global io-buffer inside gather_2d/scater_2d: this save |
| 318 |
|
memory (1 less 2D global RL array); skip 1 buffer copy; and only send/ |
| 319 |
|
receive real*4 array (instead of real*8) to read/write 32.bit files. |
| 320 |
|
(new template for gather_2d/scater_2d, new set of S/R MDS_PASS_R4,8toRL,S |
| 321 |
|
and remove new mapping S/R) |
| 322 |
|
o pkg/mdsio: in preparation for topology-generator within pkg/exch2: |
| 323 |
|
- Change declaration of SingleCpuIO buffer, reduced to only 1 dim.: |
| 324 |
|
xyBuffer_size, which is set to W2_ioBufferSize from W2_EXCH2_PARAMS.h |
| 325 |
|
when using exch2. Add S/R to map global io-buffer to global model array. |
| 326 |
|
- uses exch2_global_Nx,y instead of exch2_domain_nxt,nyt. |
| 327 |
|
|
| 328 |
|
checkpoint61m |
| 329 |
|
o write_utils : change WRITE_1D_R8 to WRITE_1D_RL |
| 330 |
|
and add 3 other S/R for other types (R4,R8,RS). |
| 331 |
|
Change calls to WRITE_0D/1D_R[4,8,S,L] to match the type of argument. |
| 332 |
|
o eesupp/inc/CPP_EEMACROS.h (EXCH & GLOBAL_SUM/MAX macros): |
| 333 |
|
- ensure suffix (_R4,_R8,_RS,_RL) correspondance between macro and S/R ; |
| 334 |
|
- reduce number of macro definitions (keep only those which are used); |
| 335 |
|
can always call directly the corrresponding S/R if needed. |
| 336 |
|
- everywhere in the code: change macros (EXCH & GLOBAL_SUM/MAX) suffix |
| 337 |
|
_R4/_R8 to _RS/_RL when applied to _RS/_RL variable. |
| 338 |
|
Fixed wrong type of arg in: |
| 339 |
|
atm2d/put_ocnvars.F cheapaml/cheapaml.F ocn_compon_interf/ocn_apply_import.F |
| 340 |
|
ctrl/ctrl_map_ini_ecco.F seaice/seaice_do_diags.F seaice/seaice_model.F |
| 341 |
|
To fix: global_sum of var in common block is wrong (multi-threaded) in: |
| 342 |
|
dic/dic_atmos.F ebm/ebm_area_t.F ebm/ebm_zonalmean.F sbo/sbo_calc.F |
| 343 |
|
To fix: aim_v23/aim_do_co2.F (BARRIER & GLOBAL_SUM within bi,bj loops) |
| 344 |
|
o adjustment.cs-32x32x1: test "blank tiles" when compiling with mpi; 2nd |
| 345 |
|
"nlfs" mpi test is going to stop when checking for unconnected tile egdes. |
| 346 |
|
o eesupp/src: new S/R to stop everyone when 1 (or more) Proc. find an error |
| 347 |
|
o pkg/exch2: new S/R EXCH2_CHECK_DEPTHS to check that unconnected tile |
| 348 |
|
edges are closed (zero depth); might happen with "blank tiles"; |
| 349 |
|
for now, disabled if using OBCS. |
| 350 |
|
o tools/gemake2: delete modifs from March 27-29 2009 (with option "-mpi": |
| 351 |
|
link *_mpi files from "MODS" dir) to return to a strait-forward behavior. |
| 352 |
|
o move read_write.F to write_utils.F ; new parameter (maxLengthPrt1D) |
| 353 |
|
to reduce length of 1.D array print in STDOUT. |
| 354 |
|
o adjustment.cs-32x32x1: changed to oceanic test with 1 continent |
| 355 |
|
+ use 48 tiles (16x8): this will allow to test "blank tiles". |
| 356 |
|
o start to test MPI + multi-threaded (change testreport to skip tests |
| 357 |
|
where number of tiles do not match). |
| 358 |
|
o genmake2: add option "-omp" to turn on Open-MP ; |
| 359 |
|
passed to testreport (if using -mth) ; merge few (*+mth) optfiles. |
| 360 |
|
o pkg/exch2 (+ utils/exch2): ignore blank tiles (instead of removing them) |
| 361 |
|
and keep the original tile numbering. Note: compatible with old |
| 362 |
|
W2_EXCH2_TOPOLOGY.h & w2_e2setup.F topology files. |
| 363 |
|
|
| 364 |
|
checkpoint61l |
| 365 |
|
o Overlaps had been forgotten in calculating ijk keys : fixed |
| 366 |
|
o fix cyrus makedepend for gcc 4.4 |
| 367 |
|
o experiment fizhi-cs-aqualev20: |
| 368 |
|
switching to new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE) |
| 369 |
|
and generate new output. Note: new output is much closer to the old |
| 370 |
|
one (v1.8) generated with pgf77 -O2 on Mar 14 2007 than it is from |
| 371 |
|
the previous one (v1.9) generated with pgf77 -O0 on Jun 13 2007. |
| 372 |
|
o pkg/fizhi: |
| 373 |
|
- change to avoid indices going deliberately over array-bounds |
| 374 |
|
- remove unnecessary MPI stuff |
| 375 |
|
- perpetual spring equinox with "#define FIZHI_USE_FIXED_DAY" |
| 376 |
|
- new version of S/R GETPWHERE available with #define TRY_NEW_GETPWHERE: |
| 377 |
|
does not go over array-bounds and therefore returns reliable output. |
| 378 |
|
- in fizhi_driver.F & fizhi_turb.F, fix "get_alarm" calls: |
| 379 |
|
this S/R has 4 output arguments, which are used inside "get_alarm"; |
| 380 |
|
when it is called with the same variable "ndum" in place of several |
| 381 |
|
output arguments, this produces weird side effect inside "get_alarm" |
| 382 |
|
(e.g., datein=dates(n) is overwritten by timein=times(n) since both |
| 383 |
|
datein & timein, resp. 2nd and 3rd arg., are pointed to the same "ndum" |
| 384 |
|
address) and produces error. |
| 385 |
|
o tools/gemake2: (March 27-29 2009) |
| 386 |
|
with option "-mpi": link *_mpi files from "MODS" dir (this is what |
| 387 |
|
testreport does). |
| 388 |
|
o lab_sea experiment: change from 2x1 tiles to 2x2 tiles and regenerate output |
| 389 |
|
o pkg/seaice: fix bug in new version of S/R SEAICE_LSR.F: |
| 390 |
|
update lab_sea.lsr & lab_sea.salt_plume results |
| 391 |
|
o pkg/seaice: |
| 392 |
|
Major overhaul of the LSOR solver: change discretization from original |
| 393 |
|
finite differences to finite volume. The old routine is still in the |
| 394 |
|
file seaice_lsr.F and can be turned on with the CPP-flag |
| 395 |
|
SEAICE_OLD_AND_BAD_DISCRETIZATION |
| 396 |
|
Along with this change, the discretization of the strain rates is changed. |
| 397 |
|
The same flag turns on the old discretization in seaice_calc_strainrates.F |
| 398 |
|
All verification experiments with seaice are affected (except for |
| 399 |
|
seaice_exf_offline); global_ocean.cs32x15/input.icedyn recovers the old |
| 400 |
|
results by setting the above flag. |
| 401 |
|
Further changes involve changes in defaults: |
| 402 |
|
- ALLOW_FLOODING is defined and turned on by default |
| 403 |
|
- SEAICEadvSnow = .true. is now the default |
| 404 |
|
- SEAICEadvSalt = .true. is now the default |
| 405 |
|
- SEAICEadvAge = .true. is now the default |
| 406 |
|
- SEAICE_clipVelocities = .false. is now the default |
| 407 |
|
(as per J. Zhang's recommendation) |
| 408 |
|
- B-grid, and thus not tested: SEAICE_TEST_ICE_STRESS_1/EXPLICIT_SSH_SLOPE |
| 409 |
|
is defined, SEAICE_TEST_ICE_STRESS_1 is renamed into SEAICE_BICE_STRESS |
| 410 |
|
- seaice_growth: replace computation of UG by a simple copy from wspeed |
| 411 |
|
|
| 412 |
|
checkpoint61k |
| 413 |
|
o pkg/seaice: a few bug fixes mostly concerning the metric terms: |
| 414 |
|
seaice_lsr: fixed a few metric terms, |
| 415 |
|
affects lab_sea.lsr, lab_sea.salt_plume, seaice_obcs |
| 416 |
|
add more debugging diagnostics |
| 417 |
|
seaice_evp: removed superfluous many metric terms of FV discretization |
| 418 |
|
of stress divergence |
| 419 |
|
affects lab_sea, lab_sea.hb87 |
| 420 |
|
seaice_ocean_stress: removed superfluous many metric terms of FV discretization |
| 421 |
|
of stress divergence for non-evp solver |
| 422 |
|
(this part is not tested anywhere) |
| 423 |
|
seaice_calc_strainrates: fixed a bug in no-slip boundary conditions, |
| 424 |
|
they were effectively only half slip |
| 425 |
|
affects lab_sea.hb87 |
| 426 |
|
updated all relevant verification experiments (except lab_sea//output_adm.txt |
| 427 |
|
which was left over, but fails at level 7 & 6) |
| 428 |
|
|
| 429 |
|
checkpoint61j |
| 430 |
|
o pkg/seaice: turn a few hard wired parameters into run time parameters |
| 431 |
|
o pkg/seaice/exf/monitor: turn netcdf coordinate variable T into model |
| 432 |
|
time in seconds as promised by the usints in seaice_monitor and exf_monitor |
| 433 |
|
o pkg/mnc: fix the coordinate variables for multi-tile curvi-linear grids |
| 434 |
|
that are not cubed-sphere grids |
| 435 |
|
o pkg/seaice: fix a bug for the rare case of SEAICE_VECTORIZE_LSR |
| 436 |
|
o pkg/ctrl: |
| 437 |
|
fix bug in ctrl_depth_ini.F (EXCH_XYZ was applied to 2-D field xx_r_low) |
| 438 |
|
o non-hydrostatic (calc_gw.F): |
| 439 |
|
fix viscA4 on CS-grid + fix diagnostics: Wm_Diss & Wm_Advec |
| 440 |
|
update output of exp. global_ocean.cs32x15.viscA4 |
| 441 |
|
o remove backward compatibility for thetaMin,phiMin |
| 442 |
|
(replaced by xgOrigin,ygOrigin on Jan 27, 2009) |
| 443 |
|
o pkg/exf: fix a serious bug in exf_set_uv.F: do a rotation of the |
| 444 |
|
interpolated wind field not only for curvilineargrid=.true., but also |
| 445 |
|
for a rotated grid (rotateGrid=.true.) |
| 446 |
o pkg/exf: add capability to bypass interpolation for runoff |
o pkg/exf: add capability to bypass interpolation for runoff |
| 447 |
by setting yet another CPP-flag |
by setting yet another CPP-flag |
| 448 |
|
o eesupp/src, B-grid exchange: |
| 449 |
|
add simple (6 tiles, non MPI) CS exch + standard interface S/R. |
| 450 |
o autodiff |
o autodiff |
| 451 |
new CPP option ALLOW_TAMC_SINGLEPREC_COMLEV |
new CPP option ALLOW_TAMC_SINGLEPREC_COMLEV |
| 452 |
allows to switch to single-prec common blocks; |
allows to switch to single-prec common blocks; |
| 462 |
Add flag to reduce all tapelev I/O to single-prec. |
Add flag to reduce all tapelev I/O to single-prec. |
| 463 |
In data.ctrl set |
In data.ctrl set |
| 464 |
doSinglePrecTapelev = .TRUE. |
doSinglePrecTapelev = .TRUE. |
| 465 |
o model/src/ini_curvilinear_grid.F: check in hack for SX8 compiler |
o model/src/ini_curvilinear_grid.F, new grid-file format without EXCH2: |
| 466 |
to make sure that recip_dxV and recip_dyU are never zero, until we |
check in hack for SX8 compiler (for dxV, dyU); remove it afterwards. |
|
have a proper exchange for them. Most compilers do not seem |
|
|
to mind divisions by zero in the overlaps, as long as the results are |
|
|
not used anywhere, but sxf90 does. |
|
| 467 |
o pkg/shelfice: fix bug with SHELFICEconserve flag, prepare for |
o pkg/shelfice: fix bug with SHELFICEconserve flag, prepare for |
| 468 |
real fresh water flux (not yet) |
real fresh water flux (not yet) |
| 469 |
o pkg/mdsio & rw: |
o pkg/mdsio & rw: |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch