| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/bbl: modification so it can work with z* |
| 8 |
|
o eesupp/src: |
| 9 |
|
- PRINT_MESSAGE: use OpenMP critical instruction (similar to PRINT_ERROR); |
| 10 |
|
writing to unit 0 (if unit=errorMessageUnit) extended to the case myThid=1 |
| 11 |
|
- CHECK_THREADS: specific code if using OpenMP threading: improve checking of |
| 12 |
|
# of threads across processors (e.g., different env OMP_NUM_THREADS setting) |
| 13 |
|
- improve special preliminary call to EESET_PARMS (if eedata is read 2 times). |
| 14 |
|
- when using MPI, always set usingMPI=T ; set default accordingly and stop |
| 15 |
|
if not consistent. |
| 16 |
|
- ALL_PROC_DIE: add a BARRIER after MPI_FINALIZE call ; skip this when thread |
| 17 |
|
argument is zero (in case called within single-thread section). |
| 18 |
|
o pkg/fizhi: |
| 19 |
|
clean-up turbulence cold-start switch: decided in fizhi_init_vars.F, stored |
| 20 |
|
in common bloc (fizhi_coms.h) and then passed as argument up to S/R TURBIO. |
| 21 |
|
o pkg/exch2: |
| 22 |
|
- add argument "updateCorners" to S/R exch2_get_uv_bounds (enable to |
| 23 |
|
activate EXCH_IGNORE_CORNERS in vector EXCH S/R). |
| 24 |
|
- switch 1rst EXCH call to IGNORE_CORNERS (instead of UPDATE_CORNERS) |
| 25 |
|
but keep the 2nd with UPDATE_CORNERS: this prevents overwriting good data |
| 26 |
|
with bad ones coming from a not-yet-updated halo. |
| 27 |
|
This should fix the problem when sNx <> sNy and GCD(sNx,sNy) < 2*Olx. |
| 28 |
|
o pkg/frazil: |
| 29 |
|
move FrzForcT diag from frazil_diagnostics_state.F to frazil_calc_rhs.F |
| 30 |
|
http://mitgcm.org/pipermail/mitgcm-devel/2012-March/005384.html |
| 31 |
|
o model/src/config_check.F: add a check for OLx>sNx/OLy>sNy |
| 32 |
|
o verification/lab_sea |
| 33 |
|
* #undef SEAICE_EXCLUDE_FOR_EXACT_AD_TESTING |
| 34 |
|
* #define ALLOW_SST_CONTROL & ALLOW_SST_CONTROL |
| 35 |
|
* nTimeSteps 3 -> 4 |
| 36 |
|
* changed reference output accordingly |
| 37 |
|
o pkg/ctrl: |
| 38 |
|
* fix ctrl_get_gen for xx_sst, xx_sss |
| 39 |
|
o pkg/fizhi: |
| 40 |
|
- fix 2 calls to S/R GRD2MSC (argument igrd) in update_earth_exports.F |
| 41 |
|
update results of exp. fizhi-cs-32x32x40 (fail with only 6 digits for cg2d) |
| 42 |
|
- by default, use new version of S/R GETPWHERE (#define TRY_NEW_GETPWHERE); |
| 43 |
|
fix few out-of-bounds indices in referencing vars (initialise igrd to 1); |
| 44 |
|
clean-up fizhi_turb.F (remove unused & uninitialised qdiaglsm array). |
| 45 |
|
o pkg/gmredi: |
| 46 |
|
- add diagnostic of Redi (main diagnonal) vertical diffusive flux of Temp |
| 47 |
|
o pkg/fizhi: |
| 48 |
|
- fix few initialisation and multi-tile Pb: aqualev & gridalt now pass the |
| 49 |
|
(old)aces open64 tuv test. |
| 50 |
|
o pkg/icefront: fix bug and reorder loop in icefront_init_varia.F |
| 51 |
|
o pkg/mom_vecinv: |
| 52 |
|
- fix 1 loop range in mom_vecinv.F to be like all the other loops which |
| 53 |
|
set/update gu,gv/Diss (fix Pb of uninitialised fVerUkp in admom_vecinv |
| 54 |
|
with non-lin free-surf). |
| 55 |
|
o model/src: move k-loop outside of i/j-loops when (re-)computing R_low |
| 56 |
|
in ini/update_masks_etc.F in order to avoid -O3 optimization problems with |
| 57 |
|
some compilers (gfortran 4.6.0 on MacOS) |
| 58 |
|
o momentum: |
| 59 |
|
- separate fVer?(:,:,kUp) & fVer?(:,:,kDown) in argument list of MOM_FLUXFORM |
| 60 |
|
& MOM_VECINV subroutines (to help TAF). This fixes Pb of uninitialised |
| 61 |
|
fVer?(kUp) in admom_fluxform with non-lin free-surf or bottom control. |
| 62 |
|
|
| 63 |
|
checkpoint63k (2012/03/17) |
| 64 |
|
o model/src: |
| 65 |
|
- selectAddFluid (ALLOW_ADDFLUID): add missing term in horizontal momentum |
| 66 |
|
flux-form (mom_fluxform.F) and vertical momentum (calc_gw.F) equations. |
| 67 |
|
- SOLVE_DIAGONAL: switch default to use adjoinable & vectorized version |
| 68 |
|
(#undef SOLVE_DIAGONAL_LOWMEMORY); update output of exp. front_relax.bvp. |
| 69 |
|
o model/src: solve_*diagonal.F |
| 70 |
|
- replace division with multiplication by inverse (similar to original version) |
| 71 |
|
update output of AD exp. global_ocean.90x40x15. |
| 72 |
|
- fix pkg/gmredi/gmredi_calc_psi_bvp.F & pkg/ggl90/ggl90_calc.F |
| 73 |
|
to enable the use of the vectorized & differentiable solve_tridiagonal.F |
| 74 |
|
- test exp. global_ocean.90x40x15/input_ad: switch to advection scheme 20 for |
| 75 |
|
vertical advection (to get solve_tridiagonal tested in AD mode). |
| 76 |
|
o pkg/seaice: ECCO-CLIVAR merge: |
| 77 |
|
1. seaice AREA relaxation |
| 78 |
|
* CPP option: SEAICE_ALLOW_AREA_RELAXATION |
| 79 |
|
* runtime flag: SEAICE_tauAreaObsRelax |
| 80 |
|
2. modified global mean cost imbalance code: CPP option |
| 81 |
|
ALLOW_SSH_GLOBMEAN_COST_CONTRIBUTION |
| 82 |
|
o another iteration on solve_*diagonal.F |
| 83 |
|
Make choices independent of AUTODIFF |
| 84 |
|
Default will be the adjoinable vectorized version. |
| 85 |
|
Alternative choices are: |
| 86 |
|
* non-adjoinable original version with low memory footprint: |
| 87 |
|
#define SOLVE_DIAGONAL_LOWMEMORY |
| 88 |
|
* still adjoinable but does not vectorize (k as inner-most loop): |
| 89 |
|
#define SOLVE_DIAGONAL_KINNER (keeping SOLVE_DIAGONAL_LOWMEMORY undef) |
| 90 |
|
o testreport |
| 91 |
|
- add option to use a home made wrapper around "make" |
| 92 |
|
- remove MITGCM_IEEE env. variable (no longer active) |
| 93 |
|
o pkg/shelfice |
| 94 |
|
- improve computation of friction velocity for velocity dependent |
| 95 |
|
exchange coefficients: include velocities into SHELFICEBoundaryLayer |
| 96 |
|
block to average velocities vertically |
| 97 |
|
- add TAF store directives for SHI_ALLOW_GAMMAFRICT |
| 98 |
|
o Modify diagonal solvers, now three versions (upon request): |
| 99 |
|
#ifndef SOLVE_DIAGONAL_AUTODIFF |
| 100 |
|
1. default version (dating back a while ago) |
| 101 |
|
#else /* def SOLVE_DIAGONAL_AUTODIFF */ |
| 102 |
|
# ifdef SOLVE_DIAGONAL_KINNER |
| 103 |
|
2. adjoinable version with k-innermost loop (G. Forget) |
| 104 |
|
# else |
| 105 |
|
3. adjoinable vectorized version of 2. |
| 106 |
|
# endif |
| 107 |
|
#endif /* SOLVE_DIAGONAL_AUTODIFF */ |
| 108 |
|
All flags are currently set within routines, but could/should be moved to CPP-options. |
| 109 |
|
Array bounds for 1. are as before, for 2.,3. cover the entire domain |
| 110 |
|
(could be changed for 1. too). |
| 111 |
|
o verification/lab_sea (fwd): |
| 112 |
|
- update the 4 fwd lab_sea test experiment: no longer SEAICE_GROWTH_LEGACY, |
| 113 |
|
use 7 categories (except hb87), new solve4temp params (except salt_plume), |
| 114 |
|
constant salinity (=4) or variable salinity (salt_plume) done through |
| 115 |
|
SItracer. |
| 116 |
|
o pkg/seaice: |
| 117 |
|
- rename parameters: SIsalFrac to SEAICE_saltFrac & SIsal0 to SEAICE_salt0; |
| 118 |
|
- remove old parameters ( SEAICE_freeze, SEAICEturbFluxFormula, SEAICE_gamma_t, |
| 119 |
|
SEAICE_gamma_t_frz, SEAICE_availHeatTaper & SEAICE_availHeatFracFrz) |
| 120 |
|
from SEAICE_PARMS.h ; still need to fix seaice_cost_sst.F (broken when |
| 121 |
|
SEAICE_freeze got retired) but already better than previously with |
| 122 |
|
SEAICE_freeze=123456.7 deg.C; |
| 123 |
|
- move setting of facOpenGrow/Melt from SEAICE_INIT_FIXED to SEAICE_READPARMS |
| 124 |
|
(safer multi-threaded setting); always set SEAICEuseEVP; |
| 125 |
|
- setting of ocean-ice turb. flux coeff: moved from SEAICE_CHECK to |
| 126 |
|
SEAICE_READPARMS & SEAICE_INIT_FIXED (this fixes wrong summary report); |
| 127 |
|
stop if multiple specifications for the same coeff; make sure default |
| 128 |
|
SEAICE_mcPheePiston is compatible with drF(1) & deltaT. |
| 129 |
|
o pkg/obcs: |
| 130 |
|
- allow to switch to upwind 1rst order advection scheme for the advective |
| 131 |
|
flux computation at the open-boundary; disabled for adjoint built. |
| 132 |
|
o pkg/ptracers: |
| 133 |
|
- rename PTRACERS_RESTART.h -> PTRACERS_START.h |
| 134 |
|
- rename ptracers_fields_blocking_exchanges.F -> ptracers_fields_blocking_exch.F |
| 135 |
|
- add parameter to decide when to start a tracer; use internal flag to |
| 136 |
|
know which tracer to step-forward; switch this internal flag at the top |
| 137 |
|
of forward_step.F (new S/R PTRACERS_SWITCH_ONOFF); for now, not enabled |
| 138 |
|
for adjoint built. |
| 139 |
|
o pkg/seaice: |
| 140 |
|
- add SEAICE_SIZE.h anywhere in the code where SEAICE.h is included ; |
| 141 |
|
- move MULTDIM declaration and setting from SEAICE.h to SEAICE_SIZE.h ; |
| 142 |
|
- keep experiment offline_exf_seaice truly single category (set MULTDIM=1). |
| 143 |
|
o pkg/ecco: |
| 144 |
|
- fix writing of output file DiagnosCost_ClimSalt/Theta |
| 145 |
|
and DiagnosCost_DriftSalt/Theta (if multi-tiles per proc). |
| 146 |
|
o pkg/seaice: |
| 147 |
|
- add missing initialisation of COR_ICE array in dynsolver.F |
| 148 |
|
- merging SEAICE_MULTICATEGORY define and undef cases. Now the same code is |
| 149 |
|
compiled either way, and is tested in all exps (multidim was only tested |
| 150 |
|
in lab_sea ad before). |
| 151 |
|
- cosmetic change to prepare for future addition of ITD. no change to results. |
| 152 |
|
no defaults change. |
| 153 |
|
- added run time param SEAICE_multDim (7 for SEAICE_MULTICATEGORY, 1 otherwise). |
| 154 |
|
- by lack of adequate verification experiments, I further used custom versions |
| 155 |
|
of global_ocean.cs32x15 to test multicat or not, with pickup or not. All |
| 156 |
|
should be correct. |
| 157 |
|
- avoid recomputations in ad. |
| 158 |
|
o array initialisation in adjoint mode: |
| 159 |
|
1) pkg/mom_common/mom_calc_ke.F: |
| 160 |
|
add full array initialisation of KE inside mom_calc_ke.F (ALLOW_AUTODIFF_TAMC): |
| 161 |
|
The S/R which calls MOM_CALC_KE initialises KE but in some recomputation |
| 162 |
|
part this initialisation is gone, resulting in Floating Point Exception |
| 163 |
|
(caught by open64 compiler with debug option). |
| 164 |
|
2) model/src/convective_weights.F |
| 165 |
|
set output convectCount over the full array range (instead of doing |
| 166 |
|
an update): this fix a similar issue when called within recomputation (adjoint) |
| 167 |
|
which could by-pass the initialisation (normally done in the caller S/R). |
| 168 |
|
o pkg/seaice: |
| 169 |
|
- final version of turbulent flux params, as agreed at MIT ice meet: |
| 170 |
|
SEAICE_mcPheePiston (default is ~ 0.000875) |
| 171 |
|
SEAICE_mcPheeTaper (default is 0.) |
| 172 |
|
SEAICE_frazilFrac (defualt is 1.) |
| 173 |
|
SEAICE_mcPheeStepFunc (default is false) |
| 174 |
|
- changes results at trunction error level |
| 175 |
|
- ifdef SEAICE_EXTERNAL_FLUXES, disallow SEAICE_waterAlbedo |
| 176 |
|
o added pkg/frazil: |
| 177 |
|
- see frazil_description.tex for details |
| 178 |
|
- verification experiment is global_with_exf/input.yearly; changes output.yearly.txt |
| 179 |
|
o pkg/shelfice/shelfice_thermodynamics.F |
| 180 |
|
- fix exponents for velocity dependent exchange coefficients: change |
| 181 |
|
from 2/3(=0) to 0.66666666666666667 |
| 182 |
|
- move computation of velocity dependent exchange coefficients into |
| 183 |
|
separate loop, so that it applies to both thermodynamics |
| 184 |
|
- move some divisions by constants out of loops |
| 185 |
|
|
| 186 |
|
checkpoint63j (2012/02/16) |
| 187 |
|
o pkg/seaice: |
| 188 |
|
- overhaul of seaice_summary.F after feb 2012 clean-up of seaice_growth.F etc. |
| 189 |
|
- SItracer: added run time params, and allow coupling to ocn salinity. |
| 190 |
|
o pkg/seaice: remove (almost) all divisions by constants within loops |
| 191 |
|
in seaice_growth.F and seaice_solve4temp.F, this changes (only) the cg2d |
| 192 |
|
results of global_ocean.cs32x15.seaice from 16 to 11 digits (but only |
| 193 |
|
those, caused by 1/QI -> recip_QI) -> update output.seaice.txt, |
| 194 |
|
output_adm.seaice_dynmix.txt and also lab_sea: output_adm.evp.txt |
| 195 |
|
o pkg/seaice : |
| 196 |
|
- simplify McPhee tapering, and allow to use it with SEAICEturbFluxFormula |
| 197 |
|
= 1 or 2, using newly added run time parameter SEAICE_availHeatTaper. |
| 198 |
|
- fix d_AREAbyATM, d_AREAbyOCN, d_AREAbyICE diags I broke in r1.148. |
| 199 |
|
- add permanent SItflux diag that corresponds to TFLUX but includes |
| 200 |
|
ice+snow. Hence SItflux-TFLUX should match the ice+snow heat budget. |
| 201 |
|
- allow activation/testing of a fix for suspected missing term in |
| 202 |
|
ocn-ice heat budget (to be confirmed). To test this, you want to |
| 203 |
|
undef SEAICE_DISABLE_HEATCONSFIX, and then set the run time param |
| 204 |
|
SEAICEheatConsFix to .TRUE. that also allows the 'SIaaflux' diagnostic. |
| 205 |
|
- no change in results, fwd or ad. |
| 206 |
|
o global_ocean.cs32x15/results: 3 changes following from the pkg/seaice commit below: |
| 207 |
|
- switch to variable freezing point. |
| 208 |
|
Results change : cg2d -> 1 digits; ad -> 3-6-6 digits. |
| 209 |
|
- bug fix : the sublimation term that was missing is now activated. |
| 210 |
|
Results change : cg2d -> 2 digits; ad -> 8-6-6 digits. |
| 211 |
|
- bug fix : flooding sign term for SIsal0.NE.0. |
| 212 |
|
Result change : cg2d -> 8 digits; ad -> 11-12-9 digits. |
| 213 |
|
o pkg/seaice: |
| 214 |
|
- unified freezing point treatment : the old SEAICE_VARIABLE_FREEZING_POINT |
| 215 |
|
is now the default, and the old default constant freezing point is recovered |
| 216 |
|
with SEAICE_tempFrz0 = -1.96, |
| 217 |
|
SEAICE_dTempFrz_dS = 0., |
| 218 |
|
- retire SEAICE_freeze (= the old way of specifycing the constant freezing point) |
| 219 |
|
- remove ALLOW_SEAICE_FLOODING brackets; run time switch is already there. |
| 220 |
|
- bug fix (thanks to M. Losch) : the sublimation term that was missing is now |
| 221 |
|
activated. To reproduce old results with this bug define SEAICE_DISABLE_SUBLIM. |
| 222 |
|
- bug fix (silly me) : flooding sign term (seaice_growth.F r 1.149line 1211) |
| 223 |
|
was wrong for SIsal0.NE.0. Changes cs32x15 results (see above item for detail). |
| 224 |
|
- bug fix (thanks to O. Jahn) : area loss for melting got messed up in |
| 225 |
|
seaice_growth r149 for legacy branch (no results change). |
| 226 |
|
- introduce SEAICE_CAP_SUBLIM : caps sublimation heat flux in solve4temp (code |
| 227 |
|
from I. Fenty). |
| 228 |
|
- results did not change except for global_ocean.cs32x15, mostly due to the |
| 229 |
|
switch to variable freezing point (see above item for detail). |
| 230 |
|
o pkg/thsice: |
| 231 |
|
- fix and simplify interface to salt_plume pkg ; diagnose directly amount of |
| 232 |
|
seawater freezing in thsice_calc_thickn (not used). |
| 233 |
|
o pkg/seaice: turbulent flux term specification via run time params. |
| 234 |
|
- replace CPP switches with run time switches to facilitate testing |
| 235 |
|
- retired CPPs : MCPHEE_OCEAN_ICE_HEAT_FLUX, |
| 236 |
|
GRADIENT_MIXED_LAYER_TURBULENCE_FACTOR |
| 237 |
|
- added runtime parameter : SEAICEturbFluxFormula |
| 238 |
|
- move Mcphee constants to SEAICE_PARAMS.h |
| 239 |
|
- seaice_readparms.F : read turbulent flux term params (SEAICEturbFluxFormula; |
| 240 |
|
SEAICE_availHeatFrac/Frz, or SEAICE_gamma_t/_frz if apply); |
| 241 |
|
remove seaice_summary call (moved to seaice_init_fixed) |
| 242 |
|
- seaice_init_fixed.F : set SEAICE_availHeatFrac/Frz depending on |
| 243 |
|
SEAICEturbFluxFormula, and seaice_summary call (moved from seaice_readparms) |
| 244 |
|
- seaice_summary.F : add missing report of read turbulent flux term set up |
| 245 |
|
and SITRACER. |
| 246 |
|
- seaice_check.F : check range; inform and stop if retired CPPs are used |
| 247 |
|
(incl. SEAICE_AGE). |
| 248 |
|
- seaice_growth.F : unified use of SEAICE_availHeatFrac/Frz, without |
| 249 |
|
CPP switch, same computation as before for the different options. |
| 250 |
|
- change results at the truncation level. |
| 251 |
|
o pkg/seaice: |
| 252 |
|
- remove un-used parameters LAD & MAX_TICE ; add new run-time parameters: |
| 253 |
|
useMaykutSatVapPoly (default=F), postSolvTempIter (default=2) and |
| 254 |
|
SEAICE_wetAlbTemp (default=-1e-3). Remove option SEAICE_SOLVE4TEMP_LEGACY. |
| 255 |
|
- update verification/*/input*/data.seaice: |
| 256 |
|
to reproduce previous results with former #defined SEAICE_SOLVE4TEMP_LEGACY |
| 257 |
|
code, set useMaykutSatVapPoly=T & postSolvTempIter=0 ; |
| 258 |
|
and to reproduce previous results with former non-SOLVE4TEMP_LEGACY code, |
| 259 |
|
set SEAICE_wetAlbTemp=0 & SEAICE_snowThick=0. |
| 260 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY): |
| 261 |
|
- remove LEGACY code for solving for tsurf (A1,A2,A3) but maintain the same |
| 262 |
|
algorithm (same choice: useMaykutPolySatVap=T, postSolvTempIter=0); |
| 263 |
|
difference in results only due to machine truncation. |
| 264 |
|
- remove MAX_TICE (tsurf is always =< TMELT anyway); keep MIN_TICE if using |
| 265 |
|
MaykutPolySatVap; keep MIN_LWDOWN. |
| 266 |
|
- adapt SEAICE_MODIFY_GROWTH_ADJ code (untested) to non-legacy formulation. |
| 267 |
|
- update output of verification exp. lab_sea (4 fwd: 11 cg2d digits except hb87, |
| 268 |
|
+ 3 AD: 6 digits except evp) and offline_exf_seaice.seaice (12 digits). |
| 269 |
|
o pkg/salt_plume: |
| 270 |
|
- isolate saltPlumeFlux array exch into a specific S/R called from |
| 271 |
|
do_oceanic_phys.F |
| 272 |
|
- add interface to pkg/salt_plume (filling of saltPlumeFlux) in pkg/thsice. |
| 273 |
|
o verification: |
| 274 |
|
- move untested set-up to MITgcm_contrib/verification_other. |
| 275 |
|
o pkg/seaice: |
| 276 |
|
- retire old way of SEAICE_AGE. Now replaced with ALLOW_SITRACER. |
| 277 |
|
o pkg/seaice: |
| 278 |
|
- seaice_solve4temp.F (keeping results unchanged): |
| 279 |
|
* add 2 future run-time params to select which saturation vapor pressure |
| 280 |
|
formula is used and how post-iteration fluxes are set. |
| 281 |
|
Temporary set these 2 params according to option SOLVE4TEMP_LEGACY; |
| 282 |
|
* New piece of code (not used) to update surf. atmos. heat flux F_ia using |
| 283 |
|
the linearized expression to stay consistent with tsurf finding. |
| 284 |
|
- seaice_freedrift.F avoid floating exception in sqrt(y) since y=sqrt(x*x)-x |
| 285 |
|
can be < 0. |
| 286 |
|
o pkg/seaice/seaice_solve4temp.F (SOLVE4TEMP_LEGACY undef): |
| 287 |
|
- remove from F_ia (and from it's derivative dFiDTs1) the contribution of |
| 288 |
|
conductive heat flux F_c , and add it explicitly when updating tsurf as |
| 289 |
|
solution of: Fc = Fia + d/dT(Fia - Fc) *delta.tsurf |
| 290 |
|
so that now F_ia has a consistent meaning through the entire routine. |
| 291 |
|
This causes differences at truncation level: update output of fwd exp. |
| 292 |
|
global_ocean.cs32x15.seaice. |
| 293 |
|
o pkg/seaice: |
| 294 |
|
- lots of editing/cleaning in seaice_solve4temp.F + better documentation |
| 295 |
|
of arrays, sign/direction of fluxes; no effect on results. |
| 296 |
|
- replace hard coded 273.16 (=previous value of celsius2K) by celsius2K |
| 297 |
|
in seaice_budget_ocean.F & seaice_solve4temp.F (SOLVE4TEMP_LEGACY part); |
| 298 |
|
note: this should have been done before changing celsius2K default. |
| 299 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 300 |
|
exp. input*/data : lab_sea (AD), offline_exf_seaice (fwd+AD) & seaice_obcs |
| 301 |
|
- replace hard coded seawater freezing temp in seaice_solve4temp.F (part |
| 302 |
|
SOLVE4TEMP_LEGACY) of 271.20 (=previous value of celsius2K + default |
| 303 |
|
value of SEAICE_freeze) by celsius2K+SEAICE_freeze so that seawater |
| 304 |
|
freezing temp is consistent with value in seaice_growth.F ; this causes |
| 305 |
|
differences at machine truncation level: update lab_sea AD output (3/4). |
| 306 |
|
o pkg/seaice: |
| 307 |
|
- mask (in exf_init_fixed.F) atemp,aqh,evap,precip,runoff,lwflx,areamask |
| 308 |
|
and climsst/sss even when using seaice (to prevent calculation that might |
| 309 |
|
use SST on land); does not affect any verification exp. |
| 310 |
|
- apply mask to taux,tauy (in seaice_get_dynforcing.F); update output |
| 311 |
|
of lab_sea.fd & lab_sea.hb87 and global_ocean.cs32x15.seaice_dynmix. |
| 312 |
|
o pkg/seaice/seaice_growth.F: add mask to avoid non-zero ice thickness |
| 313 |
|
over land (non-legacy code) |
| 314 |
|
o vectorize salt_plume package: |
| 315 |
|
- add extra code to salt_plume_frac and salt_plume_tendency_apply_s |
| 316 |
|
- this code computes plumebk everywhere (also over land), thus requires |
| 317 |
|
code to avoid divisions by zero and catch the case of kLev=Nr. |
| 318 |
|
- efficiency of salt_plume_frac is still sub-optimal |
| 319 |
|
o tools (genmake2): |
| 320 |
|
- fix makefile NAME specification (option: -makefile NAME) by adding |
| 321 |
|
"-f $MAKEFILE" in few places where it was missing including makedepend |
| 322 |
|
command (contribution from Paul). |
| 323 |
|
|
| 324 |
|
checkpoint63i (2012/01/24) |
| 325 |
|
o model/src: |
| 326 |
|
- add factorized versions of some EOS code to find_rho.F, |
| 327 |
|
define USE_FACTORIZED_EOS to turn it on (default for TARGET_NEC_SX) |
| 328 |
|
o model/src: |
| 329 |
|
- add celsius2K to namelist PARM01; remove unused recip_rhoNil from PARAMS.h; |
| 330 |
|
- change default celsius2K from 273.16 to 273.15 |
| 331 |
|
- to keep results unchanged, add back old value of celsius2K in verification |
| 332 |
|
exp. input*/data : aim.5l_cs, 1D_ocean_ice_column, lab_sea (fwd), |
| 333 |
|
global_ocean.cs32x15(seaice) & cpl_aim+ocn(input_atm). |
| 334 |
|
o model/src: add a little initialisation trick to find_rho.F and find_alpha.F |
| 335 |
|
to make TAF generate vectorizable code |
| 336 |
|
o pkg/seaice/seaice_evp.F: add code (copied from CICE) that avoids underflows. |
| 337 |
|
Turn on by defining SEAICE_EVP_ELIMINATE_UNDERFLOWS. Most compilers |
| 338 |
|
have flags that do this more efficiently. |
| 339 |
|
o pkg/diagnostics/diagstats_calc.F |
| 340 |
|
- for TARGET_NEC_SX fix the treatment of the scaling factor tmpFac=scaleFact |
| 341 |
|
o pkg/obcs (with exch2): |
| 342 |
|
- derive OB indices in overlap region from OB-InsideMask (in obcs_init_fixed.F) |
| 343 |
|
and remove code (in obcs_readparms.F) which was based on EXCH of indices |
| 344 |
|
(through buffer) and did not account for exch2 (e.g., CS-grid) topology. |
| 345 |
|
o pkg/exf and seaice exp: |
| 346 |
|
- change offline_exf_seaice.seaicetd test exp. to use default DIFF1 value (=0) |
| 347 |
|
so that switching off area & heff advection flags does not affect results. |
| 348 |
|
- change default EXF_LWDOWN_WITH_EMISSIVITY to #define in EXF_OPTIONS.h |
| 349 |
|
- keep exp. seaice_obcs & 1D_ocean_ice_column(ad) unchanged (using #undef |
| 350 |
|
EXF_LWDOWN_WITH_EMISSIVITY) and, using pkg/exf default emissivities, update |
| 351 |
|
results of verification experiments: 1D_ocean_ice_column(fwd), |
| 352 |
|
global_ocean.cs32x15.seaice(fwd+ad) & seaice_dynmix(ad), lab_sea (all 8) |
| 353 |
|
and offline_exf_seaice (all 4). |
| 354 |
|
o pkg/seaice: |
| 355 |
|
- remove array YNEG, RIVER, TMIX (replaced by local var) from common block; |
| 356 |
|
remove also areaNm1 & hEffNm1 when SEAICE_GROWTH_LEGACY is undef. |
| 357 |
|
- fix bug: areaNm1 & hEffNm1 are needed in seaice_growth (SEAICE_GROWTH_LEGACY) |
| 358 |
|
but were not filled when resp. SEAICEadvArea=F & SEAICEadvHeff=F and |
| 359 |
|
not multi-dim advection; |
| 360 |
|
- fix seaice_growth.F to compile with both SEAICE_GROWTH_LEGACY and |
| 361 |
|
SHORTWAVE_HEATING #undef. |
| 362 |
|
o optim: make Makefile more robust (?) |
| 363 |
|
o pkg/obcs: |
| 364 |
|
* fix treatment of obcs_read_pickup for TAF |
| 365 |
|
o pkg/shelfice: |
| 366 |
|
* add missing initialisation of num_shifwflx |
| 367 |
|
* new adjoint verification exp. for isomip |
| 368 |
|
* change Prandtl and Schmidt numbers from generic formulations |
| 369 |
|
(in terms of model diffus. and visc.) to separate runtime |
| 370 |
|
parameters, with Holland and Jenkins (1999) default values. |
| 371 |
|
o pkg/exf (interpolation): |
| 372 |
|
- extended input field (2 rows) near the N & S poles: |
| 373 |
|
* fill in with the symetric value (when even Nb of data in longitude) |
| 374 |
|
* add average value at the poles only for scalar quantities ; for vector |
| 375 |
|
component interpolation, skip the averaging and keep duplicated values, |
| 376 |
|
unless the 2 components have same location (uvInterp=T) in which case |
| 377 |
|
interpolate the 2 components together using S/R EXF_INTERP_UV. |
| 378 |
|
- new S/R EXF_INTERP_UV to interpolate the 2 components of a vector field |
| 379 |
|
together: this allows to account properly for local orientation when |
| 380 |
|
averaging at N & S pole. |
| 381 |
|
- add CPP option EXF_USE_OLD_INTERP_POLE to recover old results regarding |
| 382 |
|
exf-interpolation near N & S poles. Undef by default. |
| 383 |
|
- add debug check/print on 1rst iter if debugLevel >=2. |
| 384 |
|
o pkg/exf: |
| 385 |
|
- change masking flags definition (no longer "parameter"), put them in |
| 386 |
|
common block and set them in S/R EXF_INIT_FIXED. |
| 387 |
|
- change recognized masking flag from s,u,v to c,w,s since the mask |
| 388 |
|
to use (maskC,W,S) depends on position on model grid and has little to |
| 389 |
|
do with scalar/vector difference; fix masking if using P-coordinates. |
| 390 |
|
- fix masking of wind-stress (was wrong if interpolated or read on A-grid) |
| 391 |
|
and update results of exp. global_with_exf (x2). |
| 392 |
|
- fix setting of zenith-angle table when SHORTWAVE_HEATING is undef. |
| 393 |
|
o pkg/obcs |
| 394 |
|
- S/R obcs_calc_stevens: fix a small bug (gammat -> gammas where appropriate) |
| 395 |
|
o pkg/exf (interpolation): |
| 396 |
|
- assume periodicity in X only if input field cover full longitude range. |
| 397 |
|
- improve search for lat. index (supposed to be faster, in ~log2(ny) steps, |
| 398 |
|
and should vectorise). |
| 399 |
|
- fix input lat of the 2 added row (in case we provide N.pole data). |
| 400 |
|
|
| 401 |
|
checkpoint63h (2011/12/30) |
| 402 |
|
o pkg/seaice: |
| 403 |
|
- change declaration of UVM from _RL to _RS in order to get B-grid |
| 404 |
|
uIce,vIce monitor when _RS = real*4 |
| 405 |
|
o pkg/offline: |
| 406 |
|
- new S/R OFFLINE_RESET_PARMS for resetting main-model params (switch off flags); |
| 407 |
|
- compute vertical velocity if not read from file (switch on exactConserv |
| 408 |
|
& staggerTimeStep); |
| 409 |
|
- fix output of ptracer monitor iter & time for default PTRACERS_monitorFreq. |
| 410 |
|
o verification: |
| 411 |
|
- update grid-files (in tutorial_held_suarez_cs/input and fizhi-cs-32x32x40/input) |
| 412 |
|
with grid-angle generated using "utils/matlab/cs_grid/cubeCalcAngle.m": |
| 413 |
|
fix Pb in yG definition @ 2 missing corners (previously yG was averaged); |
| 414 |
|
- update output of exp. global_ocean.cs32x15.viscA4 after changing |
| 415 |
|
grid-file angles (used here for coriolis-3d); |
| 416 |
|
- remove (or gzip) few files not needed to run fizhi-cs experiments. |
| 417 |
|
o pkg/exf (vector interpolation): |
| 418 |
|
- rotate vector component toward local grid-axis orientation using grid-angles |
| 419 |
|
(stored in GRID.h) instead of locally computed rotation angle; keep old code |
| 420 |
|
available with exf option EXF_USE_OLD_VEC_ROTATION (undef by default). |
| 421 |
|
o pkg/seaice: |
| 422 |
|
- allow to compile with exf options ALLOW_ATM_TEMP or ALLOW_DOWNWARD_RADIATION |
| 423 |
|
undefined. Fix and remove the stop when ALLOW_RUNOFF is undefined. |
| 424 |
|
o pkg/PKG_OPTIONS.h files: |
| 425 |
|
- move #include "CPP_OPTIONS.h" just after #include "PACKAGES_CONFIG.h", |
| 426 |
|
outside of the #ifdef ALLOW_THISPKG / #endif block. |
| 427 |
|
- update verification/*/code/PKG_OPTIONS.h files. |
| 428 |
|
o add a verification experiment (offline_exf_seaice/input.seaice) that test |
| 429 |
|
the B-grid LSOR solver |
| 430 |
|
o pkg/seaice: sort out emissivity and long wave radiation step 2: |
| 431 |
|
- add emissivity for snow and ice as new run-time parameters |
| 432 |
|
(unfortunately) that default to the corresponding exf values; this |
| 433 |
|
changes results in most verification experiments so that for backward |
| 434 |
|
compatibility these parameter have to be set explicitly to inconsistent |
| 435 |
|
values (ugly); |
| 436 |
|
- the exf-flag EXF_LWDOWN_WITH_EMISSIVITY then gets rid off the hard-wired |
| 437 |
|
emissivities of 0.97 associated with lwdownloc in S/R seaice_solve4temp |
| 438 |
|
until we agree how to handle this bug properly |
| 439 |
|
o pkg/exf (interpolation): |
| 440 |
|
- add a set of run-time param ({inputfield}_interpMethod), one for |
| 441 |
|
each interpolated input field, to select the interpolation method |
| 442 |
|
with a value of zero switching off the interpolation; |
| 443 |
|
- print interpolation parameters to standard output; |
| 444 |
|
- refine exf_check.F accordingly ; stop if USE_NO_INTERP_RUNOFF is defined |
| 445 |
|
(to use instead runoff_interpMethod=0 in data.exf). |
| 446 |
|
- simplify default setting of interpolation parameters (for all fields, |
| 447 |
|
set position to match model grid cell-center position, leading to trivial |
| 448 |
|
interpolation in case of regular Lat-Lon grid) and fix for the case of |
| 449 |
|
non-uniform delY. |
| 450 |
|
o pkg/exf/exf_radiation.F: add the factor ocean_emissivity to lwdown, for |
| 451 |
|
within #ifdef EXF_LWDOWN_WITH_EMISSIVITY/#endif. Unless ocean_emissivity=1. |
| 452 |
|
this factor is absolutely required, because the lw exitance (= out-going |
| 453 |
|
long wave radiation) is emissivity*stefanBoltzmann*T^4 + rho*lwdown, |
| 454 |
|
where the reflectivity rho = 1-emissivity for conservation reasons. Once |
| 455 |
|
this is established, we can remove the CPP-Flag (if we want to). |
| 456 |
|
o pkg/seaice: |
| 457 |
|
- qualify a stop statement in S/R seaice_check: EXF_READ_EVAP and |
| 458 |
|
ALLOW_BULKFORMULAE are only required if SEAICE_EXTERNAL_FLUXES is defined |
| 459 |
|
- sort out emissivity and long wave radiation, step 1: make SEAICE_emissivity |
| 460 |
|
what the name implies (and not emissivity*BoltzmannConstant), this means |
| 461 |
|
the old default value of 5.5e-8 now means |
| 462 |
|
5.5e-8/5.670e-8 = 0.97001763668430343479 as ocean_emissivity in |
| 463 |
|
S/R exf_readparms |
| 464 |
|
- FV-discretization of the B-grid LSOR solver, turn on with |
| 465 |
|
SEAICE_LSRBNEW. This new solver also involves a slight re-organization |
| 466 |
|
of the calling routine dynsolver, so that B and C-grid code look a |
| 467 |
|
little more alike. |
| 468 |
|
- fix index bugs in ostres.F (B-grid code) |
| 469 |
|
o pkg/seaice/seaice_ocean_budget.F: change (unused) code to make it look better |
| 470 |
|
o pkg/seaice/seaice_readparms.F: make ocean_emissivity*stefanBoltzmann the |
| 471 |
|
default for SEAICE_emissivity, if useEXF; requires setting a wrong |
| 472 |
|
parameter value in global_ocean.cs32x15/input.seaice/data.seaice for |
| 473 |
|
backward compatiblity |
| 474 |
|
o model/src: use sigmaR in calc_ivdc |
| 475 |
|
|
| 476 |
|
checkpoint63g (2011/12/16) |
| 477 |
|
o pkg/seaice/seaice_growth.F: |
| 478 |
|
fix heat conservation of the coupled ocean-seaice system. |
| 479 |
|
when SEAICE_HEAT_CONSERV_FIX is defined, the mismatch of |
| 480 |
|
solid vs liquid water treatment is resolved via QNET. |
| 481 |
|
o pkg/seaice/seaice_growth.F: |
| 482 |
|
add missing term for sublimation in saltFlux, which was breaking conservation. |
| 483 |
|
o pkg/seaice/seaice_model.F: |
| 484 |
|
Remove this patholigical case treatment in evolution branch, |
| 485 |
|
where it is un-necessary and breaks conservation. |
| 486 |
|
Update global_ocean.cs32x15/results accordingly for |
| 487 |
|
output.seaice.txt output_adm.seaice.txt and output_adm.seaice_dynmix.txt |
| 488 |
|
o model/src: |
| 489 |
|
useRealFreshWaterFlux: remove masking of EmPmP (using maskInC) in |
| 490 |
|
external_forcing_surf.F and apply mask directly in S/R SOLVE_FOR_PRESSURE. |
| 491 |
|
o pkg/obcs: |
| 492 |
|
modify Stevens boundary conditions so that S/R obcs_calc_stevens computes |
| 493 |
|
tendency for temperature and salinity that is then applied to update |
| 494 |
|
theta and salt in S/R obcs_apply_ts; this requires proper masking of all |
| 495 |
|
horizontal advection and diffusion contributions on the boundary (in |
| 496 |
|
S/Rs gad_advection, gad_calc_rhs, gmredi_rtransport, gmredi_calc_diff), and |
| 497 |
|
removing the mask in S/R timestep_tracer. The advantage of this approach is |
| 498 |
|
that the updated tracer values include contributions from the surface |
| 499 |
|
forcing and vertical diffusion. |
| 500 |
|
This modification changes exp4.stevens because of vertical diffusion. |
| 501 |
|
o model/src: |
| 502 |
|
change non-curvilinear grid setting to also work with exch2 + blank tiles: |
| 503 |
|
- move delX,delY to new header file (SET_GRID.h) and adjust length to 1rst |
| 504 |
|
face dimensions. |
| 505 |
|
- new S/R INI_LOCAL_GRID to define model tile-local grid (using same units |
| 506 |
|
as delX,delY) and called from S/R INI_CARTESIAN_GRID, INI_CYLINDER_GRID |
| 507 |
|
and INI_SPHERICAL_POLAR_GRID. |
| 508 |
|
change test-experiment global_ocean.90x40x15: |
| 509 |
|
- split the domain in many more tiles (9x4 tiles of 10x10 each); |
| 510 |
|
- switch to exch2 and remove 1 blank-tile (but only for MPI test). |
| 511 |
|
- update results of both test (std & dwnslp). |
| 512 |
|
o pkg/diagnostics/diagstat_calc.F: fix problem with non-initialised halos in |
| 513 |
|
tmp-fields for TARGET_NEC_SX at the cost of extra loops and less vectorisation |
| 514 |
|
o model/src: |
| 515 |
|
- take sigma-coords related code out of update_etah.F into new S/R UPDATE_ETAWS |
| 516 |
|
and fix initialisation when using sigma-coords. |
| 517 |
|
o model/src: |
| 518 |
|
- improve Gael's changes from Jan 14, 2011 "addition of an 'update' of hfacc etc. |
| 519 |
|
to their current value at the beginning of forward_step.F": add a new run-time |
| 520 |
|
switch "doResetHFactors" (default=false) and use it to do (or not) the resetting. |
| 521 |
|
- set doResetHFactors=T in the following test exp: |
| 522 |
|
global_ocean.90x40x15/input (rStar) & input.dwnslp (linFS), |
| 523 |
|
global_ocean.cs32x15/input.seaice (rStar), hs94.cs-32x32x5/input.impIGW (linFS) |
| 524 |
|
and tutorial_global_oce_in_p (nonLinFS in p) |
| 525 |
|
o pkg/ecco |
| 526 |
|
- added IES cost term |
| 527 |
|
o verification/advect_xz |
| 528 |
|
- scale down the depth by 1/100 (from 200 km to just 2.km) |
| 529 |
|
- add secondary test using divergent flow, r-star and implicit vertical advection. |
| 530 |
|
- add note (check_conserve_TS.txt) and matlab script to check global |
| 531 |
|
conservation of T & S with NonLin-FreeSurf and Adams-Bashforth. |
| 532 |
|
o pkg/rbcs: |
| 533 |
|
- add missing relaxUFile & relaxVFile in namelist (in rbcs_readparms.F). |
| 534 |
|
o pkg/obcs (Stevens BCs): |
| 535 |
|
- fix various problems in the phase speed computations of the Stevens |
| 536 |
|
boundary conditions: |
| 537 |
|
- sign error for western and southern boundaries, |
| 538 |
|
- time tendencies were underestimated by factor of dTracerLev and some just |
| 539 |
|
zero (for multidim advection schemes) -> now estimate time tendencies |
| 540 |
|
from difference between previous (n) time level and the one before (n-1); |
| 541 |
|
this requires storing a field per tracer per boundary, also in the pickup |
| 542 |
|
files. |
| 543 |
|
- replace deltaTmom in cflMer/Zon computation with dTracerLev |
| 544 |
|
- set default phase velocity to cflMer/Zon |
| 545 |
|
- update verification experiment exp4.stevens |
| 546 |
|
o pkg/generic_advdiff (implicit_r): |
| 547 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 548 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 549 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 550 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 551 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 552 |
|
solver S/R ; |
| 553 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 554 |
|
when using implicit vert. advection; |
| 555 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 556 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 557 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 558 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 559 |
|
o pkg/diagnostics: |
| 560 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 561 |
|
|
| 562 |
|
checkpoint63f (2011/11/30) |
| 563 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 564 |
|
- join some loops to reduce number of if-statements |
| 565 |
|
- fix a bug in code for northern and southern boundaries. |
| 566 |
|
o pkg/seaice/seaice_init_varia.F |
| 567 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 568 |
|
caused zero ice-velocities for the B-grid code |
| 569 |
|
o pkg/seaice/seaice_init_fixed.F |
| 570 |
|
- fix a bug in the initialisation of the second metric terms |
| 571 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 572 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 573 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 574 |
|
= .true. (default) |
| 575 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 576 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 577 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 578 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 579 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 580 |
o model/src: |
o model/src: |
| 581 |
- move bi,bj loops inside INTEGR_CONTINUITY ; |
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 582 |
- call INTEGR_CONTINUITY directly from forward_step.F |
- call INTEGR_CONTINUITY directly from forward_step.F |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch