| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/autodiff: |
| 8 |
|
- include PACKAGES_CONFIG.h in exch*ad.flow & exch*ad.F |
| 9 |
|
(not supposed to be in CPP_OPTIONS.h) to get ALLOW_EXCH2 defined correctly. |
| 10 |
|
+ clean-up comments (_RS is not always real*4) |
| 11 |
|
- fix bug in ADEXCH_UV_3D_RX (without EXCH2, was calling the forward exch S/R) |
| 12 |
|
- add a stop in ADEXCH_UV_AGRID_3D_RX if trying to use it with EXCH2: |
| 13 |
|
was calling a forward exch2, which is wrong ; used in SEAICE & EXF pkgs. |
| 14 |
|
o testreport (AD-tests): |
| 15 |
|
no longer link files from dir "../input" (1rst link files from |
| 16 |
|
"../input_ad.[xx]" if secondary test "xx" and then from "../input_ad") |
| 17 |
|
|
| 18 |
|
checkpoint62f (2010/04/29) |
| 19 |
|
o model/src/the_main_loop.F: |
| 20 |
|
adjust store directives for seaice evp and multicategory according to |
| 21 |
|
pkg/ecco/the_main_loop.F |
| 22 |
|
o adjoint: |
| 23 |
|
global_sum_ad was incomplete (noted many times by many people ;) |
| 24 |
|
nice description by Jean U. as follows: |
| 25 |
|
* allreduce(var) in global_sum.F can be interpreted as |
| 26 |
|
reduce(sum) followed by broadcast of sum. |
| 27 |
|
* The adjoint of that is |
| 28 |
|
sum(adjoint) followed by broadcast(summed adjoint value) |
| 29 |
|
or in other words, allreduce(sum, adjoint vars) |
| 30 |
|
We were missing the sum(adjoint)! |
| 31 |
|
Benign, except(!) for "global" scalars appearing in tile loops (bi,bj) |
| 32 |
|
(noted by J.M. Campin, e.g., in cost_ssh_mean, variable offset). |
| 33 |
|
The fix should produce 16-digit accuracy between |
| 34 |
|
single-CPU multi-tile (e.g. nSx=2, nPx=1) and |
| 35 |
|
multi-CPU single-tile (e.g. nSx=1, nPx-2) |
| 36 |
|
We'll probably change this yet again shortly |
| 37 |
|
o eesupp/src: |
| 38 |
|
- fix global_sum_r4 (wrong from previous modif in Jun 2009; ever used ?) |
| 39 |
|
o pkg/icefront |
| 40 |
|
- ALLOW_SUBGLACIAL_RUNOFF option adds capability for time-evolving |
| 41 |
|
specification of addmass array based on a 2D field, which is added |
| 42 |
|
at bottommost wet level at each horizontal location. |
| 43 |
|
o model/src: |
| 44 |
|
horizontal grid initialisation (other than curvilinear): add code for Exch2 IO |
| 45 |
|
layout; (not always compatible with delX,delY setting; commented out for now). |
| 46 |
|
o pkg/exch2: |
| 47 |
|
change tile to processor setting (case nSy*nPy > 1): allows default model mapping |
| 48 |
|
(myX and myYGlobalLow) to be used for simple (1 facet, no blank tile) config. |
| 49 |
|
|
| 50 |
|
checkpoint62e (2010/04/15) |
| 51 |
|
o pkg/obcs: |
| 52 |
|
- fix wrong index in OBCS_SPONGE_V for Eastern-OB (reported by David Hebert). |
| 53 |
|
o pkg/dic: |
| 54 |
|
-fix bug in fe_chem.F for multi-tile (nSx*nSy > 1) set-up; |
| 55 |
|
(note: not presently tested in any forward verification exp.) |
| 56 |
|
update tutorial_global_oce_biogeo AD output file. |
| 57 |
|
o pkg/exf: |
| 58 |
|
- account for the variation of albedo as a function of zenith angle |
| 59 |
|
by defining ALLOW_ZENITHANGLE in EXF_OPTIONS.h |
| 60 |
|
o build_options: |
| 61 |
|
- rename "linux_ia64_ifort+mpi_ice_nas" to "linux_amd64_ifort+mpi_ice_nas" |
| 62 |
|
o pkg/dic: |
| 63 |
|
change DIC atmos-CO2 box (method 3, dic_int1=3) initialisation & restart: |
| 64 |
|
- use binary pickup file for restart; |
| 65 |
|
- initialise atmos-CO2 box from dic_pCO2 parameter; |
| 66 |
|
- fix multi-threaded. |
| 67 |
|
o pkg/rbcs: |
| 68 |
|
- clean-up RBCS code: add RBCS_OPTIONS.h file ; fix multi-threaded ; |
| 69 |
|
change (+ fix IO calls) type of array RBC_mask from _RL to _RS. |
| 70 |
|
- add RBCS to exp4 passive tracer 01 (rbcs was previously untested) |
| 71 |
|
and update output.txt |
| 72 |
|
o pkg/kpp: |
| 73 |
|
- add diagnostics for KPP non-local flux of Temp, Salinity and pTracers; |
| 74 |
|
- change diagnostic of KPP non-local term: output average of KPPghat*KPPdiffKzS |
| 75 |
|
(= ratio of KPP non-local (salt) flux relative to surface-flux) when |
| 76 |
|
using pkg/timeave & pkg/diagnostics (diag 'KPPghatK' replaces 'KPPghat '); |
| 77 |
|
- change pkg/offline to read-in average KPPghat*KPPdiffKzS from file |
| 78 |
|
KPP_ghatKFile (instead of the average of KPPghat from file KPP_ghatFile). |
| 79 |
|
o pkg/offline: |
| 80 |
|
fix bug in S/R OFFLINE_FIELDS_LOAD regarding surfaceForcing conversion factor |
| 81 |
|
(bug was added in version 1.10 on 2007-08-23). |
| 82 |
|
o pkg/offline: |
| 83 |
|
- no need to specify periodicExternalForcing, etc ... to use offline pack |
| 84 |
|
- offline input files no longer just single prec --> parameter offlineLoadPrec |
| 85 |
|
o verification/lab_sea: |
| 86 |
|
change AD test to multi-tile setup and update all 4 AD output. |
| 87 |
|
NOTE: while cost function values remain very similar, |
| 88 |
|
gradients are very different, although gradient checks are self-consistent |
| 89 |
|
Should try to get to the bottom of this (cost function summation order?) |
| 90 |
|
o pkg/dic: |
| 91 |
|
in carbon_chem.F, replace log10 (AUTODIFF) with explicit form to avoid |
| 92 |
|
a weakness of TAF that drops part of double precision in log10 derivative. |
| 93 |
|
<= changes removed since problem has been fixed in current TAF version 1.9.71 |
| 94 |
|
update AD output of exp. tutorial_dic_adjoffline & tutorial_global_oce_biogeo. |
| 95 |
|
o pkg/ecco: |
| 96 |
|
add missing "_d 0" in cost_readers.F, cost_readtopex.F & cost_readtopexmean.F |
| 97 |
|
update all 4 lab_sea AD output. |
| 98 |
|
|
| 99 |
|
checkpoint62d (2010/03/22) |
| 100 |
|
o build_options: |
| 101 |
|
remove '-r8' (and '-i4') from linux_*pgf and linux_*ifort optfiles. |
| 102 |
|
o remove unbalanced quote (single or double) in commented line of source code |
| 103 |
|
(may cause some warning with some preprocessor/makedepend versions). |
| 104 |
|
o pkg/seaice: |
| 105 |
|
fix seaice_model.F for adjoint (gael) and update AD results of experiments |
| 106 |
|
lab_sea (std + evp + noseaicedyn) and offline_exf_seaice. |
| 107 |
|
o testreport: |
| 108 |
|
add option '-runonly' (short: '-ro') to just do the run part (without make). |
| 109 |
|
o eesupp: remove JAM communication code (obsolete). |
| 110 |
|
o add option to genmake2 & testreport to switch "_RS" type to "real*4" |
| 111 |
|
(if allowed in CPP_EEOPTIONS.h); update default CPP_EEOPTIONS.h and return |
| 112 |
|
to default CPP_EEOPTIONS.h for exp. inverted_barometer & solid-body.cs-32x32x1 |
| 113 |
|
(update also the output). |
| 114 |
|
|
| 115 |
|
checkpoint62c (2010/03/02) |
| 116 |
|
o tools/build_options : |
| 117 |
|
move (some) old optfiles from build_options/ to build_options/unsupported/ |
| 118 |
|
o model/src and pkg/exf |
| 119 |
|
surface relaxation -- separating data and data.exf options |
| 120 |
|
The point is to ensure that we specify the surface relaxation |
| 121 |
|
either in data or in data.exf (but not half and half) and to |
| 122 |
|
avoid an accidental relaxation to 0 (which happened if a time |
| 123 |
|
scale was specified but the file name was left empty) |
| 124 |
|
o model/src model/inc and pkg/mom_common |
| 125 |
|
ALLOW_3D_VISCAH/ALLOW_3D_VISCA4 => 3D specification of Viscosity |
| 126 |
|
=> addition to the viscosity field as computed by others schemes |
| 127 |
|
o tools/build_options: |
| 128 |
|
- rename "_generic_mpi" -> "+mpi_generic" (like other "+mpi" optfile) |
| 129 |
|
but keep the former optfile for few weeks for smooth transition |
| 130 |
|
o pkg/ecco |
| 131 |
|
- allow user defined cost function contributions |
| 132 |
|
CPP: ALLOW_USERCOST_CONTRIBUTION |
| 133 |
|
USAGE: compute contributions in cost_usercost_all.F |
| 134 |
|
- note: this is identical to what ALLOW_GENCOST_CONTRIBUTION once was. |
| 135 |
|
the two options are complementary. |
| 136 |
|
o pkg/smooth |
| 137 |
|
- migration from contrib to the main repository |
| 138 |
|
|
| 139 |
|
checkpoint62b (2010/01/26) |
| 140 |
|
o pkg/monitor: |
| 141 |
|
- change back mon_printstats_rl.F & mon_stats_rl.F and add a stop |
| 142 |
|
(in case someone forgot to update customized pieces of code) |
| 143 |
|
o nonHydrostatic: |
| 144 |
|
- add Non-hydrostatic free-surface form (selectNHfreeSurf=1)(not fully tested); |
| 145 |
|
- add a simple 2-D experiment (short_surf_wave) to test it. |
| 146 |
|
o pkg/icefront: |
| 147 |
|
adding the shell of, and the hooks to, a new package that |
| 148 |
|
will model melting and freezing of vertical glacier ice fronts |
| 149 |
|
o momentum: |
| 150 |
|
add diagnostics of momentum tendency from Hydrostatic pressure gradient |
| 151 |
|
(without surf.pressure term: would need a 2nd filling since implicit term). |
| 152 |
|
o add 3 "_d 0"s so that fizhi compiles with xlf on iblade, and replace |
| 153 |
|
two " &end" by " &" (in fizhi-cs-*) because S/R NML_SET_TERMINATOR |
| 154 |
|
cannot deal with the former |
| 155 |
|
o cleaning: |
| 156 |
|
- remove all (except OpenAD) old TLM output from results_ad dirs. |
| 157 |
|
- remove unused S/R (MDSWRITEMETA, DIAGNOSTICS_ADD2LIST, old DFILE IO S/R) |
| 158 |
|
- comment out maskH definition (replaced by maskInC) |
| 159 |
|
o pkg/monitor: |
| 160 |
|
- change mon_printstats_rl.F & mon_stats_rl.F (were similar to mon_writestats_rl |
| 161 |
|
& mon_calc_stats_rl) to be the RL equivalent of mon_printstats_rs & mon_stats_rs. |
| 162 |
|
|
| 163 |
|
checkpoint62a (2010/01/15) |
| 164 |
|
o model/src: |
| 165 |
|
- bottom pressure diagnostic: correct for r* (when nonlinFreeSurf >= 4) |
| 166 |
|
o pkg/diagnostics: |
| 167 |
|
- add optional level number diagnostics (i.e., level number to be define |
| 168 |
|
explictly with S/R DIAGNOSTICS_SETKLEV) with parser-code(10)="X". |
| 169 |
|
- strictly check for valid parser-code(10) ; |
| 170 |
|
- check if adding diag to the list from the right place. |
| 171 |
|
o pkg/longstep: |
| 172 |
|
- change parameters and fix tracer conservation with rstar/nonlinear free surface |
| 173 |
|
o diagnostics: |
| 174 |
|
- in all pkgs, replace remaining calls to old S/R DIAGNOSTICS_ADD2LIST with newer |
| 175 |
|
S/R DIAGNOSTICS_ADDTOLIST ; fix seaice VICE diagnostics. |
| 176 |
|
o pkg/diagnostics: |
| 177 |
|
- Add option for writing vertical integral (sum of selected levels) of an output |
| 178 |
|
field instead of writing output field levels. Activate this option on a per |
| 179 |
|
output-file basis, by setting the 2nd character of fileflag to 'I'. |
| 180 |
|
- Add field-specific information relative to level integral in 3rd postion |
| 181 |
|
of parser diagnostics code (gdiag): " "=cumulate levels, "R"=integrate |
| 182 |
|
vertically (x level-thickness x hFac), "r"=same but without hFac. |
| 183 |
|
o do_the_model_io: |
| 184 |
|
- pass end-of-model-run flag as argument, from forward_step to diagnostics_write: |
| 185 |
|
in case useSIGREG, will write (averaged) diagnostics (if dumpAtLast) before |
| 186 |
|
writing pickups and stopping. |
| 187 |
|
o pkg/diagnostics (for now, only with mdsio): |
| 188 |
|
- write time information to meta file (and modify accordingly rdmds.m) : |
| 189 |
|
time-averaged diagnostics output: write starting and ending time of the |
| 190 |
|
time-averaging interval ; snap-shot diagnostics output remains unchanged; |
| 191 |
|
o pkg/timeave: |
| 192 |
|
- S/R TIMEAVE_NORMALIZ: change size of cumulated-time array (was previously |
| 193 |
|
always Nr), now assumed to be equal to number of levels of averaged field; |
| 194 |
|
only used for DIC_COST monthly mean arrays: this fixes dic_aver_final.F |
| 195 |
|
o pkg/sbo: |
| 196 |
|
- fix ocean bottom pressure global-average & 2-D time-ave output (was |
| 197 |
|
neither initialised nor filled). |
| 198 |
|
- add starting iteration in suffix of global-average output file |
| 199 |
|
(to avoid over-writing the file after a restart) |
| 200 |
|
- use standard MDSIO pkg S/R instead of SBO_WRITEVECTOR (fix byte-swap Pb). |
| 201 |
|
o time-average: |
| 202 |
|
- use simple cumulative-time array (no k index) in all pkgs: {PKG}_timeAve(bi,bj) |
| 203 |
|
(pkgs: aim_v23, bulk_force, dic, gmredi, kpp, land, ocn_compon_interf, |
| 204 |
|
ggl90, my82, opps, pp81, ptracers, sbo, seaice, shelfice, thsice) |
| 205 |
|
this fix DIC_COST cumulative-time array (previously: bi,bj,k) |
| 206 |
|
- fix 1rst call (nIter0) snap-shot output and accumulation (pkg/shelfice) |
| 207 |
|
- fix missing accumulation for pkg/opps. |
| 208 |
|
- cumulate fields only if doing time-ave output ({PKG}_taveFreq > 0) |
| 209 |
|
(pkgs: ptracers, kpp, ocn_compon_interf, ggl90, my82, pp81); |
| 210 |
|
- fix initialisation of time-ave vars and do only full time-step increment |
| 211 |
|
(i.e.: no first & last "half time-step") (pkgs: ggl90, my82, opps, pp81); |
| 212 |
|
o pkg/layers: |
| 213 |
|
- use standard RW pkg S/R to write the output |
| 214 |
|
and remove local write_fld version (which had a problem). |
| 215 |
|
- use simple cumulative-time array (no level index) to fix time-ave S/R calls. |
| 216 |
|
- fix LAYERS_CALC argument list. |
| 217 |
|
o pkg/timeave: |
| 218 |
|
- store cumulative-time in a simple tiled array (drop the level index) |
| 219 |
|
- add new S/R (TIMEAVE_NORMALIZE) which uses simple cumulative-time array. |
| 220 |
|
o pkg/ocn,aim_compon_interf |
| 221 |
|
- changes for multi-threaded coupled run. (tested with ifort-11 on danton) |
| 222 |
|
|
| 223 |
|
checkpoint62 (2009/12/23) |
| 224 |
|
o switch on useOBCSbalance in tutorial_plume_on_slope exp. and update output. |
| 225 |
|
(was not previously tested in any other exp.) |
| 226 |
|
o pkg/monitor: |
| 227 |
|
- clean-up _RL/_RS version: add specific S/R for statistics with mask & volume: |
| 228 |
|
mon_writestats_rl/s,F mon_calc_stats_rl/s.F ; will keep the old one |
| 229 |
|
(mon_printstats_rl/s,F mon_stats_rl/s.F) just for bare statistics. |
| 230 |
|
- use hFac & 2-D mask (instead of 3-D mask + hFac in previous mon_stats_rl.F). |
| 231 |
|
- change del2 calculation. |
| 232 |
|
- use interior masks (instead of maskH, <- to be remove). |
| 233 |
|
- shorter monitor suffix for forcing stats ("forcing" instead of "extforcing"). |
| 234 |
|
o mask & obcs: |
| 235 |
|
- define 2-D "interior" masks (i.e., zero beyond OB) at 3 locations (C, W & S). |
| 236 |
|
- move global area computation from ini_masks_etc.F to ini_linear_phisurf.F |
| 237 |
|
(called after packages_init_fixed) |
| 238 |
|
o pkg/obcs: |
| 239 |
|
- move bi,bj loops into obcs_calc, so obcs_prescribe_read is called only once. |
| 240 |
|
Fixes bug in obcs+exf with nSx*nSy.GT.1 |
| 241 |
|
- fix multi-tile handling in obcs balance code |
| 242 |
|
o nonHydrostatic: |
| 243 |
|
- Implement AB-3 for non-hydrostatic vertical momentum ; |
| 244 |
|
(change ordering of var. stored in pickup file when using NH) |
| 245 |
|
- move NH code from solve_for_pressure.F to 2 new S/R: PRE_CG3D & POST_CG3D. |
| 246 |
|
- add 2-D field to store Hydrostatic Surface Pressure adjusment from cg3d_x |
| 247 |
|
(in prep. for new NH free surface form). |
| 248 |
o pkg/obcs: |
o pkg/obcs: |
| 249 |
add files & OB-variables for wVel (Non-Hydrostatic) with useOBCSprescribe |
add files & OB-variables for wVel (Non-Hydrostatic) with useOBCSprescribe |
| 250 |
o model/src: |
o model/src: |
| 251 |
fix 2-D solver initialisation for deep-atmosphere (p-coord) with topography |
fix 2-D solver initialisation for deep-atmosphere (p-coord) with topography |
| 252 |
|
|
| 253 |
checkpoint61z (2009/12/01) |
checkpoint61z (2009/12/01) |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch