| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/seaice/seaice_preconditioner.F : fix cpp flags, so that code also |
| 8 |
|
compiles when SEAICE_ALLOW_DYNAMICS is undefined |
| 9 |
|
o global_oce_llc90,cs32 : ecco_v4 verification exps now use separate |
| 10 |
|
AUTODIFF_OPTIONS.h, CTRL_OPTIONS.h, ECCO_OPTIONS.h rather than |
| 11 |
|
ECCO_CPPOPTIONS.h (i.e. replacing the deprecated, circumvoluted, |
| 12 |
|
approach where CPP_OPTIONS.h includes an omnipotent |
| 13 |
|
ECCO_CPPOPTIONS.h that superseeds pkgs '_OPTIONS.h'). |
| 14 |
|
o pkg/ctrl/ctrl_map_ini_genarr.F : include GMREDI_OPTIONS.h where |
| 15 |
|
ALLOW_3D_KAPGM, ALLOW_3D_KAPREDI (to be added later) belong. |
| 16 |
|
o pkg/seaice/SEAICE_SIZE.h : replace ALLOW_AUTODIFF_TAMC with ALLOW_AUTODIFF |
| 17 |
|
to avoid needing AUTODIFF_OPTIONS.h anytime SEAICE_SIZE.h is included |
| 18 |
|
(it seems that THSICE_SIZE.h, PTRACERS_SIZE.h have the same issue...) |
| 19 |
|
o model/src, pkg/smooth, profiles, salt_plume, seaice, exf, ecco, ctrl : |
| 20 |
|
add ECCO_OPTIONS.h, AUTODIFF_OPTIONS.h, CTRL_OPTIONS.h when needed |
| 21 |
|
- ECCO_OPTIONS.h is needed when including ecco_cost.h, ecco.h |
| 22 |
|
- AUTODIFF_OPTIONS.h is needed when including tamc.h, tamc_keys.h |
| 23 |
|
- CTRL_OPTIONS.h is needed when including ctrl.h, optim.h, etc |
| 24 |
|
o pkg/ctrl,ecco,exf : |
| 25 |
|
- remove variables associated with NON-generic costs, |
| 26 |
|
unless ECCO_CTRL_DEPRECATED is defined. |
| 27 |
|
- remove NON-generic NON-obcs controls, |
| 28 |
|
unless ECCO_CTRL_DEPRECATED is defined. |
| 29 |
|
o pkg/ctrl : added ctrl_local_params.h |
| 30 |
|
o pkg/ecco : added ecco_local_params.h |
| 31 |
|
o verification : added ECCO_CTRL_DEPRECATED to most as and oad |
| 32 |
|
experiments, which will progressively be removed once the |
| 33 |
|
experiments are revised to use only generic controls/costs. |
| 34 |
|
|
| 35 |
|
checkpoint65f (2014/10/13) |
| 36 |
|
o pkg/ctrl, ecco, seaice : minor changes in headers |
| 37 |
|
o global_oce_llc90,cs32 : ecco_v4 verification exps now test generic |
| 38 |
|
cost function and control capabilities added since checkpoint65c. |
| 39 |
|
o pkg/ctrl: regroup all obcs ctrl variables in CTRL_OBCS.h. |
| 40 |
|
o pkg/ecco: increase modularity and improve logic |
| 41 |
|
- ecco_toolbox.F (new) : basic operations that are often used, |
| 42 |
|
including ecco_zero, ecco_cp, ecco_cprsrl, ecco_diffmsk, |
| 43 |
|
ecco_addcost, ecco_add, ecco_div, ecco_readbar. |
| 44 |
|
- cost_gencal.F (new) : determine filnames and records. |
| 45 |
|
- cost_genread.F, cost_generic.F : condense code using ecco_toolbox. |
| 46 |
|
- cost_generic.F : use spzeroloc rather than hard-coded -9999, |
| 47 |
|
and exploit the above functions leading to more compact code. |
| 48 |
|
- cost_genread.F : rm un-necessary arguments, re-arrange args order. |
| 49 |
|
- ecco_check.F, ecco_readparms.F : bring logic up to date (using_tpj, |
| 50 |
|
using_ers, using_gfo, using_mdt is now only defined within gencost) |
| 51 |
|
o pkg/ecco: extend generic cost capabilities |
| 52 |
|
- pkg/ecco : added 3D gencost (ALLOW_GENCOST3D), added gencost |
| 53 |
|
capabilities via gencost_preproc (+ _c,_i,_r related params), |
| 54 |
|
gencost_posproc (+ _c,_i,_r related params), gencost_nrecperiod, |
| 55 |
|
gencost_outputlevel arguments to cost_generic |
| 56 |
|
- pkg/ecco/cost_genread.F (new) : interface between cost_generic |
| 57 |
|
and active_read, making room for gencost_preproc to take effect. |
| 58 |
|
Added preproc code ('climmon') to replace GENERIC_BAR_MONTH. |
| 59 |
|
- pkg/ecco/cost_generic.F : |
| 60 |
|
compute and store misfit maks*(model-data) in localdif that is |
| 61 |
|
then used in cost and for output, output misfit if outlev.GT.0 |
| 62 |
|
- pkg/ecco/cost_averagesfields.F : depend on gencost_barskip |
| 63 |
|
rather gencost_barfile for deciding whether to write barfile |
| 64 |
|
- pkg/ecco/ecco_cost_driver.F : extract call to cost_profiles from cost_hyd |
| 65 |
|
- pkg/ecco/ecco_cost_init_fixed.F : extract gencost weights from |
| 66 |
|
ecco_cost_weights, re-activate ecco_summary, determine gencost_barskip |
| 67 |
|
- pkg/ecco/ecco_summary.F : report gencost variables |
| 68 |
|
- pkg/ecco/cost_gencost_customize.F : treat case of scatterometer costs |
| 69 |
|
o pkg/sea/SEAICE_OPTIONS.h : add ALLOW_COST_ICE, ALLOW_SEAICE_COST_SMR_AREA |
| 70 |
|
o pkg/ecco: internal re-organization |
| 71 |
|
- resolve un-necessary dependancies within pkg/ecco and to pkg/ctrl |
| 72 |
|
(rm includes of optim.h and ctrl.h, replace optimcycle with eccoiter, |
| 73 |
|
mv relevant variables definition from ecco_cost.h to ecco.h, |
| 74 |
|
make sure gencost routines only include ecco.h) |
| 75 |
|
- throughout : add missing CCP switches, rm unused variables, |
| 76 |
|
and rm un-necessary CPP switches |
| 77 |
|
- throughout gencost routines : replace modelstartdate with |
| 78 |
|
gencost_startdate when needed |
| 79 |
|
- cost_bp_read.F : use arguments, instead of common blocs |
| 80 |
|
so that it can be used also by (new) cost_gencost_bpv4.F |
| 81 |
|
- ecco_init_varia.F : initialize RHOsumGlob_0, VOLsumGlob_0 |
| 82 |
|
- ecco_phys.F : compute etanFull |
| 83 |
|
- ecco_readparms.F : rename using_topex as using_tpj, add |
| 84 |
|
bpv4-grace to gencost list, initialize added parameters |
| 85 |
|
- ecco_summary.F : include SIZE.h needed for augmented ecco.h |
| 86 |
|
|
| 87 |
|
checkpoint65e (2014/09/28) |
| 88 |
|
o pkg/obcs: |
| 89 |
|
- replaced the just-added CPP options with run-time variables |
| 90 |
|
(see pkg/obcs/OBCS_PARAMS.h for details) |
| 91 |
|
o pkg/obcs: |
| 92 |
|
- add additional CPP options for sponge boundary layers |
| 93 |
|
(see pkg/obcs/OBCS_OPTIONS.h for details) |
| 94 |
|
o pkg/atm_phys: |
| 95 |
|
- implement simple (obliquity only, assuming circular planet orbit) |
| 96 |
|
seasonal cycle for incoming insolation ; used when run-time parameter |
| 97 |
|
"select_incSW" is set to 1 ; by default (=0), uses old unchanged formula. |
| 98 |
|
o pkg/exf, pkg/ecco, pkg/ctrl: |
| 99 |
|
- add ctrlUseGen and .NOT.ctrlUseGen exclusive brackets |
| 100 |
|
- activate gentim2d for xx_atemp,xx_aqh,xx_swdown,xx_lwdown,xx_precip |
| 101 |
|
- implement gentim2d for xx_tauu, xx_tauv |
| 102 |
|
o pkg/ctrl, pkg/ecco : |
| 103 |
|
- fix and complement the generic controls implementation |
| 104 |
|
o pkg/exf/exf_getclim.F, exf_getffields.F, exf_getsurfacefluxes.F, |
| 105 |
|
pkg/shelfice/shelfice_thermodynamics.F, |
| 106 |
|
verification/hs94.1x64x5/code_ad/ctrl_map_gentim2d.F, |
| 107 |
|
verification/hs94.1x64x5/code_oad/ctrl_map_gentim2d.F : |
| 108 |
|
- add weight in CTRL_GET_GEN calls |
| 109 |
|
o pkg/ctrl : |
| 110 |
|
- ctrl_get_gen.F : add weight as input parameter, and apply |
| 111 |
|
it directly rather than using smooth_correl2Dw (to be retired). |
| 112 |
|
- ctrl_map_gentim2d.F : add wgentim2d in CTRL_GET_GEN call |
| 113 |
|
o pkg/ctrl : |
| 114 |
|
- introduce run time switch ctrlUseGen (in ctrl.h, ctrl_check.F, |
| 115 |
|
ctrl_init_variables.F, ctrl_readparms.F, ctrl_summary.F) |
| 116 |
|
- re-activate ctrl_summary (call in ctrl_init.F) |
| 117 |
|
o pkg/ctrl/ctrl_cost_gen.F : |
| 118 |
|
- fix CCP brackets, remove un-necessary myiter, mytime |
| 119 |
|
o pkg/ecco, pkg/ctrl : |
| 120 |
|
- remove cost_genctrl.F (now pkg/ctrl/ctrl_cost_driver.F) |
| 121 |
|
- remove cost_forcing_gen.F (now pkg/ctrl/ctrl_cost_gen2d.F) |
| 122 |
|
- add ctrl_cost_driver.F (replaces pkg/ecco/cost_genctrl.F) |
| 123 |
|
- add ctrl_cost_gen2d.F (replaces pkg/ecco/cost_forcing_gen.F) |
| 124 |
|
|
| 125 |
|
checkpoint65d (2014/09/15) |
| 126 |
|
o pkg/ctrl/CTRL_GENARR.h, ctrl_readparms.F : |
| 127 |
|
- add xx_genarr2d_bounds,xx_genarr3d_bounds, |
| 128 |
|
xx_genarr2d_numsmooth, xx_genarr3d_numsmooth |
| 129 |
|
o pkg/ctrl/ctrl_map_ini_genarr.F : |
| 130 |
|
- remove compilation failure |
| 131 |
|
- replace hard coded example |
| 132 |
|
- use ctrl_map_ini_gen2D, 3D |
| 133 |
|
o pkg/ctrl/ctrl_pack.F, ctrl_unpack.F : |
| 134 |
|
- on/off switch based upon xx_genarr2d_weight,3d |
| 135 |
|
o src/packages_init_variables.F : |
| 136 |
|
- regroup pkg/estimation calls |
| 137 |
|
- remove CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
| 138 |
|
(moved to ctrl_init_variables) |
| 139 |
|
o cost/cost_init_varia.F : |
| 140 |
|
- remove ecco_cost_init_varia |
| 141 |
|
(moved to ecco_init_varia) |
| 142 |
|
o ctrl/ctrl_init_variables.F : |
| 143 |
|
- add CTRL_MAP_INI, CTRL_MAP_INI_ECCO |
| 144 |
|
- add CTRL_MAP_INI_GENARR, SEAICE_CTRL_MAP_INI |
| 145 |
|
o ctrl/ctrl_map_ini.F : |
| 146 |
|
- remove ctrl_map_ini_genarr, seaice_ctrl_map_ini |
| 147 |
|
(moved to ctrl_init_variables) |
| 148 |
|
o ctrl/ctrl_map_ini_ecco.F : |
| 149 |
|
- remove ECCO_PHYS (mv to ecco_init_varia) |
| 150 |
|
- remove seaice_ctrl_map_ini (mv to ctrl_init_variables) |
| 151 |
|
o ecco/ecco_ad_diff.list : |
| 152 |
|
- add ecco_init_varia.f |
| 153 |
|
o ecco/ecco_init_varia.F |
| 154 |
|
- new routine |
| 155 |
|
o pkg/streamice: |
| 156 |
|
- move call to STREAMICE_INITIALIZE_PETSC from the_model_main.F |
| 157 |
|
to streamice_init_fixed.F ; fix setting of STREAMICEisOn. |
| 158 |
|
- from model/src, only call pkg/streamice routines if useStreamIce is TRUE. |
| 159 |
|
o pkg/generic_advdiff: |
| 160 |
|
- fix bug causing negatives in GAD_SMOLARKIEWICZ_HACK, introduced 8/8/2014. |
| 161 |
|
o pkg/exf: |
| 162 |
|
- exf_getffields.F : add xxg_atemp, xxg_aqh, xxg_swdown, xxg_lwdown, |
| 163 |
|
xxg_precip capability |
| 164 |
|
- exf_wind.F : no need for ALLOW_WSPEED_CONTROL cpp switch |
| 165 |
|
o pkg/ctrl: |
| 166 |
|
- ctrl_pack.F, ctrl_unpack.F : omit (un)packing of undefined xx_gentim2d |
| 167 |
|
o model/src/load_fields_driver.F : |
| 168 |
|
- move call to CTRL_MAP_GENTIM2D ahead of BULKF_FIELDS_LOAD, EXF_GETFORCING |
| 169 |
|
so xx_gentim2d can be applied to e.g. exf fields in a timely manner. |
| 170 |
|
o OpenAD verification experiments: |
| 171 |
|
- Include explicitly AUTODIFF_OPTIONS.h, COST_OPTIONS.h, and CTRL_OPTIONS.h |
| 172 |
|
in src files (to enable to skip the ECCO_CPPOPTIONS.h); |
| 173 |
|
for now, only in pkgs used in OpenAD verification experiments. |
| 174 |
|
- Change all except one (halfpipe_streamice) OpenAD experiments to use pkg |
| 175 |
|
specific option file (AUTODIFF_OPTIONS.h, COST_OPTIONS.h & CTRL_OPTIONS.h) |
| 176 |
|
instead of using ECCO_CPPOPTIONS.h (with all relevant options in it). |
| 177 |
|
This applies to both TAF (*/code_ad/) and OpenAD (*/code_oad/) tests. |
| 178 |
|
o OpenAD verification tests: |
| 179 |
|
- finish removing ALLOW_AUTODIFF_OPENAD (replaced by ALLOW_OPENAD); |
| 180 |
|
- finish replacing ALLOW_AUTODIFF_TAMC by ALLOW_AUTODIFF (except for |
| 181 |
|
tape/storage which are specific to TAF/TAMC) in pkgs used in OpenAD exp. |
| 182 |
|
- leave ALLOW_AUTODIFF_TAMC undef in OpenAD verification tests (*/code_oad/) |
| 183 |
|
and remove local copy of "tamc.h" (needed only if ALLOW_AUTODIFF_TAMC). |
| 184 |
|
o model/src & generic_advdiff: |
| 185 |
|
- change hard-coded loop-range in S/R APPLY_FORCING_T/S to set T & S |
| 186 |
|
forcing over 0:sNx+1, 0:sNy=1 (instead of just 1:sNx,1:sNy): Model |
| 187 |
|
dynamics requires valid tracer forcing only over tile interior but, for |
| 188 |
|
some diagnostics, may need to extend it over 1 point in tile halo region. |
| 189 |
|
- in gad_calc_rhs.F, update calls to gmredi_x/ytransport to get valid |
| 190 |
|
tendency over i,j_Min,Max range. This allows to simplfy i,j_Min,Max |
| 191 |
|
setting in temp/salt/ptracer_integrate.F |
| 192 |
|
o pkg/dic: |
| 193 |
|
- multiply tracer tendencies by maskInC (if ussing OBCS) before updating |
| 194 |
|
gchem tracers: this allows to skip the 2nd call to OBCS_APPLY_PTRACER |
| 195 |
|
in gchem_forcing_sep.F |
| 196 |
|
o pkg/autodiff & obcs: |
| 197 |
|
- add storage of current OB values for U & V (was already done for T & S). |
| 198 |
|
|
| 199 |
|
checkpoint65c (2014/08/30) |
| 200 |
|
o pkg/dic: |
| 201 |
|
- take out of dic_atmos.F the initialisation part (corresponding to istate=0) |
| 202 |
|
and move it to new S/R DIC_INI_ATMOS ; also simplify the dependencies for |
| 203 |
|
AD compilers (but still a Pb with multi-threading and Ajoint dependencies). |
| 204 |
|
o verification: |
| 205 |
|
- new experiment testing OBCS and DIC pkgs, using params & output from |
| 206 |
|
tutorial_global_oce_biogeo but limited to a sub-domain around Drake |
| 207 |
|
passage: take OBCS from the last year of a 2 yrs simulation and initial |
| 208 |
|
conditions from t=1.yr while keeping the same forcing. |
| 209 |
|
o model/src: |
| 210 |
|
- when allowFreezing=T, only reset below freezing initial Temp to Tfreezing |
| 211 |
|
(at any k) if checkIniTemp is not set to FALSE (default checkIniTemp=T). |
| 212 |
|
o pkg/diagnostics (Stats-Diags): |
| 213 |
|
- re-write S/R DIAGSTATS_CALC (more similar to TARGET_NEC_SX part) to: |
| 214 |
|
a) refine region where stats are computed, excluding where arrhFac=0 ; |
| 215 |
|
b) fix missing interior mask (use with OBCS) in 3-D fields statistics; |
| 216 |
|
c) extend regional stats over the region edges (for U or V pt location). |
| 217 |
|
o pkg/gchem: |
| 218 |
|
- add a (2nd) call to OBCS_APPLY_PTRACER in gchem_forcing_sep.F (needed since |
| 219 |
|
pkg/dic is currently changing/updating ptracers values beyond the OB). |
| 220 |
|
o verification (hs94): |
| 221 |
|
- convert Held & Suarez external_forcing.F (from hs94.cs, with Sigma-coords |
| 222 |
|
bits) to apply_forcing.F and undef USE_OLD_EXTERNAL_FORCING in experiments |
| 223 |
|
hs94.cs-32x32x5 and tutorial_held_suarez_cs ; also use the same version of |
| 224 |
|
apply_forcing.F in 2D hs94 (fwd, ad & oad) but keep LatLon hs94 unchanged. |
| 225 |
|
o pkg/ptracers: |
| 226 |
|
- implement Adams-Bashforth on pTracers (instead of on tracer tendency), |
| 227 |
|
switched on by setting PTRACERS_doAB_onGpTr=F (default set to doAB_onGtGs) |
| 228 |
|
- change exp4 secondary test (input.nlfs) to test AB on T & S & pTracer |
| 229 |
|
with AB-2 code (so that it get tested). |
| 230 |
|
o model/src: |
| 231 |
|
- allow to apply Adams-Bashforth on Temp & Salt (instead of on gT,gS) |
| 232 |
|
with AB-2 code (previously only available with AB-3 code). |
| 233 |
|
Also move the code (call to ADAMS_BASHFORTH S/R) form thermodynamics.F |
| 234 |
|
to temp/salt_integrate.F (since the 2nd part of gt/sNm1 update is done |
| 235 |
|
there, by calling CYCLE_AB_TRACER). |
| 236 |
|
o pkg/generic_advdiff: |
| 237 |
|
- change Tracer argument (drop bi,bj indices) in S/R GAD_CALC_RHS, |
| 238 |
|
GAD_C2_ADV_R, GAD_U3_ADV_R, GAD_C4_ADV_R, GAD_DIFF_R, GAD_BIHARM_R |
| 239 |
|
+ also in GMREDI_X/Y/RTRANSPORT ; and update corresponding calls in |
| 240 |
|
S/R temp/salt/ptracers_integrate.F |
| 241 |
|
o model/src & pkg/ptracers: |
| 242 |
|
- remove common block variables gT,gS (in DYNVARS.h), except when |
| 243 |
|
USE_OLD_EXTERNAL_FORCING is defined; update TAF storage accordingly. |
| 244 |
|
- remove common block variable gPtr. |
| 245 |
|
o model/src & pkgs: |
| 246 |
|
- change gTracer (and/or tracer) argument (drop bi,bj indices) in S/R |
| 247 |
|
ADAMS_BASHFORTH(2&3), CYCLE_(AB_)TRACER, FREESURF_RESCALE_G, |
| 248 |
|
IMPLDIFF, SOLVE_TRIDIAGONAL & _PENTADIAGONAL, GAD_SOM_ADVECT, |
| 249 |
|
GAD_ADVECTION, GAD_CALC_RHS, GAD_IMPLICIT_R, TIMEAVE_CUMUL_DIF_1T |
| 250 |
|
+ change accordingly all calling S/R. |
| 251 |
|
- use local temperature/salinity/ptracer tendency array (without bi,bj) |
| 252 |
|
in S/R temp/salt/ptracers_integrate.F |
| 253 |
|
o pkg/seaice: |
| 254 |
|
- move computation of stress contributions to rhsU/V in s/r seaice_lsr |
| 255 |
|
to separate s/r seaice_lsr_rhsu/v in order to be able to re-use code |
| 256 |
|
- make u/vIceC local variables if SEAICE_CGRID is defined only to be used |
| 257 |
|
in seaice_lsr |
| 258 |
|
- seaice_lsr.F: make local 4D arrays UXX, VYY, etc 2D |
| 259 |
|
in s/r seaice_lsr_calc_coeffs |
| 260 |
|
o pkg/mdsio: |
| 261 |
|
- in MDS_READ/WRITE_FIELD, stop if file-name (+prefix) is too long |
| 262 |
|
(e.g., > MAX_LEN_MBUF -90 ) or, in INI_MODEL_IO, if mdsioLocalDir is |
| 263 |
|
too long (e.g., > MAX_LEN_FNAM/2 ) |
| 264 |
|
|
| 265 |
|
checkpoint65b (2014/08/12) |
| 266 |
|
o pkg/matrix: |
| 267 |
|
- pass, as argument, updated tracer field to S/R MATRIX_STORE_TENDENCY_EXP |
| 268 |
|
o model/src: |
| 269 |
|
- fix initialisation of geothermalFile; compile geothermal-flux code in |
| 270 |
|
natl_box verification experiment. |
| 271 |
|
o model/src & pkg/down_slope: |
| 272 |
|
- push the k loop inside S/R TIMESTEP_TRACER (now called outside the k loop). |
| 273 |
|
- in dwnslp_apply.F, update tracer tendency instead of the future tracer |
| 274 |
|
field and call S/R DWNSLP_APPLY before TIMESTEP_TRACER; this affects |
| 275 |
|
results at machine truncation level: update output of experiments |
| 276 |
|
global_ocean.90x40x15.dwnslp (FWD) and lab_sea.noseaicedyn (AD). |
| 277 |
|
o pkg/diagnostics (Stats-Diags): |
| 278 |
|
- do not cumulate the full volume when DIAGNOSTICS_FILL is |
| 279 |
|
called with bibjFlg < 0 (no increment of the counter for 2D/3D diag); |
| 280 |
|
This fix the mean statistics when DIAGNOSTICS_FILL is called multiple |
| 281 |
|
times (but Min,Max and StD are still wrong). |
| 282 |
|
o model/src: |
| 283 |
|
- add geothermal flux forcing: read in ini_forcing.F as time-constant |
| 284 |
|
field "geothermalFlux" applied in S/R APPLY_FORCING_T (apply_forcing.F) |
| 285 |
|
o model/src: |
| 286 |
|
- move CYCLE_TRACER calls from tracers_correction_step.F to temp/salt/ptracer |
| 287 |
|
_integrate.F so that, when leaving S/R THERMODYANMICS, theta,salt and pTrac |
| 288 |
|
arrays are already updated while adjustments (filters, conv.adjustment) are |
| 289 |
|
still applied later, in S/R TRACERS_CORRECTION_STEP. |
| 290 |
|
o model/src: |
| 291 |
|
- store in common bloc array "rhoInSitu" the virtual potential temperature |
| 292 |
|
anomaly that is used to compute geopotential: this make the atmos code |
| 293 |
|
more similar to ocean code which already uses rhoInSitu in calc_phi_hyd.F |
| 294 |
|
o pkg/seaice/seaice_lsr.F |
| 295 |
|
- rename integer variable ilcall to ipass (that's what it is called |
| 296 |
|
in the residual diagnostics |
| 297 |
|
- change time stepping for NPSEUDOTIMESTEP > 2 (does not change the |
| 298 |
|
default) for improved non-linear convergence of the first few steps |
| 299 |
|
- adjust a few comments and add new ones to explain some of the store |
| 300 |
|
directives |
| 301 |
|
o pkg/generic_advdiff (& ptracers): |
| 302 |
|
- re-work the code to check for valid advection scheme and for minimum |
| 303 |
|
size of overlap (now stored in local common bloc in gad_advscheme.F) |
| 304 |
|
o pkg/seaice: another attempt to make the adjoint work for sea ice dynamics |
| 305 |
|
- re-initialize more variables in seaice_lsr: u/vIceC, u/vIceNm1 |
| 306 |
|
- add an auxilliary variable "bet" and fix store directives and keys in |
| 307 |
|
seaice_lsr_tridiagu/v, this seems to do the trick (i.e. more or |
| 308 |
|
less exact gradients in my tests); but there are still |
| 309 |
|
recomputation warning (although gradients are sort of OK), when |
| 310 |
|
SEAICE_LSR_VECTORIZE is not defined, so this flag and |
| 311 |
|
SEAICE_LSR_VECTORIZE_ZEBRA are recommended for efficiency. |
| 312 |
|
- update verification experiments lab_sea. |
| 313 |
|
- change some comments in S/R seaice_calc_viscosities |
| 314 |
|
o model/src: |
| 315 |
|
- if staggerTimeStep=T, always apply exchange to velocity field in |
| 316 |
|
do_stagger_fields_exchanges.F instead of in do_fields_blocking_exchanges.F |
| 317 |
|
(independent of using multi-dim advection or not); no effect on FWD run |
| 318 |
|
but affects AD results (at machine truncation level): update output of |
| 319 |
|
experiment 1D_ocean_ice_column (ad: 12 digits), hs94.1x64x5 (ad,oad: 13.d) |
| 320 |
|
and isomip (oad: 12.d). |
| 321 |
|
o pkg/generic_advdiff: |
| 322 |
|
- stop if doAB_onGtGs is set to FALSE but ignored |
| 323 |
|
- refine warning related to stability of tracer time-stepping |
| 324 |
|
regarding internal wave dynamics. |
| 325 |
|
- setting of AdamsBashforth_T,S when doAB_onGtGs=F: remove condition |
| 326 |
|
on staggerTimeStep & implicitIntGravWave (will now get a warning |
| 327 |
|
if potentially unstable). |
| 328 |
|
o pkg/kl10: |
| 329 |
|
- add new pkg "kl10" for mixing due to internal wave breaking, from |
| 330 |
|
http://www.sciencedirect.com/science/article/pii/S1463500310000144 |
| 331 |
|
(contribution from Jody Klymak), tested in verification experiment |
| 332 |
|
verification/internal_wave/input.kl10/ |
| 333 |
|
o isomip experiment: |
| 334 |
|
- test pkg/shelfice with Non-Lin Free-Surf in one of the FWD set-up |
| 335 |
|
(input.htd) and update the output. |
| 336 |
|
o cd_code experiments: |
| 337 |
|
- use default cd_code options (#undef CD_CODE_NO_AB_MOMENTUM & |
| 338 |
|
#undef CD_CODE_NO_AB_CORIOLIS) in experiments: cfc_example (fwd) |
| 339 |
|
global_ocean.90x40x15 (ad & oad) and OpenAD (ad & oad) and |
| 340 |
|
update the corresponding output. |
| 341 |
|
o pkg/seaice: |
| 342 |
|
- reduce the number of include files and store directives in |
| 343 |
|
S/R seaice_lsr_tridiagu/v |
| 344 |
|
- change the order of loops in one case in S/R seaice_lsr_tridiagv |
| 345 |
|
(only for SEAICE_VECTORIZE_LSR_ZEBRA defined), which allows me to |
| 346 |
|
get rid off one store directive (a TAF bug?) |
| 347 |
|
- add one more instance of ifdef SEAICE_VECTORIZE_LSR_ZEBRA in |
| 348 |
|
S/R seaice_lsr_tridiagv to change the loop range for consistency |
| 349 |
|
- remove ilcall, m from parameter list of S/R seaice_lsr_tridiagu/v |
| 350 |
|
- fix a bug that affects the JFNK solver: replace sNx/y by i/jMax in |
| 351 |
|
S/R seaice_lsr_tridiagu/v (requires update of |
| 352 |
|
offline_exf_seaice/input.dyn_jfnk) |
| 353 |
|
|
| 354 |
|
checkpoint65a (2014/07/27) |
| 355 |
|
o model/src: |
| 356 |
|
- Non-Lin Free-Surf in p/z coords: allows hFacW,S to be larger than |
| 357 |
|
surrounding hFacC=1 @ edge of a step with different kSurfC on either side |
| 358 |
|
(topo in p-coords, ice-shelf in z-coords); update output of experiments |
| 359 |
|
tutorial_global_oce_in_p and isomip (both AD and OpenAD output). |
| 360 |
|
o model/src: |
| 361 |
|
- collect momentum forcing tendency into local 2-D array (passed as argument |
| 362 |
|
to apply_forcing S/R); this simplifies mom. Forcing diagnostics and CD_CODE |
| 363 |
|
parts in timestep.F (without CD_CODE_NO_AB_MOMENTUM defined = the default); |
| 364 |
|
affects results at machine truncation level (e.g., if using OBCS_SPONGE). |
| 365 |
|
- collect T & S forcing tendency into local 2-D array (passed as argument to |
| 366 |
|
apply_forcing S/R); add 3-D diagnostics for temp & salt forcing tendency. |
| 367 |
|
affects results at machine truncation level (e.g., ocean: if using |
| 368 |
|
SHORTWAVE_HEATING ; atmos: if using FrictionHeating or (atm_Rq<>0) moist |
| 369 |
|
correction due to vertical advection). |
| 370 |
|
- update output of experiments: fizhi-cs-32x32x40 (13 digits), |
| 371 |
|
global_ocean.cs32x15 (fwd: icedyn, seaice, thsice, all 3 @ 11d; adm & tml: |
| 372 |
|
seaice_dynmix & thsice, fwd grd @ 3 & 8), hs94.1x64x5 (ad grd @ 13), |
| 373 |
|
obcs_ctrl (ad & fwd grd @ 12 & 7). |
| 374 |
|
o pkg/ptracers & diagnostics: |
| 375 |
|
- use ptracers (short) name (instead of long one) to make ptracers diagnostics |
| 376 |
|
title (to avoid some unexpected truncation); sort out ptracers diags units. |
| 377 |
|
- collect ptracer forcing tendency into local 2-D array (passed as argument |
| 378 |
|
to apply_forcing S/R); add 3-D diagnostics for ptracers forcing tendency. |
| 379 |
|
|
| 380 |
|
checkpoint65 (2014/07/18) |
| 381 |
|
o pkg/fizhi: |
| 382 |
|
- add parenthesis around fizhi tendencies in fizhi_tendency_apply.F: this |
| 383 |
|
affects results at machine truncation level. Update output of experiments |
| 384 |
|
fizhi-cs-32x32x40 (12 digits for cg2d) & fizhi-cs-aqualev20 (13 digits). |
| 385 |
|
o pkg/seaice: more clean up |
| 386 |
|
- rename TAF common block tapes to be more consistent and remove |
| 387 |
|
unnecessary duplicates |
| 388 |
|
- add store directives to remove more recomputations, but use smaller |
| 389 |
|
tapes (and adjust keys) when SEAICE_LSR_ADJOINT_ITER is undefined. |
| 390 |
|
The idea behind this flag is to reduce the memory footprint when the |
| 391 |
|
adjoint of the LSR is not required. As of now, defining the flag |
| 392 |
|
SEAICE_LSR_ADJOINT_ITER increases 4 common block tapes for 2D field by |
| 393 |
|
a factor of SOLV_MAX_FIXED (=500 by default in SEAICE_SIZE.h). |
| 394 |
|
For experiment offline_exf_seaice, this means on a linux box with gfortran |
| 395 |
|
nearly a factor of 10 (but keep in mind there is mostly seaice code in |
| 396 |
|
this experiment): |
| 397 |
|
> size mitgcmuv_ad |
| 398 |
|
text data bss dec hex |
| 399 |
|
5100659 1216 220458952 225560827 d71c8fb |
| 400 |
|
5339425 1200 1868783272 1874123897 6fb4dc79 (SEAICE_LSR_ADJOINT_ITER) |
| 401 |
|
but only a moderate increase of 36% for global_ocean.cs32x15: |
| 402 |
|
text data bss dec hex |
| 403 |
|
6695027 1648 1014578664 1021275339 3cdf6ccb |
| 404 |
|
6695203 1648 1382505320 1389202171 52cd8afb (SEAICE_LSR_ADJOINT_ITER) |
| 405 |
|
- note: there are still recomputations in global_ocean.cs32x15 and |
| 406 |
|
offline_exf_seaice and the gradient agreement changes (gets a |
| 407 |
|
little worse) for global_ocean.cs32x15 (-> update output_adm.seaice.txt) |
| 408 |
|
- in general, the AD gradients still are wrong |
| 409 |
|
o OpenAD |
| 410 |
|
- clean up code_oad/ directories somewhat by moving files |
| 411 |
|
dontCompile, dontTransform, keepOriginal to OAD_support/ |
| 412 |
|
o model/src: |
| 413 |
|
- using MOM fluxform and Non-Lin Free-Surf with momDissip_In_AB=F |
| 414 |
|
(not currently tested): add dissipation terms before NLFS rescaling of |
| 415 |
|
tendencies (previously done after). |
| 416 |
|
o pkg/diagnostics: |
| 417 |
|
- write stats-diags in ascii file with more digits (same as in monitor). |
| 418 |
|
o pkg/down_slope: |
| 419 |
|
- drop the bi,bj dimension of argument recip_hFac in S/R DWNSLP_APPLY; with |
| 420 |
|
NLFS (not tested), use new recip_hFac value in order to conserve tracer. |
| 421 |
|
o model/src: |
| 422 |
|
- new file "apply_forcing.F" containing all the code previously in |
| 423 |
|
external_forcing.F, but with new argument list: pass, as new argument, |
| 424 |
|
the current level tendency array to update (instead of a direct update |
| 425 |
|
of the common bloc array). Change the corresponding calls. |
| 426 |
|
- add CPP option USE_OLD_EXTERNAL_FORCING (default is undef) to use |
| 427 |
|
EXTERNAL_FORCING_U,V,T,S subroutines (for backward compatibility). |
| 428 |
|
o pkg/seaice/seaice_lsr, a little bit of clean up |
| 429 |
|
- rearrange some code blocks, so that now all calculations for |
| 430 |
|
setting up the right-hand-sides done within one single block |
| 431 |
|
(I find that easier to read and understand) |
| 432 |
|
- rearrange freedrift-code to reduce the number of ifdefs |
| 433 |
|
- adjust some indentations and comments |
| 434 |
|
|
| 435 |
|
checkpoint64z (2014/07/10) |
| 436 |
|
o model/src and several pkgs: |
| 437 |
|
- change argument list of all S/R called from external_forcing.F and |
| 438 |
|
called from ptracers_forcing.F (renamed to ptracers_apply_forcing.F) |
| 439 |
|
to pass, as argument, the current level tendency array to update |
| 440 |
|
(instead of a direct update of the common bloc array). |
| 441 |
|
- change also (in the same way) argument list of PTRACERS_APPLY_FORCING; |
| 442 |
|
- rename taueddy_external_forcing.f to taueddy_tendency_apply.F |
| 443 |
|
o pkg/seaice/seaice_lsr.F |
| 444 |
|
- always initialize local arrays in seaice_lsr_tridiagu/v |
| 445 |
|
- add more local tapes to seaice_lsr_tridiagu/v |
| 446 |
|
- move storing u/vice(:,:,bi,bj) out of seaice_lsr_tridiagu/v, but |
| 447 |
|
keep it in bi/bj loop; this seems to be essential |
| 448 |
|
- gradients are still wrong but only by 4-7 orders of magnitude |
| 449 |
|
instead of 15 orders of magnitude, lab_sea improves a little |
| 450 |
o pkg/seaice |
o pkg/seaice |
| 451 |
- remove unnecessary u/vTmp from subroutine call of |
- (pkg/autodiff) remove storing/restoring of seaiceMaskU/V that |
| 452 |
seaice_lsr_tridiagu/v |
generates unnecessary code in seaice_lsr_ad |
| 453 |
|
- add more store directives in seaice_lsr to avoid unnecessary code |
| 454 |
|
in seaice_lsr_ad |
| 455 |
|
- exclude some residual computations in seaice_lsr when |
| 456 |
|
ALLOW_AUTODIFF_TAMC is defined in order to avoid unnecessary code |
| 457 |
|
in seaice_lsr_ad |
| 458 |
|
- add more storing, a new tape (model/src/the_main_loop.F) and |
| 459 |
|
another key for SEAICE_LSR_VECTORIZE_ZEBRA (the local keys ilockey |
| 460 |
|
and klockey should be checked by a specialist) |
| 461 |
|
- modify ( define SEAICE_VECTORIZE_LSR and SEAICE_LSR_ADJOINT_ITER ) |
| 462 |
|
and update lab_sea after previous changes in pkg/seaice below |
| 463 |
|
o pkg/autodiff: |
| 464 |
|
- introduce useSmoothCorrel2DinAdMode, SEAICEapproxLevInAd, and |
| 465 |
|
viscFacInAd : run time parameters allowing for adjoint switches |
| 466 |
|
note : logic for useSmoothCorrel2DinAdMode is in ctrl_readparms.F |
| 467 |
|
o pkg/ecco: |
| 468 |
|
- introduce cost_gencost_boxmean.F that computes a box mean |
| 469 |
|
temperature (for use in adjoint sensitivity studies). |
| 470 |
|
o model/src/set_defaults.F : initialize viscFacAdj to 1. |
| 471 |
|
o pkg/mom_common/mom_calc_visc.F: |
| 472 |
|
- ifdef ALLOW_AUTODIFF then include viscFacAdj factor. |
| 473 |
|
o pkg/seaice/seaice_summary.F: |
| 474 |
|
- statement for SEAICEadjMODE now in autodiff_readparms.F |
| 475 |
|
o pkg/seaice: |
| 476 |
- remove some store directives and add new ones in an effort to get |
- remove some store directives and add new ones in an effort to get |
| 477 |
finally rid off the recomputation warnings. This is successful |
finally rid off the recomputation warnings. This is successful |
| 478 |
for SEAICE_VECTORIZE_LSR defined (i.e. no extensive recomputation |
when SEAICE_VECTORIZE_LSR ***and*** SEAICE_LSR_ADJOINT_ITER are |
| 479 |
warnings left), but there are still too many recomputations on the |
defined (i.e. no extensive recomputation warnings left), but there |
| 480 |
solver iteration level |
are still too many recomputations on the solver iteration level |
| 481 |
|
- define SEAICE_VECTORISZE_LSR in offline_exf_seaice/code_ad/SEAICE_OPTIONS.h |
| 482 |
- move definition of MPSEUDOTIMESTEPS into TAMC-block in |
- move definition of MPSEUDOTIMESTEPS into TAMC-block in |
| 483 |
SEAICE_SIZE.h |
SEAICE_SIZE.h |
| 484 |
- add a store directive in S/R seaice_calc_viscosities |
- add a store directive in S/R seaice_calc_viscosities |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch