| 4 |
Notes on tags used in MITgcmUV |
Notes on tags used in MITgcmUV |
| 5 |
============================== |
============================== |
| 6 |
|
|
| 7 |
|
o pkg/generic_advdiff (implicit_r): |
| 8 |
|
- fix implicit vertical advection conservation with AB and/or NonLin-FreeSurf |
| 9 |
|
(remove Tr*d/dz(w) in gad_implicit_r.F and add it in gad_calc_rhs.F); |
| 10 |
|
- fix implicit vertical diffusion or advection with NonLin FreeSurf |
| 11 |
|
(was using current recip_hFacC instead of future recip_hFacC): set future |
| 12 |
|
recip_hFac in thermodynamics.F and pass & use it in all vertical implicit |
| 13 |
|
solver S/R ; |
| 14 |
|
- fill diagnostics of vertical advective fluxes (computed from tendency) |
| 15 |
|
when using implicit vert. advection; |
| 16 |
|
- update output of exp that uses NonLin-FreeSurf & implicit vertical diffusion: |
| 17 |
|
global_ocean.90x40x15 (fwd+AD), global_ocean.cs32x15 (4 fwd +4 AD), |
| 18 |
|
tutorial_global_oce_in_p (fwd), tutorial_tracer_adjsens (AD) |
| 19 |
|
and cpl_aim+ocn (used in ocean); to be fixed: bottom_ctrl_5x5. |
| 20 |
|
o pkg/diagnostics: |
| 21 |
|
- add diags for T & S tendency which goes through Adams-Bashforth. |
| 22 |
|
|
| 23 |
|
checkpoint63f (2011/11/30) |
| 24 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 25 |
|
- join some loops to reduce number of if-statements |
| 26 |
|
- fix a bug in code for northern and southern boundaries. |
| 27 |
|
o pkg/seaice/seaice_init_varia.F |
| 28 |
|
- undo resetting UVM=0 that has slipped in unnoticed in r1.49 and |
| 29 |
|
caused zero ice-velocities for the B-grid code |
| 30 |
|
o pkg/seaice/seaice_init_fixed.F |
| 31 |
|
- fix a bug in the initialisation of the second metric terms |
| 32 |
|
k2AtC and k2AtZ: k2AtC was set to the value of k2AtZ and k2AtZ was 0. |
| 33 |
|
- this affects all seaice configurations with useCurviLinearGrid = .true. |
| 34 |
|
and SEAICEuseDynamics = .true. (default) and SEAICEuseMetricTerms |
| 35 |
|
= .true. (default) |
| 36 |
|
- the only verification experiment affected is global_ocean.cs32x15: |
| 37 |
|
icedyn, seaice, and seaice_dynmix (AD) |
| 38 |
|
o pkg/thsice/thsice_diagnostics_state.F |
| 39 |
|
- only for TARGET_NEC_SX: initialise all of tmpFld, so that overlap does |
| 40 |
|
not contain garbage that can lead to surprises in diagstats_calc.F |
| 41 |
|
o model/src: |
| 42 |
|
- move bi,bj loops inside INTEGR_CONTINUITY ; |
| 43 |
|
- call INTEGR_CONTINUITY directly from forward_step.F |
| 44 |
|
(previously called from momentum_correction_step.F) |
| 45 |
|
- call UPDATE_ETAH from integr_continuity.F and update initialise_varia.F, |
| 46 |
|
forward_step.F and pkg/ecco/the_main_loop.F |
| 47 |
|
o model/src/do_oceanic_phys.F: |
| 48 |
|
- reset addMass to zero only if useICEFRONT ; |
| 49 |
|
- separated k-loop for rhoInSitu calculation ; |
| 50 |
|
- add 2 diagnostics for wVel*delta^k(Rho) at constant pressure (= WdRHO_P) |
| 51 |
|
and at constant T,S (= WdRHOdP); |
| 52 |
|
NOTE: change diagnostics WRHOMASS : this is now simply the Vertical transport |
| 53 |
|
of In-Situ Density (Anomaly) (=wVel*rho^bar-k) (previously was Vertical |
| 54 |
|
transport of locally-referenced potential density); |
| 55 |
|
to recover old diag: (WRHOMASS)_old = (WRHOMASS)_new -1/2 * (WdRHOdP) |
| 56 |
|
o gluemnc: |
| 57 |
|
- replace ncrcat with ncks when adding variables to *.glob.nc |
| 58 |
|
- change the way variables without record dimensions are handled so that |
| 59 |
|
files that have variables with and without record variables can be glued: |
| 60 |
|
add a record dimension with a new unique name to be able to differentiate |
| 61 |
|
between variable with and without a-prior record dimensions. Remove |
| 62 |
|
this record dimension before adding the variable to the *.glob.nc file. |
| 63 |
|
This procedure automatically works also for grid.*.nc files that do not |
| 64 |
|
have any record dimension. |
| 65 |
|
o verification/cpl_aim+ocn: |
| 66 |
|
- generate new reference output on baudelaire (gfortran, mpich2) (previously |
| 67 |
|
from old aces-grid cluster, ao + ifort) and update 'run_cpl_test' script. |
| 68 |
|
o pkg/obcs/obcs_calc_stevens.F: |
| 69 |
|
- add code for northern and southern boundaries. |
| 70 |
|
- reorder some loops to save some operations and so that drFBar can be scalar |
| 71 |
|
o model/src: |
| 72 |
|
- re-arrange extrapolation calculation in Adams-Bashforth S/R (affects machine |
| 73 |
|
truncation) and add diagnostics for Adams-Bashforth tendency increment. |
| 74 |
|
- update test-exp. AD output: |
| 75 |
|
1D_ocean_ice_column, bottom_ctrl_5x5, lab_sea.noseaicedyn, obcs_ctrl; |
| 76 |
|
and FWD output: exp4 (x3), fizhi-cs-32x32x40, fizhi-cs-aqualev20, |
| 77 |
|
front_relax (x3), global_ocean.90x40x15 (x2), global_ocean.cs32x15 (x5), |
| 78 |
|
global_ocean_ebm, ideal_2D_oce, internal_wave, isomip (x3), lab_sea (x4), |
| 79 |
|
matrix_example, MLAdjust (x5), natl_box (x2), tutorial_advection_in_gyre, |
| 80 |
|
tutorial_global_oce_in_p, tutorial_global_oce_latlon and |
| 81 |
|
tutorial_plume_on_slope. |
| 82 |
|
o pkg/diagnostics/diagstats_calc.F: add special code for TARGET_NEC_SX |
| 83 |
|
that vectorises. This code uses 3 extra 2D fields, F90 array assignments |
| 84 |
|
and F90 intrinsic routines SUM, MINVAL, MAXVAL, but since TARGET_NEC_SX |
| 85 |
|
does not even come with an F77 compiler anymore, this should not be |
| 86 |
|
a limitation |
| 87 |
|
|
| 88 |
|
checkpoint63e (2011/11/06) |
| 89 |
|
o pkg/seaice adjoint of LSR: |
| 90 |
|
- substantially rework STORE dirs. |
| 91 |
|
- add new flag SEAICE_LSR_ADJOINT_ITER and parameter SOLV_MAX_FIXED |
| 92 |
|
this flag will do SOLV_MAX_ITERS but only store SOLV_MAX_FIXED fields |
| 93 |
|
and only perform SOLV_MAX_FIXED adjoint iters. |
| 94 |
|
If flag SEAICE_LSR_ADJOINT_ITER is undef-ined, the store in the iteration |
| 95 |
|
always goes to same record, meaning that the last forward field will be |
| 96 |
|
the one used in the adjoint - an approximation. |
| 97 |
|
- now produces non-zero LSR-related gradients, and acceptable gradients for |
| 98 |
|
An's zonal (x-z) test case (to be checked in) |
| 99 |
|
- lab_sea: produces acceptable gradients for lab_sea with forward/backward LSR |
| 100 |
|
(but these are screwed up by the thermodynamics in the first place); |
| 101 |
|
reduce from 4 to 3 timesteps to avoid t.d. issue as temporary solution; |
| 102 |
|
output_adm.txt also reflects changes to seaice_lsr |
| 103 |
|
- global_ocean.cs32x15: |
| 104 |
|
* the "default" input_ad.seaice has been re-defined to always exclude dynamics |
| 105 |
|
(output_adm.seaice.txt was updated) |
| 106 |
|
* new input_ad.seaice_dynmix tests a forward LSR / backward free-drift |
| 107 |
|
(output_adm.seaice_dynmix.txt) |
| 108 |
|
o test-exp. exp4+stevens: |
| 109 |
|
- switch off pTracers and nonHydrostatic (restart problems with NH); update output |
| 110 |
|
o pkg/seaice (lsr solver): |
| 111 |
|
- put coriolis term into FORCEX,Y (as in seaice_evp.F; previously in rhsU,V only); |
| 112 |
|
update output (change truncation) of FWD test exp lab_sea & global_ocean.cs32x15 |
| 113 |
|
- fix SEAICEuseFREEDRIFT for new OBCS version (ndef OBCS_UVICE_OLD) |
| 114 |
|
- new parameter "LSR_mixIniGuess" allows (if=2,4) to mix free-drift solution |
| 115 |
|
into initial guess for linearised solver; use weight ~ (1/err)^2,4. |
| 116 |
|
- compute (with new S/R) and print initial (+ free-driff sol. if available) |
| 117 |
|
and final residual of linearised system. |
| 118 |
|
o pkg/pp81: add diagnostics for vertical eddy viscosity and diffusivity |
| 119 |
|
(requires new subroutines pp81_init_fixed.F/pp81_diagnostics_init.F) |
| 120 |
|
o pkg/obcs: Stevens BCs (still only for east and west) |
| 121 |
|
- fix Stevens BCs by using intermediate velocities of previous |
| 122 |
|
time step as "baroclinic" contribution rather velocity of one grid cell |
| 123 |
|
inside the boundaries; more consistent but makes the entire treatment |
| 124 |
|
more complicated, requires new pickup files and two new S/Rs: |
| 125 |
|
obcs_copy_uv_n and obcs_save_uv_n |
| 126 |
|
keep old version with flag OBCS_STEVENS_USE_INTERIOR_VELOCITY |
| 127 |
|
(undefined by default) |
| 128 |
|
- silently move computation of some grid factors into separate loops to |
| 129 |
|
save some recomputations |
| 130 |
|
- add a hack for non-linear free surface |
| 131 |
|
- add a verification experiment to exp4 that tests this code |
| 132 |
|
o make gluemnc/xplodemnc work with (moron) non-GNU shell tools |
| 133 |
|
|
| 134 |
|
checkpoint63d (2011/10/25) |
| 135 |
|
o pkg/obcs + seaice-dynamics: |
| 136 |
|
- new implementation calls OBCS_APPLY_UVICE (in seaice_dynsolver.F) before |
| 137 |
|
solving for uIce,vIce and prevent SEAICE_LSR or SEAICE_EVP to modify OB |
| 138 |
|
values (consistent with an implicit method). |
| 139 |
|
- add option OBCS_UVICE_OLD (in OBCS_OPTIONS.h, defined by default) to |
| 140 |
|
return to older implementation (same results as before); note that none of |
| 141 |
|
the "experimental" OBCS_SEAICE options are implemented in the new version. |
| 142 |
|
- switch test exp. seaice_obcs to use new version (update output). |
| 143 |
|
o pkg/seaice: |
| 144 |
|
- add few stop (B-grid & CS-exch, B-grid & obcs, AUTODIFF & SEAICE_maskRHS) |
| 145 |
|
- add parenthesis in Water-Ice drag calculations (evp & lsr); |
| 146 |
|
- in seaice_lsr.F, simplify and fix AA3 setting in case sNx or sNy=1; |
| 147 |
|
and fix case SEAICE_waterDrag=0 (but unstable if no or little seaice) |
| 148 |
|
- update output of test exp lab_sea that uses evp or lsr (fwd+ad) |
| 149 |
|
and global_ocean.cs32x15 (icedyn & seaice fwd+ad). |
| 150 |
|
o pkg/layers: |
| 151 |
|
- Include potential density as new coordinate (Thanks to David Munday) |
| 152 |
|
o pkg/dic: |
| 153 |
|
- Remove subroutine CALC_PCO2_APPROX_CO3 from carbon_chem.F and add |
| 154 |
|
carbonate computation/output to CALC_PCO2_APPROX |
| 155 |
|
o pkg/generic_advdiff |
| 156 |
|
- make TAF generate code that vectorizes: |
| 157 |
|
gad_dst3fl_adv_*.F, gad_u3c4_impl_r.F |
| 158 |
|
o model/src: |
| 159 |
|
- improve vectorization also for adjoint code of |
| 160 |
|
solve_tridiagonal and solve_pentadiagonal. As this requires up to |
| 161 |
|
5 new 3D-fields, this code is only turned on for the combination of |
| 162 |
|
ALLOW_AUTODIFF_TAMC and TARGET_NEC_SX. Also remove error message |
| 163 |
|
for singular matrix check (only for TARGET_NEC_SX). |
| 164 |
|
- remove hard-wiring of CPP-flag ALLOW_SOLVERS_KLOOPINSIDE to |
| 165 |
|
ALLOW_AUTODIFF. This flag now needs to be set outside of |
| 166 |
|
solve_tri/pentadiagonal.F |
| 167 |
|
o pkg/exf: |
| 168 |
|
- fix previous modif in exf_readparms.F (revision 1.66: treatment of |
| 169 |
|
optional namelist EXF_NML_OBCS). |
| 170 |
|
- add many debug-print (to trace down where pkg/cal error msg comes from) |
| 171 |
|
o pkg/mom_vecinv/mom_vi_hdissip.F |
| 172 |
|
- rearrange loops so that vectorization is improved and in particular |
| 173 |
|
the adjoint routine vectorizes. The code is a little longer now, but I |
| 174 |
|
think easier to read. |
| 175 |
|
Note: CPP-flag MOM_VI_ORIGINAL_VISCA4 is not tested. |
| 176 |
|
o pkg/seaice: |
| 177 |
|
- allow to specify initial seaice velocity from files (uIceFile,vIceFile) |
| 178 |
|
o pkg/exch2: |
| 179 |
|
- alternative code (without tile x tile matrix) for cumulated (global) sum; |
| 180 |
|
used as default; keep using matrix version in adjustment.cs-32x32x1. |
| 181 |
|
o tools/build_options: |
| 182 |
|
- after merging some MPI and/or multi-threads specific optfiles so that |
| 183 |
|
the modified default optfile support both built (using genmake2 -mpi |
| 184 |
|
for the MPI built, using genmake2 -omp for OpenMP built), |
| 185 |
|
move now obsolete optfiles to tools/build_options/unsupported/ |
| 186 |
|
(add copy of email sent to support list in doc/optfiles_changes.txt) |
| 187 |
|
|
| 188 |
|
checkpoint63c (2011/09/28) |
| 189 |
|
o pkg/ebm: |
| 190 |
|
- fix ebm_zonalmean.F for several procs in Ydir (nPy > 1); update output of |
| 191 |
|
test exp. global_ocean_ebm (affects machine truncation, 12 digits for cg2d) |
| 192 |
|
o pkg/seaice (SItracer pickup) |
| 193 |
|
* Simple code for pickup of SItracer fields (#define ALLOW_SITRACER) |
| 194 |
|
To be done: |
| 195 |
|
- thorough testing of missing fields in S/R seaice_read_pickup |
| 196 |
|
- thorough matching between generic tracers and specific fields used |
| 197 |
|
(e.g. volume-weighted age, area-weighted age, salinity, ...) |
| 198 |
|
o pkg/grdchk: |
| 199 |
|
- all procs calculate and print finite-difference gradient (for testreport) |
| 200 |
|
- change description output used by testreport; |
| 201 |
|
- AD testing: also compare and report Finite-difference gradient; |
| 202 |
|
=> update all output_adm*.txt |
| 203 |
|
o test exp. global_ocean_ebm: |
| 204 |
|
- switch back useRealFreshWaterFlux (no problem anymore with run-off); |
| 205 |
|
and turn on exactConserve; update (fwd) output. |
| 206 |
|
o pkg/seaice (LSR): |
| 207 |
|
- print to STDOUT number of solver iterations at SEAICE_monFreq interval. |
| 208 |
|
- modify solver to deal cleanly with u/v switch at face edges (CS-grid): |
| 209 |
|
* identical results with non-CS topology (but save up to half of EXCH calls) |
| 210 |
|
* no much changes in cs-32 verification tests since no ice at face edges |
| 211 |
|
(differences due to convergence criteria, since nb of iterations changed) |
| 212 |
|
* expect some differences on lat-lon-cap grid. |
| 213 |
|
update FWD results of global_ocean.cs32x15 test exp. (icedyn & seaice) |
| 214 |
|
o pkg/exch2: |
| 215 |
|
- add new CPP option to disable Cumul-Sum matrix (to save storage when using |
| 216 |
|
many tiles); until alternative coding is added, just add a stop. |
| 217 |
|
o pkg/kpp: |
| 218 |
|
- move ptracer/salt correction to KPP diffusivity from calc_3d_diffusivity.F |
| 219 |
|
to S/R KPP_CALC_DIFF_PTR (+ add tracer-index to argument list). |
| 220 |
|
o optfiles: |
| 221 |
|
- merged few MPI specific (*+mpi*) and multi-threads specific (*+mth) optfiles |
| 222 |
|
into corresponding standard one, which now support different build: |
| 223 |
|
(when using "genmake2 -mpi" for MPI built, "genmake2 -omp" for OpenMP built) |
| 224 |
|
- add "darwin_amd64_gfortran" optfile (initially from Constantinos, tested by Gael) |
| 225 |
|
o pkg/obcs (seaice): |
| 226 |
|
- add missing EXCH for uIce,vIce after applying OBCS; |
| 227 |
|
- remove S/R EXF_SWAPFFIELDS_X/Y , disable S/R EXF_SET_OBCS_X/Y by adding |
| 228 |
|
argument = number of levels to S/R EXF_SWAPFFIELDS_XZ/YZ and S/R |
| 229 |
|
EXF_SET_OBCS_XZ/YZ ; update obcs_exf_load.F; |
| 230 |
|
- fix EXF_SET_OBCS_XZ/YZ for multi-threaded (assuming loaded arrays are shared) |
| 231 |
|
- verification exp. seaice_obcs: split domain in 2 tiles ; add SIZE.h_mpi |
| 232 |
|
and eedata.mth for MPI and mutlti-threaded testing. |
| 233 |
|
o pkg/flt: |
| 234 |
|
- make FLT EXCH working with multi-threads (and MPI + multi-threads); |
| 235 |
|
- use buffer for floats IO (trajectories & profiles); size set in FLT_SIZE.h; |
| 236 |
|
- fix pickup and trajectories + profiles output with multi-threads; |
| 237 |
|
- add parameter to select group of fields to write along trajectory and |
| 238 |
|
profile (default unchanged); |
| 239 |
|
- only call PORT_RAND* function when flt_noise <> 0; |
| 240 |
|
- add multi-threaded test for verification exp. flt_example. |
| 241 |
|
o eesupp/src: |
| 242 |
|
- fix S/R ALL_PROC_DIE for MPI+multi-threads. |
| 243 |
|
- USE_OMP_THREADING: check that number of threads (from eedata) matches |
| 244 |
|
actual number (from env.var. setting). |
| 245 |
|
o pkg/ebm: |
| 246 |
|
- fix multi-threading in ebm_area_t.F ; clean-up EBM.h header file. |
| 247 |
|
- add multi-threaded test for verification exp. global_ocean_ebm |
| 248 |
|
|
| 249 |
|
checkpoint63b (2011/08/29) |
| 250 |
|
o pkg/ebm: |
| 251 |
|
- fix sign of runoff; |
| 252 |
|
- update directly forcing fields (Qnet,EmPmR) to use standard |
| 253 |
|
external_forcing_surf.F (remove ebm_forcing_surf.F); |
| 254 |
|
- avoid loading forcing fields a 2nd time (1rst time from ini_forcing.F); |
| 255 |
|
- set either tauThetaClimRelax (in data) or tauThetaZonRelax (in data.ebm) |
| 256 |
|
and apply relaxation towards corresponding SST field (2-D map or ZonAver). |
| 257 |
|
- update global_ocean_ebm parameters file data and update output (fwd+ad). |
| 258 |
|
o verification/matrix_example: |
| 259 |
|
- split domain in 8 tiles (2x4); add SIZE.h_mpi and eedata.mth for |
| 260 |
|
MPI and mutlti-threaded testing. |
| 261 |
|
o pkg/matrix: |
| 262 |
|
- change name of S/R MATRIX_INIT to S/R MATRIX_INIT_VARIA ; |
| 263 |
|
- fix for multi-tiles (add bi,bj indices to exp/impMatrixCounter); |
| 264 |
|
- fix for multi-threaded (remove DATA statement); |
| 265 |
|
- use standard DIFFERENT_MULTIPLE function; |
| 266 |
|
- add MATRIX_OPTIONS.h |
| 267 |
|
o verification/matrix_example: |
| 268 |
|
To allow to split the domain in several tiles, change the domain size |
| 269 |
|
from 31x31 to 32x32 by adding 1 row (on Southern side) + 1 column (on |
| 270 |
|
Western side) of land points. |
| 271 |
|
o (*_)write_pickup: |
| 272 |
|
- fix few bugs in mypackage_read/write_pickup.F |
| 273 |
|
- in MDS_WR_METAFILES calls, replace "myTime" by a local copy into |
| 274 |
|
array of length 1 (was caught by compiler syntax-check). |
| 275 |
|
o pkg/diagnostics (velocity potential solver): |
| 276 |
|
- fix initialisation of main diagonal matrix (for overlap values) |
| 277 |
|
o tools/build_options: |
| 278 |
|
- towards single optfile for MPI and non-MPI built: merge few +mpi optfile |
| 279 |
|
into previously non MPI one (linux_am64 pgf77,open64,pathf90,ifort11) |
| 280 |
|
- linux_amd64_gfortran: merge +mpi_generic version into standard optfile: |
| 281 |
|
* move IEEE flags to DEVEL section; take IEEE flags from +mpi_generic ; |
| 282 |
|
* FAST case: for now, keep -O3 with ini_masks_etc.F in NOOPTFILES list; |
| 283 |
|
and use "-devel" testreport option for standard testing on baudelaire. |
| 284 |
|
o pkg/grdchk: |
| 285 |
|
- Assume that all gradient-check position are within the same tile |
| 286 |
|
corresponding to global indices (iGloTile,jGloTile) and that |
| 287 |
|
positions (i,j indices or nbeg) are local to this tile; |
| 288 |
|
- set tile local-indices and proc. number according to tile global-indices; |
| 289 |
|
- remove grdchkwhichproc from namelist (retired param); |
| 290 |
|
- send adjoint gradient to all procs so that all procs print it to STDOUT; |
| 291 |
|
- switch on MPI test for global_ocean.90x40x15 AD test experiment. |
| 292 |
|
o adding package bbl (Bottom Boundary Layer) |
| 293 |
|
description in MITgcm/pkg/bbl/bbl_description.tex |
| 294 |
|
example/test experiment in MITgcm_contrib/bbl |
| 295 |
|
o adjoint verifications |
| 296 |
|
- changed 5 experiments to multi-tiles |
| 297 |
|
* global_ocean.90x40x15 |
| 298 |
|
* obcs_ctrl |
| 299 |
|
* offline_exf_seaice |
| 300 |
|
* tutorial_dic_adjoffline |
| 301 |
|
* tutorial_tracer_adjsens |
| 302 |
|
changed reference output for those that crossed tile boundaries |
| 303 |
|
(changed choices of gradient check positions) |
| 304 |
|
- with same tiling, switch on MPI test for the last 4 (add SIZE.h_mpi) |
| 305 |
|
- temporary bug fix in grdchk_loc.F for obcs |
| 306 |
|
o genmake2 & testreport |
| 307 |
|
- add target "obj" (just for OBJFILES files) to Makefile; |
| 308 |
|
- add option to specify FEXTRAFLAGS on command line. |
| 309 |
|
o pkg/mypackage: |
| 310 |
|
- remove bi,bj arguments from argument list of S/R MYPACKAGE_CALC_RHS |
| 311 |
|
|
| 312 |
|
checkpoint63a (2011/08/02) |
| 313 |
|
o pkg/diagnostics (velocity potential): |
| 314 |
|
- fix velocity-potential calculation when using OBCS: balance net inflow |
| 315 |
|
at each level (new S/R OBCS_DIAG_BALANCE). |
| 316 |
|
- fix some of the problems with OBCS in stream-function calculation. |
| 317 |
|
o pkg/exf/exf_readparms.F |
| 318 |
|
- make treatment of optional namelists (EXF_NML_04, EXF_NML_SGRUNOFF, |
| 319 |
|
EXF_NML_OBCS) more consistent, so that you need not have these lists |
| 320 |
|
in data.exf when they are not used. |
| 321 |
|
o optim/optim_readdata.F: |
| 322 |
|
- add some output about obcs variables that might help debugging |
| 323 |
|
- add a check about nvarlength |
| 324 |
|
o pkg/ctrl: once again, fix computation of endrec in s/r ctrl_init_rec |
| 325 |
|
o pkg/diagnostics (velocity potential): |
| 326 |
|
- fix mask for OBCS (still problems in stream-function with OBCS); |
| 327 |
|
- add specific parameter (default = main code CG2D params) for solver; |
| 328 |
|
- in case of poor convergence, use solution corresponding to lowest residual. |
| 329 |
|
o pkg/seaice/seaice_growth.F: small changes that permit vectorizable |
| 330 |
|
adjoint code. In general statements like tmpscal=fld(i,j) are problematic |
| 331 |
|
and should be avoided where possible. |
| 332 |
|
o model/src (rStar): |
| 333 |
|
- include r* effect on reference-state (PhiRef) in totPhiHyd |
| 334 |
|
(so that it's really the potential anomaly at the cell center); |
| 335 |
|
affect solution only if z* with full pressure in EOS. |
| 336 |
|
- test-exp global_ocean.90x40x15: reduce viscA4 (was not stable) and |
| 337 |
|
update output (because of z* in totPhiHyd and viscA4 changes); |
| 338 |
|
- keep the previous diagnostics as "PHIHYDcR" (closer to potential anomaly |
| 339 |
|
@ constant r) until interpolation at constant r is implemented. |
| 340 |
|
o pkg/diagnostics |
| 341 |
|
- fix RCENTER diagnostics in case cell center is not at interface middle |
| 342 |
|
o add code for TEOS-10 (www.teos-10.org, McDougall et al. 2011). Use |
| 343 |
|
this eos with eosType = 'TEOS10', in data (PARM01). This eos implies |
| 344 |
|
that THETA and SALT are "conservative temperature" and "absolute |
| 345 |
|
salinity" |
| 346 |
|
o pkg/ctrl |
| 347 |
|
- fix computation of endrec in s/r ctrl_init_rec |
| 348 |
|
- ctrl_pack/unpack_*: remove unused variables and some obsolete code |
| 349 |
|
o pkg/seaice/seaice_growth.F |
| 350 |
|
- fix recomputation with FENTY_AREA_EXPANSION_CONTRACTION code, |
| 351 |
|
remove then obsolete STORE directives |
| 352 |
|
- fix STORE directives for tice and tices, so that only the |
| 353 |
|
appropriate part of the fields are stored (and not the entire |
| 354 |
|
field); update global_ocean.cs32x15.seaice AD output. |
| 355 |
|
- cosmetic changes: adjust CPP flags and indentation for better |
| 356 |
|
legibilty |
| 357 |
|
o pkg/autodiff: add mnc-output of adBottomDragFld (code contributed by |
| 358 |
|
Chris Wilson) |
| 359 |
|
o pkg/gmredi: |
| 360 |
|
Add Sub-Meso Eddies parameterisation from Baylor (for now, disabled with TAF), |
| 361 |
|
and test it in verification exp. "front_relax.bvp" (update output.bvp.txt) |
| 362 |
|
|
| 363 |
|
checkpoint63 (2011/07/11) |
| 364 |
|
o pkg/exch2: |
| 365 |
|
- rename+move: nTiles in W2_EXCH2_PARAMS.h --> exch2_nTiles in W2_EXCH2_TOPOLOGY.h |
| 366 |
|
- exch2 version of Cumul-Sum routine: S/R W2_SET_MAP_CUMSUM set up the |
| 367 |
|
(2*nTiles)x(nTiles) Cumul-Sum matrix and Master Proc collects all tiles X,Y |
| 368 |
|
increments, calculates Cumul-Sum @ tile origin and sends results to each tile. |
| 369 |
|
o pkg/diagnostics: |
| 370 |
|
- deal with pairs of post-processed diags which are computed together; in |
| 371 |
|
particular, re-order list of diags within 1 file to save 2nd computation. |
| 372 |
|
- add S/R to compute velocity stream-function (called after velocity-potential |
| 373 |
|
calculation) from divergence free transport -> new diagnostics "PsiVEL". |
| 374 |
|
- add parameter to select grid-point location where PsiVEL == 0. |
| 375 |
|
o eesupp/src: |
| 376 |
|
new S/R to calculate cumulated sum on tiled array, corner grid-cell location |
| 377 |
|
(specific S/R needed with exch2 topology - for now, just print an error msg) |
| 378 |
|
o pkg/shelfice |
| 379 |
|
- Implement friction velocity-dependent transfer coefficients following |
| 380 |
|
Holland and Jenkins, JPO, 1999 |
| 381 |
|
Original code by M. Losch with small modifs. |
| 382 |
|
Enable with CPP option SHI_ALLOW_GAMMAFRICT |
| 383 |
|
and runtime flag SHELFICEuseGammaFrict |
| 384 |
|
o verification lab_sea & global_ocean.cs32x15: |
| 385 |
|
- use tools/xmakedepend (instead of cyrus_makedepend, in genmake_local): |
| 386 |
|
does not miss some dependencies (but is slower) and also works with many files |
| 387 |
|
(default makedepend limitation for AD built). |
| 388 |
|
- use cyrus_makedepend in adjustment.128x64x1 (so that it still tested). |
| 389 |
|
o pkg/diagnostics: |
| 390 |
|
- add run-time parameter "useMissingValue" (def=False) to fill land-point |
| 391 |
|
(i.e., where mask=0) with MissingValue ; used only in MNC output file. |
| 392 |
|
This replaces CPP-option DIAGNOSTICS_MISSING_VALUE. |
| 393 |
|
- Extend the use of "missing_value" setting from data.diagnostics for the case |
| 394 |
|
of counter-diagnostics (where fraction-weight is zero). This applies both to |
| 395 |
|
MNC and MDS output files. |
| 396 |
|
o pkg/seaice/seaice_growth.F: |
| 397 |
|
- add 'a priori' cap of latent heat flux based on actual mass considerations |
| 398 |
|
when SEAICE_ADD_SUBLIMATION_TO_FWBUDGET is used in conjunction with the |
| 399 |
|
non-legacy seaice_solve4temp. |
| 400 |
|
- add diagnostic of the residual sublimation freshwater flux (the freshwater |
| 401 |
|
flux taken from the ocean if the total actual latent heat fluxes exceed |
| 402 |
|
the maximum) |
| 403 |
|
- remove the CPP switch around the *_FWbySublim unit change and move diagnostic |
| 404 |
|
fill for SIatmQnt, SIfwSubl, SIatmFW to the end of seaice_growth.F. |
| 405 |
|
- add diagnostic of the actual sublimation freshwater flux (that is 0. ifndef |
| 406 |
|
SEAICE_ADD_SUBLIMATION_TO_FWBUDGET) and of the latent heat flux (evap+sublim). |
| 407 |
|
- bug fix : frWtrAtm needs a_FWbySublim ifdef SEAICE_ADD_SUBLIMATION_TO_FWBUDGET. |
| 408 |
|
- bug fix : missing part to Martin's r_FWbySublim pathological case fix. |
| 409 |
|
o verification 1D_ocean_ice_column: |
| 410 |
|
made model domain truly 1x1x23 instead of 5x5x23 with only center cell (3,3,:) wet |
| 411 |
|
update results |
| 412 |
|
o pkg/diagnostics: |
| 413 |
|
- Implement setting of "Post-Processed" diagnostics (corresponding to gdiag(5)='P') |
| 414 |
|
which are not filled-up but computed from other diags ; In this case, the mate |
| 415 |
|
diag points to the primary (filled-up) diag to used for post processing. |
| 416 |
|
- Update Velocity-potential computation using post-processed diag framework. |
| 417 |
|
==> Change the ordering of fields and time-periods in MDS output file |
| 418 |
|
when using periodic averaging: now writes one time record with the full set |
| 419 |
|
of fields for this time period, then the next time reccord (it used to be |
| 420 |
|
one field with the full set of time records then the next field). |
| 421 |
|
Note: this is now similar to NetCDF (MNC) output file. <== |
| 422 |
|
|
| 423 |
|
checkpoint62z (2011/06/21) |
| 424 |
|
o adjoint monitor: |
| 425 |
|
- Add adjoint monitor output for packages exf, seaice |
| 426 |
|
and update relevant testreport output |
| 427 |
|
o pkg/seaice: |
| 428 |
|
- re-order diags inits so that they appear in order in available_diagnostics.log |
| 429 |
|
- added diags: hsnow thermo. rates of change, area preceeding ridiging process, |
| 430 |
|
area/heff/hsnow preceeding thermodynamic growth/melt. |
| 431 |
|
- modified diag: SIdA; output actual effect, as the description states. |
| 432 |
|
- modified description: SIqneti, SIqneto, SIuheff, SIvheff, SIdAb*, HSNOW. |
| 433 |
|
- retired redundant diags: SIyneg, SIfice, SIsnwice, SIthdgrh. |
| 434 |
|
(SIyneg->SIdHbOCN; SIfice->SIdHbATC; SIsnwice->SIdHbFLO; |
| 435 |
|
and SIthdgrh->SIdHbOCN+SIdHbATC+SIdHbATO) |
| 436 |
|
- modified diags (2) : switch all SIdA*, SIdH*, SIdS* from delta to rates. |
| 437 |
|
- added diagnostics for seaice generic tracers (SItr*). |
| 438 |
|
- added SItrUnit and SItrNameLong run time param (for SItr* diags). |
| 439 |
|
- in diag names, replaced 'PrTh' abbrev. of 'preceeding thermo' with 'PT'. |
| 440 |
|
I. Fenty: 18-Jun-2011: |
| 441 |
|
Minor changes to seaice package: |
| 442 |
|
1) Retired old variables (A22, SEAICE_lhsublim, areaMax, areaMin, hiceMin) and |
| 443 |
|
added some new ones (SEAICE_area_reg, SEAICE_hice_reg, SEAICE_area_floor) |
| 444 |
|
- Differentiated "regularization variables" from "floor variables" |
| 445 |
|
* areaMin became SEAICE_area_reg (old A22) and SEAICE_area_floor |
| 446 |
|
* hiceMin became SEAICE_hice_reg (old hiceMin) |
| 447 |
|
(with _reg meaning regularization variable) |
| 448 |
|
- SEAICE_lhSublim becomes lhSublim, the sum of SEAICE_lhEvap and SEAICE_lhFusion |
| 449 |
|
so as to ensure energy conservation when going between phases |
| 450 |
|
- A22 was not used anywhere |
| 451 |
|
2) Changed regularization procedure for heffActual and hsnowActual to ensure |
| 452 |
|
well-boundedness and smooth adjoint in seaice_growth.F |
| 453 |
|
3) Fixed a bug where seaice_solve4temp would not recognize ice-free grid cells |
| 454 |
|
because the old regularization always set heffActual >= 0.05 cm |
| 455 |
|
4) Changed the model so that the default behavior is to put a small (10^-5) "floor" |
| 456 |
|
on AREA when HEFF > 0. |
| 457 |
|
- went from requiring ALLOW_PRECLUDE_INFINITESIMAL_AREA to be defined to |
| 458 |
|
requiring that DISABLE_AREA_FLOOR *not* be defined |
| 459 |
|
Affected verifications: |
| 460 |
|
- 1D_ocean_ice_column (output.txt output_adm.txt) |
| 461 |
|
- global_ocean.cs32x15 (output.seaice.txt output_adm.seaice.txt) |
| 462 |
|
o pkg/diagnostics: |
| 463 |
|
- move MNC code from diagnostics_out.F into new diagnostics_mnc_out.F (2 S/R). |
| 464 |
|
- rename S/R GETDIAG to DIAGNOSTICS_GET_DIAG and change type of 1rst argument |
| 465 |
|
(was _RL, now integer) with option = 0 to retrieve all levels. |
| 466 |
|
- add pieces of code to compute velocity potential at each level (new diagnostics |
| 467 |
|
PhiVEL, works only when UVELMASS & VVELMASS are also turned on); |
| 468 |
|
for now, using same params as CG2D (target-resisual, max Nb of iter ...). |
| 469 |
|
- fix few issues with counter diagnostics in diagnostics_setdiag.F & |
| 470 |
|
diagstats_setdiag.F (if diagnostic counter is itself a counter diag) |
| 471 |
|
and in diagnostics_fract_fill.F (do not need a valid pointer for the |
| 472 |
|
diagnostics counter-mate); check that definition of counter-diagnostic |
| 473 |
|
includes a valid counter-mate (in diagnostics_set_levels.F). |
| 474 |
|
o model/src (rStar): |
| 475 |
|
- add rStar scaling factor in diags_phi_hyd.F (similar to calc_grad_phi_hyd.F); |
| 476 |
|
affect solution only if z* with full pressure in EOS; |
| 477 |
|
update output of test-exp global_ocean.90x40x15. |
| 478 |
|
o pkg/seaice: |
| 479 |
|
- introduce siEps=1e-5 parameter |
| 480 |
|
- use areaMax in AREA update (part 4), consistent with ridging step (part 2.5). |
| 481 |
|
- re-organize SEAICE_ADD_SUBLIMATION_TO_FWBUDGET code. |
| 482 |
|
- introduce ALLOW_SITRACER and seaice_tracer_phys.F to handle generic seaice tracer. |
| 483 |
|
For now it covers, and was tested for, ice salinity and age (attached to HEFF), |
| 484 |
|
as well as ice cover age and ridging index (attached to AREA). |
| 485 |
|
For now the run time parameters (in data.seaice/SEAICE_PARM03) are |
| 486 |
|
SItrName (e.g. 'age') and SItrMate ('HEFF', which is the default, or 'AREA'). |
| 487 |
|
Up to SItrMaxNum=3 tracers can be used simultaneously. |
| 488 |
|
o pkg/salt_plume: |
| 489 |
|
-introduce SPsalFRAC run time parameter that sets the fraction of the |
| 490 |
|
salt by-product of ice growth (SPsalFRAC*(1-SIsalFRAC)*salt typically) |
| 491 |
|
that gets vertically redistributed (fluxed down) by pkg/salt_plume. |
| 492 |
|
o model debug options: |
| 493 |
|
- Switch reading of debugMode from S/R INI_PARMS (parameter file "data", stored |
| 494 |
|
in PARAMS.h) to S/R EESET_PARMS (parameter file "eedata", stored in EEPARAMS.h). |
| 495 |
|
- Refine debug-msg printing selection (3 new levels): |
| 496 |
|
debugMode : controls printing of debug messages (sequence of S/R calls). |
| 497 |
|
debugLevel : controls printing of algorithm-relevant auxiliary/debug messages |
| 498 |
|
debLevZero = 0 ; /* level of disabled aux. msg printing */ |
| 499 |
|
debLevA = 1 ; /* level of minimum aux. msg printing */ |
| 500 |
|
debLevB = 2 ; /* level of low aux. print (report read-file opening)*/ |
| 501 |
|
debLevC = 3 ; /* level of moderate debug prt (most pkgs debug msg) */ |
| 502 |
|
debLevD = 4 ; /* level of enhanced debug prt (add DEBUG_STATS prt) */ |
| 503 |
|
debLevE = 5 ; /* level of extensive debug printing */ |
| 504 |
|
New debugLevel default: with default debugMode value (=F), |
| 505 |
|
= 2 (debLevB) or = 1 (debLevA) in case ALLOW_AUTODIFF is defined.; |
| 506 |
|
and if debugMode=T, default debugLevel = 4 (debLevD). |
| 507 |
|
Relation with previous settings: |
| 508 |
|
debLevB (=2) corresponds to former debLevA (=1) |
| 509 |
|
debLevD (=4) corresponds to former debLevB (=2) |
| 510 |
|
Note: |
| 511 |
|
a) if debugLevel=0, skip WRITE_GRID call when nIter0 > 0 (same as before); |
| 512 |
|
b) default debugLevel=1 is convenient in AD runs (avoid many file opening msgs); |
| 513 |
|
to recover previous default, set debugLevel=2 (e.g. AD-test hs94.1x64x5) |
| 514 |
|
- Add new parameter (printResidualFreq, read from PARM02 namelist) to print |
| 515 |
|
detailed CG solvers convergence; off (=0) by default, except if debugLevel=5. |
| 516 |
|
o pkg/obcs: |
| 517 |
|
- change OBCSfixTopo default from True to False (should not change the results); |
| 518 |
|
keep OBCSfixTopo=T in verification-exp. seaice_obcs. |
| 519 |
|
o pkg/thsice: |
| 520 |
|
- fix bug in thsice_calc_thickn.F (was introduced in version 1.18) in |
| 521 |
|
2nd layer seaice sublimation (unlikely to happen) |
| 522 |
|
- use Interior mask for OBCS in thsice_advection.F (similar to what is |
| 523 |
|
done in gad_advection & seaice_advection). |
| 524 |
|
o adjoint: |
| 525 |
|
bug fix spotted by Gael Forget: |
| 526 |
|
seaice_advection and thsice_advection still had |
| 527 |
|
legacy CPP options to avoid CS corner updates for adjoint |
| 528 |
|
o pkg/seaice: |
| 529 |
|
=> Change some of the defaults (2011/05/29): |
| 530 |
|
- change SEAICEuseFluxForm default (from False to True) |
| 531 |
|
- change DIFF1 default (from 0.004 m/s to 0. m/s) |
| 532 |
|
And print warnings if DIFF1 is not set in data.seaice and centered |
| 533 |
|
avection scheme is used without any diffusion. |
| 534 |
|
also: |
| 535 |
|
- fix seaice_diffusion calls in default AdvScheme part of seaice_advdiff.F; |
| 536 |
|
- set SEAICEdiffKh[] default in the same way as SEAICEadvSch[] |
| 537 |
|
- stop if DIFF1<>0 with SEAICEadvScheme <> 2, if DIFF1<>0 with any |
| 538 |
|
other non-zero SEAICEdiffKh[] diffusivity, if SEAICEadvSalt=T with |
| 539 |
|
#undef SEAICE_VARIABLE_SALINITY, if SEAICEadvAge=T with #undef SEAICE_AGE. |
| 540 |
|
update results of test exp.: |
| 541 |
|
lab_sea: output.fd (switch to AdvScheme=33 with diffKh=20) |
| 542 |
|
output.hb87, output_adm.evp (SEAICEuseFluxForm=T and diffKh=200) |
| 543 |
|
output_adm.noseaicedyn (SEAICEuseFluxForm=T) |
| 544 |
|
offline_exf_seaice: output.seaicetd, output_adm (SEAICEuseFluxForm=T) |
| 545 |
|
seaice_obcs: output (SEAICEuseFluxForm=T) |
| 546 |
|
and prescribe old default for SEAICEuseFluxForm (=F) and DIFF1 (=0.004) |
| 547 |
|
for standard fwd & AD lab_sea tests (to keep the same output). |
| 548 |
|
o pkg/seaice/seaice_growth.F: |
| 549 |
|
- use Ian Fenty's capping formulas for actual ice |
| 550 |
|
thickness thoughout EVOLUTION branch. |
| 551 |
|
- put treatment pathological case #2) in CPP brackets |
| 552 |
|
(ALLOW_AVOID_INFINITESIMAL_AREA, undef by default). |
| 553 |
|
- update global_ocean.cs32x15 and 1D_ocean_ice_colum results accordingly. |
| 554 |
|
o pkg/seaice: |
| 555 |
|
- seaice_diffusion.F : remove the min(DX,DY) factor permanently; |
| 556 |
|
pass the Laplacian diffusivity (in m^2/s) diffKh as a parameter; |
| 557 |
|
also pass fac as a param, which can be 1. (to update the tendency |
| 558 |
|
field) or the time step (to update the field itself). |
| 559 |
|
- seaice_advdiff.F: for multidim, call seaice_diffusion with |
| 560 |
|
e.g. SEAICEdiffKhHeff and with fac=1; for single-dim, call |
| 561 |
|
seaice_diffusion with e.g. SEAICEdiffKhHeff and with fac=time step. |
| 562 |
|
- SEAICE_PARAMS.h, seaice_readparms.F, seaice_check.F : |
| 563 |
|
hooks to handle SEAICEdiffKhHeff, SEAICEdiffKhArea, etc. |
| 564 |
|
o pkg/seaice: |
| 565 |
|
diffusion with centered advection scheme (diffus.F & advect.F): |
| 566 |
|
- simplify S/R DIFFUS (put deltaT & DIFF1 factor outside, move EXCH outside) |
| 567 |
|
to just compute the laplacian of input-field. |
| 568 |
|
- unroll k loop (harmonic,biharmonic diff) in advect.F to save 1 exch call. |
| 569 |
|
- fix flux-form version in diffus.F to conserve tracer. |
| 570 |
|
update output of lab_sea.fd & lab_sea.hb87 (1rst set of modif affects |
| 571 |
|
machine truncation) and lab_sea.salt_plume (conservative flux-form modif) |
| 572 |
|
|
| 573 |
|
checkpoint62y (2011/05/26) |
| 574 |
|
o pkg/seaice: |
| 575 |
|
- seaice_growth.F : in EVOLUTION branch, always include |
| 576 |
|
a_QSWbyATM_cover in qnet (as it should be). |
| 577 |
|
- verification/global_ocean.cs32x15 : update results accordingly |
| 578 |
|
(output.seaice.txt output_adm.seaice.txt). |
| 579 |
|
o pkg/seaice + obcs: |
| 580 |
|
- use maskInW & maskInS in multi-dim advection and biharmonic diffusion: |
| 581 |
|
equivalent of assuming no tracer gradient outside the OB region. |
| 582 |
|
update output of seaice_obcs (uses DIFF1 <>0 => biharmonic diffusion) |
| 583 |
|
- remove calls to OBCS_COPY_TRACER after EXCH calls (no longer needed |
| 584 |
|
after changes above); |
| 585 |
|
- obcs+seaice cleaning: apply seaice-tracer OB values to tracer field |
| 586 |
|
only at OB location (instead of over a band of OLx width). |
| 587 |
|
o pkg/seaice: |
| 588 |
|
- fix wrong indices in old (non Flux-Form) diffusion default S/R diffus.F |
| 589 |
|
(dxG(I+1, ...) changed to dxG(I, ...), no impact on Lat-Lon grid) |
| 590 |
|
o pkg/obcs: |
| 591 |
|
- split header file "OBCS.h" into 4 separated files: |
| 592 |
|
OBCS_PARAMS.h, OBCS_GRID.h, OBCS_FIELDS.h & OBCS_SEAICE.h |
| 593 |
|
Note: OBCS_PARAMS.h & OBCS_GRID.h can be included without OBCS_OPTIONS.h |
| 594 |
|
(contain no conditional statement which depends on OBCS options). |
| 595 |
|
- move "useOBCSYearlyFields" from "data.obcs" (hold in OBCS_PARAMS.h) |
| 596 |
|
to parameter file "data.exf", namelist EXF_NML_OBCS (in EXF_PARAM.h). |
| 597 |
|
o ctrl, cost, grdchk & autodiff pkgs: |
| 598 |
|
- make options file more standard (like other {PKG}_OPTIONS.h file but |
| 599 |
|
with AD_CONFIG.h); clean-up some of the included header files. |
| 600 |
o pkg/obcs: |
o pkg/obcs: |
| 601 |
- do not mask tracer when applying OB (tracer == 0 could generate problems) |
- do not mask tracer when applying OB (tracer == 0 could generate problems) |
| 602 |
- apply tracer OB values to tracer field only at OB location (instead of |
- apply tracer OB values to tracer field only at OB location (instead of |
Parent Directory
| 
Revision Log
| 
Revision Graph
| 
Patch